2f6e6a635b
Merge pull request #694 from a5-stable/specify-concurrent-version
...
Specify the version of concurrent-ruby due to CI failure
2025-02-12 11:10:41 -05:00
4f1593ca2e
specify concurrent version for CI failure in Logger
2025-02-12 10:47:26 +09:00
e8e0bb1ebb
Merge pull request #691 from kbrock/bin_setup
...
bin/console for testing
2024-10-23 20:14:57 -04:00
9ea121d125
bin/console for testing
2024-10-23 20:13:31 -04:00
4d267887f4
Merge pull request #690 from kbrock/test_chatter
...
reduce test chatter
2024-10-23 20:10:02 -04:00
5bcd89c061
require logger
2024-10-23 20:07:08 -04:00
9ed9d59078
reduce test chatter
2024-10-23 19:58:37 -04:00
6cc93989c0
Merge pull request #688 from kbrock/cops
...
rubocop fixes
2024-10-23 19:39:45 -04:00
98d831b865
rubocop.yml
2024-10-23 19:33:58 -04:00
333714cc27
rubocop spacing
2024-10-23 19:33:58 -04:00
b4f288a7e3
rubocop methods
2024-10-23 19:33:57 -04:00
cddecd1e42
drop extra self
2024-10-23 19:31:52 -04:00
5e65618739
method parens
2024-10-23 19:31:52 -04:00
6a3b3fb3a5
use Raise exception, message (vs Raise exception.new()
2024-10-23 19:31:52 -04:00
faf9029af1
add fronzen string comment
2024-10-23 19:31:51 -04:00
78d63a8e10
Merge pull request #670 from kbrock/virtual_depth
...
Add virtual depth column support
2024-10-23 19:31:21 -04:00
541c167938
Add support for virtual depth column
...
still need to consider whether to keep depth_cache_column as deprecated
2024-10-22 19:19:02 -04:00
4dda866e0b
remove duplication for before_depth scope and friends
2024-10-22 18:50:24 -04:00
fe8c2ce207
Extract format module extract
2024-10-22 18:50:23 -04:00
7176d19715
extract ancestry_depth_sql to module methods
...
want to call these from tests
2024-10-22 18:20:01 -04:00
8a4e7c0499
Merge pull request #687 from kbrock/ruby3.3
...
Test ruby 7.2
2024-10-22 17:26:57 -04:00
5129762631
Test ruby 7.2
2024-10-22 16:55:40 -04:00
404c5141e7
Merge pull request #686 from digitalfrost/patch-1
...
Make Supported Rails versions section of README easier to read
2024-10-22 16:36:32 -04:00
07336a7a65
Make supported Rails versions easier to read
...
Add double space at end of line to force line break.
So that the independent clause about Rails 5.2 with 'update_strategy... is shown on a new line...
2024-10-18 17:46:19 +02:00
d613f00c2c
Merge pull request #683 from fkmy/fix-typo-in-readme
...
Fix typo in README
2024-08-21 13:14:16 -04:00
80abe3c566
Fix typo in README
2024-08-01 10:57:05 +09:00
e1c0f355a5
Merge pull request #680 from instrumentl/in_subtree_of
...
add in_subtree_of? helper function, for symmetry
2024-06-14 16:01:50 -04:00
b594e99ac0
add in_subtree_of? helper function, for symmetry
2024-06-12 16:40:47 -07:00
498638e6f1
Merge pull request #681 from kbrock/sqlite_tests
...
Fix sqlite3 dependency
2024-06-12 19:26:01 -04:00
8cb59e6aed
Fix local sqlite3 build
...
Main change was to sqlite3. The 2.0 driver broke things
Locally, was having trouble compiling mysql2,
so hardc oded a version that is working
2024-06-12 19:18:03 -04:00
d2e2f2a7fa
Merge pull request #678 from ytjmt/fix-readme
...
docs: fix README
2024-02-29 11:26:14 -05:00
2e7a5304e0
docs: fix README
...
- fix suggested collation for MySQL field
- s/runnnig/running
- s/Mysql/MySQL/
2024-02-29 00:15:36 +09:00
c2df44cc8b
Merge pull request #677 from kbrock/rails_71
...
add tests for 7.1 and bump versions
2024-01-03 09:55:44 -05:00
9e6f653ba6
add tests for 7.1 and bump versions
2023-12-12 12:00:58 -05:00
9dab81f508
Merge pull request #674 from stefankroes/dependabot/github_actions/actions/checkout-4
...
Bump actions/checkout from 3 to 4
2023-09-26 10:59:15 -04:00
1613ac2463
Merge pull request #675 from ken3ypa/fix-typo-in-readme
...
Fix typo in README
2023-09-26 10:58:54 -04:00
99620d8675
fix typo in readme
2023-09-08 21:30:40 +09:00
a61da6c4e0
Bump actions/checkout from 3 to 4
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v3...v4 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-09-04 13:19:35 +00:00
af0d66dd25
Merge pull request #672 from ericgpks/fix/change_image_untransparent
...
change images on README to opaque
2023-08-28 17:28:17 -04:00
25dd26e8a8
fix: change images to untransparents
2023-08-27 22:04:47 +09:00
c7f49dddfd
Merge pull request #671 from kbrock/orphan_strategy_leafs_first_test
...
test orphan_strategy: :destroy deletes leafs first
2023-07-18 07:35:59 -04:00
f1b8d95834
test orphan_strategy: :destroy deletes leafs first
...
validates https://github.com/stefankroes/ancestry/pull/635
2023-07-17 18:14:03 -04:00
5c637482f3
Merge pull request #669 from kbrock/fix_unique_warning_test
...
fix uniqueness warning in mysql 6.0 tests
2023-07-13 15:04:44 -04:00
08539c5ac5
test only: fix uniqueness warning
...
This test on mysql rails 6.0 was throwing the following warning:
DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1
2023-07-13 10:31:35 -04:00
c08b07dcb0
Merge pull request #658 from kbrock/extensible_orphan_strategy
...
Extensible orphan_strategy
2023-07-13 09:48:17 -04:00
753013a1bb
Introduce orphan_strategy none
...
Many people override apply_orphan_strategy and either leave it blank or call custom methods from there.
Introducing `orphan_strategy: :none` to allows developers to skip default orphan handling.
From here a developer can add `before_destroy` with what ever logic is desired.
It is possible to introduce a custom orphan strategy with a mixin/concern,
but it doesn't seem to save any code and is not the best interface with too many nuances.
Leaving in the code for now but not promoting to a supported feature yet.
2023-07-13 09:40:10 -04:00
cb9635cc3a
docs: Move (default) values to the end of the line
...
also tried for some consistency in messaging around attributes
2023-07-13 09:33:57 -04:00
22c199152d
Merge pull request #668 from kbrock/rebuild-counter-cache
...
Fix Rebuild counter cache
2023-07-13 09:15:18 -04:00
3e25711617
changelog entries
2023-07-13 08:57:40 -04:00
d196dd4b80
fix: cast to char in child_ancestry_sql / rebuild_counter_cache
...
Before
======
We were casting to a fixed length char field. This can truncate parts of the path
After
=====
Using the conversion built into concat, so no need to CAST.
MySQL works best with CHAR
Postgresql works better with VARCHAR
2023-07-13 00:02:00 -04:00
Keenan Brock
a5-stable
digitalfrost
fkmy
James Brown
ytjmt
Kensuke Yanase
dependabot[bot]
Eriko Sugiyama
Ya-Rong, Teng