Minor changes (format, remove unused/unnecessary vars/keywords)

src/app/ui/dock.cpp

@@ -110,7 +110,7 @@ Dock::DropzonePlaceholder::DropzonePlaceholder(Widget* dragWidget, const gfx::Po
   display()->addLayer(m_floatingUILayer);
 }
 
-inline Dock::DropzonePlaceholder::~DropzonePlaceholder()
+Dock::DropzonePlaceholder::~DropzonePlaceholder()
 {
   display()->removeLayer(m_floatingUILayer);
 }
@@ -570,7 +570,6 @@ bool Dock::onProcessMessage(ui::Message* msg)
     case kMouseUpMessage: {
       if (hasCapture()) {
         releaseMouse();
-        const auto* mouseMessage = static_cast<MouseMessage*>(msg);
 
         if (m_dropzonePlaceholder && m_dropzonePlaceholder->parent()) {
           // Always undock the dropzone placeholder to avoid dangling sizes.
@@ -586,6 +585,7 @@ bool Dock::onProcessMessage(ui::Message* msg)
 
           assert(dockableWidget && widgetDock);
 
+          const auto* mouseMessage = static_cast<MouseMessage*>(msg);
           if (mouseMessage->right() && !m_dragging) {
             Menu menu;
             MenuItem left(Strings::dock_left());
@@ -791,15 +791,17 @@ void Dock::forEachSide(gfx::Rect bounds,
 
 void Dock::redockWidget(app::Dock* widgetDock, ui::Widget* dockableWidget, const int side)
 {
+  gfx::Size size;
+
+  if (dockableWidget->id() == "timeline") {
     const gfx::Rect workspaceBounds = widgetDock->bounds();
 
-  gfx::Size size;
-  if (dockableWidget->id() == "timeline") {
     size.w = 64;
     size.h = 64;
-    auto timelineSplitterPos =
+    const auto timelineSplitterPos =
       get_config_double(kLegacyLayoutMainWindowSection, kLegacyLayoutTimelineSplitter, 75.0) /
       100.0;
+
     auto pos = gen::TimelinePosition::LEFT;
     size.w = (workspaceBounds.w * (1.0 - timelineSplitterPos)) / guiscale();
 

src/app/ui/dock.h

@@ -29,8 +29,9 @@ public:
   class DropzonePlaceholder final : public Widget,
                                     public Dockable {
   public:
-    explicit DropzonePlaceholder(Widget* dragWidget, const gfx::Point& mousePosition);
+    DropzonePlaceholder(Widget* dragWidget, const gfx::Point& mousePosition);
     ~DropzonePlaceholder() override;
+
     void setGhostPosition(const gfx::Point& position) const;
 
   private:

src/app/ui/layout.cpp

@@ -35,7 +35,7 @@ static void save_dock_layout(XMLElement* elem, const Dock* dock)
 {
   for (const auto* child : dock->children()) {
     const int side = dock->whichSideChildIsDocked(child);
-    const gfx::Size& size = dock->getUserDefinedSizeAtSide(side);
+    const gfx::Size size = dock->getUserDefinedSizeAtSide(side);
 
     std::string sideStr;
     switch (side) {

src/app/ui/main_window.cpp

@@ -731,9 +731,10 @@ void MainWindow::configureWorkspaceLayout()
   m_contextBar->setVisible(isDoc && (m_mode == NormalMode || m_mode == ContextBarAndTimelineMode));
 
   // Configure timeline
-  if (m_timeline && m_timeline->parent())
+  if (m_timeline && m_timeline->parent()) {
     m_timelineResizeConn = dynamic_cast<Dock*>(m_timeline->parent())
                              ->Resize.connect(&MainWindow::saveTimelineConfiguration, this);
+  }
 
   m_timeline->setVisible(isDoc && (m_mode == NormalMode || m_mode == ContextBarAndTimelineMode) &&
                          pref.general.visibleTimeline());