From cdd955441a3f5d450a5a629f6ee035d0ceedd02f Mon Sep 17 00:00:00 2001 From: David Capello Date: Thu, 3 Dec 2015 21:50:05 -0300 Subject: [PATCH] Rename PreferredSize -> SizeHint --- src/app/commands/cmd_export_sprite_sheet.cpp | 2 +- src/app/commands/cmd_keyboard_shortcuts.cpp | 6 +- .../commands/filters/color_curve_editor.cpp | 8 +-- src/app/commands/filters/color_curve_editor.h | 2 +- src/app/ui/app_menuitem.cpp | 6 +- src/app/ui/app_menuitem.h | 2 +- src/app/ui/button_set.cpp | 6 +- src/app/ui/button_set.h | 2 +- src/app/ui/color_bar.cpp | 4 +- src/app/ui/color_button.cpp | 8 +-- src/app/ui/color_button.h | 2 +- src/app/ui/color_selector.cpp | 2 +- src/app/ui/color_sliders.cpp | 6 +- src/app/ui/color_sliders.h | 2 +- src/app/ui/color_spectrum.cpp | 6 +- src/app/ui/color_spectrum.h | 2 +- src/app/ui/color_wheel.cpp | 8 +-- src/app/ui/color_wheel.h | 2 +- src/app/ui/context_bar.cpp | 20 +++--- src/app/ui/context_bar.h | 2 +- src/app/ui/data_recovery_view.cpp | 12 ++-- src/app/ui/editor/editor.cpp | 4 +- src/app/ui/editor/editor.h | 2 +- src/app/ui/file_list.cpp | 4 +- src/app/ui/file_list.h | 2 +- src/app/ui/font_popup.cpp | 10 +-- src/app/ui/home_view.cpp | 2 +- src/app/ui/icon_button.cpp | 6 +- src/app/ui/icon_button.h | 2 +- src/app/ui/main_window.cpp | 2 +- src/app/ui/news_listbox.cpp | 14 ++-- src/app/ui/notifications.cpp | 8 +-- src/app/ui/notifications.h | 2 +- src/app/ui/palette_view.cpp | 6 +- src/app/ui/palette_view.h | 2 +- src/app/ui/palettes_listbox.cpp | 4 +- src/app/ui/palettes_listbox.h | 2 +- src/app/ui/recent_listbox.cpp | 12 ++-- src/app/ui/resources_listbox.cpp | 12 ++-- src/app/ui/resources_listbox.h | 4 +- src/app/ui/search_entry.cpp | 10 +-- src/app/ui/search_entry.h | 2 +- src/app/ui/skin/style.cpp | 6 +- src/app/ui/skin/style.h | 4 +- src/app/ui/status_bar.cpp | 10 +-- src/app/ui/status_bar.h | 2 +- src/app/ui/styled_button.cpp | 8 +-- src/app/ui/styled_button.h | 2 +- src/app/ui/tabs.cpp | 4 +- src/app/ui/tabs.h | 2 +- src/app/ui/timeline.cpp | 6 +- src/app/ui/timeline.h | 2 +- src/app/ui/toolbar.cpp | 10 +-- src/app/ui/toolbar.h | 2 +- src/app/widget_loader.cpp | 2 +- src/ui/CMakeLists.txt | 2 +- src/ui/box.cpp | 12 ++-- src/ui/box.h | 2 +- src/ui/button.cpp | 8 +-- src/ui/button.h | 2 +- src/ui/combobox.cpp | 10 +-- src/ui/combobox.h | 2 +- src/ui/entry.cpp | 6 +- src/ui/entry.h | 2 +- src/ui/grid.cpp | 10 +-- src/ui/grid.h | 2 +- src/ui/grid_ui_tests.cpp | 16 ++--- src/ui/image_view.cpp | 6 +- src/ui/image_view.h | 2 +- src/ui/int_entry.cpp | 8 +-- src/ui/int_entry.h | 2 +- src/ui/label.cpp | 6 +- src/ui/label.h | 2 +- src/ui/listbox.cpp | 10 +-- src/ui/listbox.h | 2 +- src/ui/listitem.cpp | 8 +-- src/ui/listitem.h | 2 +- src/ui/manager.cpp | 4 +- src/ui/manager.h | 2 +- src/ui/menu.cpp | 18 ++--- src/ui/menu.h | 6 +- src/ui/panel.cpp | 8 +-- src/ui/panel.h | 2 +- src/ui/popup_window.cpp | 8 +-- src/ui/popup_window.h | 2 +- src/ui/preferred_size_event.h | 40 ----------- src/ui/separator.cpp | 8 +-- src/ui/separator.h | 2 +- ...red_size_event.cpp => size_hint_event.cpp} | 32 ++++----- src/ui/size_hint_event.h | 39 +++++++++++ src/ui/slider.cpp | 6 +- src/ui/slider.h | 2 +- src/ui/splitter.cpp | 8 +-- src/ui/splitter.h | 2 +- src/ui/textbox.cpp | 6 +- src/ui/textbox.h | 2 +- src/ui/tooltips.cpp | 8 +-- src/ui/tooltips.h | 2 +- src/ui/ui.h | 4 +- src/ui/view.cpp | 8 +-- src/ui/view.h | 2 +- src/ui/viewport.cpp | 12 ++-- src/ui/viewport.h | 2 +- src/ui/widget.cpp | 66 +++++++++---------- src/ui/widget.h | 14 ++-- src/ui/window.cpp | 14 ++-- src/ui/window.h | 2 +- 107 files changed, 367 insertions(+), 368 deletions(-) delete mode 100644 src/ui/preferred_size_event.h rename src/ui/{preferred_size_event.cpp => size_hint_event.cpp} (54%) create mode 100644 src/ui/size_hint_event.h diff --git a/src/app/commands/cmd_export_sprite_sheet.cpp b/src/app/commands/cmd_export_sprite_sheet.cpp index 801efc95b..0302d894d 100644 --- a/src/app/commands/cmd_export_sprite_sheet.cpp +++ b/src/app/commands/cmd_export_sprite_sheet.cpp @@ -633,7 +633,7 @@ private: } void resize() { - gfx::Size reqSize = getPreferredSize(); + gfx::Size reqSize = sizeHint(); moveWindow(gfx::Rect(getOrigin(), reqSize)); layout(); invalidate(); diff --git a/src/app/commands/cmd_keyboard_shortcuts.cpp b/src/app/commands/cmd_keyboard_shortcuts.cpp index 144c536c2..13de15ebc 100644 --- a/src/app/commands/cmd_keyboard_shortcuts.cpp +++ b/src/app/commands/cmd_keyboard_shortcuts.cpp @@ -30,7 +30,7 @@ #include "ui/graphics.h" #include "ui/listitem.h" #include "ui/paint_event.h" -#include "ui/preferred_size_event.h" +#include "ui/size_hint_event.h" #include "ui/resize_event.h" #include "ui/separator.h" @@ -121,7 +121,7 @@ private: getRoot()->layout(); } - void onPreferredSize(PreferredSizeEvent& ev) override { + void onSizeHint(SizeHintEvent& ev) override { gfx::Size size = getTextSize(); size.w = size.w + border().width(); size.h = size.h + border().height() + 4*guiscale(); @@ -132,7 +132,7 @@ private: size.h *= combos; } - ev.setPreferredSize(size); + ev.setSizeHint(size); } void onPaint(PaintEvent& ev) override { diff --git a/src/app/commands/filters/color_curve_editor.cpp b/src/app/commands/filters/color_curve_editor.cpp index 964032831..7ac7cf33f 100644 --- a/src/app/commands/filters/color_curve_editor.cpp +++ b/src/app/commands/filters/color_curve_editor.cpp @@ -17,7 +17,7 @@ #include "ui/manager.h" #include "ui/message.h" #include "ui/paint_event.h" -#include "ui/preferred_size_event.h" +#include "ui/size_hint_event.h" #include "ui/system.h" #include "ui/theme.h" #include "ui/view.h" @@ -177,10 +177,10 @@ bool ColorCurveEditor::onProcessMessage(Message* msg) return Widget::onProcessMessage(msg); } -void ColorCurveEditor::onPreferredSize(PreferredSizeEvent& ev) +void ColorCurveEditor::onSizeHint(SizeHintEvent& ev) { - ev.setPreferredSize(gfx::Size(1 + border().width(), - 1 + border().height())); + ev.setSizeHint(gfx::Size(1 + border().width(), + 1 + border().height())); } void ColorCurveEditor::onPaint(ui::PaintEvent& ev) diff --git a/src/app/commands/filters/color_curve_editor.h b/src/app/commands/filters/color_curve_editor.h index 30c7795b2..b520e8caa 100644 --- a/src/app/commands/filters/color_curve_editor.h +++ b/src/app/commands/filters/color_curve_editor.h @@ -30,7 +30,7 @@ namespace app { protected: bool onProcessMessage(ui::Message* msg) override; - void onPreferredSize(ui::PreferredSizeEvent& ev) override; + void onSizeHint(ui::SizeHintEvent& ev) override; void onPaint(ui::PaintEvent& ev) override; private: diff --git a/src/app/ui/app_menuitem.cpp b/src/app/ui/app_menuitem.cpp index af19cfb0b..7a25d6430 100644 --- a/src/app/ui/app_menuitem.cpp +++ b/src/app/ui/app_menuitem.cpp @@ -19,7 +19,7 @@ #include "ui/accelerator.h" #include "ui/menu.h" #include "ui/message.h" -#include "ui/preferred_size_event.h" +#include "ui/size_hint_event.h" #include "ui/widget.h" #include @@ -85,7 +85,7 @@ bool AppMenuItem::onProcessMessage(Message* msg) return MenuItem::onProcessMessage(msg); } -void AppMenuItem::onPreferredSize(PreferredSizeEvent& ev) +void AppMenuItem::onSizeHint(SizeHintEvent& ev) { gfx::Size size(0, 0); @@ -105,7 +105,7 @@ void AppMenuItem::onPreferredSize(PreferredSizeEvent& ev) } } - ev.setPreferredSize(size); + ev.setSizeHint(size); } void AppMenuItem::onClick() diff --git a/src/app/ui/app_menuitem.h b/src/app/ui/app_menuitem.h index 456ca0ce0..2196504e4 100644 --- a/src/app/ui/app_menuitem.h +++ b/src/app/ui/app_menuitem.h @@ -35,7 +35,7 @@ namespace app { protected: bool onProcessMessage(ui::Message* msg) override; - void onPreferredSize(ui::PreferredSizeEvent& ev) override; + void onSizeHint(ui::SizeHintEvent& ev) override; void onClick() override; private: diff --git a/src/app/ui/button_set.cpp b/src/app/ui/button_set.cpp index 9961b1dd5..64559a021 100644 --- a/src/app/ui/button_set.cpp +++ b/src/app/ui/button_set.cpp @@ -21,7 +21,7 @@ #include "ui/graphics.h" #include "ui/message.h" #include "ui/paint_event.h" -#include "ui/preferred_size_event.h" +#include "ui/size_hint_event.h" #include "ui/system.h" #include "ui/theme.h" #include "ui/widget.h" @@ -206,7 +206,7 @@ bool ButtonSet::Item::onProcessMessage(ui::Message* msg) return Widget::onProcessMessage(msg); } -void ButtonSet::Item::onPreferredSize(ui::PreferredSizeEvent& ev) +void ButtonSet::Item::onSizeHint(ui::SizeHintEvent& ev) { gfx::Size iconSize; if (m_icon) { @@ -229,7 +229,7 @@ void ButtonSet::Item::onPreferredSize(ui::PreferredSizeEvent& ev) if (info.row == info.grid_rows-1) sz.h += 3*guiscale(); - ev.setPreferredSize(sz); + ev.setSizeHint(sz); } ButtonSet::ButtonSet(int columns) diff --git a/src/app/ui/button_set.h b/src/app/ui/button_set.h index cc032515c..6290cc8c2 100644 --- a/src/app/ui/button_set.h +++ b/src/app/ui/button_set.h @@ -28,7 +28,7 @@ namespace app { protected: void onPaint(ui::PaintEvent& ev) override; bool onProcessMessage(ui::Message* msg) override; - void onPreferredSize(ui::PreferredSizeEvent& ev) override; + void onSizeHint(ui::SizeHintEvent& ev) override; private: skin::SkinPartPtr m_icon; }; diff --git a/src/app/ui/color_bar.cpp b/src/app/ui/color_bar.cpp index f1649f92d..466950fb6 100644 --- a/src/app/ui/color_bar.cpp +++ b/src/app/ui/color_bar.cpp @@ -155,8 +155,8 @@ ColorBar::ColorBar(int align) setChildSpacing(2*guiscale()); m_paletteView.setColumns(8); - m_fgColor.setPreferredSize(0, m_fgColor.getPreferredSize().h); - m_bgColor.setPreferredSize(0, m_bgColor.getPreferredSize().h); + m_fgColor.setSizeHint(0, m_fgColor.sizeHint().h); + m_bgColor.setSizeHint(0, m_bgColor.sizeHint().h); // TODO hardcoded scroll bar width should be get from skin.xml file int scrollBarWidth = 6*guiscale(); diff --git a/src/app/ui/color_button.cpp b/src/app/ui/color_button.cpp index 0c10bccde..d1f1071b3 100644 --- a/src/app/ui/color_button.cpp +++ b/src/app/ui/color_button.cpp @@ -26,7 +26,7 @@ #include "doc/layer.h" #include "doc/site.h" #include "doc/sprite.h" -#include "ui/preferred_size_event.h" +#include "ui/size_hint_event.h" #include "ui/ui.h" namespace app { @@ -158,14 +158,14 @@ bool ColorButton::onProcessMessage(Message* msg) return ButtonBase::onProcessMessage(msg); } -void ColorButton::onPreferredSize(PreferredSizeEvent& ev) +void ColorButton::onSizeHint(SizeHintEvent& ev) { gfx::Rect box; getTextIconInfo(&box); box.w = 64*guiscale(); - ev.setPreferredSize(box.w + border().width(), - box.h + border().height()); + ev.setSizeHint(box.w + border().width(), + box.h + border().height()); } void ColorButton::onPaint(PaintEvent& ev) diff --git a/src/app/ui/color_button.h b/src/app/ui/color_button.h index c67b1daa3..0c7ed54fa 100644 --- a/src/app/ui/color_button.h +++ b/src/app/ui/color_button.h @@ -36,7 +36,7 @@ namespace app { protected: // Events bool onProcessMessage(ui::Message* msg) override; - void onPreferredSize(ui::PreferredSizeEvent& ev) override; + void onSizeHint(ui::SizeHintEvent& ev) override; void onPaint(ui::PaintEvent& ev) override; void onClick(ui::Event& ev) override; diff --git a/src/app/ui/color_selector.cpp b/src/app/ui/color_selector.cpp index c2cd859b8..63d31998d 100644 --- a/src/app/ui/color_selector.cpp +++ b/src/app/ui/color_selector.cpp @@ -97,7 +97,7 @@ ColorSelector::ColorSelector() m_hexColorEntry.ColorChange.connect(&ColorSelector::onColorHexEntryChange, this); selectColorType(app::Color::RgbType); - setPreferredSize(gfx::Size(300*guiscale(), getPreferredSize().h)); + setSizeHint(gfx::Size(300*guiscale(), sizeHint().h)); m_onPaletteChangeConn = App::instance()->PaletteChange.connect(&ColorSelector::onPaletteChange, this); diff --git a/src/app/ui/color_sliders.cpp b/src/app/ui/color_sliders.cpp index 1d8c074af..aafee26a9 100644 --- a/src/app/ui/color_sliders.cpp +++ b/src/app/ui/color_sliders.cpp @@ -18,7 +18,7 @@ #include "ui/entry.h" #include "ui/graphics.h" #include "ui/label.h" -#include "ui/preferred_size_event.h" +#include "ui/size_hint_event.h" #include "ui/slider.h" #include "ui/theme.h" @@ -124,9 +124,9 @@ void ColorSliders::resetRelativeSliders() slider->setValue(0); } -void ColorSliders::onPreferredSize(PreferredSizeEvent& ev) +void ColorSliders::onSizeHint(SizeHintEvent& ev) { - ev.setPreferredSize(m_grid.getPreferredSize()); + ev.setSizeHint(m_grid.sizeHint()); } void ColorSliders::addSlider(Channel channel, const char* labelText, int min, int max) diff --git a/src/app/ui/color_sliders.h b/src/app/ui/color_sliders.h index 8c0a6a398..a1b00ac50 100644 --- a/src/app/ui/color_sliders.h +++ b/src/app/ui/color_sliders.h @@ -46,7 +46,7 @@ namespace app { Signal1 ColorChange; protected: - void onPreferredSize(ui::PreferredSizeEvent& ev); + void onSizeHint(ui::SizeHintEvent& ev); // For derived classes void addSlider(Channel channel, const char* labelText, int min, int max); diff --git a/src/app/ui/color_spectrum.cpp b/src/app/ui/color_spectrum.cpp index bf9574336..a7f986540 100644 --- a/src/app/ui/color_spectrum.cpp +++ b/src/app/ui/color_spectrum.cpp @@ -18,7 +18,7 @@ #include "ui/graphics.h" #include "ui/message.h" #include "ui/paint_event.h" -#include "ui/preferred_size_event.h" +#include "ui/size_hint_event.h" #include "ui/resize_event.h" #include "ui/system.h" @@ -76,9 +76,9 @@ void ColorSpectrum::selectColor(const app::Color& color) invalidate(); } -void ColorSpectrum::onPreferredSize(PreferredSizeEvent& ev) +void ColorSpectrum::onSizeHint(SizeHintEvent& ev) { - ev.setPreferredSize(gfx::Size(32*ui::guiscale(), 32*ui::guiscale())); + ev.setSizeHint(gfx::Size(32*ui::guiscale(), 32*ui::guiscale())); } void ColorSpectrum::onResize(ui::ResizeEvent& ev) diff --git a/src/app/ui/color_spectrum.h b/src/app/ui/color_spectrum.h index 82939eb57..207fa03bc 100644 --- a/src/app/ui/color_spectrum.h +++ b/src/app/ui/color_spectrum.h @@ -28,7 +28,7 @@ namespace app { Signal2 ColorChange; protected: - void onPreferredSize(ui::PreferredSizeEvent& ev) override; + void onSizeHint(ui::SizeHintEvent& ev) override; void onResize(ui::ResizeEvent& ev) override; void onPaint(ui::PaintEvent& ev) override; bool onProcessMessage(ui::Message* msg) override; diff --git a/src/app/ui/color_wheel.cpp b/src/app/ui/color_wheel.cpp index bf6d3c433..1b33acb5a 100644 --- a/src/app/ui/color_wheel.cpp +++ b/src/app/ui/color_wheel.cpp @@ -24,7 +24,7 @@ #include "ui/menu.h" #include "ui/message.h" #include "ui/paint_event.h" -#include "ui/preferred_size_event.h" +#include "ui/size_hint_event.h" #include "ui/resize_event.h" #include "ui/system.h" @@ -178,9 +178,9 @@ app::Color ColorWheel::getColorInHarmony(int j) const m_mainColor.getValue()); } -void ColorWheel::onPreferredSize(PreferredSizeEvent& ev) +void ColorWheel::onSizeHint(SizeHintEvent& ev) { - ev.setPreferredSize(gfx::Size(32*ui::guiscale(), 32*ui::guiscale())); + ev.setSizeHint(gfx::Size(32*ui::guiscale(), 32*ui::guiscale())); } void ColorWheel::onResize(ui::ResizeEvent& ev) @@ -196,7 +196,7 @@ void ColorWheel::onResize(ui::ResizeEvent& ev) rc.y+rc.h/2-r, r*2, r*2); - gfx::Size prefSize = m_options.getPreferredSize(); + gfx::Size prefSize = m_options.sizeHint(); rc = getChildrenBounds(); rc.x += rc.w-prefSize.w; rc.w = prefSize.w; diff --git a/src/app/ui/color_wheel.h b/src/app/ui/color_wheel.h index 65c7f5c3c..b7874d570 100644 --- a/src/app/ui/color_wheel.h +++ b/src/app/ui/color_wheel.h @@ -46,7 +46,7 @@ namespace app { Signal2 ColorChange; private: - void onPreferredSize(ui::PreferredSizeEvent& ev) override; + void onSizeHint(ui::SizeHintEvent& ev) override; void onResize(ui::ResizeEvent& ev) override; void onPaint(ui::PaintEvent& ev) override; bool onProcessMessage(ui::Message* msg) override; diff --git a/src/app/ui/context_bar.cpp b/src/app/ui/context_bar.cpp index f2901c1c4..5ef5f4a6f 100644 --- a/src/app/ui/context_bar.cpp +++ b/src/app/ui/context_bar.cpp @@ -57,7 +57,7 @@ #include "ui/message.h" #include "ui/paint_event.h" #include "ui/popup_window.h" -#include "ui/preferred_size_event.h" +#include "ui/size_hint_event.h" #include "ui/system.h" #include "ui/theme.h" #include "ui/tooltips.h" @@ -113,8 +113,8 @@ protected: closePopup(); } - void onPreferredSize(PreferredSizeEvent& ev) override { - ev.setPreferredSize(Size(16, 18)*guiscale()); + void onSizeHint(SizeHintEvent& ev) override { + ev.setSizeHint(Size(16, 18)*guiscale()); } // BrushPopupDelegate impl @@ -144,7 +144,7 @@ private: gfx::Rect getPopupBox() { Rect rc = getBounds(); rc.y += rc.h - 2*guiscale(); - rc.setSize(getPreferredSize()); + rc.setSize(sizeHint()); return rc; } @@ -574,14 +574,14 @@ class ContextBar::InkShadesField : public HBox { return Widget::onProcessMessage(msg); } - void onPreferredSize(PreferredSizeEvent& ev) override { + void onSizeHint(SizeHintEvent& ev) override { int size = this->size(); if (size < 2) - ev.setPreferredSize(Size((16+m_boxSize)*guiscale()+getTextWidth(), 18*guiscale())); + ev.setSizeHint(Size((16+m_boxSize)*guiscale()+getTextWidth(), 18*guiscale())); else { if (m_click == Select && size > 16) size = 16; - ev.setPreferredSize(Size(6+m_boxSize*size, 18)*guiscale()); + ev.setSizeHint(Size(6+m_boxSize*size, 18)*guiscale()); } } @@ -866,7 +866,7 @@ public: addChild(&m_maskColor); m_icon.addItem(theme->parts.selectionOpaque()); - gfx::Size sz = m_icon.getItem(0)->getPreferredSize(); + gfx::Size sz = m_icon.getItem(0)->sizeHint(); sz.w += 2*guiscale(); m_icon.getItem(0)->setMinSize(sz); @@ -1371,9 +1371,9 @@ ContextBar::ContextBar() setActiveBrush(createBrushFromPreferences()); } -void ContextBar::onPreferredSize(PreferredSizeEvent& ev) +void ContextBar::onSizeHint(SizeHintEvent& ev) { - ev.setPreferredSize(gfx::Size(0, 18*guiscale())); // TODO calculate height + ev.setSizeHint(gfx::Size(0, 18*guiscale())); // TODO calculate height } void ContextBar::onToolSetOpacity(const int& newOpacity) diff --git a/src/app/ui/context_bar.h b/src/app/ui/context_bar.h index 56c80b1a0..5745ff3d5 100644 --- a/src/app/ui/context_bar.h +++ b/src/app/ui/context_bar.h @@ -80,7 +80,7 @@ namespace app { Signal0 BrushChange; protected: - void onPreferredSize(ui::PreferredSizeEvent& ev) override; + void onSizeHint(ui::SizeHintEvent& ev) override; void onToolSetOpacity(const int& newOpacity); void onToolSetFreehandAlgorithm(); diff --git a/src/app/ui/data_recovery_view.cpp b/src/app/ui/data_recovery_view.cpp index 8105c66c8..0cb37bc26 100644 --- a/src/app/ui/data_recovery_view.cpp +++ b/src/app/ui/data_recovery_view.cpp @@ -24,7 +24,7 @@ #include "ui/entry.h" #include "ui/listitem.h" #include "ui/message.h" -#include "ui/preferred_size_event.h" +#include "ui/size_hint_event.h" #include "ui/resize_event.h" #include "ui/system.h" #include "ui/view.h" @@ -58,19 +58,19 @@ public: Signal0 Regenerate; protected: - void onPreferredSize(PreferredSizeEvent& ev) override { - gfx::Size sz = m_deleteButton.getPreferredSize(); + void onSizeHint(SizeHintEvent& ev) override { + gfx::Size sz = m_deleteButton.sizeHint(); sz.h += 4*guiscale(); - ev.setPreferredSize(sz); + ev.setSizeHint(sz); } void onResize(ResizeEvent& ev) override { ListItem::onResize(ev); gfx::Rect rc = ev.getBounds(); - gfx::Size sz1 = m_openButton.getPreferredSize(); + gfx::Size sz1 = m_openButton.sizeHint(); sz1.w *= 2*guiscale(); - gfx::Size sz2 = m_deleteButton.getPreferredSize(); + gfx::Size sz2 = m_deleteButton.sizeHint(); int h = rc.h*3/4; int sep = 8*guiscale(); m_openButton.setBounds(gfx::Rect(rc.x+rc.w-sz2.w-sz1.w-2*sep, rc.y+rc.h/2-h/2, sz1.w, h)); diff --git a/src/app/ui/editor/editor.cpp b/src/app/ui/editor/editor.cpp index 8ee92e89a..466a1c2f7 100644 --- a/src/app/ui/editor/editor.cpp +++ b/src/app/ui/editor/editor.cpp @@ -1324,7 +1324,7 @@ bool Editor::onProcessMessage(Message* msg) return Widget::onProcessMessage(msg); } -void Editor::onPreferredSize(PreferredSizeEvent& ev) +void Editor::onSizeHint(SizeHintEvent& ev) { gfx::Size sz(0, 0); @@ -1337,7 +1337,7 @@ void Editor::onPreferredSize(PreferredSizeEvent& ev) sz.w = 4; sz.h = 4; } - ev.setPreferredSize(sz); + ev.setSizeHint(sz); } void Editor::onResize(ui::ResizeEvent& ev) diff --git a/src/app/ui/editor/editor.h b/src/app/ui/editor/editor.h index 747b25f8d..d99a617a1 100644 --- a/src/app/ui/editor/editor.h +++ b/src/app/ui/editor/editor.h @@ -218,7 +218,7 @@ namespace app { protected: bool onProcessMessage(ui::Message* msg) override; - void onPreferredSize(ui::PreferredSizeEvent& ev) override; + void onSizeHint(ui::SizeHintEvent& ev) override; void onResize(ui::ResizeEvent& ev) override; void onPaint(ui::PaintEvent& ev) override; void onInvalidateRegion(const gfx::Region& region) override; diff --git a/src/app/ui/file_list.cpp b/src/app/ui/file_list.cpp index 1bb7c6597..87350077d 100644 --- a/src/app/ui/file_list.cpp +++ b/src/app/ui/file_list.cpp @@ -397,7 +397,7 @@ void FileList::onPaint(ui::PaintEvent& ev) } } -void FileList::onPreferredSize(PreferredSizeEvent& ev) +void FileList::onSizeHint(SizeHintEvent& ev) { if (!m_req_valid) { gfx::Size reqSize(0, 0); @@ -416,7 +416,7 @@ void FileList::onPreferredSize(PreferredSizeEvent& ev) m_req_w = reqSize.w; m_req_h = reqSize.h; } - ev.setPreferredSize(Size(m_req_w, m_req_h)); + ev.setSizeHint(Size(m_req_w, m_req_h)); } void FileList::onFileSelected() diff --git a/src/app/ui/file_list.h b/src/app/ui/file_list.h index bd7b474e7..56e9ea020 100644 --- a/src/app/ui/file_list.h +++ b/src/app/ui/file_list.h @@ -41,7 +41,7 @@ namespace app { protected: virtual bool onProcessMessage(ui::Message* msg) override; virtual void onPaint(ui::PaintEvent& ev) override; - virtual void onPreferredSize(ui::PreferredSizeEvent& ev) override; + virtual void onSizeHint(ui::SizeHintEvent& ev) override; virtual void onFileSelected(); virtual void onFileAccepted(); virtual void onCurrentFolderChanged(); diff --git a/src/app/ui/font_popup.cpp b/src/app/ui/font_popup.cpp index 745fd7be6..c3e238014 100644 --- a/src/app/ui/font_popup.cpp +++ b/src/app/ui/font_popup.cpp @@ -29,7 +29,7 @@ #include "she/system.h" #include "ui/box.h" #include "ui/button.h" -#include "ui/preferred_size_event.h" +#include "ui/size_hint_event.h" #include "ui/theme.h" #include "ui/view.h" @@ -79,11 +79,11 @@ private: } } - void onPreferredSize(PreferredSizeEvent& ev) override { - ListItem::onPreferredSize(ev); + void onSizeHint(SizeHintEvent& ev) override { + ListItem::onSizeHint(ev); if (m_image) { - gfx::Size sz = ev.getPreferredSize(); - ev.setPreferredSize( + gfx::Size sz = ev.sizeHint(); + ev.setSizeHint( sz.w + 4 + m_image->width(), MAX(sz.h, m_image->height())); } diff --git a/src/app/ui/home_view.cpp b/src/app/ui/home_view.cpp index fd9f87365..d6a548ccf 100644 --- a/src/app/ui/home_view.cpp +++ b/src/app/ui/home_view.cpp @@ -157,7 +157,7 @@ void HomeView::onNewUpdate(const std::string& url, const std::string& version) SkinStylePropertyPtr(new SkinStyleProperty(theme->styles.workspaceUpdateLink()))); // TODO this should be in a skin.xml's