From fae42dbe12f2c8812ae31c1364c4f400b0686e33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thorbj=C3=B8rn=20Lindeijer?= Date: Fri, 12 Sep 2025 11:36:17 +0200 Subject: [PATCH] CMake: Use find_package(PkgConfig) instead of direct include This gets rid of the following warning: ``` CMake Warning (dev) at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:441 (message): The package name passed to `find_package_handle_standard_args` (PkgConfig) does not match the name of the calling package (HarfBuzz). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): /usr/share/cmake/Modules/FindPkgConfig.cmake:114 (find_package_handle_standard_args) aseprite/cmake/FindHarfBuzz.cmake:33 (include) CMakeLists.txt:173 (find_package) This warning is for project developers. Use -Wno-dev to suppress it. ``` By applying the following change: https://github.com/WebKit/WebKit/commit/407fa892d9dfa41738fd985f274485be63d26cfb The file could use further updates based on the upstream version. --- cmake/FindHarfBuzz.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/FindHarfBuzz.cmake b/cmake/FindHarfBuzz.cmake index 562b4bd21..6ad84e01b 100644 --- a/cmake/FindHarfBuzz.cmake +++ b/cmake/FindHarfBuzz.cmake @@ -30,7 +30,7 @@ # HARFBUZZ_INCLUDE_DIRS - containg the HarfBuzz headers # HARFBUZZ_LIBRARIES - containg the HarfBuzz library -include(FindPkgConfig) +find_package(PkgConfig QUIET) pkg_check_modules(PC_HARFBUZZ harfbuzz>=0.9.7)