Compare commits

...

3 Commits

Author SHA1 Message Date
Gaspar Capello 95d0dee4e0 Fix move tool with Auto Select Layer isn't working (fix #4812)
build-auto / build-auto (Debug, macos-latest) (push) Waiting to run Details
build-auto / build-auto (Debug, ubuntu-latest) (push) Waiting to run Details
build-auto / build-auto (Debug, windows-latest) (push) Waiting to run Details
build-auto / build-auto (RelWithDebInfo, macos-latest) (push) Waiting to run Details
build-auto / build-auto (RelWithDebInfo, ubuntu-latest) (push) Waiting to run Details
build-auto / build-auto (RelWithDebInfo, windows-latest) (push) Waiting to run Details
build / build (Debug, macos-latest, lua, cli) (push) Waiting to run Details
build / build (Debug, macos-latest, noscripts, cli) (push) Waiting to run Details
build / build (Debug, ubuntu-latest, lua, cli) (push) Waiting to run Details
build / build (Debug, ubuntu-latest, noscripts, cli) (push) Waiting to run Details
build / build (Debug, windows-latest, lua, cli) (push) Waiting to run Details
build / build (Debug, windows-latest, noscripts, cli) (push) Waiting to run Details
build / build (RelWithDebInfo, macos-latest, lua, gui) (push) Waiting to run Details
build / build (RelWithDebInfo, ubuntu-latest, lua, gui) (push) Waiting to run Details
build / build (RelWithDebInfo, windows-latest, lua, gui) (push) Waiting to run Details
Prior to this fix, automatic layer selection for the Move Tool
did not work when the "Compose Groups Separately" option was active.

Related PRs: #5438, #5439
2025-10-07 11:00:45 -03:00
David Capello 7ee486ebde [clang-tidy] Avoid showing comments about boolean simplifications by DeMorgan's theorem
This is quite common for ASSERT(condition), which is a macro with !(condition)
2025-10-07 08:45:01 -03:00
David Capello d3ef5c61da Update laf module 2025-10-07 08:05:18 -03:00
3 changed files with 7 additions and 2 deletions

View File

@ -31,6 +31,9 @@
# readability-named-parameter: We prefer misc-unused-parameters to
# remove a parameter name that is not used.
#
# readability-simplify-boolean-expr: Avoid showing comments about
# boolean expressions inside ASSERTs().
#
# misc-use-anonymous-namespace: We use anonymous namespaces or static
# functions indifferently.
#
@ -64,6 +67,8 @@ CheckOptions:
value: true
- key: readability-implicit-bool-conversion.AllowPointerConditions
value: true
- key: readability-simplify-boolean-expr.IgnoreMacros
value: true
- key: misc-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic
value: true
...

2
laf

@ -1 +1 @@
Subproject commit 39706c11063fb53cf4c8e865102c6f71e2606906
Subproject commit 12ea4f7aa466c5a7a570c2e8d61fe2d10b57b9fb

View File

@ -104,7 +104,7 @@ void ColorPicker::pickColor(const Site& site,
switch (mode) {
// Pick from the composed image
case FromComposition: {
doc::RenderPlan plan(pref.experimental.composeGroups());
doc::RenderPlan plan;
plan.addLayer(sprite->root(), site.frame());
doc::CelList cels;