From 0829decce075e190c0bb6e9992ca2a1ca56c60c7 Mon Sep 17 00:00:00 2001 From: david-lallement <51702439+david-lallement@users.noreply.github.com> Date: Thu, 13 Jun 2019 10:42:54 +0200 Subject: [PATCH] tooltip dispose:removing only own event handler (#28896) --- js/src/tooltip.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/js/src/tooltip.js b/js/src/tooltip.js index 7b792bc711..6cca7d75a4 100644 --- a/js/src/tooltip.js +++ b/js/src/tooltip.js @@ -237,7 +237,7 @@ class Tooltip { Data.removeData(this.element, this.constructor.DATA_KEY) EventHandler.off(this.element, this.constructor.EVENT_KEY) - EventHandler.off(SelectorEngine.closest(this.element, '.modal'), 'hide.bs.modal') + EventHandler.off(SelectorEngine.closest(this.element, '.modal'), 'hide.bs.modal', this._hideModalHandler) if (this.tip) { this.tip.parentNode.removeChild(this.tip) @@ -558,13 +558,15 @@ class Tooltip { } }) + this._hideModalHandler = () => { + if (this.element) { + this.hide() + } + } + EventHandler.on(SelectorEngine.closest(this.element, '.modal'), 'hide.bs.modal', - () => { - if (this.element) { - this.hide() - } - } + this._hideModalHandler ) if (this.config.selector) {