From dfd10efd80ab56004cb34156b713e8ee7bffb075 Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 29 Jul 2013 16:57:30 -0700 Subject: [PATCH 1/2] make it clearer than buttons are slightly broken on Firefox --- css.html | 1 + 1 file changed, 1 insertion(+) diff --git a/css.html b/css.html index 8018c4ff57..d34b487d8c 100644 --- a/css.html +++ b/css.html @@ -1777,6 +1777,7 @@ For example, <section> should be wrapped as inline.

Cross-browser rendering

As a best practice, we highly recommend using the <button> element whenever possible to ensure matching cross-browser rendering.

+

Among other things, there's a Firefox bug that prevents us from setting the line-height of <input>-based buttons, causing them to not exactly match the height of other buttons on Firefox.

From 7ae32074a09fe09906f5d007c2891601e0438a5b Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Mon, 29 Jul 2013 17:17:52 -0700 Subject: [PATCH 2/2] Remove hack/workaround for jshint/grunt bug that's now fixed See https://github.com/gruntjs/grunt-contrib-jshint/issues/86 --- Gruntfile.js | 1 - 1 file changed, 1 deletion(-) diff --git a/Gruntfile.js b/Gruntfile.js index dd0cc96009..7aad9b339a 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -28,7 +28,6 @@ module.exports = function(grunt) { }, jshint: { options: { - ignores: [],// HACK: workaround https://github.com/gruntjs/grunt-contrib-jshint/issues/86 jshintrc: 'js/.jshintrc' }, gruntfile: {