From ca64e71db7ff59bbf40e4f9fb59d2d0b546a3786 Mon Sep 17 00:00:00 2001
From: Marko Oleksiyenko <markoleksiyenko@gmail.com>
Date: Tue, 14 Jan 2025 13:59:38 +0100
Subject: [PATCH] docs(pagination): put current page on link element for a11y

---
 .../content/docs/components/pagination.mdx    | 20 ++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/site/src/content/docs/components/pagination.mdx b/site/src/content/docs/components/pagination.mdx
index 07710af072..bbebbfe9ed 100644
--- a/site/src/content/docs/components/pagination.mdx
+++ b/site/src/content/docs/components/pagination.mdx
@@ -46,6 +46,8 @@ Looking to use an icon or symbol in place of text for some pagination links? Be
 
 Pagination links are customizable for different circumstances. Use `.disabled` for links that appear un-clickable and `.active` to indicate the current page.
 
+`aria-current="page"` should be put on the link element for the assistive technology to recognize the active element.
+
 While the `.disabled` class uses `pointer-events: none` to _try_ to disable the link functionality of `<a>`s, that CSS property is not yet standardized and doesn’t account for keyboard navigation. As such, you should always add `tabindex="-1"` on disabled links and use custom JavaScript to fully disable their functionality.
 
 <Example code={`<nav aria-label="...">
@@ -54,8 +56,8 @@ While the `.disabled` class uses `pointer-events: none` to _try_ to disable the
         <a class="page-link">Previous</a>
       </li>
       <li class="page-item"><a class="page-link" href="#">1</a></li>
-      <li class="page-item active" aria-current="page">
-        <a class="page-link" href="#">2</a>
+      <li class="page-item active">
+        <a class="page-link" href="#" aria-current="page">2</a>
       </li>
       <li class="page-item"><a class="page-link" href="#">3</a></li>
       <li class="page-item">
@@ -64,7 +66,7 @@ While the `.disabled` class uses `pointer-events: none` to _try_ to disable the
     </ul>
   </nav>`} />
 
-You can optionally swap out active or disabled anchors for `<span>`, or omit the anchor in the case of the prev/next arrows, to remove click functionality and prevent keyboard focus while retaining intended styles.
+You can optionally swap out disabled anchors for `<span>`, or omit the anchor in the case of the prev/next arrows, to remove click functionality and prevent keyboard focus while retaining intended styles.
 
 <Example code={`<nav aria-label="...">
     <ul class="pagination">
@@ -72,8 +74,8 @@ You can optionally swap out active or disabled anchors for `<span>`, or omit the
         <span class="page-link">Previous</span>
       </li>
       <li class="page-item"><a class="page-link" href="#">1</a></li>
-      <li class="page-item active" aria-current="page">
-        <span class="page-link">2</span>
+      <li class="page-item active">
+        <a class="page-link" aria-current="page">2</a>
       </li>
       <li class="page-item"><a class="page-link" href="#">3</a></li>
       <li class="page-item">
@@ -88,8 +90,8 @@ Fancy larger or smaller pagination? Add `.pagination-lg` or `.pagination-sm` for
 
 <Example code={`<nav aria-label="...">
     <ul class="pagination pagination-lg">
-      <li class="page-item active" aria-current="page">
-        <span class="page-link">1</span>
+      <li class="page-item active" >
+        <a class="page-link" aria-current="page">1</a>
       </li>
       <li class="page-item"><a class="page-link" href="#">2</a></li>
       <li class="page-item"><a class="page-link" href="#">3</a></li>
@@ -98,8 +100,8 @@ Fancy larger or smaller pagination? Add `.pagination-lg` or `.pagination-sm` for
 
 <Example code={`<nav aria-label="...">
     <ul class="pagination pagination-sm">
-      <li class="page-item active" aria-current="page">
-        <span class="page-link">1</span>
+      <li class="page-item active">
+        <a class="page-link" aria-current="page">1</a>
       </li>
       <li class="page-item"><a class="page-link" href="#">2</a></li>
       <li class="page-item"><a class="page-link" href="#">3</a></li>