root
/
bootstrap
mirror of https://github.com/twbs/bootstrap.git
1
0
Fork 0
Code Issues Actions 11 Packages Projects Releases Wiki Activity
21,146 Commits 105 Branches 92 Tags 675 MiB
Commit Graph

168 Commits

Author SHA1 Message Date
XhmikosR 40042ee503
visual tests: minor fixes (#34802) 2021-08-23 18:33:55 +03:00
XhmikosR 730566221f
visual tests: add missing base-component dist file (#33167) 
Regression of #32313
 2021-02-22 08:42:43 +02:00
Patrick H. Lauke 96be06e32b
Dynamic tabs: use buttons rather than links (#32630) 
* Dynamic tabs: use buttons rather than links

- change docs
- add mention that tabs should be <button> elements
- tweak styles to neutralise border and background

* Update js unit and visual test accordingly

- replace links with buttons
- make one specific test that uses links instead of buttons, as we still want to support it despite it being non-semantically appropriate
- Leaving a couple of tests for now. The test for removed tabs should be redone so that tabs are removed programmatically (as the approach of having that close button inside the link is invalid and broken markup). The test for dropdowns should be removed together we actually ripping out the handling for dropdowns in the tab.js code (arguably a breaking change, though we discouraged this for a few versions and effectively "deprecated" it)

* Add isolation:isolate to prevent focus being overlapped

https://github.com/twbs/bootstrap/pull/32630#issuecomment-756015766
 2021-02-09 07:23:45 +02:00
Patrick H. Lauke a882614c45 Make carousel indicators actual buttons 2021-01-28 23:32:24 +02:00
Patrick H. Lauke 3aa3fda730
Carousel: use buttons, not links, for prev/next controls (#32627) 
* Carousel: use buttons, not links, for prev/next

- expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
- use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links

* Clarify that controls can be button or link

* Update site/content/docs/5.0/components/carousel.md

Co-authored-by: Mark Otto <markd.otto@gmail.com>

* Explicitly set padding to 0 to prevent dipping/moving on active in Firefox

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2021-01-27 17:31:16 +02:00
Théophile Helleboid - chtitux 80557b3ac0
Move "active" class from `.nav-item` to `.nav-link` (#32730) 2021-01-08 20:53:04 +02:00
Johann-S adfdf7160b Update to popper.js v2.x 2020-12-06 18:42:40 +02:00
Gaël Poupard 9488978fb5 feat(RTL): implement RTL 
Using RTLCSS directives, renaming things to use logical names and following best practices.
 2020-12-04 07:52:03 +02:00
XhmikosR f4457bca02
Be consistent with Popper's name. (#32224) 
The npm package is named "popper.js" but the project is named "Popper", so use the latter consistently.
 2020-11-21 16:22:08 +02:00
XhmikosR 4f8b243ac1
Fix `.close` instances (#32152) 2020-11-14 08:16:30 +02:00
Rohit Sharma 418f17ee2b Add `bs` in data attributes 
- Add `bs` in data APIs everywhere
- Update unit tests
 2020-11-14 07:09:15 +02:00
XhmikosR 411fc649f2
modal.html: use `textContent` (#32101) 
We are not handling any HTML
 2020-11-09 20:47:33 +02:00
XhmikosR 13572a6867 Remove the now unneeded polyfills. 2020-11-05 15:37:34 +02:00
XhmikosR c196d21e7f
Remove obsolete prefixes (#32012) 2020-10-30 07:29:48 +02:00
XhmikosR 5a3f273b60
Move `href` attribute first (#31835) 2020-10-22 09:38:15 +03:00
Patrick H. Lauke 836a4c0bd6
Remove redundant visually hidden "(current)" from pagination controls (#31892) 
* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
 2020-10-14 11:59:43 +01:00
Patrick H. Lauke 10690dd317
Rename `sr-only`/`sr-only-focusable` (#31139) 
* Rename `sr-only`/`sr-only-focusable`

To be more representative of the fact that these are not necessarily "screen reader" specific, but actually apply to assistive technologies in general (and also things like Alexa/Siri/etc). Goes hand-in-hand with #31133

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2020-07-03 14:38:11 +03:00
Rohit Sharma 5faf41eb48
Add role="dialog" in modals via JavaScript (#30936) 2020-06-04 10:35:09 +03:00
Rohit Sharma ec3cfae29c
Removed role="document" from the modal dialog (#30755) 2020-05-11 12:45:42 +03:00
XhmikosR 967e6071ba
tests: streamline HTML end tags (#30648) 2020-05-06 09:20:08 +03:00
Martijn Cuppens c48d89cb70 Use unordered lists in dropdown-menus 2020-03-31 22:52:57 +02:00
Laussel Loïc 7ce29d75f3
v5 tabs - accessibility issue when using ul/li semantic 
Add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc
 2020-03-28 09:51:24 +02:00
Johann-S dcba526775 remove underscore for static methods 2019-07-29 11:34:12 +02:00
Johann-S e101ba4989 add polyfill.js in visual tests (#29116) 2019-07-24 08:19:47 +03:00
XhmikosR 438e01b61c Rename `eventHandler` and `selectorEngine` files. 2019-05-08 17:26:37 +03:00
Johann-S ad0f5f153c fix remove files in our visual tests 2019-03-18 01:11:05 +02:00
XhmikosR d5f9107abb
Remove the now unneeded `shrink-to-fit` directive. (#28314) 2019-02-27 17:47:41 +02:00
Johann-S 8a37045b79 move util in a util folder with the sanitizer 2019-02-26 13:04:04 +02:00
XhmikosR 5ad2121819
Remove DOMContentLoaded. (#28337) 
There's no reason for us to wait here.
 2019-02-24 15:42:18 +02:00
XhmikosR 423e4a3811 tests/visual/modal.html: fix close button placement. 2019-02-20 22:05:45 +02:00
Johann-S 764bab2941 remove polyfills which override browsers default 2019-02-20 22:05:45 +02:00
Johann-S 661db08eeb rewrite toast plugin without jquery 2019-02-20 22:05:45 +02:00
Alessandro Chitolina 6cfc78f2d9 Remove IE support and button bsChecked hack 2019-02-20 22:05:45 +02:00
Johann-S c44db783bf chore(update): bump to 4.1.3 2019-02-20 22:05:45 +02:00
Johann-S 5dcca44fcf fix(visual-test): remove jquery in them 2019-02-20 22:05:45 +02:00
Johann-S 6b0808354d fix(unit-test): dropdown, collapse and carousel 2019-02-20 22:05:45 +02:00
Alessandro Chitolina 0263d1742c rewritten scrollspy without jquery 2019-02-20 22:05:45 +02:00
Alessandro Chitolina 7f08061eca rewritten tab without jquery 2019-02-20 22:05:45 +02:00
Johann-S 90261b484c Dropdown without jQuery 2019-02-20 22:05:45 +02:00
Alessandro Chitolina cc6e130fc1 tooltip without jquery 2019-02-20 22:05:45 +02:00
Johann-S 69e4d4f3ac Rewrite Collapse without jQuery 2019-02-20 22:05:45 +02:00
Alessandro Chitolina 33211eefdf Rewritten modal without jquery (#23955) 
* Trigger jquery events if available in event handler

* Rewritten modal without jquery
 2019-02-20 22:05:45 +02:00
Johann-S 9f9712b98c Add Manipulator object to add shortcuts for dom manipulations 2019-02-20 22:05:45 +02:00
Johann-S 44f38e4128 Rewrite carousel without jquery 2019-02-20 22:05:45 +02:00
XhmikosR aba87279fd button without jquery 2019-02-20 22:05:45 +02:00
Johann-S 0b16c8c6d9 alert without jquery 2019-02-20 22:05:45 +02:00
Johann-S fb465c4745 Remove jQuery from Util.js 
s
 2019-02-20 22:05:45 +02:00
Patrick H. Lauke 4b00aa6c4e Remove incorrect aria-haspopup from dropdown toggles (#28299) 
`aria-haspopup` use requires the use of an ARIA `menu`, `listbox`, `tree`, `grid` or `dialog` (see https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup)

in our use (as generic disclosure widgets), it's incorrect and sets up the wrong assumption/behavior from assistive technologies.

in future, we likely want to change our dropdowns to essentially be like a `dialog` - move focus to it when opened, possibly make it modal so focus is maintained inside it and the rest of the page
is hidden/inert.

but for now, removing the incorrect attribute is probably the quickest, most immediate fix.
 2019-02-19 11:25:36 +02:00
XhmikosR 3aeda9942d
tests: use jQuery from node_modules. (#28059) 2019-01-15 18:01:40 +02:00
Mark Otto eda851ee76 Prep for v4.2.0 release 
- Move 4.1 docs to 4.2
- Update versions everywhere to 4.1.3 with release script
- Manually bump the shorthand version in package.json
- Add 4.2 to the versions docs page
- Update some redirects
- Fix tests asset URLs
- Bump Nuget and more
 2018-12-21 09:03:29 -08:00