Commit Graph

48 Commits

Author SHA1 Message Date
Stephen Horvath a2c9b39a24 Fix animation when overriding `--bs-progress-height` 2025-04-02 22:56:10 -07:00
Patrick H. Lauke 26a3ef1bcb
Rework progress bar markup and styles (#36831)
* Rework progress bar markup and styles

Logically moves the various `role` and `aria-` attributes to the `.progress` element itself, leaving the `.progress-bar` to be used purely for the visual presentation. This fixes the problem #36736 that in certain browser/AT combinations, zero-value/zero-width progress bars are completely ignored and not announced.

For multiple/stacked progress bars, this PR introduces a new wrapper and class `.progress-stacked`, to accommodate for the fact that with the more logical structure above, we need full `.progress` elements with child `.progress-bar` elements, and can't get away with the fudge we had before of having a single `.progress` with multiple `.progress-bar`s.

Note that the old markup structures still work with this change, so this could be considered a non-breaking change - though one we definitely want to highlight as it's more accessible (as it now guarantees that zero-value/zero-width progress bars, whether on their own or as part of a multi/stacked bar, are actually announced)

* Add a note about progress bar change in migration guide

* Add notes with old markup examples and explanation

* Fix bundlewatch

* Update site/content/docs/5.2/components/progress.md

Co-authored-by: Julien Déramond <julien.deramond@orange.com>

* Reintroduce deleted styles

Turns out they're needed for correct positioning of text inside progress bar

* Move changes in markup to Migrationg guide, link to that from top of progress page, rewrite some content

* Fix typo in callout

* Clarify "Sizing" section

* Remove redundant "now"

Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <juderamond@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-11-28 23:07:48 -08:00
Mark Otto 427c089961 Stylelint: Disable `custom-property-empty-line-before` 2022-05-22 19:58:14 -07:00
Mark Otto 88bd287b27
Convert progress bars to CSS variables (#35962)
* Convert progress bars to CSS variables

* bundlewatch
2022-03-18 09:02:03 -07:00
Mark Otto 4c7a3e8adf
Add Sass docs (variables, mixins, and loops) to most pages (#32747)
* WIP: Mention variables, mixins, and loops in docs

* Add Sass sections to component pages

* add sass docs for forms and content

* Update buttons.md

* Remove empty mixins sections

* Massive update to utilities and some consistency changes

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-10 19:29:59 -08:00
Martijn Cuppens 3612a1e463
Use correct value order (#32121)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-11 18:27:12 +02:00
Mark Otto 0408799ae5 Rename variables for brevity
- Rename `$enable-prefers-reduced-motion-media-query` to `$enable-reduced-motion`
- Rename `$enable-pointer-cursor-for-buttons` to `$enable-button-pointers`
2020-04-26 17:26:04 -07:00
Martijn Cuppens 504098d664 progress: Fix IE overflow (#29629) 2019-11-04 14:37:13 +02:00
Martijn Cuppens b327c34ce3 Improve progress-bar-stripes animation (#28697)
- `background-position: 0 0;` is the default background position, so redundant
- The background position should only be animated in the x direction
- `0%` is a little shorter than `from`
2019-05-02 11:03:28 +03:00
Patrick H. Lauke b4a2beb3c2 Check prefers-reduced-motion variable before adding reduced motion media query for animated progress bars (#28530) 2019-03-21 15:59:02 +02:00
Martijn Cuppens 51375abca5
Responsive font size implementation (#23816) 2019-02-07 23:32:05 +01:00
Martijn Cuppens f1f740be09 Make progress animation respect `$enable-transitions` and `prefers-reduced-motion` media query
Make progress animation respect `$enable-transitions` and `prefers-reduced-motion` media query
2019-01-15 00:51:11 +00:00
Martijn Cuppens 0205fc8bdb Prevent word-wrap (#25248)
Fixes #25235
2018-02-11 16:46:54 -08:00
Mark Otto 671bb278bb Restore currently unused variables (#24891) 2017-11-27 19:31:11 +02:00
Mark Otto a8aaccbd4d
Restore .progress-bar transition (#24694)
Unintentionally removed in #22703. Fixes #24643.
2017-11-06 12:02:42 -08:00
Gijs Boddeus bfbf24e7a5 fixing label cutoff at 0% (#24544) 2017-11-06 09:57:25 -08:00
Dave Poole 120a14237e remove unnecessary line-height 2017-08-10 22:50:59 -07:00
Dave Poole 36a21f355c remove comments, align-items, and unnecessary height 2017-08-10 22:50:59 -07:00
Dave 1ab4f57af4 Fixes PropertySortOrder errors 2017-08-10 22:50:59 -07:00
Dave ad84eeb6e9 Fixes hound code style/standards 2017-08-10 22:50:59 -07:00
Dave c2c06bc581 _progress.scss: makes bars 100% height, centers labels horizontally & vertically 2017-08-10 22:50:59 -07:00
Mark Otto 2a833d559a Add box-shadow to .progress-bar (#22579)
* Add box-shadow to .progress-bar

Puts an unused variable back in use for when folks set `$enable-shadows` to `true`.
2017-05-25 21:32:59 -07:00
Mark Otto fba27befef Add transition to .progress-bar
- Pulls in values from v3
- Closes #22371 which didn't use a transition include
2017-04-08 14:40:35 -07:00
Mark Otto eb361fa6c1 Progress line height (#21805)
* remove obvi comments

* proper fix for #21801

- ensures .progress-bar text is vertically centered should the height of the .progress-bar change by matching the line-height and height values
- we can't use flexbox here because the inner text of an element doesn't count as a flex item
2017-01-21 12:32:38 -08:00
Mark Otto a0141aa38e Rewrite progress component without <progress> element
- <progress> element didn't allow animation, labels overlaid, multiple bars, etc.

- Revamps CSS to use something more similar to v3's implementation

- Ditches variant mixin for `bg-` utils

- Rebuilds docs to match, including adding a new Height section for customizing that.

Only potential remaining todo is adding `.sr-only` instances to within the bar. Unsure if that's necessary.
2016-12-30 22:46:00 -08:00
Bardi Harborow 855a67b1d6 Remove IE9 browser hacks. (#21393) 2016-12-22 13:41:31 -08:00
Mark Otto 23301b21cd Remove most border-radius properties and instead use overflow: hidden; to properly round corners of a full progress bar. (#21216)
Fixes #19065.
2016-11-26 18:46:46 -08:00
An Yang af6eaf5438 Progress bar:fix border-radius to use variable progress-border-radius instead of border-radius 2016-07-20 01:03:40 +00:00
Mark Otto 03ec195974 linter overhaul 2016-02-06 12:28:18 -08:00
Chris Rebert 1e37f507d5 Respect $border-rounded inside progress bars too
[skip sauce]
2016-01-11 12:29:50 -08:00
Chris Rebert 46c9f4b143 Add $progress-box-shadow variable
[skip sauce]
[skip validator]
2016-01-09 14:59:08 -08:00
Chris Rebert f547806e88 Remove associated comment too
Erratum from #18658
[ci skip]
2016-01-06 14:42:37 -08:00
Mark Otto d46c7ef565 fixes #18658: no more min-width action on progress bars. we had them in v3 and ended up removing them for additional problems it caused folks. 2016-01-06 14:33:58 -08:00
Chris Rebert 7cfdc771f8 Uncomment Firefox .progress styles; fixes #18536
[skip sauce]
[skip validator]
2015-12-23 23:19:44 -07:00
Chris Rebert a96e522d6a Organize existing .progress styles 2015-12-23 22:35:45 -07:00
Chris Rebert 646580a919 Actually use $progress-bg instead of hardcoded color
Refs #18535
[skip sauce]
2015-12-21 10:57:57 -07:00
Chris Rebert 0917b04711 Actually use $progress-bar-color instead of hardcoded color
Refs #18535
2015-12-21 10:57:57 -07:00
Patrick H. Lauke 3cfbeda08d remove generated content value for progress
as it's currently not displayed, and (in my opinion) would look fugly if
it did appear...
2015-12-11 10:57:45 +00:00
Patrick H. Lauke 97461a51a2 progress bar for IE10+/Edge (radius, use ::-ms-fill, add variant mixins, striped support) 2015-12-11 08:58:11 +00:00
Chris Rebert 43b130022b scss/_progress.scss: Add comments for IE9 CSS hacks
[skip sauce]
[skip validator]
2015-10-31 14:37:22 -07:00
Kevin Kirsche 29e4dd2fba Fix accidental triple colon from :before to ::before conversion
Fix #17288 — Sorry about that!
2015-08-24 15:47:04 -04:00
Kevin Kirsche d51f0a4f81 Use double colons for psuedo elements
Fix #17052
2015-08-24 13:22:10 -04:00
Mark Otto c3373df95f clean out comments that aren't all that helpful 2015-08-17 18:33:34 -07:00
Mark Otto 0ca9b21c34 drop the base (hahaha), no but seriously drop the -base from our vars since it's cleaner 2015-06-22 18:53:04 -07:00
Chris Rebert 82c9038f20 Unquote to avoid NUL chars in the output CSS 2015-05-15 12:17:13 -07:00
Mark Otto ed89be1f44 Remove $line-height-computed
We have it set to `1` right now just to avoid compilation errors, but
it’s been replaced everywhere with our new spacer classes anywho. We’ll
likely want to remap that var to custom component vars though (e.g.,
`$pagination-margin` instead of `$spacer-y`).
2015-04-29 12:00:11 -07:00
Mark Otto fef873a840 fix all validation, turn off some settings, add sort order 2014-12-11 12:05:29 -08:00
Mark Otto 27df020852 convert to scss 2014-12-02 14:02:35 -08:00