Commit Graph

1742 Commits

Author SHA1 Message Date
XhmikosR e5643aaa89
Release v4.6.2 (#36725)
* Bump version to 4.6.2.

* Dist
2022-07-19 18:13:44 +03:00
Patrick H. Lauke b4c994d296
Remove confusing unnecessary id/aria-labelledby for dropdown menus (#36491)
v4 port of https://github.com/twbs/bootstrap/pull/36487
2022-06-03 17:28:18 +01:00
Louis-Maxime Piton 8274bf25d0
Fixing tabs' tests (#36485) 2022-06-02 12:58:43 +03:00
Patrick H. Lauke 7d57d9a68b
Dynamic tabs: use buttons rather than links (backport to v4) (#33163)
* Manually backport 32630

Dynamic tabs: use buttons rather than links

* Tweak unit test

* Tweak unit tests

* More tweakage

* show() should also bail if `disabled` attribute is set

* Tweak tests

* Simplify test for relatedTarget

* Temporarily remove problematic test

(as i can't get local tests to run just noww)

* Revert previous

* test: fix broken test cases for tab.js

* test: fix role=tablist invalid on nav element

* test: prefer <div/> over <div></div>

* Manually backport 32630

Dynamic tabs: use buttons rather than links

* test: fix broken test cases for tab.js

* Fixes

* Remove and ignore lock file

Co-authored-by: alpadev <alpa.muc@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2022-05-24 11:16:58 -07:00
Julien Déramond e4dc2e91a5
Doc: remove `role="group"` from some split drop* buttons (#36254) 2022-05-24 11:04:59 +03:00
XhmikosR d36b1a46cf Fix lint issues 2022-04-19 09:07:15 +03:00
XhmikosR f7cb3639a7 Update devDependencies 2021-12-16 09:23:08 +02:00
XhmikosR 043a03c95a
Release v4.6.1 (#35272)
* Bump version to v4.6.1

* Dist
2021-10-28 17:45:21 +03:00
XhmikosR 41330696b9 Update devDependencies and switch to Node.js 16/npm 8
* @babel/core                      ^7.15.5  →   ^7.15.8
* @babel/preset-env                ^7.15.6  →   ^7.15.8
* @rollup/plugin-commonjs          ^20.0.0  →   ^21.0.1
* @rollup/plugin-node-resolve      ^13.0.5  →   ^13.0.6
* autoprefixer                     ^10.3.6  →   ^10.3.7
* babel-plugin-istanbul             ^6.0.0  →    ^6.1.1
* clean-css-cli                     ^5.3.3  →    ^5.4.2
* eslint                           ^7.32.0  →    ^8.0.0
* eslint-config-xo                 ^0.38.0  →   ^0.39.0
* eslint-plugin-import             ^2.24.2  →   ^2.25.1
* eslint-plugin-qunit               ^6.2.0  →    ^7.0.0
* eslint-plugin-unicorn            ^36.0.0  →   ^37.0.1
* karma                             ^6.3.4  →    ^6.3.5
* linkinator                       ^2.14.0  →   ^2.14.4
* nodemon                          ^2.0.13  →   ^2.0.14
* postcss                           ^8.3.8  →   ^8.3.11
* postcss-cli                       ^9.0.0  →    ^9.0.1
* rollup                           ^2.57.0  →   ^2.58.0
* stylelint-config-twbs-bootstrap   ^2.2.3  →    ^2.2.4
* vnu-jar                           21.9.2  →  21.10.12
2021-10-22 17:07:51 +03:00
XhmikosR fe73da982f JS: minor refactoring
* shorten block comments
* reorder constants
2021-10-22 17:07:51 +03:00
XhmikosR 6d0fd8c3a5 Backport #35074
sanitizer: add `sms` in the `SAFE_URL_PATTERN`
2021-10-22 17:07:51 +03:00
XhmikosR bdab948670 Remove unneeded conditional 2021-09-15 15:44:20 +03:00
XhmikosR af52795501 Remove duplicate test. 2021-09-15 15:44:20 +03:00
XhmikosR f6ff736a59 Change test description so that it's unique 2021-09-15 15:44:20 +03:00
XhmikosR 77e0855e5e Merge duplicate test. 2021-09-15 15:44:20 +03:00
XhmikosR ed62ab6e41 Remove commented out test 2021-09-15 15:44:20 +03:00
XhmikosR d4e162f4ac Skip tests if `attachShadow` is not present 2021-09-15 15:44:20 +03:00
XhmikosR 551f37aff6 tests: comply to the new rules
Use `assert.strictEqual`/`assert.true`/`assert.false`
2021-09-15 15:44:20 +03:00
XhmikosR 5391ecdfde Add eslint-plugin-qunit 2021-09-15 15:44:20 +03:00
XhmikosR e202996a2b Update devDependencies
* @babel/cli                   ^7.14.8  →  ^7.15.5
* @babel/core                  ^7.14.8  →  ^7.15.4
* @babel/preset-env            ^7.14.8  →  ^7.15.6
* @rollup/plugin-commonjs      ^19.0.1  →  ^20.0.0
* @rollup/plugin-node-resolve  ^13.0.2  →  ^13.0.4
* autoprefixer                 ^10.3.1  →  ^10.3.4
* clean-css-cli                 ^5.3.0  →   ^5.3.3
* eslint                       ^7.31.0  →  ^7.32.0
* eslint-config-xo             ^0.37.0  →  ^0.38.0
* eslint-plugin-import         ^2.23.4  →  ^2.24.2
* eslint-plugin-unicorn        ^34.0.1  →  ^36.0.0
* hugo-bin                     ^0.74.0  →  ^0.76.1
* qunit                        ^2.16.0  →  ^2.17.1
* postcss                       ^8.3.5  →   ^8.3.6
* rollup                       ^2.53.3  →  ^2.56.3
* vnu-jar                      21.6.11  →   21.9.2
2021-09-15 15:31:00 +03:00
alpadev b010a6f9f4
fix(modal): change the order we return from show() method (#34087)
In case of a modal with fading enabled, a prevented show event can cause show to not showing the modal anymore.

See #34055

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-07-25 20:36:11 +03:00
Carson Sievert 4b5eb3ca51
Backport #33634 (#33649)
Dropdown: support `.dropdown-item` wrapped in `<li>` tags
2021-04-28 07:02:22 +03:00
Patrick H. Lauke d967553913
Remove aria-haspopup from dropdowns (#33624)
`aria-haspopup="true"` is really intended to signal that an ARIA `menu` will be opened on activation. as a result, some assistive technologies will announce controls with `aria-haspopup="true"` as a menu or menu item (e.g. JAWS and NVDA).
In addition, `aria-haspopup` seems to trigger a bug in Edge/Narrator where the `aria-expanded` state is not correctly announced at the moment when `aria-haspopup` is present.
This now makes the dropdown button more like a generic disclosure widget control - see also https://www.w3.org/TR/wai-aria-practices-1.2/examples/disclosure/disclosure-navigation.html01
2021-04-15 06:35:54 +03:00
XhmikosR 67f873f41a Update devDependencies
* @babel/cli                    ^7.13.0  →  ^7.13.14
* @babel/core                   ^7.13.8  →  ^7.13.14
* @babel/preset-env             ^7.13.9  →  ^7.13.12
* @rollup/plugin-commonjs       ^17.1.0  →   ^18.0.0
* @rollup/plugin-node-resolve   ^11.2.0  →   ^11.2.1
* autoprefixer                  ^10.2.4  →   ^10.2.5
* clean-css-cli                 ^5.2.0  →    ^5.2.2
* eslint                        ^7.21.0  →   ^7.23.0
* eslint-plugin-unicorn         ^28.0.2  →   ^29.0.0
* globby                        ^11.0.2  →   ^11.0.3
* hugo-bin                      ^0.69.0  →   ^0.70.0
* karma                         ^6.1.1  →    ^6.3.2
* postcss                       ^8.2.6  →    ^8.2.9
* qunit                         ^2.14.0  →   ^2.14.1
* rollup                        ^2.40.0  →   ^2.44.0
* stylelint                     ^13.11.0  →  ^13.12.0

Also lock jQuery to v3.5.1 since 3.6.0 has a bug that affects at least our tests
2021-04-05 07:44:39 +03:00
XhmikosR a06c2b6706 BrowserStack: test on iPhone 12 (#33398) 2021-04-05 07:44:39 +03:00
Patrick H. Lauke e16b06929a
Manual backport of #32627 (#33165)
Carousel: use buttons, not links, for prev/next controls
2021-03-11 09:23:46 +02:00
Nikon the Third 7ad0625b8d
Adjust `SAFE_URL_PATTERN` regex for use with `test` method. (#33153)
The `test` method on regexes does not behave like `match` on strings
for checks if the regex matches when the global modifier (g) is present.

Also adds a unit test on tooltips for sanitizing the same template twice.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-03-02 17:16:09 +02:00
XhmikosR c341721439 Partially backport #33045
Simplify karma.conf.js

`customLaunchers` does not seem to be needed.
2021-02-17 06:54:38 +02:00
XhmikosR 2267193d8f Switch to jsDelivr for jQuery too. (#32918) 2021-01-28 23:26:39 +02:00
XhmikosR 17d8fba548
Update devDependencies (#32852)
Pin karma and linkinator due to failures
2021-01-27 18:37:18 +02:00
XhmikosR 6ffb0b48e4
Release v4.6.0. (#32726)
* Bump version to v4.6.0.

* Dist
2021-01-19 18:16:38 +02:00
XhmikosR 0f1069a32e Update karma config
* rename constants
* enforce the constants to be Boolean
* use the coverage plugin only one time, on the latest jQuery run
* fix karma `logLevel`
2021-01-13 10:49:09 +02:00
XhmikosR bb99676a8a BrowserStack: test on macOS Catalina instead of High Sierra (#32486) 2021-01-08 12:04:37 +02:00
XhmikosR 4620b9838b
karma: add `v4` in Browserstack build ID (#32502) 2021-01-08 10:05:56 +02:00
Rohit Sharma 8e59752ee1
Partially backport #32217 (#32225)
Remove unnecessary `_getCustomClass` method.

`customClass` will be in the configuration already, even if it is provided in the data attributes, and jQuery's [`addClass()`](https://api.jquery.com/addclass/) method will handle it, either `this.config.customClass` is a function or a class name (even if it is a blank string).

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-25 09:35:36 +02:00
XhmikosR 57e045f0ab Backport #32224
Be consistent with Popper's name.
2020-11-24 08:40:11 +02:00
XhmikosR 7eee78c517 Backport #32178 and #32182
Handle Chromium to run Karma
2020-11-24 08:40:11 +02:00
Rohit Sharma bfb773d64b
Backport #32179 (#32220)
Don't hide modal when `config.keyboard` is false
2020-11-21 22:14:28 +02:00
James Remeika 2d8c02eb10
tooltip/popover: add a `customClass` option (#31834)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-20 11:56:16 +02:00
Mitchell Bryson 896e444895
Check for data-interval on the first slide of carousel - v4 (#31820)
When starting a cycle for a carousel, it only checks for a default interval, and not an interval defined on the slide element via data props. This adds a check in before creating the interval to move to the next slide.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-12 09:34:17 +02:00
XhmikosR b3aa3958da Backport #32045
tests: fix sanitizer test.

The test template does not include a `script` tag so the test always returned true.
2020-11-05 11:22:05 +02:00
XhmikosR 5664e728b4
Move js/src/index.js one folder up (#32001) 2020-11-01 07:31:17 +02:00
Patrick H. Lauke 5f1bc4a756 Remove redundant visually hidden "(current)" from pagination controls (#31892)
* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
2020-10-27 12:11:01 +02:00
XhmikosR a716fb03f9
Prepare v4.5.3. (#31880) 2020-10-13 18:38:30 +03:00
XhmikosR c049713382 Remove the unused js/dist/index.js.map 2020-10-13 15:24:40 +03:00
XhmikosR 1b48122641 Update .eslintrc.json
Enforce ES5 for tests
2020-10-13 15:24:40 +03:00
Laussel Loïc 24572b1577
buttons plugin : avoid multiple change event trigger (#31000)
- add unit test to count how many events are thrown when widget contains multiple tags inside label
- add a parameter to toggle, if click event is provided onto an input then don't trigger another change event already thrown by the browser
- simplify the case where toggle interface is called click provide from input itself OR it's a button without label. If label is present, then browser propagate click event from childrens through label and then cause multiple calls to toggle
- the test assumes that `.btn` class is always set onto the label if there's one, otherwise need to update this plugin and look for label around the input

Test with keyboard, mouse and js click call

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-10-02 17:40:20 +03:00
XhmikosR 31eb108811 Add parentheses around multiple spread conditions 2020-09-21 14:58:34 +03:00
XhmikosR b31046aab3 Cache a few variables. 2020-09-21 14:58:34 +03:00
XhmikosR c86b74fe88 Unbreak lines and remove a TODO comment 2020-09-21 14:58:34 +03:00