ec8166a90f
fix: fix possible bug on event handler. ( #36561 )
...
some browsers validate the empty object as `true`, so is safer to use an explicit check
2022-06-14 08:33:53 +03:00
ae3442041c
Fix typo in dropdown unit test
2022-06-08 15:23:03 -07:00
37cf7d11b9
Scrollspy: enable smooth-scroll behavior ( #36528 )
2022-06-08 22:35:09 +03:00
8965b11dd5
Remove confusing unnecessary id/aria-labelledby for dropdown menus ( #36487 )
...
see https://github.com/twbs/bootstrap/discussions/35755
Note that even the APG guide for disclosure widgets doesn't use this optional "nice-to-have" extra bit https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/ (though they do use `aria-controls`, which in most current browser/AT combos is borked though)
2022-06-03 11:18:22 +01:00
c137d11aa2
Re-ordering js default objects
2022-06-01 19:24:45 -07:00
d388bd6e1b
JS: tests fixes & standardization of spies usage ( #36398 )
...
* Fix carousel spec typo
* Change carousel test name in align with testing method
* Make the spies declarations the same everywhere
2022-05-31 11:18:32 +03:00
8959bf3f0b
Docs: quick fixes for HTML ( #36395 )
...
* Using the new helper in the doc
* Remove input from `Tab` access
* Change scrollspy code examples
* Reordering tables for JS
* Fix for parcel file
* Center align all the code example texts in layout
* Alphabetical reorder the helpers
2022-05-20 10:21:48 -07:00
b5a956781f
Assorted Event handler patches ( #36171 )
...
* EventHandler: rename functions & variables
* EventHandler: export event hydration to function
* EventHandler: rename variable
* EventHandler: simplify checks and make use of one variable
Move check of falsie delegated-selector, caused by tooltip.js
* EventHandler: more renaming
* Update event-handler.js
* bump bunldewatch
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2022-05-16 07:59:50 -07:00
fca04c0713
Dist
2022-05-13 19:44:01 +03:00
f7e8ca91e0
Prepare v5.2.0-beta1
2022-05-13 19:44:01 +03:00
b167420bdf
Revert backdrop utilization, handling clicks over modal ( #36324 )
...
* refactor(Modal.js): stop using backdrop class to handle clicks over modal
* Revert #35554 and backdrop callback usage
Explanation: In order to bypass `.modal`, was applied a css rule `pointer-events:none` which caused the side effect, and user couldn't scroll "long content modals"
* Update .bundlewatch.config.json
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2022-05-12 21:20:04 -07:00
4a682ab00a
Toast: provide `isShown` method ( #36272 )
...
* feat(Toast): provide `isShown` method
* Update site/content/docs/5.1/components/toasts.md
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
2022-05-06 21:29:21 -07:00
5d9500bdfd
Handle disabled focused tabs with tab JavaScript plugin ( #36169 )
...
* Handle disabled tabs
* Fix after feedback
* Update js/src/tab.js
Co-authored-by: GeoSot <geo.sotis@gmail.com>
* Update js/src/tab.js
Co-authored-by: GeoSot <geo.sotis@gmail.com>
* Commit suggestions via GitHub broke the thing
* Add some unit tests
* Remove temp doc modification
* Add tests for left arrow
* Add disabled tabs in JavaScript Behavior section
* Compact 4 tests to 2 tests
* Compact 4 tests to 2 tests
* Add 'disabled' attribute for all buttons
* Change the disabled pane position only for the vertical version
* Change ids for the confusing first example in JavaScript behavior
* Use disabled attribute instead of the class for buttons in tabs
Co-authored-by: GeoSot <geo.sotis@gmail.com>
2022-05-05 19:26:15 -07:00
ec41392717
Doc: remove `role="group"` from some split drop* buttons
2022-04-30 11:35:44 -07:00
3edead4ffe
EventHandler: change check method for custom events, avoiding regex
2022-04-25 19:52:27 -07:00
554736834d
Carousel: Fix not used option (`ride`), simplify `cycle` method ( #35983 )
...
* Fix not used option (`ride`) (according to docs), continuing of #35753 a247fe9
2022-04-21 22:42:17 +03:00
584600bda3
Manipulator: Add JSON parse support ( #35077 )
...
Support parsing JSON from each component's main element using the `data-bs-config` attribute.
The `bs-config` attribute will be reserved and omitted during `getDataAttributes` parsing.
With this commit, every component, will create its config object, using:
* defaults
* data-bs-config
* the rest of data attributes
* configuration object given during instance initialization
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2022-04-21 21:41:43 +03:00
195440f2fb
v5.2.0 design refresh, plus responsive offcanvas classes ( #35736 )
...
* Add responsive offcanvas classes
- Updates navbar-expand classes to de-dupe some styles—these shouldn't interfere now.
- Adds some JS to the offcanvas component to help with responsiveness
Co-Authored-By: GeoSot <geo.sotis@gmail.com>
* Redesign homepage, docs, and examples
Homepage:
- New Bootstrap purple navbar
- Redesigned masthead
- Rewrote and redesigned homepage content
- Replace Copy text with icons like Bootstrap Icons site across all ClipboardJS instances
- Fixed padding issues in site footer
- Match homepage button styles to examples page, use gap instead of tons of responsive margin utils
Docs:
- New navbar, no more subnav. Migrated search and version picker into the main navbar and refreshed the design of it all, including the responsive toggles.
- New sidebar navigation is always expanded, and now features Bootstrap Icons alongside section headings
- Sidebar navigation autoscrolls to active link for better usability
- Subnav and navbar padding issues ironed out
- Enhanced the version picker in anticipation of v5.2: we can now link right to the same page in the previous version.
- Redesign callouts to add more color to our pages
- Collapse table of contents on mobile
- Cleanup and redesign button styles with CSS variables
- Update design for subnav version dropdown
- Update highlight and example to be full-width until md
- Improve the Added In badges
- Turn the ToC into a well on mobile
- Redesign code snippets to better house two action buttons
Examples:
- Redesign Examples page layout
- Add new example for responsive offcanvases in navbars
* Convert offcanvas to CSS vars
* Feat: add resize handler to Offcanvas.js.
If we could use as default the `.offcanvas` class without modifiers, we then, could add a simplified selector
The selector itself, ignores the .offcanvas class as it doesn't have any responsive behavior
The `aria-modal` addon is to protect us, selection backdrop elements
* Separate examples code, Add some selectors, fix stackblitz btn
Co-authored-by: GeoSot <geo.sotis@gmail.com>
2022-04-17 22:17:50 -07:00
ece1601227
Revamp Scrollspy using Intersection observer ( #33421 )
...
* Revamp scrollspy to use IntersectionObserver
* Add smooth scroll support
* Update scrollspy.js/md
* move functionality to method
* Update scrollspy.js
* Add SmoothScroll to docs example
* Refactor Using `Maps` and smaller methods
* Update scrollspy.md/js
* Update scrollspy.spec.js
* Support backwards compatibility
* minor optimizations
* Merge activation functionality
* Update scrollspy.md
* Update scrollspy.js
* Rewording some of the documentation changes
* Update scrollspy.js
* Update scrollspy.md
* tweaking calculation functionality & drop text that suggests, to deactivate target when wrapper is not visible
* tweak calculation
* Fix lint
* Support scrollspy in body & tests
* change doc example to a more valid solution
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
2022-04-13 10:29:13 -07:00
cfd2f3f778
Update dropdown.js
...
minor refactoring
2022-04-13 08:41:03 -07:00
135b9cdff2
Revamp tabs & follow ARIA 1.1 practices ( #33079 )
...
* Tab: Revamp tab.js & add support Aria features
* Tab: Add tab support, just to keep backwards compatibility. Better to remove it on v6
* Revert "Tab: Add tab support, just to keep backwards compatibility. Better to remove it on v6"
* Support arrow down/up functionality
* add prevent default to avoid scrolling the page during up/down keys handling
* remove panel tabindex handling
* Expand documentation text for JS plugin
* Rearrange new docs to specifically call out a11y
* properly place section
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2022-04-06 16:36:08 -07:00
0e5cd69c02
No propagating escape event in an open dropdown.
2022-03-19 01:43:43 +02:00
6e904341c9
Carousel: change class check as it can only exist if carousel is sliding
...
Also, fix the corresponding test
2022-03-10 15:22:14 +02:00
3673933fe7
Carousel: rename private property
2022-03-10 15:22:14 +02:00
ec0e1c220e
Carousel: add comment for future fixes
2022-03-10 15:22:14 +02:00
88da704eed
Carousel: omit redundant checks as we are always transforming the right values
2022-03-10 15:22:14 +02:00
28f150d720
Carousel: omit config merging in jQueryInterface after we create the instance
...
This is already done inside `getOrCreateInstance` method
2022-03-10 15:22:14 +02:00
7e5a8016ba
Carousel: return early in `_slide` method
2022-03-09 17:25:47 +02:00
d4e87d28cd
Carousel: small refactoring, remove unnecessary checks
2022-03-09 17:25:47 +02:00
dd93551914
Carousel: refactor using inline function and move variables to the proper place
2022-03-09 17:25:47 +02:00
699402bee5
Carousel: refactor `_slide` method te accept only order as first argument
2022-03-09 17:25:47 +02:00
fcc2c80976
Carousel: add a `getItems` helper
2022-03-09 17:25:47 +02:00
b7cce49dbc
Carousel: use combined selector and drop variable used once
2022-03-09 17:25:47 +02:00
a8142497c7
Carousel: reorder variables and refactor method to use it inline
2022-03-09 17:25:47 +02:00
e77ae50311
Carousel: cleanup jQueryInterface
...
Drop chained else ifs and unused variable.
Since we were checking for `typeof config === 'string'` in both places, action was never `_config.slide`.
2022-03-09 17:25:47 +02:00
6c40476af9
Fix dropdowns
2022-03-08 14:37:44 -08:00
8d7358f231
Add static backdrop to offcanvas ( #35832 )
...
* Add static backdrop option, to offcanvas
* Trigger prevented event on esc with keyboard=false
* Change offcanvas doc , moving backdrop examples to examples section
2022-03-02 02:20:37 +02:00
63f30ac8ee
Modal: refactor listeners to reduce some code noise ( #35902 )
2022-03-01 17:08:12 +02:00
c644f09d88
Carousel: simplify carousel items selection
...
We already know that carousel's parent is the carousel element, so we can use it explicitly
2022-03-01 16:56:33 +02:00
eb8d5b43ce
Carousel: move `carouselInterface` inside `jqueryInterface`
2022-03-01 16:56:33 +02:00
13042d25ca
Carousel: move logic of `dataApiClickHandler`
2022-03-01 16:56:33 +02:00
631cec4f70
Carousel: refactor dataApiKeyHandler to avoid use of `carouselInterface`
2022-03-01 16:56:33 +02:00
bb7664db0a
Dropdown: Simplify dataKeyApiHandler ( #35870 )
...
* Dropdown.js: Remove duplicated check for `Not Shown` instance
* Dropdown.js: Rearrange `dataApiKeydownHandler` checks
* Dropdown: do some fixup inside `dataApiKeydownHandler`
* Update dropdown.js
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2022-03-01 15:53:07 +02:00
7a74f2c302
add tests
2022-02-28 14:02:51 -08:00
c0f30366ac
Add centered dropdown and dropup options
2022-02-28 14:02:51 -08:00
e4b62a920a
src/tooltip.js Optimization
...
Util.findShadowRoot() returns either null or an object.
It cannot return falsy, which allows this optimization.
2022-02-25 09:01:49 -08:00
cb8726d9e7
Dropdown: use a better selector to avoid triggering click if button is disabled ( #35866 )
2022-02-19 16:22:32 +02:00
353ad45b4b
Dropdown: use a combined selector to filter foreign not shown instances iteration ( #35766 )
2022-02-19 16:16:51 +02:00
4b17868fb4
tests: revisit all tests using Promise.reject instead of throwing an error ( #35765 )
2022-02-19 16:08:16 +02:00
407af8ac7f
Make event name helper and use it on tooltip & popover to reduce dist sizes ( #35856 )
...
* feat: create eventName getter function in baseComponent
* refactor: use `eventName` getter on tooltip & popover
2022-02-19 15:10:47 +02:00
642d756eea
Carousel: remove one more call to ActiveIndex
2022-02-19 14:52:36 +02:00
d52f6c9de1
Carousel: change argument to `_setActiveIndicatorElement`, from element to index
2022-02-19 14:52:36 +02:00
928bdcadc5
Carousel: make direct triggering of slid event, instead of using a callback
2022-02-19 14:52:36 +02:00
d97125475b
Carousel: merge slide functionality, regardless of whether it is animated or not
2022-02-19 14:52:36 +02:00
a247fe9b27
Carousel: simplify initialization on document load, using `getOrCreateInstance`
2022-02-19 14:52:36 +02:00
ccba6a3589
Carousel: remove redundant config merge on `dataApiClickHandler`, as it is done by default in the `constructor`
2022-02-19 14:52:36 +02:00
42da2b9556
Update devDependencies ( #35841 )
...
* Update devDependencies
* @babel/core ^7.17.0 → ^7.17.2
* @rollup/plugin-replace ^3.0.1 → ^3.1.0
* eslint ^8.8.0 → ^8.9.0
* eslint-config-xo ^0.39.0 → ^0.40.0
* hugo-bin ^0.80.1 → ^0.80.2
* karma ^6.3.15 → ^6.3.16
* rollup ^2.67.1 → ^2.67.2
* Fix new ESLint errors
2022-02-15 08:50:37 +02:00
d3babf7d7f
Remove remaining `.navbar-light` classes ( #35814 )
...
* Fix typo in CSS variables documentation
* Drop remaining .navbar-light classes
2022-02-09 21:12:08 +02:00
a805330f63
Optimize jQueryInterface in Collapse ( #35689 )
...
extracts config initialization from cycle
2022-02-07 10:50:26 +02:00
cf7fec8a2e
event-handler.js: remove unneeded return statement
2022-02-01 12:43:19 +02:00
a1e924c4da
Event-handler: use `Array.find` instead of `for`
2022-02-01 12:43:19 +02:00
fc7c5fcb7a
Event-handler: initialize variable properly
2022-02-01 12:43:19 +02:00
3f7b31e0e0
Fix Popover test that randomly fails on BrowserStack ( #35757 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2022-02-01 10:33:18 +02:00
c44d99f55c
Dropdown: use destructured variables in `dataApyKeydownHandler`
2022-02-01 08:58:46 +02:00
c14fc989df
Dropdown: dropdown doesn't document `data-bs-target` option & `parentNode` is ALWAYS the wrapper for toggle & menu
2022-02-01 08:58:46 +02:00
d105439235
Dropdown: merge instance identification in `dataApiKeydownHandler`
...
As we use the `dataApiKeydownHandler` only for events that are triggered on `[data-bs-toggle="dropdown"]` or on `.dropdown-menu`, we can ensure that their `parentNode` will ALWAYS be the `.dropdown` wrapper
2022-02-01 08:58:46 +02:00
7f04f84bf8
Dropdown: use only one check for shown state
2022-01-30 18:01:09 +02:00
5f1c542d67
Dropdown: get dropdown's parent in one place
2022-01-30 18:01:09 +02:00
74f24cdf24
More tooltip refactoring ( #35546 )
...
* Tooltip.js: move `shown` check to method
* Tooltip.js: move Popper's creation to method
* Tooltip.js: merge checks before `hide`
* Tooltip.js: minor refactoring on `toggle` method
2022-01-30 17:39:03 +02:00
882185bbde
Change selector-engine.js `parents` method to utilize better js native methods ( #35684 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2022-01-30 16:24:03 +02:00
89f88762c5
Fix visual tests ( #35585 )
...
* Fix visual tests
They broke in #34509
* load bundle.js in visual tests
Co-authored-by: GeoSot <geo.sotis@gmail.com>
2022-01-30 16:12:24 +02:00
dcbe7b6f31
Modal.js: remove unnecessary checks from test
2022-01-30 15:39:34 +02:00
28c9002573
Modal: handle click event from backdrop callback
2022-01-30 15:39:34 +02:00
aa650f0f1e
tests: replace 'done' callback with 'Promise' to fix deprecation errors ( #35659 )
...
Reference:
https://jasmine.github.io/tutorials/async
'DEPRECATION: An asynchronous function called its 'done' callback more than once. This is a bug in the spec, beforeAll, beforeEach, afterAll, or afterEach function in question. This will be treated as an error in a future version. See<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times > for more information.
2022-01-30 14:30:04 +02:00
d092817059
Event handler: merge `new Event` with `new CustomEvent`
2022-01-30 14:15:17 +02:00
fa93995123
Event handler: replace deprecated `initEvent`
2022-01-30 14:15:17 +02:00
0840105d7f
SelectorEngine: remove moot space
2022-01-29 13:25:30 +02:00
558002f3dc
Return early in more places
2022-01-29 13:25:30 +02:00
7d3bc44bb0
dropdown: Move constant
2022-01-29 13:25:30 +02:00
a8887ea8a8
collapse: merge class toggling
2022-01-29 13:25:30 +02:00
b5147ec218
event-handler.js: use `for...of`
2022-01-29 13:25:30 +02:00
62d86c07f8
Rename variables
2022-01-29 13:25:30 +02:00
3ac4451d47
backdrop.js: cache `_getElement` calls
2022-01-29 13:25:30 +02:00
0c3dfe104b
Remove a few unneeded variables
2022-01-29 13:25:30 +02:00
14c7dc1e88
Fix: `isVisible` function behavior in case of a `<details>` element, on chrome 97 ( #35682 )
2022-01-13 10:55:05 +02:00
0d054bb0f1
Remove explicit use of aria-hidden for offcanvas when closed ( #35589 )
...
Remove explicit use of aria-hidden & visibility for offcanvas when closed, handling it with css
Co-authored-by: GeoSot <geo.sotis@gmail.com>
Co-authored-by: Gaël Poupard <ffoodd@users.noreply.github.com>
2022-01-05 19:20:15 +02:00
0d4213bde3
Carousel: move repeated code to a method
2021-12-21 17:37:24 +02:00
b8ee68cfa0
Carousel: remove always true `visibilityState` check
...
According to https://developer.mozilla.org/en-US/docs/Web/API/Document/visibilityState `visibilityState` is always a string, so the check was always true
2021-12-21 17:37:24 +02:00
ff4bf4a458
Carousel: move carousel default interval to `_getConfig()` and simplify it
2021-12-21 17:37:24 +02:00
6f79721c82
Carousel: return early and drop a loop.
...
We can achieve the same thing by querying the specific selector directly
2021-12-21 17:37:24 +02:00
d60f146507
Carousel: add a helper to get the active element
2021-12-21 17:37:24 +02:00
65cf77ae3e
Popover/Tooltip: Fix vertical alignment on arrow of tip elements ( #35527 )
...
Regression of #32692
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-21 17:19:29 +02:00
c2db7108c2
Fix typo in comment ( #35564 )
...
s/moddal/modal
2021-12-18 07:58:31 +02:00
e0960b08e0
Tooltip: remove extraneous call to _getConfig() ( #35540 )
...
BaseClass already initializes the config
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-15 10:47:32 +02:00
d40fae456e
Popover.js: Accept empty content through `data-bs-content` ( #35514 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-15 10:41:31 +02:00
cd04fe015f
Scrollspy: minor refactoring ( #35512 )
...
* reorder variables
* join lines
* use `filter(Boolean)` since it's clearer
* use `for...of`
2021-12-15 09:38:06 +02:00
886b940796
Extract Component config functionality to a separate class ( #33872 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-10 18:18:18 +02:00
63d38b1974
Tab: minor refactoring ( #35511 )
...
* remove unneeded parentheses
* move variable
2021-12-10 07:51:57 +02:00
871c8bdd3f
util/index.js: minor refactoring ( #35510 )
...
* rename variables
* remove an unused variable
* be more explicit
* reuse variable
2021-12-10 07:48:04 +02:00
eaa801c899
Toast: join multiple classList calls ( #35507 )
2021-12-10 07:42:08 +02:00
94d4fa3b10
Fix tests fixture type ( #35501 )
...
Previously we were adding an Array instead of a String
2021-12-09 16:01:29 +02:00
28a5a72ed5
Scrollbar - remove margin/padding properties properly ( #35388 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-09 15:49:28 +02:00
c376cb0763
Dropdown: fix toggle focus after dropdown is hidden using the `ESC` button ( #35500 )
2021-12-09 15:34:17 +02:00
4fd5539c75
ScrollBar.js. Minor refactoring and add test ( #35492 )
2021-12-09 15:05:50 +02:00
328f723008
Tooltip: remove title attribute before show & add tests ( #35456 )
2021-12-07 15:51:56 +02:00
d8999dd566
Tests: Minor fixes ( #35455 )
2021-12-02 12:01:11 +02:00
385fea49e8
Tooltip/Popover: add underscore prefix to protected functions
2021-12-01 18:00:36 +02:00
bd79d69a73
Tooltip: a simple code-block position change
2021-12-01 18:00:36 +02:00
1f7b83203d
Tooltip: simplify popper check
2021-12-01 18:00:36 +02:00
9b9372e8dd
Tooltip: refactor `_hoverState` to Boolean to achieve better control
2021-12-01 18:00:36 +02:00
8eacbaa08b
Tooltip: merge timeout functionality
2021-12-01 18:00:36 +02:00
c69ccba08c
Tooltip: Change `_enter` & `_leave` to work without arguments
2021-12-01 18:00:36 +02:00
a20e4203fe
Tooltip: Remove redundant `config.delay` check
...
`config.delay` is always an object after initialization
2021-12-01 18:00:36 +02:00
724663b3cd
Tooltip: Remove `Data.set` usage for dynamically created tip
...
This is not used any further, so we were just setting it.
2021-12-01 18:00:36 +02:00
3baeb0a5c1
Tooltip: merge `isAnimated` checks
2021-12-01 18:00:36 +02:00
53c77c0203
Tooltip: refactor jQueryInterface
2021-12-01 18:00:36 +02:00
dd07c1ff9e
Dropdown: clearMenus is always an event callback
2021-12-01 17:10:39 +02:00
f71640f048
Dropdown: Clean more
2021-12-01 17:10:39 +02:00
21e5618ba7
Dropdown: rename vars
2021-12-01 17:10:39 +02:00
0686fa00f0
Dropdown: Remove redundant `Space` check
2021-12-01 17:10:39 +02:00
a14a552d83
Dropdown: Deduplicate complex check
2021-12-01 17:10:39 +02:00
bff95d55af
Dropdown: Remove redundant check since the `show` method already does it
2021-12-01 17:10:39 +02:00
2d32802f53
Dropdown: Change constant to the way we use it
2021-12-01 17:10:39 +02:00
fb5921dec4
Dropdown: Merge `display='static'` & `isNavbar` functionality activating static popper with no styles attached
2021-12-01 17:10:39 +02:00
137b324930
Dropdown: Remove static method used once
2021-12-01 17:10:39 +02:00
8b308b76f0
Dropdown tests: Use a function to improve readability ( #35448 )
2021-12-01 16:49:02 +02:00
cab62af2e6
Fix popover arrow & tooltip template after the `setContent` addition ( #35441 )
2021-12-01 15:10:10 +02:00
44a6cd724c
Tooltip: remove leftover method ( #35440 )
...
Remove a leftover after #32692
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-01 14:53:56 +02:00
e5d8256e42
tests/unit/util/scrollbar.spec.js: rename function
...
`parseInt` is a global one.
2021-12-01 14:30:49 +02:00
11ce6c2dcd
tests: fix a few typos
2021-12-01 14:30:49 +02:00
f8f9dc3b5c
tests: remove extra spaces, unneeded arrays and add missing newlines
2021-12-01 14:30:49 +02:00
eb54e1a1ce
tests: tweak Jasmine's matchers usage
...
Use:
* toBeNull
* toEqual
* toBeTrue
* toBeFalse
* toHaveSize
* toHaveClass
2021-12-01 14:30:49 +02:00
5739bf7637
tests/browsers.js: remove unneeded export
2021-12-01 14:30:49 +02:00
1692fc6b4b
Alert: add a couple more tests ( #35419 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-11-29 14:32:11 +02:00
3129ff075b
BaseComponent: add a couple more tests ( #35410 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-11-29 14:27:03 +02:00
6f077ff7bc
Clean tooltip component unneeded functionality ( #32692 )
2021-11-25 20:08:11 +02:00
374eeecfbc
tooltip.js: use array.includes instead of for iteration ( #35127 )
2021-11-25 19:39:13 +02:00
91ad255e07
Change adjustDialog's if conditions to improve readability
2021-11-25 19:23:49 +02:00
569bca54d2
Add test for modal-content
2021-11-25 19:23:49 +02:00
0f9fd75d6c
Respect modal's initial overflowY
2021-11-25 19:23:49 +02:00
cc3e5789ec
Remove some uncovered code that seems to be unused
2021-11-25 19:23:49 +02:00
92e664c921
Change check for dynamic modal
2021-11-25 19:23:49 +02:00
fc33ce4b46
Tweak methods
...
Name them to be more descriptive and have agnostic functionality
2021-11-25 19:23:49 +02:00
79e01c3bad
Some refactoring on modal, to improve readability and generic functionality
2021-11-25 19:23:49 +02:00
94a596fbcb
Add a template factory helper to handle all template cases ( #34519 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-11-25 19:14:02 +02:00
367caea501
Update devDependencies ( #35322 )
...
* cspell ^5.12.4 → ^5.12.6
* eslint ^8.1.0 → ^8.2.0
* eslint-plugin-unicorn ^37.0.1 → ^38.0.1
* hugo-bin ^0.76.1 → ^0.77.2
* karma ^6.3.7 → ^6.3.8
* linkinator ^2.14.4 → ^2.14.5
* postcss-cli ^9.0.1 → ^9.0.2
* rtlcss ^3.4.0 → ^3.5.0
2021-11-09 08:02:36 +02:00
b991a6b851
tests: try to fix a few random failures ( #35184 )
...
* Change `Swipe` dispose spy on EventHandler
* Modal hide spy on backdrop hide
2021-10-13 17:45:39 +03:00
9640e2d5dd
Change the way collapse handles its children on opening
2021-10-13 16:38:27 +03:00
1eea132866
collapse: extract duplicate code to a function
2021-10-13 16:38:27 +03:00
e8f702666f
JS: minor refactoring ( #35183 )
...
* add missing comments
* shorten block comments
* reorder constants
* reorder public/private methods
* sort exports alphabetically in util/index.js
* fix a couple of typos
2021-10-13 15:19:28 +03:00
GeoSot
Julien Déramond
Patrick H. Lauke
louismaxime.piton
XhmikosR
Mark Otto
Mark Otto
Jann Westermann
Дилян Палаузов
Anton
Ryan Berliner
Phil E. Taylor