Commit Graph

68 Commits

Author SHA1 Message Date
Patrick H. Lauke 8965b11dd5
Remove confusing unnecessary id/aria-labelledby for dropdown menus (#36487)
see https://github.com/twbs/bootstrap/discussions/35755

Note that even the APG guide for disclosure widgets doesn't use this optional "nice-to-have" extra bit https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/ (though they do use `aria-controls`, which in most current browser/AT combos is borked though)
2022-06-03 11:18:22 +01:00
Julien Déramond ec41392717 Doc: remove `role="group"` from some split drop* buttons 2022-04-30 11:35:44 -07:00
Julien Déramond d3babf7d7f
Remove remaining `.navbar-light` classes (#35814)
* Fix typo in CSS variables documentation

* Drop remaining .navbar-light classes
2022-02-09 21:12:08 +02:00
XhmikosR 89f88762c5
Fix visual tests (#35585)
* Fix visual tests

They broke in #34509

* load bundle.js in visual tests

Co-authored-by: GeoSot <geo.sotis@gmail.com>
2022-01-30 16:12:24 +02:00
XhmikosR 730566221f
visual tests: add missing base-component dist file (#33167)
Regression of #32313
2021-02-22 08:42:43 +02:00
Théophile Helleboid - chtitux 80557b3ac0
Move "active" class from `.nav-item` to `.nav-link` (#32730) 2021-01-08 20:53:04 +02:00
Johann-S adfdf7160b Update to popper.js v2.x 2020-12-06 18:42:40 +02:00
Gaël Poupard 9488978fb5 feat(RTL): implement RTL
Using RTLCSS directives, renaming things to use logical names and following best practices.
2020-12-04 07:52:03 +02:00
XhmikosR f4457bca02
Be consistent with Popper's name. (#32224)
The npm package is named "popper.js" but the project is named "Popper", so use the latter consistently.
2020-11-21 16:22:08 +02:00
Rohit Sharma 418f17ee2b Add `bs` in data attributes
- Add `bs` in data APIs everywhere
- Update unit tests
2020-11-14 07:09:15 +02:00
XhmikosR 13572a6867 Remove the now unneeded polyfills. 2020-11-05 15:37:34 +02:00
XhmikosR 5a3f273b60
Move `href` attribute first (#31835) 2020-10-22 09:38:15 +03:00
Patrick H. Lauke 836a4c0bd6
Remove redundant visually hidden "(current)" from pagination controls (#31892)
* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
2020-10-14 11:59:43 +01:00
Patrick H. Lauke 10690dd317
Rename `sr-only`/`sr-only-focusable` (#31139)
* Rename `sr-only`/`sr-only-focusable`

To be more representative of the fact that these are not necessarily "screen reader" specific, but actually apply to assistive technologies in general (and also things like Alexa/Siri/etc). Goes hand-in-hand with #31133

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-07-03 14:38:11 +03:00
Martijn Cuppens c48d89cb70 Use unordered lists in dropdown-menus 2020-03-31 22:52:57 +02:00
Johann-S e101ba4989 add polyfill.js in visual tests (#29116) 2019-07-24 08:19:47 +03:00
XhmikosR 438e01b61c Rename `eventHandler` and `selectorEngine` files. 2019-05-08 17:26:37 +03:00
Johann-S ad0f5f153c fix remove files in our visual tests 2019-03-18 01:11:05 +02:00
XhmikosR d5f9107abb
Remove the now unneeded `shrink-to-fit` directive. (#28314) 2019-02-27 17:47:41 +02:00
Johann-S c44db783bf chore(update): bump to 4.1.3 2019-02-20 22:05:45 +02:00
Johann-S 5dcca44fcf fix(visual-test): remove jquery in them 2019-02-20 22:05:45 +02:00
Johann-S 6b0808354d fix(unit-test): dropdown, collapse and carousel 2019-02-20 22:05:45 +02:00
Johann-S 90261b484c Dropdown without jQuery 2019-02-20 22:05:45 +02:00
Johann-S 0b16c8c6d9 alert without jquery 2019-02-20 22:05:45 +02:00
Johann-S fb465c4745 Remove jQuery from Util.js
s
2019-02-20 22:05:45 +02:00
Patrick H. Lauke 4b00aa6c4e Remove incorrect aria-haspopup from dropdown toggles (#28299)
`aria-haspopup` use requires the use of an ARIA `menu`, `listbox`, `tree`, `grid` or `dialog` (see https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup)

in our use (as generic disclosure widgets), it's incorrect and sets up the wrong assumption/behavior from assistive technologies.

in future, we likely want to change our dropdowns to essentially be like a `dialog` - move focus to it when opened, possibly make it modal so focus is maintained inside it and the rest of the page
is hidden/inert.

but for now, removing the incorrect attribute is probably the quickest, most immediate fix.
2019-02-19 11:25:36 +02:00
XhmikosR 3aeda9942d
tests: use jQuery from node_modules. (#28059) 2019-01-15 18:01:40 +02:00
Mark Otto eda851ee76 Prep for v4.2.0 release
- Move 4.1 docs to 4.2
- Update versions everywhere to 4.1.3 with release script
- Manually bump the shorthand version in package.json
- Add 4.2 to the versions docs page
- Update some redirects
- Fix tests asset URLs
- Bump Nuget and more
2018-12-21 09:03:29 -08:00
XhmikosR 07b4b5907b
Revert "Remove now unnecessary shrink-to-fit viewport directive (#27818)" (#27855)
This reverts commit af484dc12c.
2018-12-16 16:39:48 +02:00
Patrick H. Lauke af484dc12c
Remove now unnecessary shrink-to-fit viewport directive (#27818)
`shrink-to-fit=no` is not needed anymore - Apple removed the need for it from iOS9.3 onwards

See https://www.scottohara.me/blog/2018/12/11/shrink-to-fit.html and https://github.com/h5bp/html5-boilerplate/issues/2102
2018-12-15 01:05:49 +00:00
XhmikosR ea575bc1a7 js/tests/visual: fix popper script.
Broken after 787441d.
2018-10-14 08:17:40 +03:00
XhmikosR 339311ddb5 Fix invalid selectors in tests and examples. 2018-10-14 08:17:40 +03:00
Johann-S d18045210c fix(tests): visual plugins tests 2018-07-23 17:29:53 -07:00
Swardu c3caf7ee4e Docs/examples: change links to Sass documentation and example.com to https 2018-04-12 11:56:33 +01:00
Johann-S 65ae622d40 Dropdown - Allow to disable Popper.js style (#24092)
* Dropdown - Allow to disable Popper.js style

* Update dropdown.js

* Update dropdown.html

* copy changes
2018-02-11 16:45:59 -08:00
719media bd9084d249 Update dropdown.js to allow referenceElement (#25219) 2018-01-21 19:09:23 +01:00
Johann-S e454c8ec1e Add dropright and dropleft (right and left placements for our dropdown) (#23860)
* Add dropright (right placement for our dropdown)

* Add dropleft

* moves drop left arrow to the left
2017-10-29 15:29:13 -07:00
XhmikosR 2ef5b90136 Tighten htmllint's rules. (#24471) 2017-10-22 15:02:24 +03:00
XhmikosR ee574b76a7 Switch to lowercase `doctype`. (#24217)
Having it uppercase doesn't offer anything and the lowercase version slightly improves gzip compression.
2017-10-03 19:34:59 +03:00
Mark Otto 36e482ed27 update navbars to rename .navbar-inverse to .navbar-dark, update all navbar examples and variables 2017-06-25 18:29:43 -07:00
Johann-S 2d87895089 Update path to our docs assets for visual tests 2017-06-04 11:08:31 +02:00
Johann-S 70f4a30def Better management of dropdown/dropup with alignment 2017-05-22 16:14:10 +02:00
Johann-S b36d8ae6cb Use popper to align dropdown menu instead of using css with important 2017-05-17 22:03:11 +02:00
Johann-S 53ee455bc7 Handle dropup for Dropdown 2017-05-14 11:41:19 +02:00
Johann-S 54a8ab4011 Begin to use Popper for Dropdown 2017-05-14 11:41:19 +02:00
Mark Otto 90c5f6230b rename from .navbar-toggleable to .navbar-expand to reflect mobile first approach everywhere else 2017-03-23 23:02:28 -07:00
Mark Otto 11ba308b2f more docs updates 2017-03-23 23:02:28 -07:00
Mark Otto e2b6badb86 v4: Rip out IE compatibility mode meta tags (#21483)
* Remove IE compatibility mode meta tag from docs, examples, and JS tests as we no longer support IE9 and IE8
* update and remove some IE bits from our supported browser page
* update introduction.md to match
* reword starter template intro
2016-12-31 12:20:32 -08:00
Mark Otto 55413e109f nuke local test vendor jquery and tether, replace with docs assets 2016-12-31 00:52:08 -08:00
Mark Otto 92fa9b2256 fix navbar in dropdown visual test file 2016-12-30 22:45:39 -08:00