Commit Graph

192 Commits

Author SHA1 Message Date
Patrick H. Lauke ed253683f3
[Docs] Remove some unnecessary Twitter references/examples (#41174)
* Remove some unnecessary Twitter references/examples

* Changes suggested by @mdo
2025-04-02 23:03:06 -07:00
Louis-Maxime Piton 49a5ccfd4f
Docs: From Twitter to X (#40706)
* From Twitter to X

* .

* Use Bootstrap Icons

* Set X card to use `twitter` again

* Update `tests/unit/popover.spec.js`

---------

Co-authored-by: Julien Déramond <juderamond@gmail.com>
2025-04-02 22:47:45 -07:00
Patrick (Casus Belli) cacbdc680e
Fix left alignment of floating labels with `.form-select` size variants (#41013)
Co-authored-by: Patrick Kroog <pk@kroog.com>
Co-authored-by: Christian Oliff <christianoliff@pm.me>
Co-authored-by: Julien Déramond <juderamond@gmail.com>
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
2024-11-14 11:12:33 +01:00
Louis-Maxime Piton b522441901
Floating labels: Fix `max-width` and `background-color` (#39720)
* Fix `max-width`

* Fix label background color

* Add new visual test: floating label

* Fix `npm run docs`

---------

Co-authored-by: Julien Déramond <juderamond@gmail.com>
2024-06-12 18:39:23 -07:00
Julien Déramond ce114117a8
Tests: update navbar in visual modal test (#39294) 2023-10-13 10:28:08 +02:00
Julien Déramond 3515ac16a1 Docs: add missing `aria-disabled='true'` to disabled anchors 2023-07-05 22:28:00 -07:00
Alejandro Mendoza a06c2e6b5f
Fix scrollspy and accented anchor links (#38502) 2023-05-01 00:31:26 +03:00
XhmikosR ae43f0c48b
Tweak and re-organize ESLint config (#38369)
* Tweak and re-organize ESLint config

* merge individual configs to the root config
* enable more eslint-plugin-import rules
* lint markdown files

* Lint
2023-03-29 13:49:30 -04:00
Neeraj Kumar Das 6a043d95fa
Remove empty script tag (#38233) 2023-03-14 14:30:36 +02:00
Tanguy Krotoff 1369b81492
Fix Android Chrome input date dimensions (#36143)
* Bind Hugo to 0.0.0.0, helps debug on mobile when on the same network

* Use http-server for visual tests

* Add input visual tests

* Fix input date dimensions on Android Chrome

* Increase bootstrap.css max size

* Revert "Bind Hugo to 0.0.0.0" & "Use http-server for visual tests"

* Switch to pixels: this is an empirical minimum safe value

* Update .bundlewatch.config.json

Co-authored-by: Mark Otto <otto@github.com>
2023-01-17 21:09:39 -08:00
Louis-Maxime Piton 9042efd0f8
Deprecate the Sass var and remove any occurence of the `.text-muted` (#37890) 2023-01-16 15:55:28 -08:00
XhmikosR 5208dd10c4
ESLint: enable prefer-template rule (#37484) 2022-11-12 10:09:36 +02:00
Julien Déramond 137c932e47 Docs: standardize usage of `<kbd>` 2022-10-12 11:45:46 -07:00
Patrick H. Lauke 0a5f6e078c
Use `<h1>` for all `modal-title` examples/uses (#37210)
* Use `fs-` font sizing classes where needed
* Also add info callout about heading hierarchy in modals
2022-10-02 13:02:36 +03:00
Julien Déramond abb1cf529f
Add eslint-plugin-html to lint JS in HTML files (#37186) 2022-09-27 22:53:59 +03:00
GeoSot 27f20257eb
Use es6 on visual tests (#36915) 2022-09-22 01:48:23 +03:00
GeoSot 3bd5756414
fix: add trick to support tooltip selector usage on dynamic created tooltips that utilize `title` attribute (#36914) 2022-09-14 16:24:37 +03:00
Patrick H. Lauke 8965b11dd5
Remove confusing unnecessary id/aria-labelledby for dropdown menus (#36487)
see https://github.com/twbs/bootstrap/discussions/35755

Note that even the APG guide for disclosure widgets doesn't use this optional "nice-to-have" extra bit https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/ (though they do use `aria-controls`, which in most current browser/AT combos is borked though)
2022-06-03 11:18:22 +01:00
Louis-Maxime Piton 8959bf3f0b
Docs: quick fixes for HTML (#36395)
* Using the new helper in the doc

* Remove input from `Tab` access

* Change scrollspy code examples

* Reordering tables for JS

* Fix for parcel file

* Center align all the code example texts in layout

* Alphabetical reorder the helpers
2022-05-20 10:21:48 -07:00
Julien Déramond ec41392717 Doc: remove `role="group"` from some split drop* buttons 2022-04-30 11:35:44 -07:00
Julien Déramond d3babf7d7f
Remove remaining `.navbar-light` classes (#35814)
* Fix typo in CSS variables documentation

* Drop remaining .navbar-light classes
2022-02-09 21:12:08 +02:00
XhmikosR 89f88762c5
Fix visual tests (#35585)
* Fix visual tests

They broke in #34509

* load bundle.js in visual tests

Co-authored-by: GeoSot <geo.sotis@gmail.com>
2022-01-30 16:12:24 +02:00
GeoSot 598b4c59a6 Use `for...of` in visual tests too 2021-10-05 19:52:11 +03:00
XhmikosR 9f1579aa04 Enable `unicorn/prefer-prototype-methods` rule 2021-10-05 19:52:11 +03:00
XhmikosR 40042ee503
visual tests: minor fixes (#34802) 2021-08-23 18:33:55 +03:00
XhmikosR 730566221f
visual tests: add missing base-component dist file (#33167)
Regression of #32313
2021-02-22 08:42:43 +02:00
Patrick H. Lauke 96be06e32b
Dynamic tabs: use buttons rather than links (#32630)
* Dynamic tabs: use buttons rather than links

- change docs
- add mention that tabs should be <button> elements
- tweak styles to neutralise border and background

* Update js unit and visual test accordingly

- replace links with buttons
- make one specific test that uses links instead of buttons, as we still want to support it despite it being non-semantically appropriate
- Leaving a couple of tests for now. The test for removed tabs should be redone so that tabs are removed programmatically (as the approach of having that close button inside the link is invalid and broken markup). The test for dropdowns should be removed together we actually ripping out the handling for dropdowns in the tab.js code (arguably a breaking change, though we discouraged this for a few versions and effectively "deprecated" it)

* Add isolation:isolate to prevent focus being overlapped

https://github.com/twbs/bootstrap/pull/32630#issuecomment-756015766
2021-02-09 07:23:45 +02:00
Patrick H. Lauke a882614c45 Make carousel indicators actual buttons 2021-01-28 23:32:24 +02:00
Patrick H. Lauke 3aa3fda730
Carousel: use buttons, not links, for prev/next controls (#32627)
* Carousel: use buttons, not links, for prev/next

- expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
- use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links

* Clarify that controls can be button or link

* Update site/content/docs/5.0/components/carousel.md

Co-authored-by: Mark Otto <markd.otto@gmail.com>

* Explicitly set padding to 0 to prevent dipping/moving on active in Firefox

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-27 17:31:16 +02:00
Théophile Helleboid - chtitux 80557b3ac0
Move "active" class from `.nav-item` to `.nav-link` (#32730) 2021-01-08 20:53:04 +02:00
Johann-S adfdf7160b Update to popper.js v2.x 2020-12-06 18:42:40 +02:00
Gaël Poupard 9488978fb5 feat(RTL): implement RTL
Using RTLCSS directives, renaming things to use logical names and following best practices.
2020-12-04 07:52:03 +02:00
XhmikosR f4457bca02
Be consistent with Popper's name. (#32224)
The npm package is named "popper.js" but the project is named "Popper", so use the latter consistently.
2020-11-21 16:22:08 +02:00
XhmikosR 4f8b243ac1
Fix `.close` instances (#32152) 2020-11-14 08:16:30 +02:00
Rohit Sharma 418f17ee2b Add `bs` in data attributes
- Add `bs` in data APIs everywhere
- Update unit tests
2020-11-14 07:09:15 +02:00
XhmikosR 411fc649f2
modal.html: use `textContent` (#32101)
We are not handling any HTML
2020-11-09 20:47:33 +02:00
XhmikosR 13572a6867 Remove the now unneeded polyfills. 2020-11-05 15:37:34 +02:00
XhmikosR c196d21e7f
Remove obsolete prefixes (#32012) 2020-10-30 07:29:48 +02:00
XhmikosR 5a3f273b60
Move `href` attribute first (#31835) 2020-10-22 09:38:15 +03:00
Patrick H. Lauke 836a4c0bd6
Remove redundant visually hidden "(current)" from pagination controls (#31892)
* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
2020-10-14 11:59:43 +01:00
Patrick H. Lauke 10690dd317
Rename `sr-only`/`sr-only-focusable` (#31139)
* Rename `sr-only`/`sr-only-focusable`

To be more representative of the fact that these are not necessarily "screen reader" specific, but actually apply to assistive technologies in general (and also things like Alexa/Siri/etc). Goes hand-in-hand with #31133

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-07-03 14:38:11 +03:00
Rohit Sharma 5faf41eb48
Add role="dialog" in modals via JavaScript (#30936) 2020-06-04 10:35:09 +03:00
Rohit Sharma ec3cfae29c
Removed role="document" from the modal dialog (#30755) 2020-05-11 12:45:42 +03:00
XhmikosR 967e6071ba
tests: streamline HTML end tags (#30648) 2020-05-06 09:20:08 +03:00
Martijn Cuppens c48d89cb70 Use unordered lists in dropdown-menus 2020-03-31 22:52:57 +02:00
Laussel Loïc 7ce29d75f3
v5 tabs - accessibility issue when using ul/li semantic
Add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc
2020-03-28 09:51:24 +02:00
Johann-S dcba526775 remove underscore for static methods 2019-07-29 11:34:12 +02:00
Johann-S e101ba4989 add polyfill.js in visual tests (#29116) 2019-07-24 08:19:47 +03:00
XhmikosR 438e01b61c Rename `eventHandler` and `selectorEngine` files. 2019-05-08 17:26:37 +03:00
Johann-S ad0f5f153c fix remove files in our visual tests 2019-03-18 01:11:05 +02:00