Commit Graph

2668 Commits

Author SHA1 Message Date
Kyle Tsang 91fa809529
Make .nav-link color consistent when using buttons (#33478)
* Make .nav-link color consistent when using buttons

* Set $nav-link-hover-color to $link-hover-color as default
2021-03-30 23:07:00 -07:00
XhmikosR 220139a89f
Release v5.0.0-beta3 (#33439) 2021-03-23 18:26:54 +02:00
Mark Otto e775c494f2 Fix flush accordion styles 2021-03-22 13:56:06 -07:00
Mark Otto c198eb6319
Revamp accordion borders to fix pixel jumping (#33149)
- Pushes the borders to the .accordion-item
- Simplifies the .accordion-flush
- Recreates the .accordion-button border-bottom with an inset box-shadow
- Updates background-color to solid to match other components like list group and prevent stacked translucent borders
- Use negative margin to overlap the consecutive items
2021-03-16 22:16:03 -07:00
Mark Otto 5c6e72c6fe Change from element selector to the opt-in class 2021-03-10 22:04:32 -08:00
Mark Otto defce83027 Add ol.list-group with psuedo-element numbers 2021-03-10 22:04:32 -08:00
gopal-jayaraman 644afc2761
Removing duplicate text-decoration style for abbr[title] #33197 (#33325)
Removing duplicate text-decoration style for abbr[title] #33197
2021-03-10 19:06:18 -08:00
XhmikosR bdffdb9380
Update devDependencies (#33307)
* @popperjs/core    ^2.9.0  →    ^2.9.1
* autoprefixer     ^10.2.4  →   ^10.2.5
* clean-css-cli     ^5.2.0  →    ^5.2.1
* postcss           ^8.2.6  →    ^8.2.7
* stylelint       ^13.11.0  →  ^13.12.0
2021-03-08 19:00:06 +02:00
GeoSot 548be2ed66
Offcanvas as component (#29017)
* Add a new offcanvas component

* offcanvas.js: switch to string constants and `event.key`

* Remove unneeded code

* Sass optimizations

* Fixes

Make sure the element is hidden and not offscreen when inactive
fix close icon negative margins
Add content in right & bottom examples
Re-fix bottom offcanvas height not to cover all viewport

* Wording tweaks

* update tests and offcanvas class

* separate scrollbar functionality and use it in offcanvas

* Update .bundlewatch.config.json

* fix focus

* update btn-close / fix focus on close

* add aria-modal and role
return focus on trigger when offcanvas is closed
change body scrolling timings

* move common code to reusable functions

* add aria-labelledby

* Replace lorem ipsum text

* fix focus when offcanvas is closed

* updates

* revert modal, add tests for scrollbar

* show backdrop by default

* Update offcanvas.md

* Update offcanvas CSS to better match modals

- Add background-clip for borders
- Move from outline to border (less clever, more consistent)
- Add scss-docs in vars

* Revamp offcanvas docs

- Add static example to show and explain the components
- Split live examples and rename them
- Simplify example content
- Expand docs notes elsewhere
- Add sass docs

* Add .offcanvas-title instead of .modal-title

* Rename offcanvas example to offcanvas-navbar to reflect it's purpose

* labelledby references title and not header

* Add default shadow to offcanvas

* enable offcanvas-body to fill all the remaining wrapper area

* Be more descriptive, on Accessibility area

* remove redundant classes

* ensure in case of an already open offcanvas, not to open another one

* bring back backdrop|scroll combinations

* bring back toggling class

* refactor scrollbar method, plus tests

* add check if element is not full-width, according to #30621

* revert all in modal

* use documentElement innerWidth

* Rename classes to -start and -end

Also copyedit some docs wording

* omit some things on scrollbar

* PASS BrowserStack tests

-- IOS devices, Android devices and Browsers on Mac, hide scrollbar by default and appear it, only while scrolling.

* Rename '_handleClosing' to '_addEventListeners'

* change pipe usage to comma

* change Data.getData to Data.get

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Martijn Cuppens <martijn.cuppens@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
2021-03-02 19:10:10 +02:00
Mark Otto 6d93a1371a Reset select:disabled opacity and null-ify color to fix rendering differences in Chrome 2021-03-02 06:40:32 -08:00
Gaël Poupard bed8fc8381 fix(navs): ensure button will grow in fill/justified nav 2021-03-01 11:55:19 -08:00
Gaël Poupard 0bdf931507 fix(list-group): properly set a color on list-group-items 2021-03-01 11:27:08 -08:00
Gaël Poupard ac3a1069b1 fix(forms): validated controls in input-group 2021-03-01 07:53:39 -08:00
Rohit Sharma d983744d12
Remove the default positioning from `.dropup` (#33120) 2021-02-22 08:57:21 +02:00
Gaël Poupard 489e7b6798
fix(card): siblings card links in RTL (#33154)
Fixes a bug mentionned in [#32330](https://github.com/twbs/bootstrap/issues/32330#issuecomment-782001326).

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-22 08:49:38 +02:00
k-utsumi 4d19e0e8a4
Clear duplicated class `border-0` (#32925)
* Clear duplicated class `border-0`

* Update migration.md

Co-authored-by: Mark Otto <otto@github.com>
2021-02-16 08:05:09 +02:00
Sam Willis 2f03e32d8c Add input focus blur variable 2021-02-10 21:03:37 -08:00
Patrick H. Lauke df79aad5e4 Remove explicit suppression of focus outline
It's unclear what the reason for first introducing the original hack here (for `[tabindex="-1"]:focus {...}`) was. Seems something that may have been useful/necessary in SuitCSS, but don't think BS ever relied on this. https://github.com/twbs/bootstrap/issues/18330
It's since been modified to only apply when the browser wouldn't apply a visible outline anyway based on its own heuristics (the `:not(:focus-visible)` part) https://github.com/twbs/bootstrap/pull/28437/

But now, thinking this through more...in browsers that do support this pseudo-selector, what this is essentially saying is redundant: don't apply outline in cases where a `tabindex="-1"` element receives focus but the browser wouldn't normally apply focus outline". at best, this is unnecessary. at worst, this actually overrides things an author may explicitly be trying to do with adding `:focus { outline: ... }` explicitly.
2021-02-10 19:35:52 -08:00
Mark Otto 4c7a3e8adf
Add Sass docs (variables, mixins, and loops) to most pages (#32747)
* WIP: Mention variables, mixins, and loops in docs

* Add Sass sections to component pages

* add sass docs for forms and content

* Update buttons.md

* Remove empty mixins sections

* Massive update to utilities and some consistency changes

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-10 19:29:59 -08:00
XhmikosR e50c11b8c6
Release v5.0.0-beta2 (#32467)
* Bump version to 5.0.0-beta2

* Dist
2021-02-10 18:14:51 +02:00
Rohit Sharma 29e0c9dfa1
Dropdown — Change the selector to check the use of Popper (#33003)
* Create the popper instance first

Make sure that popper instance has been created first and then apply the
styling on the dropdown(menu)

* Use `data-bs-popper` attibute to check popper

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-09 21:04:23 +02:00
Gaël Poupard 91d3da1f3d
fix(navbar): ensure .navbar-collapse behaves as intended (#33022) 2021-02-09 20:54:37 +02:00
Rohit Sharma 273db7c205 Remove the default left styling in favor of Popper 2021-02-09 14:34:27 +02:00
Mark Otto 8f1c882545 Remove .dropdown-menu[style] reset and adjust .dropdown-menu-* modifiers
- Removes the &[style] selector that was used for resetting Popper styles
- Separate Popper-based alignment from static alignment with `data-bs-popover` attribute that separates the --bs-position and custom right/left properties

Co-Authored-By: Rohit Sharma <rohit2sharma95@gmail.com>
2021-02-09 14:34:27 +02:00
Patrick H. Lauke 96be06e32b
Dynamic tabs: use buttons rather than links (#32630)
* Dynamic tabs: use buttons rather than links

- change docs
- add mention that tabs should be <button> elements
- tweak styles to neutralise border and background

* Update js unit and visual test accordingly

- replace links with buttons
- make one specific test that uses links instead of buttons, as we still want to support it despite it being non-semantically appropriate
- Leaving a couple of tests for now. The test for removed tabs should be redone so that tabs are removed programmatically (as the approach of having that close button inside the link is invalid and broken markup). The test for dropdowns should be removed together we actually ripping out the handling for dropdowns in the tab.js code (arguably a breaking change, though we discouraged this for a few versions and effectively "deprecated" it)

* Add isolation:isolate to prevent focus being overlapped

https://github.com/twbs/bootstrap/pull/32630#issuecomment-756015766
2021-02-09 07:23:45 +02:00
Gaël Poupard 02d103be91
fix(accordion): ensure .accordion-button stays left-aligned (#32951)
Fixes #32938

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-03 21:44:48 +02:00
Gaël Poupard e4b249d02b
fix(navbar): hardcoded custom property (#32930) 2021-02-03 21:42:24 +02:00
Rohit Sharma 217d84d6b2
Remove the initial margin from dropdown/popover in favor of Popper (#32524)
* Remove the margin from dropdown in favor of Popper

- Set the default margin to 0 for dropdowns (To remove the Popper's  warning)
- Set the required offset in dropdown's defaults

* Remove the margin from the popover component

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-02-03 21:37:25 +02:00
Mark Otto 88be1ce502 Update docs for color and bg utilities
- Split colors from background utilities with new docs page
- Add Sass docs for both pages
2021-02-03 07:15:49 +02:00
Quy ed0fc83216
_carousel.scss: Fix typo in comment (#32950) 2021-02-01 15:22:24 +02:00
Patrick H. Lauke a882614c45 Make carousel indicators actual buttons 2021-01-28 23:32:24 +02:00
Mark Otto 0fa16a5d45
Re-add flex-grow to .navbar-collapse (#32899)
Update .navbar-collapse to drop width 100 and use flex-grow, restoring it to v4's behavior

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-27 21:27:02 +02:00
Patrick H. Lauke 3aa3fda730
Carousel: use buttons, not links, for prev/next controls (#32627)
* Carousel: use buttons, not links, for prev/next

- expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
- use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links

* Clarify that controls can be button or link

* Update site/content/docs/5.0/components/carousel.md

Co-authored-by: Mark Otto <markd.otto@gmail.com>

* Explicitly set padding to 0 to prevent dipping/moving on active in Firefox

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-27 17:31:16 +02:00
Mark Otto 40b15de723
Add `.navbar-nav-scroll` for vertical scrolling of navbar content (#32037)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-19 07:32:18 +02:00
Mark Otto bb19b08fbe
Remove popover-arrow margin to fix alignment of the arrow (#32787)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-15 09:12:45 +02:00
Mark Otto 987715fd24 Drop transition on .form-check, keep on .form-switch
To avoid breaking changes, turns -check-transition to null, then adds a new -switch-transition variable
2021-01-14 19:46:50 -08:00
Mark Otto a8aede0df1 Lighten disabled dropdown text to $gray-500
Fixes #32474
2021-01-14 19:41:34 -08:00
Onycss 041de9d5ed
Add word-break to .toast-body (#32670)
* Update _toasts.scss

* Update scss/_toasts.scss

Co-authored-by: Mark Otto <otto@github.com>
2021-01-13 09:21:57 -08:00
Patrick H. Lauke 78c5b503f9
Darken dropdown item hover style (#32754)
Closes https://github.com/twbs/bootstrap/issues/23329
2021-01-11 01:24:03 +00:00
Patrick H. Lauke d62d18f172
Consistently use outline:0 rather than outline:none (#32751)
just for code consistency, no actual effect on styling per se
2021-01-10 16:13:08 +00:00
Patrick H. Lauke a2ae2c364f
Suppress focus outline for buttons when it shouldn't be visible in Chromium (#32689)
Follow-up to https://github.com/twbs/bootstrap/pull/32631

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-10 10:42:26 +00:00
XhmikosR f2c504397e
Bump copyright year to 2021 (#32713) 2021-01-07 12:12:53 +02:00
Gaël Poupard acec356c81
fix(ratio): missing variable prefix (#32501)
This is the only unprefixed custom property, and its name is very common so I think we'd better prefix it too.
2021-01-06 08:14:54 +02:00
Patrick H. Lauke eb45005047
Remove old/unnecessary reboot bug fix (#32631)
From initial testing, this bug doesn't seem to manifest itself anywhere in Bootstrap (since we don't just set transparent background anywhere on buttons, and when we do set explicit button styles in the more specific stylings, we already do create a custom `:focus` style anyway)

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-05 22:20:35 +02:00
Mark Otto a48a29a7a5
Tweak .form-select padding (#32419)
* Tweak .form-select padding

* Simplify the padding entirely

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-28 08:27:03 +02:00
Marc Jansing f07106e604
Add helpers to utilities bundle (#32324)
Adds currently missing utilities classes which are located in scss/helpers to
boostrap-utilities dist files.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-18 07:39:39 +02:00
Dylan Anderson df763d6457
Add variables for modifying button state colours. (#32317)
Add some variables to allow users to modify how much a button gets
lighter or darker on :hover and :active.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-17 07:16:54 +02:00
Dmytro Yaremenko 8984255158
Extended form validation states customization capabilities (#31757)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-17 07:07:48 +02:00
Rafi b424650ab5
Fix: variables collide with globals (#32492)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-17 07:02:20 +02:00
Patrick H. Lauke eae52b1cb0 Expand `visually-hidden-focusable` so it can be used on a container, so the container becomes visible when focus is inside it / on one of its child elements. 2020-12-15 09:22:14 +02:00
Mark Otto 071f914fa1
Add two new variables for pagination border-radius values (#32423)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-14 15:34:01 +02:00
Martijn Cuppens 62eb5a3232
Use box shadows instead of linear gradients to colorize tables (#32348)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-11 15:49:22 +02:00
Gaël Poupard 7e47b7ecc9
Reset Popper position in RTL (#32415)
The RTL cheatsheet's dropdowns aren't positioned correctly because of RTLCSS transforming `right: auto` to `left:auto` (which conflicts with Popper positioning).
2020-12-10 16:38:42 +02:00
Martijn Cuppens 8fed098ef9
Utility API, RFS option: Only generate responsive classes when needed (#32397)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-09 23:49:21 +02:00
Mark Otto 33b275c04b
Remove vertical-align from .form-select (#32318)
Aligns the component with the .form-control. Closes #32271.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-12-07 19:08:31 +02:00
XhmikosR 8dc85c657e Prepare v5.0.0-beta1. 2020-12-07 18:18:16 +02:00
Gaël Poupard 9312442338 fix(dropdown): ensure [style] will override inline styles 2020-12-06 18:42:40 +02:00
Gaël Poupard 6a27618d21 fix(RTL) 2020-12-06 18:42:40 +02:00
Martijn Cuppens d8f247392d Fix conflict with Bootstrap CSS 2020-12-06 18:42:40 +02:00
Martijn Cuppens 87e56de066 Override margins set by popper 2020-12-06 18:42:40 +02:00
Johann-S adfdf7160b Update to popper.js v2.x 2020-12-06 18:42:40 +02:00
Martijn Cuppens 5b0dcf8ffe Add `.translate-middle-x` and `.translate-middle-y` utilities 2020-12-04 16:15:51 +02:00
Martijn Cuppens 1f2e600304 Add toast positioning 2020-12-04 16:15:51 +02:00
Gaël Poupard 9488978fb5 feat(RTL): implement RTL
Using RTLCSS directives, renaming things to use logical names and following best practices.
2020-12-04 07:52:03 +02:00
Martijn Cuppens bf3c4d0b68 Use $variable-prefix 2020-12-01 19:17:06 +02:00
Mark Otto 3b015ed34e Update breadcrumb docs and dividers
- Add CSS custom property with fallback to Sass variable
- Update docs to mention the new CSS custom property
- Rewrite some of the docs to use divider instead of separator, and add some context here and there
2020-12-01 19:17:06 +02:00
Patrick H. Lauke ff130b17dc Remove background, padding, border from breadcrumb container 2020-12-01 19:17:06 +02:00
Rohit Sharma af57444405
Keep rounded corners for the first .btn in vertical button group (#31303)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-30 11:09:55 +02:00
Martijn Cuppens ff25a75320
Remove default linear gradient (#32277)
Remove the default invisible gradient causing the performance issue in #32266. By removing the custom property, the linear gradient will become invalid, thus not appear by default.

There can still be a performance issue with striped tables though.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-30 10:51:32 +02:00
XhmikosR f4457bca02
Be consistent with Popper's name. (#32224)
The npm package is named "popper.js" but the project is named "Popper", so use the latter consistently.
2020-11-21 16:22:08 +02:00
XhmikosR a96b118f04
_reboot.scss: remove needless Stylelint disable (#32213) 2020-11-20 09:54:24 +02:00
Gaël Poupard 268da84f16
fix(container): use $variable-prefix (#32201)
Missed that while merging.
2020-11-19 20:38:39 +02:00
Gaël Poupard 44fef1677b
Simplify make-container() (#31735) 2020-11-14 14:33:10 +01:00
Rohit Sharma 418f17ee2b Add `bs` in data attributes
- Add `bs` in data APIs everywhere
- Update unit tests
2020-11-14 07:09:15 +02:00
Nikita Mikhaylov 1fddb48aff Add hover utilities
remome several hobers

refactoring hover utilities

refactoring hover utilities
2020-11-13 20:16:05 +01:00
Mark Otto 55f2192a39
Rename scale-color() function to shift-color() to avoid collision with Sass's own color function (#32149) 2020-11-13 20:50:59 +02:00
XhmikosR 384eccbfaf
Prepare v5.0.0-alpha3 (#32122) 2020-11-11 19:07:37 +02:00
Martijn Cuppens 3612a1e463
Use correct value order (#32121)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-11 18:27:12 +02:00
Mark Otto fb3a57b7ba
Drop `.btn-block` classes, replace with utilities (#31995)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-09 11:27:20 +02:00
Mark Otto 649e525c62
Add .gap utilities (#32074)
* Add gap utilities

* Update .bundlewatch.config.json

* Revamp headings on this page for better organization

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-08 20:56:02 +02:00
Martijn Cuppens 67847b0aab
Add checks to fix color contrast issues (#32085) 2020-11-08 19:49:26 +01:00
XhmikosR bb6daab961 _variables.scss: reorder SVG attributes
This results in slightly better gzip compression
2020-11-06 14:49:41 +02:00
Martijn Cuppens 82ac087c4d Shade color for better color contrast 2020-11-06 14:49:41 +02:00
Martijn Cuppens 4c1f807142 Fix missing border & add transitions 2020-11-06 14:49:41 +02:00
Mark Otto d6a72c4e1b Remove default transform-origin per code review 2020-11-06 14:49:41 +02:00
Mark Otto 3df4dd15e4 Update relative position hack for layers
Switches to slightly more verbose, but more consistent, z-index layering we use elsewhere (e.g., pagination). Doing this ensures we're not toggling position on and off, but rather z-index.
2020-11-06 14:49:41 +02:00
Mark Otto 6a37612540 Add dedicated accordion component based on Collapse JS 2020-11-06 14:49:41 +02:00
Mark Otto f20335b6c1
Add .d-grid to our display utilities (#32066)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-06 14:35:17 +02:00
XhmikosR 82f2416132
stylelint: pass the ` --rd` flag (#32063)
* stylelint: pass the ` --rd` flag

Should report any needless disables

* Update _button-group.scss

* Update _floating-labels.scss
2020-11-06 12:00:03 +02:00
Emilio Cobos Álvarez c1bb1acf54
Remove firefox workaround for ::file-selector-button margin. (#32064)
As per https://bugzilla.mozilla.org/show_bug.cgi?id=1673895,
this workaround shouldn't be necessary in FF83+.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-06 10:46:49 +02:00
XhmikosR e8f1709adf Drop Legacy Edge support.
This allows us to move forward without being held back. Microsoft already replaces the Legacy Edge with the new one on supported Windows versions.
2020-11-05 15:37:34 +02:00
Gaël Poupard 230a41f1d7
Form file docs and overrides (#32058) 2020-11-03 18:22:35 +01:00
Mark Otto 4d1ee3b0a7 Add class name so the utility generates 2020-10-31 19:19:52 +01:00
Mark Otto 241f910dc5
Updated .rounded utilities (#31687)
* Updated rounded utilities to fix scale, but not rename anything else

* Rename rounded-pill to border-radius-pill to match

Also reorder some variables while I'm here to make more sense

* Updated rounded utilities to fix scale, but not rename anything else

* Rename rounded-pill to border-radius-pill to match

Also reorder some variables while I'm here to make more sense

* Small copy addition

* Add example modifier class for spacing

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-10-30 22:42:11 +02:00
Martijn Cuppens a108e2bbf8
Fix color heights (#32023) 2020-10-30 22:36:44 +02:00
Patrick H. Lauke 6fc35e3231
Add `cursor:pointer` to color inputs (#32020)
* Add `cursor:pointer` for color inputs

* Add to migration guide
2020-10-30 18:03:07 +00:00
Martijn Cuppens ed1d867dd8
Remove explicit heights on form elements (#31993)
* Remove explicit heights

* Link to upstream bug

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-10-29 15:18:39 +02:00
Martijn Cuppens b1c7d1d3a3 Use the same font on the button as on the field itself 2020-10-28 18:29:28 +01:00
Martijn Cuppens b2be299f63 Fix Firefox padding issue
Caused by https://searchfox.org/mozilla-central/rev/0b7007a23bc16c857f894140e12f307bfeef2fdd/layout/style/res/forms.css#494
2020-10-28 18:29:28 +01:00
Martijn Cuppens f236667483 Drop custom file upload plugin in favor of CSS 2020-10-28 18:29:28 +01:00