49a5ccfd4f
Docs: From Twitter to X ( #40706 )
...
* From Twitter to X
* .
* Use Bootstrap Icons
* Set X card to use `twitter` again
* Update `tests/unit/popover.spec.js`
---------
Co-authored-by: Julien Déramond <juderamond@gmail.com>
2025-04-02 22:47:45 -07:00
fecd219983
Fix popover remaining open when toggled after being shown ( #40803 )
...
Co-authored-by: Dmitry Sergienko <dmitry.sergienko@codefirst.net>
Co-authored-by: Julien Déramond <juderamond@gmail.com>
2024-09-12 09:45:08 +02:00
16d80a4ff7
Fix `this` reference for JavaScript functions ( #38725 )
2024-07-19 07:05:21 +02:00
ae43f0c48b
Tweak and re-organize ESLint config ( #38369 )
...
* Tweak and re-organize ESLint config
* merge individual configs to the root config
* enable more eslint-plugin-import rules
* lint markdown files
* Lint
2023-03-29 13:49:30 -04:00
d388bd6e1b
JS: tests fixes & standardization of spies usage ( #36398 )
...
* Fix carousel spec typo
* Change carousel test name in align with testing method
* Make the spies declarations the same everywhere
2022-05-31 11:18:32 +03:00
407af8ac7f
Make event name helper and use it on tooltip & popover to reduce dist sizes ( #35856 )
...
* feat: create eventName getter function in baseComponent
* refactor: use `eventName` getter on tooltip & popover
2022-02-19 15:10:47 +02:00
3f7b31e0e0
Fix Popover test that randomly fails on BrowserStack ( #35757 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2022-02-01 10:33:18 +02:00
aa650f0f1e
tests: replace 'done' callback with 'Promise' to fix deprecation errors ( #35659 )
...
Reference:
https://jasmine.github.io/tutorials/async
'DEPRECATION: An asynchronous function called its 'done' callback more than once. This is a bug in the spec, beforeAll, beforeEach, afterAll, or afterEach function in question. This will be treated as an error in a future version. See<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times > for more information.
2022-01-30 14:30:04 +02:00
d40fae456e
Popover.js: Accept empty content through `data-bs-content` ( #35514 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-12-15 10:41:31 +02:00
385fea49e8
Tooltip/Popover: add underscore prefix to protected functions
2021-12-01 18:00:36 +02:00
cab62af2e6
Fix popover arrow & tooltip template after the `setContent` addition ( #35441 )
2021-12-01 15:10:10 +02:00
eb54e1a1ce
tests: tweak Jasmine's matchers usage
...
Use:
* toBeNull
* toEqual
* toBeTrue
* toBeFalse
* toHaveSize
* toHaveClass
2021-12-01 14:30:49 +02:00
94a596fbcb
Add a template factory helper to handle all template cases ( #34519 )
...
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-11-25 19:14:02 +02:00
a260967a55
tests: minor cleanup ( #35138 )
...
* tests: minor cleanup
* tests: use the util noop function
2021-10-08 12:32:11 +03:00
666fe596bf
Enable `unicorn/no-array-for-each` rule
2021-10-05 19:52:11 +03:00
a6a2d1e2df
Regression on tooltip template creation process. ( #34628 )
...
* Regression on tooltip template creation process.
* check if template content does not exist, or given argument is empty
* call `setContent()` once.
2021-08-03 11:59:33 +03:00
6d707f4801
Enable a few eslint-config-xo rules ( #34620 )
...
* unicorn/prefer-dom-node-append
* unicorn/prefer-dom-node-remove
2021-07-30 00:23:00 +02:00
c98657b830
Add `getOrCreateInstance` method in base-component ( #33276 )
...
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-06-03 18:53:27 +03:00
9e4f87ae8f
Allow use of `dispose/hide` methods on Tooltip & Popover from jQueryInterface, when component does not exists. ( #33371 )
2021-05-20 16:16:55 +03:00
153cf3a235
Don't add empty content holder when there is no content available ( #33982 )
...
* Remove content holder when there is no content
* Add tests to check the removal of header/content
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-05-18 09:02:39 +03:00
052def4568
Remove potential false positive assertions ( #33288 )
...
* Remove potential false positive assertions
querySelector() returns null but
expect(document.querySelector('...')).toBeDefined()
tests that the value is not undefined
* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests
* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call
* convert more cases to not.toBeNull assertions
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-05-11 08:45:57 +03:00
c9cd741aff
Throw a `TypeError` instead of the generic `Error` ( #32585 )
...
* Change from Error to TypeError
* Convert the `NAME` to upper case to make the consistency in the error message
* Update the remaining tests to be stricter
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2021-01-13 22:13:30 +02:00
51a208f119
Switch to Jasmine's `toBeInstanceOf` matcher
2020-11-29 20:58:26 +02:00
9f6b342dc7
create a base component
2020-11-29 20:58:26 +02:00
c348ad4a94
Ability to add custom class in tooltip/popover ( #32217 )
...
Porting of #31834 to main.
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-11-25 09:16:22 +02:00
418f17ee2b
Add `bs` in data attributes
...
- Add `bs` in data APIs everywhere
- Update unit tests
2020-11-14 07:09:15 +02:00
26d86fce2a
fix: remove make array util function ( #30430 )
2020-03-25 16:35:02 +02:00
577bf8b14d
Rename "js/tests/units" to "js/tests/unit". ( #29503 )
2019-10-09 01:27:43 +03:00
Louis-Maxime Piton
Dmitry
Nathan Sarang-Walters
XhmikosR
GeoSot
Rohit Sharma
Ben Lertlumprasertkul
Johann-S