Commit Graph

40 Commits

Author SHA1 Message Date
XhmikosR 52d99a887e Refactor a few selectors. (#24404)
1. move a couple of them before the more specific ones.
2. change nesting to be under the same parent selector
3. use the ampersand more
2017-10-23 00:17:28 +03:00
rmacklin 9e6dabbb10 Reduce z-indexes in button-group, input-group, list-group, and pagination to the minimum necessary (#24315)
These were using `z-index: 2` to "Place active items above their
siblings for proper border styling". However, using `z-index: 1` is
sufficient for accomplishing that goal.

In input-group, there were also three `z-index: 3` rules for the
hover/focus/active states. I reduced these to `z-index: 2` since they
just needed to be "one more than normal" (i.e. one more than what is now
`z-index: 1` after my changes).

These changes can be verified by viewing the documentation pages for
Button group, Input group, List group, and Pagination before and after
this commit and observing that the active elements are still "above"
their siblings, so their borders look correct.
2017-10-20 10:01:29 +03:00
Andres Galante bbb6ab1275 changes reset for mixin list reset on pagination 2017-09-30 23:36:30 -07:00
Patrick Yeo 34257d25a5 Pagination border-widths greater than 1px cause uneven borders between items 2017-08-10 23:24:37 -07:00
Patrick Yeo dd0ce3e4b2 Rename variable $input-border-focus to $input-border-color-focus (#22413)
* Rename variable $input-border-focus to $input-border-color-focus
* Rename variables $pagination-hover-border, $pagination-active-border, $pagination-disabled-border to $pagination-hover-border-color, $pagination-active-border-color, $pagination-disabled-border-color, respectively
* Rename variables $state-*-border to $state-*-border-color, respectively
* Rename variables $alert-*-border to $alert-*-border-color
* Rename $list-group-active-border to $list-group-active-border-color
* Rename $table-inverse-border to $table-inverse-border-color
* Rename $btn-*-border to $btn-*-border-color
* Rename $navbar-*-toggler-border to $navbar-*-toggler-border-color
2017-04-16 15:45:10 -07:00
Patrick H. Lauke 7056f70240 Remove `cursor: not-allowed` styles 2017-04-10 22:10:20 +01:00
Mark Otto d91481397e linting 2016-12-28 15:13:43 -08:00
Mark Otto 3fd9557cfd no need to float, but do set display: block;
this, coupled with the move to flex, fixes #20029
2016-12-28 15:13:43 -08:00
Mark Otto 79fd05d209 remove plain-hover-focus mixins 2016-12-28 15:13:43 -08:00
Mark Otto bd6e047152 no need for cursor: default, since, well, it's the default 2016-12-28 15:13:43 -08:00
Mark Otto c52049e5a7 add a comment here to explain some things 2016-12-28 15:13:43 -08:00
Mark Otto e3d01a326b .page-item's don't need this anymore (they're flex items) 2016-12-28 15:13:43 -08:00
Mark Otto e81aa62af6 remove default margin, allow folks to use utils instead 2016-12-28 15:13:43 -08:00
Mark Otto 645330a755 update pagination list reset styles 2016-12-28 15:13:43 -08:00
Mark Otto c73bea60de move pagination to flexbox 2016-12-28 15:13:43 -08:00
Stefan Staynov 0051be1657 Set line-height for page-links (#21052) 2016-11-27 23:37:36 -08:00
Mark Otto c13215d038 Fixes #21094: Move text-decoration override from the default link state to the hover/focus state so it can override the global styles properly 2016-11-23 11:37:56 -08:00
Mark Otto ba37c37615 Redo line-height globally
- Rename -height to -height-base to match other vars
- Drop use of -height across the board and rely on it to be inherited
- Adjust padding of .dropdown-header to account for different line-height of h6 heading element (this needs refactoring for variables and rems also)
2016-02-03 19:45:13 -08:00
Patrick H. Lauke 348763d65c Add pointer-events:none to disabled pagination/pager links
as currently this was missed out (compared to disabled `a.btn`)
2015-12-27 10:03:09 +00:00
Chris Rebert 8b0d737a56 scss/_pagination.scss: Reassert #18257
[skip sauce]
2015-12-08 00:01:58 -08:00
Mark Otto 4dd60d8310 fix variable 2015-12-07 23:46:56 -08:00
Chris Rebert e7edf10473 .page => .page-item 2015-12-07 22:37:17 -08:00
Chris Rebert 0c1df9912f Refactor pagination code to remove unnecessary ancestor requirements in selectors 2015-12-07 22:37:17 -08:00
Chris Rebert 5f35ce2095 .page>{a,span => .page-link} 2015-12-07 22:37:17 -08:00
Chris Rebert a878c4f0c6 .pagination>{li => .page} 2015-12-07 22:37:17 -08:00
Chris Rebert 203264d7af Add $pagination-border-width; refs #18150 2015-11-14 22:53:18 -08:00
Chris Rebert 5f45f652f7 Rename $pagination-border => $pagination-border-color for clarity 2015-11-14 22:51:18 -08:00
Mark Otto c3373df95f clean out comments that aren't all that helpful 2015-08-17 18:33:34 -07:00
Mark Otto 9b1ee31567 nuke the shared padding vars and assign to individual components
- no real need for everything to be 100% shared
- padding looked and felt too large for inputs but not for buttons
- tying forms and buttons seems fine, but throwing in pagination feels wrong
2015-08-13 23:04:16 -07:00
Mark Otto ed42fc9b76 line-height-base to line-height var 2015-06-22 23:24:32 -07:00
Mark Otto 75cf69a1ab drop more -base, clean up var spacing 2015-06-22 18:57:56 -07:00
Mark Otto 0ca9b21c34 drop the base (hahaha), no but seriously drop the -base from our vars since it's cleaner 2015-06-22 18:53:04 -07:00
Mark Otto 4565281df3 rename -horizontal and -vertical vars to -x and -y for consistency 2015-06-22 16:33:17 -07:00
Mark Otto 169d2a4a78 Merge branch 'master' into v4 2015-06-18 23:56:43 -07:00
Mark Otto 663576a7ae Merge branch 'v4' of https://github.com/twbs/derpstrap into v4
Conflicts:
	dist/css/bootstrap.css
	dist/css/bootstrap.css.map
	docs/assets/css/docs.min.css
2015-05-27 15:49:55 -07:00
Mark Otto ed89be1f44 Remove $line-height-computed
We have it set to `1` right now just to avoid compilation errors, but
it’s been replaced everywhere with our new spacer classes anywho. We’ll
likely want to remap that var to custom component vars though (e.g.,
`$pagination-margin` instead of `$spacer-y`).
2015-04-29 12:00:11 -07:00
Mark Otto ac1ed746ef more comments and formatting clean up 2015-04-18 11:38:47 -07:00
Chris Rebert 8e374bd010 put all :hover styles within @media (hover: hover) 2015-01-22 11:37:37 -08:00
Mark Otto fef873a840 fix all validation, turn off some settings, add sort order 2014-12-11 12:05:29 -08:00
Mark Otto 27df020852 convert to scss 2014-12-02 14:02:35 -08:00