root
/
bootstrap
mirror of https://github.com/twbs/bootstrap.git
1
0
Fork 0
Code Issues Actions 11 Packages Projects Releases Wiki Activity
14,086 Commits 106 Branches 92 Tags 672 MiB
Commit Graph

1080 Commits

Author SHA1 Message Date
Chris Rebert 32cb071594 Remove semicolons from #15425 because fat 2014-12-29 18:34:35 -08:00
Chris Rebert 27bfef5b35 Add regression test for #14244. 
Special thanks to @programcsharp

[skip validator]
 2014-12-29 16:09:37 -08:00
Chris Rebert 54b03c27d2 Merge pull request #43 from twbs/popover-arrow 
rename .arrow => .popover-arrow
 2014-12-29 16:01:07 -08:00
Chris Rebert e26701c04e JSCS: enable requireSpaceBetweenArguments 
New rule added in JSCS v1.9.0
Our JS already complies with this.
 2014-12-29 14:16:26 -08:00
Chris Rebert 05d1877985 update JS to use .{tooltip,popover}-{left,right,top,bottom} 2014-12-29 12:34:09 -08:00
Chris Rebert 6a5bc63649 rename .arrow => .popover-arrow 2014-12-29 12:33:06 -08:00
Chris Rebert 2ae4c0b03f JSCS: enable requireSpaceBetweenArguments 
New rule added in JSCS v1.9.0
Our JS already complies with this.
 2014-12-29 12:02:33 -08:00
Heinrich Fenkart 32f62bc565 Modal: Work around IE scrollbars not taking up page width 
Fixes #15353.
 2014-12-18 07:29:34 +01:00
Chris Rebert c7ef5810e1 rename .item => .carousel-item 2014-12-17 18:44:55 -08:00
Chris Rebert a8299b5b45 Remove ancillary references to IE<9 in comments+docs 2014-12-16 19:06:57 -08:00
Chris Rebert a28e25c00b Remove IE8 compat shims from JS visual tests 2014-12-15 11:38:57 -08:00
Dan Dascalescu 2c64fc2c4d Fix copy/paste error 2014-11-28 04:30:04 -08:00
Chris Rebert bc5a753b67 fix affix-top unit test to properly clean up after itself 2014-11-20 23:26:37 -08:00
Nick O'Donoghue 36b4f90f25 Fixes affix-top class not applying 
Use scrollTop instead of colliderTop which uses the elements
offset().top, as the offset top does not account for padding.

This issue can be replicated by using a navbar-fixed-top and applying
relevant padding to the body. (A navbar-static-top with no padding on
the body does not encounter this issue)

Fixes #15078
Closes #15154 by merging it
 2014-11-17 18:17:42 -08:00
Nick O'Donoghue da79ab9488 add unit test for affix-top for padding issue 2014-11-17 18:17:40 -08:00
Chris Rebert b7398bc9c4 honor wrap option in Carousel.getItemForDirection; fixes #15144 2014-11-15 22:43:20 -08:00
Chris Rebert 8008fe707e add unit tests for Carousel's 'wrap' option 2014-11-15 22:37:55 -08:00
Heinrich Fenkart a577f1922e Collapse: Use $.fn.children instead of `>` in selector 
Fixes #15131.
 2014-11-14 15:18:34 +01:00
Mark Otto 9a7e365c2c bump version to v3.3.1 2014-11-12 09:03:16 -08:00
Heinrich Fenkart 1d55ada581 Dropdown: ignore keydown events coming from `input`s and `textarea`s 
Fixes #15084.
 2014-11-12 02:01:25 +01:00
Chris Rebert 21644321e4 Merge pull request #14993 from twbs/fix-14991 
Have Carousel ignore keyboard events from <input>s or <textarea>s
 2014-11-04 16:50:36 -08:00
Heinrich Fenkart da74fba490 Center modal dialog at all times 2014-11-05 01:37:44 +01:00
Chris Rebert 469dc3ab1f Have Carousel ignore keyboard events from <input>s or <textarea>s; fixes #14991 2014-11-04 16:23:44 -08:00
Heinrich Fenkart 425a985491 Update head of all visual tests to use our basic template 2014-11-05 01:18:11 +01:00
Heinrich Fenkart 14e5fb04e9 Fix modal backdrop overlaying the modal's scrollbar 
Fixes #14916.
 2014-11-04 23:17:55 +01:00
Chris Rebert 4102a67f33 fix typo in comment 2014-10-30 01:47:48 -07:00
Heinrich Fenkart cf482dbb0b Fix the iOS 8 unit test failures 
Resolves #14919.
 2014-10-30 09:35:53 +01:00
Heinrich Fenkart 5178d8b8ba Use RegExp for button plugin's focus shim 
Fixes #14923.
 2014-10-30 03:46:49 +01:00
Mark Otto 94b59b57d6 version bump 2014-10-29 08:56:20 -07:00
Ben-Russell 68b771a057 Independently delegate data-api selectors 
Fixes #14462.
Closes #14463 by merging it.
 2014-10-29 04:54:53 +01:00
Heinrich Fenkart ed3a65f084 Handle `collapsed` class on triggers even when manually invoked 
Fixes #13636.
 2014-10-29 04:34:05 +01:00
Heinrich Fenkart e851b8685a Merge pull request #14457 from hnrch02/button-set-val-after-event-loop 
Change value of stateful button after event loop
 2014-10-29 04:28:22 +01:00
Chris Rebert 22e1f94b52 Increase timeouts in tooltip unit tests to avoid spurious Sauce failures 
Fixes #14851
 2014-10-27 15:53:43 -07:00
Heinrich Fenkart 007fbdb66d Remove faulty unit test from 9740d8b 
This would only work with transitions but since we disable them for unit tests, this delivers unreliably results.
 2014-10-26 04:56:52 +01:00
Heinrich Fenkart 5da85f8e8b Follow-up to 9740d8b: fix small typo 2014-10-26 04:41:47 +01:00
Phil Hughes 9740d8bb69 Fix tooltip occasionally not hiding when using a hide delay 
Fixes #14375.
Closes #14519 by merging it.
 2014-10-26 04:38:18 +01:00
Andrew S. Brown 1b3237629a Allow multiple delegated tooltip selectors on a node 
Fixes #14167.
Closes #14189 by merging it.
 2014-10-26 03:51:55 +01:00
Heinrich Fenkart 0e991ccba2 Follow-up to e8af21c: rm unused variable in unit test 2014-10-26 03:16:05 +01:00
Tadeu Zagallo e8af21cc9d Clear scrollspy selection above first section 
Closes #13563 by merging it.
 2014-10-26 03:14:08 +01:00
Cameron Little 0755d529c6 Tabs plugin accessibility 
Added support for `aria-expanded` toggling via JavaScript. Added
`aria-controls`, `aria-expanded`, `aria-labelledby` to tabs docs.

Added `aria-expanded` unit test for the tabs plugin.

See also #13554.

Closes #14154 by merging it.
 2014-10-26 02:25:47 +01:00
Heinrich Fenkart c1f669e83b Revert "Scrollspy: ignore invisible list items" 2014-10-26 01:50:38 +02:00
Heinrich Fenkart fe51148434 Merge pull request #14669 from vsn4ik/dropdown_event_target 
Use e.target instead :focus selector.
 2014-10-23 06:13:46 +02:00
Heinrich Fenkart 3c98dd35ba Fix IE8 unit test breakage introduced by #14767 2014-10-22 22:09:58 +02:00
Phil Hughes ab8dbc214e Implement `hide` and `hidden` events for tabs 
Closes #14772.
 2014-10-22 21:42:35 +02:00
Heinrich Fenkart 95e0f48e3a Follow-up to e2cfbd5: Fix spaces in placement calculation 2014-10-22 21:38:34 +02:00
saranya.r e2cfbd5f2d Fixes tooltip misplacements in scrollable viewports with auto positioning 
Fixes #14756.
Closes #14767.
 2014-10-22 21:35:44 +02:00
Patrick H. Lauke e1d40f7633 Add `aria-pressed` to single toggle buttons 
also includes tiny fix/clarification to two existing unit tests for the
.active class, adding data-toggle=“button” explicitly to the tested
buttons

Closes #14819.
 2014-10-22 21:02:19 +02:00
Heinrich Fenkart e811a24118 Don't fire show event if show is prevented because other element is still transitioning 
Fixes #14844.
Closes #14845.
 2014-10-22 04:25:05 +02:00
fat 4bbe80658a fixes #13816 Modal dialog closes when dragging and releasing mouse button outside dialog 2014-10-09 20:01:51 -07:00
XhmikosR 909a178362 Change Twitter links to use `https`. 2014-10-07 15:28:41 +03:00
Heinrich Fenkart 61705d35fa Small clean-up in scrollspy unit test 2014-10-07 06:57:46 +02:00
Chris Rebert d361470487 tooltip unit tests: fix typo in test description 2014-10-03 16:26:53 -07:00
Maarten Van Hoof 44894a40e5 Add missing collapse JS files to dropdown visual test 
Closes #14726.
 2014-10-03 19:55:13 +02:00
Jacob 2c562d2386 Merge pull request #14590 from twbs/carousel-keyboard-option 
Add `keyboard` option to carousel
 2014-10-02 23:11:14 -07:00
Jacob 3fda099f5c Merge pull request #14722 from twbs/fat-14646 
Escape key should only close Dropdown
 2014-10-02 21:26:38 -07:00
fat e5fc22ccfa Escape key should only close Dropdown 2014-10-02 21:11:17 -07:00
Heinrich Fenkart 038a63b0eb Add `keyboard` option to carousel 
Also adds unit tests for keyboard events.

Fixes #14468.
 2014-10-03 05:16:31 +02:00
Jacob b702889613 Merge pull request #14626 from twbs/carousel-pause-hover-non-mobile 
Only enable `pause: hover` for non-touch browsers
 2014-10-02 20:09:20 -07:00
Chris Rebert 443a1b11ee tooltip.js: fix alignment 2014-09-24 21:27:56 -07:00
Chris Rebert 4d9890ea2e Use container instead of parent for tooltip/popover auto-placement calcs 
Fixes #14561. Big thanks to @wickstargazer.

[skip validator]
 2014-09-24 20:46:49 -07:00
Heinrich Fenkart 24ae068f21 Tooltip: Rely on `getBoundingClientRect` for `width` and `height` 
Fixes #14553.
 2014-09-25 01:35:51 +02:00
Heinrich Fenkart c37c1a6743 Only enable `pause: hover` for non-touch browsers 
Fixes #11967.
 2014-09-23 23:34:58 +02:00
vsn4ik bd66b12a94 Use e.target instead :focus selector. 2014-09-23 13:19:15 +04:00
Heinrich Fenkart acf3c0bf48 Merge pull request #14570 from twbs/remove-modal-open-after-backdrop-closed 
Remove `.modal-open` class after backdrop is hidden
 2014-09-22 21:44:39 +02:00
Chris Rebert 6f6466330d Make it easier to see failing tests in Sauce screencasts 
...by hiding passing tests in the list of tests.
 2014-09-17 18:33:39 -07:00
Heinrich Fenkart 3beeb32bb0 Follow-up to #14581: Use div instead of HTML5 section for IE8 2014-09-17 23:33:22 +02:00
saranya.r db9e8ee813 Fix tooltip misplacement with "auto top" 
Fixes #14322.
Closes #14581.
 2014-09-17 23:11:04 +02:00
Heinrich Fenkart c4f431d262 Remove `.modal-open` class after backdrop is hidden 
Fixes #14274.
Fixes #14632.
 2014-09-17 09:21:09 +02:00
Heinrich Fenkart 152d9dfe2e Merge pull request #14610 from twbs/axe-tooltip-validate 
Remove unused Tooltip#validate method
 2014-09-16 05:41:17 +02:00
Chris Rebert 73e3db0a2f Must explicitly destroy tooltip in SVG unit test since its container is body. 
Leaking tooltips across tests leads to confusion and sadness.
 2014-09-15 20:01:06 -07:00
Heinrich Fenkart e094d470d4 Remove unused Tooltip#validate method 2014-09-13 09:39:15 +02:00
Peter West 4c98507010 Correctly selects arrow placement for a tooltip 
Fixes #13696.
Fixes #13696.
Fixes #14197.
Closes #13718.
 2014-09-13 04:25:34 +02:00
Heinrich Fenkart 76762169c3 Properly fire hidden event when tooltip is destroyed 
Fixes #13031.
 2014-09-13 03:07:32 +02:00
Heinrich Fenkart a97db64881 Merge pull request #14569 from twbs/scrollspy-ignore-invisible-targets 
Scrollspy: ignore invisible list items
 2014-09-13 02:29:28 +02:00
Heinrich Fenkart 40f889df2a Merge pull request #14353 from hnrch02/collapse-count-collapsing-as-active 
Collapse: count `.collapsing` elements as actives; closes #13447
 2014-09-13 02:28:25 +02:00
Heinrich Fenkart 6e206f5e8f Merge pull request #14492 from twbs/ie8-getBoundingClientRect 
Handle lack of .width and .height from getBoundingClientRect() in IE8
 2014-09-11 23:11:45 +02:00
Heinrich Fenkart 759a95b0fe Make inDom check of tooltip cross document compatible 
Fixes #14483
 2014-09-09 03:03:14 +02:00
samme e29c75041e Make affix accept `0` as offsetTop or offsetBottom 
Fixes #12815.
Closes #14363.
 2014-09-09 01:32:42 +02:00
Heinrich Fenkart 9b9e2f5d13 grunt and missing new line 2014-09-09 01:23:48 +02:00
Patrick H. Lauke fb1ca10b99 ARIA support for collapse 
Added handling of aria-expanded=true/false to collapse.js, updated
documentation to include advice on making expand/collapse controls
accessible, updated examples and javascript documentation to use
aria-expanded and aria-controls (when targetting single collapsible
element, using ID rather than class selector)

Closes #14147.
Closes #14153.
 2014-09-09 01:19:20 +02:00
Heinrich Fenkart d15444d15e Scrollspy: ignore invisible list items 
Fixes #13071
 2014-09-09 00:18:18 +02:00
Heinrich Fenkart 859ddc11fb Merge pull request #14242 from hnrch02/remove-aria-describedby-later 
Remove `aria-describedby` attribute later
 2014-09-08 23:14:50 +02:00
Heinrich Fenkart e4b55ded5c Merge pull request #13928 from SGinTech/sgit_collapseEventOrder 
Ensure that hidden event is sent when content is really hidden (collapsi...
 2014-09-08 23:12:27 +02:00
Heinrich Fenkart 787404e090 Merge pull request #14287 from hnrch02/revert-13855-modal-mousedown 
Revert #13855 due to #14263
 2014-09-08 22:23:43 +02:00
Chris Rebert 7f56233862 Merge branch 'stefansundin/master' 2014-09-07 23:07:38 -07:00
Stefan Sundin f25181615e Fix bug not re-calculating scrollbar width when opening modal. 
If opening a modal when a scrollbar is present, closing it, then
resizing the window so the scrollbar disappears, then opening the
modal again, the content would shift. This fixes the problem by
always calculating the scrollbar width every time a modal is opened.

Closes #14357.
 2014-09-07 23:06:37 -07:00
Chris Rebert 989dafb153 Handle lack of .width and .height from getBoundingClientRect() in IE8 
Closes #14093
Correction to #14090
Relevant docs: https://developer.mozilla.org/en-US/docs/Web/API/Element.getBoundingClientRect#Browser_compatibility
 2014-09-07 22:58:33 -07:00
Jacob c22b270582 Merge pull request #14273 from sgonyea/master 
Fix hover-popover/tooltip flickering when mouse re-enters
 2014-09-07 10:36:45 -07:00
Scott Gonyea aac0e16452 Fix hover-tooltip flickering when mouse re-enters 
- is(':visible') seems to be the only reliable check, without a refactoring of how hoverState is used
- tests need improvement
 2014-08-28 17:17:50 -07:00
XhmikosR d869a5fb62 Update QUnit to v1.15.0. 2014-08-28 09:38:53 +03:00
Heinrich Fenkart c207b5b66b Change value of stateful button after event loop 
Fixes #14450
 2014-08-26 03:02:29 +02:00
Mark Otto 875006d08c Merge pull request #14417 from twbs/fat-14282 
fixes #14282 - Already Visible collapse gets closed when …
 2014-08-23 12:58:24 -07:00
Chris Rebert 9efedf8f7b Merge pull request #14406 from twbs/nav-tag-for-navbar 
consistently use <nav> instead of <div> for .navbar in docs
 2014-08-20 21:48:59 -07:00
Jacob c95aa97c03 Merge pull request #14244 from programcsharp/master 
Remove popover content with .children().detach() instead of .empty()
 2014-08-18 20:06:02 -07:00
fat 9c2e54bfec fixes #14282 - Already Visible collapse gets closed when .collapse('show') is called 2014-08-18 19:58:19 -07:00
Chris Rebert ea0e1606dc Assume Element.getBoundingClientRect() exists; Fixes #14093 
[skip validator]
 2014-08-17 16:08:49 -07:00
Chris Rebert 6b7142212f consistently use <nav> instead of <div> for .navbar in docs 2014-08-15 18:09:05 -07:00
Heinrich Fenkart 436015c191 Collapse: count `.collapsing` elements as actives; closes #13447 2014-08-08 01:23:50 +02:00
Heinrich Fenkart 75bffd84ae Use closest `.alert` for alert dismissal; closes #14306 2014-08-04 19:33:42 +02:00
Heinrich Fenkart dca8afa333 Remove `aria-describedby` attribute later 
Fixes #14241
 2014-08-04 19:21:49 +02:00
Jacob 8bf48121a0 Merge pull request #14061 from hnrch02/fix-13656 
Expose transition durations on plugin constructors; closes #13656
 2014-08-01 12:50:03 -07:00
Chris Rebert 08393bf68a Fix #14076: Add unit test for tooltips on SVG elements 
[skip validator]
 2014-08-01 12:10:00 -07:00
Chris Rebert cbba8e53df Fix #13818 by using more robust "find next carousel item" logic 
Also adds another test for #9461: carousel next/prev should ignore non-items
 2014-07-31 11:36:24 -07:00
Heinrich Fenkart 18c0a1c977 Revert "Use mousedown instead of click for backdrop click detection; fixes #13816" 2014-07-30 23:54:25 +02:00
Chris Hynes 531fc80885 Use .end() to remove extra line 2014-07-25 11:10:46 -07:00
Chris Rebert c2f4e5fef1 re-alphabetize .jscsrc 2014-07-25 11:02:30 -07:00
Chris Hynes 519a087dbe Remove popover content with .children().detach() instead of .empty() so it can be reused 2014-07-25 10:16:44 -07:00
Artem Belov 098242afd8 Delete duplicate JSCS properties 2014-07-25 15:03:07 +04:00
Jacob 36483af92c Merge pull request #14207 from twbs/charlesbjohnson-affix-bottom-when-dynamic-height 
Charlesbjohnson affix bottom when dynamic height
 2014-07-21 22:48:38 -07:00
fat 4775c9296a Merge branch 'dropdown-aria' of git://github.com/mckramer/bootstrap into mckramer-dropdown-aria 
Conflicts:
	docs/_includes/js/dropdowns.html
 2014-07-21 22:44:35 -07:00
fat eff9b063da cleanup style 2014-07-21 22:37:04 -07:00
Charles B Johnson 724c4f526c Fix issue where bottom affixed element floats over the footer when the 
document height is smaller than the viewport height.
 2014-07-18 10:46:42 -04:00
Charles B Johnson 8c0eb9b00e Refactor determining affix state into a separate expanded method 
in order to handle multiple edge cases, specifically when the document
  height is dynamic.
Always reposition an affix that is affixed to the bottom.
 2014-07-18 10:45:59 -04:00
Charles B Johnson d3dea01a11 Add a bottom affixed element to affix visual tests. 2014-07-18 10:45:59 -04:00
Jacob 866ffc4f37 Merge pull request #14055 from twbs/fat-speed-up-tests 
speed up js tests a bit
 2014-07-17 10:07:28 -07:00
fat 9b90b87099 speed up js tests a bit 2014-07-16 22:22:42 -07:00
Heinrich Fenkart cc7fab893d Follow-up to #13907: simplify JS logic for focus shim 2014-07-16 08:44:56 +02:00
Heinrich Fenkart 1719d2b051 `document.head` is undefined in IE8 2014-07-09 00:42:02 +02:00
Heinrich Fenkart 0268b41c4f Fix IE8 reporting type object for `getBoundingClientRect` 2014-07-09 00:42:02 +02:00
Heinrich Fenkart 05ddea314c Fix IE8 reporting height style as all uppercase 2014-07-09 00:42:02 +02:00
Chris Rebert 21571b3412 Fix invalid HTML in "should allow html entities" tooltip unit test 
Refs #14090.
Also, fix one typo.
 2014-07-08 14:40:20 -07:00
Heinrich Fenkart 231744d628 Expose transition durations on plugin constructors; closes #13656 2014-07-07 13:03:56 +02:00
Mark Otto 907b3b2892 Merge pull request #13907 from twbs/fat-12145 
add "focus" to focused btns with button plugin
 2014-07-07 00:36:59 -07:00
fat 587c09cb48 fix scrollspy test in firefox mac os 2014-07-06 21:50:46 -07:00
Jacob b5d86ad0bd Merge pull request #13853 from hnrch02/unit-tests-cleanup 
Major unit tests cleanup
 2014-07-06 21:43:48 -07:00
Mark Otto 44f83fff90 Merge pull request #14021 from CFXd/add_collapsed_default_class_to_navbar_collapse_button 
Add collapsed default class to navbar-toggle
 2014-07-06 16:37:42 -07:00
Mark Otto ac18e5811d jscs fix 2014-07-06 15:08:33 -07:00
fat cb19f4f227 Merge branch 'breaddevil-replace-scrollspy-default-behavior-test' 2014-07-06 14:11:38 -07:00
fat b19719ea1a Merge branch 'replace-scrollspy-default-behavior-test' of git://github.com/breaddevil/bootstrap into breaddevil-replace-scrollspy-default-behavior-test 
Conflicts:
	js/tests/unit/scrollspy.js
 2014-07-06 14:11:23 -07:00
Jacob 279c46152b Merge pull request #13815 from hnrch02/tabs-fade-not-active 
Allow tabs to fade in if no initially active pane is present
 2014-07-06 13:50:54 -07:00
Heinrich Fenkart 58eb8b2ae3 Move to leading pluses 2014-07-06 11:56:12 +02:00
Chris Rebert a34e52de4d Merge pull request #14015 from twbs/possible-14013-fix 
Possible fix for #14013
 2014-07-06 00:36:52 -07:00
Heinrich Fenkart dad56be96c Move to 16ms from 18ms based on the Paul Irish's rAF polyfill 2014-07-06 09:24:23 +02:00
Heinrich Fenkart 8ff099585f Mention #13500 in comment for ScrollSpy test 2014-07-06 09:24:23 +02:00
Heinrich Fenkart e341355d28 Clean tooltip unit tests up 2014-07-06 09:24:23 +02:00
Heinrich Fenkart b3a125e941 Clean tab unit tests up 2014-07-06 09:24:23 +02:00
Heinrich Fenkart 05ba1e491e Clean scrollspy unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 56b8d5fe6e Clean popover unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 998c3724e8 Clean modal unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 9ff66a12bc Clean dropdown unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 77d0557468 Clean collapse unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 6a523bf99d Clean carousel unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart f3345f68d7 Clean button unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart b063de54a5 Clean alert unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 95d7c9c3fb Clean affix unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 4950fe6f4e Perform a cleanup after each test 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 1e64c4c0ba Update QUnit settings/QUnit phantomjs bridge to new versions 2014-07-06 09:24:22 +02:00
Chris Rebert f9ffb49932 refactor/reformat Tooltip.getPosition per @fat's feedback 2014-07-06 00:16:54 -07:00
Jacob 5830febd9a Merge pull request #13855 from hnrch02/modal-mousedown 
Use mousedown instead of click for backdrop click detection; fixes #13816
 2014-07-06 00:01:57 -07:00
Jacob 13a4c50cc7 Merge pull request #14000 from hnrch02/modal-keydown 
Only close modal if escape was hit with keydown; fixes #13929
 2014-07-05 23:55:36 -07:00
fat c08e275000 fix build 2014-07-05 23:49:45 -07:00
fat 22f851fa62 apply #14022 without semicolon – cleans up some jquery class usage 2014-07-05 23:28:44 -07:00
Wing 4b08832308 no need to create $.Event 
`trigger()` can handle string argument
 2014-07-03 10:52:22 -07:00
Wing 48b822db40 trigger 'affixed.bs.affix' instead of 'affixed' 
Original is triggering `affixed` not `affixed.bs.affix`, only `.on('affixed.bs.affix', ...)` also catch `affixed` event.

Closes #13998.
 2014-07-03 10:52:22 -07:00
Michael Silber 1e407c81f1 Add collapsed default class to navbar-toggle 2014-07-02 16:49:03 -04:00
Chris Rebert 1ce5e9f3ae possible fix for #14013 2014-07-02 10:09:28 -07:00
Heinrich Fenkart 91f329e448 Only close modal if escape was hit with keydown; fixes #13929 2014-07-01 05:50:31 +02:00
Heinrich Fenkart 121bf6633e Use mousedown instead of click for backdrop click detection; fixes #13816 2014-07-01 02:53:57 +02:00
Mark Otto ff6b279b3c bump to v3.2.0 2014-06-26 09:13:24 -07:00
sgamel 9445b84b0b Ensure that hidden event is sent when content is really hidden (collapsing class is removed) 2014-06-26 10:18:45 +02:00
Heinrich Fenkart 282f8fc04b Add a few more cases to the visual test tab page 2014-06-25 04:18:51 +02:00
Heinrich Fenkart 634ea59a25 Allow tabs to fade in if no initially active pane is present; fixes #13814 2014-06-25 04:18:51 +02:00
fat 6b6476fcd9 add "focus" to focused btns with button plugin 2014-06-23 23:39:54 -07:00
fat 0aa01f63e3 Merge branch 'master' into fix-13386 
Conflicts:
	js/carousel.js
 2014-06-23 23:08:23 -07:00
Chris Rebert c2c19a4d2d Revert UMD (#13772 & friends) for now, due to #13812. 
Will hopefully revert this reversion and land a fully-working version of UMD in v3.3.0.

Revert "some changes from #13801 - add strict mode back and =="
This reverts commit 2b302f69ee.

Revert "Fix regression of #10038 introduced by #13772"
This reverts commit e9d6756a1a.

Revert "MD/CommonJS/Globals #12909"
This reverts commit 1c6fa9010d.

Revert "address #13811"
This reverts commit f347d7d955.

Conflicts:
    js/carousel.js
    js/collapse.js
    js/dropdown.js
    js/modal.js
    js/tab.js
    js/tooltip.js
 2014-06-23 11:11:59 -07:00
Heinrich Fenkart 587451ad9a Update a few source files to comply to new JSCS rules 2014-06-19 21:08:05 +02:00
Heinrich Fenkart 09c2e41ec4 Remove deprecated JSCS rules and add requireSpaceAfterLineComment 2014-06-19 21:08:05 +02:00
Erwan Jegouzo 1b63d0b9ba fix for #13747 
Closes #13782 by merging it.
 2014-06-17 17:56:15 -07:00
Chris Rebert f071549c84 fix #13386 2014-06-13 12:12:32 -07:00
fat 2b302f69ee some changes from #13801 - add strict mode back and == 2014-06-12 11:11:04 -07:00
Jacob 696632d7da Merge pull request #13786 from twbs/fat-13430 
add special transitionend type to test event origin
 2014-06-11 22:44:04 -07:00
Heinrich Fenkart e9d6756a1a Fix regression of #10038 introduced by #13772 2014-06-12 06:00:02 +02:00
Jacob 6ac5708a0d Merge pull request #13787 from twbs/fat-3731 
fix #13185 - keyboard support for carousel
 2014-06-11 15:19:39 -07:00
fat 7f122be004 add special transitionend type to test event origin 
fixes #13430
 2014-06-10 20:42:19 -07:00
fat a1dad14f44 fix #13185 - keyboard support for carousel 2014-06-10 20:35:03 -07:00
fat 571fd32bce fix #13220 Scrollspy generates wrong offsets for a page-- recalculate offsets if `scrollheight` changes 2014-06-10 17:38:42 -07:00
Katie Zhu 1c6fa9010d MD/CommonJS/Globals #12909 2014-06-10 17:16:29 -07:00
Katie Zhu 5eaedbe097 change how carousel indicators activate #12592 2014-06-09 21:59:03 -07:00
Jacob fe74a8bb3e Merge pull request #13755 from twbs/fat-visual-test 
Adds isolated visual tests for javascript plugins (decoupled from docs)....
 2014-06-08 16:05:08 -07:00
fat 91103e6d1f Adds isolated visual tests for javascript plugins (decoupled from docs). This makes it 
faster and easier to test/develop js functionality not represented in unit tests, and gives us
a playground for interactions, etc.

It also makes it so developing javascript is now decoupled form jekyll, which should make everything
faster and less painful.

This commit also reverts my filter commit 9900771aa7
which broke scrollspy for dropdowns.
 2014-06-07 19:11:44 -07:00
Mike Greiling 1cfa902e31 refactor scrollspy refresh method 
Closes #13702 by merging a rebased version of it.
 2014-06-07 18:26:39 -07:00
Mike Greiling bc8e6ffb7d removing this.$element as it is a superfluous copy of this.$scrollElement 2014-06-07 18:09:53 -07:00
Mike Greiling 632313d631 no need to check for href attribute on the scrollable element 2014-06-07 18:09:53 -07:00
Mike Greiling 0be4109688 there is no need for this.offsets and this.targets to be jQuery objects 2014-06-07 18:09:53 -07:00
Chris Rebert 21de05c8c0 don't show tooltips/popovers whose element isn't in the DOM; fixes #13268 2014-06-07 17:54:11 -07:00
Chris Rebert b23ed1b034 put the tooltips into the DOM in the tooltip unit tests 2014-06-07 17:54:11 -07:00
Chris Rebert 20c099d41a add failing test for #13268 2014-06-07 17:54:10 -07:00
XhmikosR 3b99a41246 Merge pull request #13388 from twbs/xhmikosr-js-style 
Improve JS style
 2014-06-07 09:13:05 +03:00
Chris Rebert 3cbbc70d55 Merge pull request #13627 from twbs/maybe-fix-12364 
Hopefully fixes trigger focus restoration on modal close
 2014-06-06 15:59:17 -07:00
XhmikosR e2cabe4971 Minor style tweaks. 2014-06-06 01:23:07 +03:00
XhmikosR 82fc03f3b6 carousel.js: remove unneeded variable assignment. 
`slideIndex` is assigned to the same value a few lines above.
 2014-06-06 01:23:07 +03:00
XhmikosR 7b0acf14d8 Comply to the new style. 2014-06-06 01:23:07 +03:00
XhmikosR 5ef9383f53 Tweak JSHint and JSCS checks. 
Be more consistent across the whole codebase.

Also, make use of JSHint's 2.5.1 `extends` and `qunit` options. This way we set our basis options in js/.jshintrc and override the rest.
 2014-06-06 01:23:06 +03:00
Chris Rebert 475dbe58b0 Merge pull request #13589 from mrobinet/scrollspy-maxScroll-with-offset 
Adjust for Scrollspy offset when calculating maxScroll.
 2014-05-23 14:36:05 -07:00
Chris Rebert bc1ce426d9 Merge pull request #13593 from ResentedHook/master 
Add tooltip self-reference to address #12320
 2014-05-23 14:33:19 -07:00
Chris Rebert ef62254917 Merge pull request #13557 from bassettsj/aria-describedby-tooltip-13480 
Aria describedby tooltip: #13480
 2014-05-23 14:11:15 -07:00
Max Kramer ee12ce8305 Add aria-haspopup and aria-expanded attributes to dropdown plugin 
1. Add aria-haspopup="true" and aria-expanded="false" to dropdown docs
2. Toggle aria-expanded between "true" and "false" when opening and closing dropdown

Satisfy item 1 from https://github.com/paypal/bootstrap-accessibility-plugin#dropdown. See #13553.
 2014-05-22 18:13:41 -04:00
Chris Rebert b058c018eb Hopefully a fix for #12364 
* register the callback before invoking the toggling
* listen for `hidden` instead of `hide`
* account for the possibility of the associated `show` event being preventDefault-ed

Adds relevant unit tests.
 2014-05-19 02:14:14 -07:00
Chris Rebert e9b99d475c fix typo in assertion description 2014-05-19 00:47:06 -07:00
Chris Rebert 3d1723d689 add missing event namespacing in modal.js 2014-05-16 17:05:03 -07:00
Attila Dobi f47ad79538 add `target` option to Affix plugin 2014-05-16 13:07:45 -07:00
Steven Bassett a70da16f6f Adds aria described by to tooltip plugin for accessibility 
Generates a unique id for tooltip and adds [aria-describedby] to the element
it is called on. Resolves issue #13480

- set up test
- linted the code styles
- passed the tests
- integrated feedback from @cvrebert
 2014-05-16 10:45:38 -07:00
j.corns 122c05dbd8 Add tooltip self-reference to address #12320 
primarily adds a data- attribute to the tooltip (and thus, the popover)
to create a self-reference.
 2014-05-14 10:36:32 -07:00
Mike Robinet c2e94eba8d Add Scrollspy maxScroll with offset test. 2014-05-13 12:53:54 -05:00
Mike Robinet e84b0c0433 Adjust for Scrollspy offset when calculating maxScroll. 2014-05-13 09:57:04 -05:00
XhmikosR 7a765d1f8b Update jQuery to v1.11.1. 2014-05-13 08:33:23 +03:00
fat f219fee07b versions 2014-05-12 21:15:16 -07:00
Jacob c312d735d9 Merge pull request #13191 from AshleyDawson/master 
Fixed nested tab elements li activation
 2014-05-12 20:57:21 -07:00
fat 9900771aa7 fixes #12211: Scrollspy: Navs in different tabs can interfere with each othe 2014-05-12 19:15:23 -07:00
Gregory Pakosz 78cac11cef Fixed affix-bottom positioning 
Set top position to (scrollHeight - this.$element.height() - offsetBottom).
 2014-05-09 00:26:31 +02:00
Chris Rebert 9444df2476 Merge pull request #13511 from hnrch02/button-reset-falsey-values-fix 
Allow for resetText of a button to be a falsey value; fixes #13466
 2014-05-05 22:55:05 -07:00
Chris Rebert a032c396ee Merge pull request #13406 from EnsignR/closed.bs.alert-after-remove 
fires closed.bs.alert *after* DOM detach() as per #12379
 2014-05-05 22:47:50 -07:00
Heinrich Fenkart d8ee1ba9b6 Allow for resetText of a button to be a falsey value; fixes #13466 2014-05-05 19:07:47 +02:00
Chris Rebert 06af640e82 import rules from Ratchet's JSCS config with which we already comply 2014-05-04 15:15:02 -07:00
breaddevil 7627b24c1e replace js scrollspy test for default behavior 2014-05-04 11:24:31 +02:00
Chris Rebert d9edf28c5f make new Carousel tests compatible with noConflict mode 2014-05-01 13:37:44 -07:00
Chris Rebert b23ca2de41 add role="tooltip" to popovers; fixes #13481 2014-05-01 13:27:00 -07:00
Mark Otto f20f66604b Merge pull request #11966 from colllin/noconflict 
Fix #11464 - JS noConflict() mode not working in 3.0.x
 2014-04-30 17:43:43 -07:00
Ross Nye 73f7acc01b Update alert.js 
Added call to remove() after event fires to clean up data as per discussion at #12379
 2014-04-30 13:12:31 +10:00
Chris Rebert 05d4932cad Merge pull request #13396 from twbs/carousel-events 
Carousel event properties
 2014-04-25 19:35:38 -07:00
Chris Rebert e114727ae9 Carousel.slide: rename e => slideEvent 2014-04-25 17:50:38 -07:00
Chris Rebert 4bd29bfcff change 'slid' comments per @fat's feedback 2014-04-25 17:48:02 -07:00
Chris Rebert 4d0a8e31a4 Add direction & relatedTarget properties to slid.bs.carousel event 
Fixes #13393
 2014-04-24 19:02:47 -07:00
Ross Nye 637808f2ee fires closed.bs.alert *after* DOM detach() 
fires closed.bs.alert *after* element is removed from DOM.
Previously it fired while the element was still attached.
 2014-04-23 17:34:32 +10:00
Collin Donahue-Oponski a9f2b6ce0f #11464 - Fix JS noConflict mode - Refactor all plugins to use an internal reference to the jQuery plugin, because in noConflict mode you can never expect to be defined on the jQuery object 2014-04-21 23:03:33 -06:00
fat b9ae07d84a fixes #13157 - Collapse plugin - issues with transition end event bubbling 2014-04-21 17:35:29 -07:00
Chris Rebert f66a747615 add unit tests for Carousel slid events 2014-04-21 13:14:53 -07:00
Chris Rebert 9c4afc5772 spelling fixes in Carousel unit tests 2014-04-21 13:08:42 -07:00
Chris Rebert d971ddb730 add missing operators to some JSCS rules that we already comply with 2014-04-20 16:33:23 -07:00
Tobias Lindig a69bc3bc09 move call for removeBackdrop() to backdrop() 
Closes #11958 by rebasing & merging it
 2014-04-20 14:47:32 -07:00
Jacob b02d3c7eff Merge pull request #13306 from twbs/fat-11099 
fixes #11099 - $.collapse() overrides the original dimension of the coll...
 2014-04-20 12:12:17 -07:00
Jacob 4f427cbe32 Merge pull request #13354 from twbs/fat-13296 
fixes #13296 Dropdown disappears with right-click on Firefox
 2014-04-20 12:11:25 -07:00
Chris Rebert 170ba560c2 quote attribute value in ^= selector in button.js 2014-04-19 18:53:23 -07:00
Chris Rebert a54e6d4ea9 rename jquery.js -> jquery.min.js since it's minified 2014-04-19 18:25:40 -07:00
Chris Rebert 0aaf2cdd3a quote attribute values in selectors in JS unit tests for consistency 2014-04-19 17:45:58 -07:00
fat f2af95353e fixes #13296 Dropdown disappears with right-click on Firefox 2014-04-15 21:52:34 -07:00
fat cd4696f723 fixes #11099 - $.collapse() overrides the original dimension of the coll... 2014-04-15 21:16:40 -07:00
Germán M. Bravo 82b066f0a9 Wait for the expected target during a collapse 
Actually wait for the collapsed item to complete. If complete is called
with other target, instead of simply returning and do nothing, wait again
until the proper target triggers the event (otherwise this leaves collapse
in a broken state).
 2014-04-12 14:44:35 -05:00
XhmikosR 45b476bdbf JS: remove unused variables. 2014-04-09 10:01:48 +03:00
Collin Donahue-Oponski d7a3771abd When opening the dropdown, focus() the dropdown-toggle BEFORE triggering 'shown.bs.dropdown' 
Closes #11281 by merging it (after rebasing & resolving conflicts)
 2014-04-08 22:36:21 -07:00
Chris Rebert 5ef634dab9 replace $.bind() with $.on() in unit tests; per #13272 2014-04-03 18:13:16 -07:00
XhmikosR 2b30b48894 Fix the new JSHint warnings. 2014-04-03 10:53:13 +03:00
Chris Rebert 26f6807a3d Add comments in carousel.js to clarify that "slid" is not a typo 
Addresses #13248.
 2014-03-31 18:09:24 -07:00
Tyler Cipriani 0907244256 Modal body shift fix for IE10/11 
Closes #13103 by merging it.
 2014-03-28 23:45:22 -07:00
Ashley Dawson 138af82e29 Fixed nested tab elements li activation 
Added closest li instead of direct parent so that you can nest multiple elements within tabs, such as button groups
 2014-03-26 22:21:54 +00:00
Jacob b3421cf040 Merge pull request #13165 from stefanneculai/master 
Fix popover when using append
 2014-03-24 22:42:40 -04:00
Mark Otto 39fec66fc4 Merge branch 'master' into fat-9461 2014-03-24 19:30:17 -07:00
fat 4a2d337bf5 fixes #9461 - Make carousel ignore non-items in carousel-inner 2014-03-24 19:23:39 -07:00
Stefan Neculai 674b41dd63 Add test for popover. 2014-03-24 19:49:06 +02:00
Stefan Neculai 41628c90a2 Fix popover when using append. 2014-03-24 18:49:03 +02:00