root
/
bootstrap
mirror of https://github.com/twbs/bootstrap.git
1
0
Fork 0
Code Issues Actions 11 Packages Projects Releases Wiki Activity
18,958 Commits 105 Branches 92 Tags 675 MiB
Commit Graph

1703 Commits

Author SHA1 Message Date
Mitchell Bryson 896e444895
Check for data-interval on the first slide of carousel - v4 (#31820) 
When starting a cycle for a carousel, it only checks for a default interval, and not an interval defined on the slide element via data props. This adds a check in before creating the interval to move to the next slide.

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2020-11-12 09:34:17 +02:00
XhmikosR b3aa3958da Backport #32045 
tests: fix sanitizer test.

The test template does not include a `script` tag so the test always returned true.
 2020-11-05 11:22:05 +02:00
XhmikosR 5664e728b4
Move js/src/index.js one folder up (#32001) 2020-11-01 07:31:17 +02:00
Patrick H. Lauke 5f1bc4a756 Remove redundant visually hidden "(current)" from pagination controls (#31892) 
* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
 2020-10-27 12:11:01 +02:00
XhmikosR a716fb03f9
Prepare v4.5.3. (#31880) 2020-10-13 18:38:30 +03:00
XhmikosR c049713382 Remove the unused js/dist/index.js.map 2020-10-13 15:24:40 +03:00
XhmikosR 1b48122641 Update .eslintrc.json 
Enforce ES5 for tests
 2020-10-13 15:24:40 +03:00
Laussel Loïc 24572b1577
buttons plugin : avoid multiple change event trigger (#31000) 
- add unit test to count how many events are thrown when widget contains multiple tags inside label
- add a parameter to toggle, if click event is provided onto an input then don't trigger another change event already thrown by the browser
- simplify the case where toggle interface is called click provide from input itself OR it's a button without label. If label is present, then browser propagate click event from childrens through label and then cause multiple calls to toggle
- the test assumes that `.btn` class is always set onto the label if there's one, otherwise need to update this plugin and look for label around the input

Test with keyboard, mouse and js click call

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2020-10-02 17:40:20 +03:00
XhmikosR 31eb108811 Add parentheses around multiple spread conditions 2020-09-21 14:58:34 +03:00
XhmikosR b31046aab3 Cache a few variables. 2020-09-21 14:58:34 +03:00
XhmikosR c86b74fe88 Unbreak lines and remove a TODO comment 2020-09-21 14:58:34 +03:00
Joakim Riedel b0a0c56788
ensure `hidePrevented.bs.modal` can be prevented (#31696) 2020-09-21 14:41:40 +03:00
XhmikosR dc2f1e68cd
Dropdown: fix variable always evaluating to true (#31673) 2020-09-18 10:22:24 +03:00
XhmikosR 3be585990c Comply to the new rules 2020-09-10 12:06:30 +03:00
XhmikosR 1c37a2ba77 Switch to xo and remove babel-eslint 2020-09-10 12:06:30 +03:00
XhmikosR 5f2480a90a
Prepare v4.5.2. (#31444) 2020-08-06 19:22:43 +03:00
XhmikosR 89dc9750ec
Prepare v4.5.1. (#31408) 2020-08-04 19:24:33 +03:00
Rohit Sharma 1abe9264aa Add unit test for toast to check clearTimeout to have been called (#31298) 2020-08-03 19:06:36 +03:00
Rohit Sharma f530ab7549 Clear timeout before showing the toast (#31155) 
* clear timeout before showing the toast

* Add unit test

* Remove the check for timeout

* Check for clearTimeout to have been called

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
# Conflicts:
#	js/tests/unit/toast.spec.js
 2020-08-03 19:06:36 +03:00
XhmikosR 38bcf108c9
Update dependencies, gems and regenerate package-lock.json (#31261) 
* @rollup/plugin-node-resolve 8.1.0
* popper.js 1.16.1
* qunit 2.10.1
* rollup 2.21.0
 2020-07-09 15:21:41 +03:00
ysds 9a6cfeb36e Backport #30326 (Unit test) 2020-07-06 16:40:27 +03:00
XhmikosR ea01c29294 Backport #30326 
Prevent overflowing static backdrop modal animation

TODO: backport the test too
 2020-07-06 16:40:27 +03:00
XhmikosR c49b084158 BrowserStack: test on Edge 15 2020-07-06 16:40:27 +03:00
XhmikosR 3349eb6a41 Update links to point to v4-dev or main branches 2020-06-24 15:16:58 +03:00
XhmikosR 78a51cb12f Backport #30973 
Remove the class `.nav-item` from `.nav-link` inside the non `ul` or `ol` based navs.
This makes the consistency for `.nav-item` (This class will not be required on the `.nav-link`).
`.nav-item` was only required when you use `.nav-fill` or `.nav-justified` on the `.nav`. In other cases, it was redundant. And the purpose of `.nav-item` on `.nav-link`s can be achieved via flexbox utilities as well (Mentioned in the docs also).
 2020-06-24 15:16:58 +03:00
Laussel Loïc e9f039d1fe
avoid preventing input event onclick (#30992) 
* instead of stopping event if onclick is triggered on input, call toggle method only if its not on checkbox inside a label

* add unit test

* add a dedicated test to ensure click event is forward to label

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
 2020-06-10 15:45:31 +03:00
XhmikosR 3caea1ca02 visual/modal.html: fix close buttons placement 2020-06-04 17:53:16 +03:00
XhmikosR 8bc6dcd280 Backport #30936 
Add role="dialog" in modals via JavaScript
 2020-06-04 17:53:16 +03:00
XhmikosR 7a9bbd4489 Backport #30742 
Update to `@rollup/plugin-babel`
 2020-06-04 17:53:16 +03:00
XhmikosR 7a6da5e3e7 Dist 2020-05-12 20:44:42 +03:00
XhmikosR 109ad5db90 Bump version to 4.5.0. 2020-05-12 20:44:42 +03:00
XhmikosR 30e7df6cca Backport d59de33 from #30772 
Add a test about the scrollbar issue on non-integer width
 2020-05-12 19:21:36 +03:00
Giovanni Mendoza f1827ce9cd Avoid bad scrollbar replacement into width values 
Refs #30772
 2020-05-12 19:21:36 +03:00
Rohit Sharma d2f9fbd055 Removed role="document" from the modal dialog (#30755) 2020-05-12 19:21:36 +03:00
XhmikosR 86f2c01459 Partially revert "Use regex.test() when we want to check for a Boolean. (#29969)" 
This partially reverts commit 6c46493803.
 2020-05-12 19:21:36 +03:00
XhmikosR 955c437f32 collapse.js: combine classes 2020-05-12 19:21:36 +03:00
XhmikosR eb720f20ff Minor lint tweaks and rules cleanup 2020-05-12 19:21:36 +03:00
XhmikosR 1c9e203c52 dropdown.js: switch to a ternary 2020-05-12 19:21:36 +03:00
XhmikosR 5f79b75ea8 tests: switch to strictEqual/notStrictEqual 2020-05-12 19:21:36 +03:00
XhmikosR 195585f5a6 scrollspy.js add more tests 2020-05-12 19:21:36 +03:00
XhmikosR fa8a7eca06 Remove variables used once. 2020-05-12 19:21:36 +03:00
XhmikosR 52fdab8d70 Join/break a few lines, no functional changes 2020-05-12 19:21:36 +03:00
XhmikosR e82888daf4 Revert "Avoid bad scrollbar replacement into width values (#30690)" 
This reverts commit 5f00bba652.
 2020-05-07 09:31:49 +03:00
Johann-S 22f75ca2e3 enforce element check on scrollspy target 2020-05-07 09:31:49 +03:00
XhmikosR 0f6cb9139f scrollspy.js: remove temporary variable (#30724) 2020-05-07 09:31:49 +03:00
Johann-S 5f00bba652 Avoid bad scrollbar replacement into width values (#30690) 2020-05-02 15:39:19 +03:00
Martijn Cuppens 7a678fc64f Backport #30633 
Remove caret element
 2020-04-28 20:59:30 +03:00
XhmikosR f5ec0dbf74 collapse: fix error with jQuery v3.5.0. 2020-04-17 11:41:32 +03:00
XhmikosR d848c32297 Fix tests for jQuery v3.5.0. 2020-04-17 11:41:32 +03:00
Laussel Loïc 0cf29baf63
v4 tabs - accessibility issue when using ul/li semantic (#30381) 
Add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc
 2020-04-10 08:35:09 +03:00