Commit Graph

43 Commits

Author SHA1 Message Date
David Bailey ba6a6f1369 Fix sticky margin when a modal is opened (#23669)
* Adjust margin for sticky elements on modal

Previously white space was visible to the right of sticky elements due to right padding being added to the body. This fixes #23661.

* Add unit tests for margin of sticky elements on modal
2017-08-25 22:01:41 +01:00
XhmikosR ef8c77d8dc Tweak ESLint rules. 2017-08-23 00:05:38 +03:00
Mark Otto 35f80bb12e bump to beta 2017-08-10 20:56:35 -07:00
Patrick H. Lauke 2626eba5f1 Prevent default for ESC in modal.js
ESC can be used to close modals, but on OS X/macOS this also jumps out
of full-screen mode. `preventDefault` suppresses this.
2017-04-09 16:19:20 +01:00
Ilias a14451deb3 Fix #18373: properly adjust padding-right of body and fixed elements when opening or closing modal 2017-04-02 13:26:25 +02:00
Pierre Vanduynslager 48c5efa4c3 Fix JS components console error "Error: <Component> is transitioning" 2017-03-28 23:43:15 +02:00
Johann 3f247a42f2 Fix Modal documentation about _handleUpdate method + move to public scope (#21877)
Fix Modal documentation about _handleUpdate method + move to public scope
2017-03-23 22:22:09 +01:00
Pierre Vanduynslager 275821bbb0 HTMLElement.offset* by getBoundingClientRect() (#21788)
* Replace element.offet* by getBoundingClientRect()

* Use variable to store BoundingClientRect

* Fix cc issue...
2017-03-18 18:24:54 -07:00
Mark Otto 045888fa38 version bump 2017-01-06 08:38:04 -08:00
Mark Otto c61a0059ad update seletors in js 2017-01-02 11:52:38 -08:00
Starsam80 bf39bb3ac3
Rename `.active` to `.show` 2016-12-07 21:20:15 -07:00
Johann 297c47c3fd [V4] Throw error when a plugin is in transition (#17823)
* Throw error when a plugin is in transition
* Add unit tests about plugins in transition
2016-12-02 09:52:19 -08:00
Juno_okyo 8c17e5fb3c Use multi-selector to remove the same event handler (#20642) 2016-11-28 13:42:32 -08:00
Mark Otto 25d218b02d Merge branch 'v4-dev-18796' of https://github.com/maxbeatty/bootstrap into maxbeatty-v4-dev-18796 2016-11-26 00:58:51 -08:00
Bardi Harborow c2616fb74e Make JS compliant with the new ESLint rules. 2016-11-24 11:59:55 +11:00
Bardi Harborow 0974267b8c Move from $.proxy to es6 arrow functions. (#21049) 2016-10-31 20:32:36 -07:00
Johann-S 9d129a43d6 Use a single class name for opened/expanded/shown state of widgets 2016-10-25 14:07:41 +02:00
Mark Otto 8ff7edaab4 version bump to alpha 5 2016-10-19 08:27:41 -07:00
Mark Otto 5495a4b3d3 versions 2016-09-05 12:41:44 -07:00
Max Beatty bfa714ae1e prevent navigating to area href when modal target. fixes #18796 2016-08-04 13:47:30 -07:00
Mark Otto 24e992a6ff bump versions 2016-07-27 09:31:24 -07:00
Chris Rebert 5dcd1a743d Tweak Esc key comment in modal.js
[skip sauce]
[skip validator]
2016-05-31 02:19:56 -07:00
Chris Rebert 5a35ad6d74 Use named constants for magic numbers (#19992)
Mostly KeyboardEvent.which and MouseEvent.which values.

[skip validator]
2016-05-30 23:42:00 -07:00
akai 4d1b9d7ce7 Remove stray "~" in modal paddingRight value (#19932)
[skip validator]
2016-05-18 13:53:01 -07:00
Patrick H. Lauke b107e3342a Handle aria-hidden on modal container when showing/hiding
Fixes #19878
2016-05-11 02:01:56 +01:00
Chris Rebert afdd62d161 Modal: Remove IE8-specific window.innerWidth workaround
[skip validator]
2016-04-21 01:15:24 -07:00
Chris Rebert d12ed5520e Modal: Ignore spurious `focus` event that Firefox fires at `document` when switching back to its tab
Fixes #18365
Refs https://bugzilla.mozilla.org/show_bug.cgi?id=1228802
2015-12-22 23:08:03 -07:00
Chris Rebert 31d4139a74 Update version numbers using npm script
Errata from:
* 8ce5da3026
* 5d3144e8fb
which missed a few numbers.

[skip sauce]
[skip validator]
2015-12-08 18:16:47 -08:00
Mark Otto 5d3144e8fb manually bump versions because npm script wasn't working for me 2015-12-08 09:36:08 -08:00
Chris Rebert 75c39f9138 Fix version numbers is JS files; fixes #18435
[skip sauce]
[skip validator]
2015-12-05 02:19:46 -08:00
XhmikosR 79a4273891 Tweak ESLint rules. 2015-12-03 08:41:46 +02:00
Jon Tewksbury 2d87ec9a64 Add eslint no-undef rule and resolve errors 2015-11-03 15:04:26 -08:00
Johann-S 21a65f181e Add throw error for undefined method on plugins 2015-10-02 10:01:24 +02:00
muzige2000 3af4560c67 Modals: Fix bad paddingRight calculation; fixes #17399
We want to sum two numbers, not concatenate their stringifications.
Closes #17457 by merging a tweaked version of it.
2015-09-03 01:25:38 -07:00
Jacob Thornton 18ff57a183 js tests passing + eslint 2015-08-18 19:22:46 -07:00
Jacob Thornton c830956d17 change modal.js to use is-fixed classes to target padding-right 2015-08-15 12:10:24 -07:00
Jacob Thornton 11abb0f7e9 fix modal 2015-08-12 21:12:03 -07:00
fat eaab1def7a add simple type checker implementation 2015-05-13 14:46:50 -07:00
fat b0d142334f fix #15301 2015-05-13 13:43:56 -07:00
fat 7ef0e52fd0 add "focus" option for turning off modal focusing #16050 2015-05-13 13:22:26 -07:00
fat f8b2569ec8 implement global dispose method 2015-05-13 12:48:34 -07:00
fat ab1578465a grunt test-js, grunt dist-js now working 2015-05-12 16:52:54 -07:00
fat ca9c850ebb add getters for Version and Default where applicable
add modal my gawd
2015-05-10 19:45:38 -07:00