Commit Graph

974 Commits

Author SHA1 Message Date
Chris Rebert adaabab81b Revert "Allow multiple delegated tooltip selectors on a node"
This reverts commit 1b3237629a.
This reverts PR #14189 because it caused major regressions.

Fixes #15168.

We'll try to revisit #14167's feature request in Bootstrap v4.

[skip validator]
2014-12-29 20:08:22 -08:00
Chris Rebert 32cb071594 Remove semicolons from #15425 because fat 2014-12-29 18:34:35 -08:00
Chris Rebert 27bfef5b35 Add regression test for #14244.
Special thanks to @programcsharp

[skip validator]
2014-12-29 16:09:37 -08:00
Chris Rebert 2ae4c0b03f JSCS: enable requireSpaceBetweenArguments
New rule added in JSCS v1.9.0
Our JS already complies with this.
2014-12-29 12:02:33 -08:00
Heinrich Fenkart 32f62bc565 Modal: Work around IE scrollbars not taking up page width
Fixes #15353.
2014-12-18 07:29:34 +01:00
Dan Dascalescu 2c64fc2c4d Fix copy/paste error 2014-11-28 04:30:04 -08:00
Chris Rebert bc5a753b67 fix affix-top unit test to properly clean up after itself 2014-11-20 23:26:37 -08:00
Nick O'Donoghue 36b4f90f25 Fixes affix-top class not applying
Use scrollTop instead of colliderTop which uses the elements
offset().top, as the offset top does not account for padding.

This issue can be replicated by using a navbar-fixed-top and applying
relevant padding to the body. (A navbar-static-top with no padding on
the body does not encounter this issue)

Fixes #15078
Closes #15154 by merging it
2014-11-17 18:17:42 -08:00
Nick O'Donoghue da79ab9488 add unit test for affix-top for padding issue 2014-11-17 18:17:40 -08:00
Chris Rebert b7398bc9c4 honor wrap option in Carousel.getItemForDirection; fixes #15144 2014-11-15 22:43:20 -08:00
Chris Rebert 8008fe707e add unit tests for Carousel's 'wrap' option 2014-11-15 22:37:55 -08:00
Heinrich Fenkart a577f1922e Collapse: Use $.fn.children instead of `>` in selector
Fixes #15131.
2014-11-14 15:18:34 +01:00
Mark Otto 9a7e365c2c bump version to v3.3.1 2014-11-12 09:03:16 -08:00
Heinrich Fenkart 1d55ada581 Dropdown: ignore keydown events coming from `input`s and `textarea`s
Fixes #15084.
2014-11-12 02:01:25 +01:00
Chris Rebert 21644321e4 Merge pull request #14993 from twbs/fix-14991
Have Carousel ignore keyboard events from <input>s or <textarea>s
2014-11-04 16:50:36 -08:00
Heinrich Fenkart da74fba490 Center modal dialog at all times 2014-11-05 01:37:44 +01:00
Chris Rebert 469dc3ab1f Have Carousel ignore keyboard events from <input>s or <textarea>s; fixes #14991 2014-11-04 16:23:44 -08:00
Heinrich Fenkart 425a985491 Update head of all visual tests to use our basic template 2014-11-05 01:18:11 +01:00
Heinrich Fenkart 14e5fb04e9 Fix modal backdrop overlaying the modal's scrollbar
Fixes #14916.
2014-11-04 23:17:55 +01:00
Chris Rebert 4102a67f33 fix typo in comment 2014-10-30 01:47:48 -07:00
Heinrich Fenkart cf482dbb0b Fix the iOS 8 unit test failures
Resolves #14919.
2014-10-30 09:35:53 +01:00
Heinrich Fenkart 5178d8b8ba Use RegExp for button plugin's focus shim
Fixes #14923.
2014-10-30 03:46:49 +01:00
Mark Otto 94b59b57d6 version bump 2014-10-29 08:56:20 -07:00
Ben-Russell 68b771a057 Independently delegate data-api selectors
Fixes #14462.
Closes #14463 by merging it.
2014-10-29 04:54:53 +01:00
Heinrich Fenkart ed3a65f084 Handle `collapsed` class on triggers even when manually invoked
Fixes #13636.
2014-10-29 04:34:05 +01:00
Heinrich Fenkart e851b8685a Merge pull request #14457 from hnrch02/button-set-val-after-event-loop
Change value of stateful button after event loop
2014-10-29 04:28:22 +01:00
Chris Rebert 22e1f94b52 Increase timeouts in tooltip unit tests to avoid spurious Sauce failures
Fixes #14851
2014-10-27 15:53:43 -07:00
Heinrich Fenkart 007fbdb66d Remove faulty unit test from 9740d8b
This would only work with transitions but since we disable them for unit tests, this delivers unreliably results.
2014-10-26 04:56:52 +01:00
Heinrich Fenkart 5da85f8e8b Follow-up to 9740d8b: fix small typo 2014-10-26 04:41:47 +01:00
Phil Hughes 9740d8bb69 Fix tooltip occasionally not hiding when using a hide delay
Fixes #14375.
Closes #14519 by merging it.
2014-10-26 04:38:18 +01:00
Andrew S. Brown 1b3237629a Allow multiple delegated tooltip selectors on a node
Fixes #14167.
Closes #14189 by merging it.
2014-10-26 03:51:55 +01:00
Heinrich Fenkart 0e991ccba2 Follow-up to e8af21c: rm unused variable in unit test 2014-10-26 03:16:05 +01:00
Tadeu Zagallo e8af21cc9d Clear scrollspy selection above first section
Closes #13563 by merging it.
2014-10-26 03:14:08 +01:00
Cameron Little 0755d529c6 Tabs plugin accessibility
Added support for `aria-expanded` toggling via JavaScript. Added
`aria-controls`, `aria-expanded`, `aria-labelledby` to tabs docs.

Added `aria-expanded` unit test for the tabs plugin.

See also #13554.

Closes #14154 by merging it.
2014-10-26 02:25:47 +01:00
Heinrich Fenkart c1f669e83b Revert "Scrollspy: ignore invisible list items" 2014-10-26 01:50:38 +02:00
Heinrich Fenkart fe51148434 Merge pull request #14669 from vsn4ik/dropdown_event_target
Use e.target instead :focus selector.
2014-10-23 06:13:46 +02:00
Heinrich Fenkart 3c98dd35ba Fix IE8 unit test breakage introduced by #14767 2014-10-22 22:09:58 +02:00
Phil Hughes ab8dbc214e Implement `hide` and `hidden` events for tabs
Closes #14772.
2014-10-22 21:42:35 +02:00
Heinrich Fenkart 95e0f48e3a Follow-up to e2cfbd5: Fix spaces in placement calculation 2014-10-22 21:38:34 +02:00
saranya.r e2cfbd5f2d Fixes tooltip misplacements in scrollable viewports with auto positioning
Fixes #14756.
Closes #14767.
2014-10-22 21:35:44 +02:00
Patrick H. Lauke e1d40f7633 Add `aria-pressed` to single toggle buttons
also includes tiny fix/clarification to two existing unit tests for the
.active class, adding data-toggle=“button” explicitly to the tested
buttons

Closes #14819.
2014-10-22 21:02:19 +02:00
Heinrich Fenkart e811a24118 Don't fire show event if show is prevented because other element is still transitioning
Fixes #14844.
Closes #14845.
2014-10-22 04:25:05 +02:00
fat 4bbe80658a fixes #13816 Modal dialog closes when dragging and releasing mouse button outside dialog 2014-10-09 20:01:51 -07:00
XhmikosR 909a178362 Change Twitter links to use `https`. 2014-10-07 15:28:41 +03:00
Heinrich Fenkart 61705d35fa Small clean-up in scrollspy unit test 2014-10-07 06:57:46 +02:00
Chris Rebert d361470487 tooltip unit tests: fix typo in test description 2014-10-03 16:26:53 -07:00
Maarten Van Hoof 44894a40e5 Add missing collapse JS files to dropdown visual test
Closes #14726.
2014-10-03 19:55:13 +02:00
Jacob 2c562d2386 Merge pull request #14590 from twbs/carousel-keyboard-option
Add `keyboard` option to carousel
2014-10-02 23:11:14 -07:00
Jacob 3fda099f5c Merge pull request #14722 from twbs/fat-14646
Escape key should only close Dropdown
2014-10-02 21:26:38 -07:00
fat e5fc22ccfa Escape key should only close Dropdown 2014-10-02 21:11:17 -07:00
Heinrich Fenkart 038a63b0eb Add `keyboard` option to carousel
Also adds unit tests for keyboard events.

Fixes #14468.
2014-10-03 05:16:31 +02:00
Jacob b702889613 Merge pull request #14626 from twbs/carousel-pause-hover-non-mobile
Only enable `pause: hover` for non-touch browsers
2014-10-02 20:09:20 -07:00
Chris Rebert 443a1b11ee tooltip.js: fix alignment 2014-09-24 21:27:56 -07:00
Chris Rebert 4d9890ea2e Use container instead of parent for tooltip/popover auto-placement calcs
Fixes #14561. Big thanks to @wickstargazer.

[skip validator]
2014-09-24 20:46:49 -07:00
Heinrich Fenkart 24ae068f21 Tooltip: Rely on `getBoundingClientRect` for `width` and `height`
Fixes #14553.
2014-09-25 01:35:51 +02:00
Heinrich Fenkart c37c1a6743 Only enable `pause: hover` for non-touch browsers
Fixes #11967.
2014-09-23 23:34:58 +02:00
vsn4ik bd66b12a94 Use e.target instead :focus selector. 2014-09-23 13:19:15 +04:00
Heinrich Fenkart acf3c0bf48 Merge pull request #14570 from twbs/remove-modal-open-after-backdrop-closed
Remove `.modal-open` class after backdrop is hidden
2014-09-22 21:44:39 +02:00
Chris Rebert 6f6466330d Make it easier to see failing tests in Sauce screencasts
...by hiding passing tests in the list of tests.
2014-09-17 18:33:39 -07:00
Heinrich Fenkart 3beeb32bb0 Follow-up to #14581: Use div instead of HTML5 section for IE8 2014-09-17 23:33:22 +02:00
saranya.r db9e8ee813 Fix tooltip misplacement with "auto top"
Fixes #14322.
Closes #14581.
2014-09-17 23:11:04 +02:00
Heinrich Fenkart c4f431d262 Remove `.modal-open` class after backdrop is hidden
Fixes #14274.
Fixes #14632.
2014-09-17 09:21:09 +02:00
Heinrich Fenkart 152d9dfe2e Merge pull request #14610 from twbs/axe-tooltip-validate
Remove unused Tooltip#validate method
2014-09-16 05:41:17 +02:00
Chris Rebert 73e3db0a2f Must explicitly destroy tooltip in SVG unit test since its container is body.
Leaking tooltips across tests leads to confusion and sadness.
2014-09-15 20:01:06 -07:00
Heinrich Fenkart e094d470d4 Remove unused Tooltip#validate method 2014-09-13 09:39:15 +02:00
Peter West 4c98507010 Correctly selects arrow placement for a tooltip
Fixes #13696.
Fixes #13696.
Fixes #14197.
Closes #13718.
2014-09-13 04:25:34 +02:00
Heinrich Fenkart 76762169c3 Properly fire hidden event when tooltip is destroyed
Fixes #13031.
2014-09-13 03:07:32 +02:00
Heinrich Fenkart a97db64881 Merge pull request #14569 from twbs/scrollspy-ignore-invisible-targets
Scrollspy: ignore invisible list items
2014-09-13 02:29:28 +02:00
Heinrich Fenkart 40f889df2a Merge pull request #14353 from hnrch02/collapse-count-collapsing-as-active
Collapse: count `.collapsing` elements as actives; closes #13447
2014-09-13 02:28:25 +02:00
Heinrich Fenkart 6e206f5e8f Merge pull request #14492 from twbs/ie8-getBoundingClientRect
Handle lack of .width and .height from getBoundingClientRect() in IE8
2014-09-11 23:11:45 +02:00
Heinrich Fenkart 759a95b0fe Make inDom check of tooltip cross document compatible
Fixes #14483
2014-09-09 03:03:14 +02:00
samme e29c75041e Make affix accept `0` as offsetTop or offsetBottom
Fixes #12815.
Closes #14363.
2014-09-09 01:32:42 +02:00
Heinrich Fenkart 9b9e2f5d13 grunt and missing new line 2014-09-09 01:23:48 +02:00
Patrick H. Lauke fb1ca10b99 ARIA support for collapse
Added handling of aria-expanded=true/false to collapse.js, updated
documentation to include advice on making expand/collapse controls
accessible, updated examples and javascript documentation to use
aria-expanded and aria-controls (when targetting single collapsible
element, using ID rather than class selector)

Closes #14147.
Closes #14153.
2014-09-09 01:19:20 +02:00
Heinrich Fenkart d15444d15e Scrollspy: ignore invisible list items
Fixes #13071
2014-09-09 00:18:18 +02:00
Heinrich Fenkart 859ddc11fb Merge pull request #14242 from hnrch02/remove-aria-describedby-later
Remove `aria-describedby` attribute later
2014-09-08 23:14:50 +02:00
Heinrich Fenkart e4b55ded5c Merge pull request #13928 from SGinTech/sgit_collapseEventOrder
Ensure that hidden event is sent when content is really hidden (collapsi...
2014-09-08 23:12:27 +02:00
Heinrich Fenkart 787404e090 Merge pull request #14287 from hnrch02/revert-13855-modal-mousedown
Revert #13855 due to #14263
2014-09-08 22:23:43 +02:00
Chris Rebert 7f56233862 Merge branch 'stefansundin/master' 2014-09-07 23:07:38 -07:00
Stefan Sundin f25181615e Fix bug not re-calculating scrollbar width when opening modal.
If opening a modal when a scrollbar is present, closing it, then
resizing the window so the scrollbar disappears, then opening the
modal again, the content would shift. This fixes the problem by
always calculating the scrollbar width every time a modal is opened.

Closes #14357.
2014-09-07 23:06:37 -07:00
Chris Rebert 989dafb153 Handle lack of .width and .height from getBoundingClientRect() in IE8
Closes #14093
Correction to #14090
Relevant docs: https://developer.mozilla.org/en-US/docs/Web/API/Element.getBoundingClientRect#Browser_compatibility
2014-09-07 22:58:33 -07:00
Jacob c22b270582 Merge pull request #14273 from sgonyea/master
Fix hover-popover/tooltip flickering when mouse re-enters
2014-09-07 10:36:45 -07:00
Scott Gonyea aac0e16452 Fix hover-tooltip flickering when mouse re-enters
- is(':visible') seems to be the only reliable check, without a refactoring of how hoverState is used
- tests need improvement
2014-08-28 17:17:50 -07:00
XhmikosR d869a5fb62 Update QUnit to v1.15.0. 2014-08-28 09:38:53 +03:00
Heinrich Fenkart c207b5b66b Change value of stateful button after event loop
Fixes #14450
2014-08-26 03:02:29 +02:00
Mark Otto 875006d08c Merge pull request #14417 from twbs/fat-14282
fixes #14282 - Already Visible collapse gets closed when …
2014-08-23 12:58:24 -07:00
Chris Rebert 9efedf8f7b Merge pull request #14406 from twbs/nav-tag-for-navbar
consistently use <nav> instead of <div> for .navbar in docs
2014-08-20 21:48:59 -07:00
Jacob c95aa97c03 Merge pull request #14244 from programcsharp/master
Remove popover content with .children().detach() instead of .empty()
2014-08-18 20:06:02 -07:00
fat 9c2e54bfec fixes #14282 - Already Visible collapse gets closed when .collapse('show') is called 2014-08-18 19:58:19 -07:00
Chris Rebert ea0e1606dc Assume Element.getBoundingClientRect() exists; Fixes #14093
[skip validator]
2014-08-17 16:08:49 -07:00
Chris Rebert 6b7142212f consistently use <nav> instead of <div> for .navbar in docs 2014-08-15 18:09:05 -07:00
Heinrich Fenkart 436015c191 Collapse: count `.collapsing` elements as actives; closes #13447 2014-08-08 01:23:50 +02:00
Heinrich Fenkart 75bffd84ae Use closest `.alert` for alert dismissal; closes #14306 2014-08-04 19:33:42 +02:00
Heinrich Fenkart dca8afa333 Remove `aria-describedby` attribute later
Fixes #14241
2014-08-04 19:21:49 +02:00
Jacob 8bf48121a0 Merge pull request #14061 from hnrch02/fix-13656
Expose transition durations on plugin constructors; closes #13656
2014-08-01 12:50:03 -07:00
Chris Rebert 08393bf68a Fix #14076: Add unit test for tooltips on SVG elements
[skip validator]
2014-08-01 12:10:00 -07:00
Chris Rebert cbba8e53df Fix #13818 by using more robust "find next carousel item" logic
Also adds another test for #9461: carousel next/prev should ignore non-items
2014-07-31 11:36:24 -07:00
Heinrich Fenkart 18c0a1c977 Revert "Use mousedown instead of click for backdrop click detection; fixes #13816" 2014-07-30 23:54:25 +02:00
Chris Hynes 531fc80885 Use .end() to remove extra line 2014-07-25 11:10:46 -07:00
Chris Rebert c2f4e5fef1 re-alphabetize .jscsrc 2014-07-25 11:02:30 -07:00
Chris Hynes 519a087dbe Remove popover content with .children().detach() instead of .empty() so it can be reused 2014-07-25 10:16:44 -07:00
Artem Belov 098242afd8 Delete duplicate JSCS properties 2014-07-25 15:03:07 +04:00
Jacob 36483af92c Merge pull request #14207 from twbs/charlesbjohnson-affix-bottom-when-dynamic-height
Charlesbjohnson affix bottom when dynamic height
2014-07-21 22:48:38 -07:00
fat 4775c9296a Merge branch 'dropdown-aria' of git://github.com/mckramer/bootstrap into mckramer-dropdown-aria
Conflicts:
	docs/_includes/js/dropdowns.html
2014-07-21 22:44:35 -07:00
fat eff9b063da cleanup style 2014-07-21 22:37:04 -07:00
Charles B Johnson 724c4f526c Fix issue where bottom affixed element floats over the footer when the
document height is smaller than the viewport height.
2014-07-18 10:46:42 -04:00
Charles B Johnson 8c0eb9b00e Refactor determining affix state into a separate expanded method
in order to handle multiple edge cases, specifically when the document
  height is dynamic.
Always reposition an affix that is affixed to the bottom.
2014-07-18 10:45:59 -04:00
Charles B Johnson d3dea01a11 Add a bottom affixed element to affix visual tests. 2014-07-18 10:45:59 -04:00
Jacob 866ffc4f37 Merge pull request #14055 from twbs/fat-speed-up-tests
speed up js tests a bit
2014-07-17 10:07:28 -07:00
fat 9b90b87099 speed up js tests a bit 2014-07-16 22:22:42 -07:00
Heinrich Fenkart cc7fab893d Follow-up to #13907: simplify JS logic for focus shim 2014-07-16 08:44:56 +02:00
Heinrich Fenkart 1719d2b051 `document.head` is undefined in IE8 2014-07-09 00:42:02 +02:00
Heinrich Fenkart 0268b41c4f Fix IE8 reporting type object for `getBoundingClientRect` 2014-07-09 00:42:02 +02:00
Heinrich Fenkart 05ddea314c Fix IE8 reporting height style as all uppercase 2014-07-09 00:42:02 +02:00
Chris Rebert 21571b3412 Fix invalid HTML in "should allow html entities" tooltip unit test
Refs #14090.
Also, fix one typo.
2014-07-08 14:40:20 -07:00
Heinrich Fenkart 231744d628 Expose transition durations on plugin constructors; closes #13656 2014-07-07 13:03:56 +02:00
Mark Otto 907b3b2892 Merge pull request #13907 from twbs/fat-12145
add "focus" to focused btns with button plugin
2014-07-07 00:36:59 -07:00
fat 587c09cb48 fix scrollspy test in firefox mac os 2014-07-06 21:50:46 -07:00
Jacob b5d86ad0bd Merge pull request #13853 from hnrch02/unit-tests-cleanup
Major unit tests cleanup
2014-07-06 21:43:48 -07:00
Mark Otto 44f83fff90 Merge pull request #14021 from CFXd/add_collapsed_default_class_to_navbar_collapse_button
Add collapsed default class to navbar-toggle
2014-07-06 16:37:42 -07:00
Mark Otto ac18e5811d jscs fix 2014-07-06 15:08:33 -07:00
fat cb19f4f227 Merge branch 'breaddevil-replace-scrollspy-default-behavior-test' 2014-07-06 14:11:38 -07:00
fat b19719ea1a Merge branch 'replace-scrollspy-default-behavior-test' of git://github.com/breaddevil/bootstrap into breaddevil-replace-scrollspy-default-behavior-test
Conflicts:
	js/tests/unit/scrollspy.js
2014-07-06 14:11:23 -07:00
Jacob 279c46152b Merge pull request #13815 from hnrch02/tabs-fade-not-active
Allow tabs to fade in if no initially active pane is present
2014-07-06 13:50:54 -07:00
Heinrich Fenkart 58eb8b2ae3 Move to leading pluses 2014-07-06 11:56:12 +02:00
Chris Rebert a34e52de4d Merge pull request #14015 from twbs/possible-14013-fix
Possible fix for #14013
2014-07-06 00:36:52 -07:00
Heinrich Fenkart dad56be96c Move to 16ms from 18ms based on the Paul Irish's rAF polyfill 2014-07-06 09:24:23 +02:00
Heinrich Fenkart 8ff099585f Mention #13500 in comment for ScrollSpy test 2014-07-06 09:24:23 +02:00
Heinrich Fenkart e341355d28 Clean tooltip unit tests up 2014-07-06 09:24:23 +02:00
Heinrich Fenkart b3a125e941 Clean tab unit tests up 2014-07-06 09:24:23 +02:00
Heinrich Fenkart 05ba1e491e Clean scrollspy unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 56b8d5fe6e Clean popover unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 998c3724e8 Clean modal unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 9ff66a12bc Clean dropdown unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 77d0557468 Clean collapse unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 6a523bf99d Clean carousel unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart f3345f68d7 Clean button unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart b063de54a5 Clean alert unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 95d7c9c3fb Clean affix unit tests up 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 4950fe6f4e Perform a cleanup after each test 2014-07-06 09:24:22 +02:00
Heinrich Fenkart 1e64c4c0ba Update QUnit settings/QUnit phantomjs bridge to new versions 2014-07-06 09:24:22 +02:00
Chris Rebert f9ffb49932 refactor/reformat Tooltip.getPosition per @fat's feedback 2014-07-06 00:16:54 -07:00
Jacob 5830febd9a Merge pull request #13855 from hnrch02/modal-mousedown
Use mousedown instead of click for backdrop click detection; fixes #13816
2014-07-06 00:01:57 -07:00
Jacob 13a4c50cc7 Merge pull request #14000 from hnrch02/modal-keydown
Only close modal if escape was hit with keydown; fixes #13929
2014-07-05 23:55:36 -07:00
fat c08e275000 fix build 2014-07-05 23:49:45 -07:00
fat 22f851fa62 apply #14022 without semicolon – cleans up some jquery class usage 2014-07-05 23:28:44 -07:00
Wing 4b08832308 no need to create $.Event
`trigger()` can handle string argument
2014-07-03 10:52:22 -07:00
Wing 48b822db40 trigger 'affixed.bs.affix' instead of 'affixed'
Original is triggering `affixed` not `affixed.bs.affix`, only `.on('affixed.bs.affix', ...)` also catch `affixed` event.

Closes #13998.
2014-07-03 10:52:22 -07:00
Michael Silber 1e407c81f1 Add collapsed default class to navbar-toggle 2014-07-02 16:49:03 -04:00
Chris Rebert 1ce5e9f3ae possible fix for #14013 2014-07-02 10:09:28 -07:00