Commit Graph

819 Commits

Author SHA1 Message Date
Patrick H. Lauke 836a4c0bd6
Remove redundant visually hidden "(current)" from pagination controls (#31892)
* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891
2020-10-14 11:59:43 +01:00
XhmikosR 0c1651ee9d
Remove `Manipulator.toggleClass` (#31842)
It's only used in one place so it makes more sense to remove it for the time being.
2020-10-05 18:07:49 +03:00
Hiws 43b4252a34
fix tooltip hide method when already hidden (#31115)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-09-24 14:55:38 +03:00
Rohit Sharma f6348f6c89
Clear timeout before showing the toast (#31155)
* clear timeout before showing the toast

* Add unit test

* Remove the check for timeout

* Check for clearTimeout to have been called

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-07-11 11:51:04 -07:00
XhmikosR bd72dfc41d
Update to `@rollup/plugin-node-resolve` v8.1.0. (#31249) 2020-07-07 10:23:11 +03:00
Patrick H. Lauke 10690dd317
Rename `sr-only`/`sr-only-focusable` (#31139)
* Rename `sr-only`/`sr-only-focusable`

To be more representative of the fact that these are not necessarily "screen reader" specific, but actually apply to assistive technologies in general (and also things like Alexa/Siri/etc). Goes hand-in-hand with #31133

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-07-03 14:38:11 +03:00
XhmikosR 786208ea15
BrowserStack: stop testing on latest Edge. (#31125)
It's Chromium-based so it seems redundant.
2020-06-25 11:42:55 +03:00
Shohei Yoshida fb4efb49ea
Prevent overflowing static backdrop modal animation (#30326)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-06-25 11:35:53 +03:00
Patrick H. Lauke edbcc401c2
Change whitelist to allowlist (#31066)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markd.otto@gmail.com>
2020-06-19 11:31:37 +03:00
Tanguy Krotoff d80a9fc553
Fix tooltip when hovering a children element (delegateTarget) (#30928)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
2020-06-18 10:02:44 +03:00
Johann-S 088c727a31 data: reword storage key in dom 2020-06-17 15:45:36 +02:00
XhmikosR c28934cb18
Rename "master" to "main". (#31050) 2020-06-16 21:41:47 +03:00
XhmikosR 3b66bbeddc
Fix a broken link and a redirect. (#31045) 2020-06-16 19:32:00 +03:00
Martijn Cuppens 1a0a0858ef Remove checkbox/radio toggle from button plugin in favor of a CSS only solution 2020-06-15 19:04:19 -07:00
Rohit Sharma e140ff92ed Remove .nav-item from .nav-link to make it consistent
- Closes #28423
2020-06-09 07:48:58 +03:00
Rohit Sharma 5faf41eb48
Add role="dialog" in modals via JavaScript (#30936) 2020-06-04 10:35:09 +03:00
XhmikosR 340236cbe4
Update to `@rollup/plugin-babel` (#30742) 2020-05-26 06:14:12 +03:00
Mark Otto d2f07ec9e1 Fix some easy Markdown linting issues
- Always use dashes for bullets
- Add some basic alt text for our readme OC sponsors
2020-05-18 16:28:22 +03:00
XhmikosR fbdacc0e92 coverage: ignore node_modules 2020-05-12 08:31:38 +03:00
Dominik Kremer d59de33fc0 Add a test about the scrollbar issue on non-integer width 2020-05-12 07:51:09 +03:00
XhmikosR 94109cabf4
Add missing closing `div` tags (#30775)
Missed those in 967e607
2020-05-11 16:54:56 +03:00
Rohit Sharma ec3cfae29c
Removed role="document" from the modal dialog (#30755) 2020-05-11 12:45:42 +03:00
XhmikosR 967e6071ba
tests: streamline HTML end tags (#30648) 2020-05-06 09:20:08 +03:00
Johann-S 650a7a7b76 add unit tests to ensure our plugins works in jquery 2020-05-06 07:55:48 +02:00
XhmikosR 122c99ebeb
BrowserStack: test Edge 16 too (#30725) 2020-05-05 22:10:16 +03:00
XhmikosR 345fd1fe4c Revert "Update karma.conf.js"
This reverts commit b8abded0af.
2020-05-05 17:34:48 +03:00
XhmikosR db80eb96fa
Move babel whitelist helpers to a common file (#30723) 2020-05-04 20:08:28 +03:00
XhmikosR b8abded0af Update karma.conf.js
Use the recommended karma-browserstack-launcher settings
2020-05-04 20:01:29 +03:00
XhmikosR 37f2c04c5f
Clean up lint rules (#30721)
* Remove unneeded rule suppression
* Format tests/unit/.eslintrc.json
* build/.eslintrc.json: add strict for consistency
2020-05-04 19:32:09 +03:00
Tanguy Krotoff d2ed920b15
Remove caret element (#30633) 2020-04-24 21:53:31 +02:00
Tanguy Krotoff 7787f642b9 Fix crash when pressing ArrowUp the first time 2020-04-17 18:22:15 +03:00
Tanguy Krotoff dcd99aa7d1 Replace event.which with event.key and event.button 2020-04-17 18:22:15 +03:00
ysds dfa017adc3 Always modal scroll top to 0 2020-04-01 10:05:43 +03:00
Martijn Cuppens c48d89cb70 Use unordered lists in dropdown-menus 2020-03-31 22:52:57 +02:00
XhmikosR e1f5d819c7
Remove `MSPointerEvent` and `ms-touch-action` in tests (#30463) 2020-03-29 09:59:54 +03:00
XhmikosR ed94976ea8
Use `textContent` instead of `innerText`. (#30462)
It's supported by all of our supported browsers.
2020-03-29 09:53:57 +03:00
XhmikosR f761d8e801
Remove holder.js leftovers (#30469) 2020-03-28 12:07:14 +02:00
Laussel Loïc 7ce29d75f3
v5 tabs - accessibility issue when using ul/li semantic
Add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc
2020-03-28 09:51:24 +02:00
Johann-S fe492d8021 fix babel config in our files 2020-03-25 22:32:37 +02:00
Johann-S 26d86fce2a
fix: remove make array util function (#30430) 2020-03-25 16:35:02 +02:00
Martijn Cuppens 2e150e722a Use next dropdown menu instead of first of the parent 2020-03-23 15:35:07 +01:00
XhmikosR 018a94c9c1 Remove Internet Explorer leftovers 2020-03-18 20:59:27 +02:00
Johann-S 47aef7b2c6 Remove IE compatibility JS code 2020-03-18 20:59:27 +02:00
Johann-S aff115219e
fix: ensure `totype` always returns stringified null/undefined when null/undefined is passed (#30383) 2020-03-18 13:10:55 +02:00
Martijn Cuppens 7d8c7c4ba8
`prev()` function fails when non-element nodes are present (#30117)
The `prev()` function doesn't take nodes other than elements into account. Also we could simplify things a lot using the `previousElementSibling` property. This property isn't fully supported in IE, it only works for elements, but since the `element` variable is an element, we can safely use it here.

I've also added an additional test.

I don't think we had this issue in v4, since we relied on jQuery back then.

Ref. https://developer.mozilla.org/en-US/docs/Web/API/NonDocumentTypeChildNode/nextElementSibling
2020-03-09 17:21:04 +02:00
yonikohen 7a60dcf9b0 Corrected grammatical error in test descriptions (#30150)
"without instantiate it" should be "without instantiating it"
2020-02-10 09:35:13 +02:00
Martijn Cuppens ef6c13c534
tests: Remove button `href`s (#30119) 2020-02-01 20:39:18 +02:00
Giovanni Mendoza 954a0b1e6a Close modal with keyboard=true & backdrop=static (#29986)
* Close modal with keyboard=true & backdrop=static
2020-01-10 11:06:12 +02:00
XhmikosR 8f1c4b9a03
Switch to @rollup/plugin-commonjs (#29907) 2019-12-25 21:43:56 +02:00
XhmikosR f153748f52
Switch to @rollup/plugin-node-resolve (#29851) 2019-12-25 21:36:22 +02:00