Commit Graph

849 Commits

Author SHA1 Message Date
XhmikosR 94109cabf4
Add missing closing `div` tags (#30775)
Missed those in 967e607
2020-05-11 16:54:56 +03:00
Rohit Sharma ec3cfae29c
Removed role="document" from the modal dialog (#30755) 2020-05-11 12:45:42 +03:00
XhmikosR 967e6071ba
tests: streamline HTML end tags (#30648) 2020-05-06 09:20:08 +03:00
Johann-S 650a7a7b76 add unit tests to ensure our plugins works in jquery 2020-05-06 07:55:48 +02:00
XhmikosR 122c99ebeb
BrowserStack: test Edge 16 too (#30725) 2020-05-05 22:10:16 +03:00
XhmikosR 345fd1fe4c Revert "Update karma.conf.js"
This reverts commit b8abded0af.
2020-05-05 17:34:48 +03:00
XhmikosR db80eb96fa
Move babel whitelist helpers to a common file (#30723) 2020-05-04 20:08:28 +03:00
XhmikosR b8abded0af Update karma.conf.js
Use the recommended karma-browserstack-launcher settings
2020-05-04 20:01:29 +03:00
XhmikosR 37f2c04c5f
Clean up lint rules (#30721)
* Remove unneeded rule suppression
* Format tests/unit/.eslintrc.json
* build/.eslintrc.json: add strict for consistency
2020-05-04 19:32:09 +03:00
Tanguy Krotoff d2ed920b15
Remove caret element (#30633) 2020-04-24 21:53:31 +02:00
Tanguy Krotoff 7787f642b9 Fix crash when pressing ArrowUp the first time 2020-04-17 18:22:15 +03:00
Tanguy Krotoff dcd99aa7d1 Replace event.which with event.key and event.button 2020-04-17 18:22:15 +03:00
ysds dfa017adc3 Always modal scroll top to 0 2020-04-01 10:05:43 +03:00
Martijn Cuppens c48d89cb70 Use unordered lists in dropdown-menus 2020-03-31 22:52:57 +02:00
XhmikosR e1f5d819c7
Remove `MSPointerEvent` and `ms-touch-action` in tests (#30463) 2020-03-29 09:59:54 +03:00
XhmikosR ed94976ea8
Use `textContent` instead of `innerText`. (#30462)
It's supported by all of our supported browsers.
2020-03-29 09:53:57 +03:00
XhmikosR f761d8e801
Remove holder.js leftovers (#30469) 2020-03-28 12:07:14 +02:00
Laussel Loïc 7ce29d75f3
v5 tabs - accessibility issue when using ul/li semantic
Add aria-role presentation on li element when ul element has role tablist and remove dropdown from visual tests as they've been removed from doc
2020-03-28 09:51:24 +02:00
Johann-S fe492d8021 fix babel config in our files 2020-03-25 22:32:37 +02:00
Johann-S 26d86fce2a
fix: remove make array util function (#30430) 2020-03-25 16:35:02 +02:00
Martijn Cuppens 2e150e722a Use next dropdown menu instead of first of the parent 2020-03-23 15:35:07 +01:00
XhmikosR 018a94c9c1 Remove Internet Explorer leftovers 2020-03-18 20:59:27 +02:00
Johann-S 47aef7b2c6 Remove IE compatibility JS code 2020-03-18 20:59:27 +02:00
Johann-S aff115219e
fix: ensure `totype` always returns stringified null/undefined when null/undefined is passed (#30383) 2020-03-18 13:10:55 +02:00
Martijn Cuppens 7d8c7c4ba8
`prev()` function fails when non-element nodes are present (#30117)
The `prev()` function doesn't take nodes other than elements into account. Also we could simplify things a lot using the `previousElementSibling` property. This property isn't fully supported in IE, it only works for elements, but since the `element` variable is an element, we can safely use it here.

I've also added an additional test.

I don't think we had this issue in v4, since we relied on jQuery back then.

Ref. https://developer.mozilla.org/en-US/docs/Web/API/NonDocumentTypeChildNode/nextElementSibling
2020-03-09 17:21:04 +02:00
yonikohen 7a60dcf9b0 Corrected grammatical error in test descriptions (#30150)
"without instantiate it" should be "without instantiating it"
2020-02-10 09:35:13 +02:00
Martijn Cuppens ef6c13c534
tests: Remove button `href`s (#30119) 2020-02-01 20:39:18 +02:00
Giovanni Mendoza 954a0b1e6a Close modal with keyboard=true & backdrop=static (#29986)
* Close modal with keyboard=true & backdrop=static
2020-01-10 11:06:12 +02:00
XhmikosR 8f1c4b9a03
Switch to @rollup/plugin-commonjs (#29907) 2019-12-25 21:43:56 +02:00
XhmikosR f153748f52
Switch to @rollup/plugin-node-resolve (#29851) 2019-12-25 21:36:22 +02:00
Steffen Roßkamp c62efc3ef6 Update normalizeDataKey to match the spec (#29609) 2019-10-31 07:58:09 +02:00
Higor Araújo dos Anjos 46912797b2 Added animation when modal backdrop is static (#29516) 2019-10-25 21:12:09 +03:00
Jeremy Jackson c1ee395f80 Skip hidden dropdowns while focusing (#29523) 2019-10-17 18:01:44 +03:00
XhmikosR 577bf8b14d
Rename "js/tests/units" to "js/tests/unit". (#29503) 2019-10-09 01:27:43 +03:00
Johann-S e1b82f51e2 add modularity integration test 2019-10-03 09:55:57 +02:00
Johann-S 3d12b541c4 return to the original file structure to avoid breaking modularity 2019-10-03 09:55:57 +02:00
XhmikosR d06eec372a
Minor lint tweaks. (#29328) 2019-08-29 16:20:49 +03:00
Johann-S dcba526775 remove underscore for static methods 2019-07-29 11:34:12 +02:00
Johann-S e101ba4989 add polyfill.js in visual tests (#29116) 2019-07-24 08:19:47 +03:00
Johann-S 233f3fb1ce rewrite tab unit tests 2019-07-23 14:23:50 +02:00
Johann-S e1b5d8471a use qunit css for our fixture 2019-07-23 14:23:50 +02:00
Johann-S b7b56cb10a rewrite scrollspy unit tests 2019-07-23 14:23:50 +02:00
Johann-S 85b70cef3c rewrite tooltip unit tests 2019-07-23 14:23:50 +02:00
Johann-S c9e650a56f rewrite popover unit tests 2019-07-23 14:23:50 +02:00
Johann-S 1ac07a66ce rewrite modal unit tests 2019-07-23 14:23:50 +02:00
Anton Bershanskiy e916a9bc03 rewrite toast unit tests 2019-07-23 14:23:50 +02:00
Johann-S 6a59c58480 rewrite dropdown unit tests 2019-07-23 14:23:50 +02:00
Johann-S 0ed1618c06 rewrite collapse unit tests 2019-07-23 14:23:50 +02:00
Johann-S 62730d9afd rewrite carousel unit tests 2019-07-23 14:23:50 +02:00
Johann-S 891a187059 rewrite button unit tests 2019-07-23 14:23:50 +02:00
Johann-S c834895fa0 rewrite unit tests for selector engine 2019-07-23 14:23:50 +02:00
Anton Bershanskiy fe6ba2384a rewrite manipulator unit tests 2019-07-23 14:23:50 +02:00
Johann-S c8c2074650 Switch from QUnit to Jasmine. 2019-07-23 14:23:50 +02:00
Kitten King 37703a6fc9 Fix Typos across Bootstrap repository (#29082) 2019-07-20 12:53:02 +03:00
Johann-S 18077460aa updated babel 2019-07-17 15:03:32 +03:00
Patrick H. Lauke cc49977038 Fix dropdown unit test (#29037)
swap jQuery's `trigger(...)` with the more verbose native `dispatchEvent(...)`, as the former may not always behave/bubble correctly (observed while trying to write unit tests for keyboard handling of ARIA tab navigation), which may lead to this test passing even though it fails in real usage.
2019-07-14 12:24:27 +03:00
Patrick H. Lauke f2c63ac729 Port new unit test for dropdown from v4 (#28913)
Add unit test from #28912 to v5
2019-06-25 14:57:41 +03:00
Patrick H. Lauke f0f75379f6 Closing dropdown with ESC correctly sets focus to toggle (#28928)
Just firing the focus event isn't enough ... need to actually call the proper `focus()` method for it to actually do it...
2019-06-19 12:23:41 +03:00
Johann-S d5752a18ab toast should allow prevent default for hide and show events 2019-05-16 13:24:29 +02:00
Martijn Cuppens a827934f13 Documentation tweaks (#28679)
* Documentation tweaks

* Remove redundant col-12 classes
2019-05-08 19:58:29 +03:00
XhmikosR 438e01b61c Rename `eventHandler` and `selectorEngine` files. 2019-05-08 17:26:37 +03:00
Johann-S dda31bbee6 improve build plugin script to keep file name 2019-05-08 17:26:37 +03:00
XhmikosR e7657c8bc0 Remove the `unicorn/filename-case` rule suppression. 2019-05-08 17:26:37 +03:00
Johann-S 14f53d9baa fix unit tests for chrome mobile 2019-04-15 13:48:27 +02:00
XhmikosR 105687ac4a Update eslint config for the new xo rules. 2019-04-10 15:18:57 +03:00
XhmikosR efb9a7749f
karma.conf.js: switch to `CI === true`. (#28588) 2019-04-01 17:26:43 +03:00
Johann-S 1752addadf Reset carousel touch delta x to prevent click transformation in swipe (#28558) 2019-03-27 14:37:04 +02:00
Johann-S ad0f5f153c fix remove files in our visual tests 2019-03-18 01:11:05 +02:00
Johann-S 08679ac0b5 Add back support for IE 11 2019-03-18 01:11:05 +02:00
XhmikosR 6aa475c82e
Use one-line imports when possible. (#28467) 2019-03-13 14:55:53 +02:00
Johann-S 2fd50f98a5 build bootstrap in esm 2019-03-11 17:59:08 +02:00
XhmikosR 5bcd6a29cd Disable a few rules for now. 2019-03-11 17:01:28 +02:00
XhmikosR 46c037410b Comply to the new rules. 2019-03-11 17:01:28 +02:00
XhmikosR 44e6abcba5 Switch to eslint-config-xo and eslint-plugin-unicorn. 2019-03-11 17:01:28 +02:00
XhmikosR d5f9107abb
Remove the now unneeded `shrink-to-fit` directive. (#28314) 2019-02-27 17:47:41 +02:00
XhmikosR 9cbd041f6b
tests: add tests for plugins version. (#28366) 2019-02-27 13:20:25 +02:00
XhmikosR 7933ee3282 karma.conf.js: minor simplification. 2019-02-26 13:04:04 +02:00
Johann-S 497518db1a remove tests for old jQuery 1.9.x compatibility 2019-02-26 13:04:04 +02:00
Johann-S 8a37045b79 move util in a util folder with the sanitizer 2019-02-26 13:04:04 +02:00
XhmikosR 5ad2121819
Remove DOMContentLoaded. (#28337)
There's no reason for us to wait here.
2019-02-24 15:42:18 +02:00
XhmikosR 423e4a3811 tests/visual/modal.html: fix close button placement. 2019-02-20 22:05:45 +02:00
Johann-S 764bab2941 remove polyfills which override browsers default 2019-02-20 22:05:45 +02:00
XhmikosR f0c6b24bd7 4.3.1. 2019-02-20 22:05:45 +02:00
Joshua Wilson fdbb5db919 minor jQuery.hasclass removal (#28158) 2019-02-20 22:05:45 +02:00
Peter Blazejewicz cbd333185e Use consistent arrow class (#28105) 2019-02-20 22:05:45 +02:00
Johann-S c096e0e0da bump to 4.2.1 2019-02-20 22:05:45 +02:00
Johann-S 661db08eeb rewrite toast plugin without jquery 2019-02-20 22:05:45 +02:00
Johann-S 57d50b2134 Improve manipulator coverage 2019-02-20 22:05:45 +02:00
Alessandro Chitolina 6cfc78f2d9 Remove IE support and button bsChecked hack 2019-02-20 22:05:45 +02:00
Johann-S a2f1d79045 Refactor util plugin and some tests 2019-02-20 22:05:45 +02:00
Johann-S c44db783bf chore(update): bump to 4.1.3 2019-02-20 22:05:45 +02:00
Johann-S 5dcca44fcf fix(visual-test): remove jquery in them 2019-02-20 22:05:45 +02:00
Johann-S 6b0808354d fix(unit-test): dropdown, collapse and carousel 2019-02-20 22:05:45 +02:00
Johann-S a1cc9a6e33 fix(util): increase util coverage 2019-02-20 22:05:45 +02:00
Johann-S 096413a994 fix(selector-engine): increase coverage for selector engine 2019-02-20 22:05:45 +02:00
Johann-S 64591b3722 fix(manipulator): increase coverage for manipulator 2019-02-20 22:05:45 +02:00
Johann-S 4d6e41dea6 refactor(polyfill): a file for polyfills 2019-02-20 22:05:45 +02:00
Johann-S 0b719e065c fix(data): increase coverage for data 2019-02-20 22:05:45 +02:00
Johann-S 9313446274 fix(event-handler): remove the use of our event handler in unit test 2019-02-20 22:05:45 +02:00
Johann-S 2b78078779 fix(data): do not use data object in our unit tests 2019-02-20 22:05:45 +02:00