root
/
buildah
mirror of https://github.com/containers/buildah.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

tests: add quotes to names 

In podman we also run the bud tests, there I noticed a issue with the
podman skip logic as it was unable to fine the build-add-https-retry-ca
test name as it always expects quotes[1]

In general names should be human readable so add quotes and use spaces
over a dash as word separator.

[1] https://github.com/containers/podman/pull/24135

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This commit is contained in:
Paul Holzinger 2024-10-02 14:57:38 +02:00
parent a518f88139
commit c7dd90dd7b
No known key found for this signature in database
GPG Key ID: EB145DD938A3CAF2
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/add.bats
View File

@ -307,7 +307,7 @@ stuff/mystuff"
expect_output --substring "checksum flag is not supported for local sources" expect_output --substring "checksum flag is not supported for local sources"
} }
@test add-https-retry-ca { @test "add https retry ca" {
createrandom ${TEST_SCRATCH_DIR}/randomfile createrandom ${TEST_SCRATCH_DIR}/randomfile
mkdir -p ${TEST_SCRATCH_DIR}/private mkdir -p ${TEST_SCRATCH_DIR}/private
starthttpd ${TEST_SCRATCH_DIR} "" ${TEST_SCRATCH_DIR}/localhost.crt ${TEST_SCRATCH_DIR}/private/localhost.key starthttpd ${TEST_SCRATCH_DIR} "" ${TEST_SCRATCH_DIR}/localhost.crt ${TEST_SCRATCH_DIR}/private/localhost.key

2
tests/bud.bats
View File

@ -6905,7 +6905,7 @@ _EOF
expect_output --substring "\-\-platform=$platform" expect_output --substring "\-\-platform=$platform"
} }
@test build-add-https-retry-ca { @test "build add https retry ca" {
createrandom ${TEST_SCRATCH_DIR}/randomfile createrandom ${TEST_SCRATCH_DIR}/randomfile
mkdir -p ${TEST_SCRATCH_DIR}/private mkdir -p ${TEST_SCRATCH_DIR}/private
starthttpd ${TEST_SCRATCH_DIR} "" ${TEST_SCRATCH_DIR}/localhost.crt ${TEST_SCRATCH_DIR}/private/localhost.key starthttpd ${TEST_SCRATCH_DIR} "" ${TEST_SCRATCH_DIR}/localhost.crt ${TEST_SCRATCH_DIR}/private/localhost.key

2
tests/chroot.bats
View File

@ -2,7 +2,7 @@
load helpers load helpers
@test chroot-mount-flags { @test "chroot mount flags" {
skip_if_no_unshare skip_if_no_unshare
if ! test -e /etc/subuid ; then if ! test -e /etc/subuid ; then
skip "we can't bind mount over /etc/subuid during the test if there is no /etc/subuid file" skip "we can't bind mount over /etc/subuid during the test if there is no /etc/subuid file"