Commit Graph

2 Commits

Author SHA1 Message Date
TomSweeneyRedHat ed0a329d9e Handle missing equal sign in --from and --chown flags for COPY/ADD
When buildah bud runs without layers (default), it hands off the parsing
of the Dockerfile steps to imagebuilder.  However if the the --layers
option is in use, then we start parsing the steps before we hand stuff
off to imagebuilder.

The COPY --chown, ADD --chown, and COPY --from commands in a Dockerfile
were failing if there was not an '=' sign after them like "COPY --chown=2374:3256".
This moves the parsing into the code that handles the layer processing.

Fixes: #1984

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>

Closes: #1997
Approved by: vrothberg
2019-12-03 09:44:46 +00:00
Daniel J Walsh 3a6942ec9e Add support for ADD --chown
Currently buildah support COPY --chown in a Dockerfile build,
but it ignores this flag if it is passed into an ADD.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #1288
Approved by: vrothberg
2019-01-18 13:41:44 +00:00