Newer golangci-lint does not understand the nolint: directive
because it is followed by some comment.
To fix, add a comment before the (human) comment.
While at it, remove the space after // since comments targeted for
non-humans should not have space (this is currently not enforced by
golangci-lint).
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Expand the list of OS/arch combinations we check when we're checking if
we can successfully be cross-compiled, and fix up a couple of places
that wouldn't pass otherwise.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
When we go to unmount a tree of mounts, if one of the directories isn't
there, instead of returning an error as before, log a debug message and
keep going.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #1996
Approved by: rhatdan
Make the chroot() call before applying a seccomp filter, which might not
allow us to do it. Add more debugging messages.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #979
Approved by: rhatdan
In bind/mount_unsupported.go, only one import is needed. The current version
causes compilation errors when building for darwin.
../src/github.com/projectatomic/libpod/vendor/github.com/projectatomic/buildah/bind/mount_unsupported.go:6:2: imported and not used: "fmt"
../src/github.com/projectatomic/libpod/vendor/github.com/projectatomic/buildah/bind/mount_unsupported.go:7:2: imported and not used: "os"
../src/github.com/projectatomic/libpod/vendor/github.com/projectatomic/buildah/bind/mount_unsupported.go:8:2: imported and not used: "path/filepath"
...
Signed-off-by: baude <bbaude@redhat.com>
Factor out logic for unmounting our bind mounts, and make use of the
parent/child relationship between mountpoints to decide which order to
use, rather than sorting based on their mountpoint paths.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #800
Approved by: rhatdan
Break runSetupIntermediateMountNamespace() into its own package.
Move stringInSlice(), getHostIDs(), and getHostRootIDs() into the util
subdirectory and export them.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Closes: #796
Approved by: rhatdan
Kir Kolyshkin
Nalin Dahyabhai
Valentin Rothberg
Daniel J Walsh
baude