buildtags mentioned as $(hack/foobar.sh) need double quotes to get
correctly read.
Fixes: #4944
[NO NEW TESTS NEEDED]
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
`fedora-all` doesn't include eln targets. We need to add them
explicitly.
[NO NEW TESTS NEEDED]
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
Building all PRs of all container projects into the same COPR does not
properly isolate PRs from each other: E.g. a podman PR currently runs
against whichever buildah PR was opened/updated last; in other
words, sending a broken buildah PR will instantly break tests for
all subsequent podman runs.
To avoid that, change the copr_build configuration to use the packit
default COPRs, which are specific to the particular PR, and disappear
after a few weeks. Depending projects like podman should only run
against what landed in buildah/main, i.e. the podman-next COPR.
Note that this does not preclude testing a podman PR against an
buildah PR: This can be explicitly requested [1]. But most PRs
don't change the API and thus should default to isolation.
[1] https://packit.dev/posts/testing-farm-triggering
[NO NEW TESTS NEEDED]
Signed-off-by: Martin Pitt <mpitt@redhat.com>
updated Debian install instructions to reflect current stable Debian version and name which is Debian 12 Bookworm
Signed-off-by: Anjaneyulu Aerrolla <aaerrolla@gmail.com>
`--layer-label` allows users to set labels on intermediate labels agnostic
of the labels set on actual image. Since there are use-cases where users
want to perform operation on intermediate images only on the basis of
certain labels.
Closes: https://github.com/containers/buildah/issues/4933
Signed-off-by: Aditya R <arajan@redhat.com>
Fixes: https://github.com/containers/buildah/issues/4838
Resolve a long-standing TODO item (and bug fix apparently) relating to
passing important env. var. values into special testing contexts.
Namely container-based and rootless testing. These changes mostly come
from the (now battle-tested) work by @edsantiago in the podman CI
scripts. Some podman-CI specific variables have been stripped out, and
other buildah-specific simplifications made.
Signed-off-by: Chris Evich <cevich@redhat.com>
Don't create an ImageDestination only to call .Reference() on it. copy.Image
manages its own ImageSource/ImageDestination instances.
- On the pull path, this causes two ImageDestination objects to exist concurrently
for the same directory. That's not really expected to work (because the implementation
caches a modified top-level index in memory); luckily it currently doesn't matter
because we don't make any writes through the manually-managed object, but it's
a risk for future changes.
- On the push path, this creates a local object when the thing to push just doesn't exist.
Note that the code calls the input "sourcePath" but it can contain a tag, and that
seems to be intentional.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Adds support for `--add-compression` which accepts multiple compression
formats and when used it will add all instances in a manifest list with
requested compression formats.
Signed-off-by: Aditya R <arajan@redhat.com>
renovate[bot]
OpenShift Merge Robot
Lokesh Mandvekar
Daniel J Walsh
Martin Pitt
Anjaneyulu Aerrolla
Tom Sweeney
Aditya R
Chris Evich
Miloslav Trmač