Use the directories configured in containers.conf, now that
containers/common can tell us what they are, and now that it provides a
place to configure defaults for container tools, always override the
library's default set, even if it's empty, which means we do nothing.
Switch to the default CDI registry instead of the recenty-deprecated
non-global one.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Add a link to the README.md for the Buildah Container Image
that is found in quay.io to the README.md page.
Addresses: #5500
Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
We can't set it all of the time because the renovate bot doesn't allow
us to set this in its configuration unless we're hosting the bot
ourselves, and I don't think that we are.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Set GOTOOLCHAIN=local for all make targets, and for renovate.
Have the "vendor" target (and by extension, "vendor-in-container", which
our validation in CI uses) clear any "toolchain" directive that might
have been added to go.mod through manual invocations of the compiler.
At this point, we probably don't need to be checking for Go module
support, so switch to assuming it's available.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Replace some of the base images we've been using (particularly centos:8,
which will EOL soon) with other images hosted on quay.io.
We already use registries.conf at test-time to redirect some image
references there, so this will slightly reduce the number of registries
which we need to be able to reach while running these tests.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Merge the two tar filters, if we need two, that we use when committing
an image. Try to improve passing of error information from the writing
end of a pipe to the reader, so that it can be reported better.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
It's no longer an active release for the rhcontainerbot/podman-next COPR
at https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/.
Add "adjustments to .packit.yaml" to the list of things we don't require
updated tests for.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
For the last long time, Fedora CI VMs have had a disk /tmp.
Real-world setups typically have tmpfs /tmp. This switches
to CI VMs that reflect the real world.
See https://github.com/containers/automation_images/pull/340
Signed-off-by: Ed Santiago <santiago@redhat.com>
Instead of assuming which labels are set in our base image, and using
the --unsetlabel flag to suppress them in a derived image, query the
base image and unset all of them, except for our own version label.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
We seem to be running up against the timeout when running the unit tests
in CI. Give them 90 minutes to complete instead of 60.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Don't bother removing specific images at the beginning or the end of
tests, since we don't carry over the storage used between tests anyway.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Attempt to make more thorough use of cached copies of images during
integration tests, except in tests which need to pull a new image while
they're running, either because they test pulling directly, or because
they expect to pull a given image for a non-default platform or for
multiple platforms.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
When fetching images in the _prefetch() function, use the same registry
configuration (shortname configuration, registry aliases) that we're
already telling buildah to use when we call it, so that we prefetch from
the locations that buildah would subsequently use if we didn't prefetch.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
openshift-merge-bot[bot]
renovate[bot]
Nalin Dahyabhai
Daniel J Walsh
tomsweeneyredhat
Ed Santiago
Giuseppe Scrivano