Podman adds an Error: to every error message. So starting an error
message with "error" ends up being reported to the user as
Error: error ...
This patch removes the stutter.
Also ioutil.ReadFile errors report the Path, so wrapping the err message
with the path causes a stutter.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com
[NO NEW TESTS NEEDED]
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
In a couple of places, we'd try to wrap an error at points after we'd
have returned if they weren't `nil`.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
We now use the golang error wrapping format specifier `%w` instead of
the deprecated github.com/pkg/errors package.
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Make tests/copy/copy.go and tests/imgtype/imgtype.go aware of rootless
defaults, and have them re-exec themselves in user namespaces if they're
run in such an environment.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
`DefaultConfig()` from c/common/pkg/config should not be used here.
This only contains the built in defaults but not the actual values from
the files on disk. The correct way is to call `Default()` and since this
already handles the `CONTAINERS_CONF` env var we do not need to handle
it manually.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Force libnetwork to record the network configuration so that its
auto-detection logic doesn't get confused by the presence of the image
that we're writing to storage, after it's been written.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Add the --dest-compress, --dest-decompress, --dest-compress-format,
and --dest-compress-level options to the "copy" test helper.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Add a --max-parallel-downloads flag to allow tuning down from the
default of six blobs at a time, and tune it down to one at a time when
we invoke the helper.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Nalin Dahyabhai
Giuseppe Scrivano
Daniel J Walsh
Sascha Grunert
Paul Holzinger