Marco Hutter
9855400417
Use proper relative paths in all public headers
2021-09-28 17:23:07 +02:00
Marco Hutter
27fdd26e27
Merge remote-tracking branch 'origin/main' into include-style-fixes
...
# Conflicts:
# Cesium3DTilesSelection/include/Cesium3DTilesSelection/GltfContent.h
# Cesium3DTilesSelection/src/Batched3DModelContent.cpp
# Cesium3DTilesSelection/src/CompositeContent.cpp
# Cesium3DTilesSelection/src/ExternalTilesetContent.cpp
# Cesium3DTilesSelection/src/GltfContent.cpp
# Cesium3DTilesSelection/src/QuantizedMeshContent.cpp
# Cesium3DTilesSelection/src/Tile.cpp
# Cesium3DTilesSelection/src/TileContentFactory.cpp
# Cesium3DTilesSelection/src/calcQuadtreeMaxGeometricError.h
2021-09-28 14:38:33 +02:00
Kevin Ring
62ff744d4f
Treat `<something.h>` as third-party include.
2021-09-27 10:46:26 +10:00
Sean Lilley
ae7d9e70a8
Merge branch 'main' into gltf-generator-enum-fixes
2021-09-26 13:24:10 -04:00
Marco Hutter
175b7eec9a
Also format the auto-generated code
...
This will sort itself out at some point...
2021-09-26 17:57:48 +02:00
Marco Hutter
0e827f7afd
Updated includes based on clang-format with Regroup
...
This MAINLY inserted some blank lines between
the blocks.
2021-09-26 17:46:27 +02:00
Marco Hutter
0f6645f34b
Removed the classes from GeneratedJsonHandlers.
...
Apparently, all implementations are in one file. Not
sure where the individual files came from...
2021-09-26 16:53:51 +02:00
Marco Hutter
486eb57a93
Update for glTF enums in other classes - WIP
...
This updates the non-auto-generated classes based on
the changes of the auto-generated ones.
2021-09-26 15:06:10 +02:00
Marco Hutter
f63c0e5265
Update of auto-generated classes - WIP
...
This does not compile. It is only the update of the
auto-generated classes, without the corresponding
updates in the non-auto-generated classes.
2021-09-26 14:44:29 +02:00
Marco Hutter
6a5e0d3d48
Added missing const for reference parameters
...
C26460: The reference argument ... for function ... can be marked as const
2021-09-15 17:43:42 +02:00
Marco Hutter
46c9c7ec7d
Formatting after adding const
2021-09-15 15:38:06 +02:00
Marco Hutter
de8145ab9e
Added missing const keyword
...
C26496: The variable ... is assigned only once, mark it as const
2021-09-15 15:37:29 +02:00
Marco Hutter
a84b09c238
Added further noexcept specifiers
2021-09-15 02:35:40 +02:00
Marco Hutter
588c5a1ab9
Add noexcept for default constructors
...
C26455: Default constructor may not throw.
2021-09-15 01:35:34 +02:00
Marco Hutter
97a2757e39
Added missing noexcept specifiers
...
Reported as "C26440 Function ... can be declared noexcept"
2021-09-14 16:12:50 +02:00
Kevin Ring
7f012b2506
Clearer verifySuccessfulCopy.
2021-08-25 10:23:32 +10:00
Kevin Ring
f8b8f9bcb0
Fix clang warnings.
2021-08-23 22:56:56 +10:00
Kevin Ring
4704366a94
Better doc, extra test.
2021-08-23 22:46:21 +10:00
Kevin Ring
004b4839ad
Fix typo.
2021-08-23 22:28:30 +10:00
Kevin Ring
215b3e3d32
Add ImageManipulation class.
2021-08-23 22:26:37 +10:00
Bao Tran
1c608a9dd4
attempt to unify draco target
2021-07-26 17:03:13 -04:00
Bao Tran
3dc4c2da40
suppress draco warning on MSVC and define draco alias target
2021-07-26 16:43:36 -04:00
Sean Lilley
46c5a41827
Update draco version so that cesium-native builds in gcc 11
2021-07-26 16:17:57 -04:00
Kevin Ring
449068c3d6
Merge pull request #281 from CesiumGS/feature-metadata-extension
...
Upgrade batch table to EXT_feature_metadata extension
2021-07-24 21:32:14 +10:00
Kevin Ring
33b40b6dad
Generate JSON handlers into a single source file.
...
To speed up compilation.
2021-07-06 22:34:18 +10:00
Kevin Ring
4e45bab460
Use angle brackets to #include catch2.
2021-07-04 22:57:11 +10:00
Bao Tran
e1eb2d1f84
Merge branch 'main' into feature-metadata-extension
2021-07-02 10:50:43 -04:00
Kevin Ring
09b4e393de
More cleanup of tracing macros.
2021-06-22 12:26:07 +10:00
Kevin Ring
44a69d4cda
Clean up tracing API.
2021-06-21 17:33:59 +10:00
Kevin Ring
0648cb07d2
Allocate unique IDs for tileset loading slots.
2021-06-08 15:23:36 +10:00
Kevin Ring
491531147d
Merge remote-tracking branch 'origin/profiler' into load-tracing
2021-06-07 16:35:19 +10:00
Kevin Ring
30f22898b1
Feature metadata working well for simple case.
2021-05-17 12:30:09 +10:00
Kevin Ring
8f85fd8bbe
WIP conversion of b3dm batch table to EXT_feature_metadata.
2021-05-14 22:28:31 +10:00
Kevin Ring
15be10ed1b
Merge remote-tracking branch 'origin/main' into feature-metadata-extension
2021-05-13 21:22:28 +10:00
Kevin Ring
a21938c371
Use stbi_image_free instead of free, update CHANGES.
2021-05-12 23:03:26 +10:00
Bao Tran
ed01f94552
format
2021-05-07 17:31:30 -04:00
Bao Tran
17348ff432
Merge branch 'main' into match-draco-indices
2021-05-07 17:19:04 -04:00
Bao Tran
1dc58c95e2
match indices accessor count with decoded draco indices
2021-05-07 17:12:34 -04:00
Kevin Ring
ed42e46d5f
Add support for EXT_feature_metadata on Primitives.
2021-05-07 16:18:13 +10:00
Kevin Ring
0d6295168f
Use 3d-tiles-next branch of glTF instead of my fork.
2021-05-07 15:40:53 +10:00
Kevin Ring
b29b8c64ad
EXT_feature_metadata progress.
2021-05-07 15:34:16 +10:00
Samuel Vargas
fbcc458681
Fix a leak where pImage isn't freed after being copied into ImageReaderResult
2021-05-06 11:53:39 -04:00
Kevin Ring
527e6051c1
Fix more code gen problems.
2021-05-06 17:30:39 +10:00
Marco Hutter
51e43bbd49
Comment fixes for clang formatting
2021-04-29 17:06:34 +02:00
Samuel Vargas
3412704062
Replace bitmask options with dedicated struct
2021-04-19 14:28:43 -04:00
Samuel Vargas
5deb2861f2
Replace back_inserter / transform with std::copy and reinterpret_cast
2021-04-19 13:41:10 -04:00
Kevin Ring
6c0a55c090
Fix formatting.
2021-04-16 16:23:08 +10:00
Kevin Ring
999c382cc1
Merge remote-tracking branch 'origin/main' into gltf-extensions
2021-04-16 16:07:23 +10:00
Kevin Ring
e5c5408804
More constier.
2021-04-16 13:18:25 +10:00
Kevin Ring
8aab8bbec2
Don't construct so many GltfReaders.
...
Also switch to constexpr char* for extension and type names to avoid
static initializer ordering problems.
2021-04-16 12:52:29 +10:00
Samuel Vargas
8070d85023
Merge remote-tracking branch 'origin/main' into gltf-writer
2021-04-15 13:49:04 -04:00
Kevin Ring
02e3be9b03
Merge remote-tracking branch 'origin/main' into gltf-extensions
2021-04-15 21:54:03 +10:00
Kevin Ring
ea97130b0e
Formatting.
2021-04-15 10:54:49 +10:00
Kevin Ring
aab3fcbf40
Fix another clang error.
2021-04-15 10:40:58 +10:00
Kevin Ring
bf00407f90
Add missing include.
2021-04-15 10:22:56 +10:00
Kevin Ring
0c7c949ce8
Remove unused code.
2021-04-15 09:47:33 +10:00
Kevin Ring
45f44fa034
Reader -> GltfReader.
2021-04-15 00:37:37 +10:00
Kevin Ring
e414544b50
Implement glTF reader using JSON reader.
2021-04-14 23:53:26 +10:00
Kevin Ring
fc4f25515f
JSON reader.
2021-04-14 23:31:40 +10:00
Kevin Ring
15f799429a
More renames.
2021-04-14 21:38:36 +10:00
Kevin Ring
cb91ccf8a6
JsonReader -> JsonHandler ♻
2021-04-14 18:31:12 +10:00
Kevin Ring
94ea03847c
Move CesiumJsonReader stuff to the right namespace.
2021-04-14 14:22:22 +10:00
Kevin Ring
88795c0045
Move JsonValue to CesiumUtility.
2021-04-13 23:24:53 +10:00
Kevin Ring
222692b590
Separate CesiumJsonReader library.
2021-04-13 22:05:36 +10:00
Jordi Torres
6333b1cb0a
First pass of clang tidy
...
Mainly caching else after return, not using empty() instead of size() == 0, missing const references to avoid copies and removing redundant initializations
2021-04-12 13:22:03 +02:00
Kevin Ring
f0b06a826d
Make IgnoreValueJsonHandler public.
2021-04-09 12:37:53 +10:00
Kevin Ring
673e9884a1
Renames.
2021-04-09 12:30:27 +10:00
Kevin Ring
cfff453f8c
Rename protected key methods.
2021-04-08 22:34:12 +10:00
Kevin Ring
2ab38cd0fb
Don't qualify reader methods in extensions.
2021-04-08 22:26:22 +10:00
Kevin Ring
ebfb30554a
Fix linux build.
2021-04-08 22:20:24 +10:00
Kevin Ring
48f2d3b5c2
Remove unused files, other cleanup.
2021-04-08 21:59:42 +10:00
Kevin Ring
7279f4cabf
Improve tests.
2021-04-08 17:59:45 +10:00
Kevin Ring
e3148aedc6
Reactivate Draco extension.
2021-04-08 14:44:39 +10:00
Kevin Ring
f33f7b1dd5
Make CesiumGltf::Reader a proper class, mange its own extensions.
2021-04-07 23:41:37 +10:00
Kevin Ring
3566ba5b29
Clean up JsonReader function signatures.
2021-04-07 14:35:19 +10:00
Samuel Vargas
f9e489f67f
Merge remote-tracking branch 'origin/main' into gltf-writer
...
Accidentally merged with antiquated `master` branch before
2021-04-06 14:16:55 -04:00
Samuel Vargas
6516b2dcb3
Add clarifying comment for std::transform usage
2021-04-06 13:44:34 -04:00
Samuel Vargas
b03dac82af
Add trailing newline to misc files [ skip ci ]
2021-04-06 13:07:48 -04:00
Kevin Ring
d6d9de643d
Rename JsonReader methods.
2021-04-06 22:26:16 +10:00
Kevin Ring
04f4cc12db
JsonHandler -> JsonReader.
2021-04-06 21:59:20 +10:00
Kevin Ring
c8c9ca0f3a
Make IJsonHandler.h and JsonHandler.h public.
2021-04-06 21:55:50 +10:00
Kevin Ring
987ca69614
Support for external glTF extensions.
2021-04-06 21:49:12 +10:00
Kevin Ring
692a3bf16b
Merge remote-tracking branch 'origin/main' into support-deserializing-arbitrary-extensions
2021-04-05 11:57:45 +10:00
Marco Hutter
0ba6f38be5
Fixed typo.
2021-04-02 21:43:45 +02:00
Marco Hutter
aeeb44e804
Added cast.
...
Expected that. GCC this time.
2021-04-02 21:42:23 +02:00
Marco Hutter
7425d5a89a
Updated and extended error messages
2021-04-02 21:14:43 +02:00
Bao Tran
9c5de37499
add TRACE for Gltf reader
2021-03-25 13:25:03 -04:00
Samuel Vargas
11413ee747
Run clang-format on all changed files
2021-03-11 15:15:59 -05:00
Samuel Vargas
258f1a1993
Add test to verify deserializeExtensionsAsJsonValue is respected
2021-03-11 15:01:01 -05:00
Samuel Vargas
f81dd2c218
Use references to avoid extraneous copies.
2021-03-11 14:40:13 -05:00
Samuel Vargas
f685ceff51
Propagate `ReadModelOptions` to ALL JsonHandlers
...
This commit adds conditional support for propagating the
`ReadModelOptions` variable to the root JsonValue class for all of
its children. CesiumGltfReader was designed with the philosophy that
extensions should be well defined and that CesiumGltfReader should
take responsbility for decoding extensions. This is a fine idea, but we've
ran into a usecase where we need CesiumGltfReader to support decoding
new / developing / unknown / WIP extensions.
This commit adds the `deserializeExtensionsAsJsonValue` bool to ReadModelOptions
and for each ***JsonHandler, forwards it to the root via super() constructor invocations.
This opens the door for other "while serializing" options to be stored in
ReadModelOptions
The deserializeExtensionsAsJsonValue variable itself instructs CesiumGltfReader
to add any extensions it encounters in the Gltf string as a `JsonValue::Object` inside
the std::vector<std::any>, so that users of the libraries can retrieve it and do their
own casting.
2021-03-11 14:30:11 -05:00
Samuel Vargas
eb3cb751bf
Always serialize extensions as a JsonValue::Object for clients to
...
use directly.
(This will be wrapped in a conditional flag in the next commit)
2021-03-11 09:41:03 -05:00
Kevin Ring
c0225f0e7d
Flesh out JSON array test.
2021-03-11 10:09:55 +11:00
Kevin Ring
d671ae6ee8
Remove unnecessary header.
2021-03-11 10:03:32 +11:00
Kevin Ring
5a3c10a020
Correctly handle elements inside JSON arrays.
2021-03-11 10:02:15 +11:00
Samuel Vargas
94c77dd89e
Merge tag 'post-clang-format' into gltf-writer-clang-format
...
The commit that ran clang-format on the entire codebase and made no other changes.
2021-03-09 16:36:39 -05:00
Shehzan Mohammed
8a2957d32f
Run clang format
2021-03-08 20:39:46 -05:00
Samuel Vargas
30057e9539
Fix casting warning in Reader.cpp
2021-03-05 10:40:12 -05:00
Samuel Vargas
506f76c34b
Use std::byte for image.cesium.pixelData
2021-03-05 10:04:10 -05:00
Samuel Vargas
c4f6025420
Add integer support to JsonValue
...
This also fixes a narrowing conversion bug. Previously if
a type that was larger than 2^53 was stored in a JsonValue
it would be silently casted into a double, causing an unexpected
precision loss. This changes JsonValue to use the largest signed,
unsigned, or floating point value available to support both types
of Numbers.
Also updates GSL version because they added a narrowing cast
function and we use that for safe type casting.
2021-03-05 07:41:15 -05:00