Commit Graph

292 Commits

Author SHA1 Message Date
Janine Liu 4e9cfaba88
Merge pull request #793 from CesiumGS/feature-id-texture-sampler-wrap
Change `FeatureIdTextureView` to account for sampler wrap values in `getFeatureID`
2024-01-19 11:37:25 -05:00
Janine Liu 695898e37d Interpret offsets as array indices, not byte offsets 2024-01-18 16:45:31 -05:00
Ashley Rogers df7bb9fa91 Fix sign conversion errors on Clang & GCC 2024-01-18 10:06:20 -05:00
Ashley Rogers 0975b7d1e3 FeatureIdTextureView now accounts for sampler wrap values. 2024-01-17 17:05:36 -05:00
Janine Liu 4c22baebfb Add size_t casts 2024-01-09 13:13:51 -05:00
Janine Liu 338b3e4f0a Add support in face index visitor for different primitive modes 2024-01-09 12:26:18 -05:00
Janine Liu 216c49996a Remove unused include 2023-12-14 16:58:52 -05:00
Janine Liu b48d8085ee Update unit tests 2023-12-14 16:51:38 -05:00
Janine Liu 8bcde4e06c Merge branch 'main' into std-string-conversion 2023-12-14 10:55:55 -05:00
Janine Liu 7ee8ddd749 Add manual check for negative sign when parsing ull 2023-12-11 10:56:18 -05:00
Janine Liu 587db88565 Attempt to catch out-of-range error 2023-12-08 15:39:48 -05:00
Kevin Ring f05ebf5785
Merge pull request #770 from CesiumGS/remove-u32
Remove `uint32_t` support for property attributes
2023-11-29 09:50:46 +11:00
Sean Lilley dcec862432 Fix formatting 2023-11-27 13:38:33 -05:00
Sean Lilley 278f936cce Update tests 2023-11-27 11:06:27 -05:00
Janine Liu f0f009c87e Decapitalize function names 2023-11-20 11:00:33 -05:00
Kevin Ring 4788905834
Merge branch 'main' into add-accessor-utility 2023-11-20 17:55:37 +11:00
Kevin Ring 7faea62441
Merge branch 'main' into property-value-conversions 2023-11-20 17:41:32 +11:00
Janine Liu 268ead2402 Add static casts 2023-11-14 16:07:09 -05:00
Janine Liu 4f51905d21 Add StatusFromAccessor visitor 2023-11-14 15:50:24 -05:00
Sean Lilley d94200fe0e Fix doc 2023-11-14 15:43:23 -05:00
Janine Liu df13673387 Add additional 'get' functions, update changelog 2023-11-14 13:32:19 -05:00
Janine Liu e19fa4dba2 Move accessor utility to cesium-native 2023-11-14 11:48:09 -05:00
Janine Liu 4b0c18d6ab Add support for matN conversions 2023-11-13 14:27:12 -05:00
Janine Liu c7122591d6 Switch to std::optional syntax instead of defaulting to some value 2023-11-13 11:47:14 -05:00
Janine Liu c702a92a01 Begin implementing conversion logic 2023-11-10 18:11:38 -05:00
Janine Liu f2564b8223 Remove redundant PropertyTexturePropertyView param 2023-09-15 17:01:27 -04:00
Janine Liu 856d34ea19 Add new status code for empty properties with default values 2023-09-13 14:26:20 -04:00
Janine Liu 7a3a5f0d86 Update changelog and fix sign conversions 2023-08-29 15:48:28 -04:00
Janine Liu 7bf2d18d05 Finish writing tests for PropertyAttributeView 2023-08-29 15:32:42 -04:00
Janine Liu 85ebd3ed7f Add unit tests for new classes, reorganize old tests 2023-08-29 12:10:47 -04:00
Janine Liu a8f46ab0c5 Add PropertyAttributeView and PropertyAttributePropertyView 2023-08-28 17:49:51 -04:00
Janine Liu f51012e602 Fix documentation and test 2023-08-28 13:18:51 -04:00
Janine Liu 7f13e1c3f4 Another CI fix 2023-08-28 11:21:10 -04:00
Janine Liu 36337303b1 Fix sign conversion 2023-08-28 10:49:18 -04:00
Janine Liu 5b33dd72ad Fix signed conversions 2023-08-28 10:07:08 -04:00
Janine Liu 79eaa3e687 Final sweep (hopefully) 2023-08-25 17:46:16 -04:00
Janine Liu 2c97ce24ba Second unit test / cleanup sweep 2023-08-25 17:15:26 -04:00
Janine Liu 3e5d630a1f First round of cleanup / PR feedback 2023-08-25 16:17:11 -04:00
Janine Liu ed2bdbd553 Update PropertyTextureView 2023-08-24 20:52:45 -04:00
Janine Liu 76427497ca Rewrite property texture property tests 2023-08-24 18:33:56 -04:00
Janine Liu a00b819dca Finish up PropertyTableView tests 2023-08-24 14:35:45 -04:00
Janine Liu 53bc30391a Integrate normalization with PropertyTableView 2023-08-24 10:55:43 -04:00
Janine Liu 12d1bbcaaa Finish PropertyTablePropertyView tests 2023-08-23 14:55:48 -04:00
Janine Liu fc190004b6 Reinitialize const ints outside of class to avoid errors 2023-08-23 11:17:12 -04:00
Janine Liu 4f37e7a217 Try to fix CI errors 2023-08-23 10:32:28 -04:00
Janine Liu bc9dd9e6e5 Add static casts for integer optionals 2023-08-23 09:58:02 -04:00
Janine Liu d43d7138af Start adding tests for PropertyTablePropertyView 2023-08-22 18:31:09 -04:00
Janine Liu 38001698e8 Fix offset / scale etc. to only work for fixed-length arrays 2023-08-22 12:43:48 -04:00
Janine Liu 734c8cfbb6 Add get vs. getRaw to property view 2023-08-21 17:43:23 -04:00
Janine Liu 78099d3a70 Fix PropertyView and unit tests 2023-08-21 15:33:05 -04:00
Janine Liu bf324061b6 Start reworking property view for normalization 2023-08-18 17:48:03 -04:00
Janine Liu 43cd1a512e Try to get CI to compile 2023-08-18 15:51:06 -04:00
Janine Liu 5da1ca3e78 Add templating for normalization 2023-08-18 14:19:40 -04:00
Janine Liu 38a595537d Finish unit tests for PropertyView 2023-08-17 15:38:17 -04:00
Janine Liu e7743ea61c Change status enum to static consts 2023-08-17 13:55:54 -04:00
Janine Liu ba779b7c41 Add support for matN values 2023-08-16 14:56:02 -04:00
Janine Liu bfbb6945e5 Add support for vecN 2023-08-16 13:56:37 -04:00
Janine Liu 6dcadfe38e Create PropertyView 2023-08-15 12:43:10 -04:00
Janine Liu 047422b53d Fix nearest sampling for feature ID textures 2023-07-05 16:35:34 -04:00
Janine Liu b024fe5b8f Stricter reinforcement of unsupported properties 2023-07-03 17:26:24 -04:00
Janine Liu bb1dea3739 Consolidate CI fixes 2023-07-03 16:27:43 -04:00
Janine Liu f3ecde1681 Add callbacks and tests 2023-06-29 16:51:07 -04:00
Janine Liu 8155617808 Add tests for templated getPropertyView 2023-06-29 14:49:12 -04:00
Janine Liu 76d5d26051 Rework PropertyTexturePropertyView, begin reworking PropertyTextureView 2023-06-23 12:06:25 -04:00
Janine Liu 73ea6a1cc9 Merge branch 'upgrade-feature-metadata' into fix-property-texture-view 2023-06-20 13:50:38 -04:00
Janine Liu ffc1ca8f65 Use helper function in PropertyTableView tests 2023-06-16 17:33:40 -04:00
Janine Liu c329a8d407 Replace class names in metadata implementation files 2023-06-16 16:25:39 -04:00
Janine Liu e0f49321c5 Prefix EXT_feature_metadata files, rename EXT_mesh_features files 2023-06-16 15:16:05 -04:00
Janine Liu b25ad79bdc Start reworking property texture view 2023-06-16 13:55:43 -04:00
Janine Liu bc67ba8490 Fix other files 2023-06-06 11:37:35 -04:00
Janine Liu a50093c460 Rename files and take classes out of separate namespaces 2023-06-06 11:28:24 -04:00
Janine Liu 7e0cd8a055 Add tests for feature ID texture view 2023-06-02 14:23:15 -04:00
Janine Liu 44b829a081 Add PropertyTextureProperty tests, fix formatting 2023-05-30 11:11:06 -04:00
Janine Liu 619faea5b7 Add PropertyTextureView and rename PropertyTable classes 2023-05-30 10:27:21 -04:00
Janine Liu 7f2ea49940 Minor whitespace nitpicks 2023-05-24 12:42:07 -04:00
Janine Liu bae45489ed Add tests 2023-05-24 12:36:28 -04:00
Janine Liu 1cce7f8202 Use references instead of pointers, add missing doc links 2023-05-24 11:04:45 -04:00
Janine Liu b8b3edea51 Code cleanup 2023-05-23 11:42:34 -04:00
Janine Liu 7e08eadf07 Remove final unused variable 2023-05-23 10:39:26 -04:00
Janine Liu 5513169280 Remove unused variables 2023-05-22 17:50:38 -04:00
Janine Liu 64b8378019 Add tests for callback on array property 2023-05-22 17:46:34 -04:00
Janine Liu 3dd83ab8d0 Add callback tests 2023-05-22 17:26:11 -04:00
Janine Liu efb95c5659 Verify that callbacks work with unit tests 2023-05-22 15:29:14 -04:00
Janine Liu 2b8e5349fa Add tests for StructuralMetadataPropertyTableView 2023-05-19 15:41:54 -04:00
Janine Liu e1305361b4 Add tests for new property view 2023-05-17 14:01:40 -04:00
Kevin Ring dccb99e666 Formatting. 2023-05-17 07:38:44 +10:00
Janine Liu 1433243c3d Add StructuralMetadataPropertyTypeTraits 2023-05-15 18:13:47 -04:00
Janine Liu 14997fb031 Add property types for structural metadata 2023-05-15 16:58:17 -04:00
Nithin Pranesh 8adcf6e67f removed todos, more descriptive comments about 8-byte alignment 2022-02-21 10:28:22 -05:00
Nithin Pranesh 122c9bcfdf fix tests, for now we will stop enforcing 8-byte alignment for metadata buffers 2022-01-10 10:44:46 -05:00
Sean Lilley 6fd48d8735 Use different naming convention for extension classes 2021-10-30 14:55:40 -04:00
Sean Lilley 066b3df5a5 Use strict types 2021-10-18 18:47:02 -04:00
Sean Lilley f9b48fbe0e Renegerate glTF classes 2021-10-18 18:46:58 -04:00
Sean Lilley 52283f3359 Fix includes 2021-10-11 17:28:44 -04:00
Marco Hutter 0e827f7afd Updated includes based on clang-format with Regroup
This MAINLY inserted some blank lines between
the blocks.
2021-09-26 17:46:27 +02:00
Marco Hutter 8ddb163f6d Perform component-wise vector comparison 2021-08-23 21:04:42 +02:00
Nithin Pranesh 08e56e68b6 more gcc/clang fixes 2021-08-23 13:33:36 -04:00
Nithin Pranesh 6d3f8ee262 attempt to fix gcc/clang errors 2021-08-23 13:12:21 -04:00
Nithin Pranesh 24e9acb1ed add tests for triangle strips and fans 2021-08-23 12:22:06 -04:00
Nithin Pranesh e7932e0ce4 add tests for smooth normals and forEachPrimitive 2021-08-21 12:15:29 -04:00
Kevin Ring 449068c3d6
Merge pull request #281 from CesiumGS/feature-metadata-extension
Upgrade batch table to EXT_feature_metadata extension
2021-07-24 21:32:14 +10:00
Bao Tran 8ccd633dfb add status for property view 2021-07-20 12:15:13 -04:00
Bao Tran 31d85a358d add status for property view 2021-07-19 12:17:54 -04:00
Bao Tran 3d9e0c13bd convert type to PropertyType instead of uint32 2021-07-17 23:55:04 -04:00
Bao Tran 2e7d9b8c97 fix compiler warning 2021-07-15 20:11:16 -04:00
Bao Tran 5f4add636a fix more compiler warning 2021-07-15 19:52:20 -04:00
Bao Tran a6d8f69e57 fix compiler warning 2021-07-15 19:49:29 -04:00
Bao Tran eca0952eb2 add assertion when converting binary metadata 2021-07-15 19:25:42 -04:00
Bao Tran e420e729ec fix compiler warning 2021-07-15 19:10:59 -04:00
Bao Tran 1185d2e78f use int64 for meta array 2021-07-15 17:17:30 -04:00
Bao Tran c19b847261 fix test 2021-07-15 17:00:31 -04:00
Bao Tran dab9312560 use int64_t for property view 2021-07-13 13:47:01 -04:00
Kevin Ring 4e45bab460 Use angle brackets to #include catch2. 2021-07-04 22:57:11 +10:00
Bao Tran e1eb2d1f84 Merge branch 'main' into feature-metadata-extension 2021-07-02 10:50:43 -04:00
Bao Tran 3091533ef6 change PropertyView to MetadataPropertyView 2021-06-20 15:58:08 -04:00
Bao Tran 3846381cc9 change names of property type trait 2021-06-20 15:56:06 -04:00
Bao Tran c64fea091e test property trait and format 2021-06-20 15:51:53 -04:00
Bao Tran 3243f9c4ed test property type 2021-06-20 15:14:34 -04:00
Bao Tran c0faaf18dc change file name for batch table to EXT_feature_metadata 2021-06-20 14:51:15 -04:00
Bao Tran 951cb7a23e pass rapidjson::Document for batch table json to metadata upgrader 2021-06-20 14:47:36 -04:00
Bao Tran 6035cc8387 clean up unused headers 2021-06-20 12:11:18 -04:00
Bao Tran 661db543d2 replace operator[] with get() for PropertyView 2021-06-20 01:40:27 -04:00
Bao Tran 76f2d10ccb test to validate dynamic array of string 2021-06-18 18:44:41 -04:00
Bao Tran 96c49c4529 test fixed array of string 2021-06-18 14:48:29 -04:00
Bao Tran 9a68718dc6 test for dynamic bool array 2021-06-18 11:41:46 -04:00
Bao Tran b6c8047c18 add test to validate fixed bool array 2021-06-17 17:00:49 -04:00
Bao Tran 6300cae267 test to validate dynamic numeric array 2021-06-17 15:26:31 -04:00
Bao Tran 47b891fac8 fix compiler warning 2021-06-17 13:28:02 -04:00
Bao Tran 7ac819dcf5 add test to validate fixed numeric array 2021-06-17 13:07:28 -04:00
Bao Tran 21f44e7a29 test to make sure offset values are sorted 2021-06-16 16:43:35 -04:00
Bao Tran d7c42c559d add test for string validation 2021-06-16 16:11:20 -04:00
Bao Tran 0506eed5c3 add test validation for bool property 2021-06-15 17:11:28 -04:00
Bao Tran 1c2a758274 add more tests to validate metadata bufferview 2021-06-15 15:15:40 -04:00
Bao Tran 3288dc5bca fix compiler warning 2021-06-15 14:51:30 -04:00
Bao Tran 62b89c365d WIP test feature table view to read property correctly 2021-06-15 14:05:26 -04:00
Bao Tran 3363cee7e8 change MetadataPropertyView to PropertyView 2021-06-14 18:35:36 -04:00
Bao Tran bc8dd36951 impl FeatureTableView 2021-06-14 18:30:01 -04:00
Bao Tran 15fcfbf7a2 fix compiler error 2021-06-08 11:41:49 -04:00
Bao Tran a4a4068e78 add test for upgrading batch table 2021-06-01 19:37:46 -04:00
Bao Tran 8d6d46ef30 test dynamic array of bool 2021-06-01 01:39:00 -04:00
Bao Tran f2e6dfed59 test fixed array of bool 2021-06-01 01:09:36 -04:00
Bao Tran a750fc2f9f impl dynamic array of string test 2021-05-31 20:25:32 -04:00
Bao Tran b9c5c77ed6 WIP template property view 2021-05-31 00:12:31 -04:00
Bao Tran 3dff283062 custom meta array view for property 2021-05-29 21:42:03 -04:00
Bao Tran 3cc40b6ed1 add boolean property view 2021-05-27 18:12:31 -04:00
Bao Tran b457b7db3c format 2021-05-27 15:41:11 -04:00
Bao Tran b7a84cfb61 fix string test 2021-05-27 14:23:55 -04:00
Bao Tran 2b79291e43 fix dynamic array tests 2021-05-27 14:15:57 -04:00
Bao Tran df7427ad2d add tests back again 2021-05-27 13:39:02 -04:00
Bao Tran 077680acae fix out of bound tests 2021-05-27 13:25:10 -04:00