Janine Liu
116743cc0b
Fix translation bug, try to appease clang-tidy
2025-02-17 16:00:07 -05:00
Janine Liu
60536f2e1a
BoundingCylinder -> BoundingCylinderRegion
2025-02-14 17:44:56 -05:00
Janine Liu
e2ca2ac357
Formatting
2025-02-12 14:17:28 -05:00
Janine Liu
b0f3c634df
Add BoundingCylinder as a tile bounding volume
2025-02-12 14:15:59 -05:00
Tim Moore
ed58d0236b
Merge remote-tracking branch 'origin/main' into vcpkg-pkg
2025-01-31 17:02:12 +01:00
Kevin Ring
2a15f06454
Merge remote-tracking branch 'origin/main' into fix-macos-tests
2025-01-24 10:47:02 +11:00
Sean Lilley
7948a1b422
Fix clang-tidy errors
2025-01-21 16:52:51 -05:00
Sean Lilley
d17552d556
Merge branch 'main' into remove-GLM_FORCE_SIZE_T_LENGTH
2025-01-21 16:34:43 -05:00
Kevin Ring
fc8f124487
macOS fixes, especially to losslessNarrow.
2025-01-21 17:34:10 +11:00
Kevin Ring
c48485e729
Formatting.
2025-01-17 18:33:29 +11:00
Kevin Ring
5294d16999
Don't use std::ranges.
...
Because it's not supported in Android NDK r25b.
2025-01-17 18:31:29 +11:00
Kevin Ring
3890b79e71
Fix various build problems and merge conflicts.
2025-01-17 13:42:52 +11:00
Kevin Ring
017d13393c
Merge pull request #1064 from CesiumGS/doctest
...
Use doctest instead of Catch2 for tests
2025-01-17 09:52:00 +11:00
Sean Lilley
ef27547b19
Merge branch 'main' into remove-GLM_FORCE_SIZE_T_LENGTH
2025-01-16 15:33:49 -05:00
Ashley Rogers
4e318925a5
Switch tests to doctest
2025-01-15 16:58:03 -05:00
Tim Moore
cc0be3e5e2
Respond to code review feedback
2025-01-15 18:14:23 +01:00
Kevin Ring
535b2e4bbf
Put BatchIdSemantic in the anonymous namespace.
2025-01-14 16:27:41 +11:00
Kevin Ring
e73e4cb057
More clang-tidy fixes.
2025-01-14 14:53:26 +11:00
Kevin Ring
b75d803aea
Fix clang-tidy errors.
2025-01-14 14:34:13 +11:00
Kevin Ring
05b5fbd065
Formatting.
2025-01-14 13:55:08 +11:00
Kevin Ring
49bf4169a1
Merge remote-tracking branch 'origin/main' into i3dm-metadata
2025-01-14 13:33:10 +11:00
Kevin Ring
59f01eb340
Fix clang-tidy errors.
2025-01-13 19:30:35 +11:00
Kevin Ring
d907086901
Fix dodgy formatting of null string values.
2025-01-13 18:24:53 +11:00
Kevin Ring
028ee29eed
Merge remote-tracking branch 'origin/main' into clang-tidy-cleanup
2025-01-13 17:30:09 +11:00
Sean Lilley
e62cfd762d
Remove GLM_FORCE_SIZE_T_LENGTH
2025-01-08 16:08:34 -05:00
Ashley Rogers
1db43366cd
Resolve review items
2025-01-06 14:48:49 -05:00
Tim Moore
5a7693ce8d
Fix some low-hanging fruit reported by clang-tidy
2025-01-02 11:51:30 +01:00
Tim Moore
8952f1161b
Unit test for I3dm batchtable conversion
2025-01-01 19:02:31 +01:00
Tim Moore
8307973d87
I3dm batch table conversion
2025-01-01 19:02:31 +01:00
Tim Moore
3258928ea3
Refactor MetadataProperty into its own files
...
This class in PntsToGltfConverter.cpp is useful for dealing with
instance metadata too.
2025-01-01 19:02:31 +01:00
Tim Moore
b7ee618972
Refactor instantiateGltfInstances in I3dm converter
...
The major refactor is to split the very rare case of
EXT_mesh_gpu_instancing extension in the I3dm glTF into another
function, and then reduce code duplication.
2025-01-01 19:02:30 +01:00
Kevin Ring
65b088de53
Merge remote-tracking branch 'origin/main' into i3dm-rotation-fix
2024-12-24 14:25:28 +11:00
Ashley Rogers
1b7b8ce29e
Fix review issues
2024-12-20 16:32:24 -05:00
Ashley Rogers
869a43267c
Undo trivially constructable std::move removals
2024-12-20 15:30:31 -05:00
Ashley Rogers
768b6510b3
Quotes to brackets
2024-12-20 12:00:09 -05:00
Ashley Rogers
2c8aa4a422
Fix includes using script
2024-12-20 11:56:49 -05:00
Ashley Rogers
2c992b7ba7
Performance checks
2024-12-19 15:27:53 -05:00
Ashley Rogers
f7d287dd80
Modernize checks
2024-12-19 15:20:19 -05:00
Ashley Rogers
9fc2400faf
Add cppcoreguidelines checks
2024-12-19 13:49:21 -05:00
Ashley Rogers
4aeee635ca
More checks
2024-12-18 15:25:51 -05:00
Ashley Rogers
bd4f19da7f
Fix unchecked optional accesses
2024-12-18 14:21:10 -05:00
Ashley Rogers
1e2e47ab5e
misc-include-cleaner for every file
2024-12-17 17:27:03 -05:00
Ashley Rogers
89b00e2cc0
Fix warnings from merge with main
2024-12-17 13:43:45 -05:00
Tim Moore
472687021e
Calculate I3dm instance rotations by converting basis to a matrix
...
The previous approach tried to create rotations directly from the up
and right vectors that encode the instance rotation, but it naïvely
didn't handle rotations of 180 degrees of the up and right vector. It
is reliable to create the rotation matrix, filling in the Z column
by doing a cross-product, and then let the algorithm for converting a
rotation matrix to a quaternion do its robust thing.
2024-12-16 11:27:59 +01:00
Kevin Ring
96e1d01844
Merge remote-tracking branch 'origin/main' into update-readme
2024-12-12 11:43:55 +11:00
Ashley Rogers
4d82403b80
Pan-zoom, add dependencies page.
2024-12-06 18:21:57 -05:00
Janine Liu
c32d3f4c04
Remove unnecessary lines, add additional test case
2024-12-06 17:30:59 -05:00
Janine Liu
192c2cb60b
Allow subtree files without binary chunks to be parsed
2024-12-06 17:14:45 -05:00
Janine Liu
30c1f4c6ae
Refactor createSubtreeContent
2024-12-06 16:40:50 -05:00
Janine Liu
4e15477ad8
Rewrite subtree creator in TestSubtreeAvailability
2024-12-06 15:53:13 -05:00
Tim Moore
d1b064d8fd
Don't add public headers to public target sources
...
The intent is for public target sources to be compiled into consumers
of a target, but that is a no-op for header files. Including the
public headers, which have paths pointing inside the project, causes
an error when generating an export set.
2024-12-05 16:03:52 +01:00
Janine Liu
4bd29dc7ef
Add missing @params
2024-12-04 15:53:04 -05:00
Ashley Rogers
bb365c8aee
Dependency graph generation
2024-12-04 14:39:16 -05:00
Ashley Rogers
cca8871eef
Include both catch2 headers
2024-11-22 11:30:45 -05:00
Ashley Rogers
f82d65bead
Change Catch2 header
2024-11-22 11:17:21 -05:00
Ashley Rogers
35bf88745e
Revert unnecessary cast changes
2024-11-22 11:04:17 -05:00
Ashley Rogers
acc9e81d12
Merge from main
2024-11-20 17:12:43 -05:00
Ashley Rogers
f573e49ad5
Fix remaining non-CesiumGltf warnings
2024-11-20 16:51:44 -05:00
Ashley Rogers
52633c67f4
Non-PropertyTable changes
2024-11-20 16:20:04 -05:00
Kevin Ring
fb24a2efe1
Merge remote-tracking branch 'origin/cpp20' into remove-gsl
2024-11-19 09:15:21 +11:00
Kevin Ring
89dfc44bdc
Remove use of GSL.
...
Change gsl::span to std::span, and replace the few uses of gsl::narrow
with an alternative.
2024-11-06 15:16:03 +11:00
Ashley Rogers
714aa28c28
SharedAsset support in gltf generated code
2024-10-22 11:42:09 -04:00
Tim Moore
a86948dadb
Change variable name to folow coding conventions
2024-08-28 18:44:14 +02:00
Tim Moore
f377ecb164
Fix a bug with instances that have multiple nodes
...
The i3dm converter was repeatedly overwriting the beginning of the new
glTF buffer that holds instance transformations.
2024-08-28 18:34:45 +02:00
Kevin Ring
88dd05cf8a
Formatting.
2024-08-15 08:40:37 +10:00
Kevin Ring
1fcdeadfd9
Merge remote-tracking branch 'origin/main' into vcpkg-swl
2024-08-02 19:45:58 +10:00
Brian L
d03181a97a
Revert changes to ForEachPrimitiveInSceneXXX callbacks
2024-07-24 13:17:22 -06:00
Kevin Ring
8b9b001b8b
Merge branch 'main' into gltf-ray-intersect
2024-07-23 13:38:37 -04:00
Janine Liu
707dd8b770
Add missing includes
2024-07-11 10:25:23 -04:00
Brian L
7cda07f420
Remove occurrences of including <glm/mat4x4.hpp> in header files
2024-07-09 09:25:27 -06:00
Brian L
ca25ad4840
Change int to int32_t when specifying an ID
2024-07-08 15:15:44 -06:00
Brian L
728668a873
Merge branch 'main' into gltf-ray-intersect
2024-07-08 09:15:30 -06:00
Kevin Ring
7c9ea84178
Merge remote-tracking branch 'origin/main' into vcpkg-swl
2024-07-02 17:39:20 +10:00
Kevin Ring
0d68e3a672
Small tweaks from review.
2024-06-29 10:54:47 +10:00
Tim Moore
38b727a674
Cast iterator distance to size_t
2024-06-28 11:10:09 +02:00
Tim Moore
c6de588e14
Strip trailing whitespace from i3dm external content URL
...
This whitespace may be added to keep the size of an i3dm file 8 byte
aligned.
2024-06-27 19:16:49 +02:00
Tim Moore
ef1438fa25
Modify comment
2024-06-27 19:14:59 +02:00
Tim Moore
e6ec85d078
run format
2024-06-26 10:47:10 +02:00
Tim Moore
9aaeb639e7
AssetFetcher: keep a copy of request headers instead of a reference
...
This was a bug waiting to happen and should always have been a
copy. Fortunately, the new use of the AssetFetcher to resolve external
data for i3dm files provoked a crash in the tests.
2024-06-26 10:38:22 +02:00
Tim Moore
8fc74b6aac
Add all members for ErrorList initializer lists and others
...
gcc / clang is less tolerant than Visual Studio, which lets one leave
off the trailing members of a braced initializer list.
2024-06-26 12:18:26 +02:00
Kevin Ring
aab5cb9031
Merge remote-tracking branch 'origin/main' into i3dm-misc-fixes
2024-06-26 08:46:24 +10:00
Kevin Ring
c7dab324bc
Merge pull request #910 from Ulvesson/fixed_compiler_warnings
...
Fixed build warning - I3dmToGltfConverter.cpp:634:14: error: ‘positio…
2024-06-25 21:04:12 +10:00
Kevin Ring
dd8af15dbe
Formatting, tweaks, CHANGES.md.
2024-06-25 20:51:37 +10:00
Tim Moore
2283f5c380
Add axis argument to Cesium3DTilesContent test code
2024-06-24 15:56:21 +02:00
Tim Moore
bd5a4805ab
Merge remote-tracking branch 'origin/main' into i3dm-misc-fixes
2024-06-24 15:02:17 +02:00
Tim Moore
9c9a5d9dc2
Resolve external data for external i3dm glb content
...
Calling GltfReader::resolveExternalData() during the i3dm conversion
correctly handles relative path references in the .glb payload or in
an external .glb file. Leaving it to
Cesium3DTilesSelection::TilesetContentManager::loadTileContent(),
where external data is resolved for normal 3D Tiles, gets relative
paths wrong.
Resolves #905 .
2024-06-24 14:53:16 +02:00
Kevin Ring
ff96b9b07a
Merge pull request #874 from CesiumGS/forced-assertions
...
Add ability to force assertions
2024-06-21 16:12:56 +10:00
Brian L
74653140f3
Rename to CESIUM_ASSERT
2024-06-20 10:14:38 -06:00
Brian L
91300f9a61
update from main
2024-06-20 09:54:52 -06:00
Tommy Henriks
ee5f635b1d
Log warning and continue. Copy default values to the buffer.
2024-06-20 16:16:55 +02:00
Tommy Wohlfart
67fd8b5259
Fixed build warning - I3dmToGltfConverter.cpp:634:14: error: ‘position.glm::vec<3, double, glm::packed_highp>::x’ may be used uninitialized [-Werror=maybe-uninitialized]
2024-06-19 11:59:48 +02:00
Ashley Rogers
65dda8335d
Respond to review, cut down on stored ellipsoids
2024-06-14 15:33:47 -04:00
Brian L
1f6ac44834
Merge branch 'main' into gltf-ray-intersect
2024-06-12 16:22:01 -06:00
Tim Moore
b48f1381af
Pass up axis to GltfConverters
...
The i3dm converter needs to know the coordinate axis convention of the
tileset in order to correctly construct instance transformations.
Resolves #904 .
2024-06-11 16:36:47 +02:00
Ashley Rogers
f332464b30
Merge with main
2024-06-06 16:57:20 -04:00
Ashley Rogers
d961a40e3d
Remove as many WGS84 defaults as possible.
2024-06-06 16:53:48 -04:00
Kevin Ring
bac574c13d
Lots of changes to support Cesium for Unreal.
2024-06-06 20:57:11 +10:00
Kevin Ring
ca42500d54
Merge remote-tracking branch 'origin/main' into vcpkg-2
2024-06-05 14:06:47 +10:00
Kevin Ring
0e74915a90
Add i3dm tests and fix some bugs.
2024-06-03 10:57:46 +10:00
Brian L
aa95514762
update from main
2024-05-31 12:39:37 -06:00