Commit Graph

208 Commits

Author SHA1 Message Date
Bao Tran c0faaf18dc change file name for batch table to EXT_feature_metadata 2021-06-20 14:51:15 -04:00
Bao Tran 951cb7a23e pass rapidjson::Document for batch table json to metadata upgrader 2021-06-20 14:47:36 -04:00
Bao Tran 6035cc8387 clean up unused headers 2021-06-20 12:11:18 -04:00
Bao Tran 0e1d188636 remove bool getter in feature table view 2021-06-20 11:54:02 -04:00
Bao Tran e1909b3bf7 remove getter for bool array in feature table view 2021-06-20 11:44:15 -04:00
Bao Tran 661db543d2 replace operator[] with get() for PropertyView 2021-06-20 01:40:27 -04:00
Bao Tran 76f2d10ccb test to validate dynamic array of string 2021-06-18 18:44:41 -04:00
Bao Tran 96c49c4529 test fixed array of string 2021-06-18 14:48:29 -04:00
Bao Tran 9a68718dc6 test for dynamic bool array 2021-06-18 11:41:46 -04:00
Bao Tran b6c8047c18 add test to validate fixed bool array 2021-06-17 17:00:49 -04:00
Bao Tran 6300cae267 test to validate dynamic numeric array 2021-06-17 15:26:31 -04:00
Bao Tran 47b891fac8 fix compiler warning 2021-06-17 13:28:02 -04:00
Bao Tran 7ac819dcf5 add test to validate fixed numeric array 2021-06-17 13:07:28 -04:00
Bao Tran 21f44e7a29 test to make sure offset values are sorted 2021-06-16 16:43:35 -04:00
Bao Tran d7c42c559d add test for string validation 2021-06-16 16:11:20 -04:00
Bao Tran 0506eed5c3 add test validation for bool property 2021-06-15 17:11:28 -04:00
Bao Tran 1c2a758274 add more tests to validate metadata bufferview 2021-06-15 15:15:40 -04:00
Bao Tran 3288dc5bca fix compiler warning 2021-06-15 14:51:30 -04:00
Bao Tran 62b89c365d WIP test feature table view to read property correctly 2021-06-15 14:05:26 -04:00
Bao Tran 3363cee7e8 change MetadataPropertyView to PropertyView 2021-06-14 18:35:36 -04:00
Bao Tran bc8dd36951 impl FeatureTableView 2021-06-14 18:30:01 -04:00
Bao Tran 774730381e fix property view when accessing fixed array of boolean 2021-06-08 18:53:11 -04:00
Bao Tran 4ee41a8bf5 fix property view for array of boolean 2021-06-08 18:17:11 -04:00
Bao Tran 15fcfbf7a2 fix compiler error 2021-06-08 11:41:49 -04:00
Bao Tran b1bcfd46c8 fix dynamic array of string 2021-06-07 02:20:40 -04:00
Bao Tran ab56949efa fix string offset array 2021-06-07 00:20:29 -04:00
Bao Tran 5ef1e6b2db upgrade json array of string 2021-06-06 23:11:46 -04:00
Bao Tran b1546b0d7b change order of property type enum 2021-06-03 09:21:13 -04:00
Bao Tran a4a4068e78 add test for upgrading batch table 2021-06-01 19:37:46 -04:00
Bao Tran 8d6d46ef30 test dynamic array of bool 2021-06-01 01:39:00 -04:00
Bao Tran f2e6dfed59 test fixed array of bool 2021-06-01 01:09:36 -04:00
Bao Tran a750fc2f9f impl dynamic array of string test 2021-05-31 20:25:32 -04:00
Bao Tran b9c5c77ed6 WIP template property view 2021-05-31 00:12:31 -04:00
Bao Tran 3dff283062 custom meta array view for property 2021-05-29 21:42:03 -04:00
Bao Tran 3cc40b6ed1 add boolean property view 2021-05-27 18:12:31 -04:00
Bao Tran b457b7db3c format 2021-05-27 15:41:11 -04:00
Bao Tran b7a84cfb61 fix string test 2021-05-27 14:23:55 -04:00
Bao Tran 2b79291e43 fix dynamic array tests 2021-05-27 14:15:57 -04:00
Bao Tran df7427ad2d add tests back again 2021-05-27 13:39:02 -04:00
Bao Tran 077680acae fix out of bound tests 2021-05-27 13:25:10 -04:00
Bao Tran 524306a68c isolate more failed tests 2021-05-27 13:00:47 -04:00
Bao Tran f108442a7f simplify getter for scalar 2021-05-27 12:48:51 -04:00
Bao Tran 6bdaa7d563 isolate failed tests 2021-05-27 12:12:36 -04:00
Bao Tran 9ca931c455 uncomment some failed tests 2021-05-27 11:52:37 -04:00
Bao Tran 5896978de3 isolate failed test 2021-05-27 11:36:17 -04:00
Bao Tran ca668bba47 test for string 2021-05-26 18:25:25 -04:00
Bao Tran f00bb6436e add double dynamic array test 2021-05-26 16:20:16 -04:00
Bao Tran 24b9119169 test dynamic array 2021-05-26 16:17:49 -04:00
Bao Tran e623ca7f54 format 2021-05-26 14:54:50 -04:00
Bao Tran 9634eddeb9 add test for fixed array of other numeric type 2021-05-26 14:53:58 -04:00
Bao Tran 84a01ecd21 format 2021-05-26 14:05:06 -04:00
Bao Tran 3dec7b9c8c fix fixed array doesn't have correct stride 2021-05-26 14:01:48 -04:00
Bao Tran c26a8c065b fix array property getter 2021-05-26 13:18:06 -04:00
Bao Tran e1829afb3a impl fixed and dynamic array 2021-05-26 11:23:24 -04:00
Bao Tran fd2ef64614 default offset buffer type to be uint32_t 2021-05-26 01:30:23 -04:00
Bao Tran 47a120d344 get array and string offset buffer 2021-05-26 01:09:28 -04:00
Bao Tran 474cf356ed format 2021-05-25 23:54:56 -04:00
Bao Tran 5af1880c49 test wrong property format 2021-05-25 23:53:13 -04:00
Bao Tran 40b0bca1f5 test with buffer view stride 2021-05-25 23:21:54 -04:00
Bao Tran b82d1399de check buffer stride 2021-05-25 21:55:15 -04:00
Bao Tran 34a022780b clean up interface 2021-05-25 21:47:46 -04:00
Bao Tran 058da9bd3c simplify PropertyAccessorView 2021-05-25 20:37:20 -04:00
Bao Tran 1c8b6216ab WIP initial support for scalar property type 2021-05-25 18:50:55 -04:00
Bao Tran 5a2b91e853 WIP PropertyView 2021-05-25 16:39:20 -04:00
Kevin Ring 7ec6bdfb80 Formatting. 2021-05-21 09:30:13 +10:00
Kevin Ring 04149ee0c4 Improve test, and hopefully fix Linux compile problems. 2021-05-21 09:28:46 +10:00
Kevin Ring b429342b81 Fix return type. 2021-05-21 08:42:57 +10:00
Kevin Ring b275392038 Formatting. 2021-05-20 21:50:19 +10:00
Kevin Ring 7315cb6e4b Allow use of createAccessorView with a simple lambda. 2021-05-20 21:37:31 +10:00
Kevin Ring 30f22898b1 Feature metadata working well for simple case. 2021-05-17 12:30:09 +10:00
Kevin Ring 8f85fd8bbe WIP conversion of b3dm batch table to EXT_feature_metadata. 2021-05-14 22:28:31 +10:00
Kevin Ring ed42e46d5f Add support for EXT_feature_metadata on Primitives. 2021-05-07 16:18:13 +10:00
Kevin Ring b29b8c64ad EXT_feature_metadata progress. 2021-05-07 15:34:16 +10:00
Kevin Ring 527e6051c1 Fix more code gen problems. 2021-05-06 17:30:39 +10:00
Kevin Ring 8762721d03 Regenerated glTF classes and re-run the formatter.
The only changes are to incorrectly-wrapped comments, now that comments
no longer get incorrectly wrapped.
2021-05-05 16:38:35 +10:00
Marco Hutter 51e43bbd49 Comment fixes for clang formatting 2021-04-29 17:06:34 +02:00
Kevin Ring acd13e2992
Merge pull request #219 from CesiumGS/gltf-writer-tech-debt
Address technical debt in CesiumGltfWriter
2021-04-22 10:27:21 +10:00
Samuel Vargas 00870929ee
Remove extraneous CESIUM_NATIVE_GSL_INCLUDE_DIR from CMakeLists.txt 2021-04-21 16:03:36 -04:00
Kevin Ring 10b0f92a64 Use std::as_const instead of const_cast. 2021-04-20 21:00:36 +10:00
Kevin Ring 3df9f5ef32 Fix test failure. 2021-04-19 10:35:21 +10:00
Kevin Ring 999c382cc1 Merge remote-tracking branch 'origin/main' into gltf-extensions 2021-04-16 16:07:23 +10:00
Kevin Ring e5c5408804 More constier. 2021-04-16 13:18:25 +10:00
Kevin Ring 8aab8bbec2 Don't construct so many GltfReaders.
Also switch to constexpr char* for extension and type names to avoid
static initializer ordering problems.
2021-04-16 12:52:29 +10:00
Samuel Vargas 8070d85023
Merge remote-tracking branch 'origin/main' into gltf-writer 2021-04-15 13:49:04 -04:00
Kevin Ring 02e3be9b03 Merge remote-tracking branch 'origin/main' into gltf-extensions 2021-04-15 21:54:03 +10:00
Kevin Ring 940d8fc8f2 Merge remote-tracking branch 'origin/main' into gltf-extensions 2021-04-15 09:58:01 +10:00
Kevin Ring 94ea03847c Move CesiumJsonReader stuff to the right namespace. 2021-04-14 14:22:22 +10:00
Kevin Ring 88795c0045 Move JsonValue to CesiumUtility. 2021-04-13 23:24:53 +10:00
Jordi Torres 6333b1cb0a First pass of clang tidy
Mainly caching else after return, not using empty() instead of size() == 0, missing const references to avoid copies and removing redundant initializations
2021-04-12 13:22:03 +02:00
Kevin Ring b2d278972a Use ExtensionName, cause it might be different from the type name. 2021-04-08 21:18:02 +10:00
Samuel Vargas dbd975f6d7
Run clang-format on `JsonValue.h` 2021-04-06 14:28:45 -04:00
Samuel Vargas b2ba45f5c1
Add comment explaining std::enable_if 2021-04-06 13:41:56 -04:00
Samuel Vargas b03dac82af
Add trailing newline to misc files [ skip ci ] 2021-04-06 13:07:48 -04:00
Kevin Ring 987ca69614 Support for external glTF extensions. 2021-04-06 21:49:12 +10:00
Kevin Ring 0884fdba27 Don't always report zero-length images as errors. 2021-04-02 12:10:30 +11:00
Samuel Vargas 94c77dd89e
Merge tag 'post-clang-format' into gltf-writer-clang-format
The commit that ran clang-format on the entire codebase and made no other changes.
2021-03-09 16:36:39 -05:00
Shehzan Mohammed 8a2957d32f Run clang format 2021-03-08 20:39:46 -05:00
Samuel Vargas 506f76c34b
Use std::byte for image.cesium.pixelData 2021-03-05 10:04:10 -05:00
Samuel Vargas e5f90d3b16
Add GSL_INCLUDE_DIR to target_include_directories
This is necessary to link against CesiumGltf as we use
gsl/narrow in JsonValue.h
2021-03-05 07:41:24 -05:00
Samuel Vargas 7c19d7d828
Add unittests for JsonValue 2021-03-05 07:41:17 -05:00