root
/
cesium
mirror of https://github.com/CesiumGS/cesium.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

optimize Primitive.prototype.getGeometryInstanceAttributes performance 

Primitive.prototype.getGeometryInstanceAttributes
This commit is contained in:
zhouhai 2023-02-04 09:18:42 +08:00
parent 19cf7d71f7
commit aa82d9a542
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/engine/Source/Scene/Primitive.js
View File

@ -314,7 +314,7 @@ function Primitive(options) {
this._boundingSphereCV = [];
this._boundingSphere2D = [];
this._boundingSphereMorph = [];
this._perInstanceAttributeCache = [];
this._perInstanceAttributeCache = new Map();
this._instanceIds = [];
this._lastPerInstanceAttributeIndex = 0;
@ -2411,6 +2411,11 @@ Primitive.prototype.getGeometryInstanceAttributes = function (id) {
}
//>>includeEnd('debug');
let attributes = this._perInstanceAttributeCache.get(id);
if (defined(attributes)) {
return attributes;
}
let index = -1;
const lastIndex = this._lastPerInstanceAttributeIndex;
const ids = this._instanceIds;
@ -2426,13 +2431,6 @@ Primitive.prototype.getGeometryInstanceAttributes = function (id) {
if (index === -1) {
return undefined;
}
this._lastPerInstanceAttributeIndex = index;
let attributes = this._perInstanceAttributeCache[index];
if (defined(attributes)) {
return attributes;
}
const batchTable = this._batchTable;
const perInstanceAttributeIndices = this._batchTableAttributeIndices;
@ -2453,7 +2451,8 @@ Primitive.prototype.getGeometryInstanceAttributes = function (id) {
createPickIdProperty(this, properties, index);
Object.defineProperties(attributes, properties);
this._perInstanceAttributeCache[index] = attributes;
this._lastPerInstanceAttributeIndex = index;
this._perInstanceAttributeCache.set(id, attributes);
return attributes;
};