Commit Graph

8 Commits

Author SHA1 Message Date
Gabby Getz f309771860 Model readyPromise deprecation and minor loader refactor 2023-03-08 15:58:23 -05:00
Peter Gagliardi 8634e8ab7a Make default exports more consistent 2022-08-15 08:06:09 -04:00
Gabby Getz 31c154a299 Remove when.js and replace with native promises
There were a few areas in Source where a function was assumed to be executed synchronously when a function was resolved. Native Promises however, by spec, will resolve at the end of a frame. There were also some strange handling of promise rejection in imagery providers that I cleaned up a bit in order to make them testable.

- In LabelCollection and EntityCluster, order of execution adjustment where made.
- Added TextureAtlas.addImageSync to support the order of execution fix in LabelCollection
- ArcGisMapServerImageryProvider.readyPromise will not reject if there is a failure unless the request cannot be retried.
- SingleTileImageryProvider.readyPromise will not reject if there is a failure unless the request cannot be retried.

The majority of the changes lie in the Specs, where unresolved promises weren’t being awaited before finishing executions, and where resolved promises are assumed to be synchronous all over the place and needed a good amount of fixes. Another issue which came up was calling Promise.reject in the body of a spec can cause node to halt execution when running via the command line.
2022-03-16 09:38:39 -04:00
Gabby Getz 8143df4436 var -> const/let 2022-01-21 11:26:25 -05:00
Sean Lilley d32fbfd8b6 Fix GltfLoader test timeouts 2021-08-12 18:45:00 -04:00
Sean Lilley a8b70d5085 GltfLoader updates 2021-06-06 19:42:52 -04:00
Sean Lilley 1847ac05f3 Fix path in waitForLoaderProcess.js 2021-04-26 11:54:00 -04:00
Sean Lilley 1818b4f247 Updated from review 2021-04-23 17:19:28 -04:00