Commit Graph

3509 Commits

Author SHA1 Message Date
Matt Schwartz c8b00a4ec7 Improves jsdocs for terainpicker 2025-10-31 09:37:48 -04:00
Matt Schwartz 8e57c5a37c Polishes PR 2025-10-31 00:45:30 -04:00
Matt Schwartz b823e08546 Moves transform computation from terrain picker to terrain mesh 2025-10-30 19:59:40 -04:00
Matt Schwartz 7081df8824 Fixes bug with intersections behind ray 2025-10-30 19:24:33 -04:00
Matt Schwartz fdb8ee42a4 Switch terrain picking data structure to quadtree 2025-10-30 19:02:41 -04:00
Gabby Getz ba5b5d77e8
Merge branch 'main' into sandcastle-build-updates 2025-10-30 18:03:48 -04:00
Luke McKinstry 453b40d6f1
Merge pull request #13004 from CesiumGS/ion-headers
Set headers for URLs proxied from Cesium ion
2025-10-30 18:13:04 +00:00
ggetz b45dead50e Fix ionImageryProvider cache, unit test cleanup 2025-10-30 13:41:25 -04:00
keyboardspecialist e9f2388ffb use primitive transform for inverse rotation matrix to ensure SH works for all datasets 2025-10-30 10:16:36 -05:00
Adam Beili 1d6d5e6570 Cleaner and readable code 2025-10-30 02:07:06 +02:00
Adam Beili f73f2f2b5c Self CR 2025-10-30 01:59:41 +02:00
Adam Beili 6f1349bc09 Suggested CR changes 2025-10-30 01:23:30 +02:00
Matt Schwartz b0f14b30f3 Refactors scene mode change and reset in octree picking 2025-10-29 19:08:15 -04:00
Adam Beili 5d00fca596 Safer implementation, handle edge cases as done previously 2025-10-29 23:29:04 +02:00
Adam Beili 08ecab02d0
Merge branch 'main' into fix-billboard-subregion 2025-10-29 23:05:56 +02:00
keyboardspecialist 72584a27e7 remove unnecessary fromArray 2025-10-29 15:58:49 -05:00
keyboardspecialist f3664c6528 removed extraneous defined check and assignment of rootTransform 2025-10-29 15:53:52 -05:00
keyboardspecialist 9246bb8e3e Merge branch 'main' into gsplat-fixedframe-transform 2025-10-29 15:49:48 -05:00
Matt Schwartz cbfa3cea27 Fixes to globesurfacetile spec 2025-10-29 14:43:15 -04:00
Matt Schwartz 2e3d6b6bf2 Moves ray-AABB intersection tests to utility class 2025-10-29 14:01:23 -04:00
Matt Schwartz 83364cc5a5 Adapts octree for different scene modes 2025-10-29 11:20:41 -04:00
Adam Larkeryd 86049c8fe6 added pickAsync code example to doc 2025-10-29 10:25:55 +09:00
Adam Larkeryd ec3e71b360 changelog 2025-10-29 10:21:56 +09:00
Adam Larkeryd 40bce95af4 test: picks async throws timeout if too slow 2025-10-29 10:12:54 +09:00
Adam Larkeryd ce0c6a79e9 Merge branch 'main' into alark/async-picking 2025-10-29 09:24:56 +09:00
Jeshurun Hembd b222893b2a PR feedback part 1 2025-10-28 18:56:05 -04:00
Jeshurun Hembd 1f737c2d78 PR feedback part 1 2025-10-28 18:08:42 -04:00
Marco Hutter 0ee5670050
Merge pull request #12924 from CesiumGS/fix-draped-imagery-removal
Fix draped imagery removal
2025-10-28 21:26:12 +00:00
ggetz c5ac658738 Minor code cleanup 2025-10-28 14:27:13 -04:00
ggetz 6f6dc355de Set ion headers for ion proxied URLs 2025-10-28 13:53:18 -04:00
Matt Schwartz 9b215be7b7 Minor fix to clear triangles 2025-10-28 12:29:21 -04:00
Matt Schwartz b00b65cee1 Merge remote-tracking branch 'origin/main' into fastPickingWithOctree 2025-10-28 11:52:03 -04:00
Matt Schwartz 1e8d248e34 Move incremental build to worker 2025-10-28 11:20:19 -04:00
Matt Schwartz 63a8371eb6 Incrementally build octree on pick 2025-10-27 23:15:52 -04:00
Matt Schwartz 3af3ef03a2 Marks octree for rebuild on exaggeration changes 2025-10-27 13:04:37 -04:00
Adam Larkeryd 9cfc449c55 Merge branch 'main' into alark/async-picking 2025-10-27 15:16:20 +09:00
Matt Schwartz b1e03247cb Improve memory patterns and simplify function signatures 2025-10-26 21:40:57 -04:00
Matt Schwartz 53fa96bf85 Lazily builds picking octree
WIP - the goal is to only build octrees on tiles
that are picked against. Beyond saving memory and worker time,
this allows us to conservatively rebuild octrees when
vertical exaggeration changes.

TODO: build the octree in a worker task, and fallback to
the default pick strategy while it's being built.
2025-10-26 20:48:50 -04:00
Matt Schwartz 790962d129 Revert changes to RequestErrorEvent.js 2025-10-26 14:38:00 -04:00
jjspace b478c3fb63
rename arguments and functions for clarity 2025-10-24 15:26:49 -04:00
Jeshurun Hembd 61f8dcfeef Clear TODO comments in Cesium3DTilesTerrainGeometryProcessor 2025-10-24 11:22:47 -04:00
Matt Schwartz 5ac1b0757d
Merge pull request #12997 from CesiumGS/react-eslint-warning
Fix eslint warning for react
2025-10-24 14:00:04 +00:00
Adam Larkeryd f02b48a50a pr comment fixes #1 2025-10-24 11:33:39 +09:00
Adam Larkeryd e53c22d09d Merge branch 'main' into alark/async-picking 2025-10-24 09:32:58 +09:00
Jeshurun Hembd d08ce7a58e Move constructors to tops of files 2025-10-23 19:44:40 -04:00
Jeshurun Hembd 2de6dd7ba3 Merge branch 'main' into 3d-tiles-terrain 2025-10-23 18:32:28 -04:00
Jeshurun Hembd 668b8bba24 Update CHANGES.md, clean up whitespace 2025-10-23 18:28:58 -04:00
Jeshurun Hembd 77fb377592 Avoid recomputing keys in ResourceCache 2025-10-23 18:12:51 -04:00
jjspace cc931d222f
don't submit and refresh page on Enter 2025-10-23 15:13:21 -04:00
Matt Schwartz 023b4f2d60 Fixes scratch variable reuse bug 2025-10-23 15:03:53 -04:00
Matt Schwartz f58ea2c51e Add child node after creation in octree 2025-10-23 14:53:10 -04:00
jjspace f843821566
use correct dependencies in hooks 2025-10-23 14:33:41 -04:00
Matt Schwartz a8f7d8f9b8 Fixes bug in octree ray intersection 2025-10-23 14:29:02 -04:00
Matt Schwartz 948e00cfc3 Reverts unit test changes for octree picking
These tests were more like integration tests and would
likely be brittle in the future, and not hard to diagnose.
2025-10-23 14:15:26 -04:00
Matt Schwartz 64ec998897 Refactors octree picking for style and modularity 2025-10-23 14:10:46 -04:00
jjspace b74d62da2a
Merge remote-tracking branch 'origin/main' into sandcastle-build-updates 2025-10-23 12:56:59 -04:00
jjspace 9a83ebdada
override the cesium viewer color-scheme 2025-10-23 11:29:22 -04:00
Jeshurun Hembd e944a82c68 Minor cleanup in Cesium3DTilesTerrainProvider 2025-10-22 22:13:47 -04:00
Jeshurun Hembd c2024630f7 Use async/await in Cesium3DTilesTerrainDataSpec 2025-10-22 14:45:49 -04:00
Gabby Getz 008ff68eab
Merge branch 'main' into billboard-terrain-clip-fix 2025-10-22 11:15:36 -04:00
Adam Larkeryd bf11b3af93 prettier fix 2025-10-22 10:18:32 +09:00
Adam Larkeryd 5c07c4dbbc
Update packages/engine/Source/Scene/PickFramebuffer.js
spelling

Co-authored-by: Matt Schwartz <mzschwartz5@gmail.com>
2025-10-22 09:58:01 +09:00
Adam Larkeryd 2b7861edab
Update packages/engine/Source/Scene/Scene.js
Simplify promise using await

Co-authored-by: Matt Schwartz <mzschwartz5@gmail.com>
2025-10-22 09:49:18 +09:00
Jeshurun Hembd d31a0c3ba7 Fix destructuring in Cesium3DTilesTerrainGeometryProcessor 2025-10-21 18:14:32 -04:00
Matt Schwartz 074acf176a
Merge pull request #12991 from CesiumGS/sandcastle-console-index
Prevent selecting console index in sandcastle
2025-10-21 19:41:28 +00:00
Marco Hutter 9d00201f33 Merge remote-tracking branch 'origin/main' into fix-draped-imagery-removal
# Conflicts:
#	CHANGES.md
2025-10-21 20:36:32 +02:00
Marco Hutter b096d177e5 Undo literal to string change. Add comment. 2025-10-21 20:17:46 +02:00
jjspace 51e39236f6
prevent selecting console index, better render icons 2025-10-21 13:49:43 -04:00
Jeshurun Hembd 2afb7b65b9 Clean up, clarify docs in Cesium3DTilesTerrain classes 2025-10-21 12:19:36 -04:00
Marco Hutter af3625979a Remove unused eslint disable directives 2025-10-21 17:23:23 +02:00
Gabby Getz 359251339c
Merge branch 'main' into billboard-terrain-clip-fix 2025-10-21 11:07:28 -04:00
Adam Larkeryd 4439df1658 Merge branch 'main' into alark/async-picking 2025-10-21 10:49:37 +09:00
Gabby Getz e7916beecc
Merge branch 'main' into edge_line_unique_VAO 2025-10-20 16:39:28 -04:00
Adam Larkeryd c9c27259ac tests for Context readPixels 2025-10-20 14:53:25 +09:00
Adam Larkeryd 2d3be0f559 added more tests 2025-10-20 11:55:05 +09:00
Jeshurun Hembd 470fbdd000 Clean up types in 3d tiles terrain processing 2025-10-17 19:08:10 -04:00
Adam Larkeryd ebaf3e7d20 added SyncSpec 2025-10-17 12:00:26 +09:00
Adam Larkeryd 3a0e0aad04 Merge branch 'main' into alark/async-picking 2025-10-17 10:44:34 +09:00
Jeshurun Hembd 62b5da41fa Merge branch 'main' into 3d-tiles-terrain 2025-10-16 18:15:50 -04:00
Jeshurun Hembd 0ed8a626ba Update 3d tiles terrain sandcastle 2025-10-16 18:09:35 -04:00
Sean Lilley ed6f310138
Merge pull request #12978 from Beilinson/fix-clamped-polygon-picking
Fix clamped polygon picking
2025-10-16 21:33:24 +00:00
jjspace 8104a6445c
Merge pull request #12969 from CesiumGS/terrain-docs
Clean up docs and type checks for terrain providers
2025-10-16 21:14:33 +00:00
Adam Beili b7d4591f74
Merge branch 'main' into fix-clamped-polygon-picking 2025-10-16 23:15:25 +03:00
Adam Beili d0177ce52b Add spec, update CHANGES 2025-10-16 23:09:26 +03:00
Jeshurun Hembd 6d6e0fc92c Fix TerrainEncodingSpec 2025-10-16 13:10:50 -04:00
Jeshurun Hembd bc9981a1a7 Fix optional param doc in TerrainEncoding 2025-10-16 13:02:13 -04:00
Jeshurun Hembd ae3641c8fd Fix types for optional properties in TerrainEncoding 2025-10-16 12:50:12 -04:00
Adam Beili b3e013a010 Unify conditions between pick and regular path 2025-10-16 14:38:13 +03:00
Adam Larkeryd aa140c1a79 added .js for imports 2025-10-16 13:33:05 +09:00
Adam Larkeryd 0d3daff896 avoid test asyncpick if stub 2025-10-16 11:33:12 +09:00
Adam Larkeryd 6872ef2e99 added comment 2025-10-16 11:24:45 +09:00
Adam Larkeryd 8e0ba0c6d3 comments and refactoring 2025-10-16 11:15:46 +09:00
Jeshurun Hembd bc97809deb Merge branch 'terrain-docs' into 3d-tiles-terrain 2025-10-15 15:49:59 -04:00
Jeshurun Hembd fc342685ee Add descriptions, optional param types in TerrainEncoding 2025-10-15 10:26:59 -04:00
Adam Larkeryd f3351b7133 Added test for pixelbuffer and async pick 2025-10-15 14:39:25 +09:00
Daniel Zhong 17b7dd6f67
Merge branch 'main' into edge_line_unique_VAO 2025-10-15 01:28:59 -04:00
danielzhong 06c1335872 fix build test 2025-10-15 00:54:53 -04:00
Adam Larkeryd c0f3fd44fd pickAsync pick first match 2025-10-15 09:56:44 +09:00
Adam Larkeryd 116ef099dd Merge branch 'main' into alark/async-picking 2025-10-15 09:54:47 +09:00
Gabby Getz 80abee3125
Merge branch 'main' into voxel-exaggeration 2025-10-14 16:56:12 -04:00