root
/
druid
mirror of https://github.com/alibaba/druid.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

feat: more support using_index_clause 

1. add identifier support and unit test.
2. add parsing exception and unit test.
3. reuse current parser to parse name.
This commit is contained in:
zchazc 2025-07-17 10:06:46 +08:00
parent ab252eb5fb
commit 6837adf139
No known key found for this signature in database
GPG Key ID: E7894CF9AF1D4CE0
2 changed files with 110 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
core/src/main/java/com/alibaba/druid/sql/dialect/oracle/parser/OracleExprParser.java
View File

@ -1210,9 +1210,12 @@ public class OracleExprParser extends SQLExprParser {
OracleCreateIndexStatement createIndex = new OracleStatementParser(lexer).parseCreateIndex();
using.setIndex(createIndex);
accept(Token.RPAREN);
} else if (lexer.token() == Token.LITERAL_ALIAS) {
SQLName index = new OracleStatementParser(lexer).getExprParser().name();
using.setIndex(index);
} else if (lexer.token() == Token.LITERAL_ALIAS || lexer.token() == Token.IDENTIFIER) {
//https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/constraint.html#GUID-1055EA97-BA6F-4764-A15F-1024FD5B6DFE__CJAGEBIG
using.setIndex(this.name());
} else {
throw new ParserException("syntax error, expect '('/LITERAL_ALIAS/IDENTIFIER, actual " + lexer.token() + " "
+ lexer.info());
}
for (; ; ) {

107
core/src/test/java/com/alibaba/druid/sql/dialect/oracle/parser/OracleUsingIndexTest.java
View File

@ -3,21 +3,122 @@ package com.alibaba.druid.sql.dialect.oracle.parser;
import com.alibaba.druid.DbType;
import com.alibaba.druid.sql.SQLUtils;
import com.alibaba.druid.sql.ast.SQLStatement;
import com.alibaba.druid.sql.ast.statement.SQLAlterTableAddConstraint;
import com.alibaba.druid.sql.ast.statement.SQLAlterTableItem;
import com.alibaba.druid.sql.ast.statement.SQLAlterTableStatement;
import com.alibaba.druid.sql.ast.statement.SQLConstraint;
import com.alibaba.druid.sql.dialect.oracle.ast.stmt.OraclePrimaryKey;
import com.alibaba.druid.sql.dialect.oracle.ast.stmt.OracleUsingIndexClause;
import org.junit.Assert;
import org.junit.Test;
import com.alibaba.druid.sql.parser.ParserException;
import java.util.NoSuchElementException;
public class OracleUsingIndexTest {
@Test
public void testUsingIndex() {
public void testUsingLiteralIndex() {
String sql = "ALTER TABLE \"SC\".\"TB1\"\n" +
"\tADD CONSTRAINT \"PK_XXX\" PRIMARY KEY (\"ID\")\n" +
"\t\tUSING INDEX \"SC\".\"PK_XXX\"\n" +
"\t\tENABLE";
"\t\tUSING INDEX \"SC\".\"PK_XXX\"";
SQLStatement stat = SQLUtils.parseSingleStatement(sql, DbType.oracle,false);
System.out.println(stat);
Assert.assertTrue(stat instanceof SQLAlterTableStatement);
SQLAlterTableItem sqlAlterTableItem = ((SQLAlterTableStatement) stat).getItems().stream().findAny()
.orElseThrow(NoSuchElementException::new);
Assert.assertTrue(sqlAlterTableItem instanceof SQLAlterTableAddConstraint);
SQLConstraint constraint = ((SQLAlterTableAddConstraint) sqlAlterTableItem).getConstraint();
Assert.assertTrue(constraint instanceof OraclePrimaryKey);
OracleUsingIndexClause usingIndexClause = ((OraclePrimaryKey) constraint).getUsing();
Assert.assertEquals("\"SC\".\"PK_XXX\"", usingIndexClause.getIndex().toString());
Assert.assertEquals(sql, stat.toString());
System.out.println("=============");
}
@Test
public void testUsingIndexWithoutSchema() {
String sql = "ALTER TABLE \"SC\".\"TB1\"\n" +
"\tADD CONSTRAINT \"PK_XXX\" PRIMARY KEY (\"ID\")\n" +
"\t\tUSING INDEX \"PK_XXX\"";
SQLStatement stat = SQLUtils.parseSingleStatement(sql, DbType.oracle,false);
System.out.println(stat);
Assert.assertTrue(stat instanceof SQLAlterTableStatement);
SQLAlterTableItem sqlAlterTableItem = ((SQLAlterTableStatement) stat).getItems().stream().findAny()
.orElseThrow(NoSuchElementException::new);
Assert.assertTrue(sqlAlterTableItem instanceof SQLAlterTableAddConstraint);
SQLConstraint constraint = ((SQLAlterTableAddConstraint) sqlAlterTableItem).getConstraint();
Assert.assertTrue(constraint instanceof OraclePrimaryKey);
OracleUsingIndexClause usingIndexClause = ((OraclePrimaryKey) constraint).getUsing();
Assert.assertEquals("\"PK_XXX\"", usingIndexClause.getIndex().toString());
Assert.assertEquals(sql, stat.toString());
System.out.println("=============");
}
@Test
public void testUsingIdentifierIndex() {
String sql = "ALTER TABLE \"SC\".\"TB1\"\n" +
"\tADD CONSTRAINT \"PK_XXX\" PRIMARY KEY (\"ID\")\n" +
"\t\tUSING INDEX SC.PK_XXX";
SQLStatement stat = SQLUtils.parseSingleStatement(sql, DbType.oracle,false);
System.out.println(stat);
Assert.assertTrue(stat instanceof SQLAlterTableStatement);
SQLAlterTableItem sqlAlterTableItem = ((SQLAlterTableStatement) stat).getItems().stream().findAny()
.orElseThrow(NoSuchElementException::new);
Assert.assertTrue(sqlAlterTableItem instanceof SQLAlterTableAddConstraint);
SQLConstraint constraint = ((SQLAlterTableAddConstraint) sqlAlterTableItem).getConstraint();
Assert.assertTrue(constraint instanceof OraclePrimaryKey);
OracleUsingIndexClause usingIndexClause = ((OraclePrimaryKey) constraint).getUsing();
Assert.assertEquals("SC.PK_XXX", usingIndexClause.getIndex().toString());
Assert.assertEquals(sql, stat.toString());
System.out.println("=============");
}
@Test
public void testUsingIdentifierIndexWithoutSchema() {
String sql = "ALTER TABLE \"SC\".\"TB1\"\n" +
"\tADD CONSTRAINT \"PK_XXX\" PRIMARY KEY (\"ID\")\n" +
"\t\tUSING INDEX PK_XXX";
SQLStatement stat = SQLUtils.parseSingleStatement(sql, DbType.oracle,false);
System.out.println(stat);
Assert.assertTrue(stat instanceof SQLAlterTableStatement);
SQLAlterTableItem sqlAlterTableItem = ((SQLAlterTableStatement) stat).getItems().stream().findAny()
.orElseThrow(NoSuchElementException::new);
Assert.assertTrue(sqlAlterTableItem instanceof SQLAlterTableAddConstraint);
SQLConstraint constraint = ((SQLAlterTableAddConstraint) sqlAlterTableItem).getConstraint();
Assert.assertTrue(constraint instanceof OraclePrimaryKey);
OracleUsingIndexClause usingIndexClause = ((OraclePrimaryKey) constraint).getUsing();
Assert.assertEquals("PK_XXX", usingIndexClause.getIndex().toString());
Assert.assertEquals(sql, stat.toString());
System.out.println("=============");
}
@Test
public void testIncompleteUsingIndex() {
String sql = "ALTER TABLE \"SC\".\"TB1\"\n" +
"\tADD CONSTRAINT \"PK_XXX\" PRIMARY KEY (\"ID\")\n" +
"\t\tUSING INDEX";
try {
SQLUtils.parseSingleStatement(sql, DbType.oracle,false);
throw new RuntimeException("not ParserException");
}catch (Throwable e){
Assert.assertTrue(e instanceof ParserException);
Assert.assertEquals(e.getMessage(),"syntax error, expect '('/LITERAL_ALIAS/IDENTIFIER, actual EOF pos 80, line 3, column 14, token EOF");
}
}
@Test
public void testWrongUsingIndex() {
String sql = "ALTER TABLE \"SC\".\"TB1\"\n" +
"\tADD CONSTRAINT \"PK_XXX\" PRIMARY KEY (\"ID\")\n" +
"\t\tUSING INDEX ENABLE";
try {
SQLUtils.parseSingleStatement(sql, DbType.oracle,false);
throw new RuntimeException("not ParserException");
}catch (Throwable e){
Assert.assertTrue(e instanceof ParserException);
Assert.assertEquals(e.getMessage(),"syntax error, expect '('/LITERAL_ALIAS/IDENTIFIER, actual ENABLE pos 87, line 3, column 15, token ENABLE");
}
}
}