From 2a33c1785412075c09f9f55b3e25f2bc995ca461 Mon Sep 17 00:00:00 2001
From: David Lord <davidism@gmail.com>
Date: Thu, 23 Feb 2023 09:28:42 -0800
Subject: [PATCH] deprecate got_first_request property

---
 CHANGES.rst         |  1 +
 src/flask/app.py    | 12 ++++++++++--
 tests/test_basic.py |  1 -
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/CHANGES.rst b/CHANGES.rst
index 049c7f6f..032cdb94 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -23,6 +23,7 @@ Unreleased
 
 -   Importing ``escape`` and ``Markup`` from ``flask`` is deprecated. Import them
     directly from ``markupsafe`` instead. :pr:`4996`
+-   The ``app.got_first_request`` property is deprecated. :pr:`4997`
 -   Use modern packaging metadata with ``pyproject.toml`` instead of ``setup.cfg``.
     :pr:`4947`
 -   Ensure subdomains are applied with nested blueprints. :issue:`4834`
diff --git a/src/flask/app.py b/src/flask/app.py
index 642d75c1..493934d5 100644
--- a/src/flask/app.py
+++ b/src/flask/app.py
@@ -8,7 +8,6 @@ import weakref
 from collections.abc import Iterator as _abc_Iterator
 from datetime import timedelta
 from itertools import chain
-from threading import Lock
 from types import TracebackType
 
 import click
@@ -496,7 +495,6 @@ class Flask(Scaffold):
         # tracks internally if the application already handled at least one
         # request.
         self._got_first_request = False
-        self._before_request_lock = Lock()
 
         # Add a static route using the provided static_url_path, static_host,
         # and static_folder if there is a configured static_folder.
@@ -592,8 +590,18 @@ class Flask(Scaffold):
         """This attribute is set to ``True`` if the application started
         handling the first request.
 
+        .. deprecated:: 2.3
+            Will be removed in Flask 2.4.
+
         .. versionadded:: 0.8
         """
+        import warnings
+
+        warnings.warn(
+            "'got_first_request' is deprecated and will be removed in Flask 2.4.",
+            DeprecationWarning,
+            stacklevel=2,
+        )
         return self._got_first_request
 
     def make_config(self, instance_relative: bool = False) -> Config:
diff --git a/tests/test_basic.py b/tests/test_basic.py
index 9c9d83e7..1add8f01 100644
--- a/tests/test_basic.py
+++ b/tests/test_basic.py
@@ -1657,7 +1657,6 @@ def test_no_setup_after_first_request(app, client):
     def index():
         return "Awesome"
 
-    assert not app.got_first_request
     assert client.get("/").data == b"Awesome"
 
     with pytest.raises(AssertionError) as exc_info: