root
/
flask
mirror of https://github.com/pallets/flask.git
1
0
Fork 0
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #3208 from singingwolfboy/fakesignal-connect-via 

FakeSignal should stub connect_via method
This commit is contained in:
David Lord 2019-05-23 08:22:07 -07:00 committed by GitHub
parent fe41c6c8ae fcf2eb4753
commit 4fe81d7c62
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGES.rst
View File

@ -47,6 +47,8 @@ Unreleased
- The return value from :meth:`cli.load_dotenv` is more consistent - The return value from :meth:`cli.load_dotenv` is more consistent
with the documentation. It will return ``False`` if python-dotenv is with the documentation. It will return ``False`` if python-dotenv is
not installed, or if the given path isn't a file. :issue:`2937` not installed, or if the given path isn't a file. :issue:`2937`
- Signaling support has a stub for the ``connect_via`` method when
the Blinker library is not installed. :pr:`3208`
.. _#2935: https://github.com/pallets/flask/issues/2935 .. _#2935: https://github.com/pallets/flask/issues/2935
.. _#2957: https://github.com/pallets/flask/issues/2957 .. _#2957: https://github.com/pallets/flask/issues/2957

17
flask/signals.py
View File

@ -32,19 +32,18 @@ except ImportError:
self.name = name self.name = name
self.__doc__ = doc self.__doc__ = doc
def send(self, *args, **kwargs):
pass
def _fail(self, *args, **kwargs): def _fail(self, *args, **kwargs):
raise RuntimeError( raise RuntimeError(
"signalling support is unavailable " "Signalling support is unavailable because the blinker"
"because the blinker library is " " library is not installed."
"not installed."
) )
send = lambda *a, **kw: None connect = connect_via = connected_to = temporarily_connected_to = _fail
connect = ( disconnect = _fail
disconnect has_receivers_for = receivers_for = _fail
) = (
has_receivers_for
) = receivers_for = temporarily_connected_to = connected_to = _fail
del _fail del _fail