From 00d7bfda95087297ea4205946092185d77d1a872 Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Thu, 19 Jan 2012 09:27:23 +0200 Subject: [PATCH] projects link added. security specs added --- app/assets/images/Storage-UI.PNG | Bin 0 -> 737 bytes app/views/deploy_keys/index.html.haml | 6 +++ app/views/layouts/_head_panel.html.haml | 4 +- spec/requests/projects_deploy_keys_spec.rb | 2 +- spec/requests/projects_security_spec.rb | 45 +++++++++++++++++++++ spec/requests/tags_spec.rb | 27 ------------- spec/requests/team_members_spec.rb | 2 +- 7 files changed, 55 insertions(+), 31 deletions(-) create mode 100644 app/assets/images/Storage-UI.PNG delete mode 100644 spec/requests/tags_spec.rb diff --git a/app/assets/images/Storage-UI.PNG b/app/assets/images/Storage-UI.PNG new file mode 100644 index 0000000000000000000000000000000000000000..8ab6678de325550c5c504ee383df323f80b5c5d6 GIT binary patch literal 737 zcmV<70v`Q|P)Px#24YJ`L;(K){{a7>y{D4^000SaNLh0L01FcU01FcV0GgZ_00007bV*G`2iyS@ z4Gku_pU>6+00Lo2L_t(Y$FoVK)2g9H#hef9ydN&!oAE~>~_045D`z}BfMd}@;*My%-&>myjYMg z@aLEyoAE9_!;J>Crk>y8oih7jWC9=KO{|50 z8`Z?dvdcJ|nJ+D~Py@b>FRT69+T>8!@9trm0( z&zH_ZW?qVj8C<}Hh0?`nfX;6<$=t+8WH=jp>%%2 z^r&&vmW|ki^Eil;5pgUtFIL9iiw`h`Pw+%-ZdIVhMNe0NzJQ%L9}x?sGga+J951gl zs(b&7#a3FG!X>;`yIzN;-Wj35 zt-4Iy9#bjrwKvi(6R-;x$CM0q%D@00000NkvXXu0mjf+y!5X literal 0 HcmV?d00001 diff --git a/app/views/deploy_keys/index.html.haml b/app/views/deploy_keys/index.html.haml index d3feadb8742..015b818c76b 100644 --- a/app/views/deploy_keys/index.html.haml +++ b/app/views/deploy_keys/index.html.haml @@ -5,6 +5,12 @@ - @keys.each do |key| = render(:partial => 'show', :locals => {:key => key}) +- if @keys.blank? + .notice_holder + %li Deploy Keys do not exist yet. + - if can? current_user, :admin_project, @project + %li You can add a new one by clicking on plus icon + :javascript $('.delete-key').live('ajax:success', function() { $(this).closest('.update-item').fadeOut(); }); diff --git a/app/views/layouts/_head_panel.html.haml b/app/views/layouts/_head_panel.html.haml index 101b411072f..f65f20ea722 100644 --- a/app/views/layouts/_head_panel.html.haml +++ b/app/views/layouts/_head_panel.html.haml @@ -5,8 +5,8 @@ %div.main_links = link_to root_path, :class => "home", :title => "Home" do = image_tag "Home-UI.PNG" - = link_to :back, :title => "Back" do - = image_tag "Arrow-Left-UI.PNG" + = link_to projects_path, :title => "Projects" do + = image_tag "Storage-UI.PNG" - if project_layout .project_name diff --git a/spec/requests/projects_deploy_keys_spec.rb b/spec/requests/projects_deploy_keys_spec.rb index 629c28871a4..580e55229e1 100644 --- a/spec/requests/projects_deploy_keys_spec.rb +++ b/spec/requests/projects_deploy_keys_spec.rb @@ -29,7 +29,7 @@ describe "Projects", "DeployKeys" do end end - describe "New key", :js => true do + describe "New key" do before do visit project_deploy_keys_path(project) click_link "New Deploy Key" diff --git a/spec/requests/projects_security_spec.rb b/spec/requests/projects_security_spec.rb index fb9f3d8cc60..f8942978a46 100644 --- a/spec/requests/projects_security_spec.rb +++ b/spec/requests/projects_security_spec.rb @@ -140,5 +140,50 @@ describe "Projects" do it { project_merge_requests_path(@project).should be_denied_for :user } it { project_merge_requests_path(@project).should be_denied_for :visitor } end + + describe "GET /project_code/repository" do + it { project_repository_path(@project).should be_allowed_for @u1 } + it { project_repository_path(@project).should be_allowed_for @u3 } + it { project_repository_path(@project).should be_denied_for :admin } + it { project_repository_path(@project).should be_denied_for @u2 } + it { project_repository_path(@project).should be_denied_for :user } + it { project_repository_path(@project).should be_denied_for :visitor } + end + + describe "GET /project_code/repository/branches" do + it { branches_project_repository_path(@project).should be_allowed_for @u1 } + it { branches_project_repository_path(@project).should be_allowed_for @u3 } + it { branches_project_repository_path(@project).should be_denied_for :admin } + it { branches_project_repository_path(@project).should be_denied_for @u2 } + it { branches_project_repository_path(@project).should be_denied_for :user } + it { branches_project_repository_path(@project).should be_denied_for :visitor } + end + + describe "GET /project_code/repository/tags" do + it { tags_project_repository_path(@project).should be_allowed_for @u1 } + it { tags_project_repository_path(@project).should be_allowed_for @u3 } + it { tags_project_repository_path(@project).should be_denied_for :admin } + it { tags_project_repository_path(@project).should be_denied_for @u2 } + it { tags_project_repository_path(@project).should be_denied_for :user } + it { tags_project_repository_path(@project).should be_denied_for :visitor } + end + + describe "GET /project_code/hooks" do + it { project_hooks_path(@project).should be_allowed_for @u1 } + it { project_hooks_path(@project).should be_allowed_for @u3 } + it { project_hooks_path(@project).should be_denied_for :admin } + it { project_hooks_path(@project).should be_denied_for @u2 } + it { project_hooks_path(@project).should be_denied_for :user } + it { project_hooks_path(@project).should be_denied_for :visitor } + end + + describe "GET /project_code/files" do + it { files_project_path(@project).should be_allowed_for @u1 } + it { files_project_path(@project).should be_allowed_for @u3 } + it { files_project_path(@project).should be_denied_for :admin } + it { files_project_path(@project).should be_denied_for @u2 } + it { files_project_path(@project).should be_denied_for :user } + it { files_project_path(@project).should be_denied_for :visitor } + end end end diff --git a/spec/requests/tags_spec.rb b/spec/requests/tags_spec.rb deleted file mode 100644 index ff72ab1f890..00000000000 --- a/spec/requests/tags_spec.rb +++ /dev/null @@ -1,27 +0,0 @@ -require 'spec_helper' - -describe "Tags" do - before { login_as :user } - - # describe "GET 'tags/index'" do - # it "should be successful" do - # get 'tags/index' - # response.should be_success - # end - # end - - describe "GET '/tags.json'" do - before do - @project = Factory :project - @project.add_access(@user, :read) - @project.tag_list = 'demo1' - @project.save - visit '/tags.json' - end - - it "should contains tags" do - page.should have_content('demo1') - end -end - -end diff --git a/spec/requests/team_members_spec.rb b/spec/requests/team_members_spec.rb index d949d759cf9..b44f47784c8 100644 --- a/spec/requests/team_members_spec.rb +++ b/spec/requests/team_members_spec.rb @@ -18,7 +18,7 @@ describe "TeamMembers" do end end - describe "New Team member", :js => true do + describe "New Team member" do before do @user_1 = Factory :user visit team_project_path(@project)