From 04f9cef437b65b4a62624936a37a99cfbfb4d61c Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 26 May 2021 12:10:41 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/CODEOWNERS | 8 + ...{feature_flags_tab.vue => empty_state.vue} | 23 +- .../components/feature_flags.vue | 246 ++++++------------ .../javascripts/feature_flags/constants.js | 3 - app/assets/javascripts/feature_flags/index.js | 4 +- .../feature_flags/store/index/actions.js | 34 --- .../store/index/mutation_types.js | 7 - .../feature_flags/store/index/mutations.js | 54 +--- .../feature_flags/store/index/state.js | 9 +- .../feature_flags_user_lists/index/index.js | 25 ++ .../components/file_nav/branch_switcher.vue | 1 - .../file_nav/pipeline_editor_file_nav.vue | 2 +- .../components/runner_filtered_search_bar.vue | 143 ++++++++++ .../runner/components/runner_list.vue | 4 +- app/assets/javascripts/runner/constants.js | 25 ++ .../runner/graphql/get_runners.query.graphql | 4 +- .../runner_list/filtered_search_utils.js | 72 +++++ .../runner/runner_list/runner_list_app.vue | 27 ++ .../user_lists/components/user_lists.vue | 120 +++++++++ .../components/user_lists_table.vue | 0 .../user_lists/store/index/actions.js | 38 +++ .../user_lists/store/index/index.js | 11 + .../user_lists/store/index/mutation_types.js | 10 + .../user_lists/store/index/mutations.js | 37 +++ .../user_lists/store/index/state.js | 10 + .../feature_flags_user_lists_controller.rb | 3 + app/helpers/preferences_helper.rb | 6 +- app/mailers/emails/members.rb | 35 ++- app/mailers/previews/notify_preview.rb | 2 +- app/models/namespace.rb | 3 +- app/models/namespaces/traversal/linear.rb | 12 + app/models/namespaces/traversal/recursive.rb | 5 + app/models/project_statistics.rb | 20 +- app/services/groups/participants_service.rb | 4 +- .../projects/feature_flags/index.html.haml | 2 +- .../feature_flags_user_lists/edit.html.haml | 1 + .../feature_flags_user_lists/index.html.haml | 8 + .../feature_flags_user_lists/new.html.haml | 1 + .../feature_flags_user_lists/show.html.haml | 1 + app/views/shared/nav/_scope_menu.html.haml | 12 +- .../shared/nav/_scope_menu_body.html.haml | 5 + app/views/shared/nav/_sidebar.html.haml | 4 +- ...16175024_service_desk_enabled_projects.yml | 1 - config/routes/project.rb | 2 +- ...083845_add_sha_to_status_check_response.rb | 13 + ...527194900_schedule_calculate_wiki_sizes.rb | 10 +- db/schema_migrations/20210510083845 | 1 + db/structure.sql | 3 +- .../external_pipeline_validation.md | 4 +- doc/administration/operations/unicorn.md | 9 + doc/administration/postgresql/external.md | 1 + doc/api/status_checks.md | 93 +++++++ doc/operations/feature_flags.md | 8 +- doc/user/project/description_templates.md | 30 ++- lib/banzai/reference_parser/issue_parser.rb | 9 +- .../reference_parser/merge_request_parser.rb | 9 +- .../ci/pipeline/chain/validate/external.rb | 4 +- .../menus/project_information_menu.rb | 17 +- lib/sidebars/projects/menus/scope_menu.rb | 21 ++ locale/gitlab.pot | 47 +++- ...eature_flags_user_lists_controller_spec.rb | 33 +++ spec/features/contextual_sidebar_spec.rb | 8 +- .../milestones/gfm_autocomplete_spec.rb | 1 + spec/features/projects/active_tabs_spec.rb | 25 +- ...ser_deletes_feature_flag_user_list_spec.rb | 7 +- .../members/user_requests_access_spec.rb | 7 +- spec/features/projects/navbar_spec.rb | 4 + .../projects/user_uses_shortcuts_spec.rb | 8 +- .../api/schemas/external_validation.json | 4 +- ..._flags_tab_spec.js => empty_state_spec.js} | 43 +-- .../components/feature_flags_spec.js | 145 ++++------- .../feature_flags/store/index/actions_spec.js | 165 +----------- .../store/index/mutations_spec.js | 94 +------ .../runner_filtered_search_bar_spec.js | 135 ++++++++++ .../runner/components/runner_list_spec.js | 26 +- .../runner_list/filtered_search_utils_spec.js | 98 +++++++ .../runner_list/runner_list_app_spec.js | 90 +++++++ .../user_lists/components/user_lists_spec.js | 195 ++++++++++++++ .../components/user_lists_table_spec.js | 4 +- .../user_lists/store/index/actions_spec.js | 203 +++++++++++++++ .../user_lists/store/index/mutations_spec.js | 121 +++++++++ spec/helpers/preferences_helper_spec.rb | 37 +++ .../reference_parser/issue_parser_spec.rb | 10 +- .../merge_request_parser_spec.rb | 4 +- .../pipeline/chain/validate/external_spec.rb | 2 +- .../menus/project_information_menu_spec.rb | 14 + .../projects/menus/scope_menu_spec.rb | 23 ++ spec/mailers/notify_spec.rb | 13 + .../schedule_calculate_wiki_sizes_spec.rb | 60 ----- spec/models/group_spec.rb | 8 + spec/models/namespace_spec.rb | 49 ++-- .../groups/participants_service_spec.rb | 37 +++ spec/support/helpers/feature_flag_helpers.rb | 1 - .../helpers/reference_parser_helpers.rb | 5 + .../navbar_structure_context.rb | 8 + .../namespaces/linear_traversal_examples.rb | 23 ++ .../namespaces/traversal_examples.rb | 16 ++ spec/tooling/danger/changelog_spec.rb | 2 +- .../nav/sidebar/_project.html.haml_spec.rb | 23 +- tooling/danger/changelog.rb | 2 +- 100 files changed, 2179 insertions(+), 897 deletions(-) rename app/assets/javascripts/feature_flags/components/{feature_flags_tab.vue => empty_state.vue} (73%) create mode 100644 app/assets/javascripts/pages/projects/feature_flags_user_lists/index/index.js create mode 100644 app/assets/javascripts/runner/components/runner_filtered_search_bar.vue create mode 100644 app/assets/javascripts/runner/runner_list/filtered_search_utils.js create mode 100644 app/assets/javascripts/user_lists/components/user_lists.vue rename app/assets/javascripts/{feature_flags => user_lists}/components/user_lists_table.vue (100%) create mode 100644 app/assets/javascripts/user_lists/store/index/actions.js create mode 100644 app/assets/javascripts/user_lists/store/index/index.js create mode 100644 app/assets/javascripts/user_lists/store/index/mutation_types.js create mode 100644 app/assets/javascripts/user_lists/store/index/mutations.js create mode 100644 app/assets/javascripts/user_lists/store/index/state.js create mode 100644 app/views/projects/feature_flags_user_lists/index.html.haml create mode 100644 app/views/shared/nav/_scope_menu_body.html.haml create mode 100644 db/migrate/20210510083845_add_sha_to_status_check_response.rb create mode 100644 db/schema_migrations/20210510083845 create mode 100644 doc/administration/operations/unicorn.md create mode 100644 doc/api/status_checks.md rename spec/frontend/feature_flags/components/{feature_flags_tab_spec.js => empty_state_spec.js} (73%) create mode 100644 spec/frontend/runner/components/runner_filtered_search_bar_spec.js create mode 100644 spec/frontend/runner/runner_list/filtered_search_utils_spec.js create mode 100644 spec/frontend/user_lists/components/user_lists_spec.js rename spec/frontend/{feature_flags => user_lists}/components/user_lists_table_spec.js (95%) create mode 100644 spec/frontend/user_lists/store/index/actions_spec.js create mode 100644 spec/frontend/user_lists/store/index/mutations_spec.js create mode 100644 spec/lib/sidebars/projects/menus/scope_menu_spec.rb delete mode 100644 spec/migrations/schedule_calculate_wiki_sizes_spec.rb create mode 100644 spec/services/groups/participants_service_spec.rb create mode 100644 spec/support/shared_examples/namespaces/linear_traversal_examples.rb diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index 4a94f672f0a..eee9b638d78 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -334,3 +334,11 @@ Dangerfile @gl-quality/eng-prod [Application Security] /lib/gitlab/content_security_policy/ @gitlab-com/gl-security/appsec + +[Gitaly] +lib/gitlab/git_access.rb @proglottis @toon @zj-gitlab +lib/gitlab/git_access_*.rb @proglottis @toon @zj-gitlab +ee/lib/ee/gitlab/git_access.rb @proglottis @toon @zj-gitlab +ee/lib/ee/gitlab/git_access_*.rb @proglottis @toon @zj-gitlab +ee/lib/ee/gitlab/checks/** @proglottis @toon @zj-gitlab +lib/gitlab/checks/** @proglottis @toon @zj-gitlab diff --git a/app/assets/javascripts/feature_flags/components/feature_flags_tab.vue b/app/assets/javascripts/feature_flags/components/empty_state.vue similarity index 73% rename from app/assets/javascripts/feature_flags/components/feature_flags_tab.vue rename to app/assets/javascripts/feature_flags/components/empty_state.vue index d0df00e446b..a6de4972bb1 100644 --- a/app/assets/javascripts/feature_flags/components/feature_flags_tab.vue +++ b/app/assets/javascripts/feature_flags/components/empty_state.vue @@ -1,14 +1,10 @@ - - + + diff --git a/app/assets/javascripts/feature_flags/components/feature_flags.vue b/app/assets/javascripts/feature_flags/components/feature_flags.vue index 9aa1accb0f2..d08e8d2b3a1 100644 --- a/app/assets/javascripts/feature_flags/components/feature_flags.vue +++ b/app/assets/javascripts/feature_flags/components/feature_flags.vue @@ -1,5 +1,5 @@ diff --git a/app/assets/javascripts/runner/components/runner_filtered_search_bar.vue b/app/assets/javascripts/runner/components/runner_filtered_search_bar.vue new file mode 100644 index 00000000000..8bcaa5df7b6 --- /dev/null +++ b/app/assets/javascripts/runner/components/runner_filtered_search_bar.vue @@ -0,0 +1,143 @@ + + diff --git a/app/assets/javascripts/runner/components/runner_list.vue b/app/assets/javascripts/runner/components/runner_list.vue index 3d4c1cb43d5..f58f271c9ee 100644 --- a/app/assets/javascripts/runner/components/runner_list.vue +++ b/app/assets/javascripts/runner/components/runner_list.vue @@ -95,8 +95,8 @@ export default { stacked="md" fixed > -