diff --git a/.gitlab/ci/release-environments/main.gitlab-ci.yml b/.gitlab/ci/release-environments/main.gitlab-ci.yml index a8a05965132..31de1a335a2 100644 --- a/.gitlab/ci/release-environments/main.gitlab-ci.yml +++ b/.gitlab/ci/release-environments/main.gitlab-ci.yml @@ -4,7 +4,7 @@ include: inputs: cng_path: 'build/CNG-mirror' - project: 'gitlab-org/quality/pipeline-common' - ref: '8.18.4' + ref: '8.18.5' file: ci/base.gitlab-ci.yml stages: diff --git a/.gitlab/ci/release-environments/security.gitlab-ci.yml b/.gitlab/ci/release-environments/security.gitlab-ci.yml index 0b68cab6e4b..cca5389d88a 100644 --- a/.gitlab/ci/release-environments/security.gitlab-ci.yml +++ b/.gitlab/ci/release-environments/security.gitlab-ci.yml @@ -7,7 +7,7 @@ include: inputs: cng_path: 'charts/components/images' - project: 'gitlab-org/quality/pipeline-common' - ref: '8.18.4' + ref: '8.18.5' file: ci/base.gitlab-ci.yml stages: diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 3cac683eca5..1fefb8eef21 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -3904,7 +3904,6 @@ Layout/LineLength: - 'spec/presenters/packages/helm/index_presenter_spec.rb' - 'spec/presenters/packages/nuget/package_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' - - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' - 'spec/presenters/projects/security/configuration_presenter_spec.rb' - 'spec/presenters/prometheus_alert_presenter_spec.rb' - 'spec/presenters/snippet_blob_presenter_spec.rb' diff --git a/app/assets/javascripts/access_tokens/components/access_token_table_app.vue b/app/assets/javascripts/access_tokens/components/access_token_table_app.vue index d21f94b736f..f28893206da 100644 --- a/app/assets/javascripts/access_tokens/components/access_token_table_app.vue +++ b/app/assets/javascripts/access_tokens/components/access_token_table_app.vue @@ -172,10 +172,6 @@ export default { v-model="currentPage" :per-page="$options.PAGE_SIZE" :total-items="activeAccessTokens.length" - :prev-text="__('Prev')" - :next-text="__('Next')" - :label-next-page="__('Go to next page')" - :label-prev-page="__('Go to previous page')" align="center" class="gl-mt-5" /> diff --git a/app/assets/javascripts/access_tokens/components/inactive_access_token_table_app.vue b/app/assets/javascripts/access_tokens/components/inactive_access_token_table_app.vue index bfb4aac75e8..eb57b778e33 100644 --- a/app/assets/javascripts/access_tokens/components/inactive_access_token_table_app.vue +++ b/app/assets/javascripts/access_tokens/components/inactive_access_token_table_app.vue @@ -114,10 +114,6 @@ export default { v-model="currentPage" :per-page="$options.PAGE_SIZE" :total-items="inactiveAccessTokens.length" - :prev-text="__('Prev')" - :next-text="__('Next')" - :label-next-page="__('Go to next page')" - :label-prev-page="__('Go to previous page')" align="center" class="gl-mt-5" /> diff --git a/app/assets/javascripts/admin/abuse_reports/components/app.vue b/app/assets/javascripts/admin/abuse_reports/components/app.vue index d42ae7c1ba9..ce0972808a4 100644 --- a/app/assets/javascripts/admin/abuse_reports/components/app.vue +++ b/app/assets/javascripts/admin/abuse_reports/components/app.vue @@ -51,10 +51,6 @@ export default { :per-page="pagination.perPage" :total-items="pagination.totalItems" :link-gen="paginationLinkGenerator" - :prev-text="__('Prev')" - :next-text="__('Next')" - :label-next-page="__('Go to next page')" - :label-prev-page="__('Go to previous page')" align="center" class="gl-mt-3" /> diff --git a/app/assets/javascripts/admin/deploy_keys/components/table.vue b/app/assets/javascripts/admin/deploy_keys/components/table.vue index e045a19c97e..bca50af5479 100644 --- a/app/assets/javascripts/admin/deploy_keys/components/table.vue +++ b/app/assets/javascripts/admin/deploy_keys/components/table.vue @@ -30,10 +30,6 @@ export default { ), delete: __('Delete deploy key'), edit: __('Edit deploy key'), - pagination: { - next: __('Next'), - prev: __('Prev'), - }, modal: { title: __('Are you sure?'), body: __('Are you sure you want to delete this deploy key?'), @@ -289,8 +285,6 @@ export default { v-model="page" :per-page="$options.DEFAULT_PER_PAGE" :total-items="totalItems" - :next-text="$options.i18n.pagination.next" - :prev-text="$options.i18n.pagination.prev" align="center" class="gl-mt-5" /> diff --git a/app/assets/javascripts/badges/components/badge_list.vue b/app/assets/javascripts/badges/components/badge_list.vue index 33257e78aa4..adabbf39902 100644 --- a/app/assets/javascripts/badges/components/badge_list.vue +++ b/app/assets/javascripts/badges/components/badge_list.vue @@ -165,10 +165,6 @@ export default { v-model="currentPage" :per-page="$options.PAGE_SIZE" :total-items="badges.length" - :prev-text="__('Prev')" - :next-text="__('Next')" - :label-next-page="__('Go to next page')" - :label-prev-page="__('Go to previous page')" align="center" class="gl-mt-5" /> diff --git a/app/assets/javascripts/ci/runner/components/cells/runner_status_cell.vue b/app/assets/javascripts/ci/runner/components/cells/runner_status_cell.vue index 63957d9b7fc..bcd556f1822 100644 --- a/app/assets/javascripts/ci/runner/components/cells/runner_status_cell.vue +++ b/app/assets/javascripts/ci/runner/components/cells/runner_status_cell.vue @@ -34,12 +34,8 @@ export default { diff --git a/app/assets/javascripts/ci/runner/components/cells/runner_summary_field.vue b/app/assets/javascripts/ci/runner/components/cells/runner_summary_field.vue index 23ea9e735b9..1097c2c7d59 100644 --- a/app/assets/javascripts/ci/runner/components/cells/runner_summary_field.vue +++ b/app/assets/javascripts/ci/runner/components/cells/runner_summary_field.vue @@ -24,7 +24,7 @@ export default { diff --git a/app/assets/javascripts/ci/runner/components/runner_status_badge.vue b/app/assets/javascripts/ci/runner/components/runner_status_badge.vue index 8b775197386..2272d4a757d 100644 --- a/app/assets/javascripts/ci/runner/components/runner_status_badge.vue +++ b/app/assets/javascripts/ci/runner/components/runner_status_badge.vue @@ -122,6 +122,8 @@ export default { :icon="badge.icon" v-bind="$attrs" > - {{ badge.label }} + + {{ badge.label }} + diff --git a/app/assets/javascripts/ci/runner/components/runner_tag.vue b/app/assets/javascripts/ci/runner/components/runner_tag.vue index 3fe09e03001..d7d7f703ee1 100644 --- a/app/assets/javascripts/ci/runner/components/runner_tag.vue +++ b/app/assets/javascripts/ci/runner/components/runner_tag.vue @@ -30,8 +30,8 @@ export default { }, }, methods: { - onResize() { - const { scrollWidth, offsetWidth } = this.$el; + onResize({ target }) { + const { scrollWidth, offsetWidth } = target; this.overflowing = scrollWidth > offsetWidth; }, }, @@ -41,10 +41,11 @@ export default { diff --git a/app/assets/javascripts/ci/runner/components/runner_tags.vue b/app/assets/javascripts/ci/runner/components/runner_tags.vue index 7d762d792a4..2b3070a1426 100644 --- a/app/assets/javascripts/ci/runner/components/runner_tags.vue +++ b/app/assets/javascripts/ci/runner/components/runner_tags.vue @@ -16,6 +16,6 @@ export default { diff --git a/app/assets/javascripts/ci_secure_files/components/secure_files_list.vue b/app/assets/javascripts/ci_secure_files/components/secure_files_list.vue index 874a339ae12..57a325d4546 100644 --- a/app/assets/javascripts/ci_secure_files/components/secure_files_list.vue +++ b/app/assets/javascripts/ci_secure_files/components/secure_files_list.vue @@ -49,10 +49,6 @@ export default { uploadLabel: __('Upload File'), uploadingLabel: __('Uploading...'), noFilesMessage: __('There are no secure files yet.'), - pagination: { - next: __('Next'), - prev: __('Prev'), - }, uploadErrorMessages: { duplicate: __('A file with this name already exists.'), tooLarge: __('File too large. Secure Files must be less than %{limit} MB.'), @@ -281,8 +277,6 @@ export default { v-model="page" :per-page="$options.DEFAULT_PER_PAGE" :total-items="totalItems" - :next-text="$options.i18n.pagination.next" - :prev-text="$options.i18n.pagination.prev" align="center" class="gl-mt-5" /> diff --git a/app/assets/javascripts/clusters_list/components/clusters.vue b/app/assets/javascripts/clusters_list/components/clusters.vue index 77c962e4056..e100d36fc80 100644 --- a/app/assets/javascripts/clusters_list/components/clusters.vue +++ b/app/assets/javascripts/clusters_list/components/clusters.vue @@ -334,8 +334,6 @@ export default { v-model="currentPage" :per-page="clustersPerPage" :total-items="totalClusters" - :prev-text="__('Prev')" - :next-text="__('Next')" align="center" /> diff --git a/app/assets/javascripts/commons/gitlab_ui.js b/app/assets/javascripts/commons/gitlab_ui.js index e0637edd111..29218c6424d 100644 --- a/app/assets/javascripts/commons/gitlab_ui.js +++ b/app/assets/javascripts/commons/gitlab_ui.js @@ -1,6 +1,13 @@ import applyGitLabUIConfig from '@gitlab/ui/dist/config'; import { __, s__, n__ } from '~/locale'; -import { NEXT, PREV } from '~/vue_shared/components/pagination/constants'; +import { + PREV, + NEXT, + LABEL_FIRST_PAGE, + LABEL_PREV_PAGE, + LABEL_NEXT_PAGE, + LABEL_LAST_PAGE, +} from '~/vue_shared/components/pagination/constants'; applyGitLabUIConfig({ translations: { @@ -12,7 +19,15 @@ applyGitLabUIConfig({ 'GlKeysetPagination.prevText': PREV, 'GlKeysetPagination.navigationLabel': s__('Pagination|Pagination'), 'GlKeysetPagination.nextText': NEXT, + + 'GlPagination.labelFirstPage': LABEL_FIRST_PAGE, + 'GlPagination.labelLastPage': LABEL_LAST_PAGE, + 'GlPagination.labelNextPage': LABEL_NEXT_PAGE, 'GlPagination.labelPage': s__('Pagination|Go to page %{page}'), + 'GlPagination.labelPrevPage': LABEL_PREV_PAGE, + 'GlPagination.nextText': NEXT, + 'GlPagination.prevText': PREV, + 'GlCollapsibleListbox.srOnlyResultsLabel': (count) => n__('%d result', '%d results', count), }, }); diff --git a/app/assets/javascripts/deploy_keys/components/app.vue b/app/assets/javascripts/deploy_keys/components/app.vue index 256fdedc7ab..93d7aed9289 100644 --- a/app/assets/javascripts/deploy_keys/components/app.vue +++ b/app/assets/javascripts/deploy_keys/components/app.vue @@ -1,7 +1,7 @@ diff --git a/app/assets/javascripts/vue_shared/components/pagination_links.vue b/app/assets/javascripts/vue_shared/components/pagination_links.vue index 5cfaf95f300..e6bbd962945 100644 --- a/app/assets/javascripts/vue_shared/components/pagination_links.vue +++ b/app/assets/javascripts/vue_shared/components/pagination_links.vue @@ -1,13 +1,5 @@