From 0636ab91ee1fc76b5561d8de1920f36a5cc409cb Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 25 Jul 2024 15:11:46 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../release-environments/main.gitlab-ci.yml | 2 +- .../security.gitlab-ci.yml | 2 +- .rubocop_todo/layout/line_length.yml | 1 - .../components/access_token_table_app.vue | 4 - .../inactive_access_token_table_app.vue | 4 - .../admin/abuse_reports/components/app.vue | 4 - .../admin/deploy_keys/components/table.vue | 6 - .../badges/components/badge_list.vue | 4 - .../components/cells/runner_status_cell.vue | 8 +- .../components/cells/runner_summary_field.vue | 2 +- .../components/runner_job_status_badge.vue | 6 +- .../runner/components/runner_status_badge.vue | 4 +- .../ci/runner/components/runner_tag.vue | 11 +- .../ci/runner/components/runner_tags.vue | 2 +- .../components/secure_files_list.vue | 6 - .../clusters_list/components/clusters.vue | 2 - app/assets/javascripts/commons/gitlab_ui.js | 17 ++- .../deploy_keys/components/app.vue | 10 +- .../components/environments_app.vue | 8 -- .../components/table/members_pagination.vue | 4 - .../javascripts/profile/components/follow.vue | 7 - .../commit_box/info/components/refs_list.vue | 2 +- .../pagination/table_pagination.vue | 20 --- .../components/pagination_links.vue | 14 -- .../instructions/runner_aws_instructions.vue | 10 +- .../instructions/runner_cli_instructions.vue | 28 ++-- .../runner_docker_instructions.vue | 2 +- .../runner_kubernetes_instructions.vue | 2 +- .../components/work_item_labels.vue | 48 +++++-- .../framework/broadcast_messages.scss | 10 +- app/assets/stylesheets/framework/mixins.scss | 2 +- .../page_bundles/_pipeline_mixins.scss | 2 +- .../stylesheets/page_bundles/build.scss | 2 +- .../stylesheets/page_bundles/ci_status.scss | 2 +- .../page_bundles/commit_description.scss | 2 +- .../page_bundles/issuable_list.scss | 2 +- .../page_bundles/merge_conflicts.scss | 2 +- .../page_bundles/merge_requests.scss | 12 +- .../stylesheets/page_bundles/pipeline.scss | 19 --- .../stylesheets/page_bundles/project.scss | 4 +- .../stylesheets/page_bundles/projects.scss | 4 +- .../stylesheets/page_bundles/search.scss | 4 +- .../stylesheets/page_bundles/todos.scss | 4 +- app/assets/stylesheets/page_bundles/tree.scss | 2 +- .../themes/dark_mode_overrides.scss | 2 - .../broadcast_banner_component.html.haml | 3 +- .../pajamas/broadcast_banner_component.rb | 6 +- app/controllers/graphql_controller.rb | 9 +- app/models/deploy_token.rb | 3 +- .../packages/maven/cached_response.rb | 52 +++++++ .../packages/maven/upstream.rb | 3 + .../packages/policies/group.rb | 17 +++ .../packages/policies/group_policy.rb | 41 ++++++ .../nuget/search_results_presenter.rb | 40 ++++-- .../cached_response_uploader.rb | 27 ++++ .../projects/commit/_commit_box.html.haml | 4 +- app/views/shared/_broadcast_message.html.haml | 56 ++------ app/views/shared/icons/_mr_bold.svg | 1 - ...stries_packages_maven_cached_responses.yml | 12 ++ ..._read_virtual_registry_to_deploy_tokens.rb | 9 ++ ...istries_packages_maven_cached_responses.rb | 48 +++++++ db/schema_migrations/20240628112814 | 1 + db/schema_migrations/20240712172152 | 1 + db/structure.sql | 51 ++++++- doc/administration/appearance.md | 4 +- doc/administration/moderate_users.md | 2 +- .../reporting/git_abuse_rate_limit.md | 2 +- .../self_hosted_models/index.md | 2 +- doc/api/search.md | 3 - doc/ci/runners/runners_scope.md | 2 +- .../packages/new_format_development.md | 2 +- .../testing_guide/best_practices.md | 7 + .../end_to_end/rspec_metadata_tests.md | 4 +- ...lue_stream_analytics_aggregated_backend.md | 2 +- .../responding_to_security_incidents.md | 2 +- .../cloud_deployments/auto_devops_with_gke.md | 4 +- doc/topics/autodevops/prepare_deployment.md | 6 +- .../observability_java_tutorial.md | 127 +++++++++++++++++ .../observabillty_java_tutorial.md | 130 +----------------- doc/user/analytics/dora_metrics.md | 2 +- .../offline_deployments/index.md | 2 +- doc/user/profile/notifications.md | 4 +- locale/gitlab.pot | 6 - .../group/transfer_group_spec.rb | 4 + scripts/run-fast-specs.sh | 97 +++++++++++++ spec/bin/sidekiq_cluster_spec.rb | 2 +- .../diagnostic_reports/uploader_smoke_spec.rb | 2 +- .../broadcast_banner_component_spec.rb | 8 +- spec/controllers/graphql_controller_spec.rb | 29 ++++ spec/dot_gitlab_ci/rules_spec.rb | 5 +- spec/factories/deploy_tokens.rb | 2 + .../packages/maven/cached_responses.rb | 23 ++++ .../abuse_reports/components/app_spec.js | 2 +- .../deploy_keys/components/table_spec.js | 2 - .../runner_job_status_badge_spec.js | 8 +- .../ci/runner/components/runner_tag_spec.js | 8 +- .../table/members_pagination_spec.js | 2 +- .../profile/components/follow_spec.js | 2 - .../components/work_item_labels_spec.js | 27 +++- .../linter/inline_javascript_spec.rb | 2 +- .../ci/config/entry/include/rules_spec.rb | 3 +- .../gitlab/graphql/known_operations_spec.rb | 3 +- spec/lib/gitlab/i18n/pluralization_spec.rb | 3 +- .../redis_cluster_validator_spec.rb | 4 +- .../pagination/offset_header_builder_spec.rb | 3 +- spec/lib/remote_development/settings_spec.rb | 2 +- .../concerns/super_sidebar_panel_spec.rb | 3 +- .../packages/maven/cached_response_spec.rb | 88 ++++++++++++ .../packages/maven/upstream_spec.rb | 6 + .../packages/policies/group_policy_spec.rb | 122 ++++++++++++++++ .../nuget/search_results_presenter_spec.rb | 38 ++++- .../graphql/project/merge_requests_spec.rb | 2 +- .../lib/glfm/update_example_snapshots_spec.rb | 2 +- .../lib/glfm/update_specification_spec.rb | 2 +- .../cached_response_uploader_spec.rb | 24 ++++ 115 files changed, 1081 insertions(+), 461 deletions(-) create mode 100644 app/models/virtual_registries/packages/maven/cached_response.rb create mode 100644 app/models/virtual_registries/packages/policies/group.rb create mode 100644 app/policies/virtual_registries/packages/policies/group_policy.rb create mode 100644 app/uploaders/virtual_registries/cached_response_uploader.rb delete mode 100644 app/views/shared/icons/_mr_bold.svg create mode 100644 db/docs/virtual_registries_packages_maven_cached_responses.yml create mode 100644 db/migrate/20240628112814_add_read_virtual_registry_to_deploy_tokens.rb create mode 100644 db/migrate/20240712172152_create_virtual_registries_packages_maven_cached_responses.rb create mode 100644 db/schema_migrations/20240628112814 create mode 100644 db/schema_migrations/20240712172152 create mode 100644 doc/tutorials/observability/observability_java_tutorial.md create mode 100755 scripts/run-fast-specs.sh create mode 100644 spec/factories/virtual_registries/packages/maven/cached_responses.rb create mode 100644 spec/models/virtual_registries/packages/maven/cached_response_spec.rb create mode 100644 spec/policies/virtual_registries/packages/policies/group_policy_spec.rb create mode 100644 spec/uploaders/virtual_registries/cached_response_uploader_spec.rb diff --git a/.gitlab/ci/release-environments/main.gitlab-ci.yml b/.gitlab/ci/release-environments/main.gitlab-ci.yml index a8a05965132..31de1a335a2 100644 --- a/.gitlab/ci/release-environments/main.gitlab-ci.yml +++ b/.gitlab/ci/release-environments/main.gitlab-ci.yml @@ -4,7 +4,7 @@ include: inputs: cng_path: 'build/CNG-mirror' - project: 'gitlab-org/quality/pipeline-common' - ref: '8.18.4' + ref: '8.18.5' file: ci/base.gitlab-ci.yml stages: diff --git a/.gitlab/ci/release-environments/security.gitlab-ci.yml b/.gitlab/ci/release-environments/security.gitlab-ci.yml index 0b68cab6e4b..cca5389d88a 100644 --- a/.gitlab/ci/release-environments/security.gitlab-ci.yml +++ b/.gitlab/ci/release-environments/security.gitlab-ci.yml @@ -7,7 +7,7 @@ include: inputs: cng_path: 'charts/components/images' - project: 'gitlab-org/quality/pipeline-common' - ref: '8.18.4' + ref: '8.18.5' file: ci/base.gitlab-ci.yml stages: diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 3cac683eca5..1fefb8eef21 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -3904,7 +3904,6 @@ Layout/LineLength: - 'spec/presenters/packages/helm/index_presenter_spec.rb' - 'spec/presenters/packages/nuget/package_metadata_presenter_spec.rb' - 'spec/presenters/packages/nuget/packages_metadata_presenter_spec.rb' - - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb' - 'spec/presenters/projects/security/configuration_presenter_spec.rb' - 'spec/presenters/prometheus_alert_presenter_spec.rb' - 'spec/presenters/snippet_blob_presenter_spec.rb' diff --git a/app/assets/javascripts/access_tokens/components/access_token_table_app.vue b/app/assets/javascripts/access_tokens/components/access_token_table_app.vue index d21f94b736f..f28893206da 100644 --- a/app/assets/javascripts/access_tokens/components/access_token_table_app.vue +++ b/app/assets/javascripts/access_tokens/components/access_token_table_app.vue @@ -172,10 +172,6 @@ export default { v-model="currentPage" :per-page="$options.PAGE_SIZE" :total-items="activeAccessTokens.length" - :prev-text="__('Prev')" - :next-text="__('Next')" - :label-next-page="__('Go to next page')" - :label-prev-page="__('Go to previous page')" align="center" class="gl-mt-5" /> diff --git a/app/assets/javascripts/access_tokens/components/inactive_access_token_table_app.vue b/app/assets/javascripts/access_tokens/components/inactive_access_token_table_app.vue index bfb4aac75e8..eb57b778e33 100644 --- a/app/assets/javascripts/access_tokens/components/inactive_access_token_table_app.vue +++ b/app/assets/javascripts/access_tokens/components/inactive_access_token_table_app.vue @@ -114,10 +114,6 @@ export default { v-model="currentPage" :per-page="$options.PAGE_SIZE" :total-items="inactiveAccessTokens.length" - :prev-text="__('Prev')" - :next-text="__('Next')" - :label-next-page="__('Go to next page')" - :label-prev-page="__('Go to previous page')" align="center" class="gl-mt-5" /> diff --git a/app/assets/javascripts/admin/abuse_reports/components/app.vue b/app/assets/javascripts/admin/abuse_reports/components/app.vue index d42ae7c1ba9..ce0972808a4 100644 --- a/app/assets/javascripts/admin/abuse_reports/components/app.vue +++ b/app/assets/javascripts/admin/abuse_reports/components/app.vue @@ -51,10 +51,6 @@ export default { :per-page="pagination.perPage" :total-items="pagination.totalItems" :link-gen="paginationLinkGenerator" - :prev-text="__('Prev')" - :next-text="__('Next')" - :label-next-page="__('Go to next page')" - :label-prev-page="__('Go to previous page')" align="center" class="gl-mt-3" /> diff --git a/app/assets/javascripts/admin/deploy_keys/components/table.vue b/app/assets/javascripts/admin/deploy_keys/components/table.vue index e045a19c97e..bca50af5479 100644 --- a/app/assets/javascripts/admin/deploy_keys/components/table.vue +++ b/app/assets/javascripts/admin/deploy_keys/components/table.vue @@ -30,10 +30,6 @@ export default { ), delete: __('Delete deploy key'), edit: __('Edit deploy key'), - pagination: { - next: __('Next'), - prev: __('Prev'), - }, modal: { title: __('Are you sure?'), body: __('Are you sure you want to delete this deploy key?'), @@ -289,8 +285,6 @@ export default { v-model="page" :per-page="$options.DEFAULT_PER_PAGE" :total-items="totalItems" - :next-text="$options.i18n.pagination.next" - :prev-text="$options.i18n.pagination.prev" align="center" class="gl-mt-5" /> diff --git a/app/assets/javascripts/badges/components/badge_list.vue b/app/assets/javascripts/badges/components/badge_list.vue index 33257e78aa4..adabbf39902 100644 --- a/app/assets/javascripts/badges/components/badge_list.vue +++ b/app/assets/javascripts/badges/components/badge_list.vue @@ -165,10 +165,6 @@ export default { v-model="currentPage" :per-page="$options.PAGE_SIZE" :total-items="badges.length" - :prev-text="__('Prev')" - :next-text="__('Next')" - :label-next-page="__('Go to next page')" - :label-prev-page="__('Go to previous page')" align="center" class="gl-mt-5" /> diff --git a/app/assets/javascripts/ci/runner/components/cells/runner_status_cell.vue b/app/assets/javascripts/ci/runner/components/cells/runner_status_cell.vue index 63957d9b7fc..bcd556f1822 100644 --- a/app/assets/javascripts/ci/runner/components/cells/runner_status_cell.vue +++ b/app/assets/javascripts/ci/runner/components/cells/runner_status_cell.vue @@ -34,12 +34,8 @@ export default { diff --git a/app/assets/javascripts/ci/runner/components/cells/runner_summary_field.vue b/app/assets/javascripts/ci/runner/components/cells/runner_summary_field.vue index 23ea9e735b9..1097c2c7d59 100644 --- a/app/assets/javascripts/ci/runner/components/cells/runner_summary_field.vue +++ b/app/assets/javascripts/ci/runner/components/cells/runner_summary_field.vue @@ -24,7 +24,7 @@ export default { diff --git a/app/assets/javascripts/ci/runner/components/runner_status_badge.vue b/app/assets/javascripts/ci/runner/components/runner_status_badge.vue index 8b775197386..2272d4a757d 100644 --- a/app/assets/javascripts/ci/runner/components/runner_status_badge.vue +++ b/app/assets/javascripts/ci/runner/components/runner_status_badge.vue @@ -122,6 +122,8 @@ export default { :icon="badge.icon" v-bind="$attrs" > - {{ badge.label }} + + {{ badge.label }} + diff --git a/app/assets/javascripts/ci/runner/components/runner_tag.vue b/app/assets/javascripts/ci/runner/components/runner_tag.vue index 3fe09e03001..d7d7f703ee1 100644 --- a/app/assets/javascripts/ci/runner/components/runner_tag.vue +++ b/app/assets/javascripts/ci/runner/components/runner_tag.vue @@ -30,8 +30,8 @@ export default { }, }, methods: { - onResize() { - const { scrollWidth, offsetWidth } = this.$el; + onResize({ target }) { + const { scrollWidth, offsetWidth } = target; this.overflowing = scrollWidth > offsetWidth; }, }, @@ -41,10 +41,11 @@ export default { diff --git a/app/assets/javascripts/ci/runner/components/runner_tags.vue b/app/assets/javascripts/ci/runner/components/runner_tags.vue index 7d762d792a4..2b3070a1426 100644 --- a/app/assets/javascripts/ci/runner/components/runner_tags.vue +++ b/app/assets/javascripts/ci/runner/components/runner_tags.vue @@ -16,6 +16,6 @@ export default { diff --git a/app/assets/javascripts/ci_secure_files/components/secure_files_list.vue b/app/assets/javascripts/ci_secure_files/components/secure_files_list.vue index 874a339ae12..57a325d4546 100644 --- a/app/assets/javascripts/ci_secure_files/components/secure_files_list.vue +++ b/app/assets/javascripts/ci_secure_files/components/secure_files_list.vue @@ -49,10 +49,6 @@ export default { uploadLabel: __('Upload File'), uploadingLabel: __('Uploading...'), noFilesMessage: __('There are no secure files yet.'), - pagination: { - next: __('Next'), - prev: __('Prev'), - }, uploadErrorMessages: { duplicate: __('A file with this name already exists.'), tooLarge: __('File too large. Secure Files must be less than %{limit} MB.'), @@ -281,8 +277,6 @@ export default { v-model="page" :per-page="$options.DEFAULT_PER_PAGE" :total-items="totalItems" - :next-text="$options.i18n.pagination.next" - :prev-text="$options.i18n.pagination.prev" align="center" class="gl-mt-5" /> diff --git a/app/assets/javascripts/clusters_list/components/clusters.vue b/app/assets/javascripts/clusters_list/components/clusters.vue index 77c962e4056..e100d36fc80 100644 --- a/app/assets/javascripts/clusters_list/components/clusters.vue +++ b/app/assets/javascripts/clusters_list/components/clusters.vue @@ -334,8 +334,6 @@ export default { v-model="currentPage" :per-page="clustersPerPage" :total-items="totalClusters" - :prev-text="__('Prev')" - :next-text="__('Next')" align="center" /> diff --git a/app/assets/javascripts/commons/gitlab_ui.js b/app/assets/javascripts/commons/gitlab_ui.js index e0637edd111..29218c6424d 100644 --- a/app/assets/javascripts/commons/gitlab_ui.js +++ b/app/assets/javascripts/commons/gitlab_ui.js @@ -1,6 +1,13 @@ import applyGitLabUIConfig from '@gitlab/ui/dist/config'; import { __, s__, n__ } from '~/locale'; -import { NEXT, PREV } from '~/vue_shared/components/pagination/constants'; +import { + PREV, + NEXT, + LABEL_FIRST_PAGE, + LABEL_PREV_PAGE, + LABEL_NEXT_PAGE, + LABEL_LAST_PAGE, +} from '~/vue_shared/components/pagination/constants'; applyGitLabUIConfig({ translations: { @@ -12,7 +19,15 @@ applyGitLabUIConfig({ 'GlKeysetPagination.prevText': PREV, 'GlKeysetPagination.navigationLabel': s__('Pagination|Pagination'), 'GlKeysetPagination.nextText': NEXT, + + 'GlPagination.labelFirstPage': LABEL_FIRST_PAGE, + 'GlPagination.labelLastPage': LABEL_LAST_PAGE, + 'GlPagination.labelNextPage': LABEL_NEXT_PAGE, 'GlPagination.labelPage': s__('Pagination|Go to page %{page}'), + 'GlPagination.labelPrevPage': LABEL_PREV_PAGE, + 'GlPagination.nextText': NEXT, + 'GlPagination.prevText': PREV, + 'GlCollapsibleListbox.srOnlyResultsLabel': (count) => n__('%d result', '%d results', count), }, }); diff --git a/app/assets/javascripts/deploy_keys/components/app.vue b/app/assets/javascripts/deploy_keys/components/app.vue index 256fdedc7ab..93d7aed9289 100644 --- a/app/assets/javascripts/deploy_keys/components/app.vue +++ b/app/assets/javascripts/deploy_keys/components/app.vue @@ -1,7 +1,7 @@ diff --git a/app/assets/javascripts/vue_shared/components/pagination_links.vue b/app/assets/javascripts/vue_shared/components/pagination_links.vue index 5cfaf95f300..e6bbd962945 100644 --- a/app/assets/javascripts/vue_shared/components/pagination_links.vue +++ b/app/assets/javascripts/vue_shared/components/pagination_links.vue @@ -1,13 +1,5 @@