From 06b63cf514d0e7d28fc8818be4fb02cd05c3b14e Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 20 Sep 2024 15:13:23 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../gitlab/feature_flag_without_actor.yml | 1 - .rubocop_todo/rspec/named_subject.yml | 1 - Gemfile | 2 +- Gemfile.checksum | 4 +- Gemfile.lock | 4 +- Gemfile.next.checksum | 4 +- Gemfile.next.lock | 4 +- .../components/sidebar/commit_block.vue | 2 +- .../sidebar/external_links_block.vue | 2 +- .../components/sidebar/sidebar_detail_row.vue | 7 +- .../components/sidebar/stages_dropdown.vue | 4 +- .../graph/components/linked_pipeline.vue | 5 +- .../components/nav_controls.vue | 2 +- .../components/pipeline_url.vue | 11 +- .../components/new_environment_item.vue | 2 +- .../components/sticky_header.vue | 2 +- .../components/states/squash_before_merge.vue | 2 +- .../issuable_blocked_icon.vue | 4 +- .../components/notes/system_note.vue | 2 +- .../design_notes/toggle_replies_widget.vue | 2 +- .../components/work_item_description.vue | 2 +- app/assets/stylesheets/framework/common.scss | 4 +- .../stylesheets/framework/typography.scss | 1 - .../stylesheets/framework/variables.scss | 4 +- app/assets/stylesheets/utilities.scss | 11 - app/helpers/stat_anchors_helper.rb | 2 +- app/models/concerns/ci/taggable.rb | 2 +- app/services/onboarding/progress_service.rb | 15 - app/views/help/index.html.haml | 6 +- app/views/profiles/emails/index.html.haml | 4 +- app/views/projects/ci/builds/_build.html.haml | 4 +- .../projects/tags/_release_link.html.haml | 2 +- .../empty_states/_merge_requests.html.haml | 10 +- app/workers/all_queues.yml | 9 - .../merge_requests/ensure_prepared_worker.rb | 34 --- .../ensure_merge_requests_prepared.yml | 8 - config/metrics/schema/internal_events.json | 5 +- config/sidekiq_queues.yml | 2 + .../geo/disaster_recovery/index.md | 2 +- doc/ci/jobs/job_rules.md | 2 +- doc/ci/pipelines/index.md | 14 +- doc/ci/yaml/index.md | 4 +- doc/development/advanced_search.md | 17 +- .../contributing/first_contribution/index.md | 2 + .../metric_definition_guide.md | 4 +- .../incident_management/status_page.md | 2 +- doc/topics/autodevops/index.md | 2 +- doc/tutorials/compliance_pipeline/index.md | 8 +- .../create_register_first_runner/index.md | 2 +- .../clusters/connect/new_civo_cluster.md | 2 +- .../clusters/connect/new_gke_cluster.md | 2 +- .../clusters/migrate_to_gitlab_agent.md | 2 +- .../pages_forked_sample_project.md | 2 +- .../pages_new_project_template.md | 2 +- lib/gitlab/internal_events.rb | 9 +- lib/tasks/gitlab/keep_around.rake | 14 +- locale/gitlab.pot | 3 + scripts/internal_events/cli/event_definer.rb | 5 +- .../internal_events/cli/helpers/cli_inputs.rb | 5 + .../cli/helpers/metric_options.rb | 243 ++++++++++----- scripts/internal_events/cli/metric.rb | 57 +++- scripts/internal_events/cli/metric_definer.rb | 9 +- spec/features/groups/empty_states_spec.rb | 8 +- spec/features/groups/merge_requests_spec.rb | 2 +- .../user_sees_empty_state_spec.rb | 9 +- .../projects/pipelines/pipelines_spec.rb | 4 +- ...abel_28d_single_event_additional_props.yml | 22 ++ ...label_7d_single_event_additional_props.yml | 22 ++ .../scripts/internal_events/new_metrics.yml | 29 +- .../components/nav_controls_spec.js | 2 +- spec/helpers/stat_anchors_helper_spec.rb | 2 +- spec/lib/gitlab/internal_events_spec.rb | 18 ++ .../instrumentations/redis_hll_metric_spec.rb | 8 + .../cli/helpers/metric_options_spec.rb | 279 ++++++++++++++++++ .../internal_events/cli/metric_spec.rb | 135 +++++++++ spec/scripts/internal_events/cli_spec.rb | 163 ++++++++-- .../ci/runners/update_runner_service_spec.rb | 26 +- .../onboarding/progress_service_spec.rb | 48 --- .../update_statistics_service_spec.rb | 6 - .../onboarding_progress_shared_examples.rb | 20 -- spec/tasks/gitlab/keep_around_rake_spec.rb | 10 - .../ensure_prepared_worker_spec.rb | 59 ---- .../onboarding/issue_created_worker_spec.rb | 8 +- .../pipeline_created_worker_spec.rb | 8 +- .../onboarding/progress_worker_spec.rb | 7 +- .../onboarding/user_added_worker_spec.rb | 8 +- 86 files changed, 1020 insertions(+), 489 deletions(-) delete mode 100644 app/services/onboarding/progress_service.rb delete mode 100644 app/workers/merge_requests/ensure_prepared_worker.rb delete mode 100644 config/feature_flags/development/ensure_merge_requests_prepared.yml create mode 100644 spec/fixtures/scripts/internal_events/metrics/label_28d_single_event_additional_props.yml create mode 100644 spec/fixtures/scripts/internal_events/metrics/label_7d_single_event_additional_props.yml create mode 100644 spec/scripts/internal_events/cli/helpers/metric_options_spec.rb create mode 100644 spec/scripts/internal_events/cli/metric_spec.rb delete mode 100644 spec/services/onboarding/progress_service_spec.rb delete mode 100644 spec/support/shared_examples/services/onboarding_progress_shared_examples.rb delete mode 100644 spec/workers/merge_requests/ensure_prepared_worker_spec.rb diff --git a/.rubocop_todo/gitlab/feature_flag_without_actor.yml b/.rubocop_todo/gitlab/feature_flag_without_actor.yml index 1d9feedd44d..6f57316c204 100644 --- a/.rubocop_todo/gitlab/feature_flag_without_actor.yml +++ b/.rubocop_todo/gitlab/feature_flag_without_actor.yml @@ -93,7 +93,6 @@ Gitlab/FeatureFlagWithoutActor: - 'app/workers/delete_user_worker.rb' - 'app/workers/loose_foreign_keys/cleanup_worker.rb' - 'app/workers/members/expiring_worker.rb' - - 'app/workers/merge_requests/ensure_prepared_worker.rb' - 'app/workers/packages/debian/cleanup_dangling_package_files_worker.rb' - 'app/workers/projects/refresh_build_artifacts_size_statistics_worker.rb' - 'app/workers/prune_old_events_worker.rb' diff --git a/.rubocop_todo/rspec/named_subject.yml b/.rubocop_todo/rspec/named_subject.yml index a72c233962c..5450f8901a9 100644 --- a/.rubocop_todo/rspec/named_subject.yml +++ b/.rubocop_todo/rspec/named_subject.yml @@ -3503,7 +3503,6 @@ RSpec/NamedSubject: - 'spec/workers/merge_request_mergeability_check_worker_spec.rb' - 'spec/workers/merge_requests/close_issue_worker_spec.rb' - 'spec/workers/merge_requests/create_pipeline_worker_spec.rb' - - 'spec/workers/merge_requests/ensure_prepared_worker_spec.rb' - 'spec/workers/merge_requests/mergeability_check_batch_worker_spec.rb' - 'spec/workers/merge_requests/update_head_pipeline_worker_spec.rb' - 'spec/workers/merge_worker_spec.rb' diff --git a/Gemfile b/Gemfile index f9507d71e4e..f7d1a2a8740 100644 --- a/Gemfile +++ b/Gemfile @@ -275,7 +275,7 @@ gem 'rack', '~> 2.2.9' # rubocop:todo Gemfile/MissingFeatureCategory gem 'rack-timeout', '~> 0.7.0', require: 'rack/timeout/base' # rubocop:todo Gemfile/MissingFeatureCategory group :puma do - gem 'puma', '= 6.4.3', require: false, feature_category: :shared + gem 'puma', '= 6.4.0', require: false, feature_category: :shared gem 'sd_notify', '~> 0.1.0', require: false # rubocop:todo Gemfile/MissingFeatureCategory end diff --git a/Gemfile.checksum b/Gemfile.checksum index 9a832b189e9..3e842d87855 100644 --- a/Gemfile.checksum +++ b/Gemfile.checksum @@ -525,8 +525,8 @@ {"name":"pry-rails","version":"0.3.9","platform":"ruby","checksum":"468662575abb6b67f4a9831219f99290d5eae7bf186e64dd810d0a3e4a8cc4b1"}, {"name":"pry-shell","version":"0.6.4","platform":"ruby","checksum":"ad024882d29912b071a7de65ebea538b242d2dc1498c60c7c2352ef94769f208"}, {"name":"public_suffix","version":"6.0.1","platform":"ruby","checksum":"61d44e1cab5cbbbe5b31068481cf16976dd0dc1b6b07bd95617ef8c5e3e00c6f"}, -{"name":"puma","version":"6.4.3","platform":"java","checksum":"373fcfacacaafd0f5a24db18cb99b3f2decb5c5316470169852559aa80adc8ab"}, -{"name":"puma","version":"6.4.3","platform":"ruby","checksum":"24a4645c006811d83f2480057d1f54a96e7627b6b90e1c99b260b9dc630eb43e"}, +{"name":"puma","version":"6.4.0","platform":"java","checksum":"eb27679e9e665882bab85dfa84704b0615b4f77cec46de014f05b90a5ab36cfe"}, +{"name":"puma","version":"6.4.0","platform":"ruby","checksum":"d5dda11362744df9f4694708a62e3cfddf72eba7498c16016ebbb30f106712f9"}, {"name":"pyu-ruby-sasl","version":"0.0.3.3","platform":"ruby","checksum":"5683a6bc5738db5a1bf5ceddeaf545405fb241b4184dd4f2587e679a7e9497e5"}, {"name":"raabro","version":"1.4.0","platform":"ruby","checksum":"d4fa9ff5172391edb92b242eed8be802d1934b1464061ae5e70d80962c5da882"}, {"name":"racc","version":"1.6.2","platform":"java","checksum":"0880781e7dfde09e665d0b6160b583e01ed52fcc2955d7891447d33c2d1d2cf1"}, diff --git a/Gemfile.lock b/Gemfile.lock index 77b8f4cfafe..d53bdcfd28e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1439,7 +1439,7 @@ GEM tty-markdown tty-prompt public_suffix (6.0.1) - puma (6.4.3) + puma (6.4.0) nio4r (~> 2.0) pyu-ruby-sasl (0.0.3.3) raabro (1.4.0) @@ -2220,7 +2220,7 @@ DEPENDENCIES pry-byebug pry-rails (~> 0.3.9) pry-shell (~> 0.6.4) - puma (= 6.4.3) + puma (= 6.4.0) rack (~> 2.2.9) rack-attack (~> 6.7.0) rack-cors (~> 2.0.1) diff --git a/Gemfile.next.checksum b/Gemfile.next.checksum index 8bc64605f24..82cf983104a 100644 --- a/Gemfile.next.checksum +++ b/Gemfile.next.checksum @@ -535,8 +535,8 @@ {"name":"psych","version":"5.1.2","platform":"java","checksum":"1dd68dc609eddbc884e6892e11da942e16f7256bd30ebde9d35449d43043a6fe"}, {"name":"psych","version":"5.1.2","platform":"ruby","checksum":"337322f58fc2bf24827d2b9bd5ab595f6a72971867d151bb39980060ea40a368"}, {"name":"public_suffix","version":"6.0.1","platform":"ruby","checksum":"61d44e1cab5cbbbe5b31068481cf16976dd0dc1b6b07bd95617ef8c5e3e00c6f"}, -{"name":"puma","version":"6.4.3","platform":"java","checksum":"373fcfacacaafd0f5a24db18cb99b3f2decb5c5316470169852559aa80adc8ab"}, -{"name":"puma","version":"6.4.3","platform":"ruby","checksum":"24a4645c006811d83f2480057d1f54a96e7627b6b90e1c99b260b9dc630eb43e"}, +{"name":"puma","version":"6.4.0","platform":"java","checksum":"eb27679e9e665882bab85dfa84704b0615b4f77cec46de014f05b90a5ab36cfe"}, +{"name":"puma","version":"6.4.0","platform":"ruby","checksum":"d5dda11362744df9f4694708a62e3cfddf72eba7498c16016ebbb30f106712f9"}, {"name":"pyu-ruby-sasl","version":"0.0.3.3","platform":"ruby","checksum":"5683a6bc5738db5a1bf5ceddeaf545405fb241b4184dd4f2587e679a7e9497e5"}, {"name":"raabro","version":"1.4.0","platform":"ruby","checksum":"d4fa9ff5172391edb92b242eed8be802d1934b1464061ae5e70d80962c5da882"}, {"name":"racc","version":"1.6.2","platform":"java","checksum":"0880781e7dfde09e665d0b6160b583e01ed52fcc2955d7891447d33c2d1d2cf1"}, diff --git a/Gemfile.next.lock b/Gemfile.next.lock index 2fc0d79838b..0803c24836a 100644 --- a/Gemfile.next.lock +++ b/Gemfile.next.lock @@ -1456,7 +1456,7 @@ GEM psych (5.1.2) stringio public_suffix (6.0.1) - puma (6.4.3) + puma (6.4.0) nio4r (~> 2.0) pyu-ruby-sasl (0.0.3.3) raabro (1.4.0) @@ -2246,7 +2246,7 @@ DEPENDENCIES pry-byebug pry-rails (~> 0.3.9) pry-shell (~> 0.6.4) - puma (= 6.4.3) + puma (= 6.4.0) rack (~> 2.2.9) rack-attack (~> 6.7.0) rack-cors (~> 2.0.1) diff --git a/app/assets/javascripts/ci/job_details/components/sidebar/commit_block.vue b/app/assets/javascripts/ci/job_details/components/sidebar/commit_block.vue index c647ee29577..699ef7d974e 100644 --- a/app/assets/javascripts/ci/job_details/components/sidebar/commit_block.vue +++ b/app/assets/javascripts/ci/job_details/components/sidebar/commit_block.vue @@ -39,7 +39,7 @@ export default { {{ __('in') }} - !{{ mergeRequest.iid }} diff --git a/app/assets/javascripts/ci/job_details/components/sidebar/external_links_block.vue b/app/assets/javascripts/ci/job_details/components/sidebar/external_links_block.vue index e5f72d9a629..1aa973870a2 100644 --- a/app/assets/javascripts/ci/job_details/components/sidebar/external_links_block.vue +++ b/app/assets/javascripts/ci/job_details/components/sidebar/external_links_block.vue @@ -23,7 +23,7 @@ export default { :href="externalLink.url" target="_blank" rel="noopener noreferrer nofollow" - class="!gl-text-blue-600" + class="!gl-text-link" > {{ externalLink.label }} diff --git a/app/assets/javascripts/ci/job_details/components/sidebar/sidebar_detail_row.vue b/app/assets/javascripts/ci/job_details/components/sidebar/sidebar_detail_row.vue index 4f3c78e34d7..b2e99992a8b 100644 --- a/app/assets/javascripts/ci/job_details/components/sidebar/sidebar_detail_row.vue +++ b/app/assets/javascripts/ci/job_details/components/sidebar/sidebar_detail_row.vue @@ -41,12 +41,7 @@ export default {