root
/
gitlab-ce
mirror of https://gitlab.com/free-releases/gitlab-ce.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Add latest changes from gitlab-org/gitlab@master

This commit is contained in:
GitLab Bot 2024-10-29 21:26:13 +00:00
parent df697c947a
commit 07fffa9f23
256 changed files with 437 additions and 943 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.rubocop_todo/database/avoid_using_pluck_without_limit.yml
View File

@ -139,7 +139,6 @@ Database/AvoidUsingPluckWithoutLimit:
- 'ee/app/services/approval_rules/params_filtering_service.rb'
- 'ee/app/services/click_house/data_ingestion/ci_finished_builds_sync_service.rb'
- 'ee/app/services/ee/groups/destroy_service.rb'
- 'ee/app/services/ee/search/global_service.rb'
- 'ee/app/services/epics/update_dates_service.rb'
- 'ee/app/services/gitlab_subscriptions/preview_billable_user_change_service.rb'
- 'ee/app/services/security/merge_request_security_report_generation_service.rb'

1
.rubocop_todo/gemspec/add_runtime_dependency.yml
View File

@ -1,3 +1,4 @@
---
# Cop supports --autocorrect.
Gemspec/AddRuntimeDependency:
Details: grace period

1
.rubocop_todo/gitlab/documentation_links/link.yml
View File

@ -25,7 +25,6 @@ Gitlab/DocumentationLinks/Link:
- 'ee/app/helpers/vulnerabilities_helper.rb'
- 'ee/app/models/integrations/github.rb'
- 'ee/app/presenters/ee/merge_request_presenter.rb'
- 'ee/app/presenters/gitlab_subscriptions/trials/duo_enterprise_status_widget_presenter.rb'
- 'ee/lib/api/managed_licenses.rb'
- 'ee/lib/ee/gitlab/namespace_storage_size_error_message.rb'
- 'ee/lib/gitlab/checks/secrets_check.rb'

1
.rubocop_todo/gitlab/namespaced_class.yml
View File

@ -408,7 +408,6 @@ Gitlab/NamespacedClass:
- 'app/presenters/group_clusterable_presenter.rb'
- 'app/presenters/group_member_presenter.rb'
- 'app/presenters/instance_clusterable_presenter.rb'
- 'app/presenters/issue_email_participant_presenter.rb'
- 'app/presenters/issue_presenter.rb'
- 'app/presenters/label_presenter.rb'
- 'app/presenters/member_presenter.rb'

1
.rubocop_todo/layout/extra_spacing.yml
View File

@ -14,5 +14,4 @@ Layout/ExtraSpacing:
- 'ee/spec/services/app_sec/fuzzing/api/ci_configuration_create_service_spec.rb'
- 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb'
- 'spec/lib/gitlab/database/background_migration/batch_optimizer_spec.rb'
- 'spec/lib/gitlab/database/no_new_tables_with_gitlab_main_schema_spec.rb'
- 'spec/lib/gitlab/database/reindexing/index_selection_spec.rb'

1
.rubocop_todo/layout/first_hash_element_indentation.yml
View File

@ -70,7 +70,6 @@ Layout/FirstHashElementIndentation:
- 'spec/lib/gitlab/import_export/members_mapper_spec.rb'
- 'spec/lib/gitlab/instrumentation_helper_spec.rb'
- 'spec/lib/gitlab/metrics/subscribers/action_cable_spec.rb'
- 'spec/lib/gitlab/sidekiq_migrate_jobs_spec.rb'
- 'spec/lib/gitlab/workhorse_spec.rb'
- 'spec/lib/mattermost/team_spec.rb'
- 'spec/lib/peek/views/redis_detailed_spec.rb'

3
.rubocop_todo/layout/line_break_after_final_mixin.yml
View File

@ -7,8 +7,6 @@ Layout/LineBreakAfterFinalMixin:
- 'app/models/alert_management/metric_image.rb'
- 'app/models/integrations/pushover.rb'
- 'app/models/integrations/telegram.rb'
- 'app/models/plan_limits.rb'
- 'app/models/project_feature_usage.rb'
- 'app/models/protected_branch/merge_access_level.rb'
- 'app/models/protected_branch/push_access_level.rb'
- 'app/policies/project_member_policy.rb'
@ -63,7 +61,6 @@ Layout/LineBreakAfterFinalMixin:
- 'ee/app/models/approval_project_rules_protected_branch.rb'
- 'ee/app/models/approval_rules/approval_group_rule.rb'
- 'ee/app/models/approval_rules/approval_group_rules_protected_branch.rb'
- 'ee/app/models/namespace_limit.rb'
- 'ee/app/models/vulnerabilities/scanner.rb'
- 'ee/app/models/vulnerabilities/statistic.rb'
- 'ee/app/services/ee/ip_restrictions/update_service.rb'

1
.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
View File

@ -402,7 +402,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'lib/gitlab/config_checker/external_database_checker.rb'
- 'lib/gitlab/database/background_migration/batched_migration_runner.rb'
- 'lib/gitlab/database/decomposition/migrate.rb'
- 'lib/gitlab/database/dictionary.rb'
- 'lib/gitlab/database/gitlab_schema.rb'
- 'lib/gitlab/database/migration_helpers/wraparound_vacuum_helpers.rb'
- 'lib/gitlab/database/migrations/pg_backend_pid.rb'

5
.rubocop_todo/layout/line_length.yml
View File

@ -367,7 +367,6 @@ Layout/LineLength:
- 'app/presenters/instance_clusterable_presenter.rb'
- 'app/presenters/merge_request_presenter.rb'
- 'app/presenters/packages/composer/packages_presenter.rb'
- 'app/presenters/packages/conan/package_presenter.rb'
- 'app/presenters/project_clusterable_presenter.rb'
- 'app/presenters/project_presenter.rb'
- 'app/presenters/snippet_blob_presenter.rb'
@ -584,7 +583,6 @@ Layout/LineLength:
- 'config/initializers/zz_metrics.rb'
- 'config/routes.rb'
- 'config/routes/admin.rb'
- 'config/routes/api.rb'
- 'config/routes/group.rb'
- 'config/routes/import.rb'
- 'config/routes/project.rb'
@ -2610,7 +2608,6 @@ Layout/LineLength:
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/merge_mr_when_pipline_is_blocked_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/trigger_matrix_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/runner/register_runner_spec.rb'
- 'qa/qa/specs/features/ee/api/2_plan/epics_milestone_dates_spec.rb'
- 'qa/qa/specs/features/ee/api/3_create/wiki/group_wiki_repository_storage_move_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/2_plan/burndown_chart/burndown_chart_spec.rb'
@ -2637,7 +2634,6 @@ Layout/LineLength:
- 'qa/qa/specs/features/ee/browser_ui/3_create/repository/merge_with_code_owner_in_subgroup_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_http_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/3_create/repository/pull_mirroring_over_ssh_with_key_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/3_create/repository/restrict_push_protected_branch_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/4_verify/transient/merge_trains_transient_bug_spec.rb'
@ -4498,7 +4494,6 @@ Layout/LineLength:
- 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb'
- 'spec/workers/container_expiration_policy_worker_spec.rb'
- 'spec/workers/create_pipeline_worker_spec.rb'
- 'spec/workers/dependency_proxy/image_ttl_group_policy_worker_spec.rb'
- 'spec/workers/deployments/update_environment_worker_spec.rb'
- 'spec/workers/disallow_two_factor_for_subgroups_worker_spec.rb'
- 'spec/workers/email_receiver_worker_spec.rb'

1
.rubocop_todo/lint/constant_definition_in_block.yml
View File

@ -31,7 +31,6 @@ Lint/ConstantDefinitionInBlock:
- 'lib/tasks/gitlab/db.rake'
- 'lib/tasks/gitlab/db/validate_config.rake'
- 'lib/tasks/gitlab/docs/compile_deprecations.rake'
- 'lib/tasks/gitlab/docs/compile_windows.rake'
- 'lib/tasks/gitlab/graphql.rake'
- 'lib/tasks/gitlab/refresh_project_statistics_build_artifacts_size.rake'
- 'lib/tasks/gitlab/snippets.rake'

4
.rubocop_todo/lint/missing_cop_enable_directive.yml
View File

@ -67,10 +67,8 @@ Lint/MissingCopEnableDirective:
- 'ee/app/graphql/types/ci/code_coverage_activity_type.rb'
- 'ee/app/graphql/types/ci/code_coverage_summary_type.rb'
- 'ee/app/graphql/types/ci/code_quality_degradation_type.rb'
- 'ee/app/graphql/types/ci/minutes/namespace_monthly_usage_type.rb'
- 'ee/app/graphql/types/ci/minutes/project_monthly_usage_type.rb'
- 'ee/app/graphql/types/dast/profile_cadence_type.rb'
- 'ee/app/graphql/types/scan_type.rb'
- 'ee/app/graphql/types/scanned_resource_type.rb'
- 'ee/app/graphql/types/security_report_summary_section_type.rb'
- 'ee/app/graphql/types/security_report_summary_type.rb'
@ -105,7 +103,6 @@ Lint/MissingCopEnableDirective:
- 'ee/app/graphql/types/vulnerable_dependency_type.rb'
- 'ee/app/graphql/types/vulnerable_kubernetes_resource_type.rb'
- 'ee/app/graphql/types/vulnerable_package_type.rb'
- 'ee/app/services/ee/ci/queue/build_queue_service.rb'
- 'ee/app/workers/ci/runners/stale_group_runners_prune_cron_worker.rb'
- 'ee/lib/api/ldap_group_links.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb'
@ -131,5 +128,4 @@ Lint/MissingCopEnableDirective:
- 'lib/unnested_in_filters/dsl.rb'
- 'qa/qa/scenario/test/integration/registry_with_cdn.rb'
- 'spec/benchmarks/banzai_benchmark.rb'
- 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb'
- 'spec/support/capybara.rb'

273
.rubocop_todo/lint/redundant_cop_disable_directive.yml
View File

@ -1,108 +1,31 @@
---
# Cop supports --autocorrect.
Lint/RedundantCopDisableDirective:
# Offense count: 573
# Offense count: 230
# Temporarily disabled due to too many offenses
Enabled: false
Exclude:
- 'app/controllers/concerns/enforces_two_factor_authentication.rb'
- 'app/controllers/concerns/issuable_actions.rb'
- 'app/controllers/concerns/preview_markdown.rb'
- 'app/controllers/concerns/renders_notes.rb'
- 'app/controllers/concerns/web_hooks/hook_log_actions.rb'
- 'app/controllers/groups/autocomplete_sources_controller.rb'
- 'app/controllers/groups/labels_controller.rb'
- 'app/controllers/groups/milestones_controller.rb'
- 'app/controllers/profiles/notifications_controller.rb'
- 'app/controllers/projects/merge_requests/diffs_controller.rb'
- 'app/controllers/projects/tags_controller.rb'
- 'app/finders/autocomplete/move_to_project_finder.rb'
- 'app/finders/autocomplete/routes_finder.rb'
- 'app/finders/autocomplete/users_finder.rb'
- 'app/finders/ci/daily_build_group_report_results_finder.rb'
- 'app/finders/ci/runner_jobs_finder.rb'
- 'app/finders/users_finder.rb'
- 'app/graphql/gitlab_schema.rb'
- 'app/graphql/resolvers/ci/pipeline_job_artifacts_resolver.rb'
- 'app/graphql/resolvers/concerns/caching_array_resolver.rb'
- 'app/graphql/resolvers/labels_resolver.rb'
- 'app/graphql/resolvers/work_item_references_resolver.rb'
- 'app/graphql/types/base_enum.rb'
- 'app/graphql/types/board_list_type.rb'
- 'app/graphql/types/ci/catalog/resources/components/input_type.rb'
- 'app/graphql/types/ci/catalog/resources/verification_level_enum.rb'
- 'app/graphql/types/ci/runner_web_url_edge.rb'
- 'app/graphql/types/commit_signatures/verification_status_enum.rb'
- 'app/graphql/types/issuables/labels/search_field_list_enum.rb'
- 'app/graphql/types/packages/helm/dependency_type.rb'
- 'app/graphql/types/projects/service_type_enum.rb'
- 'app/helpers/diff_helper.rb'
- 'app/helpers/lazy_image_tag_helper.rb'
- 'app/helpers/search_helper.rb'
- 'app/helpers/sidebars_helper.rb'
- 'app/models/bulk_import.rb'
- 'app/models/clusters/cluster.rb'
- 'app/models/compare.rb'
- 'app/models/concerns/cascading_namespace_setting_attribute.rb'
- 'app/models/concerns/cascading_project_setting_attribute.rb'
- 'app/models/concerns/from_except.rb'
- 'app/models/concerns/from_intersect.rb'
- 'app/models/concerns/from_union.rb'
- 'app/models/concerns/issuable.rb'
- 'app/models/concerns/redis_cacheable.rb'
- 'app/models/merge_request_diff_commit.rb'
- 'app/models/ml/model_version.rb'
- 'app/models/user.rb'
- 'app/models/wiki_page/meta.rb'
- 'app/models/work_items/type.rb'
- 'app/policies/issue_policy.rb'
- 'app/presenters/ci/build_runner_presenter.rb'
- 'app/presenters/dev_ops_report/metric_presenter.rb'
- 'app/serializers/diffs_entity.rb'
- 'app/serializers/fork_namespace_entity.rb'
- 'app/services/boards/base_items_list_service.rb'
- 'app/services/ci/job_artifacts/destroy_batch_service.rb'
- 'app/services/ci/register_job_service.rb'
- 'app/services/ci/retry_job_service.rb'
- 'app/services/ci/runners/bulk_delete_runners_service.rb'
- 'app/services/database/consistency_check_service.rb'
- 'app/services/design_management/copy_design_collection/copy_service.rb'
- 'app/services/groups/destroy_service.rb'
- 'app/services/groups/import_export/import_service.rb'
- 'app/services/import/placeholder_references/push_service.rb'
- 'app/services/issuable_base_service.rb'
- 'app/services/issues/export_csv_service.rb'
- 'app/services/issues/referenced_merge_requests_service.rb'
- 'app/services/labels/transfer_service.rb'
- 'app/services/members/projects/creator_service.rb'
- 'app/services/members/standard_member_builder.rb'
- 'app/services/packages/rpm/repository_metadata/build_xml_base_service.rb'
- 'app/services/projects/auto_devops/disable_service.rb'
- 'app/services/projects/open_issues_count_service.rb'
- 'app/services/releases/create_service.rb'
- 'app/services/releases/update_service.rb'
- 'app/services/users/activate_service.rb'
- 'app/services/web_hook_service.rb'
- 'app/uploaders/object_storage/cdn/google_ip_cache.rb'
- 'app/services/work_items/data_sync/clone_service.rb'
- 'app/services/work_items/data_sync/move_service.rb'
- 'app/workers/authorized_project_update/user_refresh_over_user_range_worker.rb'
- 'app/workers/ci/track_failed_build_worker.rb'
- 'app/workers/concerns/application_worker.rb'
- 'app/workers/create_note_diff_file_worker.rb'
- 'app/workers/database/batched_background_migration/execution_worker.rb'
- 'app/workers/import_issues_csv_worker.rb'
- 'app/workers/incident_management/process_alert_worker_v2.rb'
- 'app/workers/members/expiring_email_notification_worker.rb'
- 'app/workers/merge_worker.rb'
- 'app/workers/new_merge_request_worker.rb'
- 'app/workers/remove_unaccepted_member_invites_worker.rb'
- 'app/workers/run_pipeline_schedule_worker.rb'
- 'config/initializers/fog_google_list_objects_match_glob_support.rb'
- 'config/initializers/grape_validators.rb'
- 'config/initializers/sprockets_patch.rb'
- 'config/initializers/warden.rb'
- 'config/initializers/wikicloth_redos_patch.rb'
- 'config/initializers/wikicloth_ruby_3_patch.rb'
- 'config/routes/api.rb'
- 'db/migrate/20240701145111_add_namespace_import_users_table.rb'
- 'db/migrate/20240829163210_create_instance_integrations_table.rb'
- 'db/post_migrate/20231017064317_swap_columns_for_ci_pipeline_variables_pipeline_id_bigint.rb'
@ -128,11 +51,7 @@ Lint/RedundantCopDisableDirective:
- 'db/post_migrate/20240430015514_swap_columns_for_p_ci_builds_user_id.rb'
- 'db/post_migrate/20240902014331_sync_fk_referencing_p_ci_pipelines.rb'
- 'db/post_migrate/20240917143249_partition_ci_build_trace_metadata3.rb'
- 'ee/app/controllers/ee/admin/application_settings_controller.rb'
- 'ee/app/controllers/ee/groups/group_members_controller.rb'
- 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb'
- 'ee/app/controllers/groups/analytics/productivity_analytics_controller.rb'
- 'ee/app/controllers/groups/todos_controller.rb'
- 'ee/app/finders/epics/with_issues_finder.rb'
- 'ee/app/finders/geo/registry_finder.rb'
- 'ee/app/finders/groups/users_finder.rb'
@ -140,60 +59,10 @@ Lint/RedundantCopDisableDirective:
- 'ee/app/finders/search/projects_finder.rb'
- 'ee/app/finders/status_page/incident_comments_finder.rb'
- 'ee/app/finders/status_page/incidents_finder.rb'
- 'ee/app/graphql/resolvers/analytics/contribution_analytics/contributions_resolver.rb'
- 'ee/app/graphql/types/boards/epic_list_type.rb'
- 'ee/app/graphql/types/ci/minutes/namespace_monthly_usage_type.rb'
- 'ee/app/graphql/types/incident_management/oncall_rotation_active_period_input_type.rb'
- 'ee/app/graphql/types/product_analytics/category_enum.rb'
- 'ee/app/graphql/types/product_analytics/state_enum.rb'
- 'ee/app/graphql/types/sbom/source_type_enum.rb'
- 'ee/app/graphql/types/scan_type.rb'
- 'ee/app/graphql/types/vulnerability_request_type.rb'
- 'ee/app/helpers/ee/boards_helper.rb'
- 'ee/app/helpers/projects/on_demand_scans_helper.rb'
- 'ee/app/models/ai/ai_resource/concerns/noteable.rb'
- 'ee/app/models/approver.rb'
- 'ee/app/models/approver_group.rb'
- 'ee/app/models/ci/finished_build_ch_sync_event.rb'
- 'ee/app/models/dast/branch.rb'
- 'ee/app/models/ee/epic.rb'
- 'ee/app/models/ee/group.rb'
- 'ee/app/models/ee/merge_request.rb'
- 'ee/app/models/ee/project.rb'
- 'ee/app/models/ee/user.rb'
- 'ee/app/models/ee/vulnerability.rb'
- 'ee/app/models/geo_node.rb'
- 'ee/app/models/protected_environments/approval_rules/summarizable.rb'
- 'ee/app/models/requirements_management/requirement.rb'
- 'ee/app/models/vulnerabilities/finding.rb'
- 'ee/app/serializers/dashboard_environments_serializer.rb'
- 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb'
- 'ee/app/services/analytics/cycle_analytics/data_loader_service.rb'
- 'ee/app/services/approval_rules/user_rules_destroy_service.rb'
- 'ee/app/services/dora/aggregate_scores_service.rb'
- 'ee/app/services/ee/boards/issues/list_service.rb'
- 'ee/app/services/ee/ci/queue/build_queue_service.rb'
- 'ee/app/services/ee/notification_recipients/builder/base.rb'
- 'ee/app/services/security/ingestion/tasks/ingest_vulnerabilities/mark_resolved_as_detected.rb'
- 'ee/app/services/security/scan_result_policies/sync_any_merge_request_rules_service.rb'
- 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb'
- 'ee/app/services/search/zoekt/routing_service.rb'
- 'ee/app/services/security/token_revocation_service.rb'
- 'ee/app/services/software_license_policies/bulk_create_scan_result_policy_service.rb'
- 'ee/app/workers/ee/issuable_export_csv_worker.rb'
- 'ee/app/workers/members_destroyer/clean_up_group_protected_branch_rules_worker.rb'
- 'ee/app/workers/scan_security_report_secrets_worker.rb'
- 'ee/app/workers/security/orchestration_policy_rule_schedule_worker.rb'
- 'ee/app/workers/security/scan_execution_policies/create_pipeline_worker.rb'
- 'ee/app/workers/vulnerabilities/mark_dropped_as_resolved_worker.rb'
- 'ee/db/fixtures/development/93_vsd_overview_counts.rb'
- 'ee/db/geo/migrate/20210504143244_add_verification_to_merge_request_diff_registry.rb'
- 'ee/lib/analytics/merge_request_metrics_calculator.rb'
- 'ee/lib/api/admin/search/migrations.rb'
- 'ee/lib/api/audit_events.rb'
- 'ee/lib/api/dora/metrics.rb'
- 'ee/lib/ee/api/entities/analytics/code_review/merge_request.rb'
- 'ee/lib/ee/api/helpers.rb'
- 'ee/lib/ee/api/helpers/internal_helpers.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_dismissal_reason_in_vulnerability_reads.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_missing_vulnerability_dismissal_details.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_zoekt_replicas.rb'
@ -202,62 +71,21 @@ Lint/RedundantCopDisableDirective:
- 'ee/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition.rb'
- 'ee/lib/ee/gitlab/background_migration/populate_denormalized_columns_for_sbom_occurrences.rb'
- 'ee/lib/ee/gitlab/background_migration/purge_stale_security_scans.rb'
- 'ee/lib/ee/gitlab/event_store.rb'
- 'ee/lib/ee/gitlab/usage_data.rb'
- 'ee/lib/elastic/latest/git_class_proxy.rb'
- 'ee/lib/gitlab/analytics/type_of_work/tasks_by_type.rb'
- 'ee/lib/gitlab/duo/developments/feature_flag_enabler.rb'
- 'ee/lib/gitlab/status_page/storage/object.rb'
- 'ee/lib/langsmith/run_helpers.rb'
- 'ee/spec/controllers/concerns/gitlab_subscriptions/seat_count_alert_spec.rb'
- 'ee/spec/controllers/concerns/routable_actions_spec.rb'
- 'ee/spec/factories/package_metadata/pm_licenses.rb'
- 'ee/spec/features/groups/settings/domain_verification_spec.rb'
- 'ee/spec/features/projects/mirror_spec.rb'
- 'ee/spec/features/projects/pipelines/user_sees_security_tab_spec.rb'
- 'ee/spec/features/trials/lead_creation_form_validation_spec.rb'
- 'ee/spec/helpers/ee/releases_helper_spec.rb'
- 'ee/spec/lib/banzai/filter/references/iterations_cadence_reference_filter_spec.rb'
- 'ee/spec/lib/cloud_connector/self_signed/access_data_reader_spec.rb'
- 'ee/spec/lib/code_suggestions/instructions_extractor_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/backfill_missing_vulnerability_dismissal_details_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/delete_orphaned_transferred_project_approval_rules_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/populate_denormalized_columns_for_sbom_occurrences_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/purge_security_scans_with_empty_finding_data_spec.rb'
- 'ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb'
- 'ee/spec/lib/gitlab/elastic/client_spec.rb'
- 'ee/spec/lib/gitlab/geo/log_helpers_spec.rb'
- 'ee/spec/lib/gitlab/llm/completions/chat_real_requests_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_secure_pipelines_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_user_merge_requests_for_projects_with_applied_scan_result_policies_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb'
- 'ee/spec/requests/api/vulnerability_findings_spec.rb'
- 'ee/spec/requests/git_http_geo_spec.rb'
- 'ee/spec/serializers/vulnerabilities/external_issue_link_entity_spec.rb'
- 'ee/spec/services/security/merge_reports_service_spec.rb'
- 'ee/spec/support/shared_examples/features/dashboard_saml_reauth_banner_shared_examples.rb'
- 'ee/spec/support/shared_examples/models/elasticsearch_indexed_container_shared_examples.rb'
- 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb'
- 'ee/spec/views/admin/users/show.html.haml_spec.rb'
- 'lib/api/api.rb'
- 'lib/api/ci/variables.rb'
- 'lib/api/commit_statuses.rb'
- 'lib/api/entities/issuable_time_stats.rb'
- 'lib/api/entities/tag.rb'
- 'lib/api/helpers.rb'
- 'lib/api/issue_links.rb'
- 'lib/api/submodules.rb'
- 'lib/backup/options.rb'
- 'lib/bulk_imports/pipeline/runner.rb'
- 'lib/container_registry/tag.rb'
- 'lib/event_filter.rb'
- 'lib/feature.rb'
- 'lib/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb'
- 'lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher.rb'
- 'lib/gitlab/analytics/cycle_analytics/base_query_builder.rb'
- 'lib/gitlab/analytics/cycle_analytics/records_fetcher.rb'
- 'lib/gitlab/application_context.rb'
- 'lib/gitlab/auth/current_user_mode.rb'
- 'lib/gitlab/background_migration/backfill_desired_sharding_key_partition_job.rb'
- 'lib/gitlab/background_migration/backfill_epic_basic_fields_to_work_item_record.rb'
@ -297,7 +125,6 @@ Lint/RedundantCopDisableDirective:
- 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb'
- 'lib/gitlab/background_migration/update_workspaces_config_version.rb'
- 'lib/gitlab/background_migration/update_workspaces_config_version3.rb'
- 'lib/gitlab/cache/request_cache.rb'
- 'lib/gitlab/ci/ansi2json/parser.rb'
- 'lib/gitlab/ci/build/artifacts/metadata/entry.rb'
- 'lib/gitlab/ci/config/external/mapper/verifier.rb'
@ -309,7 +136,6 @@ Lint/RedundantCopDisableDirective:
- 'lib/gitlab/ci/reports/test_suite.rb'
- 'lib/gitlab/ci/reports/test_suite_summary.rb'
- 'lib/gitlab/cleanup/personal_access_tokens.rb'
- 'lib/gitlab/data_builder/pipeline.rb'
- 'lib/gitlab/database/consistency_checker.rb'
- 'lib/gitlab/database/gitlab_schema.rb'
- 'lib/gitlab/database/migration.rb'
@ -318,63 +144,12 @@ Lint/RedundantCopDisableDirective:
- 'lib/gitlab/database/migrations/observers/query_log.rb'
- 'lib/gitlab/database/migrations/runner_backoff/migration_helpers.rb'
- 'lib/gitlab/database/migrations/squasher.rb'
- 'lib/gitlab/diff/file.rb'
- 'lib/gitlab/diff/file_collection/paginated_diffs.rb'
- 'lib/gitlab/diff/pair_selector.rb'
- 'lib/gitlab/diff/parser.rb'
- 'lib/gitlab/diff/rendered/notebook/diff_file_helper.rb'
- 'lib/gitlab/encrypted_incoming_email_command.rb'
- 'lib/gitlab/encrypted_redis_command.rb'
- 'lib/gitlab/encrypted_service_desk_email_command.rb'
- 'lib/gitlab/encrypted_smtp_command.rb'
- 'lib/gitlab/error_tracking/processor/sidekiq_processor.rb'
- 'lib/gitlab/file_detector.rb'
- 'lib/gitlab/git/commit.rb'
- 'lib/gitlab/git/patches/collection.rb'
- 'lib/gitlab/github_import/markdown_text.rb'
- 'lib/gitlab/github_import/user_finder.rb'
- 'lib/gitlab/graphql/pagination/keyset/connection.rb'
- 'lib/gitlab/health_checks/metric.rb'
- 'lib/gitlab/health_checks/probes/status.rb'
- 'lib/gitlab/health_checks/result.rb'
- 'lib/gitlab/lfs_token.rb'
- 'lib/gitlab/middleware/release_env.rb'
- 'lib/gitlab/object_hierarchy.rb'
- 'lib/gitlab/pagination/keyset/column_order_definition.rb'
- 'lib/gitlab/pagination/keyset/pager.rb'
- 'lib/gitlab/patch/old_redis_cache_store.rb'
- 'lib/gitlab/patch/redis_cache_store.rb'
- 'lib/gitlab/profiler.rb'
- 'lib/gitlab/project_search_results.rb'
- 'lib/gitlab/rack_attack/user_allowlist.rb'
- 'lib/gitlab/redis/hll.rb'
- 'lib/gitlab/search/sort_options.rb'
- 'lib/gitlab/popen/runner.rb'
- 'lib/gitlab/seeders/ci/runner/runner_fleet_seeder.rb'
- 'lib/gitlab/sidekiq_config/cli_methods.rb'
- 'lib/gitlab/slash_commands/issue_search.rb'
- 'lib/gitlab/slash_commands/result.rb'
- 'lib/gitlab/tracking.rb'
- 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric.rb'
- 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb'
- 'lib/gitlab/usage/metrics/instrumentations/numbers_metric.rb'
- 'lib/gitlab/usage_data.rb'
- 'lib/gitlab/usage_data_queries.rb'
- 'lib/gitlab/verify/ci_secure_files.rb'
- 'lib/gitlab/x509/signature.rb'
- 'lib/tasks/gitlab/cleanup.rake'
- 'lib/tasks/gitlab/seed/group_seed.rake'
- 'qa/qa/resource/user_runners.rb'
- 'qa/qa/service/docker_run/gitlab_runner.rb'
- 'qa/qa/specs/features/ee/browser_ui/10_govern/create_merge_request_with_secure_spec.rb'
- 'qa/qa/vendor/one_password/cli.rb'
- 'rubocop/cop/gettext/static_identifier.rb'
- 'rubocop/cop/gitlab/feature_available_usage.rb'
- 'rubocop/cop/migration/add_reference.rb'
- 'rubocop/cop/rake/require.rb'
- 'rubocop/cop/rspec/factory_bot/inline_association.rb'
- 'rubocop/cop/static_translation_definition.rb'
- 'rubocop/feature_categories.rb'
- 'rubocop/formatter/todo_formatter.rb'
- 'scripts/failed_tests.rb'
- 'scripts/feature_flags/used-feature-flags'
- 'scripts/generate_rspec_pipeline.rb'
@ -382,20 +157,9 @@ Lint/RedundantCopDisableDirective:
- 'scripts/security-harness'
- 'scripts/setup/generate-as-if-foss-env.rb'
- 'scripts/verify-tff-mapping'
- 'sidekiq_cluster/cli.rb'
- 'sidekiq_cluster/sidekiq_cluster.rb'
- 'spec/components/previews/pajamas/banner_component_preview.rb'
- 'spec/controllers/groups/milestones_controller_spec.rb'
- 'spec/controllers/profiles/two_factor_auths_controller_spec.rb'
- 'spec/controllers/projects/milestones_controller_spec.rb'
- 'spec/features/environments/environments_folder_spec.rb'
- 'spec/features/groups/participants_autocomplete_spec.rb'
- 'spec/features/issues/discussion_lock_spec.rb'
- 'spec/features/issues/user_edits_issue_spec.rb'
- 'spec/features/merge_request/user_edits_mr_spec.rb'
- 'spec/frontend/fixtures/merge_requests.rb'
- 'spec/lib/backup/manager_spec.rb'
- 'spec/lib/gitlab/avatar_cache_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_finding_id_in_vulnerabilities_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_missing_ci_cd_settings_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_root_storage_statistics_fork_storage_sizes_spec.rb'
@ -412,32 +176,13 @@ Lint/RedundantCopDisableDirective:
- 'spec/lib/gitlab/database/health_status/indicators/wal_rate_spec.rb'
- 'spec/lib/gitlab/database/load_balancing/transaction_leaking_spec.rb'
- 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb'
- 'spec/lib/gitlab/diff/rendered/notebook/diff_file_helper_spec.rb'
- 'spec/lib/gitlab/doorkeeper_secret_storing/secret/pbkdf2_sha512_spec.rb'
- 'spec/lib/gitlab/doorkeeper_secret_storing/token/pbkdf2_sha512_spec.rb'
- 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb'
- 'spec/lib/gitlab/git/tree_spec.rb'
- 'spec/lib/gitlab/import_export/project/relation_saver_spec.rb'
- 'spec/lib/gitlab/memory/watchdog/configurator_spec.rb'
- 'spec/lib/gitlab/merge_requests/message_generator_spec.rb'
- 'spec/lib/gitlab/metrics/exporter/base_exporter_spec.rb'
- 'spec/lib/gitlab/namespaced_session_store_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb'
- 'spec/lib/gitlab/quick_actions/dsl_spec.rb'
- 'spec/lib/gitlab/redis/multi_store_spec.rb'
- 'spec/lib/gitlab/search/abuse_detection_spec.rb'
- 'spec/lib/gitlab/shard_health_cache_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb'
- 'spec/lib/omni_auth/strategies/jwt_spec.rb'
- 'spec/migrations/db/post_migrate/20240319005754_swap_columns_for_upstream_pipeline_id_between_ci_builds_and_ci_pipelines_spec.rb'
- 'spec/models/ci/build_trace_chunk_spec.rb'
- 'spec/models/concerns/encrypted_user_password_spec.rb'
- 'spec/models/concerns/triggerable_hooks_spec.rb'
- 'spec/presenters/packages/pypi/simple_index_presenter_spec.rb'
- 'spec/presenters/packages/pypi/simple_package_versions_presenter_spec.rb'
- 'spec/requests/api/alert_management_alerts_spec.rb'
- 'spec/requests/api/graphql/ci/config_spec.rb'
- 'spec/requests/projects/releases_controller_spec.rb'
- 'spec/scripts/duo_chat/reporter_spec.rb'
- 'spec/services/alert_management/metric_images/upload_service_spec.rb'
@ -447,17 +192,9 @@ Lint/RedundantCopDisableDirective:
- 'spec/support/helpers/database/multiple_databases_helpers.rb'
- 'spec/support/helpers/graphql_helpers.rb'
- 'spec/support/helpers/migrations_helpers/vulnerabilities_findings_helper.rb'
- 'spec/support/helpers/snowplow_helpers.rb'
- 'spec/support/helpers/wait_for_requests.rb'
- 'spec/support/shared_examples/features/editable_merge_request_shared_examples.rb'
- 'spec/support/shared_examples/features/milestone_editing_shared_examples.rb'
- 'spec/support/shared_examples/lib/gitlab/regex_shared_examples.rb'
- 'spec/support/shared_examples/models/boards/listable_shared_examples.rb'
- 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb'
- 'spec/support/shared_examples/models/concerns/protected_ref_access_shared_examples.rb'
- 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb'
- 'spec/support/shared_examples/models/packages/debian/distribution_key_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb'
- 'tooling/danger/ignored_model_columns.rb'
- 'tooling/danger/sidekiq_queues.rb'
- 'tooling/danger/stable_branch.rb'

5
.rubocop_todo/lint/to_enum_arguments.yml
View File

@ -1,5 +0,0 @@
---
Lint/ToEnumArguments:
Exclude:
- 'lib/gitlab/ci/trace/stream.rb'
- 'spec/lib/gitlab/ci/trace/section_parser_spec.rb'

1
.rubocop_todo/lint/unused_method_argument.yml
View File

@ -183,7 +183,6 @@ Lint/UnusedMethodArgument:
- 'app/workers/gitlab/jira_import/import_issue_worker.rb'
- 'app/workers/issues/rebalancing_worker.rb'
- 'app/workers/personal_access_tokens/expired_notification_worker.rb'
- 'app/workers/personal_access_tokens/expiring_worker.rb'
- 'app/workers/process_commit_worker.rb'
- 'app/workers/projects/inactive_projects_deletion_cron_worker.rb'
- 'app/workers/projects/refresh_build_artifacts_size_statistics_worker.rb'

1
.rubocop_todo/naming/heredoc_delimiter_naming.yml
View File

@ -32,7 +32,6 @@ Naming/HeredocDelimiterNaming:
- 'lib/gitlab/sql/set_operator.rb'
- 'lib/gitlab/utils/delegator_override/validator.rb'
- 'lib/tasks/gitlab/docs/compile_deprecations.rake'
- 'lib/tasks/gitlab/docs/compile_windows.rake'
- 'lib/tasks/gitlab/password.rake'
- 'rubocop/cop/database/multiple_databases.rb'
- 'rubocop/cop/database/rescue_query_canceled.rb'

1
.rubocop_todo/performance/string_identifier_argument.yml
View File

@ -21,7 +21,6 @@ Performance/StringIdentifierArgument:
- 'app/models/concerns/sanitizable.rb'
- 'app/models/concerns/signature_type.rb'
- 'app/models/concerns/token_authenticatable.rb'
- 'app/models/concerns/token_authenticatable_strategies/base.rb'
- 'app/models/integrations/base_third_party_wiki.rb'
- 'app/models/integrations/field.rb'
- 'app/models/namespace_statistics.rb'

1
.rubocop_todo/rails/date.yml
View File

@ -138,7 +138,6 @@ Rails/Date:
- 'qa/qa/page/profile/ssh_keys.rb'
- 'qa/qa/resource/ssh_key.rb'
- 'qa/qa/specs/features/browser_ui/6_release/deploy_token/add_deploy_token_spec.rb'
- 'qa/qa/specs/features/ee/api/2_plan/epics_milestone_dates_spec.rb'
- 'qa/qa/specs/features/ee/api/2_plan/epics_to_work_items_sync_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/ssh_push_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/12_systems/geo/ssh_push_to_secondary_spec.rb'

1
.rubocop_todo/rails/strong_params.yml
View File

@ -222,7 +222,6 @@ Rails/StrongParams:
- 'app/controllers/users/terms_controller.rb'
- 'app/controllers/users/unsubscribes_controller.rb'
- 'app/controllers/users_controller.rb'
- 'ee/app/controllers/admin/ai/feature_settings_controller.rb'
- 'ee/app/controllers/admin/ai/self_hosted_models_controller.rb'
- 'ee/app/controllers/admin/elasticsearch_controller.rb'
- 'ee/app/controllers/admin/emails_controller.rb'

1
.rubocop_todo/rspec/any_instance_of.yml
View File

@ -300,7 +300,6 @@ RSpec/AnyInstanceOf:
- 'spec/support/shared_examples/services/boards/issues_move_service_shared_examples.rb'
- 'spec/support/shared_examples/services/issuable_shared_examples.rb'
- 'spec/support/shared_examples/uploaders/object_storage_shared_examples.rb'
- 'spec/support/shared_examples/workers/authorized_projects_worker_shared_example.rb'
- 'spec/support/shared_examples/workers/reactive_cacheable_shared_examples.rb'
- 'spec/tasks/gitlab/cleanup_rake_spec.rb'
- 'spec/tasks/gitlab/container_registry_rake_spec.rb'

4
.rubocop_todo/rspec/be_eq.yml
View File

@ -27,8 +27,6 @@ RSpec/BeEq:
- 'ee/spec/controllers/projects_controller_spec.rb'
- 'ee/spec/controllers/registrations/groups_controller_spec.rb'
- 'ee/spec/controllers/subscriptions_controller_spec.rb'
- 'ee/spec/elastic/migrate/20240123181031_reindex_issue_to_update_analyzer_for_title_spec.rb'
- 'ee/spec/elastic/migrate/20240130144625_reindex_epics_to_update_analyzer_spec.rb'
- 'ee/spec/elastic/migrate/20240814231502_remove_work_item_access_level_from_work_item_spec.rb'
- 'ee/spec/elastic/migrate/20241002103536_reindex_merge_requests_for_title_completion_spec.rb'
- 'ee/spec/elastic/migrate/20241017094601_add_embedding_to_work_items_opensearch_spec.rb'
@ -893,7 +891,6 @@ RSpec/BeEq:
- 'spec/lib/gitlab/file_markdown_link_builder_spec.rb'
- 'spec/lib/gitlab/file_type_detection_spec.rb'
- 'spec/lib/gitlab/fogbugz_import/project_creator_spec.rb'
- 'spec/lib/gitlab/fp/result_spec.rb'
- 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb'
- 'spec/lib/gitlab/git/attributes_parser_spec.rb'
- 'spec/lib/gitlab/git/blob_spec.rb'
@ -1288,7 +1285,6 @@ RSpec/BeEq:
- 'spec/requests/api/graphql/project/container_repositories_spec.rb'
- 'spec/requests/api/graphql/project/environments_spec.rb'
- 'spec/requests/api/graphql/project/error_tracking/sentry_detailed_error_request_spec.rb'
- 'spec/requests/api/graphql/project/packages_spec.rb'
- 'spec/requests/api/graphql/project/release_spec.rb'
- 'spec/requests/api/group_clusters_spec.rb'
- 'spec/requests/api/group_export_spec.rb'

3
.rubocop_todo/rspec/be_nil.yml
View File

@ -25,7 +25,6 @@ RSpec/BeNil:
- 'ee/spec/models/work_items/widgets/progress_spec.rb'
- 'ee/spec/presenters/subscription_presenter_spec.rb'
- 'ee/spec/presenters/vulnerability_presenter_spec.rb'
- 'ee/spec/requests/api/ai/duo_workflows/workflows_spec.rb'
- 'ee/spec/requests/api/graphql/ai/self_hosted_models/create_spec.rb'
- 'ee/spec/requests/api/graphql/audit_events/group/namespace_filters/create_spec.rb'
- 'ee/spec/requests/api/graphql/audit_events/group/namespace_filters/delete_spec.rb'
@ -41,9 +40,7 @@ RSpec/BeNil:
- 'ee/spec/requests/api/graphql/project/runner_google_cloud_provisioning_spec.rb'
- 'ee/spec/requests/api/group_push_rule_spec.rb'
- 'ee/spec/requests/api/namespaces_spec.rb'
- 'ee/spec/services/ai/duo_workflows/start_workflow_service_spec.rb'
- 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb'
- 'ee/spec/services/ee/members/destroy_service_spec.rb'
- 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb'
- 'ee/spec/services/search/group_service_spec.rb'
- 'ee/spec/services/search/zoekt/callback_service_spec.rb'

2
.rubocop_todo/rspec/context_wording.yml
View File

@ -841,7 +841,6 @@ RSpec/ContextWording:
- 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/2_plan/epic/epics_management_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/project_issue_boards_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb'
- 'qa/spec/git/repository_spec.rb'
- 'qa/spec/page/element_spec.rb'
- 'qa/spec/service/docker_run/gitlab_runner_spec.rb'
@ -1079,7 +1078,6 @@ RSpec/ContextWording:
- 'spec/features/merge_request/user_sees_merge_widget_spec.rb'
- 'spec/features/merge_request/user_suggests_changes_on_diff_spec.rb'
- 'spec/features/merge_request/user_uses_quick_actions_spec.rb'
- 'spec/features/merge_requests/filters_generic_behavior_spec.rb'
- 'spec/features/merge_requests/user_exports_as_csv_spec.rb'
- 'spec/features/merge_requests/user_filters_by_approvals_spec.rb'
- 'spec/features/merge_requests/user_filters_by_assignees_spec.rb'

1
.rubocop_todo/rspec/duplicated_metadata.yml
View File

@ -1,3 +1,4 @@
---
# Cop supports --autocorrect.
RSpec/DuplicatedMetadata:
Details: grace period

1
.rubocop_todo/rspec/empty_metadata.yml
View File

@ -1,3 +1,4 @@
---
# Cop supports --autocorrect.
RSpec/EmptyMetadata:
Details: grace period

1
.rubocop_todo/rspec/empty_output.yml
View File

@ -1,3 +1,4 @@
---
# Cop supports --autocorrect.
RSpec/EmptyOutput:
Details: grace period

2
.rubocop_todo/rspec/example_without_description.yml
View File

@ -459,9 +459,7 @@ RSpec/ExampleWithoutDescription:
- 'spec/models/operations/feature_flags/strategy_spec.rb'
- 'spec/models/packages/cleanup/policy_spec.rb'
- 'spec/models/packages/conan/package_reference_spec.rb'
- 'spec/models/packages/conan/package_revision_spec.rb'
- 'spec/models/packages/conan/package_spec.rb'
- 'spec/models/packages/conan/recipe_revision_spec.rb'
- 'spec/models/packages/debian/package_spec.rb'
- 'spec/models/packages/npm/metadatum_spec.rb'
- 'spec/models/packages/protection/rule_spec.rb'

1
.rubocop_todo/rspec/expect_in_hook.yml
View File

@ -59,7 +59,6 @@ RSpec/ExpectInHook:
- 'ee/spec/services/gitlab_subscriptions/reconciliations/calculate_seat_count_data_service_spec.rb'
- 'ee/spec/services/groups/update_repository_storage_service_spec.rb'
- 'ee/spec/services/members/await_service_spec.rb'
- 'ee/spec/services/merge_requests/mergeability/check_approved_service_spec.rb'
- 'ee/spec/services/merge_requests/mergeability/check_blocked_by_other_mrs_service_spec.rb'
- 'ee/spec/services/projects/create_from_template_service_spec.rb'
- 'ee/spec/services/projects/mark_for_deletion_service_spec.rb'

3
.rubocop_todo/rspec/feature_category.yml
View File

@ -1467,7 +1467,6 @@ RSpec/FeatureCategory:
- 'spec/graphql/mutations/terraform/state/unlock_spec.rb'
- 'spec/graphql/mutations/timelogs/delete_spec.rb'
- 'spec/graphql/mutations/todos/create_spec.rb'
- 'spec/graphql/mutations/todos/mark_all_done_spec.rb'
- 'spec/graphql/mutations/todos/mark_done_spec.rb'
- 'spec/graphql/mutations/todos/restore_many_spec.rb'
- 'spec/graphql/mutations/todos/restore_spec.rb'
@ -3380,7 +3379,6 @@ RSpec/FeatureCategory:
- 'spec/models/concerns/milestoneish_spec.rb'
- 'spec/models/concerns/nullify_if_blank_spec.rb'
- 'spec/models/concerns/optionally_search_spec.rb'
- 'spec/models/concerns/partitioned_table_spec.rb'
- 'spec/models/concerns/presentable_spec.rb'
- 'spec/models/concerns/project_api_compatibility_spec.rb'
- 'spec/models/concerns/project_features_compatibility_spec.rb'
@ -3624,7 +3622,6 @@ RSpec/FeatureCategory:
- 'spec/policies/blob_policy_spec.rb'
- 'spec/policies/board_policy_spec.rb'
- 'spec/policies/ci/bridge_policy_spec.rb'
- 'spec/policies/ci/trigger_policy_spec.rb'
- 'spec/policies/clusters/agent_policy_spec.rb'
- 'spec/policies/clusters/agent_token_policy_spec.rb'
- 'spec/policies/clusters/agents/activity_event_policy_spec.rb'

2
.rubocop_todo/rspec/identical_equality_assertion.yml
View File

@ -12,8 +12,6 @@ RSpec/IdenticalEqualityAssertion:
- 'spec/lib/gitlab/ci/ansi2json/state_spec.rb'
- 'spec/lib/gitlab/color_spec.rb'
- 'spec/lib/gitlab/daemon_spec.rb'
- 'spec/lib/gitlab/fp/message_spec.rb'
- 'spec/lib/gitlab/fp/result_spec.rb'
- 'spec/lib/gitlab/global_anonymous_id_spec.rb'
- 'spec/lib/gitlab/graphql/lazy_spec.rb'
- 'spec/lib/gitlab/render_timeout_spec.rb'

1
.rubocop_todo/rspec/instance_variable.yml
View File

@ -33,7 +33,6 @@ RSpec/InstanceVariable:
- 'qa/qa/specs/features/browser_ui/3_create/repository/user_views_commit_diff_patch_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/project_issue_boards_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/more_than_four_assignees_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/3_create/repository/push_rules_spec.rb'
- 'spec/commands/metrics_server/metrics_server_spec.rb'
- 'spec/controllers/admin/topics/avatars_controller_spec.rb'
- 'spec/controllers/concerns/renders_commits_spec.rb'

2
.rubocop_todo/rspec/metadata_style.yml
View File

@ -34,8 +34,6 @@ RSpec/MetadataStyle:
- 'spec/lib/gitlab/ssh_public_key_spec.rb'
- 'spec/lib/gitlab/tab_width_spec.rb'
- 'spec/lib/gitlab/themes_spec.rb'
- 'spec/migrations/20230804053643_add_ticket_work_item_type_spec.rb'
- 'spec/migrations/20230815160428_rename_plans_titles_with_legacy_plan_names_spec.rb'
- 'spec/models/ci/build_need_spec.rb'
- 'spec/models/ci/build_runner_session_spec.rb'
- 'spec/models/ci/runner_manager_build_spec.rb'

1
.rubocop_todo/rspec/named_subject.yml
View File

@ -1036,7 +1036,6 @@ RSpec/NamedSubject:
- 'ee/spec/services/security/security_orchestration_policies/process_scan_result_policy_service_spec.rb'
- 'ee/spec/services/security/security_orchestration_policies/scan_pipeline_service_spec.rb'
- 'ee/spec/services/security/security_orchestration_policies/sync_opened_merge_requests_service_spec.rb'
- 'ee/spec/services/security/security_orchestration_policies/sync_scan_result_policies_service_spec.rb'
- 'ee/spec/services/security/token_revocation_service_spec.rb'
- 'ee/spec/services/security/track_scan_service_spec.rb'
- 'ee/spec/services/security/training_providers/base_url_service_spec.rb'

4
.rubocop_todo/rspec/receive_messages.yml
View File

@ -12,7 +12,6 @@ RSpec/ReceiveMessages:
- 'ee/spec/controllers/ee/search_controller_spec.rb'
- 'ee/spec/controllers/oauth/geo_auth_controller_spec.rb'
- 'ee/spec/controllers/projects_controller_spec.rb'
- 'ee/spec/elastic/migrate/20240130215043_reindex_wikis_to_fix_id_spec.rb'
- 'ee/spec/features/admin/admin_audit_logs_spec.rb'
- 'ee/spec/features/admin/groups/admin_subscription_alerts_spec.rb'
- 'ee/spec/features/groups/iterations/user_edits_iteration_cadence_spec.rb'
@ -78,9 +77,6 @@ RSpec/ReceiveMessages:
- 'ee/spec/lib/gitlab/geo/log_cursor/daemon_spec.rb'
- 'ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb'
- 'ee/spec/lib/gitlab/git_access_spec.rb'
- 'ee/spec/lib/gitlab/llm/ai_gateway/client_spec.rb'
- 'ee/spec/lib/gitlab/llm/ai_gateway/code_suggestions_client_spec.rb'
- 'ee/spec/lib/gitlab/llm/ai_gateway/docs_client_spec.rb'
- 'ee/spec/lib/gitlab/llm/chain/tools/epic_reader/executor_spec.rb'
- 'ee/spec/lib/gitlab/llm/vertex_ai/client_spec.rb'
- 'ee/spec/lib/gitlab/mirror_spec.rb'

1
.rubocop_todo/rspec/spec_file_path_format.yml
View File

@ -31,7 +31,6 @@ RSpec/SpecFilePathFormat:
- 'spec/requests/api/issues/post_projects_issues_spec.rb'
- 'spec/requests/api/issues/put_projects_issues_spec.rb'
- 'spec/requests/api/pages/pages_spec.rb'
- 'spec/rubocop/cop/rspec/httparty_basic_auth_spec.rb'
- 'spec/services/ci/create_pipeline_service/artifacts_spec.rb'
- 'spec/services/ci/create_pipeline_service/cache_spec.rb'
- 'spec/services/ci/create_pipeline_service/creation_errors_and_warnings_spec.rb'

1
.rubocop_todo/rspec/verified_double_reference.yml
View File

@ -60,7 +60,6 @@ RSpec/VerifiedDoubleReference:
- 'ee/spec/requests/projects/security/policies_controller_spec.rb'
- 'ee/spec/serializers/dashboard_environments_project_entity_spec.rb'
- 'ee/spec/serializers/vulnerabilities/finding_entity_spec.rb'
- 'ee/spec/services/ai/duo_workflows/start_workflow_service_spec.rb'
- 'ee/spec/services/analytics/cycle_analytics/consistency_check_service_spec.rb'
- 'ee/spec/services/analytics/forecasting/build_forecast_service_spec.rb'
- 'ee/spec/services/app_sec/dast/scans/run_service_spec.rb'

2
.rubocop_todo/rspec/verified_doubles.yml
View File

@ -75,7 +75,6 @@ RSpec/VerifiedDoubles:
- 'ee/spec/models/ee/user_spec.rb'
- 'ee/spec/models/elastic/index_setting_spec.rb'
- 'ee/spec/models/geo/secondary_usage_data_spec.rb'
- 'ee/spec/models/geo_node_status_spec.rb'
- 'ee/spec/models/integrations/github/status_message_spec.rb'
- 'ee/spec/models/integrations/github_spec.rb'
- 'ee/spec/models/push_rule_spec.rb'
@ -670,7 +669,6 @@ RSpec/VerifiedDoubles:
- 'spec/models/concerns/atomic_internal_id_spec.rb'
- 'spec/models/concerns/legacy_bulk_insert_spec.rb'
- 'spec/models/concerns/prometheus_adapter_spec.rb'
- 'spec/models/concerns/token_authenticatable_strategies/base_spec.rb'
- 'spec/models/concerns/token_authenticatable_strategies/encrypted_spec.rb'
- 'spec/models/concerns/triggerable_hooks_spec.rb'
- 'spec/models/concerns/x509_serial_number_attribute_spec.rb'

2
.rubocop_todo/style/arguments_forwarding.yml
View File

@ -40,10 +40,8 @@ Style/ArgumentsForwarding:
- 'app/workers/concerns/limited_capacity/job_tracker.rb'
- 'app/workers/container_expiration_policies/cleanup_container_repository_worker.rb'
- 'app/workers/container_expiration_policy_worker.rb'
- 'app/workers/dependency_proxy/image_ttl_group_policy_worker.rb'
- 'app/workers/gitlab_performance_bar_stats_worker.rb'
- 'app/workers/packages/cleanup/delete_orphaned_dependencies_worker.rb'
- 'app/workers/packages/cleanup_package_registry_worker.rb'
- 'app/workers/projects/inactive_projects_deletion_cron_worker.rb'
- 'config/initializers/6_labkit_middleware.rb'
- 'config/initializers/mail_starttls_patch.rb'

2
.rubocop_todo/style/empty_literal.yml
View File

@ -2,5 +2,3 @@
# Cop supports --autocorrect.
Style/EmptyLiteral:
Details: grace period
Exclude:
- 'lib/gitlab/api_authentication/builder.rb'

2
.rubocop_todo/style/hash_each_methods.yml
View File

@ -26,7 +26,6 @@ Style/HashEachMethods:
- 'app/graphql/types/packages/package_type_enum.rb'
- 'app/graphql/types/release_asset_link_type_enum.rb'
- 'app/graphql/types/user_callout_feature_name_enum.rb'
- 'app/helpers/routing/pseudonymization_helper.rb'
- 'app/models/application_setting.rb'
- 'app/models/ci/pipeline.rb'
- 'app/models/concerns/bulk_insertable_associations.rb'
@ -123,7 +122,6 @@ Style/HashEachMethods:
- 'spec/requests/api/project_templates_spec.rb'
- 'spec/services/system_notes/incident_service_spec.rb'
- 'spec/support/helpers/database/multiple_databases_helpers.rb'
- 'spec/support/helpers/multipart_helpers.rb'
- 'spec/support/helpers/reactive_caching_helpers.rb'
- 'spec/support/helpers/repo_helpers.rb'
- 'spec/support/import_export/project_tree_expectations.rb'

153
.rubocop_todo/style/inline_disable_annotation.yml
View File

@ -42,7 +42,6 @@ Style/InlineDisableAnnotation:
- 'app/controllers/concerns/milestone_actions.rb'
- 'app/controllers/concerns/notes_actions.rb'
- 'app/controllers/concerns/preferred_language_switcher.rb'
- 'app/controllers/concerns/preview_markdown.rb'
- 'app/controllers/concerns/registry/connection_errors_handler.rb'
- 'app/controllers/concerns/renders_commits.rb'
- 'app/controllers/concerns/renders_member_access.rb'
@ -52,13 +51,10 @@ Style/InlineDisableAnnotation:
- 'app/controllers/concerns/snippets_actions.rb'
- 'app/controllers/concerns/uploads_actions.rb'
- 'app/controllers/concerns/verifies_with_email.rb'
- 'app/controllers/concerns/web_hooks/hook_log_actions.rb'
- 'app/controllers/concerns/wiki_actions.rb'
- 'app/controllers/dashboard/projects_controller.rb'
- 'app/controllers/explore/projects_controller.rb'
- 'app/controllers/graphql_controller.rb'
- 'app/controllers/groups/autocomplete_sources_controller.rb'
- 'app/controllers/groups/labels_controller.rb'
- 'app/controllers/groups/milestones_controller.rb'
- 'app/controllers/groups_controller.rb'
- 'app/controllers/help_controller.rb'
@ -71,7 +67,6 @@ Style/InlineDisableAnnotation:
- 'app/controllers/oauth/authorizations_controller.rb'
- 'app/controllers/passwords_controller.rb'
- 'app/controllers/profiles/accounts_controller.rb'
- 'app/controllers/profiles/notifications_controller.rb'
- 'app/controllers/projects/analytics/cycle_analytics/stages_controller.rb'
- 'app/controllers/projects/blob_controller.rb'
- 'app/controllers/projects/branches_controller.rb'
@ -161,7 +156,6 @@ Style/InlineDisableAnnotation:
- 'app/finders/user_groups_counter.rb'
- 'app/finders/user_recent_events_finder.rb'
- 'app/finders/users_finder.rb'
- 'app/graphql/gitlab_schema.rb'
- 'app/graphql/graphql_triggers.rb'
- 'app/graphql/mutations/issues/update.rb'
- 'app/graphql/mutations/projects/sync_fork.rb'
@ -248,7 +242,6 @@ Style/InlineDisableAnnotation:
- 'app/graphql/types/clusters/agents/authorizations/ci_access_type.rb'
- 'app/graphql/types/clusters/agents/authorizations/user_access_type.rb'
- 'app/graphql/types/commit_references_type.rb'
- 'app/graphql/types/commit_signatures/verification_status_enum.rb'
- 'app/graphql/types/countable_connection_type.rb'
- 'app/graphql/types/customer_relations/organization_state_counts_type.rb'
- 'app/graphql/types/deployment_tag_type.rb'
@ -289,7 +282,6 @@ Style/InlineDisableAnnotation:
- 'app/graphql/types/projects/commit_parent_names_type.rb'
- 'app/graphql/types/projects/fork_details_type.rb'
- 'app/graphql/types/projects/repository_language_type.rb'
- 'app/graphql/types/projects/service_type_enum.rb'
- 'app/graphql/types/projects/services/jira_project_type.rb'
- 'app/graphql/types/projects/topic_type.rb'
- 'app/graphql/types/query_complexity_type.rb'
@ -322,16 +314,13 @@ Style/InlineDisableAnnotation:
- 'app/helpers/auth_helper.rb'
- 'app/helpers/ci/status_helper.rb'
- 'app/helpers/commits_helper.rb'
- 'app/helpers/diff_helper.rb'
- 'app/helpers/dropdowns_helper.rb'
- 'app/helpers/integrations_helper.rb'
- 'app/helpers/issuables_helper.rb'
- 'app/helpers/lazy_image_tag_helper.rb'
- 'app/helpers/namespaces_helper.rb'
- 'app/helpers/page_layout_helper.rb'
- 'app/helpers/routing/projects_helper.rb'
- 'app/helpers/routing/pseudonymization_helper.rb'
- 'app/helpers/search_helper.rb'
- 'app/helpers/sidebars_helper.rb'
- 'app/helpers/sorting_helper.rb'
- 'app/helpers/users_helper.rb'
@ -351,7 +340,6 @@ Style/InlineDisableAnnotation:
- 'app/models/award_emoji.rb'
- 'app/models/badge.rb'
- 'app/models/board.rb'
- 'app/models/bulk_import.rb'
- 'app/models/bulk_imports/entity.rb'
- 'app/models/ci/bridge.rb'
- 'app/models/ci/build.rb'
@ -385,10 +373,7 @@ Style/InlineDisableAnnotation:
- 'app/models/concerns/fast_destroy_all.rb'
- 'app/models/concerns/featurable.rb'
- 'app/models/concerns/file_store_mounter.rb'
- 'app/models/concerns/from_except.rb'
- 'app/models/concerns/from_intersect.rb'
- 'app/models/concerns/from_set_operator.rb'
- 'app/models/concerns/from_union.rb'
- 'app/models/concerns/has_repository.rb'
- 'app/models/concerns/ignorable_columns.rb'
- 'app/models/concerns/integrations/reset_secret_fields.rb'
@ -403,7 +388,6 @@ Style/InlineDisableAnnotation:
- 'app/models/concerns/participable.rb'
- 'app/models/concerns/project_features_compatibility.rb'
- 'app/models/concerns/redactable.rb'
- 'app/models/concerns/redis_cacheable.rb'
- 'app/models/concerns/resolvable_discussion.rb'
- 'app/models/concerns/routable.rb'
- 'app/models/concerns/sanitizable.rb'
@ -500,7 +484,6 @@ Style/InlineDisableAnnotation:
- 'app/policies/upload_policy.rb'
- 'app/presenters/ci/build_runner_presenter.rb'
- 'app/presenters/deploy_key_presenter.rb'
- 'app/presenters/dev_ops_report/metric_presenter.rb'
- 'app/presenters/key_presenter.rb'
- 'app/presenters/label_presenter.rb'
- 'app/presenters/merge_request_presenter.rb'
@ -517,10 +500,8 @@ Style/InlineDisableAnnotation:
- 'app/serializers/ci/dag_pipeline_entity.rb'
- 'app/serializers/ci/job_entity.rb'
- 'app/serializers/cluster_entity.rb'
- 'app/serializers/diffs_entity.rb'
- 'app/serializers/diffs_metadata_entity.rb'
- 'app/serializers/environment_serializer.rb'
- 'app/serializers/fork_namespace_entity.rb'
- 'app/serializers/group_access_token_entity.rb'
- 'app/serializers/group_access_token_serializer.rb'
- 'app/serializers/group_child_entity.rb'
@ -568,10 +549,8 @@ Style/InlineDisableAnnotation:
- 'app/services/ci/delete_unit_tests_service.rb'
- 'app/services/ci/expire_pipeline_cache_service.rb'
- 'app/services/ci/job_artifacts/bulk_delete_by_project_service.rb'
- 'app/services/ci/job_artifacts/destroy_batch_service.rb'
- 'app/services/ci/job_artifacts/expire_project_build_artifacts_service.rb'
- 'app/services/ci/pipeline_artifacts/create_code_quality_mr_diff_report_service.rb'
- 'app/services/ci/pipeline_creation/cancel_redundant_pipelines_service.rb'
- 'app/services/ci/pipeline_processing/atomic_processing_service.rb'
- 'app/services/ci/pipeline_processing/atomic_processing_service/status_collection.rb'
- 'app/services/ci/queue/build_queue_service.rb'
@ -595,7 +574,6 @@ Style/InlineDisableAnnotation:
- 'app/services/concerns/issues/resolve_discussions.rb'
- 'app/services/concerns/rate_limited_service.rb'
- 'app/services/concerns/work_items/widgetable_service.rb'
- 'app/services/database/consistency_check_service.rb'
- 'app/services/database/consistency_fix_service.rb'
- 'app/services/database/mark_migration_service.rb'
- 'app/services/deployments/create_for_job_service.rb'
@ -615,7 +593,6 @@ Style/InlineDisableAnnotation:
- 'app/services/issuable_base_service.rb'
- 'app/services/issuable_links/create_service.rb'
- 'app/services/issues/build_service.rb'
- 'app/services/issues/export_csv_service.rb'
- 'app/services/issues/referenced_merge_requests_service.rb'
- 'app/services/issues/relative_position_rebalancing_service.rb'
- 'app/services/issues/set_crm_contacts_service.rb'
@ -629,8 +606,6 @@ Style/InlineDisableAnnotation:
- 'app/services/lfs/locks_finder_service.rb'
- 'app/services/lfs/unlock_file_service.rb'
- 'app/services/loose_foreign_keys/cleaner_service.rb'
- 'app/services/members/projects/creator_service.rb'
- 'app/services/members/standard_member_builder.rb'
- 'app/services/merge_requests/base_service.rb'
- 'app/services/merge_requests/create_from_issue_service.rb'
- 'app/services/merge_requests/delete_non_latest_diffs_service.rb'
@ -654,12 +629,10 @@ Style/InlineDisableAnnotation:
- 'app/services/packages/nuget/extract_remote_metadata_file_service.rb'
- 'app/services/packages/nuget/process_package_file_service.rb'
- 'app/services/packages/nuget/search_service.rb'
- 'app/services/packages/rpm/repository_metadata/build_xml_base_service.rb'
- 'app/services/packages/rubygems/metadata_extraction_service.rb'
- 'app/services/packages/update_tags_service.rb'
- 'app/services/pages/destroy_deployments_service.rb'
- 'app/services/personal_access_tokens/revoke_token_family_service.rb'
- 'app/services/projects/auto_devops/disable_service.rb'
- 'app/services/projects/autocomplete_service.rb'
- 'app/services/projects/batch_forks_count_service.rb'
- 'app/services/projects/batch_open_issues_count_service.rb'
@ -691,8 +664,6 @@ Style/InlineDisableAnnotation:
- 'app/services/quick_actions/interpret_service.rb'
- 'app/services/quick_actions/target_service.rb'
- 'app/services/releases/create_evidence_service.rb'
- 'app/services/releases/create_service.rb'
- 'app/services/releases/update_service.rb'
- 'app/services/repositories/changelog_service.rb'
- 'app/services/resource_events/change_labels_service.rb'
- 'app/services/resource_events/synthetic_label_notes_builder_service.rb'
@ -714,7 +685,6 @@ Style/InlineDisableAnnotation:
- 'app/services/todos/destroy/unauthorized_features_service.rb'
- 'app/services/topics/merge_service.rb'
- 'app/services/user_project_access_changed_service.rb'
- 'app/services/users/activate_service.rb'
- 'app/services/users/assigned_issues_count_service.rb'
- 'app/services/users/batch_status_cleaner_service.rb'
- 'app/services/users/destroy_service.rb'
@ -724,14 +694,12 @@ Style/InlineDisableAnnotation:
- 'app/services/users/set_namespace_commit_email_service.rb'
- 'app/services/users/update_service.rb'
- 'app/services/verify_pages_domain_service.rb'
- 'app/services/web_hook_service.rb'
- 'app/services/wiki_pages/update_service.rb'
- 'app/uploaders/gitlab_uploader.rb'
- 'app/uploaders/metric_image_uploader.rb'
- 'app/uploaders/object_storage.rb'
- 'app/uploaders/object_storage/cdn.rb'
- 'app/uploaders/object_storage/cdn/google_cdn.rb'
- 'app/uploaders/object_storage/cdn/google_ip_cache.rb'
- 'app/uploaders/records_uploads.rb'
- 'app/validators/addressable_url_validator.rb'
- 'app/validators/cron_validator.rb'
@ -817,7 +785,6 @@ Style/InlineDisableAnnotation:
- 'app/workers/create_pipeline_worker.rb'
- 'app/workers/database/batched_background_migration/ci_database_worker.rb'
- 'app/workers/database/batched_background_migration/ci_execution_worker.rb'
- 'app/workers/database/batched_background_migration/execution_worker.rb'
- 'app/workers/database/batched_background_migration/main_execution_worker.rb'
- 'app/workers/database/batched_background_migration/single_database_worker.rb'
- 'app/workers/database/batched_background_migration_worker.rb'
@ -920,10 +887,8 @@ Style/InlineDisableAnnotation:
- 'app/workers/group_export_worker.rb'
- 'app/workers/group_import_worker.rb'
- 'app/workers/import_export_project_cleanup_worker.rb'
- 'app/workers/import_issues_csv_worker.rb'
- 'app/workers/incident_management/add_severity_system_note_worker.rb'
- 'app/workers/incident_management/pager_duty/process_incident_worker.rb'
- 'app/workers/incident_management/process_alert_worker_v2.rb'
- 'app/workers/integrations/execute_worker.rb'
- 'app/workers/integrations/irker_worker.rb'
- 'app/workers/invalid_gpg_signature_update_worker.rb'
@ -944,12 +909,10 @@ Style/InlineDisableAnnotation:
- 'app/workers/member_invitation_reminder_emails_worker.rb'
- 'app/workers/members/expiring_email_notification_worker.rb'
- 'app/workers/members/expiring_worker.rb'
- 'app/workers/merge_worker.rb'
- 'app/workers/metrics/global_metrics_update_worker.rb'
- 'app/workers/migrate_external_diffs_worker.rb'
- 'app/workers/namespaces/prune_aggregation_schedules_worker.rb'
- 'app/workers/new_issue_worker.rb'
- 'app/workers/new_merge_request_worker.rb'
- 'app/workers/new_note_worker.rb'
- 'app/workers/object_pool/create_worker.rb'
- 'app/workers/object_pool/destroy_worker.rb'
@ -1049,7 +1012,6 @@ Style/InlineDisableAnnotation:
- 'config/initializers/enumerator_next_patch.rb'
- 'config/initializers/fix_local_cache_middleware.rb'
- 'config/initializers/fog_core_patch.rb'
- 'config/initializers/grape_validators.rb'
- 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb'
- 'config/initializers/mail_starttls_patch.rb'
- 'config/initializers/postgres_cte_as_materialized.rb'
@ -1059,7 +1021,6 @@ Style/InlineDisableAnnotation:
- 'config/initializers/warden.rb'
- 'config/initializers/wikicloth_redos_patch.rb'
- 'config/initializers/wikicloth_ruby_3_patch.rb'
- 'config/routes/api.rb'
- 'config/routes/group.rb'
- 'config/routes/project.rb'
- 'danger/ce_ee_vue_templates/Dangerfile'
@ -1110,13 +1071,11 @@ Style/InlineDisableAnnotation:
- 'ee/app/controllers/ee/search_controller.rb'
- 'ee/app/controllers/ee/sessions_controller.rb'
- 'ee/app/controllers/ee/users_controller.rb'
- 'ee/app/controllers/groups/analytics/productivity_analytics_controller.rb'
- 'ee/app/controllers/groups/epics/notes_controller.rb'
- 'ee/app/controllers/groups/epics_controller.rb'
- 'ee/app/controllers/groups/ldap_group_links_controller.rb'
- 'ee/app/controllers/groups/ldaps_controller.rb'
- 'ee/app/controllers/groups/scim_oauth_controller.rb'
- 'ee/app/controllers/groups/todos_controller.rb'
- 'ee/app/controllers/projects/approver_groups_controller.rb'
- 'ee/app/controllers/projects/approvers_controller.rb'
- 'ee/app/controllers/projects/path_locks_controller.rb'
@ -1165,7 +1124,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/graphql/mutations/iterations/update.rb'
- 'ee/app/graphql/mutations/projects/set_locked.rb'
- 'ee/app/graphql/mutations/requirements_management/export_requirements.rb'
- 'ee/app/graphql/resolvers/analytics/contribution_analytics/contributions_resolver.rb'
- 'ee/app/graphql/resolvers/board_groupings/epics_resolver.rb'
- 'ee/app/graphql/resolvers/ci/runners_jobs_statistics_resolver.rb'
- 'ee/app/graphql/resolvers/iterations_resolver.rb'
@ -1185,7 +1143,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/graphql/types/applied_ml/suggested_reviewers_type.rb'
- 'ee/app/graphql/types/boards/board_epic_type.rb'
- 'ee/app/graphql/types/boards/epic_list_metadata_type.rb'
- 'ee/app/graphql/types/boards/epic_list_type.rb'
- 'ee/app/graphql/types/boards/epic_user_preferences_type.rb'
- 'ee/app/graphql/types/branch_protections/unprotect_access_level_type.rb'
- 'ee/app/graphql/types/burnup_chart_daily_totals_type.rb'
@ -1193,7 +1150,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/graphql/types/ci/code_coverage_summary_type.rb'
- 'ee/app/graphql/types/ci/code_quality_degradation_type.rb'
- 'ee/app/graphql/types/ci/jobs_statistics_type.rb'
- 'ee/app/graphql/types/ci/minutes/namespace_monthly_usage_type.rb'
- 'ee/app/graphql/types/ci/minutes/project_monthly_usage_type.rb'
- 'ee/app/graphql/types/ci/queueing_history_time_series_type.rb'
- 'ee/app/graphql/types/dast/profile_cadence_type.rb'
@ -1215,15 +1171,12 @@ Style/InlineDisableAnnotation:
- 'ee/app/graphql/types/incident_management/escalation_rule_input_type.rb'
- 'ee/app/graphql/types/incident_management/escalation_rule_type.rb'
- 'ee/app/graphql/types/incident_management/oncall_participant_type.rb'
- 'ee/app/graphql/types/incident_management/oncall_rotation_active_period_input_type.rb'
- 'ee/app/graphql/types/incident_management/oncall_rotation_active_period_type.rb'
- 'ee/app/graphql/types/incident_management/oncall_shift_type.rb'
- 'ee/app/graphql/types/member_roles/customizable_permission_type.rb'
- 'ee/app/graphql/types/namespaces/namespace_ban_type.rb'
- 'ee/app/graphql/types/path_lock_type.rb'
- 'ee/app/graphql/types/product_analytics/category_enum.rb'
- 'ee/app/graphql/types/product_analytics/panel_type.rb'
- 'ee/app/graphql/types/product_analytics/state_enum.rb'
- 'ee/app/graphql/types/product_analytics/visualization_type.rb'
- 'ee/app/graphql/types/protected_environment_type.rb'
- 'ee/app/graphql/types/protected_environments/approval_rule_for_summary_type.rb'
@ -1233,7 +1186,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/graphql/types/requirements_management/requirement_states_count_type.rb'
- 'ee/app/graphql/types/sbom/license_type.rb'
- 'ee/app/graphql/types/sbom/location_type.rb'
- 'ee/app/graphql/types/scan_type.rb'
- 'ee/app/graphql/types/scanned_resource_type.rb'
- 'ee/app/graphql/types/security/training_type.rb'
- 'ee/app/graphql/types/security_orchestration/approval_group_type.rb'
@ -1299,30 +1251,22 @@ Style/InlineDisableAnnotation:
- 'ee/app/graphql/types/work_items/widgets/weight_type.rb'
- 'ee/app/helpers/admin/application_settings_helper.rb'
- 'ee/app/helpers/ee/application_helper.rb'
- 'ee/app/helpers/ee/boards_helper.rb'
- 'ee/app/helpers/ee/gitlab_routing_helper.rb'
- 'ee/app/helpers/ee/kerberos_helper.rb'
- 'ee/app/helpers/projects/on_demand_scans_helper.rb'
- 'ee/app/helpers/push_rules_helper.rb'
- 'ee/app/models/ai/ai_resource/concerns/noteable.rb'
- 'ee/app/models/ai/ai_resource/epic.rb'
- 'ee/app/models/ai/ai_resource/issue.rb'
- 'ee/app/models/approval_project_rules_user.rb'
- 'ee/app/models/approver.rb'
- 'ee/app/models/approver_group.rb'
- 'ee/app/models/ci/minutes/namespace_monthly_usage.rb'
- 'ee/app/models/concerns/elastic/application_versioned_search.rb'
- 'ee/app/models/concerns/epics/metadata_cache_update.rb'
- 'ee/app/models/concerns/geo/blob_replicator_strategy.rb'
- 'ee/app/models/dast/branch.rb'
- 'ee/app/models/ee/analytics/cycle_analytics/issue_stage_event.rb'
- 'ee/app/models/ee/epic.rb'
- 'ee/app/models/ee/group.rb'
- 'ee/app/models/ee/member.rb'
- 'ee/app/models/ee/merge_request.rb'
- 'ee/app/models/ee/namespace.rb'
- 'ee/app/models/ee/namespace_setting.rb'
- 'ee/app/models/ee/project.rb'
- 'ee/app/models/ee/project_group_link.rb'
- 'ee/app/models/ee/project_member.rb'
- 'ee/app/models/ee/user.rb'
@ -1332,7 +1276,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/models/elasticsearch_indexed_project.rb'
- 'ee/app/models/geo/container_repository_registry.rb'
- 'ee/app/models/geo/upload_registry.rb'
- 'ee/app/models/geo_node.rb'
- 'ee/app/models/geo_node_status.rb'
- 'ee/app/models/incident_management/oncall_rotation.rb'
- 'ee/app/models/iteration.rb'
@ -1344,13 +1287,10 @@ Style/InlineDisableAnnotation:
- 'ee/app/models/package_metadata/package.rb'
- 'ee/app/models/protected_environments/approval_rules/summarizable.rb'
- 'ee/app/models/protected_environments/authorizable.rb'
- 'ee/app/models/requirements_management/requirement.rb'
- 'ee/app/models/security/training.rb'
- 'ee/app/models/vulnerabilities/finding.rb'
- 'ee/app/policies/merge_request_diff_policy.rb'
- 'ee/app/policies/path_lock_policy.rb'
- 'ee/app/replicators/geo/container_repository_replicator.rb'
- 'ee/app/serializers/dashboard_environments_serializer.rb'
- 'ee/app/serializers/ee/discussion_serializer.rb'
- 'ee/app/serializers/epic_ai_entity.rb'
- 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb'
@ -1373,14 +1313,12 @@ Style/InlineDisableAnnotation:
- 'ee/app/services/compliance_management/violations/export_service.rb'
- 'ee/app/services/dependencies/export_serializers/group_dependencies_service.rb'
- 'ee/app/services/deployments/approval_service.rb'
- 'ee/app/services/dora/aggregate_scores_service.rb'
- 'ee/app/services/ee/audit_event_service.rb'
- 'ee/app/services/ee/audit_events/build_service.rb'
- 'ee/app/services/ee/auth/container_registry_authentication_service.rb'
- 'ee/app/services/ee/boards/base_service.rb'
- 'ee/app/services/ee/boards/issues/list_service.rb'
- 'ee/app/services/ee/boards/lists/create_service.rb'
- 'ee/app/services/ee/ci/queue/build_queue_service.rb'
- 'ee/app/services/ee/groups/autocomplete_service.rb'
- 'ee/app/services/ee/groups/destroy_service.rb'
- 'ee/app/services/ee/groups/update_service.rb'
@ -1392,7 +1330,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/services/ee/merge_requests/merge_base_service.rb'
- 'ee/app/services/ee/merge_requests/refresh_service.rb'
- 'ee/app/services/ee/milestones/promote_service.rb'
- 'ee/app/services/ee/notification_recipients/builder/base.rb'
- 'ee/app/services/ee/projects/create_from_template_service.rb'
- 'ee/app/services/ee/projects/create_service.rb'
- 'ee/app/services/ee/projects/destroy_service.rb'
@ -1402,7 +1339,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/services/ee/quick_actions/target_service.rb'
- 'ee/app/services/ee/resource_events/synthetic_iteration_notes_builder_service.rb'
- 'ee/app/services/ee/resource_events/synthetic_weight_notes_builder_service.rb'
- 'ee/app/services/ee/search/global_service.rb'
- 'ee/app/services/ee/search_service.rb'
- 'ee/app/services/ee/system_note_service.rb'
- 'ee/app/services/ee/users/build_service.rb'
@ -1436,7 +1372,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/services/security/ingestion/schedule_mark_dropped_as_resolved_service.rb'
- 'ee/app/services/security/ingestion/tasks/ingest_vulnerability_flags.rb'
- 'ee/app/services/security/merge_request_security_report_generation_service.rb'
- 'ee/app/services/security/scan_result_policies/sync_any_merge_request_rules_service.rb'
- 'ee/app/services/security/security_orchestration_policies/fetch_policy_approvers_service.rb'
- 'ee/app/services/security/security_orchestration_policies/policy_branches_service.rb'
- 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb'
@ -1477,7 +1412,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/workers/concerns/elastic/indexing_control.rb'
- 'ee/app/workers/concerns/geo/base_registry_sync_worker.rb'
- 'ee/app/workers/create_github_webhook_worker.rb'
- 'ee/app/workers/ee/issuable_export_csv_worker.rb'
- 'ee/app/workers/ee/post_receive.rb'
- 'ee/app/workers/elastic/migration_worker.rb'
- 'ee/app/workers/elastic/namespace_update_worker.rb'
@ -1532,7 +1466,6 @@ Style/InlineDisableAnnotation:
- 'ee/app/workers/projects/disable_legacy_open_source_license_for_inactive_projects_worker.rb'
- 'ee/app/workers/pull_mirrors/reenable_configuration_worker.rb'
- 'ee/app/workers/refresh_license_compliance_checks_worker.rb'
- 'ee/app/workers/scan_security_report_secrets_worker.rb'
- 'ee/app/workers/search/index_curation_worker.rb'
- 'ee/app/workers/search/zoekt/namespace_indexer_worker.rb'
- 'ee/app/workers/security/create_orchestration_policy_worker.rb'
@ -1589,9 +1522,6 @@ Style/InlineDisableAnnotation:
- 'ee/lib/analytics/merge_request_metrics_calculator.rb'
- 'ee/lib/analytics/refresh_approvals_data.rb'
- 'ee/lib/analytics/refresh_reassign_data.rb'
- 'ee/lib/api/admin/search/migrations.rb'
- 'ee/lib/api/audit_events.rb'
- 'ee/lib/api/dora/metrics.rb'
- 'ee/lib/api/elasticsearch_indexed_namespaces.rb'
- 'ee/lib/api/entities/search/migration.rb'
- 'ee/lib/api/epic_issues.rb'
@ -1601,7 +1531,6 @@ Style/InlineDisableAnnotation:
- 'ee/lib/api/saml_group_links.rb'
- 'ee/lib/audit/changes.rb'
- 'ee/lib/banzai/filter/references/iteration_reference_filter.rb'
- 'ee/lib/ee/api/entities/analytics/code_review/merge_request.rb'
- 'ee/lib/ee/api/entities/experiment.rb'
- 'ee/lib/ee/api/group_boards.rb'
- 'ee/lib/ee/api/group_milestones.rb'
@ -1609,7 +1538,6 @@ Style/InlineDisableAnnotation:
- 'ee/lib/ee/api/helpers.rb'
- 'ee/lib/ee/api/helpers/award_emoji.rb'
- 'ee/lib/ee/api/helpers/common_helpers.rb'
- 'ee/lib/ee/api/helpers/internal_helpers.rb'
- 'ee/lib/ee/api/helpers/members_helpers.rb'
- 'ee/lib/ee/api/internal/base.rb'
- 'ee/lib/ee/api/project_milestones.rb'
@ -1695,7 +1623,6 @@ Style/InlineDisableAnnotation:
- 'ee/lib/gitlab/path_locks_finder.rb'
- 'ee/lib/gitlab/root_excess_size_error_message.rb'
- 'ee/lib/gitlab/search/zoekt/client.rb'
- 'ee/lib/gitlab/status_page/storage/object.rb'
- 'ee/lib/gitlab/status_page/storage/s3_multipart_upload.rb'
- 'ee/lib/gitlab/usage/metrics/instrumentations/license_metric.rb'
- 'ee/lib/gitlab/vulnerability_scanning/advisory.rb'
@ -1704,10 +1631,7 @@ Style/InlineDisableAnnotation:
- 'ee/lib/system_check/geo/authorized_keys_check.rb'
- 'ee/lib/tasks/geo.rake'
- 'ee/locale/unfound_translations.rb'
- 'ee/spec/controllers/concerns/gitlab_subscriptions/seat_count_alert_spec.rb'
- 'ee/spec/controllers/concerns/routable_actions_spec.rb'
- 'ee/spec/controllers/projects/settings/merge_requests_controller_spec.rb'
- 'ee/spec/factories/package_metadata/pm_licenses.rb'
- 'ee/spec/factories/security_scans.rb'
- 'ee/spec/features/dependency_proxy/packages/maven_spec.rb'
- 'ee/spec/features/groups/group_settings_spec.rb'
@ -1717,16 +1641,13 @@ Style/InlineDisableAnnotation:
- 'ee/spec/features/registrations/combined_registration_spec.rb'
- 'ee/spec/features/registrations/saas/standard_flow_with_2fa_spec.rb'
- 'ee/spec/features/subscriptions/subscription_flow_for_existing_user_with_eligible_group_spec.rb'
- 'ee/spec/features/trials/lead_creation_form_validation_spec.rb'
- 'ee/spec/finders/audit_event_finder_spec.rb'
- 'ee/spec/finders/ee/group_members_finder_spec.rb'
- 'ee/spec/helpers/analytics/analytics_dashboards_helper_spec.rb'
- 'ee/spec/helpers/ee/dashboard_helper_spec.rb'
- 'ee/spec/helpers/ee/releases_helper_spec.rb'
- 'ee/spec/initializers/fog_google_https_private_urls_spec.rb'
- 'ee/spec/lib/audit/push_rules/group_push_rules_changes_auditor_spec.rb'
- 'ee/spec/lib/audit/push_rules/project_push_rules_changes_auditor_spec.rb'
- 'ee/spec/lib/code_suggestions/instructions_extractor_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/backfill_iteration_cadence_id_for_boards_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/backfill_missing_vulnerability_dismissal_details_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb'
@ -1736,7 +1657,6 @@ Style/InlineDisableAnnotation:
- 'ee/spec/lib/ee/gitlab/background_migration/populate_denormalized_columns_for_sbom_occurrences_spec.rb'
- 'ee/spec/lib/ee/gitlab/database/docs/docs_spec.rb'
- 'ee/spec/lib/ee/gitlab/import_export/repo_restorer_spec.rb'
- 'ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb'
- 'ee/spec/lib/ee/gitlab/saas_spec.rb'
- 'ee/spec/lib/gitlab/analytics/value_stream_dashboard/namespace_cursor_spec.rb'
- 'ee/spec/lib/gitlab/auth/o_auth/user_spec.rb'
@ -1746,7 +1666,6 @@ Style/InlineDisableAnnotation:
- 'ee/spec/lib/gitlab/email/handler/create_note_handler_spec.rb'
- 'ee/spec/lib/gitlab/geo/cron_manager_spec.rb'
- 'ee/spec/lib/gitlab/geo/every_repository_type_replicated_spec.rb'
- 'ee/spec/lib/gitlab/geo/log_helpers_spec.rb'
- 'ee/spec/lib/gitlab/import_export/group/relation_factory_spec.rb'
- 'ee/spec/lib/gitlab/import_export/project/relation_factory_spec.rb'
- 'ee/spec/lib/gitlab/mirror_spec.rb'
@ -1755,7 +1674,6 @@ Style/InlineDisableAnnotation:
- 'ee/spec/lib/gitlab/timebox/snapshot_builder_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_secure_pipelines_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_security_scans_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_user_merge_requests_for_projects_with_applied_scan_result_policies_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb'
- 'ee/spec/mailers/emails/enterprise_users_spec.rb'
- 'ee/spec/mailers/emails/merge_requests_spec.rb'
@ -1794,8 +1712,6 @@ Style/InlineDisableAnnotation:
- 'ee/spec/requests/api/group_service_accounts_spec.rb'
- 'ee/spec/requests/api/groups_spec.rb'
- 'ee/spec/requests/api/internal/base_spec.rb'
- 'ee/spec/requests/api/vulnerability_findings_spec.rb'
- 'ee/spec/requests/git_http_geo_spec.rb'
- 'ee/spec/requests/groups/issues_controller_spec.rb'
- 'ee/spec/serializers/vulnerabilities/issue_link_entity_spec.rb'
- 'ee/spec/serializers/vulnerabilities/merge_request_link_entity_spec.rb'
@ -1808,7 +1724,6 @@ Style/InlineDisableAnnotation:
- 'ee/spec/services/gitlab_subscriptions/preview_billable_user_change_service_spec.rb'
- 'ee/spec/services/merge_requests/update_blocks_service_spec.rb'
- 'ee/spec/services/package_metadata/sync_service_spec.rb'
- 'ee/spec/services/security/merge_reports_service_spec.rb'
- 'ee/spec/services/security/security_orchestration_policies/policy_branches_service_spec.rb'
- 'ee/spec/services/security/token_revocation_service_spec.rb'
- 'ee/spec/spec_helper.rb'
@ -1824,10 +1739,8 @@ Style/InlineDisableAnnotation:
- 'ee/spec/support/shared_examples/models/concerns/blob_replicator_strategy_shared_examples.rb'
- 'ee/spec/support/shared_examples/models/concerns/linkable_items_shared_examples.rb'
- 'ee/spec/support/shared_examples/models/concerns/replicator_shared_examples.rb'
- 'ee/spec/support/shared_examples/models/elasticsearch_indexed_container_shared_examples.rb'
- 'ee/spec/support/shared_examples/models/geo_framework_registry_shared_examples.rb'
- 'ee/spec/support/shared_examples/models/geo_searchable_registry_shared_examples.rb'
- 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb'
- 'ee/spec/support/shared_examples/requests/api/graphql/geo/registries_shared_examples.rb'
- 'ee/spec/support/shared_examples/services/boards/base_service_shared_examples.rb'
- 'ee/spec/support/shared_examples/workers/geo/framework_registry_sync_worker_shared_examples.rb'
@ -1848,7 +1761,6 @@ Style/InlineDisableAnnotation:
- 'lib/api/access_requests.rb'
- 'lib/api/admin/plan_limits.rb'
- 'lib/api/admin/sidekiq.rb'
- 'lib/api/api.rb'
- 'lib/api/api_guard.rb'
- 'lib/api/appearance.rb'
- 'lib/api/base.rb'
@ -1870,13 +1782,11 @@ Style/InlineDisableAnnotation:
- 'lib/api/entities/basic_project_details.rb'
- 'lib/api/entities/ci/runner_details.rb'
- 'lib/api/entities/feature.rb'
- 'lib/api/entities/issuable_time_stats.rb'
- 'lib/api/entities/ml/mlflow/search_runs.rb'
- 'lib/api/entities/project.rb'
- 'lib/api/entities/project_details.rb'
- 'lib/api/entities/project_integration.rb'
- 'lib/api/entities/project_with_access.rb'
- 'lib/api/entities/tag.rb'
- 'lib/api/features.rb'
- 'lib/api/group_boards.rb'
- 'lib/api/groups.rb'
@ -1897,7 +1807,6 @@ Style/InlineDisableAnnotation:
- 'lib/api/hooks/url_variables.rb'
- 'lib/api/internal/base.rb'
- 'lib/api/internal/workhorse.rb'
- 'lib/api/issue_links.rb'
- 'lib/api/issues.rb'
- 'lib/api/members.rb'
- 'lib/api/merge_requests.rb'
@ -1932,13 +1841,11 @@ Style/InlineDisableAnnotation:
- 'lib/bulk_imports/common/pipelines/lfs_objects_pipeline.rb'
- 'lib/bulk_imports/file_downloads/filename_fetch.rb'
- 'lib/bulk_imports/groups/transformers/group_attributes_transformer.rb'
- 'lib/bulk_imports/pipeline/runner.rb'
- 'lib/bulk_imports/uniquify.rb'
- 'lib/click_house/models/base_model.rb'
- 'lib/click_house/query_builder.rb'
- 'lib/click_house/redactor.rb'
- 'lib/container_registry/path.rb'
- 'lib/container_registry/tag.rb'
- 'lib/declarative_enum.rb'
- 'lib/event_filter.rb'
- 'lib/extracts_path.rb'
@ -1949,13 +1856,11 @@ Style/InlineDisableAnnotation:
- 'lib/gem_extensions/active_record/delegate_cache.rb'
- 'lib/gem_extensions/active_record/disable_joins/associations/association_scope.rb'
- 'lib/gem_extensions/active_record/disable_joins/relation.rb'
- 'lib/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb'
- 'lib/gitlab/analytics/cycle_analytics/aggregated/median.rb'
- 'lib/gitlab/analytics/cycle_analytics/aggregated/records_fetcher.rb'
- 'lib/gitlab/analytics/cycle_analytics/average.rb'
- 'lib/gitlab/analytics/cycle_analytics/base_query_builder.rb'
- 'lib/gitlab/analytics/cycle_analytics/median.rb'
- 'lib/gitlab/analytics/cycle_analytics/records_fetcher.rb'
- 'lib/gitlab/analytics/cycle_analytics/sorting.rb'
- 'lib/gitlab/analytics/cycle_analytics/stage_events/code_stage_start.rb'
- 'lib/gitlab/analytics/cycle_analytics/stage_events/issue_deployed_to_production.rb'
@ -2077,7 +1982,6 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/container_repository/tags/cache.rb'
- 'lib/gitlab/content_security_policy/config_loader.rb'
- 'lib/gitlab/daemon.rb'
- 'lib/gitlab/data_builder/pipeline.rb'
- 'lib/gitlab/data_builder/push.rb'
- 'lib/gitlab/database.rb'
- 'lib/gitlab/database/background_migration/batched_migration.rb'
@ -2117,14 +2021,11 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/database_importers/work_items/related_links_restrictions_importer.rb'
- 'lib/gitlab/dependency_linker/go_mod_linker.rb'
- 'lib/gitlab/dependency_linker/go_sum_linker.rb'
- 'lib/gitlab/diff/file.rb'
- 'lib/gitlab/diff/file_collection/merge_request_diff_batch.rb'
- 'lib/gitlab/diff/file_collection/paginated_diffs.rb'
- 'lib/gitlab/diff/highlight_cache.rb'
- 'lib/gitlab/diff/line.rb'
- 'lib/gitlab/diff/line_mapper.rb'
- 'lib/gitlab/diff/pair_selector.rb'
- 'lib/gitlab/diff/parser.rb'
- 'lib/gitlab/discussions_diff/highlight_cache.rb'
- 'lib/gitlab/doctor/reset_tokens.rb'
- 'lib/gitlab/doctor/secrets.rb'
@ -2134,10 +2035,6 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/email/handler/reply_processing.rb'
- 'lib/gitlab/encoding_helper.rb'
- 'lib/gitlab/encrypted_command_base.rb'
- 'lib/gitlab/encrypted_incoming_email_command.rb'
- 'lib/gitlab/encrypted_redis_command.rb'
- 'lib/gitlab/encrypted_service_desk_email_command.rb'
- 'lib/gitlab/encrypted_smtp_command.rb'
- 'lib/gitlab/error_tracking/processor/context_payload_processor.rb'
- 'lib/gitlab/error_tracking/processor/sanitizer_processor.rb'
- 'lib/gitlab/etag_caching/store.rb'
@ -2151,7 +2048,6 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/git/blob.rb'
- 'lib/gitlab/git/commit.rb'
- 'lib/gitlab/git/diff.rb'
- 'lib/gitlab/git/patches/collection.rb'
- 'lib/gitlab/git/repository.rb'
- 'lib/gitlab/git/tag.rb'
- 'lib/gitlab/git/tree.rb'
@ -2172,10 +2068,8 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/github_import/importer/single_endpoint_diff_notes_importer.rb'
- 'lib/gitlab/github_import/importer/single_endpoint_issue_events_importer.rb'
- 'lib/gitlab/github_import/label_finder.rb'
- 'lib/gitlab/github_import/markdown_text.rb'
- 'lib/gitlab/github_import/milestone_finder.rb'
- 'lib/gitlab/github_import/representation/pull_requests/review_requests.rb'
- 'lib/gitlab/github_import/user_finder.rb'
- 'lib/gitlab/gon_helper.rb'
- 'lib/gitlab/gpg/invalid_gpg_signature_updater.rb'
- 'lib/gitlab/graphql/authorize/authorize_resource.rb'
@ -2190,10 +2084,7 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/graphql/present.rb'
- 'lib/gitlab/graphql/standard_graphql_error.rb'
- 'lib/gitlab/group_search_results.rb'
- 'lib/gitlab/health_checks/metric.rb'
- 'lib/gitlab/health_checks/probes/status.rb'
- 'lib/gitlab/health_checks/redis/redis_abstract_check.rb'
- 'lib/gitlab/health_checks/result.rb'
- 'lib/gitlab/identifier.rb'
- 'lib/gitlab/import/database_helpers.rb'
- 'lib/gitlab/import/errors.rb'
@ -2231,16 +2122,13 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/metrics/subscribers/action_cable.rb'
- 'lib/gitlab/metrics/subscribers/rack_attack.rb'
- 'lib/gitlab/middleware/basic_health_check.rb'
- 'lib/gitlab/middleware/release_env.rb'
- 'lib/gitlab/monitor/demo_projects.rb'
- 'lib/gitlab/nav/top_nav_menu_item.rb'
- 'lib/gitlab/object_hierarchy.rb'
- 'lib/gitlab/otp_key_rotator.rb'
- 'lib/gitlab/pagination/keyset/column_order_definition.rb'
- 'lib/gitlab/pagination/keyset/in_operator_optimization/query_builder.rb'
- 'lib/gitlab/pagination/keyset/iterator.rb'
- 'lib/gitlab/pagination/keyset/order.rb'
- 'lib/gitlab/pagination/keyset/pager.rb'
- 'lib/gitlab/pagination/offset_pagination.rb'
- 'lib/gitlab/pagination_delegate.rb'
- 'lib/gitlab/patch/action_cable_subscription_adapter_identifier.rb'
@ -2259,7 +2147,6 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/rack_attack.rb'
- 'lib/gitlab/rack_attack/request.rb'
- 'lib/gitlab/rack_attack/store.rb'
- 'lib/gitlab/redis/hll.rb'
- 'lib/gitlab/redis/multi_store.rb'
- 'lib/gitlab/reference_extractor.rb'
- 'lib/gitlab/relative_positioning/item_context.rb'
@ -2271,7 +2158,6 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/sanitizers/exif.rb'
- 'lib/gitlab/search/params.rb'
- 'lib/gitlab/search/recent_items.rb'
- 'lib/gitlab/search/sort_options.rb'
- 'lib/gitlab/search_context.rb'
- 'lib/gitlab/search_results.rb'
- 'lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb'
@ -2286,9 +2172,7 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/slash_commands/base_command.rb'
- 'lib/gitlab/slash_commands/deploy.rb'
- 'lib/gitlab/slash_commands/global_slack_handler.rb'
- 'lib/gitlab/slash_commands/issue_search.rb'
- 'lib/gitlab/slash_commands/presenters/run.rb'
- 'lib/gitlab/slash_commands/result.rb'
- 'lib/gitlab/snippet_search_results.rb'
- 'lib/gitlab/source.rb'
- 'lib/gitlab/sourcegraph.rb'
@ -2303,9 +2187,6 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/tracking.rb'
- 'lib/gitlab/uploads/migration_helper.rb'
- 'lib/gitlab/url_builder.rb'
- 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric.rb'
- 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb'
- 'lib/gitlab/usage/metrics/instrumentations/numbers_metric.rb'
- 'lib/gitlab/usage/metrics/query.rb'
- 'lib/gitlab/usage_data.rb'
- 'lib/gitlab/usage_data_counters/merge_request_activity_unique_counter.rb'
@ -2313,12 +2194,10 @@ Style/InlineDisableAnnotation:
- 'lib/gitlab/usage_data_queries.rb'
- 'lib/gitlab/utils/usage_data.rb'
- 'lib/gitlab/verify/batch_verifier.rb'
- 'lib/gitlab/verify/ci_secure_files.rb'
- 'lib/gitlab/verify/rake_task.rb'
- 'lib/gitlab/verify/uploads.rb'
- 'lib/gitlab/webpack/file_loader.rb'
- 'lib/gitlab/workhorse.rb'
- 'lib/gitlab/x509/signature.rb'
- 'lib/gitlab_edition.rb'
- 'lib/gitlab_settings/options.rb'
- 'lib/gitlab_settings/settings.rb'
@ -2396,12 +2275,6 @@ Style/InlineDisableAnnotation:
- 'qa/spec/resource/project_web_hook_spec.rb'
- 'qa/spec/scenario/template_spec.rb'
- 'qa/spec/support/formatters/allure_metadata_formatter_spec.rb'
- 'rubocop/cop/gettext/static_identifier.rb'
- 'rubocop/cop/gitlab/feature_available_usage.rb'
- 'rubocop/cop/migration/add_reference.rb'
- 'rubocop/cop/rspec/factory_bot/inline_association.rb'
- 'rubocop/cop/static_translation_definition.rb'
- 'rubocop/feature_categories.rb'
- 'rubocop/migration_helpers.rb'
- 'rubocop/rubocop.rb'
- 'scripts/api/get_job_id.rb'
@ -2416,8 +2289,6 @@ Style/InlineDisableAnnotation:
- 'scripts/rubocop-parse'
- 'scripts/security-harness'
- 'scripts/trigger-build.rb'
- 'sidekiq_cluster/cli.rb'
- 'sidekiq_cluster/sidekiq_cluster.rb'
- 'spec/benchmarks/banzai_benchmark.rb'
- 'spec/commands/diagnostic_reports/uploader_smoke_spec.rb'
- 'spec/commands/sidekiq_cluster/cli_spec.rb'
@ -2426,10 +2297,8 @@ Style/InlineDisableAnnotation:
- 'spec/config/application_spec.rb'
- 'spec/controllers/concerns/content_security_policy_patch_spec.rb'
- 'spec/controllers/concerns/continue_params_spec.rb'
- 'spec/controllers/groups/milestones_controller_spec.rb'
- 'spec/controllers/omniauth_callbacks_controller_spec.rb'
- 'spec/controllers/profiles/two_factor_auths_controller_spec.rb'
- 'spec/controllers/projects/milestones_controller_spec.rb'
- 'spec/controllers/projects/releases_controller_spec.rb'
- 'spec/controllers/projects/runners_controller_spec.rb'
- 'spec/db/docs_spec.rb'
@ -2441,7 +2310,6 @@ Style/InlineDisableAnnotation:
- 'spec/factories/projects.rb'
- 'spec/factories/projects/ci_feature_usages.rb'
- 'spec/factories/wiki_pages.rb'
- 'spec/features/issues/user_edits_issue_spec.rb'
- 'spec/features/markdown/math_spec.rb'
- 'spec/features/merge_request/user_edits_mr_spec.rb'
- 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb'
@ -2453,7 +2321,6 @@ Style/InlineDisableAnnotation:
- 'spec/finders/groups/projects_requiring_authorizations_refresh/on_transfer_finder_spec.rb'
- 'spec/finders/packages/build_infos_finder_spec.rb'
- 'spec/fixtures/packages/rubygems/package.gemspec'
- 'spec/frontend/fixtures/merge_requests.rb'
- 'spec/graphql/mutations/design_management/delete_spec.rb'
- 'spec/graphql/resolvers/board_resolver_spec.rb'
- 'spec/graphql/resolvers/boards_resolver_spec.rb'
@ -2488,7 +2355,6 @@ Style/InlineDisableAnnotation:
- 'spec/lib/gitlab/auth/o_auth/user_spec.rb'
- 'spec/lib/gitlab/auth/saml/user_spec.rb'
- 'spec/lib/gitlab/authorized_keys_spec.rb'
- 'spec/lib/gitlab/avatar_cache_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_finding_id_in_vulnerabilities_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_missing_ci_cd_settings_spec.rb'
- 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb'
@ -2527,10 +2393,8 @@ Style/InlineDisableAnnotation:
- 'spec/lib/gitlab/doorkeeper_secret_storing/secret/pbkdf2_sha512_spec.rb'
- 'spec/lib/gitlab/doorkeeper_secret_storing/token/pbkdf2_sha512_spec.rb'
- 'spec/lib/gitlab/encoding_helper_spec.rb'
- 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb'
- 'spec/lib/gitlab/git/object_pool_spec.rb'
- 'spec/lib/gitlab/git/remote_mirror_spec.rb'
- 'spec/lib/gitlab/git/tree_spec.rb'
- 'spec/lib/gitlab/grape_logging/loggers/urgency_logger_spec.rb'
- 'spec/lib/gitlab/health_checks/master_check_spec.rb'
- 'spec/lib/gitlab/i18n/po_linter_spec.rb'
@ -2561,18 +2425,13 @@ Style/InlineDisableAnnotation:
- 'spec/lib/gitlab/memory/diagnostic_reports_logger_spec.rb'
- 'spec/lib/gitlab/memory/reports_daemon_spec.rb'
- 'spec/lib/gitlab/memory/reports_uploader_spec.rb'
- 'spec/lib/gitlab/memory/watchdog/configurator_spec.rb'
- 'spec/lib/gitlab/memory/watchdog/handlers/puma_handler_spec.rb'
- 'spec/lib/gitlab/merge_requests/message_generator_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/order_spec.rb'
- 'spec/lib/gitlab/patch/database_config_spec.rb'
- 'spec/lib/gitlab/quick_actions/dsl_spec.rb'
- 'spec/lib/gitlab/redis/multi_store_spec.rb'
- 'spec/lib/gitlab/search/abuse_detection_spec.rb'
- 'spec/lib/gitlab/shard_health_cache_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb'
- 'spec/lib/gitlab/usage/metrics/instrumentations/count_deployments_metric_spec.rb'
- 'spec/lib/gitlab/usage/metrics/instrumentations/gitaly_apdex_metric_spec.rb'
- 'spec/lib/gitlab/usage/service_ping/legacy_metric_metadata_decorator_spec.rb'
@ -2585,7 +2444,6 @@ Style/InlineDisableAnnotation:
- 'spec/lib/mattermost/command_spec.rb'
- 'spec/lib/mattermost/team_spec.rb'
- 'spec/lib/object_storage/pending_direct_upload_spec.rb'
- 'spec/lib/omni_auth/strategies/jwt_spec.rb'
- 'spec/mailers/notify_spec.rb'
- 'spec/migrations/20231016001000_fix_design_user_mentions_design_id_note_id_index_for_self_managed_spec.rb'
- 'spec/models/board_spec.rb'
@ -2598,7 +2456,6 @@ Style/InlineDisableAnnotation:
- 'spec/models/concerns/legacy_bulk_insert_spec.rb'
- 'spec/models/concerns/manual_inverse_association_spec.rb'
- 'spec/models/concerns/noteable_spec.rb'
- 'spec/models/concerns/triggerable_hooks_spec.rb'
- 'spec/models/environment_spec.rb'
- 'spec/models/fork_network_member_spec.rb'
- 'spec/models/hooks/system_hook_spec.rb'
@ -2616,11 +2473,8 @@ Style/InlineDisableAnnotation:
- 'spec/presenters/member_presenter_spec.rb'
- 'spec/presenters/ml/candidates_csv_presenter_spec.rb'
- 'spec/presenters/packages/nuget/search_results_presenter_spec.rb'
- 'spec/presenters/packages/pypi/simple_index_presenter_spec.rb'
- 'spec/presenters/packages/pypi/simple_package_versions_presenter_spec.rb'
- 'spec/requests/api/alert_management_alerts_spec.rb'
- 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb'
- 'spec/requests/api/graphql/ci/config_spec.rb'
- 'spec/requests/api/graphql/groups_query_spec.rb'
- 'spec/requests/api/graphql/issues_spec.rb'
- 'spec/requests/api/graphql/mutations/issues/bulk_update_spec.rb'
@ -2647,11 +2501,9 @@ Style/InlineDisableAnnotation:
- 'spec/serializers/admin/abuse_report_serializer_spec.rb'
- 'spec/serializers/profile/event_entity_spec.rb'
- 'spec/services/admin/set_feature_flag_service_spec.rb'
- 'spec/services/alert_management/metric_images/upload_service_spec.rb'
- 'spec/services/auto_merge/base_service_spec.rb'
- 'spec/services/auto_merge_service_spec.rb'
- 'spec/services/batched_git_ref_updates/cleanup_scheduler_service_spec.rb'
- 'spec/services/boards/lists/list_service_spec.rb'
- 'spec/services/ci/create_pipeline_service/environment_spec.rb'
- 'spec/services/ci/create_pipeline_service/logger_spec.rb'
- 'spec/services/ci/create_pipeline_service_spec.rb'
@ -2687,7 +2539,6 @@ Style/InlineDisableAnnotation:
- 'spec/support/database/click_house/hooks.rb'
- 'spec/support/db_cleaner.rb'
- 'spec/support/fips.rb'
- 'spec/support/forgery_protection.rb'
- 'spec/support/frontend_fixtures.rb'
- 'spec/support/helpers/batch_destroy_dependent_associations_helper.rb'
- 'spec/support/helpers/database/multiple_databases_helpers.rb'
@ -2698,14 +2549,12 @@ Style/InlineDisableAnnotation:
- 'spec/support/helpers/gitaly_setup.rb'
- 'spec/support/helpers/google_api/cloud_platform_helpers.rb'
- 'spec/support/helpers/graphql/subscriptions/action_cable/mock_action_cable.rb'
- 'spec/support/helpers/graphql_helpers.rb'
- 'spec/support/helpers/javascript_fixtures_helpers.rb'
- 'spec/support/helpers/jira_integration_helpers.rb'
- 'spec/support/helpers/login_helpers.rb'
- 'spec/support/helpers/migrations_helpers/vulnerabilities_findings_helper.rb'
- 'spec/support/helpers/migrations_helpers/vulnerabilities_helper.rb'
- 'spec/support/helpers/rendered_helpers.rb'
- 'spec/support/helpers/snowplow_helpers.rb'
- 'spec/support/helpers/stub_feature_flags.rb'
- 'spec/support/helpers/stub_object_storage.rb'
- 'spec/support/helpers/stub_snowplow.rb'
@ -2719,7 +2568,6 @@ Style/InlineDisableAnnotation:
- 'spec/support/shared_examples/db/seeds/data_seeder_shared_examples.rb'
- 'spec/support/shared_examples/deployments/create_for_job_shared_examples.rb'
- 'spec/support/shared_examples/environments/create_for_job_shared_examples.rb'
- 'spec/support/shared_examples/features/editable_merge_request_shared_examples.rb'
- 'spec/support/shared_examples/features/milestone_editing_shared_examples.rb'
- 'spec/support/shared_examples/features/wiki/user_previews_wiki_changes_shared_examples.rb'
- 'spec/support/shared_examples/features/wiki/user_updates_wiki_page_shared_examples.rb'
@ -2738,7 +2586,6 @@ Style/InlineDisableAnnotation:
- 'spec/support/shared_examples/models/issuable_link_shared_examples.rb'
- 'spec/support/shared_examples/models/member_shared_examples.rb'
- 'spec/support/shared_examples/models/packages/debian/component_file_shared_example.rb'
- 'spec/support/shared_examples/models/packages/debian/distribution_key_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/award_emoji_todo_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/graphql/group_and_project_boards_query_shared_examples.rb'

1
.rubocop_todo/style/redundant_interpolation_unfreeze.yml
View File

@ -2,4 +2,3 @@
# Cop supports --autocorrect.
Style/RedundantInterpolationUnfreeze:
Details: grace period
Exclude:

1
.rubocop_todo/style/symbol_proc.yml
View File

@ -131,7 +131,6 @@ Style/SymbolProc:
- 'qa/qa/page/profile/two_factor_auth.rb'
- 'qa/qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/3_create/merge_request/approval_rules_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb'
- 'rubocop/cop/gitlab/mark_used_feature_flags.rb'
- 'rubocop/cop/gitlab/namespaced_class.rb'
- 'scripts/qa/testcases-check'

2
GITALY_SERVER_VERSION
View File

@ -1 +1 @@
052c8f3e6471dc2acba91db014d522880f2c3042
0449fac4772470bb53aec66a54cf671b2116d4f3

2
GITLAB_KAS_VERSION
View File

@ -1 +1 @@
f5b045d8694528efbe2e08984ac5867bdfe41aee
b595a368555ce8d92856d0bccbc3b73638cce63d

19
app/assets/javascripts/boards/components/issue_due_date.vue
View File

@ -65,6 +65,9 @@ export default {
return standardDateFormat;
},
iconName() {
return this.isOverdue ? 'calendar-overdue' : 'calendar';
},
issueDueDate() {
return newDate(this.date);
},
@ -72,7 +75,7 @@ export default {
const today = new Date();
return getDayDifference(today, this.issueDueDate);
},
isPastDue() {
isOverdue() {
if (this.timeDifference >= 0 || this.closed) return false;
return true;
},
@ -94,21 +97,17 @@ export default {
class="board-card-info gl-mr-3 gl-cursor-help gl-text-secondary"
>
<gl-icon
:class="{ 'gl-text-danger': isPastDue }"
:variant="isOverdue ? 'danger' : 'default'"
class="board-card-info-icon gl-mr-2"
name="calendar"
:name="iconName"
/>
<time
:class="{ 'gl-text-danger': isPastDue }"
datetime="date"
class="board-card-info-text gl-text-sm"
>{{ body }}</time
>
<time datetime="date" class="board-card-info-text gl-text-sm">{{ body }}</time>
</span>
<gl-tooltip :target="() => $refs.issueDueDate" :placement="tooltipPlacement">
<span class="gl-font-bold">{{ __('Due date') }}</span>
<br />
<span :class="{ 'gl-text-red-300': isPastDue }">{{ title }}</span>
<span>{{ title }}</span>
<div v-if="isOverdue">({{ __('overdue') }})</div>
</gl-tooltip>
</span>
</template>

12
app/assets/javascripts/ci/catalog/components/details/ci_resource_readme.vue
View File

@ -3,6 +3,7 @@ import { GlLoadingIcon } from '@gitlab/ui';
import { createAlert } from '~/alert';
import { __ } from '~/locale';
import SafeHtml from '~/vue_shared/directives/safe_html';
import { renderGFM } from '~/behaviors/markdown/render_gfm';
import getCiCatalogResourceReadme from '../../graphql/queries/get_ci_catalog_resource_readme.query.graphql';
export default {
@ -47,6 +48,15 @@ export default {
return this.$apollo?.queries.readmeHtml.loading;
},
},
watch: {
readmeHtml(newVal) {
if (newVal) {
this.$nextTick(() => {
renderGFM(this.$refs.readme);
});
}
},
},
i18n: {
loadingError: __("There was a problem loading this project's readme content."),
},
@ -55,6 +65,6 @@ export default {
<template>
<div>
<gl-loading-icon v-if="isLoading" class="gl-mt-5" size="lg" />
<div v-else v-safe-html="readmeHtml" class="md"></div>
<div v-else ref="readme" v-safe-html="readmeHtml" class="md"></div>
</div>
</template>

14
app/assets/javascripts/issues/list/components/issue_card_time_info.vue
View File

@ -2,6 +2,7 @@
import { GlIcon, GlTooltipDirective } from '@gitlab/ui';
import { STATUS_CLOSED } from '~/issues/constants';
import { humanTimeframe, isInPast, localeDateFormat, newDate } from '~/lib/utils/datetime_utility';
import { __ } from '~/locale';
import { STATE_CLOSED } from '~/work_items/constants';
import { isMilestoneWidget, isStartAndDueDateWidget } from '~/work_items/utils';
import IssuableMilestone from '~/vue_shared/issuable/list/components/issuable_milestone.vue';
@ -39,12 +40,18 @@ export default {
isClosed() {
return this.issue.state === STATUS_CLOSED || this.issue.state === STATE_CLOSED;
},
showDueDateInRed() {
isOverdue() {
if (!this.dueDate) {
return false;
}
return isInPast(newDate(this.dueDate)) && !this.isClosed;
},
dueDateTitle() {
return this.isOverdue ? `${__('Due date')} (${__('overdue')})` : __('Due date');
},
dateIcon() {
return this.isOverdue ? 'calendar-overdue' : 'calendar';
},
startDate() {
return this.issue.widgets?.find(isStartAndDueDateWidget)?.startDate;
},
@ -62,11 +69,10 @@ export default {
v-if="dueDateText"
v-gl-tooltip
class="issuable-due-date gl-mr-3"
:class="{ 'gl-text-red-500': showDueDateInRed }"
:title="__('Due date')"
:title="dueDateTitle"
data-testid="issuable-due-date"
>
<gl-icon name="calendar" :size="12" />
<gl-icon :variant="isOverdue ? 'danger' : 'default'" :name="dateIcon" :size="12" />
{{ dueDateText }}
</span>
<span

6
app/assets/javascripts/vue_shared/issuable/list/components/issuable_milestone.vue
View File

@ -47,13 +47,13 @@ export default {
const start = newDate(startDate);
if (dueDate && isInPast(due)) {
return __('Past due');
return __('past due');
}
if (dueDate && isToday(due)) {
return __('Today');
return __('today');
}
if (startDate && isInFuture(start)) {
return __('Upcoming');
return __('upcoming');
}
if (dueDate) {
return getTimeRemainingInWords(due);

1
app/controllers/concerns/groups/params.rb
View File

@ -19,6 +19,7 @@ module Groups
:emails_disabled,
:emails_enabled,
:show_diff_preview_in_email,
:token_expiry_notify_inherited,
:mentions_disabled,
:lfs_enabled,
:name,

2
app/controllers/concerns/issuable_actions.rb
View File

@ -280,7 +280,6 @@ module IssuableActions
@project || @group # rubocop:disable Gitlab/ModuleWithInstanceVariables
end
# rubocop:disable Gitlab/ModuleWithInstanceVariables
def finder_params_for_issuable
{
notes_filter: notes_filter,
@ -288,7 +287,6 @@ module IssuableActions
per_page: params[:per_page]
}
end
# rubocop:enable Gitlab/ModuleWithInstanceVariables
end
IssuableActions.prepend_mod_with('IssuableActions')

3
app/controllers/concerns/preview_markdown.rb
View File

@ -3,7 +3,6 @@
module PreviewMarkdown
extend ActiveSupport::Concern
# rubocop:disable Gitlab/ModuleWithInstanceVariables
def preview_markdown
result = PreviewMarkdownService.new(
container: resource_parent,
@ -62,6 +61,4 @@ module PreviewMarkdown
allow_comments: !browser.ie?
)
end
# rubocop:enable Gitlab/ModuleWithInstanceVariables
end

4
app/controllers/concerns/renders_notes.rb
View File

@ -27,15 +27,11 @@ module RendersNotes
project.team.contribution_check_for_user_ids(access)
end
# rubocop: disable CodeReuse/ActiveRecord
def preload_noteable_for_regular_notes(notes)
ActiveRecord::Associations::Preloader.new(records: notes.reject(&:for_commit?), associations: :noteable).call
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: disable CodeReuse/ActiveRecord
def preload_author_status(notes)
ActiveRecord::Associations::Preloader.new(records: notes, associations: { author: :status }).call
end
# rubocop: enable CodeReuse/ActiveRecord
end

2
app/controllers/concerns/web_hooks/hook_log_actions.rb
View File

@ -31,11 +31,9 @@ module WebHooks
private
# rubocop:disable Gitlab/ModuleWithInstanceVariables
def hook_log
@hook_log ||= hook.web_hook_logs.find(params[:id])
end
# rubocop:enable Gitlab/ModuleWithInstanceVariables
def execute_hook
result = WebHooks::Events::ResendService.new(hook_log, current_user: current_user).execute

2
app/controllers/groups/autocomplete_sources_controller.rb
View File

@ -46,7 +46,6 @@ class Groups::AutocompleteSourcesController < Groups::ApplicationController
GroupIssuableAutocompleteSerializer.new
end
# rubocop: disable CodeReuse/ActiveRecord
def target
# TODO https://gitlab.com/gitlab-org/gitlab/-/issues/388541
# type_id is a misnomer. QuickActions::TargetService actually requires an iid.
@ -54,7 +53,6 @@ class Groups::AutocompleteSourcesController < Groups::ApplicationController
.new(container: @group, current_user: current_user)
.execute(params[:type], params[:type_id])
end
# rubocop: enable CodeReuse/ActiveRecord
end
Groups::AutocompleteSourcesController.prepend_mod

2
app/controllers/groups/labels_controller.rb
View File

@ -18,7 +18,7 @@ class Groups::LabelsController < Groups::ApplicationController
format.html do
# at group level we do not want to list project labels,
# we only want `only_group_labels = false` when pulling labels for label filter dropdowns, fetched through json
@labels = available_labels(params.merge(only_group_labels: true)).page(params[:page]) # rubocop: disable CodeReuse/ActiveRecord
@labels = available_labels(params.merge(only_group_labels: true)).page(params[:page])
Preloaders::LabelsPreloader.new(@labels, current_user).preload_all
end
format.json do

2
app/controllers/profiles/notifications_controller.rb
View File

@ -34,7 +34,6 @@ class Profiles::NotificationsController < Profiles::ApplicationController
GroupsFinder.new(current_user, all_available: false).execute.order_name_asc.page(pagination_params[:page])
end
# rubocop: disable CodeReuse/ActiveRecord
def project_notifications_with_preloaded_associations
project_notifications = current_user
.notification_settings
@ -51,7 +50,6 @@ class Profiles::NotificationsController < Profiles::ApplicationController
project_notifications.select { |notification| current_user.can?(:read_project, notification.source) }
end
# rubocop: enable CodeReuse/ActiveRecord
def project_associations
{ namespace: [:route, :owner], group: [], creator: [], project_setting: [] }

2
app/controllers/projects/merge_requests/diffs_controller.rb
View File

@ -38,7 +38,6 @@ class Projects::MergeRequests::DiffsController < Projects::MergeRequests::Applic
render_diffs
end
# rubocop: disable Metrics/AbcSize
def diffs_batch
diff_options_hash = diff_options
diff_options_hash[:paths] = params[:paths] if params[:paths]
@ -86,7 +85,6 @@ class Projects::MergeRequests::DiffsController < Projects::MergeRequests::Applic
render json: PaginatedDiffSerializer.new(current_user: current_user).represent(diffs, options)
end
end
# rubocop: enable Metrics/AbcSize
def diffs_metadata
diffs = @compare.diffs(diff_options)

2
app/controllers/projects/tags_controller.rb
View File

@ -13,7 +13,6 @@ class Projects::TagsController < Projects::ApplicationController
feature_category :source_code_management
urgency :low, [:new, :show, :index]
# rubocop: disable CodeReuse/ActiveRecord
def index
begin
tags_params = params
@ -45,7 +44,6 @@ class Projects::TagsController < Projects::ApplicationController
format.atom { render layout: 'xml', status: status }
end
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: disable CodeReuse/ActiveRecord
def show

2
app/graphql/gitlab_schema.rb
View File

@ -189,4 +189,4 @@ class GitlabSchema < GraphQL::Schema
end
end
GitlabSchema.prepend_mod_with('GitlabSchema') # rubocop: disable Cop/InjectEnterpriseEditionModule
GitlabSchema.prepend_mod_with('GitlabSchema')

2
app/graphql/resolvers/concerns/caching_array_resolver.rb
View File

@ -124,7 +124,7 @@ module CachingArrayResolver
end
def limit(query)
query.limit(query_limit) # rubocop: disable CodeReuse/ActiveRecord
query.limit(query_limit)
end
def all_fields

3
app/graphql/resolvers/labels_resolver.rb
View File

@ -10,7 +10,8 @@ module Resolvers
argument :title, GraphQL::Types::String,
required: false,
description: 'Exact match on title. Cannot be used with `searchTerm`. `searchIn` will be ignored if `title` argument is provided.' # rubocop:disable Layout/LineLength -- This is just a long string
description: 'Exact match on title. Cannot be used with `searchTerm`. ' \
'`searchIn` will be ignored if `title` argument is provided.'
argument :search_term, GraphQL::Types::String,
required: false,

2
app/graphql/resolvers/work_item_references_resolver.rb
View File

@ -43,7 +43,6 @@ module Resolvers
attr_reader :container
# rubocop: disable CodeReuse/ActiveRecord -- #references is not an ActiveRecord method
def find_work_items(references)
epic_refs, issue_refs = references.partition { |r| r.match?(/epics|&/) }
item_ids = references_extractor(issue_refs)&.references(:work_item, ids_only: true) || []
@ -54,7 +53,6 @@ module Resolvers
WorkItem.id_in(item_ids.flatten.compact)
end
# rubocop: enable CodeReuse/ActiveRecord
def references_extractor(refs)
return unless refs.any?

2
app/graphql/types/base_enum.rb
View File

@ -23,7 +23,6 @@ module Types
# end
#
# Disabling descriptions rubocop for a false positive here
# rubocop: disable Graphql/Descriptions
#
def declarative_enum(enum_mod, use_name: true, use_description: true)
graphql_name(enum_mod.name) if use_name
@ -33,7 +32,6 @@ module Types
value(key.to_s.upcase, value: key.to_s, description: content[:description])
end
end
# rubocop: enable Graphql/Descriptions
# Helper to define an enum member for each element of a Rails AR enum
def from_rails_enum(enum, description:)

2
app/graphql/types/board_list_type.rb
View File

@ -55,7 +55,7 @@ module Types
# board lists have a data dependency on label - so we batch load them here
def title
BatchLoader::GraphQL.for(object).batch do |lists, callback|
ActiveRecord::Associations::Preloader.new(records: lists, associations: :label).call # rubocop: disable CodeReuse/ActiveRecord
ActiveRecord::Associations::Preloader.new(records: lists, associations: :label).call
# all list titles are preloaded at this point
lists.each { |list| callback.call(list, list.title) }

2
app/graphql/types/ci/catalog/resources/components/input_type.rb
View File

@ -5,7 +5,6 @@ module Types
module Catalog
module Resources
module Components
# rubocop: disable Graphql/AuthorizeTypes -- Authorization handled by ComponentType -> VersionType
class InputType < BaseObject
graphql_name 'CiCatalogResourceComponentInput'
@ -21,7 +20,6 @@ module Types
field :type, Types::Ci::Catalog::Resources::Components::InputTypeEnum, null: true,
description: 'Type of the input.'
end
# rubocop: enable Graphql/AuthorizeTypes
end
end
end

2
app/graphql/types/ci/catalog/resources/verification_level_enum.rb
View File

@ -4,7 +4,6 @@ module Types
module Ci
module Catalog
module Resources
# rubocop: disable Graphql/AuthorizeTypes -- Authorization handled by ResourceType
class VerificationLevelEnum < BaseEnum
graphql_name 'CiCatalogResourceVerificationLevel'
@ -12,7 +11,6 @@ module Types
value level.upcase, value: level.to_s, description: "The resource is #{level.to_s.titleize}"
end
end
# rubocop: enable Graphql/AuthorizeTypes
end
end
end

4
app/graphql/types/commit_signatures/verification_status_enum.rb
View File

@ -1,7 +1,5 @@
# frozen_string_literal: true
# rubocop:disable Graphql/AuthorizeTypes
module Types
module CommitSignatures
class VerificationStatusEnum < BaseEnum
@ -14,5 +12,3 @@ module Types
end
end
end
# rubocop:enable Graphql/AuthorizeTypes

2
app/graphql/types/issuables/labels/search_field_list_enum.rb
View File

@ -3,7 +3,6 @@
module Types
module Issuables
module Labels
# rubocop: disable Search/NamespacedClass -- not search related
class SearchFieldListEnum < BaseEnum
graphql_name 'LabelSearchFieldList'
description 'List of fields where the provided searchTerm should be looked up'
@ -11,7 +10,6 @@ module Types
value 'TITLE', 'Search in the label title.', value: :title
value 'DESCRIPTION', 'Search in the label description.', value: :description
end
# rubocop: enable Search/NamespacedClass
end
end
end

2
app/graphql/types/packages/helm/dependency_type.rb
View File

@ -12,7 +12,7 @@ module Types
field :alias, GraphQL::Types::String, null: true, description: 'Alias of the dependency.', resolver_method: :resolve_alias
field :condition, GraphQL::Types::String, null: true, description: 'Condition of the dependency.'
field :enabled, GraphQL::Types::Boolean, null: true, description: 'Indicates the dependency is enabled.'
field :import_values, [GraphQL::Types::JSON], null: true, description: 'Import-values of the dependency.', hash_key: :'import-values' # rubocop:disable Graphql/JSONType
field :import_values, [GraphQL::Types::JSON], null: true, description: 'Import-values of the dependency.', hash_key: :'import-values'
field :name, GraphQL::Types::String, null: true, description: 'Name of the dependency.'
field :repository, GraphQL::Types::String, null: true, description: 'Repository of the dependency.'
field :tags, [GraphQL::Types::String], null: true, description: 'Tags of the dependency.'

2
app/graphql/types/projects/service_type_enum.rb
View File

@ -15,7 +15,7 @@ module Types
end
# This prepend must stay here because the dynamic block below depends on it.
prepend_mod # rubocop: disable Cop/InjectEnterpriseEditionModule
prepend_mod
::Integration.available_integration_names(
include_instance_specific: false, include_dev: false, include_disabled: true

4
app/helpers/diff_helper.rb
View File

@ -248,7 +248,7 @@ module DiffHelper
def conflicts(allow_tree_conflicts: false)
return unless merge_request.cannot_be_merged? && merge_request.source_branch_exists? && merge_request.target_branch_exists?
conflicts_service = MergeRequests::Conflicts::ListService.new(merge_request, allow_tree_conflicts: allow_tree_conflicts) # rubocop:disable CodeReuse/ServiceClass
conflicts_service = MergeRequests::Conflicts::ListService.new(merge_request, allow_tree_conflicts: allow_tree_conflicts)
return unless allow_tree_conflicts || conflicts_service.can_be_resolved_in_ui?
@ -267,7 +267,7 @@ module DiffHelper
cached_conflicts_with_types do
# We set skip_content to true since we don't really need the content to list the conflicts and their types
conflicts_service = MergeRequests::Conflicts::ListService.new( # rubocop:disable CodeReuse/ServiceClass
conflicts_service = MergeRequests::Conflicts::ListService.new(
merge_request,
allow_tree_conflicts: true,
skip_content: true

2
app/helpers/lazy_image_tag_helper.rb
View File

@ -31,7 +31,7 @@ module LazyImageTagHelper
end
# Required for Banzai::Filter::ImageLazyLoadFilter
module_function :placeholder_image # rubocop: disable Style/AccessModifierDeclarations
module_function :placeholder_image
private

2
app/helpers/search_helper.rb
View File

@ -335,7 +335,6 @@ module SearchHelper
end
# Autocomplete results for the current user's groups
# rubocop: disable CodeReuse/ActiveRecord
def groups_autocomplete(term, limit = 5)
current_user.authorized_groups.order_id_desc.search(term, use_minimum_char_limit: false).limit(limit).map do |group|
{
@ -348,7 +347,6 @@ module SearchHelper
}
end
end
# rubocop: enable CodeReuse/ActiveRecord
def issue_autocomplete(term)
return [] unless @project.present? && current_user && term =~ /\A#{Issue.reference_prefix}\d+\z/

6
app/helpers/sidebars_helper.rb
View File

@ -36,13 +36,13 @@ module SidebarsHelper
Sidebars::Context.new(**context_data, **args)
end
def super_sidebar_context(user, group:, project:, panel:, panel_type:) # rubocop:disable Metrics/AbcSize
def super_sidebar_context(user, group:, project:, panel:, panel_type:)
return super_sidebar_logged_out_context(panel: panel, panel_type: panel_type) unless user
super_sidebar_logged_in_context(user, group: group, project: project, panel: panel, panel_type: panel_type)
end
def super_sidebar_logged_out_context(panel:, panel_type:) # rubocop:disable Metrics/AbcSize
def super_sidebar_logged_out_context(panel:, panel_type:)
super_sidebar_instance_version_data.merge(super_sidebar_whats_new_data).merge({
is_logged_in: false,
context_switcher_links: context_switcher_links,
@ -59,7 +59,7 @@ module SidebarsHelper
})
end
def super_sidebar_logged_in_context(user, group:, project:, panel:, panel_type:) # rubocop:disable Metrics/AbcSize
def super_sidebar_logged_in_context(user, group:, project:, panel:, panel_type:)
super_sidebar_logged_out_context(panel: panel, panel_type: panel_type).merge({
is_logged_in: true,
is_admin: user.can_admin_all_resources?,

3
app/models/bulk_import.rb
View File

@ -52,13 +52,10 @@ class BulkImport < ApplicationRecord
transition any => :canceled
end
# rubocop:disable Style/SymbolProc
after_transition any => [:finished, :failed, :timeout] do |bulk_import|
bulk_import.update_has_failures
bulk_import.send_completion_notification
end
# rubocop:enable Style/SymbolProc
after_transition any => [:canceled] do |bulk_import|
bulk_import.run_after_commit do
bulk_import.propagate_cancel

2
app/models/clusters/cluster.rb
View File

@ -40,7 +40,7 @@ module Clusters
def self.has_one_cluster_application(name) # rubocop:disable Naming/PredicateName
application = APPLICATIONS[name.to_s]
has_one application.association_name, class_name: application.to_s, inverse_of: :cluster # rubocop:disable Rails/ReflectionClassName
has_one application.association_name, class_name: application.to_s, inverse_of: :cluster
end
has_many :kubernetes_namespaces

2
app/models/compare.rb
View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'set' # rubocop:disable Lint/RedundantRequireStatement -- Ruby 3.1 and earlier needs this. Drop this line after Ruby 3.2+ is only supported.
require 'set' # Ruby 3.1 and earlier needs this. Drop this line after Ruby 3.2+ is only supported.
class Compare
include Gitlab::Utils::StrongMemoize

12
app/models/concerns/cascading_namespace_setting_attribute.rb
View File

@ -229,14 +229,12 @@ module CascadingNamespaceSettingAttribute
def cascaded_ancestor_value(attribute)
return unless namespace.has_parent?
# rubocop:disable GitlabSecurity/SqlInjection
self.class
.select(attribute)
.joins("join unnest(ARRAY[#{namespace_ancestor_ids.join(',')}]) with ordinality t(namespace_id, ord) USING (namespace_id)")
.where("#{attribute} IS NOT NULL")
.order('t.ord')
.limit(1).first&.read_attribute(attribute)
# rubocop:enable GitlabSecurity/SqlInjection
.select(attribute)
.joins("join unnest(ARRAY[#{namespace_ancestor_ids.join(',')}]) with ordinality t(namespace_id, ord) USING (namespace_id)")
.where("#{attribute} IS NOT NULL")
.order('t.ord')
.limit(1).first&.read_attribute(attribute)
end
def application_setting_value(attribute)

2
app/models/concerns/cascading_project_setting_attribute.rb
View File

@ -139,7 +139,6 @@ module CascadingProjectSettingAttribute
def cascaded_ancestor_value(attribute)
return unless direct_ancestor_present?
# rubocop:disable GitlabSecurity/SqlInjection -- model attribute, not user input
NamespaceSetting
.select(attribute)
.joins(
@ -148,7 +147,6 @@ module CascadingProjectSettingAttribute
.where("#{attribute} IS NOT NULL")
.order('t.ord')
.limit(1).first&.read_attribute(attribute)
# rubocop:enable GitlabSecurity/SqlInjection
end
def application_setting_value(attribute)

2
app/models/concerns/from_except.rb
View File

@ -29,9 +29,7 @@ module FromExcept
#
# alias_as - The alias to use for the sub query. Defaults to the name of the
# table of the current model.
# rubocop: disable Gitlab/Except
extend FromSetOperator
define_set_operator Gitlab::SQL::Except
# rubocop: enable Gitlab/Except
end
end

2
app/models/concerns/from_intersect.rb
View File

@ -29,9 +29,7 @@ module FromIntersect
#
# alias_as - The alias to use for the sub query. Defaults to the name of the
# table of the current model.
# rubocop: disable Gitlab/Intersect
extend FromSetOperator
define_set_operator Gitlab::SQL::Intersect
# rubocop: enable Gitlab/Intersect
end
end

2
app/models/concerns/from_union.rb
View File

@ -37,9 +37,7 @@ module FromUnion
#
# alias_as - The alias to use for the sub query. Defaults to the name of the
# table of the current model.
# rubocop: disable Gitlab/Union
extend FromSetOperator
define_set_operator Gitlab::SQL::Union
# rubocop: enable Gitlab/Union
end
end

6
app/models/concerns/issuable.rb
View File

@ -710,15 +710,15 @@ module Issuable
end
def old_escalation_status(assoc)
@_old_escalation_status ||= assoc.fetch(:escalation_status, escalation_status.status_name) # rubocop:disable Gitlab/ModuleWithInstanceVariables -- This is only used here
@_old_escalation_status ||= assoc.fetch(:escalation_status, escalation_status.status_name)
end
def old_total_time_spent(assoc)
@_old_total_time_spent ||= assoc.fetch(:total_time_spent, total_time_spent) # rubocop:disable Gitlab/ModuleWithInstanceVariables -- This is only used here
@_old_total_time_spent ||= assoc.fetch(:total_time_spent, total_time_spent)
end
def old_time_change(assoc)
@_old_time_change ||= assoc.fetch(:time_change, time_change) # rubocop:disable Gitlab/ModuleWithInstanceVariables -- This is only used here
@_old_time_change ||= assoc.fetch(:time_change, time_change)
end
end

2
app/models/concerns/redis_cacheable.rb
View File

@ -57,7 +57,7 @@ module RedisCacheable
end
def with_redis(&block)
Gitlab::Redis::Cache.with(&block) # rubocop:disable CodeReuse/ActiveRecord
Gitlab::Redis::Cache.with(&block)
end
def cast_value_from_cache(attribute, value)

2
app/models/merge_request_diff_commit.rb
View File

@ -64,7 +64,7 @@ class MergeRequestDiffCommit < ApplicationRecord
committer_id: committer.id,
merge_request_diff_id: merge_request_diff_id,
relative_order: index,
sha: Gitlab::Database::ShaAttribute.serialize(sha), # rubocop:disable Cop/ActiveRecordSerialize
sha: Gitlab::Database::ShaAttribute.serialize(sha),
authored_date: Gitlab::Database.sanitize_timestamp(commit_hash[:authored_date]),
committed_date: Gitlab::Database.sanitize_timestamp(commit_hash[:committed_date]),
trailers: Gitlab::Json.dump(commit_hash.fetch(:trailers, {}))

2
app/models/ml/model_version.rb
View File

@ -33,7 +33,7 @@ module Ml
order(model_id: :desc, semver_major: :desc, semver_minor: :desc, semver_patch: :desc)
.select('DISTINCT ON (model_id) *')
}
scope :by_version, ->(version) { where("version LIKE ?", "#{sanitize_sql_like(version)}%") } # rubocop:disable GitlabSecurity/SqlInjection -- we are sanitizing
scope :by_version, ->(version) { where("version LIKE ?", "#{sanitize_sql_like(version)}%") }
scope :for_model, ->(model) { where(project: model.project, model: model) }
scope :including_relations, -> { includes(:project, :model, :candidate) }
scope :order_by_version, ->(order) { reorder(version: order) }

9
app/models/namespace.rb
View File

@ -173,6 +173,7 @@ class Namespace < ApplicationRecord
to: :namespace_settings
delegate :emails_enabled, :emails_enabled=,
to: :namespace_settings, allow_nil: true
delegate :token_expiry_notify_inherited, :token_expiry_notify_inherited=, to: :namespace_settings
delegate :allow_runner_registration_token,
:allow_runner_registration_token=,
to: :namespace_settings
@ -618,6 +619,14 @@ class Namespace < ApplicationRecord
.try(name)
end
def can_modify_token_expiry_notify_inherited?
ancestors.all?(&:token_expiry_notify_inherited)
end
def token_expiry_notify_inherited?
self_and_ancestors.all?(&:token_expiry_notify_inherited)
end
def actual_plan
Plan.default
end

4
app/models/user.rb
View File

@ -159,7 +159,7 @@ class User < ApplicationRecord
dependent: :destroy, # rubocop:disable Cop/ActiveRecordDependent
foreign_key: :owner_id,
inverse_of: :owner,
autosave: true # rubocop:disable Cop/ActiveRecordDependent
autosave: true
# Profile
has_many :keys, -> { regular_keys }, dependent: :destroy # rubocop:disable Cop/ActiveRecordDependent
@ -1476,11 +1476,9 @@ class User < ApplicationRecord
several_namespaces? || admin
end
# rubocop: disable Style/ArgumentsForwarding -- https://gitlab.com/gitlab-org/gitlab/-/issues/433045
def can?(action, subject = :global, **opts)
Ability.allowed?(self, action, subject, **opts)
end
# rubocop: enable Style/ArgumentsForwarding
def confirm_deletion_with_password?
!password_automatically_set? && allow_password_authentication?

4
app/models/wiki_page/meta.rb
View File

@ -124,7 +124,6 @@ class WikiPage
end
strong_memoize_attr :canonical_slug
# rubocop:disable Gitlab/ModuleWithInstanceVariables -- Technical debt
def canonical_slug=(slug)
return if @canonical_slug == slug
@ -140,7 +139,6 @@ class WikiPage
@canonical_slug = slug
end
# rubocop:enable Gitlab/ModuleWithInstanceVariables
def update_state(created, known_slugs, wiki_page, updates)
update_wiki_page_attributes(updates)
@ -173,7 +171,7 @@ class WikiPage
end
slugs.insert_all(slug_attrs) unless !is_new && slug_attrs.size == 1
@canonical_slug = canonical_slug if is_new || strings.size == 1 # rubocop:disable Gitlab/ModuleWithInstanceVariables -- Technical debt
@canonical_slug = canonical_slug if is_new || strings.size == 1
end
def slug_attributes(slug, canonical_slug, is_new, creation)

2
app/presenters/dev_ops_report/metric_presenter.rb
View File

@ -143,10 +143,8 @@ module DevOpsReport
]
end
# rubocop: disable CodeReuse/ActiveRecord
def average_percentage_score
cards.sum(&:percentage_score) / cards.size.to_f
end
# rubocop: enable CodeReuse/ActiveRecord
end
end

6
app/serializers/diffs_entity.rb
View File

@ -43,18 +43,12 @@ class DiffsEntity < Grape::Entity
diffs_project_merge_request_path(merge_request&.project, merge_request)
end
# rubocop: disable CodeReuse/ActiveRecord
expose :added_lines do |diffs|
diffs.raw_diff_files.sum(&:added_lines)
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: disable CodeReuse/ActiveRecord
expose :removed_lines do |diffs|
diffs.raw_diff_files.sum(&:removed_lines)
end
# rubocop: enable CodeReuse/ActiveRecord
expose :render_overflow_warning do |diffs|
render_overflow_warning?(diffs)
end

2
app/serializers/fork_namespace_entity.rb
View File

@ -32,13 +32,11 @@ class ForkNamespaceEntity < Grape::Entity
private
# rubocop: disable CodeReuse/ActiveRecord
def membership(user, object, memberships)
return unless user
memberships[object.id]
end
# rubocop: enable CodeReuse/ActiveRecord
def markdown_description(namespace)
markdown_field(namespace, :description)

2
app/services/boards/base_items_list_service.rb
View File

@ -136,11 +136,9 @@ module Boards
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: disable CodeReuse/ActiveRecord
def label_links(items, label_ids)
labels_filter.label_link_query(items, label_ids: label_ids)
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: disable CodeReuse/ActiveRecord
def with_list_label(items)

2
app/services/ci/job_artifacts/destroy_batch_service.rb
View File

@ -24,7 +24,6 @@ module Ci
@destroyed_ids = []
end
# rubocop: disable CodeReuse/ActiveRecord
def execute(update_stats: true)
if @skip_projects_on_refresh
exclude_artifacts_undergoing_stats_refresh
@ -60,7 +59,6 @@ module Ci
statistics_updates: statistics_updates_per_project
)
end
# rubocop: enable CodeReuse/ActiveRecord
private

3
app/services/ci/runners/bulk_delete_runners_service.rb
View File

@ -45,13 +45,10 @@ module Ci
end
def compute_authorized_runners
# rubocop:disable CodeReuse/ActiveRecord
@current_user.ci_owned_runners.load # preload the owned runners to avoid an N+1
authorized_runners, unauthorized_runners =
@runners.limit(RUNNER_LIMIT)
.partition { |runner| Ability.allowed?(@current_user, :delete_runner, runner) }
# rubocop:enable CodeReuse/ActiveRecord
[authorized_runners.map(&:id), unauthorized_runners.map(&:id)]
end

2
app/services/database/consistency_check_service.rb
View File

@ -74,7 +74,6 @@ module Database
fetch_next_start_id || random_start_id
end
# rubocop: disable CodeReuse/ActiveRecord
def min_id
@min_id ||= source_model.minimum(source_sort_column)
end
@ -82,7 +81,6 @@ module Database
def max_id
@max_id ||= source_model.maximum(source_sort_column)
end
# rubocop: enable CodeReuse/ActiveRecord
def fetch_next_start_id
Gitlab::Redis::SharedState.with { |redis| redis.get(cursor_redis_shared_state_key)&.to_i }

2
app/services/design_management/copy_design_collection/copy_service.rb
View File

@ -267,7 +267,6 @@ module DesignManagement
end
# rubocop: enable CodeReuse/ActiveRecord
# rubocop: disable CodeReuse/ActiveRecord
def link_lfs_files!
oids = blobs.values.flat_map(&:values).map(&:lfs_oid)
repository_type = LfsObjectsProject.repository_types[:design]
@ -292,7 +291,6 @@ module DesignManagement
on_conflict: :do_nothing # Upsert
)
end
# rubocop: enable CodeReuse/ActiveRecord
# Blob data is used to find the oids for LfsObjects and to copy to Git.
# Blobs are reasonably small in memory, as their data are LFS Pointer files.

2
app/services/groups/destroy_service.rb
View File

@ -94,7 +94,6 @@ module Groups
group.users_ids_of_direct_members
end
# rubocop:disable CodeReuse/ActiveRecord
def destroy_associated_users
current_user_id = current_user.id
bot_ids = users_to_destroy
@ -105,7 +104,6 @@ module Groups
end
end
end
# rubocop:enable CodeReuse/ActiveRecord
# rubocop:disable CodeReuse/ActiveRecord
def users_to_destroy

4
app/services/groups/import_export/import_service.rb
View File

@ -53,12 +53,12 @@ module Groups
private
def user_role
# rubocop:disable CodeReuse/ActiveRecord, Style/MultilineTernaryOperator
# rubocop:disable Style/MultilineTernaryOperator
access_level = group.parent ?
current_user&.group_members&.find_by(source_id: group.parent&.id)&.access_level :
Gitlab::Access::OWNER
Gitlab::Access.human_access(access_level)
# rubocop:enable CodeReuse/ActiveRecord, Style/MultilineTernaryOperator
# rubocop:enable Style/MultilineTernaryOperator
end
def import_file

4
app/services/import/placeholder_references/push_service.rb
View File

@ -26,7 +26,9 @@ module Import
end
end
def initialize(import_source:, import_uid:, source_user_id:, source_user_namespace_id:, model:, user_reference_column:, numeric_key: nil, composite_key: nil) # rubocop:disable Layout/LineLength -- Its easier to read being on one line
def initialize(
import_source:, import_uid:, source_user_id:, source_user_namespace_id:, model:,
user_reference_column:, numeric_key: nil, composite_key: nil)
super(import_source: import_source, import_uid: import_uid)
@reference = Import::SourceUserPlaceholderReference.new(

Some files were not shown because too many files have changed in this diff Show More