From 0e5ce539275e32cfd7592362e03673807fca9cc7 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 15 Jun 2023 18:09:29 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/setup.gitlab-ci.yml | 3 + .../pages/admin/jobs/components/constants.js | 12 +- .../components/pipeline_details_header.vue | 5 +- .../search/sort/components/app.vue | 58 ++-- .../stylesheets/page_bundles/login.scss | 9 +- app/assets/stylesheets/pages/note_form.scss | 2 +- app/helpers/ci/runners_helper.rb | 7 +- app/models/ci/job_artifact.rb | 4 +- app/views/projects/diffs/_file.html.haml | 7 +- doc/api/integrations.md | 11 + doc/development/code_review.md | 2 +- .../documentation/restful_api_styleguide.md | 18 +- doc/development/rake_tasks.md | 2 +- lib/api/admin/dictionary.rb | 61 ++++ lib/api/api.rb | 1 + lib/api/entities/dictionary/table.rb | 12 + lib/api/helpers/integrations_helpers.rb | 12 +- locale/gitlab.pot | 8 +- scripts/api/create_merge_request_note.rb | 22 ++ .../generate-message-to-run-e2e-pipeline.rb | 106 +++++++ spec/frontend/fixtures/pipeline_header.rb | 26 ++ spec/frontend/pipelines/mock_data.js | 8 +- .../pipelines/pipeline_details_header_spec.js | 14 + .../search/sort/components/app_spec.js | 23 +- .../lib/atlassian/jira_connect/client_spec.rb | 7 +- .../serializers/deployment_entity_spec.rb | 2 +- .../project_error_tracking_setting_spec.rb | 2 +- spec/requests/api/admin/dictionary_spec.rb | 59 ++++ spec/requests/api/integrations_spec.rb | 1 - .../api/create_merge_request_note_spec.rb | 37 +++ ...nerate_message_to_run_e2e_pipeline_spec.rb | 279 ++++++++++++++++++ 31 files changed, 742 insertions(+), 78 deletions(-) create mode 100644 lib/api/admin/dictionary.rb create mode 100644 lib/api/entities/dictionary/table.rb create mode 100644 scripts/api/create_merge_request_note.rb create mode 100755 scripts/generate-message-to-run-e2e-pipeline.rb create mode 100644 spec/requests/api/admin/dictionary_spec.rb create mode 100644 spec/scripts/api/create_merge_request_note_spec.rb create mode 100644 spec/scripts/generate_message_to_run_e2e_pipeline_spec.rb diff --git a/.gitlab/ci/setup.gitlab-ci.yml b/.gitlab/ci/setup.gitlab-ci.yml index 85409d37fa4..0323c2dcb91 100644 --- a/.gitlab/ci/setup.gitlab-ci.yml +++ b/.gitlab/ci/setup.gitlab-ci.yml @@ -167,6 +167,9 @@ e2e-test-pipeline-generate: script: - bundle exec rake "ci:detect_changes[$ENV_FILE]" - cd $CI_PROJECT_DIR && scripts/generate-e2e-pipeline + - source scripts/utils.sh + - install_gitlab_gem + - scripts/generate-message-to-run-e2e-pipeline.rb artifacts: expire_in: 1 day paths: diff --git a/app/assets/javascripts/pages/admin/jobs/components/constants.js b/app/assets/javascripts/pages/admin/jobs/components/constants.js index 8c4ea2cde92..4af8cb355fc 100644 --- a/app/assets/javascripts/pages/admin/jobs/components/constants.js +++ b/app/assets/javascripts/pages/admin/jobs/components/constants.js @@ -1,5 +1,5 @@ import { s__, __ } from '~/locale'; -import { DEFAULT_FIELDS, RAW_TEXT_WARNING } from '~/jobs/components/table/constants'; +import { RAW_TEXT_WARNING } from '~/jobs/components/table/constants'; export const JOBS_COUNT_ERROR_MESSAGE = __('There was an error fetching the number of jobs.'); export const JOBS_FETCH_ERROR_MSG = __('There was an error fetching the jobs.'); @@ -19,11 +19,17 @@ export const RUNNER_EMPTY_TEXT = __('None'); export const RUNNER_NO_DESCRIPTION = s__('Runners|No description'); /* Admin Table constants */ +/* The field list is based on app/assets/javascripts/jobs/components/table/constants.js */ export const DEFAULT_FIELDS_ADMIN = [ - ...DEFAULT_FIELDS.slice(0, 2), + { key: 'status', label: __('Status'), columnClass: 'gl-w-15p' }, + { key: 'job', label: __('Job'), columnClass: 'gl-w-20p' }, { key: 'project', label: __('Project'), columnClass: 'gl-w-20p' }, { key: 'runner', label: __('Runner'), columnClass: 'gl-w-15p' }, - ...DEFAULT_FIELDS.slice(2), + { key: 'pipeline', label: __('Pipeline'), columnClass: 'gl-w-10p' }, + { key: 'stage', label: __('Stage'), columnClass: 'gl-w-10p' }, + { key: 'name', label: __('Name'), columnClass: 'gl-w-15p' }, + { key: 'duration', label: __('Duration'), columnClass: 'gl-w-15p' }, + { key: 'actions', label: '', columnClass: 'gl-w-10p' }, ]; export const RAW_TEXT_WARNING_ADMIN = RAW_TEXT_WARNING; diff --git a/app/assets/javascripts/pipelines/components/pipeline_details_header.vue b/app/assets/javascripts/pipelines/components/pipeline_details_header.vue index d4cdae5d69c..8fe6707028a 100644 --- a/app/assets/javascripts/pipelines/components/pipeline_details_header.vue +++ b/app/assets/javascripts/pipelines/components/pipeline_details_header.vue @@ -280,6 +280,9 @@ export default { duration() { return this.pipeline?.duration || 0; }, + showDuration() { + return this.duration && this.isFinished; + }, durationFormatted() { return timeIntervalInWords(this.duration); }, @@ -560,7 +563,7 @@ export default { {{ inProgressText }} - + {{ durationText }} diff --git a/app/assets/javascripts/search/sort/components/app.vue b/app/assets/javascripts/search/sort/components/app.vue index 2bf144705c4..9f28d2bfc99 100644 --- a/app/assets/javascripts/search/sort/components/app.vue +++ b/app/assets/javascripts/search/sort/components/app.vue @@ -1,21 +1,14 @@