Merge branch '66741-remove-spec-rails_helper-rb' into 'master'

Remove spec/rails_helper.rb

Closes #66741

See merge request gitlab-org/gitlab-ce!32380
This commit is contained in:
Grzegorz Bizon 2019-09-03 13:48:17 +00:00
commit 1068ec2e92
242 changed files with 240 additions and 244 deletions

View File

@ -264,8 +264,6 @@ RSpec/EnvAssignment:
Exclude:
- 'spec/**/fast_spec_helper.rb'
- 'ee/spec/**/fast_spec_helper.rb'
- 'spec/**/rails_helper.rb'
- 'ee/spec/**/rails_helper.rb'
- 'spec/**/spec_helper.rb'
- 'ee/spec/**/spec_helper.rb'
RSpec/BeSuccessMatcher:

View File

@ -3,7 +3,7 @@
require 'bundler/setup'
require 'stackprof'
$:.unshift 'spec'
require 'rails_helper'
require 'spec_helper'
filename = ARGV[0].split('/').last
interval = ENV.fetch('INTERVAL', 1000).to_i

View File

@ -18,7 +18,7 @@ end
Consider the following API spec:
```ruby
require 'rails_helper'
require 'spec_helper'
describe API::Labels do
it 'creates a first label' do
@ -69,7 +69,7 @@ is ok, but `create(:label, title: 'label1')` is not.
Following is the fixed API spec:
```ruby
require 'rails_helper'
require 'spec_helper'
describe API::Labels do
it 'creates a first label' do

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe Projects::BlobController do
include ProjectForksHelper

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe SentNotificationsController do
let(:user) { create(:user) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Admin disables Git access protocol', :js do
include StubENV

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Admin disables 2FA for a user' do
it 'successfully', :js do

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Admin uses repository checks' do
include StubENV

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issue Boards add issue modal', :js do
let(:project) { create(:project, :public) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issue Boards', :js do
include DragTo

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issue Boards', :js do
include DragTo

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issue Boards shortcut', :js do
context 'issues are enabled' do

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issue Boards add issue modal filtering', :js do
let(:project) { create(:project, :public) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Multiple Issue Boards', :js do
set(:user) { create(:user) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issue Boards new issue', :js do
let(:project) { create(:project, :public) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Ensure Boards do not show stale data on browser back', :js do
let(:project) {create(:project, :public)}

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issue Boards', :js do
include BoardHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Sub-group project issue boards', :js do
let(:group) { create(:group) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Commit > User uses quick actions', :js do
include Spec::Support::Helpers::Features::NotesHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Dashboard > Todo target states' do
let(:user) { create(:user) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Group Issue Boards', :js do
include BoardHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Group Boards' do
let(:group) { create(:group) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Group milestones' do
let(:group) { create(:group) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'User browse group projects page' do
let(:user) { create :user }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Cohorts page' do
before do

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Cohorts page', :js do
before do

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'issuable list' do
let(:project) { create(:project) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require "rails_helper"
require 'spec_helper'
describe "Internal references", :js do
include Spec::Support::Helpers::Features::NotesHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require "rails_helper"
require 'spec_helper'
describe "Jira", :js do
let(:user) { create(:user) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issue Sidebar on Mobile' do
include MobileHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issues > Labels bulk assignment' do
let(:user) { create(:user) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Resolving all open threads in a merge request from an issue', :js do
let(:user) { create(:user) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Resolve an open thread in a merge request by creating an issue', :js do
let(:user) { create(:user) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Dropdown assignee', :js do
include FilteredSearchHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Dropdown author', :js do
include FilteredSearchHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Dropdown emoji', :js do
include FilteredSearchHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Dropdown hint', :js do
include FilteredSearchHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Dropdown milestone', :js do
include FilteredSearchHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Search bar', :js do
include FilteredSearchHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Visual tokens', :js do
include FilteredSearchHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'New/edit issue', :js do
include ActionView::Helpers::JavaScriptHelper

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'GFM autocomplete', :js do
let(:issue_xss_title) { 'This will execute alert<img src=x onerror=alert(2)&lt;img src=x onerror=alert(1)&gt;' }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Group label on issue' do
it 'renders link to the project issues page' do

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issue Detail', :js do
let(:user) { create(:user) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issue Sidebar' do
include MobileHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issues shortcut', :js do
context 'New Issue shortcut' do

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Issue markdown toolbar', :js do
let(:project) { create(:project, :public) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'issue move to another project' do
let(:user) { create(:user) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'List issue resource label events', :js do
let(:user) { create(:user) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'New issue', :js do
include StubENV

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Manually create a todo item from issue', :js do
let!(:project) { create(:project) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Multiple issue updating from issues#index', :js do
let!(:project) { create(:project) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'User creates branch and merge request on issue page', :js do
let(:membership_level) { :developer }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'User creates confidential merge request on issue page', :js do
include ProjectForksHelper

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'New issue breadcrumb' do
let(:project) { create(:project) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
# These are written as feature specs because they cover more specific test scenarios
# than the ones described on spec/services/notes/create_service_spec.rb for quick actions,

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User assigns themselves' do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User awards emoji', :js do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User creates MR' do
include ProjectForksHelper

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request < User customizes merge commit message', :js do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User locks discussion', :js do
let(:user) { create(:user) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge requests > User merges immediately', :js do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User merges only if pipeline succeeds', :js do
let(:merge_request) { create(:merge_request_with_diffs) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User merges when pipeline succeeds', :js do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User posts diff notes', :js do
include MergeRequestDiffHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User posts notes', :js do
include NoteInteractionHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User resolves conflicts', :js do
let(:project) { create(:project, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User resolves diff notes and threads', :js do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User scrolls to note on load', :js do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees avatars on diff notes', :js do
include NoteInteractionHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'New merge request breadcrumb' do
let(:project) { create(:project, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees check out branch modal', :js do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User cherry-picks', :js do
let(:group) { create(:group) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees closing issues message', :js do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees deleted target branch', :js do
let(:merge_request) { create(:merge_request) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees deployment widget', :js do
describe 'when merge request has associated environments' do

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees diff', :js do
include ProjectForksHelper

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees threads', :js do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees empty state' do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees merge button depending on unresolved threads', :js do
let(:project) { create(:project, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees pipelines triggered by merge request', :js do
include ProjectForksHelper

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees merge widget', :js do
include ProjectForksHelper

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request < User sees mini pipeline graph', :js do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees MR from deleted forked project', :js do
include ProjectForksHelper

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
# This test serves as a regression test for a bug that caused an error
# message to be shown by JavaScript when the source branch was deleted.

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees notes from forked project', :js do
include ProjectForksHelper

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees pipelines from forked project', :js do
include ProjectForksHelper

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees pipelines', :js do
describe 'pipeline tab' do

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees system notes', :js do
let(:public_project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees versions', :js do
let(:merge_request) do

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User sees WIP help message' do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User selects branches for new MR', :js do
let(:project) { create(:project, :public, :repository) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge request > User toggles whitespace changes', :js do
let(:merge_request) { create(:merge_request) }

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
# These are written as feature specs because they cover more specific test scenarios
# than the ones described on spec/services/notes/create_service_spec.rb for quick actions,

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge Requests > Filters generic behavior', :js do
include FilteredSearchHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge Requests > User filters by assignees', :js do
include FilteredSearchHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge Requests > User filters by labels', :js do
include FilteredSearchHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge Requests > User filters by milestones', :js do
include FilteredSearchHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge requests > User filters by multiple criteria', :js do
include FilteredSearchHelpers

View File

@ -1,6 +1,6 @@
# frozen_string_literal: true
require 'rails_helper'
require 'spec_helper'
describe 'Merge Requests > User filters by target branch', :js do
include FilteredSearchHelpers

Some files were not shown because too many files have changed in this diff Show More