From 11a29f1f026ecd0c466625782af00a14889a2f91 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 25 Aug 2020 15:10:17 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/CODEOWNERS | 3 + .gitlab/ci/rails.gitlab-ci.yml | 3 +- .gitlab/ci/rules.gitlab-ci.yml | 10 + .gitlab/ci/setup.gitlab-ci.yml | 11 + CHANGELOG.md | 8 - .../components/design_notes/design_note.vue | 12 +- .../states/mr_widget_failed_to_merge.vue | 10 +- app/assets/stylesheets/framework/wells.scss | 4 - app/graphql/types/query_type.rb | 10 + app/views/admin/dashboard/index.html.haml | 10 +- app/views/import/fogbugz/new.html.haml | 5 +- .../import/fogbugz/new_user_map.html.haml | 5 +- app/views/import/fogbugz/status.html.haml | 5 +- .../projects/_import_project_pane.html.haml | 3 +- ...design-comments-text-wrapping-behavior.yml | 5 + ...fa-bugs-icons-with-gitlab-svg-bug-icon.yml | 5 + ...gitlab-ui-glbutton-in-app-assets-javas.yml | 5 + ...7248-add-api-to-monitor-issue-creation.yml | 5 + ...-fix-nil-line-codes-for-diff-positions.yml | 5 + .../graphql/reference/gitlab_schema.graphql | 15 + doc/api/graphql/reference/gitlab_schema.json | 37 +++ doc/api/issues.md | 314 ++++++++++++++++++ doc/user/project/import/github.md | 4 +- lib/api/issues.rb | 13 + lib/gitlab/danger/helper.rb | 1 + locale/gitlab.pot | 12 + package.json | 4 +- .../create_project_with_auto_devops_spec.rb | 4 +- .../kubernetes/kubernetes_integration_spec.rb | 2 +- .../all_monitor_core_features_spec.rb | 10 +- scripts/rspec_helpers.sh | 4 +- scripts/utils.sh | 4 + scripts/verify-tff-mapping | 163 +++++++++ .../__snapshots__/design_note_spec.js.snap | 11 +- .../design_notes/design_note_spec.js | 6 +- .../states/mr_widget_failed_to_merge_spec.js | 6 +- spec/graphql/types/query_type_spec.rb | 9 + spec/requests/api/graphql/issue/issue_spec.rb | 126 +++++++ spec/requests/api/issues/issues_spec.rb | 45 +++ tests.yml | 54 +++ tooling/bin/find_foss_tests | 12 +- yarn.lock | 16 +- 42 files changed, 925 insertions(+), 71 deletions(-) create mode 100644 changelogs/unreleased/209770-design-comments-text-wrapping-behavior.yml create mode 100644 changelogs/unreleased/225939-replace-fa-bugs-icons-with-gitlab-svg-bug-icon.yml create mode 100644 changelogs/unreleased/229296-migrate-bootstrap-button-to-gitlab-ui-glbutton-in-app-assets-javas.yml create mode 100644 changelogs/unreleased/37248-add-api-to-monitor-issue-creation.yml create mode 100644 changelogs/unreleased/id-fix-nil-line-codes-for-diff-positions.yml create mode 100755 scripts/verify-tff-mapping create mode 100644 spec/requests/api/graphql/issue/issue_spec.rb create mode 100644 tests.yml diff --git a/.gitlab/CODEOWNERS b/.gitlab/CODEOWNERS index 7a5516338e8..2cf8db04bb9 100644 --- a/.gitlab/CODEOWNERS +++ b/.gitlab/CODEOWNERS @@ -165,12 +165,15 @@ /.gitlab/ci/ @gl-quality/eng-prod /.gitlab/ci/docs.gitlab-ci.yml @gl-quality/eng-prod @gl-docsteam /.gitlab/ci/releases.gitlab-ci.yml @gl-quality/eng-prod @gitlab-org/delivery +/.gitlab/ci/dast.gitlab-ci.yml @dappelt @ngeorge1 @gl-quality/eng-prod +/.gitlab/ci/reports.gitlab-ci.yml @gitlab-com/gl-security/appsec @gl-quality/eng-prod /.gitlab/CODEOWNERS @gl-quality/eng-prod Dangerfile @gl-quality/eng-prod /danger/ @gl-quality/eng-prod /lib/gitlab/danger/ @gl-quality/eng-prod /scripts/ @gl-quality/eng-prod /scripts/frontend/ @gl-quality/eng-prod @gitlab-org/maintainers/frontend +/scripts/review_apps/seed-dast-test-data.sh @dappelt @ngeorge1 @gl-quality/eng-prod .editorconfig @gl-quality/eng-prod [End-to-end] diff --git a/.gitlab/ci/rails.gitlab-ci.yml b/.gitlab/ci/rails.gitlab-ci.yml index 0b54626f690..6acd52382cf 100644 --- a/.gitlab/ci/rails.gitlab-ci.yml +++ b/.gitlab/ci/rails.gitlab-ci.yml @@ -496,11 +496,12 @@ rspec foss-impact: - .rails:rules:ee-mr-only script: - install_gitlab_gem + - install_tff_gem - run_timed_command "scripts/gitaly-test-build" - run_timed_command "scripts/gitaly-test-spawn" - source scripts/rspec_helpers.sh - tooling/bin/find_foss_tests tmp/matching_foss_tests.txt - - rspec_matched_tests tmp/matching_foss_tests.txt "--tag ~quarantine" + - rspec_matched_foss_tests tmp/matching_foss_tests.txt "--tag ~quarantine" artifacts: expire_in: 7d paths: diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index 49f96eeac74..b2836d2600e 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -149,6 +149,7 @@ - "*_VERSION" - "Gemfile{,.lock}" - "Rakefile" + - "tests.yml" - "config.ru" - "{,ee/}{app,bin,config,db,haml_lint,lib,locale,public,scripts,symbol,vendor}/**/*" - "doc/api/graphql/reference/*" # Files in this folder are auto-generated @@ -170,6 +171,7 @@ - "*_VERSION" - "Gemfile{,.lock}" - "Rakefile" + - "tests.yml" - "config.ru" - "{,ee/}{app,bin,config,db,haml_lint,lib,locale,public,scripts,symbol,vendor}/**/*" - "doc/api/graphql/reference/*" # Files in this folder are auto-generated @@ -193,6 +195,7 @@ - "*_VERSION" - "Gemfile{,.lock}" - "Rakefile" + - "tests.yml" - "config.ru" - "{,ee/}{app,bin,config,db,haml_lint,lib,locale,public,scripts,symbol,vendor}/**/*" - "doc/api/graphql/reference/*" # Files in this folder are auto-generated @@ -213,6 +216,7 @@ - "*_VERSION" - "Gemfile{,.lock}" - "Rakefile" + - "tests.yml" - "config.ru" - "{,ee/}{app,bin,config,db,haml_lint,lib,locale,public,scripts,symbol,vendor}/**/*" - "doc/api/graphql/reference/*" # Files in this folder are auto-generated @@ -762,6 +766,12 @@ changes: *code-backstage-patterns when: on_success +.setup:rules:verify-tests-yml: + rules: + - <<: *if-default-refs + changes: *code-backstage-patterns + when: on_success + ####################### # Test metadata rules # ####################### diff --git a/.gitlab/ci/setup.gitlab-ci.yml b/.gitlab/ci/setup.gitlab-ci.yml index 26c7a2194cc..b2b64700b18 100644 --- a/.gitlab/ci/setup.gitlab-ci.yml +++ b/.gitlab/ci/setup.gitlab-ci.yml @@ -48,3 +48,14 @@ no_ee_check: stage: test script: - scripts/no-ee-check + +verify-tests-yml: + extends: + - .setup:rules:verify-tests-yml + image: ruby:2.6-alpine + stage: test + needs: [] + script: + - source scripts/utils.sh + - install_tff_gem + - scripts/verify-tff-mapping diff --git a/CHANGELOG.md b/CHANGELOG.md index 99a0b061a29..d7bb4ac918d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,14 +2,6 @@ documentation](doc/development/changelog.md) for instructions on adding your own entry. -## 13.3.1 (2020-08-25) - -### Fixed (2 changes) - -- Fix bug when promoting an Issue with attachments to an Epic. !39654 -- Avoid creating diff position when line-code is nil. !40089 - - ## 13.3.0 (2020-08-22) ### Security (2 changes) diff --git a/app/assets/javascripts/design_management/components/design_notes/design_note.vue b/app/assets/javascripts/design_management/components/design_notes/design_note.vue index 172e61920ef..ab64e5c43db 100644 --- a/app/assets/javascripts/design_management/components/design_notes/design_note.vue +++ b/app/assets/javascripts/design_management/components/design_notes/design_note.vue @@ -102,12 +102,12 @@ export default { - + + +
diff --git a/app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_failed_to_merge.vue b/app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_failed_to_merge.vue index 9df0c045fe4..a5ec095b8ec 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_failed_to_merge.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/states/mr_widget_failed_to_merge.vue @@ -1,4 +1,5 @@