root
/
gitlab-ce
mirror of https://gitlab.com/free-releases/gitlab-ce.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Add latest changes from gitlab-org/gitlab@master

This commit is contained in:
GitLab Bot 2023-02-16 12:08:03 +00:00
parent b1a0a71628
commit 12166c0faf
180 changed files with 1178 additions and 1183 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.rubocop_todo/capybara/visibility_matcher.yml
View File

@ -7,7 +7,6 @@ Capybara/VisibilityMatcher:
- 'ee/spec/features/epics/update_epic_spec.rb'
- 'ee/spec/features/groups/analytics/cycle_analytics/filters_and_data_spec.rb'
- 'ee/spec/features/groups/issues_spec.rb'
- 'ee/spec/features/groups/saml_enforcement_spec.rb'
- 'ee/spec/features/groups/settings/protected_environments_spec.rb'
- 'ee/spec/features/issues/related_issues_spec.rb'
- 'ee/spec/features/projects/integrations/user_activates_jira_spec.rb'
@ -15,7 +14,6 @@ Capybara/VisibilityMatcher:
- 'ee/spec/features/projects/requirements_management/requirements_list_spec.rb'
- 'ee/spec/features/projects/settings/ee/repository_mirrors_settings_spec.rb'
- 'ee/spec/features/promotion_spec.rb'
- 'ee/spec/features/registrations/welcome_spec.rb'
- 'ee/spec/support/helpers/billing_plans_helpers.rb'
- 'ee/spec/support/shared_examples/features/password_complexity_shared_examples.rb'
- 'ee/spec/support/shared_examples/views/issuable_bulk_dropdown_shared_examples.rb'

26
.rubocop_todo/cop/user_admin.yml
View File

@ -3,38 +3,19 @@ Cop/UserAdmin:
Exclude:
- 'app/controllers/admin/impersonations_controller.rb'
- 'app/controllers/sessions_controller.rb'
- 'app/finders/autocomplete/routes_finder.rb'
- 'app/finders/ci/jobs_finder.rb'
- 'app/finders/ci/runners_finder.rb'
- 'app/finders/personal_access_tokens_finder.rb'
- 'app/finders/users_finder.rb'
- 'app/graphql/mutations/admin/sidekiq_queues/delete_jobs.rb'
- 'app/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/import_helper.rb'
- 'app/helpers/projects_helper.rb'
- 'app/helpers/search_helper.rb'
- 'app/helpers/users/callouts_helper.rb'
- 'app/helpers/users_helper.rb'
- 'app/helpers/visibility_level_helper.rb'
- 'app/models/concerns/protected_ref_access.rb'
- 'app/models/concerns/spammable.rb'
- 'app/models/merge_requests_closing_issues.rb'
- 'app/models/protected_branch.rb'
- 'app/models/user.rb'
- 'app/policies/note_policy.rb'
- 'app/services/auth/container_registry_authentication_service.rb'
- 'app/services/emails/create_service.rb'
- 'app/services/projects/enable_deploy_key_service.rb'
- 'app/services/projects/fork_service.rb'
- 'app/services/users/build_service.rb'
- 'ee/app/controllers/ee/projects_controller.rb'
- 'ee/app/helpers/ee/dashboard_helper.rb'
- 'ee/app/helpers/ee/import_helper.rb'
- 'ee/app/helpers/ee/subscribable_banner_helper.rb'
- 'ee/app/helpers/ee/users/callouts_helper.rb'
- 'ee/app/helpers/license_monitoring_helper.rb'
- 'ee/app/helpers/push_rules_helper.rb'
- 'ee/app/models/concerns/ee/protected_ref_access.rb'
- 'ee/app/models/ee/user.rb'
- 'ee/app/policies/ee/group_policy.rb'
@ -43,14 +24,7 @@ Cop/UserAdmin:
- 'ee/app/services/ee/projects/update_service.rb'
- 'ee/lib/ee/api/helpers.rb'
- 'ee/lib/ee/gitlab/git_access.rb'
- 'lib/api/award_emoji.rb'
- 'lib/api/ci/runners.rb'
- 'lib/api/groups.rb'
- 'lib/api/helpers.rb'
- 'lib/api/users.rb'
- 'lib/api/v3/github.rb'
- 'lib/constraints/admin_constrainer.rb'
- 'lib/gitlab/auth.rb'
- 'lib/gitlab/import_export/members_mapper.rb'
- 'lib/gitlab/performance_bar.rb'
- 'lib/gitlab/visibility_level.rb'

5
.rubocop_todo/database/multiple_databases.yml
View File

@ -1,5 +0,0 @@
---
Database/MultipleDatabases:
Exclude:
- 'db/post_migrate/20210811122206_update_external_project_bots.rb'
- 'db/post_migrate/20210812013042_remove_duplicate_project_authorizations.rb'

1
.rubocop_todo/fips/md5.yml
View File

@ -17,6 +17,5 @@ Fips/MD5:
- 'spec/lib/gitlab/ci/trace/remote_checksum_spec.rb'
- 'spec/models/concerns/checksummable_spec.rb'
- 'spec/services/gravatar_service_spec.rb'
- 'spec/support/shared_examples/services/packages/debian/generate_distribution_shared_examples.rb'
- 'spec/tooling/rspec_flaky/example_spec.rb'
- 'tooling/rspec_flaky/example.rb'

1
.rubocop_todo/fips/sha1.yml
View File

@ -21,7 +21,6 @@ Fips/SHA1:
- 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb'
- 'ee/spec/factories/vulnerabilities/feedback.rb'
- 'ee/spec/factories/vulnerabilities/finding_signatures.rb'
- 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb'
- 'ee/spec/lib/ee/gitlab/alert_management/payload/generic_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb'

1
.rubocop_todo/gitlab/deprecate_track_redis_hll_event.yml
View File

@ -10,5 +10,4 @@ Gitlab/DeprecateTrackRedisHLLEvent:
- 'ee/app/controllers/groups/analytics/ci_cd_analytics_controller.rb'
- 'ee/app/controllers/groups/audit_events_controller.rb'
- 'ee/app/controllers/groups/epic_boards_controller.rb'
- 'ee/app/controllers/groups/security/compliance_dashboards_controller.rb'
- 'spec/controllers/concerns/redis_tracking_spec.rb'

3
.rubocop_todo/gitlab/doc_url.yml
View File

@ -6,7 +6,6 @@ Gitlab/DocUrl:
- 'app/graphql/types/merge_request_type.rb'
- 'app/graphql/types/notes/diff_position_input_type.rb'
- 'app/graphql/types/query_complexity_type.rb'
- 'ee/app/helpers/projects/learn_gitlab_helper.rb'
- 'app/models/integrations/apple_app_store.rb'
- 'app/models/integrations/microsoft_teams.rb'
- 'app/presenters/dev_ops_report/metric_presenter.rb'
@ -19,9 +18,9 @@ Gitlab/DocUrl:
- 'app/services/tasks_to_be_done/create_ci_task_service.rb'
- 'app/services/tasks_to_be_done/create_code_task_service.rb'
- 'app/services/tasks_to_be_done/create_issues_task_service.rb'
- 'ee/app/components/namespaces/free_user_cap/notification_alert_component.rb'
- 'ee/app/graphql/mutations/requirements_management/export_requirements.rb'
- 'ee/app/graphql/types/vulnerability_state_enum.rb'
- 'ee/app/helpers/projects/learn_gitlab_helper.rb'
- 'ee/app/mailers/emails/user_cap.rb'
- 'ee/app/workers/concerns/elastic/migration_obsolete.rb'
- 'ee/lib/ee/gitlab/ci/pipeline/quota/size.rb'

1
.rubocop_todo/gitlab/feature_available_usage.yml
View File

@ -58,7 +58,6 @@ Gitlab/FeatureAvailableUsage:
- 'ee/app/policies/compliance_management/framework_policy.rb'
- 'ee/app/policies/ee/group_policy.rb'
- 'ee/app/policies/ee/project_policy.rb'
- 'ee/app/policies/ee/protected_branch_policy.rb'
- 'ee/app/presenters/ee/label_presenter.rb'
- 'ee/app/presenters/merge_request_approver_presenter.rb'
- 'ee/app/serializers/dashboard_operations_project_entity.rb'

1
.rubocop_todo/gitlab/namespaced_class.yml
View File

@ -1075,7 +1075,6 @@ Gitlab/NamespacedClass:
- 'ee/lib/gitlab/cidr.rb'
- 'ee/lib/gitlab/custom_file_templates.rb'
- 'ee/lib/gitlab/expiring_subscription_message.rb'
- 'ee/lib/gitlab/geo_logger.rb'
- 'ee/lib/gitlab/group_plans_preloader.rb'
- 'ee/lib/gitlab/ip_address_state.rb'
- 'ee/lib/gitlab/items_collection.rb'

1
.rubocop_todo/gitlab/no_code_coverage_comment.yml
View File

@ -13,6 +13,5 @@ Gitlab/NoCodeCoverageComment:
- 'lib/gitlab/database/background_migration/health_status/signals.rb'
- 'lib/gitlab/seeder.rb'
- 'lib/gitlab/webpack/dev_server_middleware.rb'
- 'lib/tasks/dev.rake'
- 'lib/tasks/gems.rake'
- 'lib/tasks/gitlab/db.rake'

15
.rubocop_todo/gitlab/strong_memoize_attr.yml
View File

@ -97,9 +97,7 @@ Gitlab/StrongMemoizeAttr:
- 'app/models/concerns/has_repository.rb'
- 'app/models/concerns/has_wiki.rb'
- 'app/models/concerns/has_wiki_page_meta_attributes.rb'
- 'app/models/concerns/mentionable/reference_regexes.rb'
- 'app/models/concerns/redis_cacheable.rb'
- 'app/models/concerns/require_email_verification.rb'
- 'app/models/concerns/resolvable_discussion.rb'
- 'app/models/concerns/security/latest_pipeline_information.rb'
- 'app/models/container_registry/event.rb'
@ -237,7 +235,6 @@ Gitlab/StrongMemoizeAttr:
- 'app/services/packages/debian/generate_distribution_key_service.rb'
- 'app/services/packages/debian/generate_distribution_service.rb'
- 'app/services/packages/debian/process_changes_service.rb'
- 'app/services/packages/debian/process_package_file_service.rb'
- 'app/services/packages/helm/process_file_service.rb'
- 'app/services/packages/maven/metadata/base_create_xml_service.rb'
- 'app/services/packages/maven/metadata/create_plugins_xml_service.rb'
@ -327,7 +324,6 @@ Gitlab/StrongMemoizeAttr:
- 'ee/app/helpers/ee/welcome_helper.rb'
- 'ee/app/helpers/license_monitoring_helper.rb'
- 'ee/app/helpers/subscriptions_helper.rb'
- 'ee/app/helpers/trial_status_widget_helper.rb'
- 'ee/app/models/approval_merge_request_rule.rb'
- 'ee/app/models/approval_state.rb'
- 'ee/app/models/approval_wrapped_any_approver_rule.rb'
@ -488,13 +484,11 @@ Gitlab/StrongMemoizeAttr:
- 'ee/lib/gitlab/code_owners/entry.rb'
- 'ee/lib/gitlab/code_owners/loader.rb'
- 'ee/lib/gitlab/custom_file_templates.rb'
- 'ee/lib/gitlab/elastic/client.rb'
- 'ee/lib/gitlab/elastic/document_reference.rb'
- 'ee/lib/gitlab/elastic/indexer.rb'
- 'ee/lib/gitlab/elastic/project_search_results.rb'
- 'ee/lib/gitlab/elastic/search_results.rb'
- 'ee/lib/gitlab/expiring_subscription_message.rb'
- 'ee/lib/gitlab/geo.rb'
- 'ee/lib/gitlab/geo/health_check.rb'
- 'ee/lib/gitlab/geo/jwt_request_decoder.rb'
- 'ee/lib/gitlab/geo/oauth/logout_state.rb'
@ -591,7 +585,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/ci/pipeline/chain/seed.rb'
- 'lib/gitlab/ci/pipeline/chain/skip.rb'
- 'lib/gitlab/ci/pipeline/expression/lexer.rb'
- 'lib/gitlab/ci/pipeline/metrics.rb'
- 'lib/gitlab/ci/pipeline/quota/deployments.rb'
- 'lib/gitlab/ci/pipeline/seed/processable/resource_group.rb'
- 'lib/gitlab/ci/project_config/auto_devops.rb'
@ -600,7 +593,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/ci/project_config/remote.rb'
- 'lib/gitlab/ci/project_config/repository.rb'
- 'lib/gitlab/ci/project_config/source.rb'
- 'lib/gitlab/ci/queue/metrics.rb'
- 'lib/gitlab/ci/reports/accessibility_reports_comparer.rb'
- 'lib/gitlab/ci/reports/codequality_reports_comparer.rb'
- 'lib/gitlab/ci/reports/security/locations/base.rb'
@ -608,13 +600,11 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/ci/reports/test_reports_comparer.rb'
- 'lib/gitlab/ci/reports/test_suite_comparer.rb'
- 'lib/gitlab/ci/reports/test_suite_summary.rb'
- 'lib/gitlab/ci/runner/metrics.rb'
- 'lib/gitlab/ci/status/composite.rb'
- 'lib/gitlab/ci/tags/bulk_insert.rb'
- 'lib/gitlab/ci/trace.rb'
- 'lib/gitlab/ci/trace/archive.rb'
- 'lib/gitlab/ci/trace/checksum.rb'
- 'lib/gitlab/ci/trace/metrics.rb'
- 'lib/gitlab/ci/trace/remote_checksum.rb'
- 'lib/gitlab/ci/variables/builder.rb'
- 'lib/gitlab/ci/variables/builder/group.rb'
@ -627,9 +617,7 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/config/entry/composable_array.rb'
- 'lib/gitlab/config/loader/yaml.rb'
- 'lib/gitlab/conflict/file.rb'
- 'lib/gitlab/database/as_with_materialized.rb'
- 'lib/gitlab/database/background_migration/health_status/indicators/write_ahead_log.rb'
- 'lib/gitlab/database/background_migration/prometheus_metrics.rb'
- 'lib/gitlab/database/bulk_update.rb'
- 'lib/gitlab/database/load_balancing/srv_resolver.rb'
- 'lib/gitlab/database/metrics.rb'
@ -645,7 +633,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/diff/suggestion.rb'
- 'lib/gitlab/discussions_diff/file_collection.rb'
- 'lib/gitlab/email/handler/service_desk_handler.rb'
- 'lib/gitlab/email/hook/delivery_metrics_observer.rb'
- 'lib/gitlab/email/receiver.rb'
- 'lib/gitlab/external_authorization/response.rb'
- 'lib/gitlab/gfm/reference_rewriter.rb'
@ -689,7 +676,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/metrics/dashboard/stages/grafana_formatter.rb'
- 'lib/gitlab/metrics/dashboard/url.rb'
- 'lib/gitlab/metrics/prometheus.rb'
- 'lib/gitlab/metrics/subscribers/active_record.rb'
- 'lib/gitlab/pages/cache_control.rb'
- 'lib/gitlab/prometheus_client.rb'
- 'lib/gitlab/rack_attack/request.rb'
@ -715,7 +701,6 @@ Gitlab/StrongMemoizeAttr:
- 'lib/gitlab/webpack/graphql_known_operations.rb'
- 'lib/gitlab/webpack/manifest.rb'
- 'lib/gitlab/wiki_pages/front_matter_parser.rb'
- 'lib/gitlab/x509/certificate.rb'
- 'lib/gitlab/x509/signature.rb'
- 'lib/gitlab/x509/tag.rb'
- 'lib/grafana/time_window.rb'

2
.rubocop_todo/graphql/descriptions.yml
View File

@ -1,7 +1,6 @@
---
# Cop supports --autocorrect.
Graphql/Descriptions:
Safe: false
Details: grace period
Exclude:
- 'app/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver.rb'
@ -18,7 +17,6 @@ Graphql/Descriptions:
- 'app/graphql/resolvers/milestones_resolver.rb'
- 'app/graphql/resolvers/namespace_projects_resolver.rb'
- 'app/graphql/resolvers/packages_base_resolver.rb'
- 'app/graphql/resolvers/releases_resolver.rb'
- 'app/graphql/resolvers/users_resolver.rb'
- 'app/graphql/resolvers/work_items_resolver.rb'
- 'app/graphql/types/alert_management/alert_type.rb'

8
.rubocop_todo/layout/argument_alignment.yml
View File

@ -607,7 +607,6 @@ Layout/ArgumentAlignment:
- 'app/models/concerns/limitable.rb'
- 'app/models/concerns/mentionable/reference_regexes.rb'
- 'app/models/concerns/resolvable_discussion.rb'
- 'app/models/concerns/taskable.rb'
- 'app/models/concerns/vulnerability_finding_helpers.rb'
- 'app/models/concerns/web_hooks/auto_disabling.rb'
- 'app/models/container_repository.rb'
@ -746,7 +745,6 @@ Layout/ArgumentAlignment:
- 'app/services/protected_branches/api_service.rb'
- 'app/services/protected_branches/legacy_api_create_service.rb'
- 'app/services/quick_actions/interpret_service.rb'
- 'app/services/resource_events/change_labels_service.rb'
- 'app/services/search/global_service.rb'
- 'app/services/search/project_service.rb'
- 'app/services/security/ci_configuration/base_create_service.rb'
@ -770,7 +768,6 @@ Layout/ArgumentAlignment:
- 'app/validators/feature_flag_user_xids_validator.rb'
- 'app/workers/gitlab/github_import/stage/import_protected_branches_worker.rb'
- 'app/workers/gitlab/jira_import/stuck_jira_import_jobs_worker.rb'
- 'app/workers/merge_requests/delete_source_branch_worker.rb'
- 'app/workers/packages/debian/process_package_file_worker.rb'
- 'app/workers/repository_update_remote_mirror_worker.rb'
- 'app/workers/run_pipeline_schedule_worker.rb'
@ -1292,7 +1289,6 @@ Layout/ArgumentAlignment:
- 'ee/app/services/analytics/devops_adoption/enabled_namespaces/bulk_find_or_create_service.rb'
- 'ee/app/services/audit_events/streaming/event_type_filters/destroy_service.rb'
- 'ee/app/services/auto_merge/merge_train_service.rb'
- 'ee/app/services/ci/sync_reports_to_approval_rules_service.rb'
- 'ee/app/services/dashboard/projects/create_service.rb'
- 'ee/app/services/dora/aggregate_metrics_service.rb'
- 'ee/app/services/ee/applications/create_service.rb'
@ -1319,7 +1315,6 @@ Layout/ArgumentAlignment:
- 'ee/app/services/iterations/create_service.rb'
- 'ee/app/services/merge_trains/create_pipeline_service.rb'
- 'ee/app/services/registrations/standard_namespace_create_service.rb'
- 'ee/app/services/resource_events/change_weight_service.rb'
- 'ee/app/services/security/findings/dismiss_service.rb'
- 'ee/app/services/security/ingestion/tasks/ingest_vulnerability_flags.rb'
- 'ee/app/services/security/track_scan_service.rb'
@ -1443,8 +1438,6 @@ Layout/ArgumentAlignment:
- 'ee/spec/factories/import_states.rb'
- 'ee/spec/factories/merge_requests.rb'
- 'ee/spec/factories/namespaces.rb'
- 'ee/spec/factories/package_metadata/pm_package_versions.rb'
- 'ee/spec/factories/package_metadata/pm_packages.rb'
- 'ee/spec/factories/projects.rb'
- 'ee/spec/factories/security_scans.rb'
- 'ee/spec/factories/vulnerabilities/findings.rb'
@ -2701,7 +2694,6 @@ Layout/ArgumentAlignment:
- 'spec/lib/gitlab/prometheus/queries/additional_metrics_deployment_query_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb'
- 'spec/lib/gitlab/redis/repository_cache_spec.rb'
- 'spec/lib/gitlab/redis/sidekiq_status_spec.rb'
- 'spec/lib/gitlab/repository_cache/preloader_spec.rb'
- 'spec/lib/gitlab/repository_cache_spec.rb'

7
.rubocop_todo/layout/array_alignment.yml
View File

@ -18,7 +18,6 @@ Layout/ArrayAlignment:
- 'app/graphql/resolvers/concerns/issues/sort_arguments.rb'
- 'app/graphql/types/permission_types/merge_request.rb'
- 'app/helpers/merge_requests_helper.rb'
- 'app/helpers/namespaces_helper.rb'
- 'app/helpers/search_helper.rb'
- 'app/helpers/submodule_helper.rb'
- 'app/models/ci/bridge.rb'
@ -60,7 +59,6 @@ Layout/ArrayAlignment:
- 'ee/app/finders/ee/issues_finder/params.rb'
- 'ee/app/finders/geo/project_registry_finder.rb'
- 'ee/app/graphql/ee/resolvers/project_pipelines_resolver.rb'
- 'ee/app/helpers/ee/routing/projects_helper.rb'
- 'ee/app/models/concerns/geo/verification_state.rb'
- 'ee/app/models/dast_site_profile.rb'
- 'ee/app/models/dora/base_metric.rb'
@ -115,8 +113,8 @@ Layout/ArrayAlignment:
- 'ee/spec/models/dora/base_metric_spec.rb'
- 'ee/spec/models/dora/daily_metrics_spec.rb'
- 'ee/spec/models/ee/group_spec.rb'
- 'ee/spec/models/ee/protected_ref_access_spec.rb'
- 'ee/spec/models/ee/project_spec.rb'
- 'ee/spec/models/ee/protected_ref_access_spec.rb'
- 'ee/spec/models/issue_spec.rb'
- 'ee/spec/models/repository_spec.rb'
- 'ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb'
@ -135,7 +133,6 @@ Layout/ArrayAlignment:
- 'ee/spec/requests/api/saml_group_links_spec.rb'
- 'ee/spec/serializers/dashboard_environment_entity_spec.rb'
- 'ee/spec/serializers/user_analytics_entity_spec.rb'
- 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb'
- 'ee/spec/services/audit_events/export_csv_service_spec.rb'
- 'ee/spec/services/ee/auto_merge_service_spec.rb'
- 'ee/spec/services/ee/boards/issues/list_service_spec.rb'
@ -201,8 +198,6 @@ Layout/ArrayAlignment:
- 'qa/qa/specs/features/browser_ui/5_package/package_registry/npm/npm_project_level_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/10_govern/group/group_audit_logs_2_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb'
- 'qa/spec/specs/runner_spec.rb'
- 'rubocop/cop/gitlab/rspec/avoid_setup.rb'

5
.rubocop_todo/layout/first_array_element_indentation.yml
View File

@ -39,14 +39,12 @@ Layout/FirstArrayElementIndentation:
- 'ee/spec/models/security/orchestration_policy_configuration_spec.rb'
- 'ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb'
- 'ee/spec/policies/project_policy_spec.rb'
- 'ee/spec/requests/api/graphql/analytics/contribution_analytics/contributions_spec.rb'
- 'ee/spec/requests/api/graphql/group/epics_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/releases/update_spec.rb'
- 'ee/spec/requests/api/graphql/project/merge_requests_spec.rb'
- 'ee/spec/requests/api/ldap_group_links_spec.rb'
- 'ee/spec/requests/api/members_spec.rb'
- 'ee/spec/requests/api/saml_group_links_spec.rb'
- 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb'
- 'ee/spec/services/audit_events/export_csv_service_spec.rb'
- 'ee/spec/services/groups/seat_usage_export_service_spec.rb'
- 'lib/gitlab/email/message/in_product_marketing/team.rb'
@ -75,9 +73,6 @@ Layout/FirstArrayElementIndentation:
- 'spec/lib/gitlab/database/load_balancing/rack_middleware_spec.rb'
- 'spec/lib/gitlab/database/load_balancing/service_discovery/sampler_spec.rb'
- 'spec/lib/gitlab/diff/inline_diff_spec.rb'
- 'spec/lib/gitlab/github_import/importer/diff_notes_importer_spec.rb'
- 'spec/lib/gitlab/github_import/importer/lfs_objects_importer_spec.rb'
- 'spec/lib/gitlab/github_import/importer/notes_importer_spec.rb'
- 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/in_operator_optimization/query_builder_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb'

6
.rubocop_todo/layout/first_hash_element_indentation.yml
View File

@ -47,7 +47,6 @@ Layout/FirstHashElementIndentation:
- 'ee/app/helpers/ee/geo_helper.rb'
- 'ee/app/helpers/ee/groups/group_members_helper.rb'
- 'ee/app/helpers/ee/trial_helper.rb'
- 'ee/app/helpers/incident_management/escalation_policy_helper.rb'
- 'ee/app/models/ee/list.rb'
- 'ee/app/services/app_sec/dast/profiles/update_service.rb'
- 'ee/app/services/elastic/cluster_reindexing_service.rb'
@ -57,7 +56,6 @@ Layout/FirstHashElementIndentation:
- 'ee/app/services/resource_events/change_iteration_service.rb'
- 'ee/app/services/security/token_revocation_service.rb'
- 'ee/app/services/timebox_report_service.rb'
- 'ee/lib/ee/container_registry/client.rb'
- 'ee/lib/ee/gitlab/ci/parsers.rb'
- 'ee/lib/ee/gitlab/usage_data.rb'
- 'ee/lib/elastic/latest/application_class_proxy.rb'
@ -96,7 +94,6 @@ Layout/FirstHashElementIndentation:
- 'ee/spec/lib/audit/project_changes_auditor_spec.rb'
- 'ee/spec/lib/audit/project_ci_cd_setting_changes_auditor_spec.rb'
- 'ee/spec/lib/audit/project_setting_changes_auditor_spec.rb'
- 'ee/spec/lib/container_registry/client_spec.rb'
- 'ee/spec/lib/ee/api/entities/experiment_spec.rb'
- 'ee/spec/lib/ee/gitlab/auth/ldap/access_levels_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size_spec.rb'
@ -155,7 +152,6 @@ Layout/FirstHashElementIndentation:
- 'qa/qa/specs/features/api/3_create/repository/commit_to_templated_project_spec.rb'
- 'qa/qa/specs/features/api/5_package/container_registry_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide/open_web_ide_from_diff_tab_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_omnibus_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/container_registry/container_registry_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/container_registry/online_garbage_collection_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/dependency_proxy/dependency_proxy_spec.rb'
@ -245,14 +241,12 @@ Layout/FirstHashElementIndentation:
- 'spec/requests/api/releases_spec.rb'
- 'spec/requests/api/task_completion_status_spec.rb'
- 'spec/requests/groups/email_campaigns_controller_spec.rb'
- 'spec/requests/projects/merge_requests/creations_spec.rb'
- 'spec/requests/pwa_controller_spec.rb'
- 'spec/rubocop/cop/usage_data/distinct_count_by_large_foreign_key_spec.rb'
- 'spec/rubocop/cop/usage_data/histogram_with_large_table_spec.rb'
- 'spec/rubocop/cop/usage_data/instrumentation_superclass_spec.rb'
- 'spec/rubocop/cop/usage_data/large_table_spec.rb'
- 'spec/services/ci/pipeline_artifacts/coverage_report_service_spec.rb'
- 'spec/services/ci/register_job_service_spec.rb'
- 'spec/services/clusters/update_service_spec.rb'
- 'spec/services/google_cloud/get_cloudsql_instances_service_spec.rb'
- 'spec/services/import/github_service_spec.rb'

2
.rubocop_todo/layout/line_continuation_leading_space.yml
View File

@ -1,4 +1,5 @@
---
# Cop supports --autocorrect.
Layout/LineContinuationLeadingSpace:
Details: grace period
Exclude:
@ -8,7 +9,6 @@ Layout/LineContinuationLeadingSpace:
- 'app/helpers/application_settings_helper.rb'
- 'app/helpers/preferences_helper.rb'
- 'app/models/environment.rb'
- 'app/services/projects/container_repository/destroy_service.rb'
- 'config/initializers_before_autoloader/003_gc_compact.rb'
- 'ee/app/graphql/ee/mutations/issues/create.rb'
- 'ee/app/graphql/ee/types/merge_request_type.rb'

5
.rubocop_todo/layout/line_continuation_spacing.yml
View File

@ -4,7 +4,6 @@ Layout/LineContinuationSpacing:
Details: grace period
Exclude:
- 'app/controllers/concerns/controller_with_cross_project_access_check.rb'
- 'app/controllers/concerns/verifies_with_email.rb'
- 'app/controllers/projects/google_cloud/databases_controller.rb'
- 'app/graphql/gitlab_schema.rb'
- 'app/graphql/mutations/boards/issues/issue_move_list.rb'
@ -28,14 +27,12 @@ Layout/LineContinuationSpacing:
- 'ee/app/components/namespaces/storage/pre_enforcement_alert_component.rb'
- 'ee/app/components/namespaces/storage/user_pre_enforcement_alert_component.rb'
- 'ee/app/controllers/ee/ldap/omniauth_callbacks_controller.rb'
- 'ee/app/controllers/users/identity_verification_controller.rb'
- 'ee/app/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create.rb'
- 'ee/app/graphql/mutations/requirements_management/export_requirements.rb'
- 'ee/app/graphql/mutations/security_policy/assign_security_policy_project.rb'
- 'ee/app/graphql/resolvers/security_orchestration/scan_execution_policy_resolver.rb'
- 'ee/app/graphql/resolvers/vulnerabilities_resolver.rb'
- 'ee/app/graphql/resolvers/vulnerability_severities_count_resolver.rb'
- 'ee/app/graphql/types/geo/geo_node_type.rb'
- 'ee/app/graphql/types/requirements_management/requirement_type.rb'
- 'ee/app/helpers/push_rules_helper.rb'
- 'ee/app/models/ee/epic.rb'
@ -135,7 +132,6 @@ Layout/LineContinuationSpacing:
- 'lib/gitlab/database/shared_model.rb'
- 'lib/gitlab/i18n/po_linter.rb'
- 'qa/qa/specs/features/ee/api/9_data_stores/elasticsearch/nightly_elasticsearch_test_spec.rb'
- 'qa/qa/support/matchers/eventually_matcher.rb'
- 'qa/qa/support/page_error_checker.rb'
- 'qa/qa/tools/test_resources_handler.rb'
- 'qa/spec/resource/user_spec.rb'
@ -197,7 +193,6 @@ Layout/LineContinuationSpacing:
- 'spec/requests/api/group_labels_spec.rb'
- 'spec/requests/api/groups_spec.rb'
- 'spec/requests/api/labels_spec.rb'
- 'spec/requests/api/projects_spec.rb'
- 'spec/requests/api/users_spec.rb'
- 'spec/requests/verifies_with_email_spec.rb'
- 'spec/services/feature_flags/update_service_spec.rb'

10
.rubocop_todo/layout/line_end_string_concatenation_indentation.yml
View File

@ -4,7 +4,6 @@ Layout/LineEndStringConcatenationIndentation:
Details: grace period
Exclude:
- 'app/controllers/admin/application_settings_controller.rb'
- 'app/controllers/concerns/verifies_with_email.rb'
- 'app/finders/snippets_finder.rb'
- 'app/graphql/mutations/ci/project_ci_cd_settings_update.rb'
- 'app/graphql/mutations/ci/runner/bulk_delete.rb'
@ -15,7 +14,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'app/graphql/types/ci/config/include_type.rb'
- 'app/graphql/types/ci/runner_membership_filter_enum.rb'
- 'app/graphql/types/ci/runner_status_enum.rb'
- 'app/graphql/types/issue_type.rb'
- 'app/graphql/types/user_interface.rb'
- 'app/helpers/application_settings_helper.rb'
- 'app/helpers/members_helper.rb'
@ -36,7 +34,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'app/services/concerns/ci/job_token_scope/edit_scope_validations.rb'
- 'app/services/feature_flags/update_service.rb'
- 'app/services/projects/after_rename_service.rb'
- 'app/services/projects/container_repository/destroy_service.rb'
- 'app/services/repositories/changelog_service.rb'
- 'app/services/users/email_verification/validate_token_service.rb'
- 'app/workers/run_pipeline_schedule_worker.rb'
@ -45,9 +42,7 @@ Layout/LineEndStringConcatenationIndentation:
- 'config/initializers/wikicloth_redos_patch.rb'
- 'config/initializers/wikicloth_ruby_3_patch.rb'
- 'config/initializers_before_autoloader/003_gc_compact.rb'
- 'danger/ci_templates/Dangerfile'
- 'danger/database/Dangerfile'
- 'db/post_migrate/20210606143426_add_index_for_container_registry_access_level.rb'
- 'db/post_migrate/20220425121410_add_temporary_index_for_backfill_integrations_enable_ssl_verification.rb'
- 'db/post_migrate/20220525131624_drop_temporary_index_for_backfill_integrations_enable_ssl_verification.rb'
- 'db/post_migrate/20220920081631_prepare_ci_builds_metadata_for_partitioning_primary_key.rb'
@ -55,7 +50,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'ee/app/controllers/admin/licenses_controller.rb'
- 'ee/app/controllers/concerns/insights_actions.rb'
- 'ee/app/controllers/ee/ldap/omniauth_callbacks_controller.rb'
- 'ee/app/controllers/users/identity_verification_controller.rb'
- 'ee/app/finders/geo/framework_registry_finder.rb'
- 'ee/app/graphql/mutations/app_sec/fuzzing/api/ci_configuration/create.rb'
- 'ee/app/graphql/mutations/dast_scanner_profiles/create.rb'
@ -195,7 +189,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'lib/gitlab/database/partitioning_migration_helpers/foreign_key_helpers.rb'
- 'lib/gitlab/database/partitioning_migration_helpers/index_helpers.rb'
- 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb'
- 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb'
- 'lib/gitlab/database/schema_helpers.rb'
- 'lib/gitlab/database/shared_model.rb'
- 'lib/gitlab/github_import/importer/events/changed_reviewer.rb'
@ -212,7 +205,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'lib/tasks/gitlab/storage.rake'
- 'qa/qa/ee/page/project/settings/services/jira.rb'
- 'qa/qa/specs/features/api/4_verify/api_variable_inheritance_with_forward_pipeline_variables_spec.rb'
- 'qa/qa/support/matchers/eventually_matcher.rb'
- 'qa/qa/support/system_logs/kibana.rb'
- 'qa/qa/tools/revoke_user_personal_access_tokens.rb'
- 'qa/spec/support/page_error_checker_spec.rb'
@ -259,7 +251,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'scripts/lib/glfm/update_specification.rb'
- 'scripts/lib/glfm/verify_all_generated_files_are_up_to_date.rb'
- 'scripts/packages/automated_cleanup.rb'
- 'spec/contracts/provider_specs/helpers/provider/contract_source_helper_spec.rb'
- 'spec/controllers/graphql_controller_spec.rb'
- 'spec/controllers/projects/deploy_keys_controller_spec.rb'
- 'spec/features/projects/files/user_browses_files_spec.rb'
@ -349,7 +340,6 @@ Layout/LineEndStringConcatenationIndentation:
- 'spec/support/shared_examples/lib/email/email_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/notes_shared_examples.rb'
- 'spec/support/shared_examples/requests/self_monitoring_shared_examples.rb'
- 'spec/tooling/lib/tooling/kubernetes_client_spec.rb'
- 'spec/uploaders/file_mover_spec.rb'
- 'spec/views/devise/shared/_signup_box.html.haml_spec.rb'
- 'spec/views/projects/pages/show.html.haml_spec.rb'

5
.rubocop_todo/layout/line_length.yml
View File

@ -247,7 +247,6 @@ Layout/LineLength:
- 'app/helpers/labels_helper.rb'
- 'app/helpers/merge_requests_helper.rb'
- 'app/helpers/mirror_helper.rb'
- 'app/helpers/namespaces_helper.rb'
- 'app/helpers/nav/new_dropdown_helper.rb'
- 'app/helpers/nav/top_nav_helper.rb'
- 'app/helpers/nav_helper.rb'
@ -2567,7 +2566,6 @@ Layout/LineLength:
- 'ee/spec/support/shared_contexts/status_page/status_page_list_objects.rb'
- 'ee/spec/support/shared_examples/controllers/analytics/cycle_analytics/shared_stage_shared_examples.rb'
- 'ee/spec/support/shared_examples/controllers/concerns/description_diff_actions_shared_examples.rb'
- 'ee/spec/support/shared_examples/controllers/projects/license_scanning_report_comparison_shared_examples.rb'
- 'ee/spec/support/shared_examples/features/epics_filtered_search_shared_examples.rb'
- 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb'
- 'ee/spec/support/shared_examples/features/sidebar_shared_examples.rb'
@ -2956,7 +2954,6 @@ Layout/LineLength:
- 'lib/gitlab/database/postgres_hll/batch_distinct_counter.rb'
- 'lib/gitlab/database/postgres_hll/buckets.rb'
- 'lib/gitlab/database/postgres_index.rb'
- 'lib/gitlab/database/postgres_partition.rb'
- 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb'
- 'lib/gitlab/database/reflection.rb'
- 'lib/gitlab/database/reindexing.rb'
@ -3313,7 +3310,6 @@ Layout/LineLength:
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_local_config_file_paths_with_wildcard_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/include_multiple_files_from_a_project_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/merge_mr_when_pipline_is_blocked_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/mr_event_rule_pipeline_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pass_dotenv_variables_to_downstream_via_bridge_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_branch_switcher_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/trigger_matrix_spec.rb'
@ -3637,7 +3633,6 @@ Layout/LineLength:
- 'spec/features/merge_request/user_posts_notes_spec.rb'
- 'spec/features/merge_request/user_resolves_conflicts_spec.rb'
- 'spec/features/merge_request/user_resolves_diff_notes_and_discussions_resolve_spec.rb'
- 'spec/features/merge_request/user_resolves_wip_mr_spec.rb'
- 'spec/features/merge_request/user_reverts_merge_request_spec.rb'
- 'spec/features/merge_request/user_scrolls_to_note_on_load_spec.rb'
- 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb'

3
.rubocop_todo/layout/multiline_operation_indentation.yml
View File

@ -21,7 +21,6 @@ Layout/MultilineOperationIndentation:
- 'app/models/packages/sem_ver.rb'
- 'app/models/project.rb'
- 'app/models/user.rb'
- 'app/models/work_items/parent_link.rb'
- 'app/policies/project_policy.rb'
- 'app/serializers/deploy_keys/deploy_key_entity.rb'
- 'app/services/ci/create_downstream_pipeline_service.rb'
@ -51,12 +50,10 @@ Layout/MultilineOperationIndentation:
- 'ee/app/models/ee/project.rb'
- 'ee/app/models/ee/user.rb'
- 'ee/app/models/vulnerabilities/finding_signature.rb'
- 'ee/app/policies/ee/base_policy.rb'
- 'ee/app/policies/ee/merge_request_policy.rb'
- 'ee/app/services/analytics/cycle_analytics/value_streams/update_service.rb'
- 'ee/app/services/ee/merge_requests/build_service.rb'
- 'ee/app/services/ee/projects/operations/update_service.rb'
- 'ee/app/workers/elastic/project_transfer_worker.rb'
- 'ee/lib/ee/api/entities/group.rb'
- 'ee/lib/ee/api/geo.rb'
- 'ee/lib/ee/api/helpers.rb'

5
.rubocop_todo/layout/space_around_operators.yml
View File

@ -1,5 +0,0 @@
---
# Cop supports --autocorrect.
Layout/SpaceAroundOperators:
Exclude:
- 'lib/gitlab/utils/strong_memoize.rb'

3
.rubocop_todo/layout/space_in_lambda_literal.yml
View File

@ -95,7 +95,6 @@ Layout/SpaceInLambdaLiteral:
- 'app/models/prometheus_alert.rb'
- 'app/models/prometheus_alert_event.rb'
- 'app/models/prometheus_metric.rb'
- 'app/models/protected_branch.rb'
- 'app/models/redirect_route.rb'
- 'app/models/release.rb'
- 'app/models/route.rb'
@ -146,7 +145,6 @@ Layout/SpaceInLambdaLiteral:
- 'app/serializers/merge_request_poll_cached_widget_entity.rb'
- 'app/serializers/merge_request_poll_widget_entity.rb'
- 'app/serializers/merge_request_widget_entity.rb'
- 'app/serializers/merge_requests/pipeline_entity.rb'
- 'app/serializers/note_entity.rb'
- 'app/serializers/project_note_entity.rb'
- 'app/serializers/review_app_setup_entity.rb'
@ -282,7 +280,6 @@ Layout/SpaceInLambdaLiteral:
- 'ee/app/services/groups/seat_usage_export_service.rb'
- 'ee/app/services/historical_user_data/csv_service.rb'
- 'ee/app/services/merge_commits/export_csv_service.rb'
- 'ee/app/services/requirements_management/map_export_fields_service.rb'
- 'ee/app/services/user_permissions/export_service.rb'
- 'ee/app/services/vulnerability_exports/exporters/csv_service.rb'
- 'ee/app/workers/update_all_mirrors_worker.rb'

6
.rubocop_todo/layout/space_inside_parens.yml
View File

@ -3,7 +3,6 @@
Layout/SpaceInsideParens:
Details: grace period
Exclude:
- 'db/post_migrate/20210722042939_update_issuable_slas_where_issue_closed.rb'
- 'ee/app/models/ee/dependency_proxy/blob.rb'
- 'ee/app/models/ee/dependency_proxy/manifest.rb'
- 'ee/app/services/gitlab_subscriptions/notify_seats_exceeded_batch_service.rb'
@ -19,11 +18,9 @@ Layout/SpaceInsideParens:
- 'ee/spec/frontend/fixtures/analytics/devops_reports/devops_adoption/enabled_namespaces.rb'
- 'ee/spec/frontend/fixtures/epic.rb'
- 'ee/spec/frontend/fixtures/namespace.rb'
- 'ee/spec/frontend/fixtures/projects.rb'
- 'ee/spec/lib/gitlab/search/index_curator_spec.rb'
- 'ee/spec/lib/world_spec.rb'
- 'ee/spec/mailers/notify_spec.rb'
- 'ee/spec/migrations/add_non_null_constraint_for_escalation_rule_on_pending_alert_escalations_spec.rb'
- 'ee/spec/migrations/drop_invalid_remediations_spec.rb'
- 'ee/spec/models/allowed_email_domain_spec.rb'
- 'ee/spec/models/boards/epic_board_position_spec.rb'
@ -56,7 +53,6 @@ Layout/SpaceInsideParens:
- 'ee/spec/requests/api/project_milestones_spec.rb'
- 'ee/spec/requests/customers_dot/proxy_controller_spec.rb'
- 'ee/spec/serializers/member_user_entity_spec.rb'
- 'ee/spec/services/app_sec/dast/profiles/create_service_spec.rb'
- 'ee/spec/services/app_sec/dast/site_profile_secret_variables/create_or_update_service_spec.rb'
- 'ee/spec/services/app_sec/dast/site_validations/runner_service_spec.rb'
- 'ee/spec/services/app_sec/fuzzing/coverage/corpuses/create_service_spec.rb'
@ -91,7 +87,6 @@ Layout/SpaceInsideParens:
- 'ee/spec/workers/security/auto_fix_worker_spec.rb'
- 'qa/qa/page/group/settings/group_deploy_tokens.rb'
- 'qa/qa/specs/features/ee/browser_ui/10_govern/scan_result_policy_vulnerabilities_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb'
- 'qa/qa/tools/delete_subgroups.rb'
- 'qa/spec/runtime/feature_spec.rb'
- 'spec/dependencies/omniauth_saml_spec.rb'
@ -191,7 +186,6 @@ Layout/SpaceInsideParens:
- 'spec/lib/security/ci_configuration/secret_detection_build_action_spec.rb'
- 'spec/mailers/emails/profile_spec.rb'
- 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb'
- 'spec/migrations/backfill_issues_upvotes_count_spec.rb'
- 'spec/models/ci/pending_build_spec.rb'
- 'spec/models/ci/running_build_spec.rb'
- 'spec/models/ml/candidate_metric_spec.rb'

2
.rubocop_todo/layout/trailing_whitespace.yml
View File

@ -3,12 +3,10 @@
Layout/TrailingWhitespace:
Exclude:
- 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb'
- 'db/migrate/20210611100359_rebuild_index_for_cadence_iterations_automation.rb'
- 'db/migrate/20220913082728_drop_index_cadence_create_iterations_automation.rb'
- 'db/post_migrate/20220816163444_update_start_date_for_iterations_cadences.rb'
- 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb'
- 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb'
- 'lib/gitlab/pagination/keyset/sql_type_missing_error.rb'
- 'spec/lib/banzai/filter/front_matter_filter_spec.rb'
- 'spec/services/suggestions/apply_service_spec.rb'
- 'spec/support/helpers/x509_helpers.rb'

6
.rubocop_todo/lint/constant_definition_in_block.yml
View File

@ -45,12 +45,6 @@ Lint/ConstantDefinitionInBlock:
- 'lib/tasks/gitlab/update_templates.rake'
- 'lib/tasks/tanuki_emoji.rake'
- 'spec/db/schema_spec.rb'
- 'spec/lib/gitlab/quick_actions/dsl_spec.rb'
- 'spec/lib/marginalia_spec.rb'
- 'spec/mailers/notify_spec.rb'
- 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb'
- 'spec/models/concerns/bulk_insert_safe_spec.rb'
- 'spec/models/concerns/bulk_insertable_associations_spec.rb'
- 'spec/models/concerns/triggerable_hooks_spec.rb'
- 'spec/models/repository_spec.rb'
- 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb'

1
.rubocop_todo/lint/empty_block.yml
View File

@ -181,7 +181,6 @@ Lint/EmptyBlock:
- 'spec/requests/api/groups_spec.rb'
- 'spec/requests/api/helpers_spec.rb'
- 'spec/requests/api/markdown_spec.rb'
- 'spec/requests/api/projects_spec.rb'
- 'spec/requests/api/release/links_spec.rb'
- 'spec/requests/api/releases_spec.rb'
- 'spec/requests/api/unleash_spec.rb'

6
.rubocop_todo/lint/missing_cop_enable_directive.yml
View File

@ -67,13 +67,8 @@ Lint/MissingCopEnableDirective:
- 'danger/feature_flag/Dangerfile'
- 'danger/pajamas/Dangerfile'
- 'danger/z_metadata/Dangerfile'
- 'db/migrate/20210807101621_add_timezone_to_dast_profile_schedules.rb'
- 'db/migrate/20210816095826_add_unique_index_on_dast_profile_to_dast_profile_schedules.rb'
- 'db/migrate/20210818061156_remove_project_profile_compound_index_from_dast_profile_schedules.rb'
- 'db/migrate/20210818115613_add_index_project_id_on_dast_profile_schedule.rb'
- 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb'
- 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb'
- 'db/post_migrate/20210825182303_remove_duplicate_dast_site_tokens_with_same_token.rb'
- 'ee/app/controllers/ee/admin/dashboard_controller.rb'
- 'ee/app/controllers/ee/admin/groups_controller.rb'
- 'ee/app/controllers/ee/admin/users_controller.rb'
@ -199,7 +194,6 @@ Lint/MissingCopEnableDirective:
- 'qa/qa/scenario/test/integration/registry_with_cdn.rb'
- 'spec/benchmarks/banzai_benchmark.rb'
- 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb'
- 'spec/lib/initializer_connections_spec.rb'
- 'spec/support/capybara.rb'
- 'spec/support/cycle_analytics_helpers/test_generation.rb'
- 'spec/support/google_api/cloud_platform_helpers.rb'

67
.rubocop_todo/lint/redundant_cop_disable_directive.yml
View File

@ -1,7 +1,7 @@
---
# Cop supports --autocorrect.
Lint/RedundantCopDisableDirective:
# Offense count: 357
# Offense count: 429
# Temporarily disabled due to too many offenses
Enabled: false
Exclude:
@ -11,6 +11,7 @@ Lint/RedundantCopDisableDirective:
- 'app/controllers/groups/autocomplete_sources_controller.rb'
- 'app/controllers/groups/labels_controller.rb'
- 'app/controllers/projects/merge_requests/diffs_controller.rb'
- 'app/controllers/projects/merge_requests_controller.rb'
- 'app/finders/autocomplete/acts_as_taggable_on/tags_finder.rb'
- 'app/finders/autocomplete/move_to_project_finder.rb'
- 'app/finders/autocomplete/routes_finder.rb'
@ -35,7 +36,6 @@ Lint/RedundantCopDisableDirective:
- 'app/models/concerns/from_intersect.rb'
- 'app/models/concerns/from_union.rb'
- 'app/models/concerns/redis_cacheable.rb'
- 'app/models/project_statistics.rb'
- 'app/models/user.rb'
- 'app/presenters/dev_ops_report/metric_presenter.rb'
- 'app/presenters/packages/nuget/search_results_presenter.rb'
@ -66,11 +66,16 @@ Lint/RedundantCopDisableDirective:
- 'app/workers/ci/track_failed_build_worker.rb'
- 'app/workers/container_registry/migration/enqueuer_worker.rb'
- 'app/workers/create_note_diff_file_worker.rb'
- 'app/workers/database/batched_background_migration/execution_worker.rb'
- 'app/workers/import_issues_csv_worker.rb'
- 'app/workers/incident_management/process_alert_worker_v2.rb'
- 'app/workers/merge_worker.rb'
- 'app/workers/new_merge_request_worker.rb'
- 'app/workers/remove_unaccepted_member_invites_worker.rb'
- 'app/workers/run_pipeline_schedule_worker.rb'
- 'config/initializers/grape_validators.rb'
- 'config/initializers/warden.rb'
- 'config/initializers/wikicloth_redos_patch.rb'
- 'config/initializers/wikicloth_ruby_3_patch.rb'
- 'config/routes/api.rb'
- 'db/migrate/20210917134321_remove_temporary_index_for_project_topics_on_taggings.rb'
@ -78,21 +83,21 @@ Lint/RedundantCopDisableDirective:
- 'db/migrate/20220316022505_create_namespace_details.rb'
- 'db/migrate/20220421141342_add_allowed_plans_to_ci_runners.rb'
- 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb'
- 'db/post_migrate/20210610042700_remove_clusters_applications_fluentd_table.rb'
- 'db/post_migrate/20210708011426_finalize_ci_builds_metadata_bigint_conversion.rb'
- 'db/post_migrate/20210730104800_schedule_extract_project_topics_into_separate_table.rb'
- 'db/post_migrate/20210806131706_finalize_taggins_bigint_conversion.rb'
- 'db/post_migrate/20210906130643_drop_temporary_columns_and_triggers_for_taggings.rb'
- 'db/post_migrate/20211028100303_tmp_index_for_delete_issue_merge_request_taggings_records.rb'
- 'db/post_migrate/20220328100456_schedule20220328_reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb'
- 'db/post_migrate/20220328100457_schedule20220328_reset_duplicate_ci_runners_token_values_on_projects.rb'
- 'db/post_migrate/20220720090354_remove_pending_builds_covering_index_from_ci_builds.rb'
- 'db/post_migrate/20220902204048_move_security_findings_table_to_gitlab_partitions_dynamic_schema.rb'
- 'db/post_migrate/20221102231131_remove_temp_index_for_user_details_fields.rb'
- 'db/post_migrate/20230104103748_remove_new_amount_used_column.rb'
- 'db/post_migrate/20230105180002_remove_new_amount_used_column_on_ci_namespace_monthly_usages.rb'
- 'ee/app/controllers/ee/admin/application_settings_controller.rb'
- 'ee/app/controllers/ee/groups/group_members_controller.rb'
- 'ee/app/controllers/ee/projects/settings/ci_cd_controller.rb'
- 'ee/app/controllers/groups/todos_controller.rb'
- 'ee/app/experiments/cart_abandonment_modal_experiment.rb'
- 'ee/app/finders/epics/with_issues_finder.rb'
- 'ee/app/finders/geo/file_registry_finder.rb'
- 'ee/app/finders/geo/project_registry_finder.rb'
- 'ee/app/finders/geo/registry_finder.rb'
@ -104,15 +109,25 @@ Lint/RedundantCopDisableDirective:
- 'ee/app/graphql/types/vulnerability_request_type.rb'
- 'ee/app/helpers/ee/boards_helper.rb'
- 'ee/app/helpers/projects/on_demand_scans_helper.rb'
- 'ee/app/models/approver.rb'
- 'ee/app/models/approver_group.rb'
- 'ee/app/models/dast/branch.rb'
- 'ee/app/models/ee/epic.rb'
- 'ee/app/models/ee/group.rb'
- 'ee/app/models/ee/merge_request.rb'
- 'ee/app/models/ee/project.rb'
- 'ee/app/models/ee/user.rb'
- 'ee/app/models/ee/vulnerability.rb'
- 'ee/app/models/geo/event_log.rb'
- 'ee/app/models/geo_node.rb'
- 'ee/app/models/protected_environments/approval_rules/summarizable.rb'
- 'ee/app/models/requirements_management/requirement.rb'
- 'ee/app/services/analytics/cycle_analytics/consistency_check_service.rb'
- 'ee/app/services/analytics/cycle_analytics/data_loader_service.rb'
- 'ee/app/services/ee/boards/issues/list_service.rb'
- 'ee/app/services/ee/ci/queue/build_queue_service.rb'
- 'ee/app/services/ee/search_service.rb'
- 'ee/app/services/security/token_revocation_service.rb'
- 'ee/app/workers/ee/issuable_export_csv_worker.rb'
- 'ee/app/workers/ee/namespaces/in_product_marketing_emails_worker.rb'
- 'ee/app/workers/geo/design_repository_shard_sync_worker.rb'
@ -126,7 +141,10 @@ Lint/RedundantCopDisableDirective:
- 'ee/lib/api/dora/metrics.rb'
- 'ee/lib/ee/api/entities/analytics/code_review/merge_request.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_epic_cache_counts.rb'
- 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb'
- 'ee/lib/ee/gitlab/background_migration/fix_security_scan_statuses.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_shared_vulnerability_scanners.rb'
- 'ee/lib/ee/gitlab/background_migration/migrate_vulnerabilities_feedback_to_vulnerabilities_state_transition.rb'
- 'ee/lib/ee/gitlab/background_migration/purge_stale_security_scans.rb'
- 'ee/lib/ee/gitlab/usage_data.rb'
- 'ee/lib/elastic/latest/git_class_proxy.rb'
@ -134,15 +152,21 @@ Lint/RedundantCopDisableDirective:
- 'ee/lib/gitlab/elastic/bool_expr.rb'
- 'ee/lib/gitlab/spdx/license.rb'
- 'ee/lib/gitlab/status_page/storage/object.rb'
- 'ee/spec/controllers/concerns/gitlab_subscriptions/seat_count_alert_spec.rb'
- 'ee/spec/controllers/concerns/registrations/verification_spec.rb'
- 'ee/spec/controllers/concerns/routable_actions_spec.rb'
- 'ee/spec/elastic/migrate/20221026082700_backfill_users_spec.rb'
- 'ee/spec/features/boards/user_visits_board_spec.rb'
- 'ee/spec/features/groups/settings/domain_verification_spec.rb'
- 'ee/spec/helpers/ee/releases_helper_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size_spec.rb'
- 'ee/spec/lib/ee/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size_spec.rb'
- 'ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb'
- 'ee/spec/lib/elastic/latest/project_instance_proxy_spec.rb'
- 'ee/spec/lib/gitlab/geo/log_helpers_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/count_user_merge_requests_for_projects_with_applied_scan_result_policies_metric_spec.rb'
- 'ee/spec/lib/gitlab/usage/metrics/instrumentations/protected_environment_approval_rules_required_approvals_average_metric_spec.rb'
- 'ee/spec/requests/api/conan_project_packages_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb'
- 'ee/spec/services/security/merge_reports_service_spec.rb'
- 'ee/spec/support/shared_examples/models/elasticsearch_indexed_container_shared_examples.rb'
@ -151,19 +175,25 @@ Lint/RedundantCopDisableDirective:
- 'lib/api/ci/variables.rb'
- 'lib/api/entities/issuable_time_stats.rb'
- 'lib/api/helpers.rb'
- 'lib/api/issue_links.rb'
- 'lib/backup/manager.rb'
- 'lib/bulk_imports/common/transformers/user_reference_transformer.rb'
- 'lib/bulk_imports/pipeline/runner.rb'
- 'lib/container_registry/tag.rb'
- 'lib/event_filter.rb'
- 'lib/feature.rb'
- 'lib/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb'
- 'lib/gitlab/analytics/cycle_analytics/base_query_builder.rb'
- 'lib/gitlab/analytics/cycle_analytics/records_fetcher.rb'
- 'lib/gitlab/application_context.rb'
- 'lib/gitlab/background_migration/backfill_issue_search_data.rb'
- 'lib/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb'
- 'lib/gitlab/background_migration/backfill_project_statistics_storage_size_without_uploads_size.rb'
- 'lib/gitlab/background_migration/batching_strategies/loose_index_scan_batching_strategy.rb'
- 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb'
- 'lib/gitlab/background_migration/fix_incoherent_packages_size_on_project_statistics.rb'
- 'lib/gitlab/background_migration/migrate_personal_namespace_project_maintainer_to_owner.rb'
- 'lib/gitlab/background_migration/re_expire_o_auth_tokens.rb'
- 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb'
- 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb'
- 'lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings.rb'
@ -184,12 +214,15 @@ Lint/RedundantCopDisableDirective:
- 'lib/gitlab/database/consistency_checker.rb'
- 'lib/gitlab/database/migration.rb'
- 'lib/gitlab/database/migrations/observation.rb'
- 'lib/gitlab/database/migrations/observers/query_log.rb'
- 'lib/gitlab/database/rename_reserved_paths_migration/v1/rename_namespaces.rb'
- 'lib/gitlab/diff/file.rb'
- 'lib/gitlab/diff/file_collection/paginated_diffs.rb'
- 'lib/gitlab/diff/pair_selector.rb'
- 'lib/gitlab/diff/parser.rb'
- 'lib/gitlab/encrypted_incoming_email_command.rb'
- 'lib/gitlab/encrypted_ldap_command.rb'
- 'lib/gitlab/encrypted_service_desk_email_command.rb'
- 'lib/gitlab/encrypted_smtp_command.rb'
- 'lib/gitlab/git/commit.rb'
- 'lib/gitlab/git/patches/collection.rb'
@ -209,6 +242,8 @@ Lint/RedundantCopDisableDirective:
- 'lib/gitlab/project_search_results.rb'
- 'lib/gitlab/redis/hll.rb'
- 'lib/gitlab/search/sort_options.rb'
- 'lib/gitlab/seeders/ci/runner/runner_fleet_seeder.rb'
- 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb'
- 'lib/gitlab/slash_commands/issue_search.rb'
- 'lib/gitlab/slash_commands/result.rb'
- 'lib/gitlab/usage/metrics/instrumentations/count_imported_projects_metric.rb'
@ -220,11 +255,14 @@ Lint/RedundantCopDisableDirective:
- 'qa/qa/specs/features/ee/browser_ui/10_govern/create_merge_request_with_secure_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/10_govern/security_reports_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/10_govern/vulnerability_management_spec.rb'
- 'rubocop/cop/static_translation_definition.rb'
- 'scripts/security-harness'
- 'sidekiq_cluster/cli.rb'
- 'sidekiq_cluster/sidekiq_cluster.rb'
- 'spec/components/previews/pajamas/banner_component_preview.rb'
- 'spec/fixtures/packages/rubygems/package.gemspec'
- 'spec/controllers/concerns/preferred_language_switcher_spec.rb'
- 'spec/controllers/profiles/two_factor_auths_controller_spec.rb'
- 'spec/finders/personal_access_tokens_finder_spec.rb'
- 'spec/frontend/fixtures/merge_requests.rb'
- 'spec/graphql/mutations/clusters/agent_tokens/create_spec.rb'
- 'spec/graphql/mutations/clusters/agents/create_spec.rb'
@ -242,24 +280,30 @@ Lint/RedundantCopDisableDirective:
- 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects_spec.rb'
- 'spec/lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects_spec.rb'
- 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb'
- 'spec/lib/gitlab/database/load_balancing/transaction_leaking_spec.rb'
- 'spec/lib/gitlab/database/migration_helpers/restrict_gitlab_schema_spec.rb'
- 'spec/lib/gitlab/doorkeeper_secret_storing/secret/pbkdf2_sha512_spec.rb'
- 'spec/lib/gitlab/doorkeeper_secret_storing/token/pbkdf2_sha512_spec.rb'
- 'spec/lib/gitlab/gfm/uploads_rewriter_spec.rb'
- 'spec/lib/gitlab/git/tree_spec.rb'
- 'spec/lib/gitlab/import_export/project/relation_saver_spec.rb'
- 'spec/lib/gitlab/memory/watchdog/configurator_spec.rb'
- 'spec/lib/gitlab/merge_requests/message_generator_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb'
- 'spec/lib/gitlab/quick_actions/dsl_spec.rb'
- 'spec/lib/gitlab/rack_attack/request_spec.rb'
- 'spec/lib/gitlab/redis/multi_store_spec.rb'
- 'spec/lib/gitlab/shard_health_cache_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb'
- 'spec/lib/initializer_connections_spec.rb'
- 'spec/metrics_server/metrics_server_spec.rb'
- 'spec/migrations/20220725150127_update_jira_tracker_data_deployment_type_based_on_url_spec.rb'
- 'spec/migrations/reschedule_backfill_imported_issue_search_data_spec.rb'
- 'spec/migrations/add_namespaces_emails_enabled_column_data_spec.rb'
- 'spec/migrations/add_projects_emails_enabled_column_data_spec.rb'
- 'spec/models/ci/build_trace_chunk_spec.rb'
- 'spec/models/ci/pipeline_spec.rb'
- 'spec/models/concerns/encrypted_user_password_spec.rb'
- 'spec/models/concerns/triggerable_hooks_spec.rb'
- 'spec/models/namespace/package_setting_spec.rb'
- 'spec/models/namespace_spec.rb'
- 'spec/models/project_feature_spec.rb'
@ -276,6 +320,7 @@ Lint/RedundantCopDisableDirective:
- 'spec/services/spam/spam_verdict_service_spec.rb'
- 'spec/services/topics/merge_service_spec.rb'
- 'spec/support/forgery_protection.rb'
- 'spec/support/helpers/database/multiple_databases_helpers.rb'
- 'spec/support/helpers/snowplow_helpers.rb'
- 'spec/support/helpers/wait_for_requests.rb'
- 'spec/support/shared_examples/lib/gitlab/local_and_remote_storage_migration_shared_examples.rb'
@ -283,9 +328,11 @@ Lint/RedundantCopDisableDirective:
- 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb'
- 'spec/support/shared_examples/models/packages/debian/distribution_key_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb'
- 'spec/tasks/gitlab/db/validate_config_rake_spec.rb'
- 'spec/uploaders/packages/composer/cache_uploader_spec.rb'
- 'tooling/danger/product_intelligence.rb'
- 'tooling/danger/stable_branch.rb'
- 'tooling/danger/suggestor.rb'
- 'tooling/lib/tooling/helm3_client.rb'
- 'tooling/lib/tooling/kubernetes_client.rb'
- 'tooling/quality/test_level.rb'
- 'tooling/rspec_flaky/listener.rb'

1
.rubocop_todo/lint/unused_block_argument.yml
View File

@ -40,7 +40,6 @@ Lint/UnusedBlockArgument:
- 'app/models/merge_request.rb'
- 'app/models/namespace/root_storage_statistics.rb'
- 'app/models/project.rb'
- 'app/models/project_feature.rb'
- 'app/models/projects/build_artifacts_size_refresh.rb'
- 'app/models/service_desk_setting.rb'
- 'app/models/users/phone_number_validation.rb'

1
.rubocop_todo/lint/unused_method_argument.yml
View File

@ -282,7 +282,6 @@ Lint/UnusedMethodArgument:
- 'ee/app/services/epics/related_epic_links/create_service.rb'
- 'ee/app/services/epics/transfer_service.rb'
- 'ee/app/services/group_saml/identity/destroy_service.rb'
- 'ee/app/services/package_metadata/ingestion/ingestion_service.rb'
- 'ee/app/services/projects/update_mirror_service.rb'
- 'ee/app/services/security/security_orchestration_policies/process_scan_result_policy_service.rb'
- 'ee/app/services/vulnerabilities/finding_dismiss_service.rb'

1
.rubocop_todo/metrics/perceived_complexity.yml
View File

@ -5,7 +5,6 @@ Metrics/PerceivedComplexity:
- 'app/finders/deployments_finder.rb'
- 'app/helpers/button_helper.rb'
- 'app/helpers/nav/top_nav_helper.rb'
- 'app/helpers/submodule_helper.rb'
- 'app/services/projects/create_service.rb'
- 'ee/app/controllers/ee/groups_controller.rb'
- 'ee/lib/elastic/latest/git_class_proxy.rb'

1
.rubocop_todo/migration/background_migration_base_class.yml
View File

@ -7,7 +7,6 @@ Migration/BackgroundMigrationBaseClass:
- 'lib/gitlab/background_migration/backfill_integrations_type_new.rb'
- 'lib/gitlab/background_migration/backfill_issue_search_data.rb'
- 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'lib/gitlab/background_migration/backfill_jira_tracker_deployment_type2.rb'
- 'lib/gitlab/background_migration/backfill_member_namespace_for_group_members.rb'
- 'lib/gitlab/background_migration/backfill_namespace_id_for_namespace_route.rb'
- 'lib/gitlab/background_migration/backfill_namespace_id_for_project_route.rb'

10
.rubocop_todo/migration/background_migrations.yml
View File

@ -1,16 +1,6 @@
---
Migration/BackgroundMigrations:
Exclude:
- 'db/post_migrate/20210604070207_retry_backfill_traversal_ids.rb'
- 'db/post_migrate/20210611080951_fix_missing_traversal_ids.rb'
- 'db/post_migrate/20210701111909_backfill_issues_upvotes_count.rb'
- 'db/post_migrate/20210708130419_reschedule_merge_request_diff_users_background_migration.rb'
- 'db/post_migrate/20210722010101_reschedule_delete_orphaned_deployments.rb'
- 'db/post_migrate/20210729163312_re_schedule_latest_pipeline_id_population_with_all_security_related_artifact_types.rb'
- 'db/post_migrate/20210730104800_schedule_extract_project_topics_into_separate_table.rb'
- 'db/post_migrate/20210730170823_schedule_security_setting_creation.rb'
- 'db/post_migrate/20210823113259_steal_merge_request_diff_commit_users_migration.rb'
- 'db/post_migrate/20210825193652_backfill_cadence_id_for_boards_scoped_to_iteration.rb'
- 'db/post_migrate/20210830104800_reschedule_extract_project_topics_into_separate_table.rb'
- 'db/post_migrate/20210901153324_slice_merge_request_diff_commit_migrations.rb'
- 'db/post_migrate/20210909104800_reschedule_extract_project_topics_into_separate_table_2.rb'

4
.rubocop_todo/naming/heredoc_delimiter_naming.yml
View File

@ -2,7 +2,6 @@
Naming/HeredocDelimiterNaming:
Exclude:
- 'app/models/ci/build_trace_chunks/redis_base.rb'
- 'app/models/concerns/counter_attribute.rb'
- 'app/models/concerns/legacy_bulk_insert.rb'
- 'app/models/trending_project.rb'
- 'app/services/ci/ensure_stage_service.rb'
@ -41,7 +40,6 @@ Naming/HeredocDelimiterNaming:
- 'lib/gitlab/utils/delegator_override/validator.rb'
- 'lib/tasks/gitlab/docs/compile_deprecations.rake'
- 'lib/tasks/gitlab/password.rake'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/testing/view_code_coverage_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/package_registry/generic_repository_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb'
@ -57,7 +55,6 @@ Naming/HeredocDelimiterNaming:
- 'rubocop/cop/gitlab/predicate_memoization.rb'
- 'spec/controllers/projects/pipelines_controller_spec.rb'
- 'spec/deprecation_toolkit_env.rb'
- 'spec/factories/packages/debian/distribution.rb'
- 'spec/factories/packages/debian/file_metadatum.rb'
- 'spec/features/projects/commit/user_comments_on_commit_spec.rb'
- 'spec/features/task_lists_spec.rb'
@ -107,7 +104,6 @@ Naming/HeredocDelimiterNaming:
- 'spec/lib/gitlab/webpack/manifest_spec.rb'
- 'spec/lib/gitlab/word_diff/parser_spec.rb'
- 'spec/models/ci/bridge_spec.rb'
- 'spec/models/clusters/applications/cert_manager_spec.rb'
- 'spec/models/concerns/ci/maskable_spec.rb'
- 'spec/models/integrations/asana_spec.rb'
- 'spec/models/ssh_host_key_spec.rb'

1
.rubocop_todo/performance/active_record_subtransaction_methods.yml
View File

@ -37,7 +37,6 @@ Performance/ActiveRecordSubtransactionMethods:
- 'ee/app/models/software_license.rb'
- 'ee/app/services/boards/user_preferences/update_service.rb'
- 'ee/app/services/ci/minutes/update_project_and_namespace_usage_service.rb'
- 'ee/app/services/ee/analytics/cycle_analytics/stages/base_service.rb'
- 'ee/app/services/security/store_scan_service.rb'
- 'ee/app/workers/import_software_licenses_worker.rb'
- 'ee/db/fixtures/production/027_plans.rb'

1
.rubocop_todo/performance/collection_literal_in_loop.yml
View File

@ -22,7 +22,6 @@ Performance/CollectionLiteralInLoop:
- 'spec/lib/gitlab/file_detector_spec.rb'
- 'spec/lib/gitlab/search/abuse_detection_spec.rb'
- 'spec/lib/gitlab/utils/markdown_spec.rb'
- 'spec/metrics_server/metrics_server_spec.rb'
- 'spec/models/analytics/cycle_analytics/aggregation_spec.rb'
- 'spec/models/ci/build_spec.rb'
- 'spec/models/ci/pipeline_spec.rb'

3
.rubocop_todo/performance/flat_map.yml
View File

@ -15,10 +15,8 @@ Performance/FlatMap:
- 'ee/spec/requests/api/members_spec.rb'
- 'ee/spec/support/helpers/license_scanning_report_helpers.rb'
- 'ee/spec/support/shared_examples/finders/security/findings_finder_shared_examples.rb'
- 'lib/gitlab/ci/pipeline/chain/create_deployments.rb'
- 'lib/gitlab/ci/pipeline/chain/ensure_environments.rb'
- 'lib/gitlab/ci/pipeline/chain/ensure_resource_groups.rb'
- 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb'
- 'lib/gitlab/diff/file_collection/base.rb'
- 'lib/gitlab/instrumentation/redis_cluster_validator.rb'
- 'lib/gitlab/testing/request_inspector_middleware.rb'
@ -31,7 +29,6 @@ Performance/FlatMap:
- 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb'
- 'spec/models/ci/pipeline_spec.rb'
- 'spec/requests/api/graphql/ci/pipelines_spec.rb'
- 'spec/requests/api/projects_spec.rb'
- 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb'
- 'spec/services/git/process_ref_changes_service_spec.rb'
- 'spec/support/shared_examples/models/with_debian_distributions_shared_examples.rb'

1
.rubocop_todo/performance/map_compact.yml
View File

@ -122,7 +122,6 @@ Performance/MapCompact:
- 'lib/gitlab/url_blocker.rb'
- 'lib/gitlab/verify/batch_verifier.rb'
- 'qa/qa/page/component/issuable/sidebar.rb'
- 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_large_project_spec.rb'
- 'qa/qa/support/formatters/test_metrics_formatter.rb'
- 'qa/qa/tools/ci/ff_changes.rb'
- 'scripts/lint_templates_bash.rb'

2
.rubocop_todo/performance/method_object_as_block.yml
View File

@ -8,7 +8,6 @@ Performance/MethodObjectAsBlock:
- 'lib/gitlab/ci/build/rules/rule.rb'
- 'lib/gitlab/ci/build/rules/rule/clause/exists.rb'
- 'lib/gitlab/ci/config/yaml/tags/resolver.rb'
- 'lib/gitlab/ci/pipeline/chain/create_deployments.rb'
- 'lib/gitlab/ci/pipeline/chain/ensure_environments.rb'
- 'lib/gitlab/ci/pipeline/chain/ensure_resource_groups.rb'
- 'lib/gitlab/ci/pipeline/chain/validate/external.rb'
@ -24,7 +23,6 @@ Performance/MethodObjectAsBlock:
- 'lib/gitlab/dependency_linker/package_json_linker.rb'
- 'lib/gitlab/dependency_linker/podspec_json_linker.rb'
- 'lib/gitlab/dependency_linker/podspec_linker.rb'
- 'lib/gitlab/etag_caching/router/graphql.rb'
- 'lib/gitlab/etag_caching/router/rails.rb'
- 'lib/gitlab/health_checks/simple_abstract_check.rb'
- 'lib/gitlab/import_export/attributes_finder.rb'

1
.rubocop_todo/performance/rubyzip.yml
View File

@ -2,4 +2,3 @@
Performance/Rubyzip:
Exclude:
- 'app/services/packages/nuget/metadata_extraction_service.rb'
- 'lib/gitlab/ci/artifact_file_reader.rb'

4
.rubocop_todo/rails/file_path.yml
View File

@ -3,10 +3,8 @@ Rails/FilePath:
Exclude:
- 'app/controllers/help_controller.rb'
- 'app/helpers/startupjs_helper.rb'
- 'app/models/clusters/applications/cert_manager.rb'
- 'app/models/clusters/concerns/application_data.rb'
- 'app/models/concerns/cross_database_modification.rb'
- 'app/models/release_highlight.rb'
- 'app/serializers/review_app_setup_entity.rb'
- 'app/services/metrics/sample_metrics_service.rb'
- 'app/services/projects/readme_renderer_service.rb'
@ -15,7 +13,6 @@ Rails/FilePath:
- 'config/initializers/7_prometheus_metrics.rb'
- 'config/initializers/lograge.rb'
- 'config/initializers_before_autoloader/001_fast_gettext.rb'
- 'db/post_migrate/20210630025020_migrate_push_event_payloads_event_id_back_to_integer_for_gitlab_com.rb'
- 'ee/app/helpers/ee/application_helper.rb'
- 'ee/app/services/security/security_orchestration_policies/project_create_service.rb'
- 'ee/lib/ee/feature/definition.rb'
@ -118,7 +115,6 @@ Rails/FilePath:
- 'spec/lib/gitlab/project_transfer_spec.rb'
- 'spec/lib/gitlab/sanitizers/svg_spec.rb'
- 'spec/metrics_server/metrics_server_spec.rb'
- 'spec/models/clusters/applications/cert_manager_spec.rb'
- 'spec/models/release_highlight_spec.rb'
- 'spec/requests/api/internal/mail_room_spec.rb'
- 'spec/requests/api/usage_data_queries_spec.rb'

1
.rubocop_todo/rails/helper_instance_variable.yml
View File

@ -43,7 +43,6 @@ Rails/HelperInstanceVariable:
- 'app/helpers/routing/pseudonymization_helper.rb'
- 'app/helpers/routing/snippets_helper.rb'
- 'app/helpers/search_helper.rb'
- 'app/helpers/selects_helper.rb'
- 'app/helpers/startupjs_helper.rb'
- 'app/helpers/submodule_helper.rb'
- 'app/helpers/tab_helper.rb'

1
.rubocop_todo/rails/inverse_of.yml
View File

@ -3,7 +3,6 @@ Rails/InverseOf:
Exclude:
- 'app/models/alert_management/alert.rb'
- 'app/models/alert_management/alert_assignee.rb'
- 'app/models/analytics/cycle_analytics/project_stage.rb'
- 'app/models/application_setting.rb'
- 'app/models/audit_event.rb'
- 'app/models/board.rb'

1
.rubocop_todo/rails/lexically_scoped_action_filter.yml
View File

@ -21,7 +21,6 @@ Rails/LexicallyScopedActionFilter:
- 'app/controllers/import/base_controller.rb'
- 'app/controllers/oauth/applications_controller.rb'
- 'app/controllers/passwords_controller.rb'
- 'app/controllers/projects/analytics/cycle_analytics/stages_controller.rb'
- 'app/controllers/projects/badges_controller.rb'
- 'app/controllers/projects/branches_controller.rb'
- 'app/controllers/projects/environments_controller.rb'

13
.rubocop_todo/rails/negate_include.yml
View File

@ -16,7 +16,6 @@ Rails/NegateInclude:
- 'app/services/work_items/parent_links/create_service.rb'
- 'config/application.rb'
- 'config/initializers/1_settings.rb'
- 'danger/roulette/Dangerfile'
- 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb'
- 'ee/app/models/ee/vulnerability.rb'
- 'ee/app/services/epic_issues/create_service.rb'
@ -34,22 +33,10 @@ Rails/NegateInclude:
- 'lib/gitlab/import_export/attributes_permitter.rb'
- 'lib/gitlab/search_results.rb'
- 'lib/gitlab/task_helpers.rb'
- 'lib/gitlab/url_blocker.rb'
- 'lib/gitlab_edition.rb'
- 'qa/qa/page/merge_request/show.rb'
- 'qa/qa/runtime/ip_address.rb'
- 'qa/qa/support/run.rb'
- 'qa/qa/tools/delete_test_users.rb'
- 'rubocop/cop/gitlab/feature_available_usage.rb'
- 'rubocop/cop/graphql/id_type.rb'
- 'rubocop/cop/migration/add_reference.rb'
- 'rubocop/cop/rspec/factory_bot/inline_association.rb'
- 'scripts/lib/gitlab.rb'
- 'scripts/static-analysis'
- 'spec/lib/container_registry/blob_spec.rb'
- 'spec/lib/container_registry/client_spec.rb'
- 'spec/lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter_spec.rb'
- 'spec/lib/gitlab/metrics/subscribers/active_record_spec.rb'
- 'spec/support/matchers/pushed_frontend_feature_flags_matcher.rb'
- 'spec/uploaders/object_storage_spec.rb'
- 'tooling/danger/specs.rb'

13
.rubocop_todo/rails/pluck.yml
View File

@ -12,19 +12,16 @@ Rails/Pluck:
- 'app/models/integrations/chat_message/pipeline_message.rb'
- 'app/models/list.rb'
- 'app/models/packages/go/module_version.rb'
- 'app/models/work_items/parent_link.rb'
- 'app/services/ci/pipeline_processing/atomic_processing_service/status_collection.rb'
- 'app/services/feature_flags/update_service.rb'
- 'app/services/todos/destroy/destroyed_issuable_service.rb'
- 'app/workers/database/ci_namespace_mirrors_consistency_check_worker.rb'
- 'app/workers/database/ci_project_mirrors_consistency_check_worker.rb'
- 'db/post_migrate/20210811122206_update_external_project_bots.rb'
- 'ee/app/graphql/mutations/incident_management/escalation_policy/base.rb'
- 'ee/app/graphql/mutations/incident_management/oncall_rotation/base.rb'
- 'ee/app/models/boards/epic_list.rb'
- 'ee/app/models/concerns/geo/verification_state.rb'
- 'ee/app/services/concerns/incident_management/oncall_rotations/shared_rotation_logic.rb'
- 'ee/app/workers/geo/registry_sync_worker.rb'
- 'ee/app/workers/geo/repository_shard_sync_worker.rb'
- 'ee/app/workers/geo/repository_verification/secondary/shard_worker.rb'
- 'ee/app/workers/geo/scheduler/scheduler_worker.rb'
@ -34,7 +31,6 @@ Rails/Pluck:
- 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb'
- 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb'
- 'ee/lib/elastic/latest/custom_language_analyzers.rb'
- 'ee/lib/gitlab/ci/reports/license_scanning/report.rb'
- 'ee/lib/gitlab/search/index_curator.rb'
- 'ee/spec/controllers/autocomplete_controller_spec.rb'
- 'ee/spec/controllers/countries_controller_spec.rb'
@ -46,7 +42,6 @@ Rails/Pluck:
- 'ee/spec/controllers/projects/security/configuration_controller_spec.rb'
- 'ee/spec/features/projects/new_project_spec.rb'
- 'ee/spec/graphql/api/vulnerabilities_spec.rb'
- 'ee/spec/graphql/types/vulnerability_scanner_type_spec.rb'
- 'ee/spec/helpers/ee/geo_helper_spec.rb'
- 'ee/spec/helpers/ee/operations_helper_spec.rb'
- 'ee/spec/lib/ee/gitlab/import_export/group/tree_saver_spec.rb'
@ -96,7 +91,6 @@ Rails/Pluck:
- 'ee/spec/requests/ee/groups/autocomplete_sources_spec.rb'
- 'ee/spec/requests/groups/protected_environments_controller_spec.rb'
- 'ee/spec/requests/projects/issue_feature_flags_controller_spec.rb'
- 'ee/spec/services/analytics/cycle_analytics/stages/update_service_spec.rb'
- 'ee/spec/services/analytics/cycle_analytics/value_streams/create_service_spec.rb'
- 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb'
- 'ee/spec/services/ee/groups/autocomplete_service_spec.rb'
@ -134,7 +128,6 @@ Rails/Pluck:
- 'lib/gitlab/usage_data_counters/hll_redis_counter.rb'
- 'lib/gitlab/zentao/client.rb'
- 'lib/tasks/gitlab/info.rake'
- 'qa/qa/specs/features/api/1_manage/import/import_github_repo_spec.rb'
- 'qa/qa/specs/features/api/1_manage/migration/gitlab_migration_mr_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/integrations/jira/jira_basic_integration_spec.rb'
- 'qa/qa/tools/ci/qa_changes.rb'
@ -180,7 +173,6 @@ Rails/Pluck:
- 'spec/lib/gitlab/ci/ansi2json/line_spec.rb'
- 'spec/lib/gitlab/ci/yaml_processor_spec.rb'
- 'spec/lib/gitlab/conflict/file_spec.rb'
- 'spec/lib/gitlab/database/load_balancing/transaction_leaking_spec.rb'
- 'spec/lib/gitlab/database/similarity_score_spec.rb'
- 'spec/lib/gitlab/database_importers/common_metrics/importer_spec.rb'
- 'spec/lib/gitlab/git/blame_spec.rb'
@ -197,7 +189,6 @@ Rails/Pluck:
- 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/client_spec.rb'
- 'spec/lib/gitlab/tree_summary_spec.rb'
- 'spec/lib/peek/views/rugged_spec.rb'
- 'spec/migrations/20210713042000_fix_ci_sources_pipelines_index_names_spec.rb'
- 'spec/models/bulk_imports/entity_spec.rb'
- 'spec/models/ci/bridge_spec.rb'
- 'spec/models/ci/build_spec.rb'
@ -225,7 +216,6 @@ Rails/Pluck:
- 'spec/requests/api/graphql/boards/board_list_issues_query_spec.rb'
- 'spec/requests/api/graphql/ci/manual_variables_spec.rb'
- 'spec/requests/api/graphql/ci/pipelines_spec.rb'
- 'spec/requests/api/graphql/ci/runners_spec.rb'
- 'spec/requests/api/graphql/group/timelogs_spec.rb'
- 'spec/requests/api/graphql/group_query_spec.rb'
- 'spec/requests/api/graphql/mutations/design_management/move_spec.rb'
@ -234,7 +224,6 @@ Rails/Pluck:
- 'spec/requests/api/graphql/project/base_service_spec.rb'
- 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb'
- 'spec/requests/api/graphql/project/issue/designs/designs_spec.rb'
- 'spec/requests/api/graphql/project/issues_spec.rb'
- 'spec/requests/api/graphql/project/jira_import_spec.rb'
- 'spec/requests/api/graphql/project/jira_projects_spec.rb'
- 'spec/requests/api/graphql/project/release_spec.rb'
@ -292,7 +281,6 @@ Rails/Pluck:
- 'spec/support/shared_examples/graphql/mutation_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/container_repositories_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/custom_attributes_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/graphql/issue_list_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/graphql/packages/group_and_project_packages_list_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/graphql/packages/package_details_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/labels_api_shared_examples.rb'
@ -301,5 +289,4 @@ Rails/Pluck:
- 'spec/support/shared_examples/requests/api/repository_storage_moves_shared_examples.rb'
- 'spec/support/shared_examples/services/packages_shared_examples.rb'
- 'spec/tooling/docs/deprecation_handling_spec.rb'
- 'tooling/danger/sidekiq_queues.rb'
- 'tooling/docs/deprecation_handling.rb'

1
.rubocop_todo/rails/time_zone.yml
View File

@ -77,7 +77,6 @@ Rails/TimeZone:
- 'spec/lib/gitlab/external_authorization/cache_spec.rb'
- 'spec/lib/gitlab/external_authorization/logger_spec.rb'
- 'spec/lib/gitlab/fogbugz_import/importer_spec.rb'
- 'spec/lib/gitlab/git/commit_spec.rb'
- 'spec/lib/gitlab/github_import/importer/issue_importer_spec.rb'
- 'spec/lib/gitlab/github_import/importer/issues_importer_spec.rb'
- 'spec/lib/gitlab/github_import/importer/milestones_importer_spec.rb'

4
.rubocop_todo/rspec/any_instance_of.yml
View File

@ -4,7 +4,6 @@ RSpec/AnyInstanceOf:
Exclude:
- 'ee/spec/features/issues/form_spec.rb'
- 'ee/spec/features/projects/new_project_spec.rb'
- 'ee/spec/features/registrations/welcome_spec.rb'
- 'ee/spec/features/security/project/internal_access_spec.rb'
- 'ee/spec/features/security/project/private_access_spec.rb'
- 'ee/spec/features/security/project/public_access_spec.rb'
@ -95,7 +94,6 @@ RSpec/AnyInstanceOf:
- 'spec/controllers/projects/merge_requests_controller_spec.rb'
- 'spec/controllers/projects/pipelines_controller_spec.rb'
- 'spec/controllers/projects/settings/integration_hook_logs_controller_spec.rb'
- 'spec/controllers/projects/settings/integrations_controller_spec.rb'
- 'spec/controllers/projects/tags_controller_spec.rb'
- 'spec/controllers/registrations_controller_spec.rb'
- 'spec/controllers/sessions_controller_spec.rb'
@ -185,7 +183,6 @@ RSpec/AnyInstanceOf:
- 'spec/lib/gitlab/github_import/importer/pull_request_importer_spec.rb'
- 'spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb'
- 'spec/lib/gitlab/hashed_storage/migrator_spec.rb'
- 'spec/lib/gitlab/import/merge_request_helpers_spec.rb'
- 'spec/lib/gitlab/import_export/config_spec.rb'
- 'spec/lib/gitlab/import_export/fast_hash_serializer_spec.rb'
- 'spec/lib/gitlab/import_export/importer_spec.rb'
@ -224,7 +221,6 @@ RSpec/AnyInstanceOf:
- 'spec/models/merge_request_diff_spec.rb'
- 'spec/models/merge_request_spec.rb'
- 'spec/models/note_spec.rb'
- 'spec/models/project_import_state_spec.rb'
- 'spec/models/project_spec.rb'
- 'spec/models/repository_spec.rb'
- 'spec/models/user_spec.rb'

36
.rubocop_todo/rspec/context_wording.yml
View File

@ -167,7 +167,6 @@ RSpec/ContextWording:
- 'ee/spec/features/projects/settings/push_rules_settings_spec.rb'
- 'ee/spec/features/promotion_spec.rb'
- 'ee/spec/features/protected_branches_spec.rb'
- 'ee/spec/features/registrations/welcome_spec.rb'
- 'ee/spec/features/signup_spec.rb'
- 'ee/spec/features/trial_registrations/company_information_spec.rb'
- 'ee/spec/features/trials/select_namespace_spec.rb'
@ -203,7 +202,6 @@ RSpec/ContextWording:
- 'ee/spec/finders/merge_requests_finder_spec.rb'
- 'ee/spec/finders/productivity_analytics_finder_spec.rb'
- 'ee/spec/finders/scim_finder_spec.rb'
- 'ee/spec/finders/security/findings_finder_spec.rb'
- 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb'
- 'ee/spec/finders/security/training_providers/base_url_finder_spec.rb'
- 'ee/spec/finders/security/training_urls_finder_spec.rb'
@ -214,7 +212,6 @@ RSpec/ContextWording:
- 'ee/spec/finders/template_finder_spec.rb'
- 'ee/spec/frontend/fixtures/dast_profiles.rb'
- 'ee/spec/frontend/fixtures/on_demand_dast_scans.rb'
- 'ee/spec/frontend/fixtures/projects.rb'
- 'ee/spec/frontend/fixtures/search.rb'
- 'ee/spec/graphql/ee/resolvers/board_list_issues_resolver_spec.rb'
- 'ee/spec/graphql/ee/resolvers/namespace_projects_resolver_spec.rb'
@ -293,7 +290,6 @@ RSpec/ContextWording:
- 'ee/spec/initializers/1_settings_spec.rb'
- 'ee/spec/initializers/session_store_spec.rb'
- 'ee/spec/lib/audit/details_spec.rb'
- 'ee/spec/lib/audit/group_push_rules_changes_auditor_spec.rb'
- 'ee/spec/lib/banzai/filter/references/epic_reference_filter_spec.rb'
- 'ee/spec/lib/banzai/filter/references/iteration_reference_filter_spec.rb'
- 'ee/spec/lib/banzai/filter/references/vulnerability_reference_filters_spec.rb'
@ -336,7 +332,6 @@ RSpec/ContextWording:
- 'ee/spec/lib/ee/gitlab/issuable/clone/copy_resource_events_service_spec.rb'
- 'ee/spec/lib/ee/gitlab/issuable_metadata_spec.rb'
- 'ee/spec/lib/ee/gitlab/repo_path_spec.rb'
- 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb'
- 'ee/spec/lib/ee/gitlab/usage/service_ping/payload_keys_processor_spec.rb'
- 'ee/spec/lib/ee/gitlab/usage_data_spec.rb'
- 'ee/spec/lib/ee/service_ping/build_payload_spec.rb'
@ -433,7 +428,6 @@ RSpec/ContextWording:
- 'ee/spec/migrations/schedule_requirements_migration_spec.rb'
- 'ee/spec/models/alert_management/alert_payload_field_spec.rb'
- 'ee/spec/models/allowed_email_domain_spec.rb'
- 'ee/spec/models/analytics/cycle_analytics/project_stage_spec.rb'
- 'ee/spec/models/application_setting_spec.rb'
- 'ee/spec/models/approval_merge_request_rule_spec.rb'
- 'ee/spec/models/approval_project_rule_spec.rb'
@ -666,7 +660,6 @@ RSpec/ContextWording:
- 'ee/spec/serializers/merge_request_widget_entity_spec.rb'
- 'ee/spec/serializers/project_mirror_entity_spec.rb'
- 'ee/spec/serializers/vulnerabilities/finding_entity_spec.rb'
- 'ee/spec/services/analytics/cycle_analytics/stages/delete_service_spec.rb'
- 'ee/spec/services/analytics/cycle_analytics/value_streams/update_service_spec.rb'
- 'ee/spec/services/app_sec/dast/builds/associate_service_spec.rb'
- 'ee/spec/services/app_sec/dast/profiles/create_associations_service_spec.rb'
@ -774,7 +767,6 @@ RSpec/ContextWording:
- 'ee/spec/services/groups/mark_for_deletion_service_spec.rb'
- 'ee/spec/services/groups/memberships/export_service_spec.rb'
- 'ee/spec/services/groups/restore_service_spec.rb'
- 'ee/spec/services/groups/sync_service_spec.rb'
- 'ee/spec/services/groups/update_service_spec.rb'
- 'ee/spec/services/historical_user_data/csv_service_spec.rb'
- 'ee/spec/services/ide/schemas_config_service_spec.rb'
@ -913,7 +905,6 @@ RSpec/ContextWording:
- 'ee/spec/views/layouts/nav/sidebar/_push_rules_link.html.haml_spec.rb'
- 'ee/spec/views/profiles/preferences/show.html.haml_spec.rb'
- 'ee/spec/views/projects/security/discover/show.html.haml_spec.rb'
- 'ee/spec/views/search/_category.html.haml_spec.rb'
- 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb'
- 'ee/spec/views/shared/_kerberos_clone_button.html.haml_spec.rb'
- 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb'
@ -959,19 +950,12 @@ RSpec/ContextWording:
- 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb'
- 'qa/qa/specs/features/browser_ui/2_plan/milestone/assign_milestone_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/merge_request/suggestions/batch_suggestion_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/merge_request/suggestions/custom_commit_suggestion_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/repository/ssh_key_support_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide/server_hooks_custom_error_message_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/merge_mr_when_pipline_is_blocked_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/pipeline/mr_event_rule_pipeline_spec.rb'
- 'qa/qa/specs/features/browser_ui/4_verify/testing/endpoint_coverage_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/package_registry/maven/maven_group_level_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_ci_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb'
@ -986,7 +970,6 @@ RSpec/ContextWording:
- 'qa/spec/specs/helpers/context_selector_spec.rb'
- 'qa/spec/specs/helpers/quarantine_spec.rb'
- 'qa/spec/specs/runner_spec.rb'
- 'qa/spec/support/loglinking_spec.rb'
- 'qa/spec/support/page_error_checker_spec.rb'
- 'spec/benchmarks/banzai_benchmark.rb'
- 'spec/bin/feature_flag_spec.rb'
@ -1157,7 +1140,6 @@ RSpec/ContextWording:
- 'spec/features/dashboard/todos/todos_filtering_spec.rb'
- 'spec/features/dashboard/todos/todos_sorting_spec.rb'
- 'spec/features/dashboard/todos/todos_spec.rb'
- 'spec/features/dashboard/user_filters_projects_spec.rb'
- 'spec/features/expand_collapse_diffs_spec.rb'
- 'spec/features/file_uploads/multipart_invalid_uploads_spec.rb'
- 'spec/features/groups/board_sidebar_spec.rb'
@ -1182,7 +1164,6 @@ RSpec/ContextWording:
- 'spec/features/ics/dashboard_issues_spec.rb'
- 'spec/features/ics/group_issues_spec.rb'
- 'spec/features/ics/project_issues_spec.rb'
- 'spec/features/ide/clientside_preview_csp_spec.rb'
- 'spec/features/ide/static_object_external_storage_csp_spec.rb'
- 'spec/features/incidents/user_creates_new_incident_spec.rb'
- 'spec/features/invites_spec.rb'
@ -1279,7 +1260,6 @@ RSpec/ContextWording:
- 'spec/features/projects/environments/environments_spec.rb'
- 'spec/features/projects/features_visibility_spec.rb'
- 'spec/features/projects/files/template_selector_menu_spec.rb'
- 'spec/features/projects/files/template_type_dropdown_spec.rb'
- 'spec/features/projects/files/undo_template_spec.rb'
- 'spec/features/projects/files/user_creates_directory_spec.rb'
- 'spec/features/projects/fork_spec.rb'
@ -1401,7 +1381,6 @@ RSpec/ContextWording:
- 'spec/finders/packages/packages_finder_spec.rb'
- 'spec/finders/packages/pypi/package_finder_spec.rb'
- 'spec/finders/packages/pypi/packages_finder_spec.rb'
- 'spec/finders/personal_access_tokens_finder_spec.rb'
- 'spec/finders/personal_projects_finder_spec.rb'
- 'spec/finders/projects/groups_finder_spec.rb'
- 'spec/finders/projects/members/effective_access_level_finder_spec.rb'
@ -1493,7 +1472,6 @@ RSpec/ContextWording:
- 'spec/graphql/types/range_input_type_spec.rb'
- 'spec/graphql/types/release_links_type_spec.rb'
- 'spec/graphql/types/user_type_spec.rb'
- 'spec/haml_lint/linter/documentation_links_spec.rb'
- 'spec/haml_lint/linter/no_plain_nodes_spec.rb'
- 'spec/helpers/admin/user_actions_helper_spec.rb'
- 'spec/helpers/application_helper_spec.rb'
@ -1533,7 +1511,6 @@ RSpec/ContextWording:
- 'spec/helpers/releases_helper_spec.rb'
- 'spec/helpers/routing/pseudonymization_helper_spec.rb'
- 'spec/helpers/search_helper_spec.rb'
- 'spec/helpers/sorting_helper_spec.rb'
- 'spec/helpers/submodule_helper_spec.rb'
- 'spec/helpers/timeboxes_helper_spec.rb'
- 'spec/helpers/todos_helper_spec.rb'
@ -1576,7 +1553,6 @@ RSpec/ContextWording:
- 'spec/lib/api/validations/validators/limit_spec.rb'
- 'spec/lib/api/validations/validators/project_portable_spec.rb'
- 'spec/lib/api/validations/validators/untrusted_regexp_spec.rb'
- 'spec/lib/atlassian/jira_connect/client_spec.rb'
- 'spec/lib/atlassian/jira_connect/jwt/asymmetric_spec.rb'
- 'spec/lib/atlassian/jira_connect/jwt/symmetric_spec.rb'
- 'spec/lib/atlassian/jira_connect/serializers/deployment_entity_spec.rb'
@ -2050,7 +2026,6 @@ RSpec/ContextWording:
- 'spec/lib/gitlab/rack_attack_spec.rb'
- 'spec/lib/gitlab/reactive_cache_set_cache_spec.rb'
- 'spec/lib/gitlab/redis/boolean_spec.rb'
- 'spec/lib/gitlab/redis/duplicate_jobs_spec.rb'
- 'spec/lib/gitlab/regex_requires_app_spec.rb'
- 'spec/lib/gitlab/regex_spec.rb'
- 'spec/lib/gitlab/relative_positioning/item_context_spec.rb'
@ -2118,7 +2093,6 @@ RSpec/ContextWording:
- 'spec/lib/gitlab/usage/service_ping/payload_keys_processor_spec.rb'
- 'spec/lib/gitlab/usage/service_ping_report_spec.rb'
- 'spec/lib/gitlab/usage_data/topology_spec.rb'
- 'spec/lib/gitlab/usage_data_counters/hll_redis_counter_spec.rb'
- 'spec/lib/gitlab/usage_data_counters/ipynb_diff_activity_counter_spec.rb'
- 'spec/lib/gitlab/usage_data_counters/kubernetes_agent_counter_spec.rb'
- 'spec/lib/gitlab/usage_data_counters/quick_action_activity_unique_counter_spec.rb'
@ -2140,7 +2114,6 @@ RSpec/ContextWording:
- 'spec/lib/gitlab/x509/commit_spec.rb'
- 'spec/lib/gitlab/x509/signature_spec.rb'
- 'spec/lib/gitlab/zentao/client_spec.rb'
- 'spec/lib/google_api/cloud_platform/client_spec.rb'
- 'spec/lib/json_web_token/hmac_token_spec.rb'
- 'spec/lib/json_web_token/rsa_token_spec.rb'
- 'spec/lib/json_web_token/token_spec.rb'
@ -2175,14 +2148,11 @@ RSpec/ContextWording:
- 'spec/mailers/emails/releases_spec.rb'
- 'spec/mailers/emails/service_desk_spec.rb'
- 'spec/mailers/notify_spec.rb'
- 'spec/migrations/20210812013042_remove_duplicate_project_authorizations_spec.rb'
- 'spec/migrations/finalize_traversal_ids_background_migrations_spec.rb'
- 'spec/migrations/rename_services_to_integrations_spec.rb'
- 'spec/models/ability_spec.rb'
- 'spec/models/active_session_spec.rb'
- 'spec/models/alert_management/alert_spec.rb'
- 'spec/models/alert_management/http_integration_spec.rb'
- 'spec/models/analytics/cycle_analytics/project_stage_spec.rb'
- 'spec/models/appearance_spec.rb'
- 'spec/models/application_record_spec.rb'
- 'spec/models/application_setting_spec.rb'
@ -2221,7 +2191,6 @@ RSpec/ContextWording:
- 'spec/models/ci/trigger_spec.rb'
- 'spec/models/ci/variable_spec.rb'
- 'spec/models/clusters/agent_spec.rb'
- 'spec/models/clusters/applications/cert_manager_spec.rb'
- 'spec/models/clusters/applications/crossplane_spec.rb'
- 'spec/models/clusters/applications/helm_spec.rb'
- 'spec/models/clusters/applications/ingress_spec.rb'
@ -2257,7 +2226,6 @@ RSpec/ContextWording:
- 'spec/models/concerns/protected_ref_access_spec.rb'
- 'spec/models/concerns/reactive_caching_spec.rb'
- 'spec/models/concerns/resolvable_note_spec.rb'
- 'spec/models/concerns/sensitive_serializable_hash_spec.rb'
- 'spec/models/concerns/token_authenticatable_spec.rb'
- 'spec/models/concerns/triggerable_hooks_spec.rb'
- 'spec/models/concerns/usage_statistics_spec.rb'
@ -2783,7 +2751,6 @@ RSpec/ContextWording:
- 'spec/services/groups/update_service_spec.rb'
- 'spec/services/groups/update_shared_runners_service_spec.rb'
- 'spec/services/ide/base_config_service_spec.rb'
- 'spec/services/ide/schemas_config_service_spec.rb'
- 'spec/services/ide/terminal_config_service_spec.rb'
- 'spec/services/import/bitbucket_server_service_spec.rb'
- 'spec/services/import/fogbugz_service_spec.rb'
@ -2882,7 +2849,6 @@ RSpec/ContextWording:
- 'spec/services/packages/debian/create_distribution_service_spec.rb'
- 'spec/services/packages/debian/extract_metadata_service_spec.rb'
- 'spec/services/packages/debian/find_or_create_incoming_service_spec.rb'
- 'spec/services/packages/debian/find_or_create_package_service_spec.rb'
- 'spec/services/packages/debian/process_changes_service_spec.rb'
- 'spec/services/packages/helm/process_file_service_spec.rb'
- 'spec/services/packages/maven/create_package_service_spec.rb'
@ -3205,7 +3171,6 @@ RSpec/ContextWording:
- 'spec/tasks/dev_rake_spec.rb'
- 'spec/tasks/gettext_rake_spec.rb'
- 'spec/tasks/gitlab/cleanup_rake_spec.rb'
- 'spec/tasks/gitlab/db/lock_writes_rake_spec.rb'
- 'spec/tasks/gitlab/db/validate_config_rake_spec.rb'
- 'spec/tasks/gitlab/db_rake_spec.rb'
- 'spec/tasks/gitlab/dependency_proxy/migrate_rake_spec.rb'
@ -3289,7 +3254,6 @@ RSpec/ContextWording:
- 'spec/workers/cleanup_container_repository_worker_spec.rb'
- 'spec/workers/clusters/agents/delete_expired_events_worker_spec.rb'
- 'spec/workers/concerns/application_worker_spec.rb'
- 'spec/workers/concerns/waitable_worker_spec.rb'
- 'spec/workers/container_expiration_policies/cleanup_container_repository_worker_spec.rb'
- 'spec/workers/container_expiration_policy_worker_spec.rb'
- 'spec/workers/container_registry/migration/enqueuer_worker_spec.rb'

57
.rubocop_todo/rspec/described_class.yml
View File

@ -6,7 +6,6 @@ RSpec/DescribedClass:
- 'ee/spec/models/concerns/elastic/note_spec.rb'
- 'ee/spec/models/concerns/elastic/project_spec.rb'
- 'ee/spec/models/concerns/elastic/repository_spec.rb'
- 'ee/spec/models/concerns/elastic/snippet_spec.rb'
- 'ee/spec/models/dast_scanner_profile_spec.rb'
- 'ee/spec/models/dast_site_profile_spec.rb'
- 'ee/spec/models/ee/ci/job_artifact_spec.rb'
@ -15,7 +14,6 @@ RSpec/DescribedClass:
- 'ee/spec/models/ee/gpg_key_spec.rb'
- 'ee/spec/models/ee/group_spec.rb'
- 'ee/spec/models/ee/iteration_spec.rb'
- 'ee/spec/models/ee/merge_request_diff_spec.rb'
- 'ee/spec/models/ee/project_spec.rb'
- 'ee/spec/models/ee/vulnerability_spec.rb'
- 'ee/spec/models/epic_issue_spec.rb'
@ -25,74 +23,43 @@ RSpec/DescribedClass:
- 'ee/spec/models/geo/package_file_registry_spec.rb'
- 'ee/spec/models/geo/project_registry_spec.rb'
- 'ee/spec/models/geo/secondary_usage_data_spec.rb'
- 'ee/spec/models/incident_management/escalation_policy_spec.rb'
- 'ee/spec/models/issuable_metric_image_spec.rb'
- 'ee/spec/models/issue_spec.rb'
- 'ee/spec/models/license_spec.rb'
- 'ee/spec/models/merge_train_spec.rb'
- 'ee/spec/models/plan_spec.rb'
- 'ee/spec/models/project_import_state_spec.rb'
- 'ee/spec/models/release_highlight_spec.rb'
- 'ee/spec/models/requirements_management/requirement_spec.rb'
- 'ee/spec/models/requirements_management/test_report_spec.rb'
- 'ee/spec/models/resource_weight_event_spec.rb'
- 'ee/spec/models/uploads/local_spec.rb'
- 'ee/spec/models/vulnerabilities/finding_spec.rb'
- 'ee/spec/models/vulnerabilities/flag_spec.rb'
- 'ee/spec/models/vulnerabilities/read_spec.rb'
- 'ee/spec/services/arkose/blocked_users_report_service_spec.rb'
- 'ee/spec/services/ee/resource_events/synthetic_weight_notes_builder_service_spec.rb'
- 'ee/spec/services/ee/users/reject_service_spec.rb'
- 'ee/spec/services/resource_access_tokens/create_service_spec.rb'
- 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb'
- 'ee/spec/services/users/captcha_challenge_service_spec.rb'
- 'ee/spec/workers/concerns/elastic/indexing_control_spec.rb'
- 'ee/spec/workers/elastic/migration_worker_spec.rb'
- 'ee/spec/workers/geo/secondary/registry_consistency_worker_spec.rb'
- 'ee/spec/workers/geo/verification_state_backfill_worker_spec.rb'
- 'qa/spec/service/docker_run/base_spec.rb'
- 'qa/spec/support/loglinking_spec.rb'
- 'qa/spec/support/page_error_checker_spec.rb'
- 'spec/config/settings_spec.rb'
- 'spec/controllers/concerns/confirm_email_warning_spec.rb'
- 'spec/controllers/concerns/controller_with_cross_project_access_check_spec.rb'
- 'spec/controllers/concerns/enforces_admin_authentication_spec.rb'
- 'spec/controllers/concerns/graceful_timeout_handling_spec.rb'
- 'spec/controllers/concerns/group_tree_spec.rb'
- 'spec/controllers/concerns/metrics_dashboard_spec.rb'
- 'spec/controllers/concerns/product_analytics_tracking_spec.rb'
- 'spec/controllers/concerns/redirects_for_missing_path_on_tree_spec.rb'
- 'spec/controllers/concerns/redis_tracking_spec.rb'
- 'spec/controllers/concerns/renders_commits_spec.rb'
- 'spec/controllers/concerns/routable_actions_spec.rb'
- 'spec/controllers/concerns/sourcegraph_decorator_spec.rb'
- 'spec/controllers/concerns/spammable_actions/akismet_mark_as_spam_action_spec.rb'
- 'spec/controllers/concerns/spammable_actions/captcha_check/html_format_actions_support_spec.rb'
- 'spec/controllers/concerns/spammable_actions/captcha_check/json_format_actions_support_spec.rb'
- 'spec/controllers/concerns/static_object_external_storage_spec.rb'
- 'spec/controllers/repositories/git_http_controller_spec.rb'
- 'spec/experiments/application_experiment_spec.rb'
- 'spec/experiments/concerns/project_commit_count_spec.rb'
- 'spec/frontend/fixtures/metrics_dashboard.rb'
- 'spec/frontend/fixtures/timezones.rb'
- 'spec/frontend/fixtures/u2f.rb'
- 'spec/frontend/fixtures/webauthn.rb'
- 'spec/graphql/gitlab_schema_spec.rb'
- 'spec/graphql/graphql_triggers_spec.rb'
- 'spec/graphql/types/global_id_type_spec.rb'
- 'spec/initializers/google_api_client_spec.rb'
- 'spec/lib/api/entities/project_spec.rb'
- 'spec/lib/api/helpers_spec.rb'
- 'spec/lib/bulk_imports/groups/stage_spec.rb'
- 'spec/lib/bulk_imports/projects/stage_spec.rb'
- 'spec/lib/expand_variables_spec.rb'
- 'spec/lib/feature_spec.rb'
- 'spec/lib/gitlab/application_context_spec.rb'
- 'spec/lib/gitlab/asciidoc/html5_converter_spec.rb'
- 'spec/lib/gitlab/buffered_io_spec.rb'
- 'spec/lib/gitlab/checks/snippet_check_spec.rb'
- 'spec/lib/gitlab/ci/tags/bulk_insert_spec.rb'
- 'spec/lib/gitlab/ci/trace/chunked_io_spec.rb'
- 'spec/lib/gitlab/ci/variables/collection/item_spec.rb'
- 'spec/lib/gitlab/ci/variables/collection/sort_spec.rb'
- 'spec/lib/gitlab/ci/variables/collection_spec.rb'
@ -104,7 +71,6 @@ RSpec/DescribedClass:
- 'spec/lib/gitlab/database/load_balancing/host_spec.rb'
- 'spec/lib/gitlab/database/load_balancing/primary_host_spec.rb'
- 'spec/lib/gitlab/database/migrations/lock_retry_mixin_spec.rb'
- 'spec/lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection_spec.rb'
- 'spec/lib/gitlab/database/reindexing_spec.rb'
- 'spec/lib/gitlab/database/similarity_score_spec.rb'
- 'spec/lib/gitlab/database_spec.rb'
@ -124,26 +90,20 @@ RSpec/DescribedClass:
- 'spec/lib/gitlab/import_formatter_spec.rb'
- 'spec/lib/gitlab/inactive_projects_deletion_warning_tracker_spec.rb'
- 'spec/lib/gitlab/kubernetes/kube_client_spec.rb'
- 'spec/lib/gitlab/no_cache_headers_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/order_spec.rb'
- 'spec/lib/gitlab/relative_positioning/range_spec.rb'
- 'spec/lib/gitlab/runtime_spec.rb'
- 'spec/lib/gitlab/search_context/controller_concern_spec.rb'
- 'spec/lib/gitlab/seeder_spec.rb'
- 'spec/lib/gitlab/serverless/service_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/size_limiter/client_spec.rb'
- 'spec/lib/gitlab/suggestions/commit_message_spec.rb'
- 'spec/lib/gitlab/usage/metrics/aggregates/sources/redis_hll_spec.rb'
- 'spec/lib/gitlab/utils/measuring_spec.rb'
- 'spec/lib/gitlab/webpack/file_loader_spec.rb'
- 'spec/lib/gitlab/webpack/manifest_spec.rb'
- 'spec/lib/gitlab/x509/commit_spec.rb'
- 'spec/lib/gitlab/x509/signature_spec.rb'
- 'spec/lib/peek/views/active_record_spec.rb'
- 'spec/lib/service_ping/devops_report_spec.rb'
- 'spec/lib/sidebars/panel_spec.rb'
- 'spec/mailers/emails/service_desk_spec.rb'
- 'spec/metrics_server/metrics_server_spec.rb'
- 'spec/models/active_session_spec.rb'
- 'spec/models/alert_management/alert_spec.rb'
- 'spec/models/application_record_spec.rb'
@ -155,7 +115,6 @@ RSpec/DescribedClass:
- 'spec/models/ci/build_spec.rb'
- 'spec/models/ci/group_variable_spec.rb'
- 'spec/models/ci/job_artifact_spec.rb'
- 'spec/models/ci/namespace_mirror_spec.rb'
- 'spec/models/ci/pipeline_artifact_spec.rb'
- 'spec/models/ci/pipeline_spec.rb'
- 'spec/models/ci/processable_spec.rb'
@ -165,14 +124,10 @@ RSpec/DescribedClass:
- 'spec/models/clusters/cluster_spec.rb'
- 'spec/models/commit_spec.rb'
- 'spec/models/commit_status_spec.rb'
- 'spec/models/concerns/blocks_unsafe_serialization_spec.rb'
- 'spec/models/concerns/bulk_insertable_associations_spec.rb'
- 'spec/models/concerns/counter_attribute_spec.rb'
- 'spec/models/concerns/has_user_type_spec.rb'
- 'spec/models/concerns/integrations/enable_ssl_verification_spec.rb'
- 'spec/models/concerns/integrations/reset_secret_fields_spec.rb'
- 'spec/models/concerns/issuable_spec.rb'
- 'spec/models/concerns/mentionable_spec.rb'
- 'spec/models/concerns/resolvable_note_spec.rb'
- 'spec/models/concerns/token_authenticatable_spec.rb'
- 'spec/models/customer_relations/contact_spec.rb'
@ -185,7 +140,6 @@ RSpec/DescribedClass:
- 'spec/models/internal_id_spec.rb'
- 'spec/models/issue_assignee_spec.rb'
- 'spec/models/issue_spec.rb'
- 'spec/models/jira_import_state_spec.rb'
- 'spec/models/label_link_spec.rb'
- 'spec/models/lfs_objects_project_spec.rb'
- 'spec/models/loose_foreign_keys/deleted_record_spec.rb'
@ -196,7 +150,6 @@ RSpec/DescribedClass:
- 'spec/models/merge_request_spec.rb'
- 'spec/models/milestone_spec.rb'
- 'spec/models/namespace_spec.rb'
- 'spec/models/namespace_statistics_spec.rb'
- 'spec/models/oauth_access_token_spec.rb'
- 'spec/models/packages/dependency_spec.rb'
- 'spec/models/packages/maven/metadatum_spec.rb'
@ -207,12 +160,9 @@ RSpec/DescribedClass:
- 'spec/models/performance_monitoring/prometheus_metric_spec.rb'
- 'spec/models/performance_monitoring/prometheus_panel_group_spec.rb'
- 'spec/models/performance_monitoring/prometheus_panel_spec.rb'
- 'spec/models/plan_spec.rb'
- 'spec/models/postgresql/detached_partition_spec.rb'
- 'spec/models/preloaders/user_max_access_level_in_projects_preloader_spec.rb'
- 'spec/models/preloaders/users_max_access_level_in_projects_preloader_spec.rb'
- 'spec/models/project_feature_usage_spec.rb'
- 'spec/models/project_setting_spec.rb'
- 'spec/models/project_spec.rb'
- 'spec/models/projects/topic_spec.rb'
- 'spec/models/release_highlight_spec.rb'
@ -221,7 +171,6 @@ RSpec/DescribedClass:
- 'spec/models/todo_spec.rb'
- 'spec/models/u2f_registration_spec.rb'
- 'spec/models/user_custom_attribute_spec.rb'
- 'spec/models/user_preference_spec.rb'
- 'spec/models/user_spec.rb'
- 'spec/models/users/merge_request_interaction_spec.rb'
- 'spec/models/users_statistics_spec.rb'
@ -233,20 +182,14 @@ RSpec/DescribedClass:
- 'spec/services/ci/register_job_service_spec.rb'
- 'spec/services/incident_management/issuable_escalation_statuses/after_update_service_spec.rb'
- 'spec/services/issuable/process_assignees_spec.rb'
- 'spec/services/loose_foreign_keys/cleaner_service_spec.rb'
- 'spec/services/merge_requests/update_service_spec.rb'
- 'spec/services/notification_service_spec.rb'
- 'spec/services/projects/create_service_spec.rb'
- 'spec/services/resource_access_tokens/create_service_spec.rb'
- 'spec/services/resource_events/synthetic_label_notes_builder_service_spec.rb'
- 'spec/services/snippets/update_service_spec.rb'
- 'spec/services/system_hooks_service_spec.rb'
- 'spec/services/user_project_access_changed_service_spec.rb'
- 'spec/services/webauthn/authenticate_service_spec.rb'
- 'spec/services/webauthn/register_service_spec.rb'
- 'spec/support_specs/helpers/active_record/query_recorder_spec.rb'
- 'spec/support_specs/helpers/graphql_helpers_spec.rb'
- 'spec/support_specs/matchers/exceed_query_limit_helpers_spec.rb'
- 'spec/validators/html_safety_validator_spec.rb'
- 'spec/workers/bulk_imports/entity_worker_spec.rb'
- 'spec/workers/jira_connect/retry_request_worker_spec.rb'

2
.rubocop_todo/rspec/empty_line_after_hook.yml
View File

@ -7,7 +7,6 @@ RSpec/EmptyLineAfterHook:
- 'ee/spec/features/issues/user_bulk_edits_issues_spec.rb'
- 'ee/spec/lib/ee/api/entities/user_with_admin_spec.rb'
- 'ee/spec/lib/ee/gitlab/auth/ldap/sync/group_spec.rb'
- 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb'
- 'ee/spec/lib/gitlab/audit/auditor_spec.rb'
- 'ee/spec/lib/gitlab/proxy_spec.rb'
- 'ee/spec/lib/gitlab/vulnerabilities/container_scanning_vulnerability_spec.rb'
@ -17,7 +16,6 @@ RSpec/EmptyLineAfterHook:
- 'ee/spec/services/ci/sync_reports_to_approval_rules_service_spec.rb'
- 'ee/spec/services/ee/gpg_keys/destroy_service_spec.rb'
- 'ee/spec/services/external_status_checks/update_service_spec.rb'
- 'ee/spec/services/group_saml/saml_group_links/destroy_service_spec.rb'
- 'ee/spec/services/groups/memberships/export_service_spec.rb'
- 'ee/spec/services/merge_requests/approval_service_spec.rb'
- 'ee/spec/support/shared_examples/policies/protected_environments_shared_examples.rb'

2
.rubocop_todo/rspec/env_mocking.yml
View File

@ -1,8 +1,8 @@
---
# Cop supports --autocorrect.
RSpec/EnvMocking:
Details: grace period
Exclude:
- 'ee/spec/lib/gitlab/elastic/client_spec.rb'
- 'spec/initializers/net_http_patch_spec.rb'
- 'spec/lib/gitlab/database/reflection_spec.rb'
Details: grace period

8
.rubocop_todo/rspec/expect_change.yml
View File

@ -36,7 +36,6 @@ RSpec/ExpectChange:
- 'ee/spec/lib/quality/seeders/vulnerabilities_spec.rb'
- 'ee/spec/mailers/license_mailer_spec.rb'
- 'ee/spec/migrations/20220517144749_remove_vulnerability_approval_rules_spec.rb'
- 'ee/spec/migrations/add_non_null_constraint_for_escalation_rule_on_pending_alert_escalations_spec.rb'
- 'ee/spec/models/ee/ci/pending_build_spec.rb'
- 'ee/spec/models/ee/group_spec.rb'
- 'ee/spec/models/ee/namespace_spec.rb'
@ -80,7 +79,6 @@ RSpec/ExpectChange:
- 'ee/spec/requests/groups/epics/related_epic_links_controller_spec.rb'
- 'ee/spec/requests/groups/protected_environments_controller_spec.rb'
- 'ee/spec/requests/groups_controller_spec.rb'
- 'ee/spec/requests/registrations/project_creation_spec.rb'
- 'ee/spec/services/app_sec/dast/scanner_profiles/create_service_spec.rb'
- 'ee/spec/services/app_sec/dast/scans/run_service_spec.rb'
- 'ee/spec/services/app_sec/dast/site_profiles/create_service_spec.rb'
@ -136,7 +134,6 @@ RSpec/ExpectChange:
- 'ee/spec/services/geo/repository_sync_service_spec.rb'
- 'ee/spec/services/geo/repository_updated_service_spec.rb'
- 'ee/spec/services/geo/repository_verification_primary_service_spec.rb'
- 'ee/spec/services/geo/repository_verification_secondary_service_spec.rb'
- 'ee/spec/services/geo/wiki_sync_service_spec.rb'
- 'ee/spec/services/gitlab_subscriptions/activate_service_spec.rb'
- 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb'
@ -170,7 +167,6 @@ RSpec/ExpectChange:
- 'ee/spec/services/security/security_orchestration_policies/create_pipeline_service_spec.rb'
- 'ee/spec/services/security/security_orchestration_policies/process_rule_service_spec.rb'
- 'ee/spec/services/security/security_orchestration_policies/rule_schedule_service_spec.rb'
- 'ee/spec/services/security/security_orchestration_policies/sync_scan_result_policies_service_spec.rb'
- 'ee/spec/services/security/store_findings_service_spec.rb'
- 'ee/spec/services/users/email_verification/send_custom_confirmation_instructions_service_spec.rb'
- 'ee/spec/services/vulnerabilities/dismiss_service_spec.rb'
@ -253,7 +249,6 @@ RSpec/ExpectChange:
- 'spec/lib/gitlab/background_migration/remove_occurrence_pipelines_and_duplicate_vulnerabilities_findings_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_self_managed_wiki_notes_spec.rb'
- 'spec/lib/gitlab/background_migration/rename_task_system_note_to_checklist_item_spec.rb'
- 'spec/lib/gitlab/background_migration/sanitize_confidential_todos_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/chain/assign_partition_spec.rb'
- 'spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb'
- 'spec/lib/gitlab/ci/reports/test_suite_spec.rb'
@ -291,8 +286,6 @@ RSpec/ExpectChange:
- 'spec/migrations/cleanup_mr_attention_request_todos_spec.rb'
- 'spec/migrations/cleanup_vulnerability_state_transitions_with_same_from_state_to_state_spec.rb'
- 'spec/migrations/delete_migrate_shared_vulnerability_scanners_spec.rb'
- 'spec/migrations/remove_duplicate_dast_site_tokens_spec.rb'
- 'spec/migrations/remove_duplicate_dast_site_tokens_with_same_token_spec.rb'
- 'spec/models/awareness_session_spec.rb'
- 'spec/models/ci/build_metadata_spec.rb'
- 'spec/models/ci/build_spec.rb'
@ -377,7 +370,6 @@ RSpec/ExpectChange:
- 'spec/services/git/branch_push_service_spec.rb'
- 'spec/services/git/wiki_push_service_spec.rb'
- 'spec/services/gpg_keys/destroy_service_spec.rb'
- 'spec/services/groups/create_service_spec.rb'
- 'spec/services/import/gitlab_projects/create_project_service_spec.rb'
- 'spec/services/incident_management/incidents/create_service_spec.rb'
- 'spec/services/incident_management/issuable_escalation_statuses/prepare_update_service_spec.rb'

10
.rubocop_todo/rspec/expect_in_hook.yml
View File

@ -51,7 +51,6 @@ RSpec/ExpectInHook:
- 'ee/spec/models/concerns/geo/replicable_model_spec.rb'
- 'ee/spec/models/container_repository_spec.rb'
- 'ee/spec/models/dora/daily_metrics_spec.rb'
- 'ee/spec/models/ee/namespace_spec.rb'
- 'ee/spec/models/ee/project_spec.rb'
- 'ee/spec/models/gitlab_subscription_spec.rb'
- 'ee/spec/models/license_spec.rb'
@ -61,7 +60,6 @@ RSpec/ExpectInHook:
- 'ee/spec/requests/api/internal/base_spec.rb'
- 'ee/spec/requests/groups/analytics/devops_adoption_controller_spec.rb'
- 'ee/spec/requests/omniauth_kerberos_spec.rb'
- 'ee/spec/services/analytics/cycle_analytics/stages/update_service_spec.rb'
- 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb'
- 'ee/spec/services/auto_merge/add_to_merge_train_when_pipeline_succeeds_service_spec.rb'
- 'ee/spec/services/ci/minutes/batch_reset_service_spec.rb'
@ -195,12 +193,10 @@ RSpec/ExpectInHook:
- 'spec/lib/gitlab/ci/config/entry/ports_spec.rb'
- 'spec/lib/gitlab/ci/config/entry/processable_spec.rb'
- 'spec/lib/gitlab/ci/parsers/test/junit_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/chain/cancel_pending_pipelines_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/chain/command_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/chain/config/content_spec.rb'
- 'spec/lib/gitlab/ci/status/build/failed_spec.rb'
- 'spec/lib/gitlab/ci/trace/remote_checksum_spec.rb'
- 'spec/lib/gitlab/ci/yaml_processor_spec.rb'
- 'spec/lib/gitlab/cleanup/orphan_lfs_file_references_spec.rb'
- 'spec/lib/gitlab/cleanup/project_uploads_spec.rb'
- 'spec/lib/gitlab/cleanup/remote_uploads_spec.rb'
@ -229,7 +225,6 @@ RSpec/ExpectInHook:
- 'spec/lib/gitlab/email/service_desk_receiver_spec.rb'
- 'spec/lib/gitlab/error_tracking_spec.rb'
- 'spec/lib/gitlab/faraday/error_callback_spec.rb'
- 'spec/lib/gitlab/fips_spec.rb'
- 'spec/lib/gitlab/git/repository_spec.rb'
- 'spec/lib/gitlab/git_access_snippet_spec.rb'
- 'spec/lib/gitlab/gitaly_client/commit_service_spec.rb'
@ -305,7 +300,6 @@ RSpec/ExpectInHook:
- 'spec/models/ci/namespace_mirror_spec.rb'
- 'spec/models/ci/pipeline_spec.rb'
- 'spec/models/ci/runner_spec.rb'
- 'spec/models/clusters/applications/cert_manager_spec.rb'
- 'spec/models/clusters/platforms/kubernetes_spec.rb'
- 'spec/models/clusters/providers/aws_spec.rb'
- 'spec/models/clusters/providers/gcp_spec.rb'
@ -324,7 +318,6 @@ RSpec/ExpectInHook:
- 'spec/models/merge_request_diff_spec.rb'
- 'spec/models/merge_request_spec.rb'
- 'spec/models/postgresql/replication_slot_spec.rb'
- 'spec/models/project_import_state_spec.rb'
- 'spec/models/project_spec.rb'
- 'spec/models/repository_spec.rb'
- 'spec/models/route_spec.rb'
@ -379,7 +372,6 @@ RSpec/ExpectInHook:
- 'spec/services/captcha/captcha_verification_service_spec.rb'
- 'spec/services/ci/create_pipeline_service_spec.rb'
- 'spec/services/ci/delete_objects_service_spec.rb'
- 'spec/services/ci/generate_kubeconfig_service_spec.rb'
- 'spec/services/ci/job_artifacts/destroy_all_expired_service_spec.rb'
- 'spec/services/ci/job_artifacts/destroy_batch_service_spec.rb'
- 'spec/services/ci/register_job_service_spec.rb'
@ -442,7 +434,6 @@ RSpec/ExpectInHook:
- 'spec/services/projects/import_export/export_service_spec.rb'
- 'spec/services/projects/import_service_spec.rb'
- 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb'
- 'spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb'
- 'spec/services/projects/overwrite_project_service_spec.rb'
- 'spec/services/projects/refresh_build_artifacts_size_statistics_service_spec.rb'
- 'spec/services/projects/transfer_service_spec.rb'
@ -466,7 +457,6 @@ RSpec/ExpectInHook:
- 'spec/support/shared_examples/lib/gitlab/diff_file_collections_shared_examples.rb'
- 'spec/support/shared_examples/lib/wikis_api_examples.rb'
- 'spec/support/shared_examples/metrics/sampler_shared_examples.rb'
- 'spec/support/shared_examples/models/concerns/counter_attribute_shared_examples.rb'
- 'spec/support/shared_examples/models/concerns/has_wiki_shared_examples.rb'
- 'spec/support/shared_examples/models/concerns/update_namespace_statistics_shared_examples.rb'
- 'spec/support/shared_examples/models/mentionable_shared_examples.rb'

10
.rubocop_todo/rspec/factory_bot/avoid_create.yml
View File

@ -36,7 +36,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'ee/spec/helpers/ee/issuables_helper_spec.rb'
- 'ee/spec/helpers/ee/issues_helper_spec.rb'
- 'ee/spec/helpers/ee/labels_helper_spec.rb'
- 'ee/spec/helpers/projects/learn_gitlab_helper_spec.rb'
- 'ee/spec/helpers/ee/lock_helper_spec.rb'
- 'ee/spec/helpers/ee/namespace_user_cap_reached_alert_helper_spec.rb'
- 'ee/spec/helpers/ee/namespaces_helper_spec.rb'
@ -68,6 +67,7 @@ RSpec/FactoryBot/AvoidCreate:
- 'ee/spec/helpers/notes_helper_spec.rb'
- 'ee/spec/helpers/path_locks_helper_spec.rb'
- 'ee/spec/helpers/prevent_forking_helper_spec.rb'
- 'ee/spec/helpers/projects/learn_gitlab_helper_spec.rb'
- 'ee/spec/helpers/projects/on_demand_scans_helper_spec.rb'
- 'ee/spec/helpers/projects/project_members_helper_spec.rb'
- 'ee/spec/helpers/projects/security/dast_profiles_helper_spec.rb'
@ -120,7 +120,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'ee/spec/presenters/subscription_presenter_spec.rb'
- 'ee/spec/presenters/vulnerability_presenter_spec.rb'
- 'ee/spec/presenters/web_hooks/group/hook_presenter_spec.rb'
- 'ee/spec/serializers/analytics/cycle_analytics/stage_entity_spec.rb'
- 'ee/spec/serializers/analytics/cycle_analytics/value_stream_errors_serializer_spec.rb'
- 'ee/spec/serializers/audit_event_entity_spec.rb'
- 'ee/spec/serializers/audit_event_serializer_spec.rb'
@ -232,8 +231,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'ee/spec/views/projects/security/sast_configuration/show.html.haml_spec.rb'
- 'ee/spec/views/projects/settings/subscriptions/_index.html.haml_spec.rb'
- 'ee/spec/views/registrations/groups_projects/new.html.haml_spec.rb'
- 'ee/spec/views/registrations/welcome/show.html.haml_spec.rb'
- 'ee/spec/views/search/_category.html.haml_spec.rb'
- 'ee/spec/views/shared/_clone_panel.html.haml_spec.rb'
- 'ee/spec/views/shared/_kerberos_clone_button.html.haml_spec.rb'
- 'ee/spec/views/shared/_mirror_status.html.haml_spec.rb'
@ -431,13 +428,11 @@ RSpec/FactoryBot/AvoidCreate:
- 'spec/serializers/ci/dag_stage_entity_spec.rb'
- 'spec/serializers/ci/downloadable_artifact_entity_spec.rb'
- 'spec/serializers/ci/downloadable_artifact_serializer_spec.rb'
- 'spec/serializers/ci/group_variable_entity_spec.rb'
- 'spec/serializers/ci/job_entity_spec.rb'
- 'spec/serializers/ci/job_serializer_spec.rb'
- 'spec/serializers/ci/lint/result_serializer_spec.rb'
- 'spec/serializers/ci/pipeline_entity_spec.rb'
- 'spec/serializers/ci/trigger_entity_spec.rb'
- 'spec/serializers/ci/variable_entity_spec.rb'
- 'spec/serializers/cluster_application_entity_spec.rb'
- 'spec/serializers/cluster_entity_spec.rb'
- 'spec/serializers/cluster_serializer_spec.rb'
@ -525,7 +520,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'spec/serializers/project_access_token_entity_spec.rb'
- 'spec/serializers/project_access_token_serializer_spec.rb'
- 'spec/serializers/project_import_entity_spec.rb'
- 'spec/serializers/project_mirror_entity_spec.rb'
- 'spec/serializers/project_note_entity_spec.rb'
- 'spec/serializers/project_serializer_spec.rb'
- 'spec/serializers/review_app_setup_entity_spec.rb'
@ -552,7 +546,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'spec/views/admin/application_settings/ci_cd.html.haml_spec.rb'
- 'spec/views/admin/application_settings/general.html.haml_spec.rb'
- 'spec/views/admin/application_settings/repository.html.haml_spec.rb'
- 'spec/views/admin/broadcast_messages/index.html.haml_spec.rb'
- 'spec/views/admin/dashboard/index.html.haml_spec.rb'
- 'spec/views/admin/identities/index.html.haml_spec.rb'
- 'spec/views/admin/sessions/new.html.haml_spec.rb'
@ -588,7 +581,6 @@ RSpec/FactoryBot/AvoidCreate:
- 'spec/views/profiles/keys/_key_details.html.haml_spec.rb'
- 'spec/views/profiles/notifications/show.html.haml_spec.rb'
- 'spec/views/profiles/show.html.haml_spec.rb'
- 'spec/views/projects/_files.html.haml_spec.rb'
- 'spec/views/projects/_flash_messages.html.haml_spec.rb'
- 'spec/views/projects/_home_panel.html.haml_spec.rb'
- 'spec/views/projects/branches/index.html.haml_spec.rb'

5
.rubocop_todo/rspec/instance_variable.yml
View File

@ -42,7 +42,6 @@ RSpec/InstanceVariable:
- 'qa/qa/specs/features/browser_ui/3_create/repository/user_views_commit_diff_patch_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide/add_file_template_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide/link_to_line_in_web_ide_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb'
- 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/13_secure/merge_request_license_widget_spec.rb'
@ -106,7 +105,6 @@ RSpec/InstanceVariable:
- 'spec/lib/gitlab/chat_name_token_spec.rb'
- 'spec/lib/gitlab/ci/lint_spec.rb'
- 'spec/lib/gitlab/ci/status/composite_spec.rb'
- 'spec/lib/gitlab/contributions_calendar_spec.rb'
- 'spec/lib/gitlab/diff/parser_spec.rb'
- 'spec/lib/gitlab/email/hook/smime_signature_interceptor_spec.rb'
- 'spec/lib/gitlab/git/diff_collection_spec.rb'
@ -125,8 +123,6 @@ RSpec/InstanceVariable:
- 'spec/lib/gitlab/x509/certificate_spec.rb'
- 'spec/mailers/emails/issues_spec.rb'
- 'spec/migrations/20220106163326_add_has_issues_on_vulnerability_reads_trigger_spec.rb'
- 'spec/migrations/rename_services_to_integrations_spec.rb'
- 'spec/migrations/replace_external_wiki_triggers_spec.rb'
- 'spec/models/group_spec.rb'
- 'spec/models/integrations/assembla_spec.rb'
- 'spec/models/integrations/campfire_spec.rb'
@ -167,5 +163,4 @@ RSpec/InstanceVariable:
- 'spec/support/shared_examples/path_extraction_shared_examples.rb'
- 'spec/support/shared_examples/requests/api/notes_shared_examples.rb'
- 'spec/support_specs/helpers/stub_feature_flags_spec.rb'
- 'spec/views/search/_results.html.haml_spec.rb'
- 'spec/workers/emails_on_push_worker_spec.rb'

1
.rubocop_todo/rspec/missing_example_group_argument.yml
View File

@ -7,7 +7,6 @@ RSpec/MissingExampleGroupArgument:
- 'spec/controllers/projects/issues_controller_spec.rb'
- 'spec/controllers/projects/merge_requests_controller_spec.rb'
- 'spec/factories/projects/ci_feature_usages.rb'
- 'spec/lib/gitlab/background_migration/backfill_jira_tracker_deployment_type2_spec.rb'
- 'spec/lib/gitlab/git_access_spec.rb'
- 'spec/policies/award_emoji_policy_spec.rb'
- 'spec/requests/api/graphql/mutations/notes/create/diff_note_spec.rb'

65
.rubocop_todo/rspec/missing_feature_category.yml
View File

@ -463,12 +463,10 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/graphql/types/protected_environments/approval_rule_type_spec.rb'
- 'ee/spec/graphql/types/protected_environments/deploy_access_level_type_spec.rb'
- 'ee/spec/graphql/types/push_rules_type_spec.rb'
- 'ee/spec/graphql/types/query_type_spec.rb'
- 'ee/spec/graphql/types/requirements_management/requirement_state_enum_spec.rb'
- 'ee/spec/graphql/types/requirements_management/requirement_states_count_type_spec.rb'
- 'ee/spec/graphql/types/requirements_management/requirement_type_spec.rb'
- 'ee/spec/graphql/types/requirements_management/test_report_state_enum_spec.rb'
- 'ee/spec/graphql/types/requirements_management/test_report_type_spec.rb'
- 'ee/spec/graphql/types/scan_type_spec.rb'
- 'ee/spec/graphql/types/scanned_resource_type_spec.rb'
- 'ee/spec/graphql/types/security/training_type_spec.rb'
@ -604,7 +602,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/helpers/groups/ldap_sync_helper_spec.rb'
- 'ee/spec/helpers/groups/security_features_helper_spec.rb'
- 'ee/spec/helpers/groups/sso_helper_spec.rb'
- 'ee/spec/helpers/incident_management/escalation_policy_helper_spec.rb'
- 'ee/spec/helpers/incident_management/oncall_schedule_helper_spec.rb'
- 'ee/spec/helpers/kerberos_helper_spec.rb'
- 'ee/spec/helpers/license_helper_spec.rb'
@ -845,13 +842,11 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/lib/elastic/latest/commit_config_spec.rb'
- 'ee/spec/lib/elastic/latest/config_spec.rb'
- 'ee/spec/lib/elastic/latest/custom_language_analyzers_spec.rb'
- 'ee/spec/lib/elastic/latest/git_class_proxy_spec.rb'
- 'ee/spec/lib/elastic/latest/git_instance_proxy_spec.rb'
- 'ee/spec/lib/elastic/latest/issue_class_proxy_spec.rb'
- 'ee/spec/lib/elastic/latest/issue_config_spec.rb'
- 'ee/spec/lib/elastic/latest/merge_request_config_spec.rb'
- 'ee/spec/lib/elastic/latest/note_config_spec.rb'
- 'ee/spec/lib/elastic/latest/project_instance_proxy_spec.rb'
- 'ee/spec/lib/elastic/latest/project_wiki_class_proxy_spec.rb'
- 'ee/spec/lib/elastic/latest/project_wiki_instance_proxy_spec.rb'
- 'ee/spec/lib/elastic/latest/routing_spec.rb'
@ -1026,7 +1021,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_renamed_event_spec.rb'
- 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb'
- 'ee/spec/lib/gitlab/geo/log_cursor/events/reset_checksum_event_spec.rb'
- 'ee/spec/lib/gitlab/geo/log_cursor/lease_spec.rb'
- 'ee/spec/lib/gitlab/geo/log_helpers_spec.rb'
- 'ee/spec/lib/gitlab/geo/logger_spec.rb'
- 'ee/spec/lib/gitlab/geo/oauth/login_state_spec.rb'
@ -1192,7 +1186,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/mailers/ci_minutes_usage_mailer_spec.rb'
- 'ee/spec/mailers/credentials_inventory_mailer_spec.rb'
- 'ee/spec/mailers/devise_mailer_spec.rb'
- 'ee/spec/mailers/ee/emails/admin_notification_spec.rb'
- 'ee/spec/mailers/ee/emails/identity_verification_spec.rb'
- 'ee/spec/mailers/ee/emails/issues_spec.rb'
- 'ee/spec/mailers/ee/emails/merge_requests_spec.rb'
@ -1294,7 +1287,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/models/container_registry/event_spec.rb'
- 'ee/spec/models/container_repository_spec.rb'
- 'ee/spec/models/dast/branch_spec.rb'
- 'ee/spec/models/dast/pre_scan_verification_spec.rb'
- 'ee/spec/models/dast/profile_schedule_spec.rb'
- 'ee/spec/models/dast/profile_spec.rb'
- 'ee/spec/models/dast/profiles_pipeline_spec.rb'
@ -1310,7 +1302,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/models/dora/base_metric_spec.rb'
- 'ee/spec/models/dora/change_failure_rate_metric_spec.rb'
- 'ee/spec/models/dora/configuration_spec.rb'
- 'ee/spec/models/dora/daily_metrics_spec.rb'
- 'ee/spec/models/dora/deployment_frequency_metric_spec.rb'
- 'ee/spec/models/dora/lead_time_for_changes_metric_spec.rb'
- 'ee/spec/models/dora/time_to_restore_service_metric_spec.rb'
@ -1318,7 +1309,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/models/ee/analytics/usage_trends/measurement_spec.rb'
- 'ee/spec/models/ee/appearance_spec.rb'
- 'ee/spec/models/ee/approvable_spec.rb'
- 'ee/spec/models/ee/audit_event_spec.rb'
- 'ee/spec/models/ee/award_emoji_spec.rb'
- 'ee/spec/models/ee/ci/build_dependencies_spec.rb'
- 'ee/spec/models/ee/ci/job_artifact_spec.rb'
@ -1467,10 +1457,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/models/namespaces/storage/root_excess_size_spec.rb'
- 'ee/spec/models/namespaces/storage/root_size_spec.rb'
- 'ee/spec/models/note_spec.rb'
- 'ee/spec/models/package_metadata/license_spec.rb'
- 'ee/spec/models/package_metadata/package_spec.rb'
- 'ee/spec/models/package_metadata/package_version_license_spec.rb'
- 'ee/spec/models/package_metadata/package_version_spec.rb'
- 'ee/spec/models/packages/package_file_spec.rb'
- 'ee/spec/models/path_lock_spec.rb'
- 'ee/spec/models/plan_spec.rb'
@ -1497,17 +1483,14 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/models/requirements_management/requirement_spec.rb'
- 'ee/spec/models/saml_group_link_spec.rb'
- 'ee/spec/models/saml_provider_spec.rb'
- 'ee/spec/models/sca/license_compliance_spec.rb'
- 'ee/spec/models/sca/license_policy_spec.rb'
- 'ee/spec/models/scoped_label_set_spec.rb'
- 'ee/spec/models/security/orchestration_policy_configuration_spec.rb'
- 'ee/spec/models/security/orchestration_policy_rule_schedule_spec.rb'
- 'ee/spec/models/security/training_provider_spec.rb'
- 'ee/spec/models/security/training_spec.rb'
- 'ee/spec/models/snippet_repository_spec.rb'
- 'ee/spec/models/snippet_spec.rb'
- 'ee/spec/models/software_license_policy_spec.rb'
- 'ee/spec/models/software_license_spec.rb'
- 'ee/spec/models/status_page/project_setting_spec.rb'
- 'ee/spec/models/status_page/published_incident_spec.rb'
- 'ee/spec/models/storage_shard_spec.rb'
@ -1800,8 +1783,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/services/boards/user_preferences/update_service_spec.rb'
- 'ee/spec/services/branches/delete_service_spec.rb'
- 'ee/spec/services/ci/audit_variable_change_service_spec.rb'
- 'ee/spec/services/ci/compare_license_scanning_reports_collapsed_service_spec.rb'
- 'ee/spec/services/ci/compare_license_scanning_reports_service_spec.rb'
- 'ee/spec/services/ci/compare_metrics_reports_service_spec.rb'
- 'ee/spec/services/ci/compare_security_reports_service_spec.rb'
- 'ee/spec/services/ci/copy_cross_database_associations_service_spec.rb'
@ -1848,7 +1829,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/services/dashboard/projects/list_service_spec.rb'
- 'ee/spec/services/deploy_keys/create_service_spec.rb'
- 'ee/spec/services/deployments/auto_rollback_service_spec.rb'
- 'ee/spec/services/dora/aggregate_metrics_service_spec.rb'
- 'ee/spec/services/ee/admin/set_feature_flag_service_spec.rb'
- 'ee/spec/services/ee/alert_management/alerts/update_service_spec.rb'
- 'ee/spec/services/ee/alert_management/create_alert_issue_service_spec.rb'
@ -1894,7 +1874,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/services/ee/issuable/destroy_service_spec.rb'
- 'ee/spec/services/ee/issue_links/create_service_spec.rb'
- 'ee/spec/services/ee/issues/after_create_service_spec.rb'
- 'ee/spec/services/ee/issues/build_from_vulnerability_service_spec.rb'
- 'ee/spec/services/ee/issues/clone_service_spec.rb'
- 'ee/spec/services/ee/issues/move_service_spec.rb'
- 'ee/spec/services/ee/keys/destroy_service_spec.rb'
@ -2087,7 +2066,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/services/iterations/cadences/update_service_spec.rb'
- 'ee/spec/services/iterations/create_service_spec.rb'
- 'ee/spec/services/iterations/delete_service_spec.rb'
- 'ee/spec/services/iterations/roll_over_issues_service_spec.rb'
- 'ee/spec/services/iterations/update_service_spec.rb'
- 'ee/spec/services/jira/jql_builder_service_spec.rb'
- 'ee/spec/services/jira/requests/issues/list_service_spec.rb'
@ -2112,7 +2090,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/services/merge_requests/push_options_handler_service_spec.rb'
- 'ee/spec/services/merge_requests/reload_merge_head_diff_service_spec.rb'
- 'ee/spec/services/merge_requests/remove_approval_service_spec.rb'
- 'ee/spec/services/merge_requests/reset_approvals_service_spec.rb'
- 'ee/spec/services/merge_requests/stream_approval_audit_event_service_spec.rb'
- 'ee/spec/services/merge_requests/sync_code_owner_approval_rules_spec.rb'
- 'ee/spec/services/merge_requests/sync_report_approver_approval_rules_spec.rb'
@ -2175,12 +2152,10 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/services/quality_management/test_cases/create_service_spec.rb'
- 'ee/spec/services/releases/create_service_spec.rb'
- 'ee/spec/services/releases/update_service_spec.rb'
- 'ee/spec/services/requirements_management/map_export_fields_service_spec.rb'
- 'ee/spec/services/requirements_management/prepare_import_csv_service_spec.rb'
- 'ee/spec/services/requirements_management/process_test_reports_service_spec.rb'
- 'ee/spec/services/resource_access_tokens/create_service_spec.rb'
- 'ee/spec/services/resource_access_tokens/revoke_service_spec.rb'
- 'ee/spec/services/resource_events/change_weight_service_spec.rb'
- 'ee/spec/services/search/snippet_service_spec.rb'
- 'ee/spec/services/security/auto_fix_label_service_spec.rb'
- 'ee/spec/services/security/auto_fix_service_spec.rb'
@ -2193,7 +2168,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/services/security/ingestion/ingest_report_slice_service_spec.rb'
- 'ee/spec/services/security/ingestion/ingest_reports_service_spec.rb'
- 'ee/spec/services/security/ingestion/mark_as_resolved_service_spec.rb'
- 'ee/spec/services/security/ingestion/schedule_mark_dropped_as_resolved_service_spec.rb'
- 'ee/spec/services/security/ingestion/tasks/attach_findings_to_vulnerabilities_spec.rb'
- 'ee/spec/services/security/ingestion/tasks/hooks_execution_spec.rb'
- 'ee/spec/services/security/ingestion/tasks/ingest_finding_evidence_spec.rb'
@ -2260,8 +2234,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/services/todos/destroy/confidential_epic_service_spec.rb'
- 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb'
- 'ee/spec/services/user_permissions/export_service_spec.rb'
- 'ee/spec/services/users/abuse/git_abuse/application_throttle_service_spec.rb'
- 'ee/spec/services/users/abuse/git_abuse/namespace_throttle_service_spec.rb'
- 'ee/spec/services/users/abuse/namespace_bans/create_service_spec.rb'
- 'ee/spec/services/users/abuse/namespace_bans/destroy_service_spec.rb'
- 'ee/spec/services/users/abuse/projects_download_ban_check_service_spec.rb'
@ -2432,7 +2404,6 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/workers/elastic/project_transfer_worker_spec.rb'
- 'ee/spec/workers/elastic_association_indexer_worker_spec.rb'
- 'ee/spec/workers/elastic_cluster_reindexing_cron_worker_spec.rb'
- 'ee/spec/workers/elastic_commit_indexer_worker_spec.rb'
- 'ee/spec/workers/elastic_full_index_worker_spec.rb'
- 'ee/spec/workers/elastic_index_initial_bulk_cron_worker_spec.rb'
- 'ee/spec/workers/elastic_indexing_control_worker_spec.rb'
@ -2513,10 +2484,8 @@ RSpec/MissingFeatureCategory:
- 'ee/spec/workers/post_receive_spec.rb'
- 'ee/spec/workers/product_analytics/initialize_analytics_worker_spec.rb'
- 'ee/spec/workers/project_cache_worker_spec.rb'
- 'ee/spec/workers/project_import_schedule_worker_spec.rb'
- 'ee/spec/workers/project_template_export_worker_spec.rb'
- 'ee/spec/workers/projects/disable_legacy_open_source_license_for_inactive_projects_worker_spec.rb'
- 'ee/spec/workers/refresh_license_compliance_checks_worker_spec.rb'
- 'ee/spec/workers/repository_update_mirror_worker_spec.rb'
- 'ee/spec/workers/requirements_management/import_requirements_csv_worker_spec.rb'
- 'ee/spec/workers/requirements_management/process_requirements_reports_worker_spec.rb'
@ -2544,7 +2513,6 @@ RSpec/MissingFeatureCategory:
- 'spec/benchmarks/banzai_benchmark.rb'
- 'spec/bin/audit_event_type_spec.rb'
- 'spec/bin/diagnostic_reports_uploader_spec.rb'
- 'spec/bin/feature_flag_spec.rb'
- 'spec/bin/sidekiq_cluster_spec.rb'
- 'spec/channels/application_cable/connection_spec.rb'
- 'spec/channels/awareness_channel_spec.rb'
@ -2697,7 +2665,6 @@ RSpec/MissingFeatureCategory:
- 'spec/controllers/profiles/notifications_controller_spec.rb'
- 'spec/controllers/profiles/personal_access_tokens_controller_spec.rb'
- 'spec/controllers/profiles/preferences_controller_spec.rb'
- 'spec/controllers/profiles/two_factor_auths_controller_spec.rb'
- 'spec/controllers/profiles/webauthn_registrations_controller_spec.rb'
- 'spec/controllers/profiles_controller_spec.rb'
- 'spec/controllers/projects/alert_management_controller_spec.rb'
@ -2752,7 +2719,6 @@ RSpec/MissingFeatureCategory:
- 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb'
- 'spec/controllers/projects/milestones_controller_spec.rb'
- 'spec/controllers/projects/mirrors_controller_spec.rb'
- 'spec/controllers/projects/notes_controller_spec.rb'
- 'spec/controllers/projects/packages/infrastructure_registry_controller_spec.rb'
- 'spec/controllers/projects/packages/packages_controller_spec.rb'
- 'spec/controllers/projects/pages_controller_spec.rb'
@ -3474,7 +3440,6 @@ RSpec/MissingFeatureCategory:
- 'spec/graphql/types/projects/topic_type_spec.rb'
- 'spec/graphql/types/prometheus_alert_type_spec.rb'
- 'spec/graphql/types/query_complexity_type_spec.rb'
- 'spec/graphql/types/query_type_spec.rb'
- 'spec/graphql/types/range_input_type_spec.rb'
- 'spec/graphql/types/release_asset_link_input_type_spec.rb'
- 'spec/graphql/types/release_asset_link_type_spec.rb'
@ -3656,7 +3621,6 @@ RSpec/MissingFeatureCategory:
- 'spec/helpers/terms_helper_spec.rb'
- 'spec/helpers/time_helper_spec.rb'
- 'spec/helpers/time_zone_helper_spec.rb'
- 'spec/helpers/timeboxes_routing_helper_spec.rb'
- 'spec/helpers/todos_helper_spec.rb'
- 'spec/helpers/tooling/visual_review_helper_spec.rb'
- 'spec/helpers/tracking_helper_spec.rb'
@ -3666,7 +3630,6 @@ RSpec/MissingFeatureCategory:
- 'spec/helpers/users_helper_spec.rb'
- 'spec/helpers/version_check_helper_spec.rb'
- 'spec/helpers/visibility_level_helper_spec.rb'
- 'spec/helpers/web_hooks/web_hooks_helper_spec.rb'
- 'spec/helpers/web_ide_button_helper_spec.rb'
- 'spec/helpers/webpack_helper_spec.rb'
- 'spec/helpers/whats_new_helper_spec.rb'
@ -3832,7 +3795,6 @@ RSpec/MissingFeatureCategory:
- 'spec/lib/bitbucket_server/representation/pull_request_comment_spec.rb'
- 'spec/lib/bitbucket_server/representation/pull_request_spec.rb'
- 'spec/lib/bitbucket_server/representation/repo_spec.rb'
- 'spec/lib/bulk_imports/clients/graphql_spec.rb'
- 'spec/lib/bulk_imports/common/extractors/graphql_extractor_spec.rb'
- 'spec/lib/bulk_imports/common/extractors/json_extractor_spec.rb'
- 'spec/lib/bulk_imports/common/extractors/ndjson_extractor_spec.rb'
@ -3878,7 +3840,6 @@ RSpec/MissingFeatureCategory:
- 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb'
- 'spec/lib/bulk_imports/projects/pipelines/project_pipeline_spec.rb'
- 'spec/lib/bulk_imports/projects/pipelines/protected_branches_pipeline_spec.rb'
- 'spec/lib/bulk_imports/projects/pipelines/references_pipeline_spec.rb'
- 'spec/lib/bulk_imports/projects/pipelines/releases_pipeline_spec.rb'
- 'spec/lib/bulk_imports/projects/pipelines/repository_bundle_pipeline_spec.rb'
- 'spec/lib/bulk_imports/projects/pipelines/service_desk_setting_pipeline_spec.rb'
@ -4137,7 +4098,6 @@ RSpec/MissingFeatureCategory:
- 'spec/lib/gitlab/batch_worker_context_spec.rb'
- 'spec/lib/gitlab/bitbucket_import/project_creator_spec.rb'
- 'spec/lib/gitlab/bitbucket_import/wiki_formatter_spec.rb'
- 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb'
- 'spec/lib/gitlab/blame_spec.rb'
- 'spec/lib/gitlab/blob_helper_spec.rb'
- 'spec/lib/gitlab/branch_push_merge_commit_analyzer_spec.rb'
@ -4219,7 +4179,6 @@ RSpec/MissingFeatureCategory:
- 'spec/lib/gitlab/ci/build/releaser_spec.rb'
- 'spec/lib/gitlab/ci/build/rules/rule/clause/changes_spec.rb'
- 'spec/lib/gitlab/ci/build/rules/rule/clause/exists_spec.rb'
- 'spec/lib/gitlab/ci/build/rules/rule/clause/if_spec.rb'
- 'spec/lib/gitlab/ci/build/rules/rule/clause_spec.rb'
- 'spec/lib/gitlab/ci/build/rules/rule_spec.rb'
- 'spec/lib/gitlab/ci/build/rules_spec.rb'
@ -4281,8 +4240,6 @@ RSpec/MissingFeatureCategory:
- 'spec/lib/gitlab/ci/config/entry/workflow_spec.rb'
- 'spec/lib/gitlab/ci/config/extendable/entry_spec.rb'
- 'spec/lib/gitlab/ci/config/extendable_spec.rb'
- 'spec/lib/gitlab/ci/config/external/context_spec.rb'
- 'spec/lib/gitlab/ci/config/external/rules_spec.rb'
- 'spec/lib/gitlab/ci/config/normalizer/factory_spec.rb'
- 'spec/lib/gitlab/ci/config/normalizer/matrix_strategy_spec.rb'
- 'spec/lib/gitlab/ci/config/normalizer/number_strategy_spec.rb'
@ -4331,9 +4288,7 @@ RSpec/MissingFeatureCategory:
- 'spec/lib/gitlab/ci/pipeline/duration_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/expression/lexeme/and_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/expression/lexeme/equals_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/expression/lexeme/matches_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/expression/lexeme/not_equals_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/expression/lexeme/not_matches_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/expression/lexeme/null_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/expression/lexeme/or_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/expression/lexeme/pattern_spec.rb'
@ -4391,7 +4346,6 @@ RSpec/MissingFeatureCategory:
- 'spec/lib/gitlab/ci/secure_files/mobile_provision_spec.rb'
- 'spec/lib/gitlab/ci/secure_files/p12_spec.rb'
- 'spec/lib/gitlab/ci/secure_files/x509_name_spec.rb'
- 'spec/lib/gitlab/ci/status/bridge/common_spec.rb'
- 'spec/lib/gitlab/ci/status/bridge/waiting_for_resource_spec.rb'
- 'spec/lib/gitlab/ci/status/build/action_spec.rb'
- 'spec/lib/gitlab/ci/status/build/cancelable_spec.rb'
@ -4598,7 +4552,6 @@ RSpec/MissingFeatureCategory:
- 'spec/lib/gitlab/database/migrations/runner_spec.rb'
- 'spec/lib/gitlab/database/migrations/sidekiq_helpers_spec.rb'
- 'spec/lib/gitlab/database/migrations/test_background_runner_spec.rb'
- 'spec/lib/gitlab/database/migrations/test_batched_background_runner_spec.rb'
- 'spec/lib/gitlab/database/migrations/timeout_helpers_spec.rb'
- 'spec/lib/gitlab/database/no_cross_db_foreign_keys_spec.rb'
- 'spec/lib/gitlab/database/obsolete_ignored_columns_spec.rb'
@ -4856,7 +4809,6 @@ RSpec/MissingFeatureCategory:
- 'spec/lib/gitlab/gitaly_client/diff_stitcher_spec.rb'
- 'spec/lib/gitlab/gitaly_client/health_check_service_spec.rb'
- 'spec/lib/gitlab/gitaly_client/object_pool_service_spec.rb'
- 'spec/lib/gitlab/gitaly_client/operation_service_spec.rb'
- 'spec/lib/gitlab/gitaly_client/praefect_info_service_spec.rb'
- 'spec/lib/gitlab/gitaly_client/remote_service_spec.rb'
- 'spec/lib/gitlab/gitaly_client/repository_service_spec.rb'
@ -5252,7 +5204,6 @@ RSpec/MissingFeatureCategory:
- 'spec/lib/gitlab/metrics/methods_spec.rb'
- 'spec/lib/gitlab/metrics/prometheus_spec.rb'
- 'spec/lib/gitlab/metrics/rack_middleware_spec.rb'
- 'spec/lib/gitlab/metrics/rails_slis_spec.rb'
- 'spec/lib/gitlab/metrics/samplers/action_cable_sampler_spec.rb'
- 'spec/lib/gitlab/metrics/samplers/database_sampler_spec.rb'
- 'spec/lib/gitlab/metrics/samplers/puma_sampler_spec.rb'
@ -5298,7 +5249,6 @@ RSpec/MissingFeatureCategory:
- 'spec/lib/gitlab/null_request_store_spec.rb'
- 'spec/lib/gitlab/object_hierarchy_spec.rb'
- 'spec/lib/gitlab/observability_spec.rb'
- 'spec/lib/gitlab/octokit/middleware_spec.rb'
- 'spec/lib/gitlab/omniauth_initializer_spec.rb'
- 'spec/lib/gitlab/optimistic_locking_spec.rb'
- 'spec/lib/gitlab/other_markup_spec.rb'
@ -5867,7 +5817,6 @@ RSpec/MissingFeatureCategory:
- 'spec/models/appearance_spec.rb'
- 'spec/models/application_record_spec.rb'
- 'spec/models/application_setting/term_spec.rb'
- 'spec/models/approval_spec.rb'
- 'spec/models/atlassian/identity_spec.rb'
- 'spec/models/audit_event_spec.rb'
- 'spec/models/authentication_event_spec.rb'
@ -5923,7 +5872,6 @@ RSpec/MissingFeatureCategory:
- 'spec/models/ci/group_spec.rb'
- 'spec/models/ci/group_variable_spec.rb'
- 'spec/models/ci/instance_variable_spec.rb'
- 'spec/models/ci/job_artifact_spec.rb'
- 'spec/models/ci/namespace_mirror_spec.rb'
- 'spec/models/ci/pending_build_spec.rb'
- 'spec/models/ci/persistent_ref_spec.rb'
@ -5942,7 +5890,6 @@ RSpec/MissingFeatureCategory:
- 'spec/models/ci/secure_file_spec.rb'
- 'spec/models/ci/stage_spec.rb'
- 'spec/models/ci/trigger_request_spec.rb'
- 'spec/models/ci/trigger_spec.rb'
- 'spec/models/ci/unit_test_failure_spec.rb'
- 'spec/models/ci/unit_test_spec.rb'
- 'spec/models/ci/variable_spec.rb'
@ -6071,7 +6018,6 @@ RSpec/MissingFeatureCategory:
- 'spec/models/concerns/subquery_spec.rb'
- 'spec/models/concerns/subscribable_spec.rb'
- 'spec/models/concerns/taggable_queries_spec.rb'
- 'spec/models/concerns/taskable_spec.rb'
- 'spec/models/concerns/token_authenticatable_spec.rb'
- 'spec/models/concerns/token_authenticatable_strategies/base_spec.rb'
- 'spec/models/concerns/token_authenticatable_strategies/digest_spec.rb'
@ -6321,7 +6267,6 @@ RSpec/MissingFeatureCategory:
- 'spec/models/packages/rpm/metadatum_spec.rb'
- 'spec/models/packages/rubygems/metadatum_spec.rb'
- 'spec/models/packages/sem_ver_spec.rb'
- 'spec/models/packages/tag_spec.rb'
- 'spec/models/pages/virtual_domain_spec.rb'
- 'spec/models/pages_domain_acme_order_spec.rb'
- 'spec/models/pages_domain_spec.rb'
@ -6354,7 +6299,6 @@ RSpec/MissingFeatureCategory:
- 'spec/models/project_custom_attribute_spec.rb'
- 'spec/models/project_daily_statistic_spec.rb'
- 'spec/models/project_deploy_token_spec.rb'
- 'spec/models/project_feature_spec.rb'
- 'spec/models/project_feature_usage_spec.rb'
- 'spec/models/project_group_link_spec.rb'
- 'spec/models/project_import_data_spec.rb'
@ -6746,7 +6690,6 @@ RSpec/MissingFeatureCategory:
- 'spec/rubocop/cop/safe_params_spec.rb'
- 'spec/rubocop/cop/scalability/bulk_perform_with_context_spec.rb'
- 'spec/rubocop/cop/scalability/cron_worker_context_spec.rb'
- 'spec/rubocop/cop/scalability/file_uploads_spec.rb'
- 'spec/rubocop/cop/scalability/idempotent_worker_spec.rb'
- 'spec/rubocop/cop/sidekiq_api_usage_spec.rb'
- 'spec/rubocop/cop/sidekiq_load_balancing/worker_data_consistency_spec.rb'
@ -7025,7 +6968,6 @@ RSpec/MissingFeatureCategory:
- 'spec/services/chat_names/find_user_service_spec.rb'
- 'spec/services/ci/abort_pipelines_service_spec.rb'
- 'spec/services/ci/append_build_trace_service_spec.rb'
- 'spec/services/ci/archive_trace_service_spec.rb'
- 'spec/services/ci/build_cancel_service_spec.rb'
- 'spec/services/ci/build_erase_service_spec.rb'
- 'spec/services/ci/build_report_result_service_spec.rb'
@ -7223,7 +7165,6 @@ RSpec/MissingFeatureCategory:
- 'spec/services/gravatar_service_spec.rb'
- 'spec/services/groups/auto_devops_service_spec.rb'
- 'spec/services/groups/autocomplete_service_spec.rb'
- 'spec/services/groups/create_service_spec.rb'
- 'spec/services/groups/deploy_tokens/create_service_spec.rb'
- 'spec/services/groups/deploy_tokens/destroy_service_spec.rb'
- 'spec/services/groups/deploy_tokens/revoke_service_spec.rb'
@ -7372,7 +7313,6 @@ RSpec/MissingFeatureCategory:
- 'spec/services/merge_requests/rebase_service_spec.rb'
- 'spec/services/merge_requests/reload_diffs_service_spec.rb'
- 'spec/services/merge_requests/reload_merge_head_diff_service_spec.rb'
- 'spec/services/merge_requests/remove_approval_service_spec.rb'
- 'spec/services/merge_requests/reopen_service_spec.rb'
- 'spec/services/merge_requests/request_review_service_spec.rb'
- 'spec/services/merge_requests/resolve_todos_service_spec.rb'
@ -7534,7 +7474,6 @@ RSpec/MissingFeatureCategory:
- 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb'
- 'spec/services/projects/hashed_storage/rollback_service_spec.rb'
- 'spec/services/projects/import_error_filter_spec.rb'
- 'spec/services/projects/import_export/export_service_spec.rb'
- 'spec/services/projects/import_export/relation_export_service_spec.rb'
- 'spec/services/projects/in_product_marketing_campaign_emails_service_spec.rb'
- 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb'
@ -7583,16 +7522,13 @@ RSpec/MissingFeatureCategory:
- 'spec/services/push_event_payload_service_spec.rb'
- 'spec/services/quick_actions/target_service_spec.rb'
- 'spec/services/releases/create_evidence_service_spec.rb'
- 'spec/services/releases/create_service_spec.rb'
- 'spec/services/releases/destroy_service_spec.rb'
- 'spec/services/releases/update_service_spec.rb'
- 'spec/services/repositories/changelog_service_spec.rb'
- 'spec/services/repositories/destroy_service_spec.rb'
- 'spec/services/repository_archive_clean_up_service_spec.rb'
- 'spec/services/reset_project_cache_service_spec.rb'
- 'spec/services/resource_access_tokens/create_service_spec.rb'
- 'spec/services/resource_access_tokens/revoke_service_spec.rb'
- 'spec/services/resource_events/change_labels_service_spec.rb'
- 'spec/services/resource_events/change_milestone_service_spec.rb'
- 'spec/services/resource_events/change_state_service_spec.rb'
- 'spec/services/resource_events/merge_into_notes_service_spec.rb'
@ -8026,7 +7962,6 @@ RSpec/MissingFeatureCategory:
- 'spec/workers/bulk_imports/stuck_import_worker_spec.rb'
- 'spec/workers/chat_notification_worker_spec.rb'
- 'spec/workers/ci/archive_trace_worker_spec.rb'
- 'spec/workers/ci/archive_traces_cron_worker_spec.rb'
- 'spec/workers/ci/build_finished_worker_spec.rb'
- 'spec/workers/ci/build_prepare_worker_spec.rb'
- 'spec/workers/ci/build_schedule_worker_spec.rb'

2
.rubocop_todo/rspec/repeated_example_group_body.yml
View File

@ -8,7 +8,6 @@ RSpec/RepeatedExampleGroupBody:
- 'ee/spec/models/ee/project_spec.rb'
- 'ee/spec/models/geo/deleted_project_spec.rb'
- 'ee/spec/models/gitlab_subscriptions/upcoming_reconciliation_spec.rb'
- 'ee/spec/models/merge_requests/external_status_check_spec.rb'
- 'ee/spec/models/software_license_spec.rb'
- 'ee/spec/policies/app_sec/fuzzing/coverage/corpus_policy_spec.rb'
- 'ee/spec/policies/group_policy_spec.rb'
@ -38,7 +37,6 @@ RSpec/RepeatedExampleGroupBody:
- 'spec/lib/gitlab/empty_search_results_spec.rb'
- 'spec/lib/gitlab/import_export/project/sample/relation_factory_spec.rb'
- 'spec/lib/gitlab/lfs/client_spec.rb'
- 'spec/lib/gitlab/pagination/keyset/simple_order_builder_spec.rb'
- 'spec/lib/gitlab/sanitizers/exif_spec.rb'
- 'spec/models/ci/build_spec.rb'
- 'spec/models/deploy_token_spec.rb'

2
.rubocop_todo/rspec/repeated_example_group_description.yml
View File

@ -9,7 +9,6 @@ RSpec/RepeatedExampleGroupDescription:
- 'ee/spec/models/approval_merge_request_rule_spec.rb'
- 'ee/spec/models/ci/build_spec.rb'
- 'ee/spec/models/dast/profile_spec.rb'
- 'ee/spec/models/ee/namespace_spec.rb'
- 'ee/spec/models/ee/project_spec.rb'
- 'ee/spec/models/geo/deleted_project_spec.rb'
- 'ee/spec/models/geo_node_spec.rb'
@ -42,7 +41,6 @@ RSpec/RepeatedExampleGroupDescription:
- 'spec/helpers/admin/user_actions_helper_spec.rb'
- 'spec/helpers/dropdowns_helper_spec.rb'
- 'spec/helpers/gitlab_routing_helper_spec.rb'
- 'spec/helpers/namespaces_helper_spec.rb'
- 'spec/lib/banzai/pipeline/gfm_pipeline_spec.rb'
- 'spec/lib/gitlab/alert_management/payload/base_spec.rb'
- 'spec/lib/gitlab/auth/atlassian/auth_hash_spec.rb'

5
.rubocop_todo/rspec/return_from_stub.yml
View File

@ -27,7 +27,6 @@ RSpec/ReturnFromStub:
- 'ee/spec/lib/system_check/geo/http_connection_check_spec.rb'
- 'ee/spec/models/ci/build_spec.rb'
- 'ee/spec/models/concerns/ee/project_security_scanners_information_spec.rb'
- 'ee/spec/models/ee/namespace_spec.rb'
- 'ee/spec/models/ee/project_spec.rb'
- 'ee/spec/models/ee/user_spec.rb'
- 'ee/spec/models/license_spec.rb'
@ -138,8 +137,6 @@ RSpec/ReturnFromStub:
- 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb'
- 'spec/lib/gitlab/bitbucket_import/importer_spec.rb'
- 'spec/lib/gitlab/ci/build/policy/changes_spec.rb'
- 'spec/lib/gitlab/ci/config/external/mapper_spec.rb'
- 'spec/lib/gitlab/ci/config/external/processor_spec.rb'
- 'spec/lib/gitlab/ci/pipeline/seed/stage_spec.rb'
- 'spec/lib/gitlab/ci/status/build/failed_spec.rb'
- 'spec/lib/gitlab/ci/trace/remote_checksum_spec.rb'
@ -167,7 +164,6 @@ RSpec/ReturnFromStub:
- 'spec/lib/gitlab/middleware/read_only_spec.rb'
- 'spec/lib/gitlab/prometheus_client_spec.rb'
- 'spec/lib/gitlab/redis/cache_spec.rb'
- 'spec/lib/gitlab/redis/duplicate_jobs_spec.rb'
- 'spec/lib/gitlab/redis/shared_state_spec.rb'
- 'spec/lib/gitlab/redis/sidekiq_status_spec.rb'
- 'spec/lib/gitlab/relative_positioning/range_spec.rb'
@ -254,7 +250,6 @@ RSpec/ReturnFromStub:
- 'spec/services/verify_pages_domain_service_spec.rb'
- 'spec/support/redis/redis_shared_examples.rb'
- 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb'
- 'spec/support/shared_examples/features/container_registry_shared_examples.rb'
- 'spec/support/shared_examples/finders/snippet_visibility_shared_examples.rb'
- 'spec/support/shared_examples/lib/gitlab/middleware/read_only_gitlab_instance_shared_examples.rb'
- 'spec/support/shared_examples/lib/gitlab/sidekiq_middleware/strategy_shared_examples.rb'

8
.rubocop_todo/rspec/scattered_let.yml
View File

@ -11,8 +11,6 @@ RSpec/ScatteredLet:
- 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb'
- 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb'
- 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb'
- 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb'
- 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb'
- 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb'
- 'ee/spec/lib/gitlab/code_owners/loader_spec.rb'
- 'ee/spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb'
@ -50,7 +48,6 @@ RSpec/ScatteredLet:
- 'ee/spec/requests/api/group_boards_spec.rb'
- 'ee/spec/requests/api/project_push_rule_spec.rb'
- 'ee/spec/requests/api/settings_spec.rb'
- 'ee/spec/requests/api/vulnerability_findings_spec.rb'
- 'ee/spec/services/analytics/devops_adoption/snapshots/calculate_and_save_service_spec.rb'
- 'ee/spec/services/app_sec/dast/scan_configs/fetch_service_spec.rb'
- 'ee/spec/services/arkose/blocked_users_report_service_spec.rb'
@ -101,7 +98,6 @@ RSpec/ScatteredLet:
- 'spec/graphql/types/base_object_spec.rb'
- 'spec/graphql/types/ci/job_token_scope_type_spec.rb'
- 'spec/graphql/types/environment_type_spec.rb'
- 'spec/graphql/types/merge_request_type_spec.rb'
- 'spec/graphql/types/project_type_spec.rb'
- 'spec/graphql/types/terraform/state_version_type_spec.rb'
- 'spec/graphql/types/user_type_spec.rb'
@ -170,7 +166,6 @@ RSpec/ScatteredLet:
- 'spec/lib/gitlab/patch/database_config_spec.rb'
- 'spec/lib/gitlab/path_regex_spec.rb'
- 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb'
- 'spec/lib/gitlab/redis/multi_store_spec.rb'
- 'spec/lib/gitlab/relative_positioning/item_context_spec.rb'
- 'spec/lib/gitlab/relative_positioning/mover_spec.rb'
- 'spec/lib/gitlab/serializer/pagination_spec.rb'
@ -199,9 +194,7 @@ RSpec/ScatteredLet:
- 'spec/models/integration_spec.rb'
- 'spec/models/merge_request_spec.rb'
- 'spec/models/push_event_spec.rb'
- 'spec/models/snippet_repository_spec.rb'
- 'spec/models/ssh_host_key_spec.rb'
- 'spec/models/user_spec.rb'
- 'spec/models/users/credit_card_validation_spec.rb'
- 'spec/models/wiki_page_spec.rb'
- 'spec/policies/group_member_policy_spec.rb'
@ -232,7 +225,6 @@ RSpec/ScatteredLet:
- 'spec/requests/api/project_clusters_spec.rb'
- 'spec/requests/jira_routing_spec.rb'
- 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb'
- 'spec/scripts/pipeline_test_report_builder_spec.rb'
- 'spec/serializers/build_details_entity_spec.rb'
- 'spec/serializers/ci/job_entity_spec.rb'
- 'spec/serializers/merge_requests/pipeline_entity_spec.rb'

10
.rubocop_todo/rspec/verified_doubles.yml
View File

@ -97,9 +97,7 @@ RSpec/VerifiedDoubles:
- 'ee/spec/requests/api/geo_spec.rb'
- 'ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb'
- 'ee/spec/requests/api/internal/base_spec.rb'
- 'ee/spec/requests/api/ldap_spec.rb'
- 'ee/spec/requests/api/visual_review_discussions_spec.rb'
- 'ee/spec/requests/api/vulnerability_findings_spec.rb'
- 'ee/spec/requests/callout_spec.rb'
- 'ee/spec/requests/rack_attack_spec.rb'
- 'ee/spec/serializers/blocking_merge_request_entity_spec.rb'
@ -220,11 +218,9 @@ RSpec/VerifiedDoubles:
- 'qa/spec/page/view_spec.rb'
- 'qa/spec/resource/api_fabricator_spec.rb'
- 'qa/spec/resource/base_spec.rb'
- 'qa/spec/runtime/application_settings_spec.rb'
- 'qa/spec/runtime/feature_spec.rb'
- 'qa/spec/runtime/release_spec.rb'
- 'qa/spec/scenario/test/sanity/selectors_spec.rb'
- 'qa/spec/support/formatters/allure_metadata_formatter_spec.rb'
- 'qa/spec/support/page_error_checker_spec.rb'
- 'qa/spec/support/run_spec.rb'
- 'qa/spec/tools/long_running_spec_reporter_spec.rb'
@ -290,7 +286,6 @@ RSpec/VerifiedDoubles:
- 'spec/graphql/mutations/alert_management/update_alert_status_spec.rb'
- 'spec/graphql/mutations/branches/create_spec.rb'
- 'spec/graphql/mutations/ci/job_token_scope/add_project_spec.rb'
- 'spec/graphql/mutations/ci/job_token_scope/remove_project_spec.rb'
- 'spec/graphql/mutations/design_management/upload_spec.rb'
- 'spec/graphql/mutations/environments/canary_ingress/update_spec.rb'
- 'spec/graphql/resolvers/kas/agent_connections_resolver_spec.rb'
@ -477,7 +472,6 @@ RSpec/VerifiedDoubles:
- 'spec/lib/gitlab/config/entry/validator_spec.rb'
- 'spec/lib/gitlab/conflict/file_spec.rb'
- 'spec/lib/gitlab/cross_project_access/check_collection_spec.rb'
- 'spec/lib/gitlab/database/async_indexes_spec.rb'
- 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb'
- 'spec/lib/gitlab/database/batch_count_spec.rb'
- 'spec/lib/gitlab/database/count_spec.rb'
@ -633,8 +627,8 @@ RSpec/VerifiedDoubles:
- 'spec/lib/gitlab/mail_room/mail_room_spec.rb'
- 'spec/lib/gitlab/manifest_import/metadata_spec.rb'
- 'spec/lib/gitlab/markdown_cache/field_data_spec.rb'
- 'spec/lib/gitlab/merge_requests/message_generator_spec.rb'
- 'spec/lib/gitlab/merge_requests/mergeability/redis_interface_spec.rb'
- 'spec/lib/gitlab/merge_requests/message_generator_spec.rb'
- 'spec/lib/gitlab/metrics/boot_time_tracker_spec.rb'
- 'spec/lib/gitlab/metrics/dashboard/importers/prometheus_metrics_spec.rb'
- 'spec/lib/gitlab/metrics/elasticsearch_rack_middleware_spec.rb'
@ -801,7 +795,6 @@ RSpec/VerifiedDoubles:
- 'spec/presenters/project_member_presenter_spec.rb'
- 'spec/presenters/project_presenter_spec.rb'
- 'spec/requests/api/avatar_spec.rb'
- 'spec/requests/api/container_registry_event_spec.rb'
- 'spec/requests/api/graphql/mutations/design_management/delete_spec.rb'
- 'spec/requests/api/graphql/mutations/snippets/create_spec.rb'
- 'spec/requests/api/graphql/project/cluster_agents_spec.rb'
@ -1062,5 +1055,4 @@ RSpec/VerifiedDoubles:
- 'spec/workers/propagate_integration_inherit_worker_spec.rb'
- 'spec/workers/propagate_integration_project_worker_spec.rb'
- 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb'
- 'spec/workers/repository_import_worker_spec.rb'
- 'spec/workers/system_hook_push_worker_spec.rb'

1
.rubocop_todo/security/io_methods.yml
View File

@ -2,4 +2,3 @@
# Cop supports --autocorrect.
Security/IoMethods:
Details: grace period
Exclude:

1
.rubocop_todo/style/accessor_grouping.yml
View File

@ -56,7 +56,6 @@ Style/AccessorGrouping:
- 'lib/gitlab/graphql/connection_redaction.rb'
- 'lib/gitlab/http_io.rb'
- 'lib/gitlab/import_export/project/tree_restorer.rb'
- 'lib/gitlab/sidekiq_daemon/monitor.rb'
- 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb'
- 'lib/gitlab/suggestions/file_suggestion.rb'
- 'lib/gitlab/tracking/event_definition.rb'

1
.rubocop_todo/style/class_and_module_children.yml
View File

@ -250,7 +250,6 @@ Style/ClassAndModuleChildren:
- 'app/helpers/projects/project_members_helper.rb'
- 'app/helpers/projects/terraform_helper.rb'
- 'app/models/analytics/cycle_analytics/aggregation.rb'
- 'app/models/analytics/cycle_analytics/project_value_stream.rb'
- 'app/models/bulk_imports/configuration.rb'
- 'app/models/bulk_imports/entity.rb'
- 'app/models/bulk_imports/failure.rb'

1
.rubocop_todo/style/empty_else.yml
View File

@ -35,7 +35,6 @@ Style/EmptyElse:
- 'ee/app/services/epics/tree_reorder_service.rb'
- 'ee/app/services/gitlab_subscriptions/check_future_renewal_service.rb'
- 'ee/app/services/projects/update_mirror_service.rb'
- 'ee/app/workers/gitlab_subscriptions/notify_seats_exceeded_worker.rb'
- 'ee/lib/elastic/latest/note_instance_proxy.rb'
- 'ee/lib/gitlab/analytics/cycle_analytics/summary/change_failure_rate.rb'
- 'ee/lib/gitlab/geo/oauth/logout_token.rb'

8
.rubocop_todo/style/empty_method.yml
View File

@ -71,11 +71,7 @@ Style/EmptyMethod:
- 'app/services/issuable_base_service.rb'
- 'app/services/projects/transfer_service.rb'
- 'app/workers/namespaces/root_statistics_worker.rb'
- 'db/migrate/20210729123101_confirm_security_bot.rb'
- 'db/migrate/20211012134316_clean_up_migrate_merge_request_diff_commit_users.rb'
- 'db/post_migrate/20210730170823_schedule_security_setting_creation.rb'
- 'db/post_migrate/20210823132600_remove_duplicate_dast_site_tokens.rb'
- 'db/post_migrate/20210826171758_initialize_throttle_unauthenticated_api_columns.rb'
- 'db/post_migrate/20211028100843_delete_issue_merge_request_taggings_records.rb'
- 'db/post_migrate/20220324032250_migrate_shimo_confluence_service_category.rb'
- 'db/post_migrate/20220412143552_consume_remaining_encrypt_integration_property_jobs.rb'
@ -105,13 +101,10 @@ Style/EmptyMethod:
- 'ee/app/controllers/projects/security/dast_site_profiles_controller.rb'
- 'ee/app/controllers/projects/security/sast_configuration_controller.rb'
- 'ee/app/controllers/projects/settings/slacks_controller.rb'
- 'ee/app/controllers/registrations/company_controller.rb'
- 'ee/app/controllers/subscriptions/groups_controller.rb'
- 'ee/app/controllers/trials_controller.rb'
- 'ee/app/controllers/users/identity_verification_controller.rb'
- 'ee/app/experiments/cart_abandonment_modal_experiment.rb'
- 'ee/app/models/ee/epic.rb'
- 'ee/app/models/geo/group_wiki_repository_registry.rb'
- 'ee/app/services/feature_flag_issues/destroy_service.rb'
- 'ee/db/geo/migrate/20170906174622_remove_duplicates_from_project_registry.rb'
- 'lib/api/helpers/packages/conan/api_helpers.rb'
@ -119,7 +112,6 @@ Style/EmptyMethod:
- 'lib/api/projects_relation_builder.rb'
- 'lib/backup/task.rb'
- 'lib/banzai/filter/inline_embeds_filter.rb'
- 'lib/feature.rb'
- 'lib/gitlab/alert_management/payload/base.rb'
- 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb'
- 'lib/gitlab/background_migration/create_security_setting.rb'

3
.rubocop_todo/style/explicit_block_argument.yml
View File

@ -65,7 +65,6 @@ Style/ExplicitBlockArgument:
- 'lib/gitlab/redis/wrapper.rb'
- 'lib/gitlab/reference_counter.rb'
- 'lib/gitlab/seeder.rb'
- 'lib/gitlab/sidekiq_middleware/duplicate_jobs/duplicate_job.rb'
- 'lib/gitlab/sidekiq_middleware/monitor.rb'
- 'lib/gitlab/sidekiq_middleware/query_analyzer.rb'
- 'lib/gitlab/sidekiq_middleware/request_store_middleware.rb'
@ -81,10 +80,8 @@ Style/ExplicitBlockArgument:
- 'qa/qa/runtime/api/repository_storage_moves.rb'
- 'qa/qa/runtime/search.rb'
- 'rubocop/code_reuse_helpers.rb'
- 'spec/features/merge_request/user_sees_wip_help_message_spec.rb'
- 'spec/features/projects/features_visibility_spec.rb'
- 'spec/lib/banzai/filter/repository_link_filter_spec.rb'
- 'spec/lib/gitlab/ci/config/external/file/project_spec.rb'
- 'spec/lib/gitlab/database/query_analyzers/restrict_allowed_schemas_spec.rb'
- 'spec/lib/gitlab/pagination/offset_pagination_spec.rb'
- 'spec/lib/gitlab/usage_data_spec.rb'

1
.rubocop_todo/style/float_division.yml
View File

@ -4,4 +4,3 @@ Style/FloatDivision:
Exclude:
- 'ee/app/models/geo_node_status.rb'
- 'ee/app/models/namespaces/storage/root_size.rb'
- 'qa/qa/tools/reliable_report.rb'

5
.rubocop_todo/style/format_string.yml
View File

@ -113,7 +113,6 @@ Style/FormatString:
- 'app/models/user.rb'
- 'app/models/wiki.rb'
- 'app/models/wiki_page.rb'
- 'app/models/work_items/parent_link.rb'
- 'app/presenters/ci/pipeline_presenter.rb'
- 'app/presenters/key_presenter.rb'
- 'app/presenters/merge_request_presenter.rb'
@ -186,7 +185,6 @@ Style/FormatString:
- 'ee/app/helpers/ee/profiles_helper.rb'
- 'ee/app/helpers/ee/projects_helper.rb'
- 'ee/app/helpers/ee/timeboxes_helper.rb'
- 'ee/app/helpers/ee/users/callouts_helper.rb'
- 'ee/app/helpers/groups/sso_helper.rb'
- 'ee/app/helpers/trial_registrations/reassurances_helper.rb'
- 'ee/app/helpers/vulnerabilities_helper.rb'
@ -214,7 +212,6 @@ Style/FormatString:
- 'ee/app/services/ee/projects/create_from_template_service.rb'
- 'ee/app/services/group_saml/saml_group_links/create_service.rb'
- 'ee/app/services/incident_management/escalation_policies/base_service.rb'
- 'ee/app/services/issues/build_from_vulnerability_service.rb'
- 'ee/app/services/merge_requests/create_from_vulnerability_data_service.rb'
- 'ee/app/services/security/security_orchestration_policies/policy_configuration_validation_service.rb'
- 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb'
@ -286,7 +283,6 @@ Style/FormatString:
- 'lib/gitlab/github_import/object_counter.rb'
- 'lib/gitlab/github_import/page_counter.rb'
- 'lib/gitlab/github_import/parallel_scheduling.rb'
- 'lib/gitlab/github_import/representation/diff_note.rb'
- 'lib/gitlab/import_export/base/relation_factory.rb'
- 'lib/gitlab/import_export/error.rb'
- 'lib/gitlab/import_export/snippet_repo_restorer.rb'
@ -331,7 +327,6 @@ Style/FormatString:
- 'spec/support/shared_examples/services/jira/requests/base_shared_examples.rb'
- 'spec/support/shared_examples/views/registration_features_prompt_shared_examples.rb'
- 'spec/validators/any_field_validator_spec.rb'
- 'spec/views/errors/omniauth_error.html.haml_spec.rb'
- 'spec/views/groups/edit.html.haml_spec.rb'
- 'spec/views/profiles/keys/_form.html.haml_spec.rb'
- 'spec/views/profiles/notifications/show.html.haml_spec.rb'

36
.rubocop_todo/style/guard_clause.yml
View File

@ -8,15 +8,12 @@ Style/GuardClause:
- 'app/controllers/clusters/clusters_controller.rb'
- 'app/controllers/concerns/accepts_pending_invitations.rb'
- 'app/controllers/concerns/authenticates_with_two_factor.rb'
- 'app/controllers/concerns/controller_with_cross_project_access_check.rb'
- 'app/controllers/concerns/creates_commit.rb'
- 'app/controllers/concerns/cycle_analytics_params.rb'
- 'app/controllers/concerns/enforces_admin_authentication.rb'
- 'app/controllers/concerns/enforces_two_factor_authentication.rb'
- 'app/controllers/concerns/impersonation.rb'
- 'app/controllers/concerns/issuable_actions.rb'
- 'app/controllers/concerns/issuable_collections.rb'
- 'app/controllers/concerns/oauth_applications.rb'
- 'app/controllers/groups/application_controller.rb'
- 'app/controllers/groups_controller.rb'
- 'app/controllers/import/gitea_controller.rb'
@ -52,7 +49,6 @@ Style/GuardClause:
- 'app/finders/deployments_finder.rb'
- 'app/finders/group_members_finder.rb'
- 'app/finders/snippets_finder.rb'
- 'app/graphql/mutations/concerns/mutations/spam_protection.rb'
- 'app/graphql/mutations/design_management/delete.rb'
- 'app/graphql/mutations/notes/create/note.rb'
- 'app/graphql/mutations/notes/reposition_image_diff_note.rb'
@ -65,7 +61,6 @@ Style/GuardClause:
- 'app/graphql/types/ci/job_type.rb'
- 'app/graphql/types/permission_types/base_permission_type.rb'
- 'app/helpers/admin/user_actions_helper.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/events_helper.rb'
- 'app/helpers/issues_helper.rb'
- 'app/helpers/nav/top_nav_helper.rb'
@ -93,10 +88,8 @@ Style/GuardClause:
- 'app/models/concerns/bulk_insert_safe.rb'
- 'app/models/concerns/cache_markdown_field.rb'
- 'app/models/concerns/cacheable_attributes.rb'
- 'app/models/concerns/counter_attribute.rb'
- 'app/models/concerns/deprecated_assignee.rb'
- 'app/models/concerns/has_wiki_page_meta_attributes.rb'
- 'app/models/concerns/issuable.rb'
- 'app/models/concerns/issuable_link.rb'
- 'app/models/concerns/metric_image_uploading.rb'
- 'app/models/concerns/milestoneish.rb'
@ -120,7 +113,6 @@ Style/GuardClause:
- 'app/models/integrations/confluence.rb'
- 'app/models/integrations/datadog.rb'
- 'app/models/integrations/emails_on_push.rb'
- 'app/models/integrations/field.rb'
- 'app/models/integrations/jira.rb'
- 'app/models/integrations/pipelines_email.rb'
- 'app/models/internal_id.rb'
@ -145,7 +137,6 @@ Style/GuardClause:
- 'app/models/project_import_state.rb'
- 'app/models/project_label.rb'
- 'app/models/project_setting.rb'
- 'app/models/protected_branch.rb'
- 'app/models/protected_branch/push_access_level.rb'
- 'app/models/repository.rb'
- 'app/models/sent_notification.rb'
@ -190,7 +181,6 @@ Style/GuardClause:
- 'app/services/groups/update_service.rb'
- 'app/services/groups/update_shared_runners_service.rb'
- 'app/services/ide/base_config_service.rb'
- 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb'
- 'app/services/import/validate_remote_git_endpoint_service.rb'
- 'app/services/issuable/bulk_update_service.rb'
- 'app/services/issuable/common_system_notes_service.rb'
@ -205,7 +195,6 @@ Style/GuardClause:
- 'app/services/merge_requests/merge_base_service.rb'
- 'app/services/merge_requests/merge_service.rb'
- 'app/services/merge_requests/mergeability_check_service.rb'
- 'app/services/merge_requests/outdated_discussion_diff_lines_service.rb'
- 'app/services/merge_requests/push_options_handler_service.rb'
- 'app/services/merge_requests/refresh_service.rb'
- 'app/services/metrics/dashboard/base_service.rb'
@ -268,19 +257,12 @@ Style/GuardClause:
- 'config/initializers/0_inject_enterprise_edition_module.rb'
- 'config/initializers/carrierwave_patch.rb'
- 'config/initializers/devise_dynamic_password_length_validation.rb'
- 'config/initializers/google_api_client_patch.rb'
- 'config/initializers/postgresql_cte.rb'
- 'config/object_store_settings.rb'
- 'danger/feature_flag/Dangerfile'
- 'db/migrate/20210707095545_add_status_to_merge_request_cleanup_schedules.rb'
- 'db/migrate/20210816095826_add_unique_index_on_dast_profile_to_dast_profile_schedules.rb'
- 'db/migrate/20210816192041_add_invites_email_success_to_member.rb'
- 'db/migrate/20210818061156_remove_project_profile_compound_index_from_dast_profile_schedules.rb'
- 'db/migrate/20210830140524_add_state_to_member.rb'
- 'db/migrate/20211202094944_move_loose_fk_deleted_records_to_dynamic_schema.rb'
- 'db/migrate/20220215164709_update_application_settings_container_registry_exp_pol_worker_capacity_default.rb'
- 'db/post_migrate/20210713042000_fix_ci_sources_pipelines_index_names.rb'
- 'db/post_migrate/20210805192450_update_trial_plans_ci_daily_pipeline_schedule_triggers.rb'
- 'db/post_migrate/20210907211557_finalize_ci_builds_bigint_conversion.rb'
- 'ee/app/controllers/admin/emails_controller.rb'
- 'ee/app/controllers/admin/geo/application_controller.rb'
@ -309,7 +291,6 @@ Style/GuardClause:
- 'ee/app/graphql/resolvers/iterations_resolver.rb'
- 'ee/app/helpers/ee/application_helper.rb'
- 'ee/app/helpers/ee/auth_helper.rb'
- 'ee/app/helpers/ee/award_emoji_helper.rb'
- 'ee/app/helpers/ee/nav/new_dropdown_helper.rb'
- 'ee/app/helpers/ee/nav/top_nav_helper.rb'
- 'ee/app/helpers/ee/projects/pipeline_helper.rb'
@ -461,7 +442,6 @@ Style/GuardClause:
- 'lib/api/helpers/projects_helpers.rb'
- 'lib/api/helpers/snippets_helpers.rb'
- 'lib/api/helpers/version.rb'
- 'lib/api/internal/base.rb'
- 'lib/api/projects.rb'
- 'lib/backup/files.rb'
- 'lib/banzai/filter/external_link_filter.rb'
@ -469,7 +449,6 @@ Style/GuardClause:
- 'lib/banzai/filter/references/merge_request_reference_filter.rb'
- 'lib/banzai/filter/wiki_link_filter/rewriter.rb'
- 'lib/bulk_imports/clients/graphql.rb'
- 'lib/bulk_imports/clients/http.rb'
- 'lib/bulk_imports/pipeline/runner.rb'
- 'lib/bulk_imports/projects/pipelines/project_pipeline.rb'
- 'lib/container_registry/client.rb'
@ -486,7 +465,6 @@ Style/GuardClause:
- 'lib/gitlab/blob_helper.rb'
- 'lib/gitlab/cache/ci/project_pipeline_status.rb'
- 'lib/gitlab/changelog/config.rb'
- 'lib/gitlab/chat/responder.rb'
- 'lib/gitlab/checks/branch_check.rb'
- 'lib/gitlab/checks/matching_merge_request.rb'
- 'lib/gitlab/checks/push_file_count_check.rb'
@ -502,7 +480,6 @@ Style/GuardClause:
- 'lib/gitlab/ci/config/external/file/base.rb'
- 'lib/gitlab/ci/config/external/file/remote.rb'
- 'lib/gitlab/ci/config/external/file/template.rb'
- 'lib/gitlab/ci/config/external/mapper.rb'
- 'lib/gitlab/ci/parsers/coverage/sax_document.rb'
- 'lib/gitlab/ci/parsers/security/common.rb'
- 'lib/gitlab/ci/pipeline/chain/command.rb'
@ -532,7 +509,6 @@ Style/GuardClause:
- 'lib/gitlab/database/partitioning/partition_manager.rb'
- 'lib/gitlab/database/partitioning/sliding_list_strategy.rb'
- 'lib/gitlab/database/postgresql_adapter/force_disconnectable_mixin.rb'
- 'lib/gitlab/database/query_analyzers/gitlab_schemas_validate_connection.rb'
- 'lib/gitlab/database/query_analyzers/restrict_allowed_schemas.rb'
- 'lib/gitlab/diff/file.rb'
- 'lib/gitlab/diff/highlight.rb'
@ -551,13 +527,11 @@ Style/GuardClause:
- 'lib/gitlab/git_access.rb'
- 'lib/gitlab/git_access_design.rb'
- 'lib/gitlab/git_access_snippet.rb'
- 'lib/gitlab/gitaly_client/blobs_stitcher.rb'
- 'lib/gitlab/gitaly_client/conflicts_service.rb'
- 'lib/gitlab/gitaly_client/operation_service.rb'
- 'lib/gitlab/github_import.rb'
- 'lib/gitlab/github_import/client.rb'
- 'lib/gitlab/github_import/importer/pull_request_importer.rb'
- 'lib/gitlab/github_import/importer/pull_request_merged_by_importer.rb'
- 'lib/gitlab/github_import/importer/pull_request_review_importer.rb'
- 'lib/gitlab/github_import/object_counter.rb'
- 'lib/gitlab/gitlab_import/client.rb'
@ -576,7 +550,6 @@ Style/GuardClause:
- 'lib/gitlab/import_export/version_checker.rb'
- 'lib/gitlab/instrumentation/global_search_api.rb'
- 'lib/gitlab/instrumentation/rate_limiting_gates.rb'
- 'lib/gitlab/instrumentation/redis_cluster_validator.rb'
- 'lib/gitlab/instrumentation/uploads.rb'
- 'lib/gitlab/issuable/clone/copy_resource_events_service.rb'
- 'lib/gitlab/legacy_github_import/client.rb'
@ -596,14 +569,12 @@ Style/GuardClause:
- 'lib/gitlab/pagination/keyset/order.rb'
- 'lib/gitlab/pagination/keyset/pager.rb'
- 'lib/gitlab/pagination/keyset/paginator.rb'
- 'lib/gitlab/pagination/keyset/simple_order_builder.rb'
- 'lib/gitlab/patch/global_id.rb'
- 'lib/gitlab/patch/sprockets_base_file_digest_key.rb'
- 'lib/gitlab/process_supervisor.rb'
- 'lib/gitlab/prometheus/query_variables.rb'
- 'lib/gitlab/prometheus_client.rb'
- 'lib/gitlab/recaptcha.rb'
- 'lib/gitlab/relative_positioning/mover.rb'
- 'lib/gitlab/sanitizers/exif.rb'
- 'lib/gitlab/search/abuse_validators/no_abusive_coercion_from_string_validator.rb'
- 'lib/gitlab/search/abuse_validators/no_abusive_term_length_validator.rb'
@ -615,11 +586,9 @@ Style/GuardClause:
- 'lib/gitlab/sidekiq_middleware/extra_done_log_metadata.rb'
- 'lib/gitlab/sidekiq_middleware/size_limiter/compressor.rb'
- 'lib/gitlab/sql/set_operator.rb'
- 'lib/gitlab/ssh_public_key.rb'
- 'lib/gitlab/url_blocker.rb'
- 'lib/gitlab/usage/metric_definition.rb'
- 'lib/gitlab/usage/metrics/instrumentations/count_bulk_imports_entities_metric.rb'
- 'lib/gitlab/usage_data_counters/ci_template_unique_counter.rb'
- 'lib/gitlab/utils.rb'
- 'lib/gitlab/utils/override.rb'
- 'lib/gitlab/webpack/manifest.rb'
@ -631,15 +600,12 @@ Style/GuardClause:
- 'lib/tasks/config_lint.rake'
- 'lib/tasks/gettext.rake'
- 'qa/qa/ee/page/file/show.rb'
- 'qa/qa/ee/resource/license.rb'
- 'qa/qa/mobile/page/main/menu.rb'
- 'qa/qa/mobile/page/sub_menus/common.rb'
- 'qa/qa/page/component/invite_members_modal.rb'
- 'qa/qa/page/component/snippet.rb'
- 'qa/qa/page/mattermost/login.rb'
- 'qa/qa/page/page_concern.rb'
- 'qa/qa/page/project/settings/deploy_tokens.rb'
- 'qa/qa/resource/api_fabricator.rb'
- 'qa/qa/resource/package.rb'
- 'qa/qa/resource/registry_repository.rb'
- 'qa/qa/resource/user_gpg.rb'
@ -647,7 +613,6 @@ Style/GuardClause:
- 'qa/qa/runtime/search.rb'
- 'qa/qa/service/cluster_provider/gcloud.rb'
- 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/free_trial_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/3_create/repository/group_file_template_spec.rb'
- 'qa/qa/specs/helpers/feature_flag.rb'
- 'qa/qa/vendor/jenkins/job.rb'
@ -662,7 +627,6 @@ Style/GuardClause:
- 'scripts/lint_templates_bash.rb'
- 'scripts/setup/find-jh-branch.rb'
- 'scripts/trigger-build.rb'
- 'spec/deprecation_toolkit_env.rb'
- 'spec/features/issuables/issuable_list_spec.rb'
- 'spec/features/projects/blobs/edit_spec.rb'
- 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb'

1
.rubocop_todo/style/hash_as_last_array_item.yml
View File

@ -18,7 +18,6 @@ Style/HashAsLastArrayItem:
- 'app/graphql/resolvers/clusters/agents_resolver.rb'
- 'app/graphql/types/boards/board_issuable_input_base_type.rb'
- 'app/graphql/types/boards/board_issue_input_base_type.rb'
- 'app/helpers/namespaces_helper.rb'
- 'app/models/customer_relations/contact.rb'
- 'app/models/customer_relations/organization.rb'
- 'app/models/deploy_key.rb'

1
.rubocop_todo/style/hash_each_methods.yml
View File

@ -46,7 +46,6 @@ Style/HashEachMethods:
- 'ee/app/graphql/types/vulnerability_severity_enum.rb'
- 'ee/app/models/geo/secondary_usage_data.rb'
- 'ee/db/fixtures/development/32_compliance_report_violations.rb'
- 'ee/lib/gitlab/ci/reports/license_scanning/report.rb'
- 'ee/spec/factories/vulnerabilities.rb'
- 'ee/spec/factories/vulnerabilities/findings.rb'
- 'ee/spec/helpers/application_helper_spec.rb'

39
.rubocop_todo/style/if_unless_modifier.yml
View File

@ -3,7 +3,6 @@
Style/IfUnlessModifier:
Exclude:
- 'app/controllers/concerns/uploads_actions.rb'
- 'app/controllers/concerns/verifies_with_email.rb'
- 'app/controllers/concerns/wiki_actions.rb'
- 'app/controllers/concerns/with_performance_bar.rb'
- 'app/controllers/explore/projects_controller.rb'
@ -52,7 +51,6 @@ Style/IfUnlessModifier:
- 'app/finders/labels_finder.rb'
- 'app/finders/members_finder.rb'
- 'app/finders/metrics/users_starred_dashboards_finder.rb'
- 'app/finders/namespaces/projects_finder.rb'
- 'app/finders/notes_finder.rb'
- 'app/finders/packages/helm/packages_finder.rb'
- 'app/finders/personal_access_tokens_finder.rb'
@ -92,7 +90,6 @@ Style/IfUnlessModifier:
- 'app/helpers/lazy_image_tag_helper.rb'
- 'app/helpers/markup_helper.rb'
- 'app/helpers/merge_requests_helper.rb'
- 'app/helpers/namespaces_helper.rb'
- 'app/helpers/nav/top_nav_helper.rb'
- 'app/helpers/nav_helper.rb'
- 'app/helpers/page_layout_helper.rb'
@ -102,7 +99,6 @@ Style/IfUnlessModifier:
- 'app/helpers/reminder_emails_helper.rb'
- 'app/helpers/routing/artifacts_helper.rb'
- 'app/helpers/search_helper.rb'
- 'app/helpers/selects_helper.rb'
- 'app/helpers/snippets_helper.rb'
- 'app/helpers/sorting_helper.rb'
- 'app/helpers/submodule_helper.rb'
@ -113,7 +109,6 @@ Style/IfUnlessModifier:
- 'app/helpers/x509_helper.rb'
- 'app/mailers/emails/members.rb'
- 'app/mailers/emails/merge_requests.rb'
- 'app/mailers/notify.rb'
- 'app/models/ability.rb'
- 'app/models/appearance.rb'
- 'app/models/application_setting_implementation.rb'
@ -142,7 +137,6 @@ Style/IfUnlessModifier:
- 'app/models/concerns/deprecated_assignee.rb'
- 'app/models/concerns/group_descendant.rb'
- 'app/models/concerns/has_wiki_page_meta_attributes.rb'
- 'app/models/concerns/id_in_ordered.rb'
- 'app/models/concerns/ignorable_columns.rb'
- 'app/models/concerns/issuable.rb'
- 'app/models/concerns/issuable_link.rb'
@ -182,7 +176,6 @@ Style/IfUnlessModifier:
- 'app/models/merge_request.rb'
- 'app/models/milestone.rb'
- 'app/models/namespace.rb'
- 'app/models/namespace_setting.rb'
- 'app/models/namespaces/traversal/linear.rb'
- 'app/models/network/graph.rb'
- 'app/models/note.rb'
@ -197,7 +190,6 @@ Style/IfUnlessModifier:
- 'app/models/packages/pypi/metadatum.rb'
- 'app/models/packages/rubygems/metadatum.rb'
- 'app/models/pages_domain.rb'
- 'app/models/performance_monitoring/prometheus_dashboard.rb'
- 'app/models/project.rb'
- 'app/models/project_team.rb'
- 'app/models/projects/topic.rb'
@ -266,7 +258,6 @@ Style/IfUnlessModifier:
- 'app/services/groups/update_statistics_service.rb'
- 'app/services/ide/base_config_service.rb'
- 'app/services/import/bitbucket_server_service.rb'
- 'app/services/import/gitlab_projects/file_acquisition_strategies/remote_file.rb'
- 'app/services/issuable/bulk_update_service.rb'
- 'app/services/issuable/common_system_notes_service.rb'
- 'app/services/issuable_base_service.rb'
@ -364,7 +355,6 @@ Style/IfUnlessModifier:
- 'app/workers/concerns/packages/cleanup_artifact_worker.rb'
- 'app/workers/concerns/project_start_import.rb'
- 'app/workers/concerns/worker_attributes.rb'
- 'app/workers/delete_container_repository_worker.rb'
- 'app/workers/file_hook_worker.rb'
- 'app/workers/google_cloud/create_cloudsql_instance_worker.rb'
- 'app/workers/issues/rebalancing_worker.rb'
@ -386,7 +376,6 @@ Style/IfUnlessModifier:
- 'config/initializers/doorkeeper.rb'
- 'config/initializers/geo.rb'
- 'config/initializers/google_api_client.rb'
- 'config/initializers/google_api_client_patch.rb'
- 'config/initializers/jira.rb'
- 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb'
- 'config/initializers/remove_active_job_execute_callback.rb'
@ -399,13 +388,8 @@ Style/IfUnlessModifier:
- 'danger/pipeline/Dangerfile'
- 'danger/specs/Dangerfile'
- 'danger/z_metadata/Dangerfile'
- 'db/migrate/20210709221659_add_work_item_type_id_to_issue.rb'
- 'db/migrate/20210816095826_add_unique_index_on_dast_profile_to_dast_profile_schedules.rb'
- 'db/migrate/20210818061156_remove_project_profile_compound_index_from_dast_profile_schedules.rb'
- 'db/migrate/20210909184349_add_index_package_id_id_on_package_files.rb'
- 'db/migrate/20220324175325_add_key_data_to_secure_files.rb'
- 'db/post_migrate/20210629101712_remove_deprecated_modsecurity_columns.rb'
- 'db/post_migrate/20210713042000_fix_ci_sources_pipelines_index_names.rb'
- 'db/post_migrate/20211021140426_remove_geo_upload_deprecated_fields.rb'
- 'db/post_migrate/20220128155814_fix_approval_rules_code_owners_rule_type_index.rb'
- 'db/post_migrate/20220131000001_schedule_trace_expiry_removal.rb'
@ -460,7 +444,6 @@ Style/IfUnlessModifier:
- 'ee/app/helpers/ee/projects_helper.rb'
- 'ee/app/models/allowed_email_domain.rb'
- 'ee/app/models/app_sec/fuzzing/coverage/corpus.rb'
- 'ee/app/models/approval_project_rule.rb'
- 'ee/app/models/concerns/ee/protected_ref_access.rb'
- 'ee/app/models/concerns/elastic/application_versioned_search.rb'
- 'ee/app/models/concerns/geo/verifiable_replicator.rb'
@ -536,7 +519,6 @@ Style/IfUnlessModifier:
- 'ee/app/services/ee/notes/update_service.rb'
- 'ee/app/services/ee/projects/create_service.rb'
- 'ee/app/services/ee/projects/destroy_service.rb'
- 'ee/app/services/ee/projects/gitlab_projects_import_service.rb'
- 'ee/app/services/ee/protected_branches/create_service.rb'
- 'ee/app/services/ee/todo_service.rb'
- 'ee/app/services/ee/users/update_service.rb'
@ -601,7 +583,6 @@ Style/IfUnlessModifier:
- 'ee/db/geo/migrate/20170627195211_add_index_to_project_registry.rb'
- 'ee/db/geo/migrate/20180402170913_add_missing_on_primary_to_job_artifact_registry..rb'
- 'ee/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index.rb'
- 'ee/lib/api/epics.rb'
- 'ee/lib/api/merge_request_approval_rules.rb'
- 'ee/lib/api/protected_environments.rb'
- 'ee/lib/audit/details.rb'
@ -621,7 +602,6 @@ Style/IfUnlessModifier:
- 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules_check_progress.rb'
- 'ee/lib/ee/gitlab/checks/diff_check.rb'
- 'ee/lib/ee/gitlab/checks/push_rules/tag_check.rb'
- 'ee/lib/ee/gitlab/ci/reports/security/reports.rb'
- 'ee/lib/ee/gitlab/cleanup/orphan_job_artifact_files.rb'
- 'ee/lib/ee/gitlab/git_access_wiki.rb'
- 'ee/lib/ee/gitlab/quick_actions/epic_actions.rb'
@ -668,14 +648,12 @@ Style/IfUnlessModifier:
- 'ee/lib/tasks/geo.rake'
- 'ee/lib/tasks/gitlab/geo.rake'
- 'ee/lib/tasks/gitlab/seed/insights.rake'
- 'ee/spec/controllers/subscriptions_controller_spec.rb'
- 'ee/spec/factories/iterations.rb'
- 'ee/spec/factories/vulnerabilities/external_issue_links.rb'
- 'ee/spec/features/boards/user_visits_board_spec.rb'
- 'ee/spec/finders/custom_project_templates_finder_spec.rb'
- 'ee/spec/finders/security/findings_finder_spec.rb'
- 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb'
- 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb'
- 'ee/spec/helpers/ee/users/callouts_helper_spec.rb'
- 'ee/spec/lib/gitlab/analytics/cycle_analytics/data_collector_spec.rb'
- 'ee/spec/lib/gitlab/elastic/search_results_spec.rb'
@ -721,7 +699,6 @@ Style/IfUnlessModifier:
- 'lib/api/helpers/packages/conan/api_helpers.rb'
- 'lib/api/helpers/packages/dependency_proxy_helpers.rb'
- 'lib/api/helpers/projects_helpers.rb'
- 'lib/api/helpers/users_helpers.rb'
- 'lib/api/helpers/version.rb'
- 'lib/api/helpers/web_hooks_helpers.rb'
- 'lib/api/internal/base.rb'
@ -762,10 +739,8 @@ Style/IfUnlessModifier:
- 'lib/banzai/reference_parser/base_parser.rb'
- 'lib/banzai/renderer.rb'
- 'lib/bitbucket_server/representation/pull_request_comment.rb'
- 'lib/bulk_imports/clients/http.rb'
- 'lib/bulk_imports/common/pipelines/uploads_pipeline.rb'
- 'lib/bulk_imports/groups/loaders/group_loader.rb'
- 'lib/bulk_imports/projects/transformers/project_attributes_transformer.rb'
- 'lib/container_registry/base_client.rb'
- 'lib/container_registry/client.rb'
- 'lib/feature/definition.rb'
@ -799,7 +774,6 @@ Style/IfUnlessModifier:
- 'lib/gitlab/ci/ansi2html.rb'
- 'lib/gitlab/ci/ansi2json/converter.rb'
- 'lib/gitlab/ci/ansi2json/style.rb'
- 'lib/gitlab/ci/artifact_file_reader.rb'
- 'lib/gitlab/ci/build/artifacts/metadata.rb'
- 'lib/gitlab/ci/build/artifacts/path.rb'
- 'lib/gitlab/ci/build/policy/kubernetes.rb'
@ -836,7 +810,6 @@ Style/IfUnlessModifier:
- 'lib/gitlab/ci/trace/metrics.rb'
- 'lib/gitlab/ci/variables/builder.rb'
- 'lib/gitlab/ci/yaml_processor.rb'
- 'lib/gitlab/config/entry/attributable.rb'
- 'lib/gitlab/config/entry/simplifiable.rb'
- 'lib/gitlab/config/entry/validatable.rb'
- 'lib/gitlab/config/entry/validators.rb'
@ -857,7 +830,6 @@ Style/IfUnlessModifier:
- 'lib/gitlab/database/partitioning/detached_partition_dropper.rb'
- 'lib/gitlab/database/partitioning/monthly_strategy.rb'
- 'lib/gitlab/database/partitioning/time_partition.rb'
- 'lib/gitlab/database/postgres_partition.rb'
- 'lib/gitlab/database/reindexing.rb'
- 'lib/gitlab/database/reindexing/reindex_concurrently.rb'
- 'lib/gitlab/database/transaction/observer.rb'
@ -1010,13 +982,10 @@ Style/IfUnlessModifier:
- 'qa/qa/resource/registry_repository.rb'
- 'qa/qa/resource/repository/push.rb'
- 'qa/qa/resource/snippet.rb'
- 'qa/qa/runtime/application_settings.rb'
- 'qa/qa/runtime/gpg.rb'
- 'qa/qa/runtime/ip_address.rb'
- 'qa/qa/scenario/bootable.rb'
- 'qa/qa/service/praefect_manager.rb'
- 'qa/qa/specs/features/browser_ui/3_create/merge_request/merge_when_pipeline_succeeds_spec.rb'
- 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb'
- 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb'
- 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb'
- 'qa/qa/specs/helpers/context_selector.rb'
@ -1035,7 +1004,6 @@ Style/IfUnlessModifier:
- 'rubocop/cop/migration/remove_column.rb'
- 'rubocop/cop/migration/sidekiq_queue_migrate.rb'
- 'rubocop/routes_under_scope.rb'
- 'scripts/pipeline_test_report_builder.rb'
- 'scripts/review_apps/automated_cleanup.rb'
- 'scripts/setup/find-jh-branch.rb'
- 'scripts/static-analysis'
@ -1053,20 +1021,17 @@ Style/IfUnlessModifier:
- 'spec/factories/projects.rb'
- 'spec/factories/protected_tags.rb'
- 'spec/factories/users.rb'
- 'spec/features/admin/admin_users_spec.rb'
- 'spec/features/merge_request/batch_comments_spec.rb'
- 'spec/features/merge_request/user_sees_avatar_on_diff_notes_spec.rb'
- 'spec/features/projects/blobs/edit_spec.rb'
- 'spec/features/projects/tree/create_directory_spec.rb'
- 'spec/features/projects/tree/create_file_spec.rb'
- 'spec/graphql/mutations/releases/update_spec.rb'
- 'spec/helpers/application_settings_helper_spec.rb'
- 'spec/lib/container_registry/gitlab_api_client_spec.rb'
- 'spec/lib/gitlab/background_migration/disable_expiration_policies_linked_to_no_container_images_spec.rb'
- 'spec/lib/gitlab/config/entry/validators/nested_array_helpers_spec.rb'
- 'spec/lib/gitlab/conflict/file_spec.rb'
- 'spec/lib/gitlab/database/load_balancing_spec.rb'
- 'spec/lib/gitlab/database/lock_writes_manager_spec.rb'
- 'spec/lib/gitlab/rack_attack/user_allowlist_spec.rb'
- 'spec/lib/gitlab/sidekiq_config/worker_router_spec.rb'
- 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb'
@ -1111,7 +1076,6 @@ Style/IfUnlessModifier:
- 'spec/support/helpers/stub_gitlab_calls.rb'
- 'spec/support/helpers/stubbed_feature.rb'
- 'spec/support/helpers/test_env.rb'
- 'spec/support/helpers/usage_data_helpers.rb'
- 'spec/support/http_io/http_io_helpers.rb'
- 'spec/support/import_export/project_tree_expectations.rb'
- 'spec/support/matchers/abort_matcher.rb'
@ -1130,10 +1094,7 @@ Style/IfUnlessModifier:
- 'spec/support/shared_examples/views/registration_features_prompt_shared_examples.rb'
- 'spec/support/shared_examples/workers/batched_background_migration_worker_shared_examples.rb'
- 'spec/support/webmock.rb'
- 'spec/views/admin/application_settings/general.html.haml_spec.rb'
- 'spec/views/groups/edit.html.haml_spec.rb'
- 'spec/views/profiles/keys/_key.html.haml_spec.rb'
- 'spec/views/projects/edit.html.haml_spec.rb'
- 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb'
- 'tooling/danger/product_intelligence.rb'
- 'tooling/lib/tooling/find_codeowners.rb'

2
.rubocop_todo/style/lambda.yml
View File

@ -56,8 +56,6 @@ Style/Lambda:
- 'lib/gitlab/sidekiq_middleware.rb'
- 'lib/gitlab/utils/usage_data.rb'
- 'qa/qa/runtime/allure_report.rb'
- 'qa/qa/specs/features/api/1_manage/import/import_large_github_repo_spec.rb'
- 'qa/qa/support/api.rb'
- 'rubocop/cop/inject_enterprise_edition_module.rb'
- 'rubocop/cop/rspec/have_gitlab_http_status.rb'
- 'spec/controllers/concerns/routable_actions_spec.rb'

2
.rubocop_todo/style/numeric_literal_prefix.yml
View File

@ -20,7 +20,6 @@ Style/NumericLiteralPrefix:
- 'ee/spec/models/gitlab/seat_link_data_spec.rb'
- 'ee/spec/services/incident_management/oncall_schedules/update_service_spec.rb'
- 'ee/spec/workers/sync_seat_link_worker_spec.rb'
- 'lib/backup/database.rb'
- 'lib/backup/files.rb'
- 'lib/gitlab/background_migration/remove_all_trace_expiration_dates.rb'
- 'lib/gitlab/import_export/command_line_util.rb'
@ -33,7 +32,6 @@ Style/NumericLiteralPrefix:
- 'qa/qa/support/ssh.rb'
- 'qa/spec/support/ssh_spec.rb'
- 'scripts/security-harness'
- 'spec/finders/personal_access_tokens_finder_spec.rb'
- 'spec/lib/gitlab/background_migration/remove_all_trace_expiration_dates_spec.rb'
- 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb'
- 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb'

15
.rubocop_todo/style/percent_literal_delimiters.yml
View File

@ -52,7 +52,6 @@ Style/PercentLiteralDelimiters:
- 'app/models/ci/build.rb'
- 'app/models/ci/build_runner_session.rb'
- 'app/models/ci/pipeline.rb'
- 'app/models/clusters/applications/cert_manager.rb'
- 'app/models/clusters/platforms/kubernetes.rb'
- 'app/models/commit.rb'
- 'app/models/concerns/clusters/agents/authorization_config_scopes.rb'
@ -106,7 +105,6 @@ Style/PercentLiteralDelimiters:
- 'app/models/project_feature.rb'
- 'app/models/project_setting.rb'
- 'app/models/releases/link.rb'
- 'app/models/remote_mirror.rb'
- 'app/models/repository.rb'
- 'app/models/resource_label_event.rb'
- 'app/models/resource_state_event.rb'
@ -164,7 +162,6 @@ Style/PercentLiteralDelimiters:
- 'config/environments/production.rb'
- 'config/initializers/1_settings.rb'
- 'config/initializers/content_security_policy.rb'
- 'config/initializers/countries.rb'
- 'config/initializers/doorkeeper.rb'
- 'config/initializers/enumerator_next_patch.rb'
- 'config/initializers/fog_core_patch.rb'
@ -176,13 +173,7 @@ Style/PercentLiteralDelimiters:
- 'config/initializers_before_autoloader/000_inflections.rb'
- 'config/object_store_settings.rb'
- 'config/spring.rb'
- 'db/migrate/20210608072312_initialize_conversion_of_ci_stages_to_bigint.rb'
- 'db/migrate/20210608072346_backfill_ci_stages_for_bigint_conversion.rb'
- 'db/migrate/20210621044000_rename_services_indexes_to_integrations.rb'
- 'db/migrate/20210709085759_index_batched_migration_jobs_by_max_value.rb'
- 'db/migrate/20210928155022_improve_index_for_error_tracking.rb'
- 'db/post_migrate/20210823142036_drop_temporary_trigger_for_ci_job_artifacts.rb'
- 'db/post_migrate/20210826171758_initialize_throttle_unauthenticated_api_columns.rb'
- 'db/post_migrate/20210906130643_drop_temporary_columns_and_triggers_for_taggings.rb'
- 'db/post_migrate/20211028100843_delete_issue_merge_request_taggings_records.rb'
- 'ee/app/controllers/ee/admin/application_settings_controller.rb'
@ -522,7 +513,6 @@ Style/PercentLiteralDelimiters:
- 'lib/gitlab/project_search_results.rb'
- 'lib/gitlab/prometheus/query_variables.rb'
- 'lib/gitlab/query_limiting/transaction.rb'
- 'lib/gitlab/redis/multi_store.rb'
- 'lib/gitlab/reference_extractor.rb'
- 'lib/gitlab/regex.rb'
- 'lib/gitlab/sanitizers/exception_message.rb'
@ -638,7 +628,6 @@ Style/PercentLiteralDelimiters:
- 'spec/features/users/login_spec.rb'
- 'spec/finders/alert_management/alerts_finder_spec.rb'
- 'spec/finders/branches_finder_spec.rb'
- 'spec/finders/ci/jobs_finder_spec.rb'
- 'spec/finders/ci/runners_finder_spec.rb'
- 'spec/finders/environments/environments_finder_spec.rb'
- 'spec/finders/groups_finder_spec.rb'
@ -678,7 +667,6 @@ Style/PercentLiteralDelimiters:
- 'spec/lib/api/ci/helpers/runner_helpers_spec.rb'
- 'spec/lib/api/entities/user_spec.rb'
- 'spec/lib/api/helpers/common_helpers_spec.rb'
- 'spec/lib/atlassian/jira_connect/client_spec.rb'
- 'spec/lib/backup/files_spec.rb'
- 'spec/lib/backup/manager_spec.rb'
- 'spec/lib/backup/repositories_spec.rb'
@ -744,7 +732,6 @@ Style/PercentLiteralDelimiters:
- 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb'
- 'spec/lib/gitlab/ci/reports/accessibility_reports_comparer_spec.rb'
- 'spec/lib/gitlab/ci/reports/accessibility_reports_spec.rb'
- 'spec/lib/gitlab/ci/reports/security/reports_spec.rb'
- 'spec/lib/gitlab/ci/reports/test_suite_spec.rb'
- 'spec/lib/gitlab/ci/status/composite_spec.rb'
- 'spec/lib/gitlab/ci/status/stage/factory_spec.rb'
@ -891,7 +878,6 @@ Style/PercentLiteralDelimiters:
- 'spec/lib/unnested_in_filters/dsl_spec.rb'
- 'spec/lib/unnested_in_filters/rewriter_spec.rb'
- 'spec/metrics_server/metrics_server_spec.rb'
- 'spec/migrations/reset_severity_levels_to_new_default_spec.rb'
- 'spec/models/alert_management/http_integration_spec.rb'
- 'spec/models/appearance_spec.rb'
- 'spec/models/application_setting_spec.rb'
@ -983,7 +969,6 @@ Style/PercentLiteralDelimiters:
- 'spec/requests/api/graphql/project/jira_import_spec.rb'
- 'spec/requests/api/graphql/project/jira_projects_spec.rb'
- 'spec/requests/api/graphql/project/release_spec.rb'
- 'spec/requests/api/graphql/project/releases_spec.rb'
- 'spec/requests/api/graphql/project/terraform/state_spec.rb'
- 'spec/requests/api/graphql/project/terraform/states_spec.rb'
- 'spec/requests/api/internal/base_spec.rb'

1
.rubocop_todo/style/redundant_condition.yml
View File

@ -2,5 +2,4 @@
# Cop supports --autocorrect.
Style/RedundantCondition:
Exclude:
- 'ee/app/models/license.rb'
- 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb'

1
.rubocop_todo/style/redundant_freeze.yml
View File

@ -143,7 +143,6 @@ Style/RedundantFreeze:
- 'lib/gitlab/database/background_migration/batch_optimizer.rb'
- 'lib/gitlab/database/load_balancing/service_discovery.rb'
- 'lib/gitlab/database/migrations/runner.rb'
- 'lib/gitlab/database/postgres_constraint.rb'
- 'lib/gitlab/database/query_analyzers/query_recorder.rb'
- 'lib/gitlab/dependency_linker/base_linker.rb'
- 'lib/gitlab/dependency_linker/gemfile_linker.rb'

2
.rubocop_todo/style/redundant_interpolation.yml
View File

@ -18,14 +18,12 @@ Style/RedundantInterpolation:
- 'lib/gitlab/repository_hash_cache.rb'
- 'lib/gitlab/repository_set_cache.rb'
- 'lib/gitlab/usage/metrics/names_suggestions/relation_parsers/joins.rb'
- 'lib/gitlab/usage_data_counters/hll_redis_counter.rb'
- 'lib/gitlab/usage_data_counters/search_counter.rb'
- 'lib/gitlab/utils.rb'
- 'lib/kramdown/converter/commonmark.rb'
- 'lib/tasks/gettext.rake'
- 'lib/tasks/gitlab/seed/group_seed.rake'
- 'qa/qa/ee/page/component/secure_report.rb'
- 'qa/qa/ee/page/merge_request/new.rb'
- 'qa/qa/ee/page/project/issue/show.rb'
- 'qa/qa/ee/page/project/secure/vulnerability_details.rb'
- 'qa/qa/resource/events/base.rb'

2
.rubocop_todo/style/redundant_self.yml
View File

@ -18,7 +18,6 @@ Style/RedundantSelf:
- 'app/models/ci/stage.rb'
- 'app/models/ci/trigger.rb'
- 'app/models/ci_platform_metric.rb'
- 'app/models/clusters/applications/cert_manager.rb'
- 'app/models/clusters/applications/crossplane.rb'
- 'app/models/clusters/cluster.rb'
- 'app/models/clusters/concerns/application_core.rb'
@ -401,7 +400,6 @@ Style/RedundantSelf:
- 'spec/helpers/emails_helper_spec.rb'
- 'spec/helpers/feature_flags_helper_spec.rb'
- 'spec/helpers/graph_helper_spec.rb'
- 'spec/helpers/ide_helper_spec.rb'
- 'spec/helpers/submodule_helper_spec.rb'
- 'spec/lib/gitlab/background_task_spec.rb'
- 'spec/lib/gitlab/database/load_balancing_spec.rb'

3
.rubocop_todo/style/sole_nested_conditional.yml
View File

@ -6,9 +6,7 @@ Style/SoleNestedConditional:
- 'app/controllers/ldap/omniauth_callbacks_controller.rb'
- 'app/controllers/omniauth_callbacks_controller.rb'
- 'app/controllers/projects/blob_controller.rb'
- 'app/helpers/namespaces_helper.rb'
- 'app/helpers/nav_helper.rb'
- 'app/helpers/selects_helper.rb'
- 'app/models/concerns/cache_markdown_field.rb'
- 'app/models/external_pull_request.rb'
- 'app/models/issue.rb'
@ -50,7 +48,6 @@ Style/SoleNestedConditional:
- 'lib/gitlab/config/entry/configurable.rb'
- 'lib/gitlab/config/entry/validators.rb'
- 'lib/gitlab/database/each_database.rb'
- 'lib/gitlab/database/load_balancing/load_balancer.rb'
- 'lib/gitlab/email/handler/reply_processing.rb'
- 'lib/gitlab/patch/database_config.rb'
- 'lib/gitlab/user_access.rb'

2
.rubocop_todo/style/string_concatenation.yml
View File

@ -4,7 +4,6 @@ Style/StringConcatenation:
Exclude:
- 'app/controllers/projects/labels_controller.rb'
- 'app/controllers/projects/milestones_controller.rb'
- 'app/models/concerns/counter_attribute.rb'
- 'app/models/concerns/cross_database_modification.rb'
- 'app/models/concerns/from_set_operator.rb'
- 'app/models/concerns/routable.rb'
@ -171,7 +170,6 @@ Style/StringConcatenation:
- 'spec/helpers/events_helper_spec.rb'
- 'spec/helpers/search_helper_spec.rb'
- 'spec/lib/api/helpers/related_resources_helpers_spec.rb'
- 'spec/lib/atlassian/jira_connect/client_spec.rb'
- 'spec/lib/backup/gitaly_backup_spec.rb'
- 'spec/lib/backup/repositories_spec.rb'
- 'spec/lib/banzai/filter/color_filter_spec.rb'

1
.rubocop_todo/style/string_literals_in_interpolation.yml
View File

@ -15,7 +15,6 @@ Style/StringLiteralsInInterpolation:
- 'app/views/events/_event.atom.builder'
- 'app/workers/concerns/application_worker.rb'
- 'config/initializers/validate_database_config.rb'
- 'db/post_migrate/20210809123658_orphaned_invite_tokens_cleanup.rb'
- 'ee/app/helpers/ee/merge_requests_helper.rb'
- 'ee/app/models/license.rb'
- 'ee/app/services/epics/tree_reorder_service.rb'

2
.rubocop_todo/style/symbol_proc.yml
View File

@ -149,7 +149,6 @@ Style/SymbolProc:
- 'lib/gitlab/diff/file_collection/base.rb'
- 'lib/gitlab/diff/rendered/notebook/diff_file_helper.rb'
- 'lib/gitlab/git/diff_stats_collection.rb'
- 'lib/gitlab/gitaly_client/commit_service.rb'
- 'lib/gitlab/import_export/attributes_finder.rb'
- 'lib/gitlab/import_export/base/relation_object_saver.rb'
- 'lib/gitlab/import_export/fast_hash_serializer.rb'
@ -222,7 +221,6 @@ Style/SymbolProc:
- 'spec/lib/gitlab/relative_positioning/item_context_spec.rb'
- 'spec/lib/gitlab/usage/metrics/instrumentations/database_metric_spec.rb'
- 'spec/lib/omni_auth/strategies/jwt_spec.rb'
- 'spec/models/member_spec.rb'
- 'spec/models/merge_request_diff_spec.rb'
- 'spec/models/namespace/root_storage_statistics_spec.rb'
- 'spec/models/operations/feature_flags/strategy_spec.rb'

2
GITALY_SERVER_VERSION
View File

@ -1 +1 @@
d4daa7a154ccc86d1b57372e4265bb502c886537
f223d8cbcb6319356cb9f746252b15e541695d2f

2
Gemfile
View File

@ -81,7 +81,7 @@ gem 'rack-oauth2', '~> 1.21.3'
gem 'jwt', '~> 2.1.0'
# Kerberos authentication. EE-only
gem 'gssapi', group: :kerberos
gem 'gssapi', '~> 1.3.1', group: :kerberos
gem 'timfel-krb5-auth', '~> 0.8', group: :kerberos
# Spam and anti-bot protection

2
Gemfile.checksum
View File

@ -261,7 +261,7 @@
{"name":"grpc","version":"1.42.0","platform":"x86-mingw32","checksum":"eeb2a9381bea43fafe879b6ddaa011351a44d0894d48bdc965a07bcb67c6eb56"},
{"name":"grpc","version":"1.42.0","platform":"x86_64-darwin","checksum":"20fa202d46d8a055628260622e98fb6439529fbac283f0552af620b909f78535"},
{"name":"grpc","version":"1.42.0","platform":"x86_64-linux","checksum":"92e2ceb2aca335d5755163dd8030082091d5b0e63c117b1ca07051b66c53eb2e"},
{"name":"gssapi","version":"1.2.0","platform":"ruby","checksum":"3d0e3222f36532c1ab3b7eaab171ad4245889edc5439a5483ff714999cb62349"},
{"name":"gssapi","version":"1.3.1","platform":"ruby","checksum":"c51cf30842ee39bd93ce7fc33e20405ff8a04cda9dec6092071b61258284aee1"},
{"name":"guard","version":"2.16.2","platform":"ruby","checksum":"71ba7abaddecc8be91ab77bbaf78f767246603652ebbc7b976fda497ebdc8fbb"},
{"name":"guard-compat","version":"1.2.1","platform":"ruby","checksum":"3ad21ab0070107f92edfd82610b5cdc2fb8e368851e72362ada9703443d646fe"},
{"name":"guard-rspec","version":"4.7.3","platform":"ruby","checksum":"a47ba03cbd1e3c71e6ae8645cea97e203098a248aede507461a43e906e2f75ca"},

4
Gemfile.lock
View File

@ -726,7 +726,7 @@ GEM
grpc (1.42.0)
google-protobuf (~> 3.18)
googleapis-common-protos-types (~> 1.0)
gssapi (1.2.0)
gssapi (1.3.1)
ffi (>= 1.0.1)
guard (2.16.2)
formatador (>= 0.2.4)
@ -1713,7 +1713,7 @@ DEPENDENCIES
graphql (~> 1.13.12)
graphql-docs (~> 2.1.0)
grpc (~> 1.42.0)
gssapi
gssapi (~> 1.3.1)
guard-rspec
haml_lint (~> 0.40.0)
hamlit (~> 2.15.0)

18
app/controllers/concerns/sends_blob.rb
View File

@ -27,12 +27,7 @@ module SendsBlob
private
def cached_blob?(blob, allow_caching: false)
stale =
if Feature.enabled?(:improve_blobs_cache_headers)
stale?(strong_etag: blob.id)
else
stale?(etag: blob.id)
end
stale = stale?(strong_etag: blob.id)
max_age =
if @ref && @commit && @ref == @commit.id # rubocop:disable Gitlab/ModuleWithInstanceVariables
@ -47,14 +42,9 @@ module SendsBlob
end
# Because we are opinionated we set the cache headers ourselves.
if Feature.enabled?(:improve_blobs_cache_headers)
expires_in(max_age,
public: allow_caching, must_revalidate: true, stale_if_error: 5.minutes,
stale_while_revalidate: 1.minute, 's-maxage': 1.minute)
else
response.cache_control[:public] = allow_caching
response.cache_control[:max_age] = max_age
end
expires_in(max_age,
public: allow_caching, must_revalidate: true, stale_if_error: 5.minutes,
stale_while_revalidate: 1.minute, 's-maxage': 1.minute)
!stale
end

2
app/controllers/projects/issues_controller.rb
View File

@ -156,7 +156,7 @@ class Projects::IssuesController < Projects::ApplicationController
)
spam_params = ::Spam::SpamParams.new_from_request(request: request)
service = ::Issues::CreateService.new(project: project, current_user: current_user, params: create_params, spam_params: spam_params)
service = ::Issues::CreateService.new(container: project, current_user: current_user, params: create_params, spam_params: spam_params)
result = service.execute
# Only irrecoverable errors such as unauthorized user won't contain an issue in the response

13
app/controllers/projects/repositories_controller.rb
View File

@ -49,16 +49,11 @@ class Projects::RepositoriesController < Projects::ApplicationController
def set_cache_headers
commit_id = archive_metadata['CommitId']
if Feature.enabled?(:improve_blobs_cache_headers)
expires_in(cache_max_age(commit_id),
public: Guest.can?(:download_code, project), must_revalidate: true, stale_if_error: 5.minutes,
stale_while_revalidate: 1.minute, 's-maxage': 1.minute)
expires_in(cache_max_age(commit_id),
public: Guest.can?(:download_code, project), must_revalidate: true, stale_if_error: 5.minutes,
stale_while_revalidate: 1.minute, 's-maxage': 1.minute)
fresh_when(strong_etag: [commit_id, archive_metadata['ArchivePath']])
else
expires_in cache_max_age(commit_id), public: Guest.can?(:download_code, project)
fresh_when(etag: archive_metadata['ArchivePath'])
end
fresh_when(strong_etag: [commit_id, archive_metadata['ArchivePath']])
end
def archive_not_modified?

2
app/finders/work_items/work_items_finder.rb
View File

@ -19,7 +19,7 @@ module WorkItems
end
def by_widgets(items)
WorkItems::Type.available_widgets.each do |widget_class|
WorkItems::WidgetDefinition.available_widgets.each do |widget_class|
widget_filter = widget_filter_for(widget_class)
next unless widget_filter

2
app/graphql/mutations/concerns/mutations/work_items/widgetable.rb
View File

@ -7,7 +7,7 @@ module Mutations
def extract_widget_params!(work_item_type, attributes)
# Get the list of widgets for the work item's type to extract only the supported attributes
widget_keys = ::WorkItems::Type.available_widgets.map(&:api_symbol)
widget_keys = ::WorkItems::WidgetDefinition.available_widgets.map(&:api_symbol)
widget_params = attributes.extract!(*widget_keys)
not_supported_keys = widget_params.keys - work_item_type.widgets.map(&:api_symbol)

2
app/graphql/mutations/issues/create.rb
View File

@ -83,7 +83,7 @@ module Mutations
params = build_create_issue_params(attributes.merge(author_id: current_user.id), project)
spam_params = ::Spam::SpamParams.new_from_request(request: context[:request])
result = ::Issues::CreateService.new(project: project, current_user: current_user, params: params, spam_params: spam_params).execute
result = ::Issues::CreateService.new(container: project, current_user: current_user, params: params, spam_params: spam_params).execute
check_spam_action_response!(result[:issue]) if result[:issue]

2
app/graphql/mutations/work_items/create.rb
View File

@ -48,7 +48,7 @@ module Mutations
widget_params = extract_widget_params!(type, params)
create_result = ::WorkItems::CreateService.new(
project: project,
container: project,
current_user: current_user,
params: params,
spam_params: spam_params,

2
app/graphql/resolvers/work_items_resolver.rb
View File

@ -43,7 +43,7 @@ module Resolvers
{
work_item_type: :work_item_type,
web_url: { project: { namespace: :route } },
widgets: :work_item_type
widgets: { work_item_type: :enabled_widget_definitions }
}
end

4
app/graphql/types/work_items/widget_type_enum.rb
View File

@ -6,8 +6,8 @@ module Types
graphql_name 'WorkItemWidgetType'
description 'Type of a work item widget'
::WorkItems::Type.available_widgets.each do |widget|
value widget.type.to_s.upcase, value: widget.type, description: "#{widget.type.to_s.titleize} widget."
::WorkItems::WidgetDefinition.widget_classes.each do |cls|
value cls.type.to_s.upcase, value: cls.type, description: "#{cls.type.to_s.titleize} widget."
end
end
end

Some files were not shown because too many files have changed in this diff Show More