diff --git a/.haml-lint_todo.yml b/.haml-lint_todo.yml index 9f201dcc289..ce4f697300f 100644 --- a/.haml-lint_todo.yml +++ b/.haml-lint_todo.yml @@ -1,7 +1,19 @@ # This configuration was generated by # `haml-lint --auto-gen-config` -# on 2021-04-01 00:00:00 +0000 using Haml-Lint version 0.36.0. +# on 2022-09-15 12:13:31 +0000 using Haml-Lint version 0.40.1. # The point is for the user to remove these configuration records # one by one as the lints are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of Haml-Lint, may require this file to be generated again. + +linters: + + # Offense count: 11 + RuboCop: + exclude: + - "app/views/layouts/_page.html.haml" + - "app/views/layouts/header/_default.html.haml" + - "app/views/projects/merge_requests/dropdowns/_branch.html.haml" + - "app/views/projects/merge_requests/dropdowns/_project.html.haml" + - "app/views/shared/_flash_user_callout.html.haml" + - "app/views/shared/_label.html.haml" \ No newline at end of file diff --git a/.rubocop.yml b/.rubocop.yml index 7fe3fc35b66..a7fe623aa9e 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -40,11 +40,14 @@ AllCops: - 'plugins/**/*' - 'file_hooks/**/*' - 'workhorse/**/*' + - 'shared/packages/**/*' - 'spec/support/*.git/**/*' # e.g. spec/support/gitlab-git-test.git - 'db/ci_migrate/*.rb' # since the `db/ci_migrate` is a symlinked to `db/migrate` # Use absolute path to avoid orphan directories with changed workspace root. CacheRootDirectory: <%= Dir.getwd %>/tmp MaxFilesInCache: 35000 + NewCops: disable + SuggestExtensions: false Metrics/ParameterLists: Exclude: @@ -690,7 +693,7 @@ Gitlab/RailsLogger: - 'ee/spec/**/*.rb' # WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/267606 -FactoryBot/InlineAssociation: +RSpec/FactoryBot/InlineAssociation: Include: - 'spec/factories/**/*.rb' - 'ee/spec/factories/**/*.rb' @@ -775,3 +778,7 @@ Fips/OpenSSL: Gemspec/AvoidExecutingGit: Enabled: false + +Lint/BinaryOperatorWithIdenticalOperands: + Exclude: + - '{,ee/,qa/}spec/**/*_{spec,shared_examples,shared_context}.rb' diff --git a/.rubocop_todo/capybara/visibility_matcher.yml b/.rubocop_todo/capybara/visibility_matcher.yml index e236be2593e..f9e8c982903 100644 --- a/.rubocop_todo/capybara/visibility_matcher.yml +++ b/.rubocop_todo/capybara/visibility_matcher.yml @@ -1,5 +1,5 @@ --- -Capybara/VisibilityMatcher: +RSpec/Capybara/VisibilityMatcher: Exclude: - 'ee/spec/features/boards/sidebar_spec.rb' - 'ee/spec/features/epics/epic_show_spec.rb' diff --git a/.rubocop_todo/layout/closing_parenthesis_indentation.yml b/.rubocop_todo/layout/closing_parenthesis_indentation.yml new file mode 100644 index 00000000000..79397e92312 --- /dev/null +++ b/.rubocop_todo/layout/closing_parenthesis_indentation.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --auto-correct. +Layout/ClosingParenthesisIndentation: + Exclude: + - 'app/presenters/project_presenter.rb' + - 'spec/requests/api/internal/base_spec.rb' diff --git a/.rubocop_todo/layout/empty_line_between_defs.yml b/.rubocop_todo/layout/empty_line_between_defs.yml new file mode 100644 index 00000000000..ba69fc4c51b --- /dev/null +++ b/.rubocop_todo/layout/empty_line_between_defs.yml @@ -0,0 +1,8 @@ +--- +# Cop supports --auto-correct. +Layout/EmptyLineBetweenDefs: + Exclude: + - 'db/post_migrate/20220202105733_delete_service_template_records.rb' + - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' + - 'lib/gitlab/import_export/remote_stream_upload.rb' + - 'lib/gitlab/redis/multi_store.rb' diff --git a/.rubocop_todo/layout/first_array_element_indentation.yml b/.rubocop_todo/layout/first_array_element_indentation.yml index 291fd2155d7..2861d5fa8df 100644 --- a/.rubocop_todo/layout/first_array_element_indentation.yml +++ b/.rubocop_todo/layout/first_array_element_indentation.yml @@ -1,11 +1,13 @@ --- # Cop supports --auto-correct. Layout/FirstArrayElementIndentation: + Details: grace period Exclude: - 'lib/gitlab/email/message/in_product_marketing/trial.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/custom_issue_template_spec.rb' - 'spec/controllers/concerns/send_file_upload_spec.rb' - 'spec/graphql/types/packages/tag_type_spec.rb' + - 'spec/lib/gitlab/ci/config/external/mapper_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/reports/codequality_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/reports/codequality_reports_spec.rb' @@ -83,7 +85,6 @@ Layout/FirstArrayElementIndentation: - 'spec/models/concerns/noteable_spec.rb' - 'spec/models/diff_note_spec.rb' - 'spec/models/discussion_spec.rb' - - 'spec/models/group_group_link_spec.rb' - 'spec/models/group_spec.rb' - 'spec/models/integration_spec.rb' - 'spec/models/integrations/chat_message/issue_message_spec.rb' @@ -138,7 +139,6 @@ Layout/FirstArrayElementIndentation: - 'spec/services/repositories/changelog_service_spec.rb' - 'spec/services/resource_events/synthetic_milestone_notes_builder_service_spec.rb' - 'spec/services/security/merge_reports_service_spec.rb' - - 'spec/services/users/destroy_service_spec.rb' - 'spec/simplecov_env.rb' - 'spec/support/atlassian/jira_connect/schemata.rb' - 'spec/support/capybara.rb' diff --git a/.rubocop_todo/layout/leading_comment_space.yml b/.rubocop_todo/layout/leading_comment_space.yml new file mode 100644 index 00000000000..fda1d4ff30b --- /dev/null +++ b/.rubocop_todo/layout/leading_comment_space.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --auto-correct. +Layout/LeadingCommentSpace: + Exclude: + - 'config/initializers/kaminari_active_record_relation_methods_with_limit.rb' + - 'lib/uploaded_file.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 07eb9f99154..dd018402310 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -9,13 +9,11 @@ Layout/LineLength: - 'app/controllers/admin/impersonation_tokens_controller.rb' - 'app/controllers/admin/keys_controller.rb' - 'app/controllers/admin/projects_controller.rb' - - 'app/controllers/admin/runners_controller.rb' - 'app/controllers/admin/sessions_controller.rb' - 'app/controllers/admin/topics_controller.rb' - 'app/controllers/admin/users_controller.rb' - 'app/controllers/application_controller.rb' - 'app/controllers/boards/lists_controller.rb' - - 'app/controllers/clusters/clusters_controller.rb' - 'app/controllers/concerns/access_tokens_actions.rb' - 'app/controllers/concerns/analytics/cycle_analytics/stage_actions.rb' - 'app/controllers/concerns/clientside_preview_csp.rb' @@ -27,7 +25,6 @@ Layout/LineLength: - 'app/controllers/concerns/membership_actions.rb' - 'app/controllers/concerns/metrics_dashboard.rb' - 'app/controllers/concerns/notes_actions.rb' - - 'app/controllers/concerns/one_trust_csp.rb' - 'app/controllers/concerns/product_analytics_tracking.rb' - 'app/controllers/concerns/routable_actions.rb' - 'app/controllers/concerns/send_file_upload.rb' @@ -42,7 +39,6 @@ Layout/LineLength: - 'app/controllers/groups/dependency_proxy_for_containers_controller.rb' - 'app/controllers/groups/email_campaigns_controller.rb' - 'app/controllers/groups/group_members_controller.rb' - - 'app/controllers/groups/runners_controller.rb' - 'app/controllers/groups/settings/applications_controller.rb' - 'app/controllers/groups/settings/ci_cd_controller.rb' - 'app/controllers/groups/settings/integrations_controller.rb' @@ -59,7 +55,6 @@ Layout/LineLength: - 'app/controllers/import/gitlab_groups_controller.rb' - 'app/controllers/import/gitlab_projects_controller.rb' - 'app/controllers/invites_controller.rb' - - 'app/controllers/jira_connect/application_controller.rb' - 'app/controllers/jira_connect/events_controller.rb' - 'app/controllers/jira_connect/subscriptions_controller.rb' - 'app/controllers/jwt_controller.rb' @@ -84,7 +79,6 @@ Layout/LineLength: - 'app/controllers/projects/forks_controller.rb' - 'app/controllers/projects/google_cloud/gcp_regions_controller.rb' - 'app/controllers/projects/imports_controller.rb' - - 'app/controllers/projects/integrations/shimos_controller.rb' - 'app/controllers/projects/issues_controller.rb' - 'app/controllers/projects/jobs_controller.rb' - 'app/controllers/projects/labels_controller.rb' @@ -97,12 +91,10 @@ Layout/LineLength: - 'app/controllers/projects/notes_controller.rb' - 'app/controllers/projects/performance_monitoring/dashboards_controller.rb' - 'app/controllers/projects/pipeline_schedules_controller.rb' - - 'app/controllers/projects/pipelines/tests_controller.rb' - 'app/controllers/projects/pipelines_controller.rb' - 'app/controllers/projects/prometheus/metrics_controller.rb' - 'app/controllers/projects/raw_controller.rb' - 'app/controllers/projects/settings/ci_cd_controller.rb' - - 'app/controllers/projects/settings/operations_controller.rb' - 'app/controllers/projects/settings/repository_controller.rb' - 'app/controllers/projects/templates_controller.rb' - 'app/controllers/projects/tree_controller.rb' @@ -139,7 +131,6 @@ Layout/LineLength: - 'app/finders/security/security_jobs_finder.rb' - 'app/finders/todos_finder.rb' - 'app/finders/user_group_notification_settings_finder.rb' - - 'app/finders/user_recent_events_finder.rb' - 'app/graphql/batch_loaders/merge_request_diff_summary_batch_loader.rb' - 'app/graphql/mutations/alert_management/http_integration/create.rb' - 'app/graphql/mutations/alert_management/http_integration/http_integration_base.rb' @@ -162,7 +153,6 @@ Layout/LineLength: - 'app/graphql/mutations/merge_requests/set_labels.rb' - 'app/graphql/mutations/merge_requests/set_locked.rb' - 'app/graphql/mutations/merge_requests/set_milestone.rb' - - 'app/graphql/mutations/merge_requests/toggle_attention_requested.rb' - 'app/graphql/mutations/metrics/dashboard/annotations/create.rb' - 'app/graphql/mutations/namespace/package_settings/update.rb' - 'app/graphql/mutations/notes/create/note.rb' @@ -175,32 +165,20 @@ Layout/LineLength: - 'app/graphql/mutations/snippets/update.rb' - 'app/graphql/mutations/todos/create.rb' - 'app/graphql/mutations/todos/mark_all_done.rb' - - 'app/graphql/mutations/work_items/create.rb' - - 'app/graphql/mutations/work_items/create_from_task.rb' - - 'app/graphql/mutations/work_items/delete.rb' - - 'app/graphql/mutations/work_items/update.rb' - - 'app/graphql/resolvers/ci/job_token_scope_resolver.rb' - - 'app/graphql/resolvers/ci/runner_jobs_resolver.rb' - - 'app/graphql/resolvers/ci/runner_status_resolver.rb' - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - 'app/graphql/resolvers/container_repository_tags_resolver.rb' - - 'app/graphql/resolvers/group_packages_resolver.rb' - - 'app/graphql/resolvers/package_details_resolver.rb' - - 'app/graphql/resolvers/project_jobs_resolver.rb' - 'app/graphql/resolvers/project_merge_requests_resolver.rb' - 'app/graphql/resolvers/projects_resolver.rb' - 'app/graphql/resolvers/user_discussions_count_resolver.rb' - 'app/graphql/types/admin/sidekiq_queues/delete_jobs_response_type.rb' - 'app/graphql/types/alert_management/prometheus_integration_type.rb' - 'app/graphql/types/alert_management/status_enum.rb' - - 'app/graphql/types/base_field.rb' - 'app/graphql/types/boards/board_issuable_input_base_type.rb' - 'app/graphql/types/ci/job_artifact_file_type_enum.rb' - 'app/graphql/types/ci/job_type.rb' - 'app/graphql/types/ci/pipeline_config_source_enum.rb' - 'app/graphql/types/ci/pipeline_type.rb' - - 'app/graphql/types/ci/runner_membership_filter_enum.rb' - 'app/graphql/types/ci/runner_setup_type.rb' - 'app/graphql/types/ci/runner_status_enum.rb' - 'app/graphql/types/ci/runner_type.rb' @@ -234,7 +212,6 @@ Layout/LineLength: - 'app/graphql/types/packages/nuget/dependency_link_metadatum_type.rb' - 'app/graphql/types/packages/package_dependency_link_type.rb' - 'app/graphql/types/packages/package_details_type.rb' - - 'app/graphql/types/packages/package_type.rb' - 'app/graphql/types/packages/package_type_enum.rb' - 'app/graphql/types/packages/pypi/metadatum_type.rb' - 'app/graphql/types/project_type.rb' @@ -272,7 +249,6 @@ Layout/LineLength: - 'app/helpers/ide_helper.rb' - 'app/helpers/import_helper.rb' - 'app/helpers/in_product_marketing_helper.rb' - - 'app/helpers/integrations_helper.rb' - 'app/helpers/invite_members_helper.rb' - 'app/helpers/issuables_helper.rb' - 'app/helpers/jira_connect_helper.rb' @@ -305,7 +281,6 @@ Layout/LineLength: - 'app/helpers/tags_helper.rb' - 'app/helpers/timeboxes_helper.rb' - 'app/helpers/tree_helper.rb' - - 'app/helpers/users/callouts_helper.rb' - 'app/helpers/users_helper.rb' - 'app/helpers/version_check_helper.rb' - 'app/helpers/visibility_level_helper.rb' @@ -328,15 +303,12 @@ Layout/LineLength: - 'app/models/application_setting_implementation.rb' - 'app/models/award_emoji.rb' - 'app/models/blob_viewer/base.rb' - - 'app/models/broadcast_message.rb' - 'app/models/bulk_imports/entity.rb' - 'app/models/ci/build.rb' - 'app/models/ci/job_artifact.rb' - - 'app/models/ci/namespace_mirror.rb' - 'app/models/ci/pipeline.rb' - 'app/models/ci/pipeline_artifact.rb' - 'app/models/ci/runner.rb' - - 'app/models/ci/secure_file.rb' - 'app/models/ci/unit_test.rb' - 'app/models/clusters/agent.rb' - 'app/models/clusters/applications/cert_manager.rb' @@ -365,9 +337,7 @@ Layout/LineLength: - 'app/models/concerns/ignorable_columns.rb' - 'app/models/concerns/iid_routes.rb' - 'app/models/concerns/integrations/has_data_fields.rb' - - 'app/models/concerns/integrations/has_issue_tracker_fields.rb' - 'app/models/concerns/issuable.rb' - - 'app/models/concerns/limitable.rb' - 'app/models/concerns/mentionable/reference_regexes.rb' - 'app/models/concerns/milestoneable.rb' - 'app/models/concerns/noteable.rb' @@ -433,7 +403,6 @@ Layout/LineLength: - 'app/models/integrations/jira.rb' - 'app/models/integrations/mattermost.rb' - 'app/models/integrations/microsoft_teams.rb' - - 'app/models/integrations/mock_ci.rb' - 'app/models/integrations/pipelines_email.rb' - 'app/models/integrations/pivotaltracker.rb' - 'app/models/integrations/prometheus.rb' @@ -459,7 +428,6 @@ Layout/LineLength: - 'app/models/merge_request.rb' - 'app/models/merge_request_assignee.rb' - 'app/models/merge_request_diff.rb' - - 'app/models/merge_request_reviewer.rb' - 'app/models/merge_requests_closing_issues.rb' - 'app/models/metrics/dashboard/annotation.rb' - 'app/models/milestone.rb' @@ -495,9 +463,7 @@ Layout/LineLength: - 'app/models/repository.rb' - 'app/models/serverless/domain.rb' - 'app/models/service_desk_setting.rb' - - 'app/models/snippet.rb' - 'app/models/suggestion.rb' - - 'app/models/terraform/state.rb' - 'app/models/todo.rb' - 'app/models/upload.rb' - 'app/models/user.rb' @@ -519,7 +485,6 @@ Layout/LineLength: - 'app/presenters/merge_request_presenter.rb' - 'app/presenters/packages/composer/packages_presenter.rb' - 'app/presenters/packages/conan/package_presenter.rb' - - 'app/presenters/pages_domain_presenter.rb' - 'app/presenters/project_clusterable_presenter.rb' - 'app/presenters/project_presenter.rb' - 'app/presenters/snippet_blob_presenter.rb' @@ -536,25 +501,18 @@ Layout/LineLength: - 'app/serializers/merge_request_poll_cached_widget_entity.rb' - 'app/serializers/merge_request_poll_widget_entity.rb' - 'app/serializers/merge_request_sidebar_extras_entity.rb' - - 'app/serializers/merge_request_user_entity.rb' - 'app/serializers/merge_request_widget_entity.rb' - 'app/serializers/note_entity.rb' - 'app/serializers/project_note_entity.rb' - - 'app/serializers/prometheus_alert_entity.rb' - 'app/services/application_settings/update_service.rb' - 'app/services/auth/container_registry_authentication_service.rb' - - 'app/services/auto_merge/base_service.rb' - 'app/services/auto_merge/merge_when_pipeline_succeeds_service.rb' - 'app/services/boards/base_items_list_service.rb' - - 'app/services/boards/destroy_service.rb' - 'app/services/boards/issues/create_service.rb' - 'app/services/boards/issues/move_service.rb' - 'app/services/boards/lists/base_create_service.rb' - 'app/services/branches/delete_service.rb' - - 'app/services/bulk_create_integration_service.rb' - - 'app/services/bulk_imports/file_decompression_service.rb' - 'app/services/bulk_imports/uploads_export_service.rb' - - 'app/services/bulk_update_integration_service.rb' - 'app/services/ci/create_pipeline_service.rb' - 'app/services/ci/drop_pipeline_service.rb' - 'app/services/ci/generate_coverage_reports_service.rb' @@ -606,11 +564,8 @@ Layout/LineLength: - 'app/services/git/process_ref_changes_service.rb' - 'app/services/google_cloud/create_service_accounts_service.rb' - 'app/services/google_cloud/generate_pipeline_service.rb' - - 'app/services/google_cloud/service_accounts_service.rb' - 'app/services/groups/create_service.rb' - 'app/services/groups/destroy_service.rb' - - 'app/services/groups/import_export/import_service.rb' - - 'app/services/groups/open_issues_count_service.rb' - 'app/services/groups/transfer_service.rb' - 'app/services/groups/update_service.rb' - 'app/services/import/bitbucket_server_service.rb' @@ -640,7 +595,6 @@ Layout/LineLength: - 'app/services/lfs/unlock_file_service.rb' - 'app/services/loose_foreign_keys/batch_cleaner_service.rb' - 'app/services/loose_foreign_keys/cleaner_service.rb' - - 'app/services/members/approve_access_request_service.rb' - 'app/services/members/destroy_service.rb' - 'app/services/members/invitation_reminder_email_service.rb' - 'app/services/members/update_service.rb' @@ -649,10 +603,8 @@ Layout/LineLength: - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' - 'app/services/merge_requests/create_from_issue_service.rb' - - 'app/services/merge_requests/create_pipeline_service.rb' - 'app/services/merge_requests/merge_base_service.rb' - 'app/services/merge_requests/merge_service.rb' - - 'app/services/merge_requests/mergeability/run_checks_service.rb' - 'app/services/merge_requests/mergeability_check_service.rb' - 'app/services/merge_requests/push_options_handler_service.rb' - 'app/services/merge_requests/refresh_service.rb' @@ -665,7 +617,6 @@ Layout/LineLength: - 'app/services/milestones/destroy_service.rb' - 'app/services/namespace_settings/update_service.rb' - 'app/services/notes/build_service.rb' - - 'app/services/notes/copy_service.rb' - 'app/services/notes/quick_actions_service.rb' - 'app/services/notes/resolve_service.rb' - 'app/services/notification_recipients/builder/default.rb' @@ -687,7 +638,6 @@ Layout/LineLength: - 'app/services/packages/npm/create_package_service.rb' - 'app/services/packages/nuget/search_service.rb' - 'app/services/packages/nuget/update_package_from_metadata_service.rb' - - 'app/services/packages/rubygems/dependency_resolver_service.rb' - 'app/services/pages/migrate_from_legacy_storage_service.rb' - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' - 'app/services/personal_access_tokens/create_service.rb' @@ -718,7 +668,6 @@ Layout/LineLength: - 'app/services/repository_archive_clean_up_service.rb' - 'app/services/resource_access_tokens/create_service.rb' - 'app/services/resource_access_tokens/revoke_service.rb' - - 'app/services/resource_events/change_labels_service.rb' - 'app/services/search/global_service.rb' - 'app/services/search_service.rb' - 'app/services/security/ci_configuration/container_scanning_create_service.rb' @@ -727,7 +676,6 @@ Layout/LineLength: - 'app/services/security/ci_configuration/sast_iac_create_service.rb' - 'app/services/security/ci_configuration/sast_parser_service.rb' - 'app/services/security/ci_configuration/secret_detection_create_service.rb' - - 'app/services/service_ping/submit_service.rb' - 'app/services/snippets/count_service.rb' - 'app/services/snippets/create_service.rb' - 'app/services/spam/spam_action_service.rb' @@ -790,7 +738,6 @@ Layout/LineLength: - 'config/application.rb' - 'config/initializers/00_rails_disable_joins.rb' - 'config/initializers/01_secret_token.rb' - - 'config/initializers/0_marginalia.rb' - 'config/initializers/1_settings.rb' - 'config/initializers/5_backend.rb' - 'config/initializers/7_prometheus_metrics.rb' @@ -798,9 +745,7 @@ Layout/LineLength: - 'config/initializers/active_record_force_reconnects.rb' - 'config/initializers/active_record_keyset_pagination.rb' - 'config/initializers/active_record_schema_versions.rb' - - 'config/initializers/active_record_transaction_observer.rb' - 'config/initializers/carrierwave_patch.rb' - - 'config/initializers/content_security_policy.rb' - 'config/initializers/deprecations.rb' - 'config/initializers/devise_dynamic_password_length_validation.rb' - 'config/initializers/direct_upload_support.rb' @@ -812,10 +757,8 @@ Layout/LineLength: - 'config/initializers/pages_storage_check.rb' - 'config/initializers/rails_host_authorization.rb' - 'config/initializers/session_store.rb' - - 'config/initializers/sidekiq.rb' - 'config/initializers/validate_database_config.rb' - 'config/initializers/validate_puma.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - 'config/initializers/zz_metrics.rb' - 'config/object_store_settings.rb' - 'config/routes.rb' @@ -828,7 +771,6 @@ Layout/LineLength: - 'config/routes/uploads.rb' - 'config/routes/user.rb' - 'config/settings.rb' - - 'danger/ce_ee_vue_templates/Dangerfile' - 'danger/ci_config/Dangerfile' - 'danger/documentation/Dangerfile' - 'danger/feature_flag/Dangerfile' @@ -1122,35 +1064,28 @@ Layout/LineLength: - 'ee/app/controllers/concerns/credentials_inventory_actions.rb' - 'ee/app/controllers/concerns/ee/issuable_collections.rb' - 'ee/app/controllers/concerns/group_invite_members.rb' - - 'ee/app/controllers/concerns/insights_actions.rb' - - 'ee/app/controllers/ee/admin/dev_ops_report_controller.rb' - 'ee/app/controllers/ee/admin/users_controller.rb' - 'ee/app/controllers/ee/application_controller.rb' - 'ee/app/controllers/ee/groups/group_members_controller.rb' - 'ee/app/controllers/ee/groups_controller.rb' - 'ee/app/controllers/ee/projects/deploy_tokens_controller.rb' - - 'ee/app/controllers/ee/projects/pipelines_controller.rb' - 'ee/app/controllers/ee/projects/settings/operations_controller.rb' - 'ee/app/controllers/ee/projects/settings/repository_controller.rb' - 'ee/app/controllers/ee/projects_controller.rb' - 'ee/app/controllers/ee/repositories/git_http_client_controller.rb' - 'ee/app/controllers/ee/repositories/git_http_controller.rb' - 'ee/app/controllers/ee/repositories/lfs_api_controller.rb' - - 'ee/app/controllers/ee/sessions_controller.rb' - 'ee/app/controllers/groups/analytics/cycle_analytics/stages_controller.rb' - 'ee/app/controllers/groups/analytics/cycle_analytics/summary_controller.rb' - 'ee/app/controllers/groups/analytics/cycle_analytics/value_streams_controller.rb' - - 'ee/app/controllers/groups/analytics/cycle_analytics_controller.rb' - 'ee/app/controllers/groups/analytics/productivity_analytics_controller.rb' - 'ee/app/controllers/groups/hooks_controller.rb' - 'ee/app/controllers/groups/ldap_settings_controller.rb' - 'ee/app/controllers/groups/omniauth_callbacks_controller.rb' - 'ee/app/controllers/groups/saml_group_links_controller.rb' - 'ee/app/controllers/groups/sso_controller.rb' - - 'ee/app/controllers/groups/usage_quotas_controller.rb' - 'ee/app/controllers/oauth/geo_auth_controller.rb' - 'ee/app/controllers/operations_controller.rb' - - 'ee/app/controllers/profiles/usage_quotas_controller.rb' - 'ee/app/controllers/projects/audit_events_controller.rb' - 'ee/app/controllers/projects/insights_controller.rb' - 'ee/app/controllers/projects/integrations/zentao/issues_controller.rb' @@ -1160,7 +1095,6 @@ Layout/LineLength: - 'ee/app/controllers/projects/security/policies_controller.rb' - 'ee/app/controllers/projects/security/vulnerabilities/notes_controller.rb' - 'ee/app/controllers/subscriptions_controller.rb' - - 'ee/app/controllers/trial_registrations_controller.rb' - 'ee/app/controllers/trials_controller.rb' - 'ee/app/enums/vulnerabilities/dismissal_reason_enum.rb' - 'ee/app/finders/compliance_management/merge_requests/compliance_violations_finder.rb' @@ -1169,12 +1103,10 @@ Layout/LineLength: - 'ee/app/finders/merge_requests/by_approvers_finder.rb' - 'ee/app/finders/projects/integrations/jira/by_ids_finder.rb' - 'ee/app/finders/projects/integrations/jira/issues_finder.rb' - - 'ee/app/finders/security/findings_finder.rb' - 'ee/app/finders/security/pipeline_vulnerabilities_finder.rb' - 'ee/app/finders/security/vulnerabilities_finder.rb' - 'ee/app/graphql/ee/mutations/boards/lists/create.rb' - 'ee/app/graphql/ee/mutations/ci/runner/update.rb' - - 'ee/app/graphql/ee/mutations/issues/create.rb' - 'ee/app/graphql/ee/resolvers/base_issues_resolver.rb' - 'ee/app/graphql/mutations/analytics/devops_adoption/enabled_namespaces/bulk_enable.rb' - 'ee/app/graphql/mutations/audit_events/external_audit_event_destinations/create.rb' @@ -1194,7 +1126,6 @@ Layout/LineLength: - 'ee/app/graphql/mutations/incident_management/oncall_rotation/create.rb' - 'ee/app/graphql/mutations/incident_management/oncall_rotation/update.rb' - 'ee/app/graphql/mutations/instance_security_dashboard/remove_project.rb' - - 'ee/app/graphql/mutations/iterations/create.rb' - 'ee/app/graphql/mutations/iterations/update.rb' - 'ee/app/graphql/mutations/security/training_provider_update.rb' - 'ee/app/graphql/mutations/security_policy/assign_security_policy_project.rb' @@ -1209,13 +1140,11 @@ Layout/LineLength: - 'ee/app/graphql/resolvers/compliance_management/merge_requests/compliance_violation_resolver.rb' - 'ee/app/graphql/resolvers/concerns/resolves_orchestration_policy.rb' - 'ee/app/graphql/resolvers/dora_metrics_resolver.rb' - - 'ee/app/graphql/resolvers/epics_resolver.rb' - 'ee/app/graphql/resolvers/external_issue_resolver.rb' - 'ee/app/graphql/resolvers/incident_management/oncall_rotations_resolver.rb' - 'ee/app/graphql/resolvers/incident_management/oncall_schedule_resolver.rb' - 'ee/app/graphql/resolvers/iterations/cadences_resolver.rb' - 'ee/app/graphql/resolvers/iterations_resolver.rb' - - 'ee/app/graphql/resolvers/network_policy_resolver.rb' - 'ee/app/graphql/resolvers/security_orchestration/scan_execution_policy_resolver.rb' - 'ee/app/graphql/resolvers/security_report_summary_resolver.rb' - 'ee/app/graphql/resolvers/timebox_report_resolver.rb' @@ -1246,8 +1175,6 @@ Layout/LineLength: - 'ee/app/graphql/types/instance_security_dashboard_type.rb' - 'ee/app/graphql/types/iteration_sort_enum.rb' - 'ee/app/graphql/types/iteration_type.rb' - - 'ee/app/graphql/types/merge_requests/approval_state_type.rb' - - 'ee/app/graphql/types/network_policy_type.rb' - 'ee/app/graphql/types/scanned_resource_type.rb' - 'ee/app/graphql/types/security/training_url_request_status_enum.rb' - 'ee/app/graphql/types/security_orchestration/orchestration_policy_type.rb' @@ -1256,7 +1183,6 @@ Layout/LineLength: - 'ee/app/graphql/types/vulnerability/external_issue_link_external_tracker_enum.rb' - 'ee/app/graphql/types/vulnerability_confidence_enum.rb' - 'ee/app/graphql/types/vulnerability_detail_type.rb' - - 'ee/app/graphql/types/vulnerability_request_type.rb' - 'ee/app/graphql/types/vulnerability_type.rb' - 'ee/app/helpers/admin/emails_helper.rb' - 'ee/app/helpers/admin/ip_restriction_helper.rb' @@ -1264,7 +1190,6 @@ Layout/LineLength: - 'ee/app/helpers/analytics/code_review_helper.rb' - 'ee/app/helpers/billing_plans_helper.rb' - 'ee/app/helpers/ee/application_helper.rb' - - 'ee/app/helpers/ee/application_settings_helper.rb' - 'ee/app/helpers/ee/button_helper.rb' - 'ee/app/helpers/ee/environments_helper.rb' - 'ee/app/helpers/ee/feature_flags_helper.rb' @@ -1279,7 +1204,6 @@ Layout/LineLength: - 'ee/app/helpers/ee/lock_helper.rb' - 'ee/app/helpers/ee/merge_requests_helper.rb' - 'ee/app/helpers/ee/mirror_helper.rb' - - 'ee/app/helpers/ee/nav/top_nav_helper.rb' - 'ee/app/helpers/ee/notes_helper.rb' - 'ee/app/helpers/ee/personal_access_tokens_helper.rb' - 'ee/app/helpers/ee/profiles_helper.rb' @@ -1300,11 +1224,9 @@ Layout/LineLength: - 'ee/app/helpers/projects/security/dast_profiles_helper.rb' - 'ee/app/helpers/projects/security/discover_helper.rb' - 'ee/app/helpers/push_rules_helper.rb' - - 'ee/app/helpers/security_helper.rb' - 'ee/app/helpers/trial_status_widget_helper.rb' - 'ee/app/helpers/vulnerabilities_helper.rb' - 'ee/app/mailers/ee/emails/profile.rb' - - 'ee/app/mailers/ee/emails/projects.rb' - 'ee/app/mailers/ee/preview/notify_preview.rb' - 'ee/app/mailers/emails/namespace_storage_usage_mailer.rb' - 'ee/app/models/analytics/cycle_analytics/group_stage.rb' @@ -1346,7 +1268,6 @@ Layout/LineLength: - 'ee/app/models/ee/key.rb' - 'ee/app/models/ee/lfs_object.rb' - 'ee/app/models/ee/list.rb' - - 'ee/app/models/ee/member.rb' - 'ee/app/models/ee/merge_request/metrics.rb' - 'ee/app/models/ee/merge_request_diff.rb' - 'ee/app/models/ee/milestone_release.rb' @@ -1455,7 +1376,6 @@ Layout/LineLength: - 'ee/app/services/ee/auth/container_registry_authentication_service.rb' - 'ee/app/services/ee/boards/base_service.rb' - 'ee/app/services/ee/ci/job_artifacts/destroy_batch_service.rb' - - 'ee/app/services/ee/ci/queue/build_queue_service.rb' - 'ee/app/services/ee/ci/register_job_service.rb' - 'ee/app/services/ee/ci/retry_pipeline_service.rb' - 'ee/app/services/ee/groups/autocomplete_service.rb' @@ -1469,11 +1389,8 @@ Layout/LineLength: - 'ee/app/services/ee/issuable/common_system_notes_service.rb' - 'ee/app/services/ee/issues/base_service.rb' - 'ee/app/services/ee/issues/clone_service.rb' - - 'ee/app/services/ee/issues/move_service.rb' - - 'ee/app/services/ee/merge_requests/base_service.rb' - 'ee/app/services/ee/merge_requests/merge_base_service.rb' - 'ee/app/services/ee/merge_requests/refresh_service.rb' - - 'ee/app/services/ee/notification_service.rb' - 'ee/app/services/ee/personal_access_tokens/create_service.rb' - 'ee/app/services/ee/personal_access_tokens/revoke_service.rb' - 'ee/app/services/ee/projects/create_from_template_service.rb' @@ -1482,13 +1399,11 @@ Layout/LineLength: - 'ee/app/services/ee/projects/deploy_tokens/destroy_service.rb' - 'ee/app/services/ee/projects/gitlab_projects_import_service.rb' - 'ee/app/services/ee/projects/group_links/create_service.rb' - - 'ee/app/services/ee/projects/transfer_service.rb' - 'ee/app/services/ee/projects/update_service.rb' - 'ee/app/services/ee/protected_branches/api_service.rb' - 'ee/app/services/ee/protected_branches/create_service.rb' - 'ee/app/services/ee/protected_branches/update_service.rb' - 'ee/app/services/ee/resource_access_tokens/create_service.rb' - - 'ee/app/services/ee/resource_events/change_labels_service.rb' - 'ee/app/services/ee/system_note_service.rb' - 'ee/app/services/ee/users/update_service.rb' - 'ee/app/services/elastic/cluster_reindexing_service.rb' @@ -1496,7 +1411,6 @@ Layout/LineLength: - 'ee/app/services/epics/issue_promote_service.rb' - 'ee/app/services/epics/update_service.rb' - 'ee/app/services/external_status_checks/create_service.rb' - - 'ee/app/services/external_status_checks/dispatch_service.rb' - 'ee/app/services/geo/blob_upload_service.rb' - 'ee/app/services/geo/event_service.rb' - 'ee/app/services/geo/file_registry_removal_service.rb' @@ -1536,7 +1450,6 @@ Layout/LineLength: - 'ee/app/services/projects/licenses/create_policy_service.rb' - 'ee/app/services/projects/mark_for_deletion_service.rb' - 'ee/app/services/projects/update_mirror_service.rb' - - 'ee/app/services/requirements_management/update_requirement_service.rb' - 'ee/app/services/resource_events/change_weight_service.rb' - 'ee/app/services/security/auto_fix_service.rb' - 'ee/app/services/security/dependency_list_service.rb' @@ -1554,7 +1467,6 @@ Layout/LineLength: - 'ee/app/services/security/security_orchestration_policies/policy_configuration_validation_service.rb' - 'ee/app/services/security/security_orchestration_policies/process_policy_service.rb' - 'ee/app/services/security/security_orchestration_policies/project_create_service.rb' - - 'ee/app/services/security/security_orchestration_policies/rule_schedule_service.rb' - 'ee/app/services/security/security_orchestration_policies/validate_policy_service.rb' - 'ee/app/services/security/store_scan_service.rb' - 'ee/app/services/security/track_scan_service.rb' @@ -1563,7 +1475,6 @@ Layout/LineLength: - 'ee/app/services/system_notes/escalations_service.rb' - 'ee/app/services/timebox_report_service.rb' - 'ee/app/services/vulnerabilities/base_service.rb' - - 'ee/app/services/vulnerabilities/confirm_service.rb' - 'ee/app/services/vulnerabilities/dismiss_service.rb' - 'ee/app/services/vulnerabilities/historical_statistics/adjustment_service.rb' - 'ee/app/services/vulnerabilities/resolve_service.rb' @@ -1626,11 +1537,6 @@ Layout/LineLength: - 'ee/db/geo/migrate/20211124000002_add_indexes_to_lfs_object_registry.rb' - 'ee/db/geo/migrate/20211207162157_add_indexes_to_pages_deployment_registry.rb' - 'ee/db/geo/post_migrate/20220202101354_migrate_job_artifact_registry.rb' - - 'ee/elastic/migrate/20210302104500_migrate_notes_to_separate_index.rb' - - 'ee/elastic/migrate/20210421140400_add_new_data_to_merge_requests_documents.rb' - - 'ee/elastic/migrate/20210429154500_migrate_merge_requests_to_separate_index.rb' - - 'ee/elastic/migrate/20210510113500_delete_merge_requests_from_original_index.rb' - - 'ee/elastic/migrate/20210510143200_delete_notes_from_original_index.rb' - 'ee/lib/analytics/devops_adoption/snapshot_calculator.rb' - 'ee/lib/analytics/productivity_analytics_request_params.rb' - 'ee/lib/api/analytics/code_review_analytics.rb' @@ -1645,9 +1551,7 @@ Layout/LineLength: - 'ee/lib/api/group_push_rule.rb' - 'ee/lib/api/group_repository_storage_moves.rb' - 'ee/lib/api/helpers/project_approval_rules_helpers.rb' - - 'ee/lib/api/iterations.rb' - 'ee/lib/api/license.rb' - - 'ee/lib/api/managed_licenses.rb' - 'ee/lib/api/merge_request_approval_rules.rb' - 'ee/lib/api/merge_request_approval_settings.rb' - 'ee/lib/api/project_approval_rules.rb' @@ -1688,7 +1592,6 @@ Layout/LineLength: - 'ee/lib/ee/api/namespaces.rb' - 'ee/lib/ee/api/protected_branches.rb' - 'ee/lib/ee/audit/project_changes_auditor.rb' - - 'ee/lib/ee/audit/protected_branches_changes_auditor.rb' - 'ee/lib/ee/banzai/filter/references/iteration_reference_filter.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/aggregated/base_query_builder.rb' - 'ee/lib/ee/gitlab/analytics/cycle_analytics/data_collector.rb' @@ -1703,13 +1606,10 @@ Layout/LineLength: - 'ee/lib/ee/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' - 'ee/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_namespace_statistics.rb' - 'ee/lib/ee/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - - 'ee/lib/ee/gitlab/background_migration/populate_status_column_of_security_scans.rb' - 'ee/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings.rb' - 'ee/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'ee/lib/ee/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - - 'ee/lib/ee/gitlab/checks/diff_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/commit_check.rb' - 'ee/lib/ee/gitlab/checks/push_rules/file_size_check.rb' - 'ee/lib/ee/gitlab/ci/config_ee.rb' @@ -1719,7 +1619,6 @@ Layout/LineLength: - 'ee/lib/ee/gitlab/ci/reports/security/reports.rb' - 'ee/lib/ee/gitlab/ci/status/build/manual.rb' - 'ee/lib/ee/gitlab/git_access.rb' - - 'ee/lib/ee/gitlab/graphql/pagination/keyset/order_info.rb' - 'ee/lib/ee/gitlab/import_export/after_export_strategies/custom_template_export_import_strategy.rb' - 'ee/lib/ee/gitlab/middleware/read_only/controller.rb' - 'ee/lib/ee/gitlab/project_template.rb' @@ -1741,7 +1640,6 @@ Layout/LineLength: - 'ee/lib/elastic/latest/git_instance_proxy.rb' - 'ee/lib/elastic/latest/issue_class_proxy.rb' - 'ee/lib/elastic/latest/issue_instance_proxy.rb' - - 'ee/lib/elastic/latest/merge_request_class_proxy.rb' - 'ee/lib/elastic/latest/note_class_proxy.rb' - 'ee/lib/elastic/latest/project_class_proxy.rb' - 'ee/lib/elastic/latest/repository_class_proxy.rb' @@ -1758,7 +1656,6 @@ Layout/LineLength: - 'ee/lib/gitlab/analytics/cycle_analytics/stage_events/merge_request_label_removed.rb' - 'ee/lib/gitlab/analytics/cycle_analytics/summary/base_time.rb' - 'ee/lib/gitlab/analytics/cycle_analytics/summary/group/deployment_frequency.rb' - - 'ee/lib/gitlab/analytics/cycle_analytics/summary/lead_time.rb' - 'ee/lib/gitlab/auth/group_saml/response_check.rb' - 'ee/lib/gitlab/auth/group_saml/session_enforcer.rb' - 'ee/lib/gitlab/auth/group_saml/user.rb' @@ -1843,7 +1740,6 @@ Layout/LineLength: - 'ee/spec/controllers/projects/analytics/cycle_analytics/summary_controller_spec.rb' - 'ee/spec/controllers/projects/audit_events_controller_spec.rb' - 'ee/spec/controllers/projects/dependencies_controller_spec.rb' - - 'ee/spec/controllers/projects/insights_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/jira/issues_controller_spec.rb' - 'ee/spec/controllers/projects/integrations/zentao/issues_controller_spec.rb' - 'ee/spec/controllers/projects/issues_controller_spec.rb' @@ -1862,11 +1758,6 @@ Layout/LineLength: - 'ee/spec/controllers/registrations/welcome_controller_spec.rb' - 'ee/spec/controllers/subscriptions/groups_controller_spec.rb' - 'ee/spec/controllers/subscriptions_controller_spec.rb' - - 'ee/spec/elastic/migrate/20210201104800_migrate_notes_to_separate_index_spec.rb' - - 'ee/spec/elastic/migrate/20210421140400_add_new_data_to_merge_requests_documents_spec.rb' - - 'ee/spec/elastic/migrate/20210429154500_migrate_merge_requests_to_separate_index_spec.rb' - - 'ee/spec/elastic/migrate/20210510113500_delete_merge_requests_from_original_index_spec.rb' - - 'ee/spec/elastic/migrate/20210510143200_delete_notes_from_original_index_spec.rb' - 'ee/spec/elastic/migrate/migration_shared_examples.rb' - 'ee/spec/factories/ci/builds.rb' - 'ee/spec/factories/ci/job_artifacts.rb' @@ -1878,7 +1769,6 @@ Layout/LineLength: - 'ee/spec/factories/geo/container_repository_registry.rb' - 'ee/spec/factories/iterations.rb' - 'ee/spec/factories/namespaces.rb' - - 'ee/spec/factories/requirements_management/requirements.rb' - 'ee/spec/factories/vulnerabilities/exports.rb' - 'ee/spec/factories/vulnerabilities/findings.rb' - 'ee/spec/features/admin/admin_audit_logs_spec.rb' @@ -1897,7 +1787,6 @@ Layout/LineLength: - 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb' - 'ee/spec/features/boards/user_visits_board_spec.rb' - 'ee/spec/features/burnup_charts_spec.rb' - - 'ee/spec/features/ci_shared_runner_warnings_spec.rb' - 'ee/spec/features/dashboards/operations_spec.rb' - 'ee/spec/features/epic_boards/epic_boards_spec.rb' - 'ee/spec/features/epics/epic_issues_spec.rb' @@ -1934,7 +1823,6 @@ Layout/LineLength: - 'ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb' - 'ee/spec/features/issues/form_spec.rb' - 'ee/spec/features/issues/issue_sidebar_spec.rb' - - 'ee/spec/features/issues/user_sees_empty_state_spec.rb' - 'ee/spec/features/labels_hierarchy_spec.rb' - 'ee/spec/features/merge_request/user_approves_spec.rb' - 'ee/spec/features/merge_request/user_approves_with_password_spec.rb' @@ -1949,7 +1837,6 @@ Layout/LineLength: - 'ee/spec/features/merge_trains/user_adds_to_merge_train_when_pipeline_succeeds_spec.rb' - 'ee/spec/features/pending_group_memberships_spec.rb' - 'ee/spec/features/projects/audit_events_spec.rb' - - 'ee/spec/features/projects/custom_projects_template_spec.rb' - 'ee/spec/features/projects/feature_flags/user_sees_feature_flag_list_spec.rb' - 'ee/spec/features/projects/feature_flags/user_updates_feature_flag_spec.rb' - 'ee/spec/features/projects/integrations/prometheus_custom_metrics_spec.rb' @@ -1982,7 +1869,6 @@ Layout/LineLength: - 'ee/spec/finders/analytics/devops_adoption/enabled_namespaces_finder_spec.rb' - 'ee/spec/finders/analytics/devops_adoption/snapshots_finder_spec.rb' - 'ee/spec/finders/audit_event_finder_spec.rb' - - 'ee/spec/finders/billed_users_finder_spec.rb' - 'ee/spec/finders/boards/users_finder_spec.rb' - 'ee/spec/finders/compliance_management/merge_requests/compliance_violations_finder_spec.rb' - 'ee/spec/finders/custom_project_templates_finder_spec.rb' @@ -2033,14 +1919,12 @@ Layout/LineLength: - 'ee/spec/graphql/ee/types/board_type_spec.rb' - 'ee/spec/graphql/ee/types/issue_sort_enum_spec.rb' - 'ee/spec/graphql/ee/types/merge_request_type_spec.rb' - - 'ee/spec/graphql/ee/types/mutation_type_spec.rb' - 'ee/spec/graphql/mutations/boards/epic_boards/create_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' - 'ee/spec/graphql/mutations/boards/lists/update_limit_metrics_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/update_spec.rb' - 'ee/spec/graphql/mutations/dast/profiles/run_spec.rb' - 'ee/spec/graphql/mutations/dast_on_demand_scans/create_spec.rb' - - 'ee/spec/graphql/mutations/dast_scanner_profiles/delete_spec.rb' - 'ee/spec/graphql/mutations/dast_scanner_profiles/update_spec.rb' - 'ee/spec/graphql/mutations/dast_site_profiles/create_spec.rb' - 'ee/spec/graphql/mutations/dast_site_profiles/update_spec.rb' @@ -2078,7 +1962,6 @@ Layout/LineLength: - 'ee/spec/graphql/resolvers/iterations/cadences_resolver_spec.rb' - 'ee/spec/graphql/resolvers/iterations_resolver_spec.rb' - 'ee/spec/graphql/resolvers/network_policy_resolver_spec.rb' - - 'ee/spec/graphql/resolvers/path_locks_resolver_spec.rb' - 'ee/spec/graphql/resolvers/pipeline_security_report_findings_resolver_spec.rb' - 'ee/spec/graphql/resolvers/requirements_management/requirements_resolver_spec.rb' - 'ee/spec/graphql/resolvers/requirements_management/test_reports_resolver_spec.rb' @@ -2091,7 +1974,6 @@ Layout/LineLength: - 'ee/spec/graphql/resolvers/vulnerabilities_resolver_spec.rb' - 'ee/spec/graphql/resolvers/vulnerability_severities_count_resolver_spec.rb' - 'ee/spec/graphql/types/alert_management/payload_alert_field_name_enum_spec.rb' - - 'ee/spec/graphql/types/asset_type_spec.rb' - 'ee/spec/graphql/types/ci/minutes/namespace_monthly_usage_type_spec.rb' - 'ee/spec/graphql/types/dast/profile_schedule_type_spec.rb' - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' @@ -2099,20 +1981,14 @@ Layout/LineLength: - 'ee/spec/graphql/types/epic_sort_enum_spec.rb' - 'ee/spec/graphql/types/incident_management/escalation_rule_input_type_spec.rb' - 'ee/spec/graphql/types/issue_type_spec.rb' - - 'ee/spec/graphql/types/network_policy_type_spec.rb' - 'ee/spec/graphql/types/permission_types/vulnerability_spec.rb' - 'ee/spec/graphql/types/pipeline_security_report_finding_type_spec.rb' - 'ee/spec/graphql/types/project_type_spec.rb' - 'ee/spec/graphql/types/security_scanner_type_enum_spec.rb' - 'ee/spec/graphql/types/vulnerability_details/file_location_type_spec.rb' - - 'ee/spec/graphql/types/vulnerability_evidence_source_type_spec.rb' - - 'ee/spec/graphql/types/vulnerability_evidence_supporting_message_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_evidence_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_report_type_enum_spec.rb' - - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' - - 'ee/spec/graphql/types/vulnerability_request_type_spec.rb' - 'ee/spec/graphql/types/vulnerability_response_type_spec.rb' - - 'ee/spec/graphql/types/vulnerability_sort_enum_spec.rb' - 'ee/spec/graphql/types/vulnerability_type_spec.rb' - 'ee/spec/helpers/admin/emails_helper_spec.rb' - 'ee/spec/helpers/analytics/code_review_helper_spec.rb' @@ -2127,7 +2003,6 @@ Layout/LineLength: - 'ee/spec/helpers/ee/feature_flags_helper_spec.rb' - 'ee/spec/helpers/ee/gitlab_routing_helper_spec.rb' - 'ee/spec/helpers/ee/groups/group_members_helper_spec.rb' - - 'ee/spec/helpers/ee/groups/settings_helper_spec.rb' - 'ee/spec/helpers/ee/groups_helper_spec.rb' - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/ee/issuables_helper_spec.rb' @@ -2138,7 +2013,6 @@ Layout/LineLength: - 'ee/spec/helpers/ee/projects/pipeline_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/api_fuzzing_configuration_helper_spec.rb' - 'ee/spec/helpers/ee/projects/security/dast_configuration_helper_spec.rb' - - 'ee/spec/helpers/ee/registrations_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - 'ee/spec/helpers/ee/users/callouts_helper_spec.rb' - 'ee/spec/helpers/ee/version_check_helper_spec.rb' @@ -2156,9 +2030,7 @@ Layout/LineLength: - 'ee/spec/helpers/projects/security/dast_profiles_helper_spec.rb' - 'ee/spec/helpers/projects_helper_spec.rb' - 'ee/spec/helpers/push_rules_helper_spec.rb' - - 'ee/spec/helpers/routing/pseudonymization_helper_spec.rb' - 'ee/spec/helpers/search_helper_spec.rb' - - 'ee/spec/helpers/security_helper_spec.rb' - 'ee/spec/helpers/subscriptions_helper_spec.rb' - 'ee/spec/helpers/timeboxes_helper_spec.rb' - 'ee/spec/helpers/vulnerabilities_helper_spec.rb' @@ -2176,7 +2048,6 @@ Layout/LineLength: - 'ee/spec/lib/bulk_imports/projects/pipelines/push_rule_pipeline_spec.rb' - 'ee/spec/lib/compliance_management/merge_request_approval_settings/resolver_spec.rb' - 'ee/spec/lib/container_registry/client_spec.rb' - - 'ee/spec/lib/ee/api/entities/billable_member_spec.rb' - 'ee/spec/lib/ee/api/entities/deployment_extended_spec.rb' - 'ee/spec/lib/ee/api/entities/vulnerability_export_spec.rb' - 'ee/spec/lib/ee/api/helpers_spec.rb' @@ -2231,7 +2102,6 @@ Layout/LineLength: - 'ee/spec/lib/ee/sidebars/projects/menus/security_compliance_menu_spec.rb' - 'ee/spec/lib/elastic/latest/config_shared_examples.rb' - 'ee/spec/lib/elastic/latest/custom_language_analyzers_spec.rb' - - 'ee/spec/lib/elastic/latest/git_class_proxy_spec.rb' - 'ee/spec/lib/elastic/multi_version_class_proxy_spec.rb' - 'ee/spec/lib/elastic/multi_version_instance_proxy_spec.rb' - 'ee/spec/lib/gem_extensions/elasticsearch/model/adapter/active_record/records_spec.rb' @@ -2289,7 +2159,6 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/custom_file_templates_spec.rb' - 'ee/spec/lib/gitlab/data_builder/vulnerability_spec.rb' - 'ee/spec/lib/gitlab/elastic/bulk_indexer_spec.rb' - - 'ee/spec/lib/gitlab/elastic/client_spec.rb' - 'ee/spec/lib/gitlab/elastic/group_search_results_spec.rb' - 'ee/spec/lib/gitlab/elastic/indexer_spec.rb' - 'ee/spec/lib/gitlab/elastic/project_search_results_spec.rb' @@ -2298,7 +2167,6 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/email/handler/create_note_handler_spec.rb' - 'ee/spec/lib/gitlab/email/message/account_validation_spec.rb' - 'ee/spec/lib/gitlab/expiring_subscription_message_spec.rb' - - 'ee/spec/lib/gitlab/geo/cron_manager_spec.rb' - 'ee/spec/lib/gitlab/geo/event_gap_tracking_spec.rb' - 'ee/spec/lib/gitlab/geo/geo_tasks_spec.rb' - 'ee/spec/lib/gitlab/geo/git_ssh_proxy_spec.rb' @@ -2319,7 +2187,6 @@ Layout/LineLength: - 'ee/spec/lib/gitlab/graphql/aggregations/vulnerabilities/lazy_user_notes_count_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb' - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' - - 'ee/spec/lib/gitlab/graphql/pagination/keyset/order_info_spec.rb' - 'ee/spec/lib/gitlab/import_export/attributes_permitter_spec.rb' - 'ee/spec/lib/gitlab/import_export/group/group_and_descendants_repo_restorer_spec.rb' - 'ee/spec/lib/gitlab/insights/finders/issuable_finder_spec.rb' @@ -2395,7 +2262,6 @@ Layout/LineLength: - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - 'ee/spec/models/ci/minutes/project_monthly_usage_spec.rb' - 'ee/spec/models/ci/pipeline_spec.rb' - - 'ee/spec/models/ci/subscriptions/project_spec.rb' - 'ee/spec/models/concerns/ee/clusters/agents/authorization_config_scopes_spec.rb' - 'ee/spec/models/concerns/ee/issuable_spec.rb' - 'ee/spec/models/concerns/ee/noteable_spec.rb' @@ -2427,7 +2293,6 @@ Layout/LineLength: - 'ee/spec/models/ee/audit_event_spec.rb' - 'ee/spec/models/ee/ci/job_artifact_spec.rb' - 'ee/spec/models/ee/ci/pipeline_artifact_spec.rb' - - 'ee/spec/models/ee/ci/runner_spec.rb' - 'ee/spec/models/ee/group_spec.rb' - 'ee/spec/models/ee/incident_management/project_incident_management_setting_spec.rb' - 'ee/spec/models/ee/integrations/jira_spec.rb' @@ -2452,7 +2317,6 @@ Layout/LineLength: - 'ee/spec/models/epic_spec.rb' - 'ee/spec/models/geo/container_repository_registry_spec.rb' - 'ee/spec/models/geo/event_log_spec.rb' - - 'ee/spec/models/geo/job_artifact_registry_spec.rb' - 'ee/spec/models/geo/package_file_registry_spec.rb' - 'ee/spec/models/geo/project_registry_spec.rb' - 'ee/spec/models/geo/secondary_usage_data_spec.rb' @@ -2469,7 +2333,6 @@ Layout/LineLength: - 'ee/spec/models/incident_management/oncall_shift_spec.rb' - 'ee/spec/models/instance_security_dashboard_spec.rb' - 'ee/spec/models/integrations/chat_message/vulnerability_message_spec.rb' - - 'ee/spec/models/integrations/github_spec.rb' - 'ee/spec/models/issuable_sla_spec.rb' - 'ee/spec/models/issue_spec.rb' - 'ee/spec/models/license_spec.rb' @@ -2522,15 +2385,12 @@ Layout/LineLength: - 'ee/spec/presenters/audit_event_presenter_spec.rb' - 'ee/spec/presenters/ci/build_runner_presenter_spec.rb' - 'ee/spec/presenters/ci/pipeline_presenter_spec.rb' - - 'ee/spec/presenters/ee/issue_presenter_spec.rb' - 'ee/spec/presenters/epic_issue_presenter_spec.rb' - 'ee/spec/presenters/epic_presenter_spec.rb' - 'ee/spec/presenters/group_member_presenter_spec.rb' - 'ee/spec/presenters/merge_request_presenter_spec.rb' - 'ee/spec/presenters/security/scan_presenter_spec.rb' - - 'ee/spec/presenters/vulnerabilities/finding_presenter_spec.rb' - 'ee/spec/presenters/vulnerability_presenter_spec.rb' - - 'ee/spec/replicators/geo/upload_replicator_spec.rb' - 'ee/spec/requests/admin/credentials_controller_spec.rb' - 'ee/spec/requests/admin/geo/replicables_controller_spec.rb' - 'ee/spec/requests/admin/user_permission_exports_controller_spec.rb' @@ -2586,7 +2446,6 @@ Layout/LineLength: - 'ee/spec/requests/api/graphql/mutations/epic_tree/reorder_spec.rb' - 'ee/spec/requests/api/graphql/mutations/epics/add_issue_spec.rb' - 'ee/spec/requests/api/graphql/mutations/issues/create_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/issues/set_weight_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/cadences/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/iterations/update_spec.rb' @@ -2686,8 +2545,6 @@ Layout/LineLength: - 'ee/spec/serializers/environment_entity_spec.rb' - 'ee/spec/serializers/epic_entity_spec.rb' - 'ee/spec/serializers/fork_namespace_entity_spec.rb' - - 'ee/spec/serializers/integrations/jira_serializers/issue_detail_entity_spec.rb' - - 'ee/spec/serializers/integrations/jira_serializers/issue_entity_spec.rb' - 'ee/spec/serializers/member_entity_spec.rb' - 'ee/spec/serializers/project_mirror_entity_spec.rb' - 'ee/spec/serializers/security/license_policy_entity_spec.rb' @@ -2728,7 +2585,6 @@ Layout/LineLength: - 'ee/spec/services/approval_rules/create_service_spec.rb' - 'ee/spec/services/approval_rules/finalize_service_spec.rb' - 'ee/spec/services/approval_rules/params_filtering_service_spec.rb' - - 'ee/spec/services/arkose/user_verification_service_spec.rb' - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/register_runner_audit_event_service_spec.rb' - 'ee/spec/services/audit_events/release_associate_milestone_audit_event_service_spec.rb' @@ -2767,7 +2623,6 @@ Layout/LineLength: - 'ee/spec/services/ee/groups/import_export/export_service_spec.rb' - 'ee/spec/services/ee/ip_restrictions/update_service_spec.rb' - 'ee/spec/services/ee/issuable/common_system_notes_service_spec.rb' - - 'ee/spec/services/ee/issuable/destroy_service_spec.rb' - 'ee/spec/services/ee/issue_links/create_service_spec.rb' - 'ee/spec/services/ee/issues/clone_service_spec.rb' - 'ee/spec/services/ee/issues/create_from_vulnerability_data_service_spec.rb' @@ -2860,7 +2715,6 @@ Layout/LineLength: - 'ee/spec/services/projects/alerting/notify_service_spec.rb' - 'ee/spec/services/projects/cleanup_service_spec.rb' - 'ee/spec/services/projects/gitlab_projects_import_service_spec.rb' - - 'ee/spec/services/projects/group_links/create_service_spec.rb' - 'ee/spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - 'ee/spec/services/projects/import_export/export_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' @@ -2869,7 +2723,6 @@ Layout/LineLength: - 'ee/spec/services/projects/update_service_spec.rb' - 'ee/spec/services/quick_actions/interpret_service_spec.rb' - 'ee/spec/services/requirements_management/export_csv_service_spec.rb' - - 'ee/spec/services/requirements_management/update_requirement_service_spec.rb' - 'ee/spec/services/resource_events/change_weight_service_spec.rb' - 'ee/spec/services/search/global_service_spec.rb' - 'ee/spec/services/search/group_service_spec.rb' @@ -2886,7 +2739,6 @@ Layout/LineLength: - 'ee/spec/services/security/ingestion/tasks/ingest_findings_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_identifiers_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_remediations_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerability_flags_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerability_statistics_spec.rb' - 'ee/spec/services/security/merge_reports_service_spec.rb' @@ -2916,13 +2768,11 @@ Layout/LineLength: - 'ee/spec/services/timebox_report_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/services/user_permissions/export_service_spec.rb' - - 'ee/spec/services/vulnerabilities/destroy_dismissal_feedback_service_spec.rb' - 'ee/spec/services/vulnerabilities/dismiss_service_spec.rb' - 'ee/spec/services/vulnerabilities/finding_dismiss_service_spec.rb' - 'ee/spec/services/vulnerabilities/historical_statistics/adjustment_service_spec.rb' - 'ee/spec/services/vulnerabilities/manually_create_service_spec.rb' - 'ee/spec/services/vulnerabilities/revert_to_detected_service_spec.rb' - - 'ee/spec/services/vulnerabilities/starboard_vulnerability_resolve_service_spec.rb' - 'ee/spec/services/vulnerabilities/statistics/adjustment_service_spec.rb' - 'ee/spec/services/vulnerabilities/update_service_spec.rb' - 'ee/spec/services/vulnerability_exports/create_service_spec.rb' @@ -2953,7 +2803,6 @@ Layout/LineLength: - 'ee/spec/support/shared_examples/controllers/concerns/description_diff_actions_shared_examples.rb' - 'ee/spec/support/shared_examples/controllers/projects/license_scanning_report_comparison_shared_examples.rb' - 'ee/spec/support/shared_examples/features/epics_filtered_search_shared_examples.rb' - - 'ee/spec/support/shared_examples/features/over_free_user_limit_shared_examples.rb' - 'ee/spec/support/shared_examples/features/protected_branches_access_control_shared_examples.rb' - 'ee/spec/support/shared_examples/features/sidebar_shared_examples.rb' - 'ee/spec/support/shared_examples/finders/geo/file_registry_finder_shared_examples.rb' @@ -2977,8 +2826,6 @@ Layout/LineLength: - 'ee/spec/support/shared_examples/quick_actions/merge_request/unassign_reviewer_shared_examples.rb' - 'ee/spec/support/shared_examples/requests/api/graphql/geo/registries_shared_examples.rb' - 'ee/spec/support/shared_examples/requests/api/project_approval_rules_api_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/alert_management/alert_processing/alert_firing_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/alert_management/alert_processing/alert_recovery_shared_examples.rb' - 'ee/spec/support/shared_examples/services/base_sync_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/boards/base_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/build_execute_shared_examples.rb' @@ -2986,10 +2833,8 @@ Layout/LineLength: - 'ee/spec/support/shared_examples/services/dast_on_demand_scans_shared_examples.rb' - 'ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/group_saml/saml_provider/base_service_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/issue_epic_shared_examples.rb' - 'ee/spec/support/shared_examples/services/scoped_label_shared_examples.rb' - 'ee/spec/support/shared_examples/services/search_notes_shared_examples.rb' - - 'ee/spec/support/shared_examples/services/sync_issue_and_requirement_state_shared_examples.rb' - 'ee/spec/support/shared_examples/services/vulnerabilities/calls_vulnerability_statistics_utility_services_in_order.rb' - 'ee/spec/support/shared_examples/views/subscription_shared_examples.rb' - 'ee/spec/tasks/geo/git_rake_spec.rb' @@ -3016,13 +2861,10 @@ Layout/LineLength: - 'ee/spec/views/shared/credentials_inventory/personal_access_tokens/_personal_access_token.html.haml_spec.rb' - 'ee/spec/views/shared/credentials_inventory/project_access_tokens/_project_access_token.html.haml_spec.rb' - 'ee/spec/views/shared/promotions/_promotion_link_project.html.haml_spec.rb' - - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - - 'ee/spec/views/trial_registrations/new.html.haml_spec.rb' - 'ee/spec/workers/active_user_count_threshold_worker_spec.rb' - 'ee/spec/workers/adjourned_group_deletion_worker_spec.rb' - 'ee/spec/workers/adjourned_projects_deletion_cron_worker_spec.rb' - 'ee/spec/workers/analytics/cycle_analytics/consistency_worker_spec.rb' - - 'ee/spec/workers/analytics/cycle_analytics/incremental_worker_spec.rb' - 'ee/spec/workers/analytics/devops_adoption/create_all_snapshots_worker_spec.rb' - 'ee/spec/workers/analytics/devops_adoption/create_snapshot_worker_spec.rb' - 'ee/spec/workers/app_sec/dast/profile_schedule_worker_spec.rb' @@ -3061,8 +2903,6 @@ Layout/LineLength: - 'ee/spec/workers/new_epic_worker_spec.rb' - 'ee/spec/workers/refresh_license_compliance_checks_worker_spec.rb' - 'ee/spec/workers/repository_import_worker_spec.rb' - - 'ee/spec/workers/scan_security_report_secrets_worker_spec.rb' - - 'ee/spec/workers/security/create_orchestration_policy_worker_spec.rb' - 'ee/spec/workers/security/orchestration_policy_rule_schedule_namespace_worker_spec.rb' - 'ee/spec/workers/security/orchestration_policy_rule_schedule_worker_spec.rb' - 'ee/spec/workers/store_security_reports_worker_spec.rb' @@ -3116,7 +2956,6 @@ Layout/LineLength: - 'lib/api/generic_packages.rb' - 'lib/api/go_proxy.rb' - 'lib/api/group_clusters.rb' - - 'lib/api/group_container_repositories.rb' - 'lib/api/group_import.rb' - 'lib/api/group_labels.rb' - 'lib/api/group_packages.rb' @@ -3131,7 +2970,6 @@ Layout/LineLength: - 'lib/api/helpers/file_upload_helpers.rb' - 'lib/api/helpers/groups_helpers.rb' - 'lib/api/helpers/integrations_helpers.rb' - - 'lib/api/helpers/internal_helpers.rb' - 'lib/api/helpers/label_helpers.rb' - 'lib/api/helpers/members_helpers.rb' - 'lib/api/helpers/merge_requests_helpers.rb' @@ -3228,7 +3066,6 @@ Layout/LineLength: - 'lib/container_registry/base_client.rb' - 'lib/declarative_enum.rb' - 'lib/error_tracking/collector/payload_validator.rb' - - 'lib/error_tracking/sentry_client/issue.rb' - 'lib/feature.rb' - 'lib/feature/definition.rb' - 'lib/file_size_validator.rb' @@ -3265,7 +3102,6 @@ Layout/LineLength: - 'lib/gitlab/background_migration/backfill_snippet_repositories.rb' - 'lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy.rb' - 'lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects.rb' - - 'lib/gitlab/background_migration/copy_column_using_background_migration_job.rb' - 'lib/gitlab/background_migration/create_security_setting.rb' - 'lib/gitlab/background_migration/drop_invalid_remediations.rb' - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' @@ -3285,7 +3121,6 @@ Layout/LineLength: - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_encrypted_values_on_projects.rb' - - 'lib/gitlab/background_migration/reset_duplicate_ci_runners_token_values_on_projects.rb' - 'lib/gitlab/background_migration/update_vulnerability_occurrences_location.rb' - 'lib/gitlab/batch_pop_queueing.rb' - 'lib/gitlab/bitbucket_import/importer.rb' @@ -3342,7 +3177,6 @@ Layout/LineLength: - 'lib/gitlab/config/entry/configurable.rb' - 'lib/gitlab/config/entry/validators.rb' - 'lib/gitlab/config_checker/external_database_checker.rb' - - 'lib/gitlab/config_checker/puma_rugged_checker.rb' - 'lib/gitlab/conflict/file.rb' - 'lib/gitlab/conflict/file_collection.rb' - 'lib/gitlab/content_security_policy/config_loader.rb' @@ -3350,7 +3184,6 @@ Layout/LineLength: - 'lib/gitlab/current_settings.rb' - 'lib/gitlab/cycle_analytics/summary/deploy.rb' - 'lib/gitlab/cycle_analytics/summary/deployment_frequency.rb' - - 'lib/gitlab/data_builder/push.rb' - 'lib/gitlab/database.rb' - 'lib/gitlab/database/as_with_materialized.rb' - 'lib/gitlab/database/async_indexes/migration_helpers.rb' @@ -3361,7 +3194,6 @@ Layout/LineLength: - 'lib/gitlab/database/batch_counter.rb' - 'lib/gitlab/database/count/reltuples_count_strategy.rb' - 'lib/gitlab/database/gitlab_schema.rb' - - 'lib/gitlab/database/load_balancing/configuration.rb' - 'lib/gitlab/database/load_balancing/host.rb' - 'lib/gitlab/database/migration_helpers.rb' - 'lib/gitlab/database/migration_helpers/cascading_namespace_settings.rb' @@ -3369,11 +3201,9 @@ Layout/LineLength: - 'lib/gitlab/database/migrations/background_migration_helpers.rb' - 'lib/gitlab/database/migrations/batched_background_migration_helpers.rb' - 'lib/gitlab/database/migrations/runner.rb' - - 'lib/gitlab/database/migrations/test_background_runner.rb' - 'lib/gitlab/database/partitioning/detached_partition_dropper.rb' - 'lib/gitlab/database/partitioning/partition_monitoring.rb' - 'lib/gitlab/database/partitioning/replace_table.rb' - - 'lib/gitlab/database/partitioning/single_numeric_list_partition.rb' - 'lib/gitlab/database/partitioning/time_partition.rb' - 'lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb' - 'lib/gitlab/database/partitioning_migration_helpers/table_management_helpers.rb' @@ -3384,7 +3214,6 @@ Layout/LineLength: - 'lib/gitlab/database/postgres_partition.rb' - 'lib/gitlab/database/postgres_partitioned_table.rb' - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' - - 'lib/gitlab/database/query_analyzers/restrict_allowed_schemas.rb' - 'lib/gitlab/database/reflection.rb' - 'lib/gitlab/database/reindexing.rb' - 'lib/gitlab/database/reindexing/coordinator.rb' @@ -3405,13 +3234,11 @@ Layout/LineLength: - 'lib/gitlab/diff/formatters/base_formatter.rb' - 'lib/gitlab/diff/highlight_cache.rb' - 'lib/gitlab/diff/parser.rb' - - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' - 'lib/gitlab/email/failure_handler.rb' - 'lib/gitlab/email/handler/create_issue_handler.rb' - 'lib/gitlab/email/handler/create_merge_request_handler.rb' - 'lib/gitlab/email/message/in_product_marketing/base.rb' - 'lib/gitlab/email/message/in_product_marketing/create.rb' - - 'lib/gitlab/email/message/in_product_marketing/experience.rb' - 'lib/gitlab/email/message/in_product_marketing/helper.rb' - 'lib/gitlab/email/message/in_product_marketing/team.rb' - 'lib/gitlab/email/message/in_product_marketing/trial.rb' @@ -3443,7 +3270,6 @@ Layout/LineLength: - 'lib/gitlab/git_access.rb' - 'lib/gitlab/git_access_project.rb' - 'lib/gitlab/git_access_snippet.rb' - - 'lib/gitlab/git_access_wiki.rb' - 'lib/gitlab/gitaly_client.rb' - 'lib/gitlab/gitaly_client/blob_service.rb' - 'lib/gitlab/gitaly_client/call.rb' @@ -3468,8 +3294,6 @@ Layout/LineLength: - 'lib/gitlab/gpg/invalid_gpg_signature_updater.rb' - 'lib/gitlab/grape_logging/formatters/lograge_with_timestamp.rb' - 'lib/gitlab/grape_logging/loggers/client_env_logger.rb' - - 'lib/gitlab/graphql/pagination/keyset/generic_keyset_pagination.rb' - - 'lib/gitlab/graphql/pagination/keyset/query_builder.rb' - 'lib/gitlab/graphql/timeout.rb' - 'lib/gitlab/group_search_results.rb' - 'lib/gitlab/hashed_storage/migrator.rb' @@ -3517,10 +3341,8 @@ Layout/LineLength: - 'lib/gitlab/metrics/dashboard/stages/custom_metrics_details_inserter.rb' - 'lib/gitlab/metrics/dashboard/stages/metric_endpoint_inserter.rb' - 'lib/gitlab/metrics/dashboard/stages/variable_endpoint_inserter.rb' - - 'lib/gitlab/metrics/dashboard/url.rb' - 'lib/gitlab/metrics/dashboard/validator.rb' - 'lib/gitlab/metrics/dashboard/validator/errors.rb' - - 'lib/gitlab/metrics/rails_slis.rb' - 'lib/gitlab/metrics/samplers/action_cable_sampler.rb' - 'lib/gitlab/metrics/samplers/puma_sampler.rb' - 'lib/gitlab/metrics/samplers/ruby_sampler.rb' @@ -3588,7 +3410,6 @@ Layout/LineLength: - 'lib/gitlab/usage/metrics/aggregates/aggregate.rb' - 'lib/gitlab/usage/metrics/aggregates/sources/calculations/intersection.rb' - 'lib/gitlab/usage/metrics/aggregates/sources/postgres_hll.rb' - - 'lib/gitlab/usage/metrics/instrumentations/database_metric.rb' - 'lib/gitlab/usage/metrics/name_suggestion.rb' - 'lib/gitlab/usage/metrics/names_suggestions/generator.rb' - 'lib/gitlab/usage/service_ping_report.rb' @@ -3616,12 +3437,8 @@ Layout/LineLength: - 'lib/security/ci_configuration/base_build_action.rb' - 'lib/security/ci_configuration/sast_build_action.rb' - 'lib/sidebars/groups/menus/packages_registries_menu.rb' - - 'lib/sidebars/groups/menus/settings_menu.rb' - 'lib/sidebars/menu_item.rb' - - 'lib/sidebars/projects/menus/infrastructure_menu.rb' - - 'lib/sidebars/projects/menus/packages_registries_menu.rb' - 'lib/sidebars/projects/menus/repository_menu.rb' - - 'lib/sidebars/projects/panel.rb' - 'lib/system_check/app/orphaned_group_members_check.rb' - 'lib/system_check/app/redis_version_check.rb' - 'lib/system_check/incoming_email/mail_room_enabled_check.rb' @@ -3638,7 +3455,6 @@ Layout/LineLength: - 'lib/tasks/gitlab/info.rake' - 'lib/tasks/gitlab/packages/events.rake' - 'lib/tasks/gitlab/packages/migrate.rake' - - 'lib/tasks/gitlab/pages.rake' - 'lib/tasks/gitlab/seed/group_seed.rake' - 'lib/tasks/gitlab/shell.rake' - 'lib/tasks/gitlab/sidekiq.rake' @@ -3667,8 +3483,6 @@ Layout/LineLength: - 'qa/qa/git/repository.rb' - 'qa/qa/page/base.rb' - 'qa/qa/page/component/ci_badge_link.rb' - - 'qa/qa/page/component/design_management.rb' - - 'qa/qa/page/component/invite_members_modal.rb' - 'qa/qa/page/component/issuable/sidebar.rb' - 'qa/qa/page/component/select2.rb' - 'qa/qa/page/dashboard/snippet/index.rb' @@ -3677,14 +3491,12 @@ Layout/LineLength: - 'qa/qa/page/group/settings/package_registries.rb' - 'qa/qa/page/merge_request/new.rb' - 'qa/qa/page/project/import/repo_by_url.rb' - - 'qa/qa/page/project/issue/index.rb' - 'qa/qa/page/project/registry/show.rb' - 'qa/qa/page/project/settings/protected_branches.rb' - 'qa/qa/page/project/web_ide/edit.rb' - 'qa/qa/resource/api_fabricator.rb' - 'qa/qa/resource/file.rb' - 'qa/qa/resource/members.rb' - - 'qa/qa/resource/project.rb' - 'qa/qa/resource/protected_branch.rb' - 'qa/qa/resource/registry_repository.rb' - 'qa/qa/resource/repository/push.rb' @@ -3697,28 +3509,19 @@ Layout/LineLength: - 'qa/qa/resource/wiki/group_page.rb' - 'qa/qa/runtime/api/repository_storage_moves.rb' - 'qa/qa/runtime/application_settings.rb' - - 'qa/qa/runtime/browser.rb' - 'qa/qa/runtime/env.rb' - 'qa/qa/runtime/feature.rb' - 'qa/qa/runtime/fixtures.rb' - 'qa/qa/runtime/ip_address.rb' - 'qa/qa/runtime/search.rb' - 'qa/qa/scenario/bootable.rb' - - 'qa/qa/scenario/template.rb' - 'qa/qa/service/cluster_provider/gcloud.rb' - 'qa/qa/service/cluster_provider/k3s.rb' - - 'qa/qa/service/kubernetes_cluster.rb' - 'qa/qa/service/praefect_manager.rb' - 'qa/qa/specs/features/api/1_manage/project_access_token_spec.rb' - 'qa/qa/specs/features/api/1_manage/rate_limits_spec.rb' - 'qa/qa/specs/features/api/1_manage/user_access_termination_spec.rb' - 'qa/qa/specs/features/api/1_manage/users_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/changing_repository_storage_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/distributed_reads_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_connectivity_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_dataloss_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_replication_queue_spec.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/praefect_repo_sync_spec.rb' - 'qa/qa/specs/features/api/3_create/integrations/webhook_events_spec.rb' - 'qa/qa/specs/features/api/3_create/merge_request/push_options_labels_spec.rb' - 'qa/qa/specs/features/api/3_create/merge_request/push_options_mwps_spec.rb' @@ -3730,7 +3533,6 @@ Layout/LineLength: - 'qa/qa/specs/features/api/4_verify/cancel_pipeline_when_block_user_spec.rb' - 'qa/qa/specs/features/api/5_package/container_registry_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/group/create_group_with_mattermost_team_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_recovery_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/2fa_ssh_recovery_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/log_in_with_2fa_spec.rb' @@ -3739,15 +3541,12 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/1_manage/login/maintain_log_in_mixed_env_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/create_project_badge_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/dashboard_images_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/project/invite_group_to_project_spec.rb' - - 'qa/qa/specs/features/browser_ui/1_manage/project/project_access_token_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/follow_user_activity_spec.rb' - 'qa/qa/specs/features/browser_ui/1_manage/user/user_access_termination_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/email/trigger_email_notification_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/collapse_comments_in_discussions_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/comment_issue_spec.rb' - - 'qa/qa/specs/features/browser_ui/2_plan/issue/create_issue_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/custom_issue_template_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/export_as_csv_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/issue/filter_issue_comments_spec.rb' @@ -3756,8 +3555,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/2_plan/issue/real_time_assignee_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/related_issues/related_issues_spec.rb' - 'qa/qa/specs/features/browser_ui/2_plan/transient/comment_on_discussion_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/design_management/add_design_content_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/design_management/modify_design_content_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/jenkins/jenkins_build_status_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/jira/jira_basic_integration_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_via_template_spec.rb' @@ -3781,7 +3578,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/3_create/repository/push_http_private_token_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_lfs_over_http_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_mirroring_over_http_spec.rb' - - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_file_size_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_http_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_over_ssh_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/repository/push_protected_branch_spec.rb' @@ -3815,7 +3611,6 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/mr_event_rule_pipeline_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pass_dotenv_variables_to_downstream_via_bridge_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_branch_switcher_spec.rb' - - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/run_pipeline_with_manual_jobs_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/trigger_matrix_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/pipeline/update_ci_file_with_pipeline_editor_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/runner/register_runner_spec.rb' @@ -3834,20 +3629,10 @@ Layout/LineLength: - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/pypi_repository_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/rubygems_registry_spec.rb' - - 'qa/qa/specs/features/browser_ui/6_release/pages/pages_pipeline_spec.rb' - - 'qa/qa/specs/features/browser_ui/7_configure/kubernetes/kubernetes_integration_spec.rb' - - 'qa/qa/specs/features/ee/api/12_geo/geo_nodes_spec.rb' - 'qa/qa/specs/features/ee/api/1_manage/user/minimal_access_user_spec.rb' - 'qa/qa/specs/features/ee/api/2_plan/epics_milestone_dates_spec.rb' - 'qa/qa/specs/features/ee/api/3_create/wiki/group_wiki_repository_storage_move_spec.rb' - 'qa/qa/specs/features/ee/api/7_configure/kubernetes/kubernetes_agent_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/advanced_global_advanced_syntax_search_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/elasticsearch_api_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/issues_index/issue_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/main_index/blob_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/merge_request_index/merge_request_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/notes_index/note_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/nightly_elasticsearch_test_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/10_protect/policies_list_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/cloud_activation_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/license/license_spec.rb' @@ -3856,24 +3641,9 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/purchase_storage_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/upgrade_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/purchase/user_registration_billing_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/attachment_replication_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/database_delete_replication_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_ci_job_log_artifacts_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_maven_package_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_npm_registry_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_project_snippets_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/http_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/http_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/ssh_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/ssh_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_http_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_http_push_to_secondary_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_ssh_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_ssh_push_to_secondary_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/create_merge_request_with_secure_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/license_compliance_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/13_secure/merge_request_license_widget_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/vulnerability_management_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' @@ -3882,12 +3652,10 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_enforced_sso_new_account_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_saml_non_enforced_sso_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/prevent_forking_outside_group_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/share_group_with_group_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/instance/instance_audit_logs_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/ldap/admin_ldap_sync_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_audit_logs_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/1_manage/project/project_templates_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/user/minimal_access_user_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/burndown_chart/burndown_chart_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/custom_email/custom_email_spec.rb' @@ -3901,7 +3669,6 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/2_plan/issue_boards/sum_of_issues_weights_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/issues_analytics/issues_analytics_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/issues_weight/issue_weight_visualization_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/2_plan/iterations/assign_group_iteration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/iterations/create_group_iteration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/four_assignees_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/2_plan/multiple_assignees_for_issues/more_than_four_assignees_spec.rb' @@ -3922,32 +3689,21 @@ Layout/LineLength: - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/transient/merge_trains_transient_bug_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/5_package/dependency_proxy_sso_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/9_enablement/elasticsearch/elasticsearch_reindexing_spec.rb' - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/specs/parallel_runner.rb' - - 'qa/qa/specs/runner.rb' - 'qa/qa/support/loglinking.rb' - - 'qa/qa/support/page_error_checker.rb' - 'qa/qa/support/run.rb' - 'qa/qa/support/ssh.rb' - - 'qa/qa/support/wait_for_requests.rb' - 'qa/qa/tools/delete_projects.rb' - 'qa/qa/tools/delete_subgroups.rb' - 'qa/qa/tools/delete_test_ssh_keys.rb' - 'qa/qa/tools/delete_test_users.rb' - 'qa/qa/tools/generate_perf_testdata.rb' - 'qa/qa/tools/initialize_gitlab_auth.rb' - - 'qa/qa/tools/revoke_all_personal_access_tokens.rb' - - 'qa/qa/tools/test_resources_handler.rb' - - 'qa/qa/vendor/jenkins/page/configure_job.rb' - - 'qa/qa/vendor/jenkins/page/login.rb' - 'qa/spec/git/repository_spec.rb' - - 'qa/spec/page/logging_spec.rb' - 'qa/spec/resource/api_fabricator_spec.rb' - 'qa/spec/runtime/env_spec.rb' - 'qa/spec/runtime/feature_spec.rb' - - 'qa/spec/scenario/template_spec.rb' - - 'qa/spec/spec_helper.rb' - 'qa/spec/specs/helpers/context_selector_spec.rb' - 'qa/spec/specs/helpers/quarantine_spec.rb' - 'qa/spec/specs/runner_spec.rb' @@ -3968,10 +3724,8 @@ Layout/LineLength: - 'rubocop/cop/migration/safer_boolean_column.rb' - 'rubocop/cop/migration/versioned_migration_class.rb' - 'rubocop/cop/migration/with_lock_retries_disallowed_method.rb' - - 'rubocop/cop/performance/ar_exists_and_present_blank.rb' - 'rubocop/cop/qa/selector_usage.rb' - 'rubocop/cop/rspec/top_level_describe_path.rb' - - 'rubocop/cop/static_translation_definition.rb' - 'rubocop/cop/usage_data/large_table.rb' - 'scripts/api/cancel_pipeline.rb' - 'scripts/api/download_job_artifact.rb' @@ -3993,9 +3747,7 @@ Layout/LineLength: - 'sidekiq_cluster/cli.rb' - 'sidekiq_cluster/sidekiq_cluster.rb' - 'spec/benchmarks/banzai_benchmark.rb' - - 'spec/commands/metrics_server/metrics_server_spec.rb' - 'spec/commands/sidekiq_cluster/cli_spec.rb' - - 'spec/components/pajamas/alert_component_spec.rb' - 'spec/config/metrics/aggregates/aggregated_metrics_spec.rb' - 'spec/config/settings_spec.rb' - 'spec/controllers/admin/application_settings_controller_spec.rb' @@ -4025,7 +3777,6 @@ Layout/LineLength: - 'spec/controllers/groups/milestones_controller_spec.rb' - 'spec/controllers/groups/releases_controller_spec.rb' - 'spec/controllers/groups/settings/applications_controller_spec.rb' - - 'spec/controllers/groups/settings/ci_cd_controller_spec.rb' - 'spec/controllers/groups/settings/integrations_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/import/available_namespaces_controller_spec.rb' @@ -4035,12 +3786,9 @@ Layout/LineLength: - 'spec/controllers/import/fogbugz_controller_spec.rb' - 'spec/controllers/import/gitea_controller_spec.rb' - 'spec/controllers/import/github_controller_spec.rb' - - 'spec/controllers/import/gitlab_controller_spec.rb' - 'spec/controllers/invites_controller_spec.rb' - - 'spec/controllers/jira_connect/app_descriptor_controller_spec.rb' - 'spec/controllers/jira_connect/events_controller_spec.rb' - 'spec/controllers/jira_connect/subscriptions_controller_spec.rb' - - 'spec/controllers/metrics_controller_spec.rb' - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/passwords_controller_spec.rb' - 'spec/controllers/profiles/accounts_controller_spec.rb' @@ -4104,7 +3852,6 @@ Layout/LineLength: - 'spec/controllers/uploads_controller_spec.rb' - 'spec/db/schema_spec.rb' - 'spec/deprecation_toolkit_env.rb' - - 'spec/experiments/application_experiment_spec.rb' - 'spec/experiments/concerns/project_commit_count_spec.rb' - 'spec/experiments/require_verification_for_namespace_creation_experiment_spec.rb' - 'spec/factories/ci/builds.rb' @@ -4133,7 +3880,6 @@ Layout/LineLength: - 'spec/features/admin/admin_sees_project_statistics_spec.rb' - 'spec/features/admin/admin_settings_spec.rb' - 'spec/features/admin/admin_users_spec.rb' - - 'spec/features/admin/users/user_spec.rb' - 'spec/features/alert_management/user_filters_alerts_by_status_spec.rb' - 'spec/features/alert_management/user_updates_alert_status_spec.rb' - 'spec/features/alert_management_spec.rb' @@ -4148,7 +3894,6 @@ Layout/LineLength: - 'spec/features/boards/user_visits_board_spec.rb' - 'spec/features/calendar_spec.rb' - 'spec/features/callouts/registration_enabled_spec.rb' - - 'spec/features/clusters/cluster_detail_page_spec.rb' - 'spec/features/commits_spec.rb' - 'spec/features/contextual_sidebar_spec.rb' - 'spec/features/cycle_analytics_spec.rb' @@ -4174,7 +3919,6 @@ Layout/LineLength: - 'spec/features/groups/milestones_sorting_spec.rb' - 'spec/features/groups/packages_spec.rb' - 'spec/features/groups/settings/access_tokens_spec.rb' - - 'spec/features/groups/settings/group_badges_spec.rb' - 'spec/features/groups/settings/repository_spec.rb' - 'spec/features/groups_spec.rb' - 'spec/features/ide/static_object_external_storage_csp_spec.rb' @@ -4189,7 +3933,6 @@ Layout/LineLength: - 'spec/features/issues/csv_spec.rb' - 'spec/features/issues/filtered_search/filter_issues_spec.rb' - 'spec/features/issues/filtered_search/recent_searches_spec.rb' - - 'spec/features/issues/filtered_search/visual_tokens_spec.rb' - 'spec/features/issues/form_spec.rb' - 'spec/features/issues/gfm_autocomplete_spec.rb' - 'spec/features/issues/issue_detail_spec.rb' @@ -4204,7 +3947,6 @@ Layout/LineLength: - 'spec/features/issues/user_sees_empty_state_spec.rb' - 'spec/features/issues/user_sees_live_update_spec.rb' - 'spec/features/issues/user_views_issue_spec.rb' - - 'spec/features/jira_connect/subscriptions_spec.rb' - 'spec/features/labels_hierarchy_spec.rb' - 'spec/features/markdown/copy_as_gfm_spec.rb' - 'spec/features/markdown/gitlab_flavored_markdown_spec.rb' @@ -4312,7 +4054,6 @@ Layout/LineLength: - 'spec/features/projects/releases/user_views_edit_release_spec.rb' - 'spec/features/projects/releases/user_views_releases_spec.rb' - 'spec/features/projects/settings/access_tokens_spec.rb' - - 'spec/features/projects/settings/project_badges_spec.rb' - 'spec/features/projects/settings/project_settings_spec.rb' - 'spec/features/projects/settings/registry_settings_spec.rb' - 'spec/features/projects/settings/service_desk_setting_spec.rb' @@ -4323,12 +4064,9 @@ Layout/LineLength: - 'spec/features/projects/show/schema_markup_spec.rb' - 'spec/features/projects/show/user_sees_deletion_failure_message_spec.rb' - 'spec/features/projects/show/user_sees_setup_shortcut_buttons_spec.rb' - - 'spec/features/projects/tags/user_edits_tags_spec.rb' - 'spec/features/projects/terraform_spec.rb' - 'spec/features/projects/tree/upload_file_spec.rb' - - 'spec/features/projects/view_on_env_spec.rb' - 'spec/features/projects_spec.rb' - - 'spec/features/runners_spec.rb' - 'spec/features/search/user_searches_for_comments_spec.rb' - 'spec/features/search/user_searches_for_merge_requests_spec.rb' - 'spec/features/search/user_searches_for_projects_spec.rb' @@ -4342,19 +4080,16 @@ Layout/LineLength: - 'spec/features/snippets/spam_snippets_spec.rb' - 'spec/features/snippets/user_edits_snippet_spec.rb' - 'spec/features/task_lists_spec.rb' - - 'spec/features/topic_show_spec.rb' - 'spec/features/unsubscribe_links_spec.rb' - 'spec/features/user_sorts_things_spec.rb' - 'spec/features/users/login_spec.rb' - 'spec/features/users/overview_spec.rb' - - 'spec/features/users/show_spec.rb' - 'spec/features/users/signup_spec.rb' - 'spec/features/users/user_browses_projects_on_user_page_spec.rb' - 'spec/features/webauthn_spec.rb' - 'spec/finders/access_requests_finder_spec.rb' - 'spec/finders/admin/projects_finder_spec.rb' - 'spec/finders/alert_management/alerts_finder_spec.rb' - - 'spec/finders/applications_finder_spec.rb' - 'spec/finders/autocomplete/users_finder_spec.rb' - 'spec/finders/award_emojis_finder_spec.rb' - 'spec/finders/branches_finder_spec.rb' @@ -4375,8 +4110,6 @@ Layout/LineLength: - 'spec/finders/group_projects_finder_spec.rb' - 'spec/finders/groups/user_groups_finder_spec.rb' - 'spec/finders/groups_finder_spec.rb' - - 'spec/finders/issues_finder_spec.rb' - - 'spec/finders/keys_finder_spec.rb' - 'spec/finders/labels_finder_spec.rb' - 'spec/finders/members_finder_spec.rb' - 'spec/finders/merge_requests/by_approvals_finder_spec.rb' @@ -4386,7 +4119,6 @@ Layout/LineLength: - 'spec/finders/milestones_finder_spec.rb' - 'spec/finders/namespaces/projects_finder_spec.rb' - 'spec/finders/notes_finder_spec.rb' - - 'spec/finders/packages/build_infos_finder_spec.rb' - 'spec/finders/packages/go/version_finder_spec.rb' - 'spec/finders/packages/group_packages_finder_spec.rb' - 'spec/finders/packages/maven/package_finder_spec.rb' @@ -4409,8 +4141,6 @@ Layout/LineLength: - 'spec/finders/user_recent_events_finder_spec.rb' - 'spec/finders/users_finder_spec.rb' - 'spec/frontend/fixtures/api_deploy_keys.rb' - - 'spec/frontend/fixtures/blob.rb' - - 'spec/frontend/fixtures/deploy_keys.rb' - 'spec/frontend/fixtures/freeze_period.rb' - 'spec/frontend/fixtures/issues.rb' - 'spec/frontend/fixtures/jobs.rb' @@ -4419,7 +4149,6 @@ Layout/LineLength: - 'spec/frontend/fixtures/pipeline_schedules.rb' - 'spec/frontend/fixtures/projects.rb' - 'spec/frontend/fixtures/snippet.rb' - - 'spec/graphql/features/feature_flag_spec.rb' - 'spec/graphql/gitlab_schema_spec.rb' - 'spec/graphql/mutations/boards/issues/issue_move_list_spec.rb' - 'spec/graphql/mutations/ci/job_token_scope/add_project_spec.rb' @@ -4428,10 +4157,7 @@ Layout/LineLength: - 'spec/graphql/mutations/clusters/agents/create_spec.rb' - 'spec/graphql/mutations/commits/create_spec.rb' - 'spec/graphql/mutations/container_expiration_policies/update_spec.rb' - - 'spec/graphql/mutations/custom_emoji/create_spec.rb' - 'spec/graphql/mutations/customer_relations/contacts/create_spec.rb' - - 'spec/graphql/mutations/customer_relations/contacts/update_spec.rb' - - 'spec/graphql/mutations/customer_relations/organizations/create_spec.rb' - 'spec/graphql/mutations/customer_relations/organizations/update_spec.rb' - 'spec/graphql/mutations/discussions/toggle_resolve_spec.rb' - 'spec/graphql/mutations/groups/update_spec.rb' @@ -4446,7 +4172,6 @@ Layout/LineLength: - 'spec/graphql/mutations/releases/update_spec.rb' - 'spec/graphql/mutations/saved_replies/create_spec.rb' - 'spec/graphql/mutations/saved_replies/update_spec.rb' - - 'spec/graphql/mutations/security/ci_configuration/base_security_analyzer_spec.rb' - 'spec/graphql/mutations/security/ci_configuration/configure_sast_spec.rb' - 'spec/graphql/resolvers/admin/analytics/usage_trends/measurements_resolver_spec.rb' - 'spec/graphql/resolvers/alert_management/alert_resolver_spec.rb' @@ -4485,15 +4210,12 @@ Layout/LineLength: - 'spec/graphql/types/base_field_spec.rb' - 'spec/graphql/types/commit_type_spec.rb' - 'spec/graphql/types/container_expiration_policy_type_spec.rb' - - 'spec/graphql/types/container_repository_details_type_spec.rb' - - 'spec/graphql/types/container_repository_type_spec.rb' - 'spec/graphql/types/environment_type_spec.rb' - 'spec/graphql/types/global_id_type_spec.rb' - 'spec/graphql/types/group_type_spec.rb' - 'spec/graphql/types/issue_sort_enum_spec.rb' - 'spec/graphql/types/issue_type_spec.rb' - 'spec/graphql/types/merge_request_type_spec.rb' - - 'spec/graphql/types/mutation_type_spec.rb' - 'spec/graphql/types/packages/helm/metadata_type_spec.rb' - 'spec/graphql/types/packages/package_dependency_type_enum_spec.rb' - 'spec/graphql/types/packages/package_group_sort_enum_spec.rb' @@ -4552,7 +4274,6 @@ Layout/LineLength: - 'spec/helpers/projects/security/configuration_helper_spec.rb' - 'spec/helpers/projects_helper_spec.rb' - 'spec/helpers/registrations_helper_spec.rb' - - 'spec/helpers/routing/pseudonymization_helper_spec.rb' - 'spec/helpers/search_helper_spec.rb' - 'spec/helpers/sidebars_helper_spec.rb' - 'spec/helpers/sidekiq_helper_spec.rb' @@ -4572,7 +4293,6 @@ Layout/LineLength: - 'spec/helpers/wiki_page_version_helper_spec.rb' - 'spec/initializers/00_rails_disable_joins_spec.rb' - 'spec/initializers/6_validations_spec.rb' - - 'spec/initializers/carrierwave_patch_spec.rb' - 'spec/initializers/direct_upload_support_spec.rb' - 'spec/initializers/global_id_spec.rb' - 'spec/initializers/lograge_spec.rb' @@ -4581,7 +4301,6 @@ Layout/LineLength: - 'spec/initializers/secret_token_spec.rb' - 'spec/initializers/session_store_spec.rb' - 'spec/initializers/settings_spec.rb' - - 'spec/initializers/trusted_proxies_spec.rb' - 'spec/lib/api/entities/ci/pipeline_spec.rb' - 'spec/lib/api/entities/project_import_status_spec.rb' - 'spec/lib/api/entities/projects/repository_storage_move_spec.rb' @@ -4597,7 +4316,6 @@ Layout/LineLength: - 'spec/lib/api/helpers/rate_limiter_spec.rb' - 'spec/lib/api/helpers_spec.rb' - 'spec/lib/atlassian/jira_connect/client_spec.rb' - - 'spec/lib/atlassian/jira_connect/serializers/feature_flag_entity_spec.rb' - 'spec/lib/atlassian/jira_issue_key_extractor_spec.rb' - 'spec/lib/backup/files_spec.rb' - 'spec/lib/backup/gitaly_backup_spec.rb' @@ -4607,7 +4325,6 @@ Layout/LineLength: - 'spec/lib/banzai/filter/ascii_doc_post_processing_filter_spec.rb' - 'spec/lib/banzai/filter/ascii_doc_sanitization_filter_spec.rb' - 'spec/lib/banzai/filter/broadcast_message_sanitization_filter_spec.rb' - - 'spec/lib/banzai/filter/custom_emoji_filter_spec.rb' - 'spec/lib/banzai/filter/external_link_filter_spec.rb' - 'spec/lib/banzai/filter/gollum_tags_filter_spec.rb' - 'spec/lib/banzai/filter/image_link_filter_spec.rb' @@ -4656,7 +4373,6 @@ Layout/LineLength: - 'spec/lib/bulk_imports/projects/pipelines/external_pull_requests_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/issues_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_feature_pipeline_spec.rb' - - 'spec/lib/bulk_imports/projects/pipelines/project_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/protected_branches_pipeline_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/snippets_pipeline_spec.rb' - 'spec/lib/bulk_imports/users_mapper_spec.rb' @@ -4666,7 +4382,6 @@ Layout/LineLength: - 'spec/lib/csv_builder_spec.rb' - 'spec/lib/declarative_enum_spec.rb' - 'spec/lib/error_tracking/sentry_client/issue_link_spec.rb' - - 'spec/lib/error_tracking/sentry_client/issue_spec.rb' - 'spec/lib/error_tracking/sentry_client/pagination_parser_spec.rb' - 'spec/lib/error_tracking/sentry_client/projects_spec.rb' - 'spec/lib/event_filter_spec.rb' @@ -4707,7 +4422,6 @@ Layout/LineLength: - 'spec/lib/gitlab/background_migration/backfill_member_namespace_for_group_members_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_project_repositories_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_snippet_repositories_spec.rb' - - 'spec/lib/gitlab/background_migration/backfill_work_item_type_id_for_issues_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/backfill_project_namespace_per_group_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/batching_strategies/primary_key_batching_strategy_spec.rb' - 'spec/lib/gitlab/background_migration/cleanup_orphaned_lfs_objects_projects_spec.rb' @@ -4744,7 +4458,6 @@ Layout/LineLength: - 'spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb' - 'spec/lib/gitlab/chat/output_spec.rb' - 'spec/lib/gitlab/checks/branch_check_spec.rb' - - 'spec/lib/gitlab/checks/changes_access_spec.rb' - 'spec/lib/gitlab/checks/diff_check_spec.rb' - 'spec/lib/gitlab/checks/push_check_spec.rb' - 'spec/lib/gitlab/checks/snippet_check_spec.rb' @@ -4790,11 +4503,9 @@ Layout/LineLength: - 'spec/lib/gitlab/ci/pipeline_object_hierarchy_spec.rb' - 'spec/lib/gitlab/ci/reports/codequality_mr_diff_spec.rb' - 'spec/lib/gitlab/ci/reports/security/flag_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/link_spec.rb' - 'spec/lib/gitlab/ci/reports/security/reports_spec.rb' - 'spec/lib/gitlab/ci/reports/security/scanner_spec.rb' - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' - - 'spec/lib/gitlab/ci/runner_releases_spec.rb' - 'spec/lib/gitlab/ci/runner_upgrade_check_spec.rb' - 'spec/lib/gitlab/ci/status/bridge/factory_spec.rb' - 'spec/lib/gitlab/ci/status/build/manual_spec.rb' @@ -4833,7 +4544,6 @@ Layout/LineLength: - 'spec/lib/gitlab/database/load_balancing/configuration_spec.rb' - 'spec/lib/gitlab/database/load_balancing/host_list_spec.rb' - 'spec/lib/gitlab/database/load_balancing/service_discovery_spec.rb' - - 'spec/lib/gitlab/database/load_balancing/setup_spec.rb' - 'spec/lib/gitlab/database/load_balancing/sidekiq_client_middleware_spec.rb' - 'spec/lib/gitlab/database/load_balancing/sidekiq_server_middleware_spec.rb' - 'spec/lib/gitlab/database/load_balancing/srv_resolver_spec.rb' @@ -4883,7 +4593,6 @@ Layout/LineLength: - 'spec/lib/gitlab/diff/highlight_cache_spec.rb' - 'spec/lib/gitlab/diff/highlight_spec.rb' - 'spec/lib/gitlab/diff/inline_diff_marker_spec.rb' - - 'spec/lib/gitlab/diff/position_tracer/image_strategy_spec.rb' - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' - 'spec/lib/gitlab/diff/suggestion_spec.rb' - 'spec/lib/gitlab/email/failure_handler_spec.rb' @@ -4939,20 +4648,13 @@ Layout/LineLength: - 'spec/lib/gitlab/github_import/importer/lfs_object_importer_spec.rb' - 'spec/lib/gitlab/github_import/object_counter_spec.rb' - 'spec/lib/gitlab/github_import/user_finder_spec.rb' - - 'spec/lib/gitlab/github_import_spec.rb' - 'spec/lib/gitlab/gl_repository/repo_type_spec.rb' - - 'spec/lib/gitlab/global_id/deprecations_spec.rb' - 'spec/lib/gitlab/gpg/commit_spec.rb' - 'spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb' - 'spec/lib/gitlab/graphql/loaders/batch_lfs_oid_loader_spec.rb' - 'spec/lib/gitlab/graphql/markdown_field_spec.rb' - 'spec/lib/gitlab/graphql/pagination/connections_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/conditions/not_null_condition_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/conditions/null_condition_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/connection_generic_keyset_spec.rb' - 'spec/lib/gitlab/graphql/pagination/keyset/connection_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/order_info_spec.rb' - - 'spec/lib/gitlab/graphql/pagination/keyset/query_builder_spec.rb' - 'spec/lib/gitlab/graphql/present/field_extension_spec.rb' - 'spec/lib/gitlab/graphql/tracers/application_context_tracer_spec.rb' - 'spec/lib/gitlab/graphs/commits_spec.rb' @@ -4996,7 +4698,6 @@ Layout/LineLength: - 'spec/lib/gitlab/import_sources_spec.rb' - 'spec/lib/gitlab/incoming_email_spec.rb' - 'spec/lib/gitlab/instrumentation/redis_interceptor_spec.rb' - - 'spec/lib/gitlab/internal_post_receive/response_spec.rb' - 'spec/lib/gitlab/issuable_metadata_spec.rb' - 'spec/lib/gitlab/issues/rebalancing/state_spec.rb' - 'spec/lib/gitlab/jira/dvcs_spec.rb' @@ -5055,7 +4756,6 @@ Layout/LineLength: - 'spec/lib/gitlab/pagination/keyset/iterator_spec.rb' - 'spec/lib/gitlab/pagination/keyset/order_spec.rb' - 'spec/lib/gitlab/pagination/keyset/paginator_spec.rb' - - 'spec/lib/gitlab/pagination/offset_header_builder_spec.rb' - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/lib/gitlab/performance_bar/redis_adapter_when_peek_enabled_spec.rb' @@ -5063,7 +4763,6 @@ Layout/LineLength: - 'spec/lib/gitlab/phabricator_import/conduit/user_spec.rb' - 'spec/lib/gitlab/phabricator_import/user_finder_spec.rb' - 'spec/lib/gitlab/project_search_results_spec.rb' - - 'spec/lib/gitlab/project_template_spec.rb' - 'spec/lib/gitlab/prometheus/queries/deployment_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/knative_invocation_query_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' @@ -5118,7 +4817,6 @@ Layout/LineLength: - 'spec/lib/gitlab/usage/metrics/instrumentations/count_users_creating_issues_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/database_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_hll_metric_spec.rb' - - 'spec/lib/gitlab/usage/metrics/instrumentations/redis_metric_spec.rb' - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' - 'spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb' - 'spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/constraints_spec.rb' @@ -5180,7 +4878,6 @@ Layout/LineLength: - 'spec/mailers/emails/releases_spec.rb' - 'spec/mailers/emails/service_desk_spec.rb' - 'spec/mailers/notify_spec.rb' - - 'spec/migrations/20210421163509_schedule_update_jira_tracker_data_deployment_type_based_on_url_spec.rb' - 'spec/migrations/20210423160427_schedule_drop_invalid_vulnerabilities_spec.rb' - 'spec/migrations/20210511142748_schedule_drop_invalid_vulnerabilities2_spec.rb' - 'spec/migrations/20210514063252_schedule_cleanup_orphaned_lfs_objects_projects_spec.rb' @@ -5194,7 +4891,6 @@ Layout/LineLength: - 'spec/migrations/20210831203408_upsert_base_work_item_types_spec.rb' - 'spec/migrations/20210907211557_finalize_ci_builds_bigint_conversion_spec.rb' - 'spec/migrations/20210910194952_update_report_type_for_existing_approval_project_rules_spec.rb' - - 'spec/migrations/20210918201050_remove_old_pending_jobs_for_recalculate_vulnerabilities_occurrences_uuid_spec.rb' - 'spec/migrations/20211018152654_schedule_remove_duplicate_vulnerabilities_findings3_spec.rb' - 'spec/migrations/20211110143306_add_not_null_constraint_to_security_findings_uuid_spec.rb' - 'spec/migrations/20211110151350_schedule_drop_invalid_security_findings_spec.rb' @@ -5214,7 +4910,6 @@ Layout/LineLength: - 'spec/migrations/20220309084954_remove_leftover_external_pull_request_deletions_spec.rb' - 'spec/migrations/active_record/schema_spec.rb' - 'spec/migrations/add_upvotes_count_index_to_issues_spec.rb' - - 'spec/migrations/associate_existing_dast_builds_with_variables_spec.rb' - 'spec/migrations/backfill_all_project_namespaces_spec.rb' - 'spec/migrations/backfill_cadence_id_for_boards_scoped_to_iteration_spec.rb' - 'spec/migrations/backfill_clusters_integration_prometheus_enabled_spec.rb' @@ -5226,24 +4921,19 @@ Layout/LineLength: - 'spec/migrations/cleanup_move_container_registry_enabled_to_project_feature_spec.rb' - 'spec/migrations/confirm_support_bot_user_spec.rb' - 'spec/migrations/delete_security_findings_without_uuid_spec.rb' - - 'spec/migrations/disable_job_token_scope_when_unused_spec.rb' - 'spec/migrations/finalize_project_namespaces_backfill_spec.rb' - 'spec/migrations/fix_and_backfill_project_namespaces_for_projects_with_duplicate_name_spec.rb' - 'spec/migrations/fix_batched_migrations_old_format_job_arguments_spec.rb' - - 'spec/migrations/populate_audit_event_streaming_verification_token_spec.rb' - 'spec/migrations/populate_dismissal_information_for_vulnerabilities_spec.rb' - 'spec/migrations/re_schedule_latest_pipeline_id_population_with_all_security_related_artifact_types_spec.rb' - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_features_spec.rb' - 'spec/migrations/recreate_index_security_ci_builds_on_name_and_id_parser_with_new_features_spec.rb' - 'spec/migrations/remove_duplicate_dast_site_tokens_spec.rb' - - 'spec/migrations/remove_duplicate_dast_site_tokens_with_same_token_spec.rb' - 'spec/migrations/remove_not_null_contraint_on_title_from_sprints_spec.rb' - 'spec/migrations/rename_services_to_integrations_spec.rb' - 'spec/migrations/replace_external_wiki_triggers_spec.rb' - 'spec/migrations/reset_severity_levels_to_new_default_spec.rb' - 'spec/migrations/schedule_add_primary_email_to_emails_if_user_confirmed_spec.rb' - - 'spec/migrations/schedule_copy_ci_builds_columns_to_security_scans2_spec.rb' - - 'spec/migrations/schedule_populate_status_column_of_security_scans_spec.rb' - 'spec/migrations/schedule_recalculate_vulnerability_finding_signatures_for_findings_spec.rb' - 'spec/migrations/schedule_update_timelogs_null_spent_at_spec.rb' - 'spec/migrations/schedule_update_timelogs_project_id_spec.rb' @@ -5260,15 +4950,12 @@ Layout/LineLength: - 'spec/models/audit_event_spec.rb' - 'spec/models/authentication_event_spec.rb' - 'spec/models/award_emoji_spec.rb' - - 'spec/models/badge_spec.rb' - - 'spec/models/badges/project_badge_spec.rb' - 'spec/models/blob_viewer/go_mod_spec.rb' - 'spec/models/blob_viewer/metrics_dashboard_yml_spec.rb' - 'spec/models/broadcast_message_spec.rb' - 'spec/models/bulk_import_spec.rb' - 'spec/models/bulk_imports/entity_spec.rb' - 'spec/models/bulk_imports/file_transfer/project_config_spec.rb' - - 'spec/models/ci/artifact_blob_spec.rb' - 'spec/models/ci/build_runner_session_spec.rb' - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/build_trace_chunk_spec.rb' @@ -5322,7 +5009,6 @@ Layout/LineLength: - 'spec/models/concerns/token_authenticatable_spec.rb' - 'spec/models/concerns/token_authenticatable_strategies/encryption_helper_spec.rb' - 'spec/models/concerns/x509_serial_number_attribute_spec.rb' - - 'spec/models/container_registry/event_spec.rb' - 'spec/models/container_repository_spec.rb' - 'spec/models/context_commits_diff_spec.rb' - 'spec/models/customer_relations/issue_contact_spec.rb' @@ -5359,9 +5045,7 @@ Layout/LineLength: - 'spec/models/integrations/discord_spec.rb' - 'spec/models/integrations/drone_ci_spec.rb' - 'spec/models/integrations/emails_on_push_spec.rb' - - 'spec/models/integrations/jenkins_spec.rb' - 'spec/models/integrations/jira_spec.rb' - - 'spec/models/integrations/jira_tracker_data_spec.rb' - 'spec/models/integrations/packagist_spec.rb' - 'spec/models/integrations/prometheus_spec.rb' - 'spec/models/integrations/slack_spec.rb' @@ -5442,7 +5126,6 @@ Layout/LineLength: - 'spec/models/snippet_spec.rb' - 'spec/models/state_note_spec.rb' - 'spec/models/suggestion_spec.rb' - - 'spec/models/terraform/state_spec.rb' - 'spec/models/timelog_spec.rb' - 'spec/models/todo_spec.rb' - 'spec/models/upload_spec.rb' @@ -5467,7 +5150,6 @@ Layout/LineLength: - 'spec/presenters/clusters/cluster_presenter_spec.rb' - 'spec/presenters/commit_status_presenter_spec.rb' - 'spec/presenters/gitlab/blame_presenter_spec.rb' - - 'spec/presenters/issue_presenter_spec.rb' - 'spec/presenters/merge_request_presenter_spec.rb' - 'spec/presenters/packages/composer/packages_presenter_spec.rb' - 'spec/presenters/packages/conan/package_presenter_spec.rb' @@ -5481,7 +5163,6 @@ Layout/LineLength: - 'spec/presenters/prometheus_alert_presenter_spec.rb' - 'spec/presenters/service_hook_presenter_spec.rb' - 'spec/presenters/snippet_blob_presenter_spec.rb' - - 'spec/presenters/tree_entry_presenter_spec.rb' - 'spec/rack_servers/puma_spec.rb' - 'spec/requests/admin/background_migrations_controller_spec.rb' - 'spec/requests/api/access_requests_spec.rb' @@ -5578,7 +5259,6 @@ Layout/LineLength: - 'spec/requests/api/graphql/project/jobs_spec.rb' - 'spec/requests/api/graphql/project/milestones_spec.rb' - 'spec/requests/api/graphql/project/pipeline_spec.rb' - - 'spec/requests/api/graphql/project/project_members_spec.rb' - 'spec/requests/api/graphql/project/project_statistics_spec.rb' - 'spec/requests/api/graphql/project/release_spec.rb' - 'spec/requests/api/graphql/usage_trends_measurements_spec.rb' @@ -5611,7 +5291,6 @@ Layout/LineLength: - 'spec/requests/api/keys_spec.rb' - 'spec/requests/api/labels_spec.rb' - 'spec/requests/api/lint_spec.rb' - - 'spec/requests/api/markdown_spec.rb' - 'spec/requests/api/maven_packages_spec.rb' - 'spec/requests/api/members_spec.rb' - 'spec/requests/api/merge_request_diffs_spec.rb' @@ -5633,7 +5312,6 @@ Layout/LineLength: - 'spec/requests/api/project_debian_distributions_spec.rb' - 'spec/requests/api/project_events_spec.rb' - 'spec/requests/api/project_export_spec.rb' - - 'spec/requests/api/project_hooks_spec.rb' - 'spec/requests/api/project_import_spec.rb' - 'spec/requests/api/project_milestones_spec.rb' - 'spec/requests/api/project_packages_spec.rb' @@ -5645,7 +5323,6 @@ Layout/LineLength: - 'spec/requests/api/release/links_spec.rb' - 'spec/requests/api/releases_spec.rb' - 'spec/requests/api/repositories_spec.rb' - - 'spec/requests/api/resource_state_events_spec.rb' - 'spec/requests/api/rubygem_packages_spec.rb' - 'spec/requests/api/search_spec.rb' - 'spec/requests/api/settings_spec.rb' @@ -5664,8 +5341,6 @@ Layout/LineLength: - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/groups_controller_spec.rb' - 'spec/requests/ide_controller_spec.rb' - - 'spec/requests/jira_connect/installations_controller_spec.rb' - - 'spec/requests/jira_connect/users_controller_spec.rb' - 'spec/requests/jwt_controller_spec.rb' - 'spec/requests/lfs_http_spec.rb' - 'spec/requests/oauth/tokens_controller_spec.rb' @@ -5686,7 +5361,6 @@ Layout/LineLength: - 'spec/requests/projects/merge_requests_spec.rb' - 'spec/requests/projects/metrics/dashboards/builder_spec.rb' - 'spec/requests/projects/noteable_notes_spec.rb' - - 'spec/requests/projects/releases_controller_spec.rb' - 'spec/requests/projects/settings/access_tokens_controller_spec.rb' - 'spec/requests/projects/tags_controller_spec.rb' - 'spec/requests/projects_controller_spec.rb' @@ -5700,7 +5374,6 @@ Layout/LineLength: - 'spec/routing/project_routing_spec.rb' - 'spec/routing/projects/security/configuration_controller_routing_spec.rb' - 'spec/routing/routing_spec.rb' - - 'spec/routing/uploads_routing_spec.rb' - 'spec/rubocop/cop/gitlab/mark_used_feature_flags_spec.rb' - 'spec/rubocop/cop/lint/last_keyword_argument_spec.rb' - 'spec/rubocop/cop/migration/safer_boolean_column_spec.rb' @@ -5708,10 +5381,7 @@ Layout/LineLength: - 'spec/rubocop/cop/performance/readlines_each_spec.rb' - 'spec/rubocop/cop/rspec/env_assignment_spec.rb' - 'spec/rubocop/cop/rspec/expect_gitlab_tracking_spec.rb' - - 'spec/rubocop/cop/scalability/file_uploads_spec.rb' - - 'spec/scripts/changed-feature-flags_spec.rb' - 'spec/scripts/failed_tests_spec.rb' - - 'spec/scripts/pipeline_test_report_builder_spec.rb' - 'spec/serializers/accessibility_error_entity_spec.rb' - 'spec/serializers/accessibility_reports_comparer_entity_spec.rb' - 'spec/serializers/analytics/cycle_analytics/stage_entity_spec.rb' @@ -5777,7 +5447,6 @@ Layout/LineLength: - 'spec/services/ci/pipeline_processing/atomic_processing_service_spec.rb' - 'spec/services/ci/register_job_service_spec.rb' - 'spec/services/ci/resource_groups/assign_resource_from_resource_group_service_spec.rb' - - 'spec/services/ci/retry_job_service_spec.rb' - 'spec/services/ci/runners/register_runner_service_spec.rb' - 'spec/services/ci/test_failure_history_service_spec.rb' - 'spec/services/ci/unlock_artifacts_service_spec.rb' @@ -5802,7 +5471,6 @@ Layout/LineLength: - 'spec/services/container_expiration_policies/cleanup_service_spec.rb' - 'spec/services/container_expiration_policies/update_service_spec.rb' - 'spec/services/customer_relations/contacts/create_service_spec.rb' - - 'spec/services/customer_relations/contacts/update_service_spec.rb' - 'spec/services/customer_relations/organizations/create_service_spec.rb' - 'spec/services/dependency_proxy/find_cached_manifest_service_spec.rb' - 'spec/services/deployments/link_merge_requests_service_spec.rb' @@ -5810,7 +5478,6 @@ Layout/LineLength: - 'spec/services/design_management/copy_design_collection/copy_service_spec.rb' - 'spec/services/design_management/delete_designs_service_spec.rb' - 'spec/services/design_management/design_user_notes_count_service_spec.rb' - - 'spec/services/design_management/save_designs_service_spec.rb' - 'spec/services/discussions/capture_diff_note_positions_service_spec.rb' - 'spec/services/discussions/resolve_service_spec.rb' - 'spec/services/draft_notes/publish_service_spec.rb' @@ -5831,7 +5498,6 @@ Layout/LineLength: - 'spec/services/groups/autocomplete_service_spec.rb' - 'spec/services/groups/create_service_spec.rb' - 'spec/services/groups/group_links/destroy_service_spec.rb' - - 'spec/services/groups/open_issues_count_service_spec.rb' - 'spec/services/groups/transfer_service_spec.rb' - 'spec/services/groups/update_service_spec.rb' - 'spec/services/groups/update_shared_runners_service_spec.rb' @@ -5869,7 +5535,6 @@ Layout/LineLength: - 'spec/services/jira_import/cloud_users_mapper_service_spec.rb' - 'spec/services/jira_import/server_users_mapper_service_spec.rb' - 'spec/services/jira_import/start_import_service_spec.rb' - - 'spec/services/jira_import/users_importer_spec.rb' - 'spec/services/labels/available_labels_service_spec.rb' - 'spec/services/labels/promote_service_spec.rb' - 'spec/services/labels/transfer_service_spec.rb' @@ -5887,7 +5552,6 @@ Layout/LineLength: - 'spec/services/merge_requests/assign_issues_service_spec.rb' - 'spec/services/merge_requests/base_service_spec.rb' - 'spec/services/merge_requests/build_service_spec.rb' - - 'spec/services/merge_requests/bulk_remove_attention_requested_service_spec.rb' - 'spec/services/merge_requests/cleanup_refs_service_spec.rb' - 'spec/services/merge_requests/conflicts/list_service_spec.rb' - 'spec/services/merge_requests/create_from_issue_service_spec.rb' @@ -5899,8 +5563,6 @@ Layout/LineLength: - 'spec/services/merge_requests/link_lfs_objects_service_spec.rb' - 'spec/services/merge_requests/merge_service_spec.rb' - 'spec/services/merge_requests/merge_to_ref_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_broken_status_service_spec.rb' - - 'spec/services/merge_requests/mergeability/check_discussions_status_service_spec.rb' - 'spec/services/merge_requests/mergeability/run_checks_service_spec.rb' - 'spec/services/merge_requests/mergeability_check_service_spec.rb' - 'spec/services/merge_requests/push_options_handler_service_spec.rb' @@ -5908,7 +5570,6 @@ Layout/LineLength: - 'spec/services/merge_requests/refresh_service_spec.rb' - 'spec/services/merge_requests/request_review_service_spec.rb' - 'spec/services/merge_requests/squash_service_spec.rb' - - 'spec/services/merge_requests/toggle_attention_requested_service_spec.rb' - 'spec/services/merge_requests/update_service_spec.rb' - 'spec/services/metrics/dashboard/annotations/create_service_spec.rb' - 'spec/services/metrics/dashboard/clone_dashboard_service_spec.rb' @@ -5982,7 +5643,6 @@ Layout/LineLength: - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_import_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_object_download_list_service_spec.rb' - - 'spec/services/projects/open_issues_count_service_spec.rb' - 'spec/services/projects/operations/update_service_spec.rb' - 'spec/services/projects/overwrite_project_service_spec.rb' - 'spec/services/projects/transfer_service_spec.rb' @@ -5992,7 +5652,6 @@ Layout/LineLength: - 'spec/services/projects/update_service_spec.rb' - 'spec/services/protected_branches/create_service_spec.rb' - 'spec/services/quick_actions/interpret_service_spec.rb' - - 'spec/services/repositories/destroy_service_spec.rb' - 'spec/services/repository_archive_clean_up_service_spec.rb' - 'spec/services/resource_access_tokens/create_service_spec.rb' - 'spec/services/resource_access_tokens/revoke_service_spec.rb' @@ -6004,7 +5663,6 @@ Layout/LineLength: - 'spec/services/search_service_spec.rb' - 'spec/services/security/ci_configuration/sast_create_service_spec.rb' - 'spec/services/security/merge_reports_service_spec.rb' - - 'spec/services/service_ping/submit_service_ping_service_spec.rb' - 'spec/services/snippets/create_service_spec.rb' - 'spec/services/snippets/update_repository_storage_service_spec.rb' - 'spec/services/snippets/update_service_spec.rb' @@ -6032,7 +5690,6 @@ Layout/LineLength: - 'spec/services/web_hooks/log_execution_service_spec.rb' - 'spec/services/work_items/create_and_link_service_spec.rb' - 'spec/services/work_items/create_from_task_service_spec.rb' - - 'spec/services/work_items/create_service_spec.rb' - 'spec/services/work_items/task_list_reference_replacement_service_spec.rb' - 'spec/services/work_items/update_service_spec.rb' - 'spec/services/x509_certificate_revoke_service_spec.rb' @@ -6056,7 +5713,6 @@ Layout/LineLength: - 'spec/support/helpers/feature_flag_helpers.rb' - 'spec/support/helpers/filtered_search_helpers.rb' - 'spec/support/helpers/git_http_helpers.rb' - - 'spec/support/helpers/global_id_deprecation_helpers.rb' - 'spec/support/helpers/graphql_helpers.rb' - 'spec/support/helpers/javascript_fixtures_helpers.rb' - 'spec/support/helpers/kubernetes_helpers.rb' @@ -6109,7 +5765,6 @@ Layout/LineLength: - 'spec/support/shared_examples/controllers/set_sort_order_from_user_preference_shared_examples.rb' - 'spec/support/shared_examples/controllers/wiki_actions_shared_examples.rb' - 'spec/support/shared_examples/features/2fa_shared_examples.rb' - - 'spec/support/shared_examples/features/archive_download_buttons_shared_examples.rb' - 'spec/support/shared_examples/features/container_registry_shared_examples.rb' - 'spec/support/shared_examples/features/discussion_comments_shared_example.rb' - 'spec/support/shared_examples/features/editable_merge_request_shared_examples.rb' @@ -6233,7 +5888,6 @@ Layout/LineLength: - 'spec/support/shared_examples/services/repositories/housekeeping_shared_examples.rb' - 'spec/support/shared_examples/services/resource_events/change_milestone_service_shared_examples.rb' - 'spec/support/shared_examples/services/security/ci_configuration/create_service_shared_examples.rb' - - 'spec/support/shared_examples/snippet_blob_shared_examples.rb' - 'spec/support/shared_examples/uploaders/gitlab_uploader_shared_examples.rb' - 'spec/support/shared_examples/uploaders/upload_type_shared_examples.rb' - 'spec/support/shared_examples/views/registration_features_prompt_shared_examples.rb' @@ -6265,7 +5919,6 @@ Layout/LineLength: - 'spec/tasks/gitlab/storage_rake_spec.rb' - 'spec/tasks/gitlab/task_helpers_spec.rb' - 'spec/tasks/gitlab/terraform/migrate_rake_spec.rb' - - 'spec/tasks/gitlab/update_templates_rake_spec.rb' - 'spec/tasks/gitlab/uploads/check_rake_spec.rb' - 'spec/tasks/gitlab/workhorse_rake_spec.rb' - 'spec/tasks/migrate/schema_check_rake_spec.rb' @@ -6304,13 +5957,10 @@ Layout/LineLength: - 'spec/views/layouts/_head.html.haml_spec.rb' - 'spec/views/layouts/application.html.haml_spec.rb' - 'spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb' - - 'spec/views/notify/change_in_merge_request_draft_status_email.html.haml_spec.rb' - - 'spec/views/notify/change_in_merge_request_draft_status_email.text.erb_spec.rb' - 'spec/views/notify/push_to_merge_request_email.text.haml_spec.rb' - 'spec/views/profiles/keys/_form.html.haml_spec.rb' - 'spec/views/projects/artifacts/_artifact.html.haml_spec.rb' - 'spec/views/projects/commits/_commit.html.haml_spec.rb' - - 'spec/views/projects/edit.html.haml_spec.rb' - 'spec/views/projects/imports/new.html.haml_spec.rb' - 'spec/views/projects/jobs/_build.html.haml_spec.rb' - 'spec/views/projects/jobs/_generic_commit_status.html.haml_spec.rb' @@ -6354,8 +6004,6 @@ Layout/LineLength: - 'spec/workers/container_registry/migration/guard_worker_spec.rb' - 'spec/workers/container_registry/migration/observer_worker_spec.rb' - 'spec/workers/create_pipeline_worker_spec.rb' - - 'spec/workers/database/batched_background_migration/ci_database_worker_spec.rb' - - 'spec/workers/database/batched_background_migration_worker_spec.rb' - 'spec/workers/dependency_proxy/image_ttl_group_policy_worker_spec.rb' - 'spec/workers/deployments/hooks_worker_spec.rb' - 'spec/workers/deployments/update_environment_worker_spec.rb' @@ -6378,8 +6026,6 @@ Layout/LineLength: - 'spec/workers/jira_connect/sync_project_worker_spec.rb' - 'spec/workers/loose_foreign_keys/cleanup_worker_spec.rb' - 'spec/workers/members_destroyer/unassign_issuables_worker_spec.rb' - - 'spec/workers/merge_requests/create_pipeline_worker_spec.rb' - - 'spec/workers/merge_requests/update_head_pipeline_worker_spec.rb' - 'spec/workers/new_issue_worker_spec.rb' - 'spec/workers/new_merge_request_worker_spec.rb' - 'spec/workers/packages/cleanup_package_file_worker_spec.rb' @@ -6392,7 +6038,6 @@ Layout/LineLength: - 'spec/workers/personal_access_tokens/expiring_worker_spec.rb' - 'spec/workers/post_receive_spec.rb' - 'spec/workers/projects/post_creation_worker_spec.rb' - - 'spec/workers/projects/refresh_build_artifacts_size_statistics_worker_spec.rb' - 'spec/workers/propagate_integration_inherit_descendant_worker_spec.rb' - 'spec/workers/remove_expired_members_worker_spec.rb' - 'spec/workers/repository_check/dispatch_worker_spec.rb' diff --git a/.rubocop_todo/layout/space_around_operators.yml b/.rubocop_todo/layout/space_around_operators.yml new file mode 100644 index 00000000000..9f6c0145723 --- /dev/null +++ b/.rubocop_todo/layout/space_around_operators.yml @@ -0,0 +1,5 @@ +--- +# Cop supports --auto-correct. +Layout/SpaceAroundOperators: + Exclude: + - 'lib/gitlab/utils/strong_memoize.rb' diff --git a/.rubocop_todo/layout/space_before_block_braces.yml b/.rubocop_todo/layout/space_before_block_braces.yml new file mode 100644 index 00000000000..3be90947fee --- /dev/null +++ b/.rubocop_todo/layout/space_before_block_braces.yml @@ -0,0 +1,5 @@ +--- +# Cop supports --auto-correct. +Layout/SpaceBeforeBlockBraces: + Exclude: + - 'app/helpers/colors_helper.rb' diff --git a/.rubocop_todo/layout/space_inside_block_braces.yml b/.rubocop_todo/layout/space_inside_block_braces.yml new file mode 100644 index 00000000000..c775ad94e46 --- /dev/null +++ b/.rubocop_todo/layout/space_inside_block_braces.yml @@ -0,0 +1,5 @@ +--- +# Cop supports --auto-correct. +Layout/SpaceInsideBlockBraces: + Exclude: + - 'spec/requests/api/groups_spec.rb' diff --git a/.rubocop_todo/layout/trailing_whitespace.yml b/.rubocop_todo/layout/trailing_whitespace.yml new file mode 100644 index 00000000000..d9c88c989e0 --- /dev/null +++ b/.rubocop_todo/layout/trailing_whitespace.yml @@ -0,0 +1,16 @@ +--- +# Cop supports --auto-correct. +Layout/TrailingWhitespace: + Details: grace period + Exclude: + - 'app/models/concerns/analytics/cycle_analytics/stage_event_model.rb' + - 'db/migrate/20210611100359_rebuild_index_for_cadence_iterations_automation.rb' + - 'db/migrate/20220913082728_drop_index_cadence_create_iterations_automation.rb' + - 'db/post_migrate/20220816163444_update_start_date_for_iterations_cadences.rb' + - 'lib/gitlab/background_migration/fix_duplicate_project_name_and_path.rb' + - 'lib/gitlab/background_migration/populate_topics_non_private_projects_count.rb' + - 'lib/gitlab/pagination/keyset/sql_type_missing_error.rb' + - 'qa/qa/specs/features/browser_ui/7_configure/auto_devops/create_project_with_auto_devops_spec.rb' + - 'spec/lib/banzai/filter/front_matter_filter_spec.rb' + - 'spec/services/suggestions/apply_service_spec.rb' + - 'spec/support/helpers/x509_helpers.rb' diff --git a/.rubocop_todo/lint/binary_operator_with_identical_operands.yml b/.rubocop_todo/lint/binary_operator_with_identical_operands.yml deleted file mode 100644 index 90c3a76d3b1..00000000000 --- a/.rubocop_todo/lint/binary_operator_with_identical_operands.yml +++ /dev/null @@ -1,15 +0,0 @@ ---- -Lint/BinaryOperatorWithIdenticalOperands: - Exclude: - - 'ee/spec/lib/ee/gitlab/application_context_spec.rb' - - 'spec/helpers/visibility_level_helper_spec.rb' - - 'spec/lib/gitlab/conan_token_spec.rb' - - 'spec/lib/gitlab/git/conflict/parser_spec.rb' - - 'spec/lib/gitlab/graphql/lazy_spec.rb' - - 'spec/models/ci/build_trace_chunk_spec.rb' - - 'spec/models/clusters/platforms/kubernetes_spec.rb' - - 'spec/models/concerns/where_composite_spec.rb' - - 'spec/models/metrics/dashboard/annotation_spec.rb' - - 'spec/models/repository_spec.rb' - - 'spec/models/ssh_host_key_spec.rb' - - 'spec/tooling/danger/sidekiq_queues_spec.rb' diff --git a/.rubocop_todo/lint/duplicate_case_condition.yml b/.rubocop_todo/lint/duplicate_case_condition.yml new file mode 100644 index 00000000000..d7e1eac2e03 --- /dev/null +++ b/.rubocop_todo/lint/duplicate_case_condition.yml @@ -0,0 +1,4 @@ +--- +Lint/DuplicateCaseCondition: + Exclude: + - 'app/helpers/icons_helper.rb' diff --git a/.rubocop_todo/metrics/parameter_lists.yml b/.rubocop_todo/metrics/parameter_lists.yml new file mode 100644 index 00000000000..14cd46d31fb --- /dev/null +++ b/.rubocop_todo/metrics/parameter_lists.yml @@ -0,0 +1,9 @@ +--- +Metrics/ParameterLists: + Exclude: + - 'app/helpers/avatars_helper.rb' + - 'app/helpers/blob_helper.rb' + - 'app/models/packages/sem_ver.rb' + - 'app/models/repository.rb' + - 'lib/gitlab/git/tree.rb' + - 'lib/gitlab/version_info.rb' diff --git a/.rubocop_todo/performance/bind_call.yml b/.rubocop_todo/performance/bind_call.yml new file mode 100644 index 00000000000..5adb519793d --- /dev/null +++ b/.rubocop_todo/performance/bind_call.yml @@ -0,0 +1,10 @@ +--- +# Cop supports --auto-correct. +Performance/BindCall: + Exclude: + - 'app/services/metrics/dashboard/grafana_metric_embed_service.rb' + - 'ee/spec/features/issues/form_spec.rb' + - 'lib/gitlab/patch/prependable.rb' + - 'spec/features/issues/form_spec.rb' + - 'spec/mailers/notify_spec.rb' + - 'spec/support/patches/rspec_mocks_prepended_methods.rb' diff --git a/.rubocop_todo/performance/redundant_block_call.yml b/.rubocop_todo/performance/redundant_block_call.yml new file mode 100644 index 00000000000..89a67e3fd30 --- /dev/null +++ b/.rubocop_todo/performance/redundant_block_call.yml @@ -0,0 +1,12 @@ +--- +# Cop supports --auto-correct. +Performance/RedundantBlockCall: + Exclude: + - 'ee/app/models/gitlab_subscription.rb' + - 'ee/lib/ee/gitlab/auth/ldap/sync/proxy.rb' + - 'lib/gitlab/auth/ldap/access.rb' + - 'lib/gitlab/auth/ldap/adapter.rb' + - 'lib/gitlab/database/bulk_update.rb' + - 'lib/gitlab/http.rb' + - 'lib/gitlab/safe_request_store.rb' + - 'lib/gitlab/timeless.rb' diff --git a/.rubocop_todo/rails/http_status.yml b/.rubocop_todo/rails/http_status.yml new file mode 100644 index 00000000000..1a8ece49304 --- /dev/null +++ b/.rubocop_todo/rails/http_status.yml @@ -0,0 +1,9 @@ +--- +# Cop supports --auto-correct. +Rails/HttpStatus: + Exclude: + - 'app/controllers/concerns/invisible_captcha_on_signup.rb' + - 'app/controllers/projects/runner_projects_controller.rb' + - 'app/controllers/projects/service_ping_controller.rb' + - 'app/controllers/repositories/lfs_storage_controller.rb' + - 'ee/app/controllers/trials_controller.rb' diff --git a/.rubocop_todo/rails/time_zone.yml b/.rubocop_todo/rails/time_zone.yml index 8931b337ce1..f1e7d519a8f 100644 --- a/.rubocop_todo/rails/time_zone.yml +++ b/.rubocop_todo/rails/time_zone.yml @@ -19,7 +19,6 @@ Rails/TimeZone: - ee/spec/lib/gitlab/auth/ldap/access_spec.rb - ee/spec/lib/gitlab/auth/smartcard/san_extension_spec.rb - ee/spec/lib/gitlab/auth/smartcard/session_spec.rb - - ee/spec/lib/gitlab/ci/pipeline/chain/limit/job_activity_spec.rb - ee/spec/lib/gitlab/elastic/client_spec.rb - ee/spec/lib/gitlab/geo/base_request_spec.rb - ee/spec/lib/gitlab/geo/log_cursor/events/cache_invalidation_event_spec.rb diff --git a/.rubocop_todo/rspec/expect_change.yml b/.rubocop_todo/rspec/expect_change.yml index f8962515874..626ed1390ce 100644 --- a/.rubocop_todo/rspec/expect_change.yml +++ b/.rubocop_todo/rspec/expect_change.yml @@ -1,11 +1,13 @@ --- # Cop supports --auto-correct. RSpec/ExpectChange: + Details: grace period Exclude: - 'ee/spec/controllers/admin/applications_controller_spec.rb' - 'ee/spec/controllers/ee/groups_controller_spec.rb' - 'ee/spec/controllers/ee/omniauth_callbacks_controller_spec.rb' - 'ee/spec/controllers/ee/registrations_controller_spec.rb' + - 'ee/spec/controllers/groups/analytics/cycle_analytics/value_streams_controller_spec.rb' - 'ee/spec/controllers/groups/epic_issues_controller_spec.rb' - 'ee/spec/controllers/groups/epics/notes_controller_spec.rb' - 'ee/spec/controllers/groups/epics_controller_spec.rb' @@ -21,19 +23,25 @@ RSpec/ExpectChange: - 'ee/spec/controllers/projects/protected_environments_controller_spec.rb' - 'ee/spec/controllers/projects/repositories_controller_spec.rb' - 'ee/spec/controllers/projects/security/vulnerabilities/notes_controller_spec.rb' + - 'ee/spec/controllers/projects/vulnerability_feedback_controller_spec.rb' - 'ee/spec/controllers/projects_controller_spec.rb' - 'ee/spec/controllers/trials_controller_spec.rb' - 'ee/spec/elastic/migrate/20220119120500_populate_commit_permissions_in_main_index_spec.rb' + - 'ee/spec/elastic/migrate/20220512150000_pause_indexing_for_unsupported_es_versions_spec.rb' - 'ee/spec/features/groups/group_settings_spec.rb' - 'ee/spec/features/projects_spec.rb' - 'ee/spec/features/signup_spec.rb' - 'ee/spec/features/users/login_spec.rb' - 'ee/spec/graphql/ee/mutations/ci/runner/update_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' + - 'ee/spec/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' - 'ee/spec/graphql/mutations/compliance_management/frameworks/update_spec.rb' + - 'ee/spec/graphql/mutations/dast/profiles/delete_spec.rb' - 'ee/spec/graphql/mutations/dast_scanner_profiles/delete_spec.rb' - 'ee/spec/graphql/mutations/dast_site_profiles/delete_spec.rb' - 'ee/spec/graphql/mutations/dast_site_validations/revoke_spec.rb' + - 'ee/spec/graphql/types/dast_scanner_profile_type_spec.rb' + - 'ee/spec/graphql/types/dast_site_profile_type_spec.rb' - 'ee/spec/helpers/paid_feature_callout_helper_spec.rb' - 'ee/spec/lib/audit/changes_spec.rb' - 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb' @@ -53,12 +61,14 @@ RSpec/ExpectChange: - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' - 'ee/spec/lib/ee/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings_spec.rb' + - 'ee/spec/lib/ee/gitlab/cleanup/orphan_job_artifact_files_batch_spec.rb' - 'ee/spec/lib/ee/gitlab/elastic/helper_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/project/tree_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/import_export/repo_restorer_spec.rb' - 'ee/spec/lib/ee/gitlab/issuable/clone/copy_resource_events_service_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/deprovision_service_spec.rb' - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' + - 'ee/spec/lib/gitlab/analytics/cycle_analytics/distinct_stage_loader_spec.rb' - 'ee/spec/lib/gitlab/audit/auditor_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/identity_linker_spec.rb' - 'ee/spec/lib/gitlab/auth/group_saml/user_spec.rb' @@ -66,13 +76,17 @@ RSpec/ExpectChange: - 'ee/spec/lib/gitlab/auth/smartcard/certificate_spec.rb' - 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb' - 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb' + - 'ee/spec/lib/gitlab/cache_spec.rb' + - 'ee/spec/lib/gitlab/geo/replicator_spec.rb' - 'ee/spec/lib/gitlab/mirror_spec.rb' - 'ee/spec/migrations/20220411173544_cleanup_orphans_approval_project_rules_spec.rb' - 'ee/spec/models/ci/bridge_spec.rb' - 'ee/spec/models/ci/minutes/namespace_monthly_usage_spec.rb' - 'ee/spec/models/ci/minutes/project_monthly_usage_spec.rb' + - 'ee/spec/models/concerns/geo/eventable_spec.rb' - 'ee/spec/models/concerns/geo/replicable_model_spec.rb' - 'ee/spec/models/concerns/geo/verification_state_spec.rb' + - 'ee/spec/models/container_registry/event_spec.rb' - 'ee/spec/models/dast/profile_schedule_spec.rb' - 'ee/spec/models/dast_site_spec.rb' - 'ee/spec/models/ee/ci/job_artifact_spec.rb' @@ -85,15 +99,20 @@ RSpec/ExpectChange: - 'ee/spec/models/epic_spec.rb' - 'ee/spec/models/geo/project_registry_spec.rb' - 'ee/spec/models/geo/secondary_usage_data_spec.rb' - - 'ee/spec/models/gitlab_subscription_spec.rb' - 'ee/spec/models/issue_spec.rb' - 'ee/spec/models/project_import_state_spec.rb' + - 'ee/spec/models/project_member_spec.rb' - 'ee/spec/models/project_spec.rb' - 'ee/spec/models/repository_spec.rb' + - 'ee/spec/models/requirements_management/requirement_spec.rb' + - 'ee/spec/models/requirements_management/test_report_spec.rb' - 'ee/spec/models/status_page/published_incident_spec.rb' - 'ee/spec/models/vulnerabilities/export_spec.rb' + - 'ee/spec/models/vulnerabilities/read_spec.rb' - 'ee/spec/models/vulnerabilities/statistic_spec.rb' + - 'ee/spec/replicators/geo/pipeline_replicator_spec.rb' - 'ee/spec/requests/api/ci/pipelines_spec.rb' + - 'ee/spec/requests/api/deployments_spec.rb' - 'ee/spec/requests/api/epic_issues_spec.rb' - 'ee/spec/requests/api/epics_spec.rb' - 'ee/spec/requests/api/geo_spec.rb' @@ -101,8 +120,12 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/audit_events/external_audit_event_destinations/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/boards/epics/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/destroy_spec.rb' - 'ee/spec/requests/api/graphql/mutations/compliance_management/frameworks/update_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/dast/profiles/create_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/dast/profiles/delete_spec.rb' - 'ee/spec/requests/api/graphql/mutations/dast_scanner_profiles/delete_spec.rb' - 'ee/spec/requests/api/graphql/mutations/dast_site_profiles/delete_spec.rb' - 'ee/spec/requests/api/graphql/mutations/dast_site_tokens/create_spec.rb' @@ -110,6 +133,8 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/graphql/mutations/dast_site_validations/revoke_spec.rb' - 'ee/spec/requests/api/graphql/mutations/quality_management/test_cases/create_spec.rb' - 'ee/spec/requests/api/graphql/mutations/requirements_management/update_requirement_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security_policy/create_security_policy_project_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security_policy/unassign_security_policy_project_spec.rb' - 'ee/spec/requests/api/graphql/mutations/work_items/update_spec.rb' - 'ee/spec/requests/api/group_push_rule_spec.rb' - 'ee/spec/requests/api/groups_spec.rb' @@ -121,19 +146,30 @@ RSpec/ExpectChange: - 'ee/spec/requests/api/projects_spec.rb' - 'ee/spec/requests/api/releases_spec.rb' - 'ee/spec/requests/api/repositories_spec.rb' + - 'ee/spec/requests/api/status_checks_spec.rb' - 'ee/spec/requests/api/todos_spec.rb' - 'ee/spec/requests/api/users_spec.rb' - 'ee/spec/requests/ee/projects/deploy_tokens_controller_spec.rb' + - 'ee/spec/requests/groups/epics/related_epic_links_controller_spec.rb' - 'ee/spec/requests/groups/protected_environments_controller_spec.rb' - 'ee/spec/requests/groups_controller_spec.rb' - 'ee/spec/requests/smartcard_controller_spec.rb' + - 'ee/spec/services/analytics/cycle_analytics/stages/list_service_spec.rb' + - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/bulk_find_or_create_service_spec.rb' + - 'ee/spec/services/analytics/devops_adoption/enabled_namespaces/find_or_create_service_spec.rb' + - 'ee/spec/services/app_sec/dast/profiles/create_service_spec.rb' + - 'ee/spec/services/app_sec/dast/profiles/destroy_service_spec.rb' + - 'ee/spec/services/app_sec/dast/profiles/update_service_spec.rb' - 'ee/spec/services/app_sec/dast/scanner_profiles/destroy_service_spec.rb' + - 'ee/spec/services/app_sec/dast/site_profile_secret_variables/create_or_update_service_spec.rb' + - 'ee/spec/services/app_sec/dast/site_profile_secret_variables/destroy_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_profiles/audit/update_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_profiles/destroy_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_tokens/find_or_create_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_validations/find_or_create_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_validations/revoke_service_spec.rb' - 'ee/spec/services/app_sec/dast/site_validations/runner_service_spec.rb' + - 'ee/spec/services/app_sec/fuzzing/coverage/corpuses/create_service_spec.rb' - 'ee/spec/services/application_settings/update_service_spec.rb' - 'ee/spec/services/approval_rules/finalize_service_spec.rb' - 'ee/spec/services/approval_rules/project_rule_destroy_service_spec.rb' @@ -144,18 +180,27 @@ RSpec/ExpectChange: - 'ee/spec/services/audit_events/streaming/headers/update_service_spec.rb' - 'ee/spec/services/audit_events/user_impersonation_group_audit_event_service_spec.rb' - 'ee/spec/services/auto_merge/merge_train_service_spec.rb' + - 'ee/spec/services/boards/epic_user_preferences/update_service_spec.rb' - 'ee/spec/services/boards/epics/create_service_spec.rb' - 'ee/spec/services/boards/epics/move_service_spec.rb' + - 'ee/spec/services/boards/epics/position_create_service_spec.rb' - 'ee/spec/services/ci/destroy_pipeline_service_spec.rb' - 'ee/spec/services/ci/external_pull_requests/process_github_event_service_spec.rb' + - 'ee/spec/services/ci/minutes/update_build_minutes_service_spec.rb' + - 'ee/spec/services/ci/pipeline_trigger_service_spec.rb' - 'ee/spec/services/ci/process_build_service_spec.rb' + - 'ee/spec/services/ci/retry_job_service_spec.rb' + - 'ee/spec/services/ci/runners/stale_group_runners_prune_service_spec.rb' - 'ee/spec/services/ci/subscribe_bridge_service_spec.rb' + - 'ee/spec/services/ci/trigger_downstream_subscription_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/destroy_service_spec.rb' - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' - 'ee/spec/services/deploy_keys/create_service_spec.rb' - 'ee/spec/services/deployments/approval_service_spec.rb' - 'ee/spec/services/deployments/auto_rollback_service_spec.rb' + - 'ee/spec/services/ee/ci/job_artifacts/destroy_all_expired_service_spec.rb' + - 'ee/spec/services/ee/ci/job_artifacts/destroy_batch_service_spec.rb' - 'ee/spec/services/ee/gpg_keys/destroy_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/create_service_spec.rb' - 'ee/spec/services/ee/groups/deploy_tokens/destroy_service_spec.rb' @@ -168,6 +213,7 @@ RSpec/ExpectChange: - 'ee/spec/services/ee/members/destroy_service_spec.rb' - 'ee/spec/services/ee/members/invite_service_spec.rb' - 'ee/spec/services/ee/members/update_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/create_pipeline_service_spec.rb' - 'ee/spec/services/ee/merge_requests/update_service_spec.rb' - 'ee/spec/services/ee/notes/quick_actions_service_spec.rb' - 'ee/spec/services/ee/projects/deploy_tokens/create_service_spec.rb' @@ -179,6 +225,7 @@ RSpec/ExpectChange: - 'ee/spec/services/ee/users/reject_service_spec.rb' - 'ee/spec/services/ee/users/update_service_spec.rb' - 'ee/spec/services/elastic/indexing_control_service_spec.rb' + - 'ee/spec/services/elastic/process_initial_bookkeeping_service_spec.rb' - 'ee/spec/services/emails/create_service_spec.rb' - 'ee/spec/services/emails/destroy_service_spec.rb' - 'ee/spec/services/epic_issues/create_service_spec.rb' @@ -193,16 +240,21 @@ RSpec/ExpectChange: - 'ee/spec/services/geo/blob_download_service_spec.rb' - 'ee/spec/services/geo/metrics_update_service_spec.rb' - 'ee/spec/services/geo/project_housekeeping_service_spec.rb' + - 'ee/spec/services/geo/prune_event_log_service_spec.rb' - 'ee/spec/services/geo/registry_consistency_service_spec.rb' + - 'ee/spec/services/geo/repository_registry_removal_service_spec.rb' - 'ee/spec/services/geo/repository_sync_service_spec.rb' - 'ee/spec/services/group_saml/group_managed_accounts/transfer_membership_service_spec.rb' - 'ee/spec/services/group_saml/identity/destroy_service_spec.rb' - 'ee/spec/services/group_saml/sign_up_service_spec.rb' + - 'ee/spec/services/groups/destroy_service_spec.rb' - 'ee/spec/services/groups/mark_for_deletion_service_spec.rb' - 'ee/spec/services/groups/restore_service_spec.rb' - 'ee/spec/services/groups/sync_service_spec.rb' + - 'ee/spec/services/incident_management/issuable_resource_links/create_service_spec.rb' - 'ee/spec/services/incident_management/oncall_rotations/edit_service_spec.rb' - 'ee/spec/services/incident_management/pending_escalations/create_service_spec.rb' + - 'ee/spec/services/iterations/cadences/create_service_spec.rb' - 'ee/spec/services/iterations/update_service_spec.rb' - 'ee/spec/services/keys/create_service_spec.rb' - 'ee/spec/services/lfs/lock_file_service_spec.rb' @@ -210,56 +262,101 @@ RSpec/ExpectChange: - 'ee/spec/services/members/activate_service_spec.rb' - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - 'ee/spec/services/merge_requests/update_blocks_service_spec.rb' - - 'ee/spec/services/namespaces/free_user_cap/update_prevent_sharing_outside_hierarchy_service_spec.rb' + - 'ee/spec/services/projects/destroy_service_spec.rb' - 'ee/spec/services/projects/disable_deploy_key_service_spec.rb' - 'ee/spec/services/projects/enable_deploy_key_service_spec.rb' + - 'ee/spec/services/projects/hashed_storage/migrate_attachments_service_spec.rb' + - 'ee/spec/services/projects/hashed_storage/migrate_repository_service_spec.rb' - 'ee/spec/services/projects/import_service_spec.rb' - 'ee/spec/services/projects/mark_for_deletion_service_spec.rb' - 'ee/spec/services/projects/restore_service_spec.rb' - 'ee/spec/services/projects/transfer_service_spec.rb' - 'ee/spec/services/projects/update_service_spec.rb' - 'ee/spec/services/protected_environments/destroy_service_spec.rb' + - 'ee/spec/services/protected_environments/update_service_spec.rb' - 'ee/spec/services/push_rules/create_or_update_service_spec.rb' - - 'ee/spec/services/requirements_management/create_requirement_service_spec.rb' + - 'ee/spec/services/requirements_management/process_test_reports_service_spec.rb' - 'ee/spec/services/resource_access_tokens/create_service_spec.rb' - 'ee/spec/services/resource_access_tokens/revoke_service_spec.rb' - 'ee/spec/services/resource_events/change_weight_service_spec.rb' - 'ee/spec/services/security/ingestion/finding_map_spec.rb' - 'ee/spec/services/security/ingestion/ingest_report_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_finding_evidence_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_finding_identifiers_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_finding_links_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_finding_signatures_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_findings_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_identifiers_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_remediations_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities/mark_resolved_as_detected_spec.rb' - 'ee/spec/services/security/ingestion/tasks/ingest_vulnerabilities_spec.rb' - 'ee/spec/services/security/orchestration/assign_service_spec.rb' - 'ee/spec/services/security/override_uuids_service_spec.rb' - 'ee/spec/services/security/security_orchestration_policies/sync_opened_merge_requests_service_spec.rb' + - 'ee/spec/services/security/store_findings_metadata_service_spec.rb' - 'ee/spec/services/security/store_scan_service_spec.rb' - 'ee/spec/services/start_pull_mirroring_service_spec.rb' + - 'ee/spec/services/status_page/mark_for_publication_service_spec.rb' - 'ee/spec/services/system_notes/epics_service_spec.rb' - 'ee/spec/services/system_notes/merge_train_service_spec.rb' - 'ee/spec/services/todo_service_spec.rb' - 'ee/spec/services/todos/destroy/confidential_epic_service_spec.rb' + - 'ee/spec/services/upcoming_reconciliations/update_service_spec.rb' - 'ee/spec/services/users_ops_dashboard_projects/destroy_service_spec.rb' + - 'ee/spec/services/vulnerabilities/confirm_service_spec.rb' + - 'ee/spec/services/vulnerabilities/destroy_dismissal_feedback_service_spec.rb' + - 'ee/spec/services/vulnerabilities/historical_statistics/adjustment_service_spec.rb' + - 'ee/spec/services/vulnerabilities/historical_statistics/deletion_service_spec.rb' + - 'ee/spec/services/vulnerabilities/resolve_service_spec.rb' + - 'ee/spec/services/vulnerabilities/revert_to_detected_service_spec.rb' + - 'ee/spec/services/vulnerabilities/security_finding/create_issue_service_spec.rb' + - 'ee/spec/services/vulnerabilities/starboard_vulnerability_create_service_spec.rb' + - 'ee/spec/services/vulnerabilities/statistics/adjustment_service_spec.rb' - 'ee/spec/services/vulnerabilities/statistics/update_service_spec.rb' + - 'ee/spec/services/vulnerability_exports/create_service_spec.rb' - 'ee/spec/services/vulnerability_exports/export_service_spec.rb' + - 'ee/spec/services/vulnerability_external_issue_links/create_service_spec.rb' + - 'ee/spec/services/vulnerability_external_issue_links/destroy_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/create_service_spec.rb' - 'ee/spec/services/vulnerability_feedback/destroy_service_spec.rb' + - 'ee/spec/services/vulnerability_issue_links/create_service_spec.rb' + - 'ee/spec/services/vulnerability_issue_links/delete_service_spec.rb' - 'ee/spec/support/shared_contexts/audit_event_not_licensed_shared_context.rb' - 'ee/spec/support/shared_examples/graphql/mutations/update_health_status_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/concerns/blob_replicator_strategy_shared_examples.rb' - 'ee/spec/support/shared_examples/models/concerns/replicable_model_with_separate_table_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/concerns/repository_replicator_strategy_shared_examples.rb' + - 'ee/spec/support/shared_examples/models/concerns/verifiable_replicator_shared_examples.rb' - 'ee/spec/support/shared_examples/models/geo_verifiable_registry_shared_examples.rb' - 'ee/spec/support/shared_examples/services/group_saml/saml_provider/base_service_shared_examples.rb' - 'ee/spec/support/shared_examples/services/update_issuable_health_status_shared_examples.rb' + - 'ee/spec/support/shared_examples/services/vulnerabilities/removes_dismissal_feedback_from_associated_findings_shared_example.rb' - 'ee/spec/tasks/geo/git_rake_spec.rb' - 'ee/spec/tasks/gitlab/elastic_rake_spec.rb' + - 'ee/spec/workers/app_sec/dast/scanner_profiles_builds/consistency_worker_spec.rb' + - 'ee/spec/workers/app_sec/dast/scans/consistency_worker_spec.rb' + - 'ee/spec/workers/app_sec/dast/site_profiles_builds/consistency_worker_spec.rb' + - 'ee/spec/workers/ci/runners/stale_group_runners_prune_cron_worker_spec.rb' + - 'ee/spec/workers/ci/upstream_projects_subscriptions_cleanup_worker_spec.rb' - 'ee/spec/workers/ee/projects/inactive_projects_deletion_cron_worker_spec.rb' - 'ee/spec/workers/elastic_remove_expired_namespace_subscriptions_from_index_cron_worker_spec.rb' + - 'ee/spec/workers/geo/create_repository_updated_event_worker_spec.rb' + - 'ee/spec/workers/geo/prune_event_log_worker_spec.rb' - 'ee/spec/workers/geo/verification_state_backfill_service_spec.rb' + - 'ee/spec/workers/incident_management/oncall_rotations/persist_shifts_job_spec.rb' - 'ee/spec/workers/new_epic_worker_spec.rb' - 'ee/spec/workers/store_security_reports_worker_spec.rb' + - 'ee/spec/workers/vulnerability_exports/export_deletion_worker_spec.rb' + - 'spec/controllers/admin/applications_controller_spec.rb' + - 'spec/controllers/admin/clusters_controller_spec.rb' - 'spec/controllers/admin/groups_controller_spec.rb' - 'spec/controllers/admin/runners_controller_spec.rb' - 'spec/controllers/admin/spam_logs_controller_spec.rb' + - 'spec/controllers/admin/topics_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb' + - 'spec/controllers/groups/clusters_controller_spec.rb' - 'spec/controllers/groups/runners_controller_spec.rb' + - 'spec/controllers/groups/settings/applications_controller_spec.rb' - 'spec/controllers/groups_controller_spec.rb' - 'spec/controllers/import/bitbucket_controller_spec.rb' - 'spec/controllers/import/gitlab_controller_spec.rb' @@ -268,38 +365,71 @@ RSpec/ExpectChange: - 'spec/controllers/omniauth_callbacks_controller_spec.rb' - 'spec/controllers/profiles/gpg_keys_controller_spec.rb' - 'spec/controllers/profiles/keys_controller_spec.rb' + - 'spec/controllers/projects/artifacts_controller_spec.rb' + - 'spec/controllers/projects/clusters_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' + - 'spec/controllers/projects/feature_flags_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/controllers/projects/jobs_controller_spec.rb' - 'spec/controllers/projects/merge_requests/creations_controller_spec.rb' - 'spec/controllers/projects/merge_requests/drafts_controller_spec.rb' - 'spec/controllers/projects/merge_requests_controller_spec.rb' - 'spec/controllers/projects/mirrors_controller_spec.rb' - 'spec/controllers/projects/notes_controller_spec.rb' - 'spec/controllers/projects/pages_domains_controller_spec.rb' + - 'spec/controllers/projects/pipeline_schedules_controller_spec.rb' + - 'spec/controllers/projects/pipelines_controller_spec.rb' + - 'spec/controllers/projects/raw_controller_spec.rb' - 'spec/controllers/projects/runners_controller_spec.rb' + - 'spec/controllers/projects/settings/ci_cd_controller_spec.rb' - 'spec/controllers/projects_controller_spec.rb' - 'spec/controllers/repositories/lfs_storage_controller_spec.rb' - 'spec/controllers/sessions_controller_spec.rb' - 'spec/controllers/snippets/notes_controller_spec.rb' - 'spec/controllers/uploads_controller_spec.rb' + - 'spec/controllers/users/callouts_controller_spec.rb' - 'spec/features/admin/users/users_spec.rb' - 'spec/features/file_uploads/attachment_spec.rb' + - 'spec/features/file_uploads/ci_artifact_spec.rb' - 'spec/features/file_uploads/git_lfs_spec.rb' + - 'spec/features/file_uploads/graphql_add_design_spec.rb' - 'spec/features/file_uploads/group_import_spec.rb' + - 'spec/features/file_uploads/maven_package_spec.rb' + - 'spec/features/file_uploads/nuget_package_spec.rb' - 'spec/features/file_uploads/project_import_spec.rb' + - 'spec/features/file_uploads/rubygem_package_spec.rb' - 'spec/features/groups/import_export/import_file_spec.rb' - 'spec/features/groups_spec.rb' - 'spec/features/invites_spec.rb' + - 'spec/features/projects/environments/environment_spec.rb' + - 'spec/features/projects/environments/environments_spec.rb' - 'spec/features/projects/import_export/import_file_spec.rb' + - 'spec/features/projects/pipelines/legacy_pipelines_spec.rb' + - 'spec/features/projects/pipelines/pipelines_spec.rb' - 'spec/features/projects_spec.rb' - 'spec/features/users/signup_spec.rb' + - 'spec/finders/environments/environments_by_deployments_finder_spec.rb' + - 'spec/graphql/mutations/ci/job_token_scope/add_project_spec.rb' + - 'spec/graphql/mutations/ci/job_token_scope/remove_project_spec.rb' + - 'spec/graphql/mutations/ci/runner/bulk_delete_spec.rb' + - 'spec/graphql/mutations/ci/runner/delete_spec.rb' + - 'spec/graphql/mutations/clusters/agent_tokens/create_spec.rb' + - 'spec/graphql/mutations/clusters/agents/create_spec.rb' + - 'spec/graphql/mutations/clusters/agents/delete_spec.rb' + - 'spec/graphql/mutations/container_repositories/destroy_spec.rb' + - 'spec/graphql/mutations/container_repositories/destroy_tags_spec.rb' + - 'spec/graphql/mutations/dependency_proxy/image_ttl_group_policy/update_spec.rb' - 'spec/graphql/mutations/issues/set_severity_spec.rb' - 'spec/graphql/mutations/releases/delete_spec.rb' - 'spec/graphql/mutations/timelogs/delete_spec.rb' + - 'spec/helpers/markup_helper_spec.rb' + - 'spec/helpers/projects_helper_spec.rb' - 'spec/initializers/active_record_locking_spec.rb' - 'spec/lib/api/helpers_spec.rb' + - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/project_pipeline_spec.rb' - 'spec/lib/declarative_enum_spec.rb' + - 'spec/lib/gitaly/server_spec.rb' - 'spec/lib/gitlab/auth/ldap/access_spec.rb' - 'spec/lib/gitlab/auth/ldap/user_spec.rb' - 'spec/lib/gitlab/auth/o_auth/identity_linker_spec.rb' @@ -315,16 +445,21 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/background_task_spec.rb' - 'spec/lib/gitlab/bitbucket_import/importer_spec.rb' - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb' + - 'spec/lib/gitlab/cache/ci/project_pipeline_status_spec.rb' - 'spec/lib/gitlab/checks/matching_merge_request_spec.rb' - 'spec/lib/gitlab/ci/ansi2json/line_spec.rb' - 'spec/lib/gitlab/ci/config/external/context_spec.rb' - 'spec/lib/gitlab/ci/parsers/security/common_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/create_deployments_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/ensure_environments_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/chain/ensure_resource_groups_spec.rb' - 'spec/lib/gitlab/ci/pipeline/seed/environment_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/seed/processable/resource_group_spec.rb' - 'spec/lib/gitlab/ci/reports/security/report_spec.rb' - 'spec/lib/gitlab/ci/status/factory_spec.rb' + - 'spec/lib/gitlab/ci/trace/archive_spec.rb' - 'spec/lib/gitlab/ci/trace/chunked_io_spec.rb' + - 'spec/lib/gitlab/composer/cache_spec.rb' - 'spec/lib/gitlab/config/entry/validatable_spec.rb' - 'spec/lib/gitlab/daemon_spec.rb' - 'spec/lib/gitlab/database/async_indexes/index_creator_spec.rb' @@ -333,12 +468,20 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/database/background_migration/batched_migration_runner_spec.rb' - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' - 'spec/lib/gitlab/database/load_balancing/connection_proxy_spec.rb' + - 'spec/lib/gitlab/database/load_balancing/load_balancer_spec.rb' - 'spec/lib/gitlab/database/migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/batched_background_migration_helpers_spec.rb' + - 'spec/lib/gitlab/database/migrations/observers/query_log_spec.rb' - 'spec/lib/gitlab/database/migrations/observers/query_statistics_spec.rb' - 'spec/lib/gitlab/database/migrations/observers/total_database_size_change_spec.rb' + - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' + - 'spec/lib/gitlab/database/partitioning_spec.rb' - 'spec/lib/gitlab/database/reindexing/reindex_action_spec.rb' - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - 'spec/lib/gitlab/fogbugz_import/importer_spec.rb' + - 'spec/lib/gitlab/git/commit_spec.rb' + - 'spec/lib/gitlab/git/tag_spec.rb' - 'spec/lib/gitlab/git_access_project_spec.rb' - 'spec/lib/gitlab/github_import/importer/events/changed_assignee_spec.rb' - 'spec/lib/gitlab/github_import/importer/events/renamed_spec.rb' @@ -360,6 +503,7 @@ RSpec/ExpectChange: - 'spec/lib/gitlab/process_supervisor_spec.rb' - 'spec/lib/gitlab/query_limiting_spec.rb' - 'spec/lib/gitlab/reference_counter_spec.rb' + - 'spec/lib/gitlab/seeders/ci/daily_build_group_report_result_spec.rb' - 'spec/lib/gitlab/slash_commands/issue_move_spec.rb' - 'spec/lib/gitlab/word_diff/positions_counter_spec.rb' - 'spec/migrations/20210805192450_update_trial_plans_ci_daily_pipeline_schedule_triggers_spec.rb' @@ -371,11 +515,14 @@ RSpec/ExpectChange: - 'spec/migrations/20220202105733_delete_service_template_records_spec.rb' - 'spec/migrations/20220222192525_remove_null_releases_spec.rb' - 'spec/migrations/20220629184402_unset_escalation_policies_for_alert_incidents_spec.rb' + - 'spec/migrations/add_new_trail_plans_spec.rb' + - 'spec/migrations/add_open_source_plan_spec.rb' - 'spec/migrations/backfill_cycle_analytics_aggregations_spec.rb' - 'spec/migrations/bulk_insert_cluster_enabled_grants_spec.rb' - 'spec/migrations/cleanup_after_add_primary_email_to_emails_if_user_confirmed_spec.rb' - 'spec/migrations/cleanup_after_fixing_issue_when_admin_changed_primary_email_spec.rb' - 'spec/migrations/cleanup_after_fixing_regression_with_new_users_emails_spec.rb' + - 'spec/migrations/delete_security_findings_without_uuid_spec.rb' - 'spec/migrations/populate_audit_event_streaming_verification_token_spec.rb' - 'spec/migrations/remove_records_without_group_from_webhooks_table_spec.rb' - 'spec/migrations/remove_wiki_notes_spec.rb' @@ -389,11 +536,14 @@ RSpec/ExpectChange: - 'spec/models/ci/build_spec.rb' - 'spec/models/ci/deleted_object_spec.rb' - 'spec/models/ci/namespace_mirror_spec.rb' + - 'spec/models/ci/pipeline_artifact_spec.rb' - 'spec/models/ci/pipeline_schedule_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/ci/processable_spec.rb' - 'spec/models/ci/project_mirror_spec.rb' - 'spec/models/ci/ref_spec.rb' - 'spec/models/ci/runner_spec.rb' + - 'spec/models/clusters/applications/runner_spec.rb' - 'spec/models/clusters/cluster_spec.rb' - 'spec/models/commit_status_spec.rb' - 'spec/models/concerns/atomic_internal_id_spec.rb' @@ -410,6 +560,7 @@ RSpec/ExpectChange: - 'spec/models/container_repository_spec.rb' - 'spec/models/customer_relations/issue_contact_spec.rb' - 'spec/models/design_management/version_spec.rb' + - 'spec/models/error_tracking/project_error_tracking_setting_spec.rb' - 'spec/models/event_spec.rb' - 'spec/models/experiment_spec.rb' - 'spec/models/group_spec.rb' @@ -423,6 +574,7 @@ RSpec/ExpectChange: - 'spec/models/member_spec.rb' - 'spec/models/merge_request_spec.rb' - 'spec/models/packages/package_file_spec.rb' + - 'spec/models/packages/package_spec.rb' - 'spec/models/pages_domain_spec.rb' - 'spec/models/plan_spec.rb' - 'spec/models/project_auto_devops_spec.rb' @@ -437,6 +589,7 @@ RSpec/ExpectChange: - 'spec/models/route_spec.rb' - 'spec/models/sent_notification_spec.rb' - 'spec/models/snippet_spec.rb' + - 'spec/models/terraform/state_spec.rb' - 'spec/models/upload_spec.rb' - 'spec/models/user_interacted_project_spec.rb' - 'spec/models/user_spec.rb' @@ -444,18 +597,33 @@ RSpec/ExpectChange: - 'spec/models/x509_certificate_spec.rb' - 'spec/models/x509_issuer_spec.rb' - 'spec/requests/abuse_reports_controller_spec.rb' + - 'spec/requests/api/admin/ci/variables_spec.rb' + - 'spec/requests/api/applications_spec.rb' - 'spec/requests/api/broadcast_messages_spec.rb' + - 'spec/requests/api/ci/pipeline_schedules_spec.rb' - 'spec/requests/api/ci/pipelines_spec.rb' - 'spec/requests/api/ci/runner/jobs_trace_spec.rb' - 'spec/requests/api/commit_statuses_spec.rb' - 'spec/requests/api/deploy_keys_spec.rb' - 'spec/requests/api/deploy_tokens_spec.rb' + - 'spec/requests/api/error_tracking/collector_spec.rb' + - 'spec/requests/api/feature_flags_spec.rb' + - 'spec/requests/api/freeze_periods_spec.rb' + - 'spec/requests/api/generic_packages_spec.rb' - 'spec/requests/api/graphql/mutations/award_emojis/add_spec.rb' - 'spec/requests/api/graphql/mutations/award_emojis/remove_spec.rb' - 'spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb' - 'spec/requests/api/graphql/mutations/boards/destroy_spec.rb' + - 'spec/requests/api/graphql/mutations/clusters/agent_tokens/agent_tokens/create_spec.rb' + - 'spec/requests/api/graphql/mutations/clusters/agents/create_spec.rb' + - 'spec/requests/api/graphql/mutations/clusters/agents/delete_spec.rb' + - 'spec/requests/api/graphql/mutations/container_repository/destroy_spec.rb' + - 'spec/requests/api/graphql/mutations/container_repository/destroy_tags_spec.rb' - 'spec/requests/api/graphql/mutations/labels/create_spec.rb' + - 'spec/requests/api/graphql/mutations/metrics/dashboard/annotations/create_spec.rb' + - 'spec/requests/api/graphql/mutations/metrics/dashboard/annotations/delete_spec.rb' - 'spec/requests/api/graphql/mutations/notes/destroy_spec.rb' + - 'spec/requests/api/graphql/mutations/packages/cleanup/policy/update_spec.rb' - 'spec/requests/api/graphql/mutations/releases/delete_spec.rb' - 'spec/requests/api/graphql/mutations/snippets/create_spec.rb' - 'spec/requests/api/graphql/mutations/snippets/destroy_spec.rb' @@ -463,21 +631,35 @@ RSpec/ExpectChange: - 'spec/requests/api/group_import_spec.rb' - 'spec/requests/api/groups_spec.rb' - 'spec/requests/api/internal/base_spec.rb' + - 'spec/requests/api/maven_packages_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/notes_spec.rb' + - 'spec/requests/api/npm_project_packages_spec.rb' - 'spec/requests/api/project_snippets_spec.rb' - 'spec/requests/api/projects_spec.rb' + - 'spec/requests/api/pypi_packages_spec.rb' + - 'spec/requests/api/release/links_spec.rb' - 'spec/requests/api/releases_spec.rb' + - 'spec/requests/api/rubygem_packages_spec.rb' - 'spec/requests/api/snippets_spec.rb' + - 'spec/requests/api/terraform/modules/v1/packages_spec.rb' + - 'spec/requests/api/terraform/state_spec.rb' + - 'spec/requests/api/terraform/state_version_spec.rb' - 'spec/requests/api/users_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/import/gitlab_groups_controller_spec.rb' + - 'spec/requests/oauth_tokens_spec.rb' - 'spec/requests/product_analytics/collector_app_spec.rb' - 'spec/requests/projects/issue_links_controller_spec.rb' + - 'spec/requests/projects/merge_requests_discussions_spec.rb' - 'spec/requests/projects/settings/access_tokens_controller_spec.rb' + - 'spec/requests/users/group_callouts_spec.rb' + - 'spec/requests/users/namespace_callouts_spec.rb' + - 'spec/requests/users/project_callouts_spec.rb' - 'spec/services/alert_management/alerts/todo/create_service_spec.rb' - 'spec/services/alert_management/alerts/update_service_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' + - 'spec/services/applications/create_service_spec.rb' - 'spec/services/authorized_project_update/project_recalculate_per_user_service_spec.rb' - 'spec/services/authorized_project_update/project_recalculate_service_spec.rb' - 'spec/services/award_emojis/add_service_spec.rb' @@ -486,18 +668,39 @@ RSpec/ExpectChange: - 'spec/services/award_emojis/toggle_service_spec.rb' - 'spec/services/bulk_imports/create_service_spec.rb' - 'spec/services/bulk_imports/relation_export_service_spec.rb' + - 'spec/services/ci/build_report_result_service_spec.rb' - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' + - 'spec/services/ci/daily_build_group_report_result_service_spec.rb' + - 'spec/services/ci/delete_objects_service_spec.rb' - 'spec/services/ci/destroy_pipeline_service_spec.rb' + - 'spec/services/ci/ensure_stage_service_spec.rb' + - 'spec/services/ci/job_artifacts/create_service_spec.rb' - 'spec/services/ci/job_artifacts/delete_service_spec.rb' + - 'spec/services/ci/job_artifacts/destroy_all_expired_service_spec.rb' + - 'spec/services/ci/job_artifacts/destroy_associations_service_spec.rb' + - 'spec/services/ci/job_artifacts/destroy_batch_service_spec.rb' - 'spec/services/ci/job_artifacts/update_unknown_locked_status_service_spec.rb' + - 'spec/services/ci/job_token_scope/add_project_service_spec.rb' + - 'spec/services/ci/job_token_scope/remove_project_service_spec.rb' + - 'spec/services/ci/pipeline_artifacts/coverage_report_service_spec.rb' + - 'spec/services/ci/pipeline_artifacts/create_code_quality_mr_diff_report_service_spec.rb' + - 'spec/services/ci/pipeline_artifacts/destroy_all_expired_service_spec.rb' + - 'spec/services/ci/pipeline_trigger_service_spec.rb' - 'spec/services/ci/play_build_service_spec.rb' - 'spec/services/ci/process_build_service_spec.rb' - 'spec/services/ci/retry_job_service_spec.rb' - 'spec/services/ci/retry_pipeline_service_spec.rb' - 'spec/services/ci/run_scheduled_build_service_spec.rb' + - 'spec/services/ci/runners/bulk_delete_runners_service_spec.rb' + - 'spec/services/ci/runners/unregister_runner_service_spec.rb' - 'spec/services/ci/update_build_queue_service_spec.rb' - 'spec/services/ci/update_build_state_service_spec.rb' + - 'spec/services/ci/update_instance_variables_service_spec.rb' + - 'spec/services/clusters/agent_tokens/create_service_spec.rb' + - 'spec/services/clusters/agents/create_service_spec.rb' + - 'spec/services/clusters/agents/delete_service_spec.rb' + - 'spec/services/clusters/create_service_spec.rb' - 'spec/services/clusters/destroy_service_spec.rb' - 'spec/services/container_expiration_policies/cleanup_service_spec.rb' - 'spec/services/deployments/create_for_build_service_spec.rb' @@ -509,17 +712,21 @@ RSpec/ExpectChange: - 'spec/services/draft_notes/destroy_service_spec.rb' - 'spec/services/draft_notes/publish_service_spec.rb' - 'spec/services/emails/create_service_spec.rb' + - 'spec/services/error_tracking/collect_error_service_spec.rb' - 'spec/services/error_tracking/list_projects_service_spec.rb' - 'spec/services/event_create_service_spec.rb' - 'spec/services/feature_flags/create_service_spec.rb' - 'spec/services/feature_flags/destroy_service_spec.rb' - 'spec/services/feature_flags/update_service_spec.rb' + - 'spec/services/git/branch_push_service_spec.rb' - 'spec/services/git/process_ref_changes_service_spec.rb' + - 'spec/services/git/tag_hooks_service_spec.rb' - 'spec/services/groups/create_service_spec.rb' - 'spec/services/groups/import_export/import_service_spec.rb' - 'spec/services/groups/transfer_service_spec.rb' - 'spec/services/groups/update_service_spec.rb' - 'spec/services/groups/update_statistics_service_spec.rb' + - 'spec/services/incident_management/timeline_events/create_service_spec.rb' - 'spec/services/incident_management/timeline_events/update_service_spec.rb' - 'spec/services/issuable/common_system_notes_service_spec.rb' - 'spec/services/issues/close_service_spec.rb' @@ -533,6 +740,7 @@ RSpec/ExpectChange: - 'spec/services/lfs/lock_file_service_spec.rb' - 'spec/services/merge_requests/add_spent_time_service_spec.rb' - 'spec/services/merge_requests/close_service_spec.rb' + - 'spec/services/merge_requests/create_pipeline_service_spec.rb' - 'spec/services/merge_requests/create_service_spec.rb' - 'spec/services/merge_requests/ff_merge_service_spec.rb' - 'spec/services/merge_requests/merge_service_spec.rb' @@ -544,24 +752,48 @@ RSpec/ExpectChange: - 'spec/services/merge_requests/update_service_spec.rb' - 'spec/services/milestones/destroy_service_spec.rb' - 'spec/services/namespace_settings/update_service_spec.rb' + - 'spec/services/namespaces/in_product_marketing_emails_service_spec.rb' - 'spec/services/notes/create_service_spec.rb' - 'spec/services/notes/destroy_service_spec.rb' - 'spec/services/notes/quick_actions_service_spec.rb' - 'spec/services/packages/cleanup/update_policy_service_spec.rb' + - 'spec/services/packages/composer/create_package_service_spec.rb' + - 'spec/services/packages/create_dependency_service_spec.rb' + - 'spec/services/packages/create_event_service_spec.rb' + - 'spec/services/packages/create_temporary_package_service_spec.rb' + - 'spec/services/packages/debian/find_or_create_package_service_spec.rb' + - 'spec/services/packages/debian/process_changes_service_spec.rb' + - 'spec/services/packages/generic/create_package_file_service_spec.rb' + - 'spec/services/packages/go/create_package_service_spec.rb' - 'spec/services/packages/helm/process_file_service_spec.rb' - 'spec/services/packages/mark_package_for_destruction_service_spec.rb' + - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' + - 'spec/services/packages/npm/create_package_service_spec.rb' + - 'spec/services/packages/npm/create_tag_service_spec.rb' + - 'spec/services/packages/nuget/create_dependency_service_spec.rb' + - 'spec/services/packages/nuget/sync_metadatum_service_spec.rb' + - 'spec/services/packages/nuget/update_package_from_metadata_service_spec.rb' + - 'spec/services/packages/pypi/create_package_service_spec.rb' + - 'spec/services/packages/remove_tag_service_spec.rb' + - 'spec/services/packages/rubygems/create_dependencies_service_spec.rb' + - 'spec/services/packages/rubygems/metadata_extraction_service_spec.rb' + - 'spec/services/packages/terraform_module/create_package_service_spec.rb' - 'spec/services/packages/update_package_file_service_spec.rb' + - 'spec/services/packages/update_tags_service_spec.rb' - 'spec/services/pages/delete_service_spec.rb' - 'spec/services/pages/destroy_deployments_service_spec.rb' - 'spec/services/pages_domains/retry_acme_order_service_spec.rb' - 'spec/services/personal_access_tokens/last_used_service_spec.rb' - 'spec/services/projects/auto_devops/disable_service_spec.rb' + - 'spec/services/projects/destroy_service_spec.rb' - 'spec/services/projects/fetch_statistics_increment_service_spec.rb' - 'spec/services/projects/hashed_storage/migration_service_spec.rb' - 'spec/services/projects/hashed_storage/rollback_repository_service_spec.rb' - 'spec/services/projects/hashed_storage/rollback_service_spec.rb' + - 'spec/services/projects/in_product_marketing_campaign_emails_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' - 'spec/services/projects/record_target_platforms_service_spec.rb' + - 'spec/services/projects/transfer_service_spec.rb' - 'spec/services/projects/update_pages_service_spec.rb' - 'spec/services/projects/update_service_spec.rb' - 'spec/services/quick_actions/interpret_service_spec.rb' @@ -594,14 +826,17 @@ RSpec/ExpectChange: - 'spec/services/users/update_service_spec.rb' - 'spec/services/verify_pages_domain_service_spec.rb' - 'spec/services/work_items/parent_links/create_service_spec.rb' + - 'spec/support/services/clusters/create_service_shared.rb' - 'spec/support/services/deploy_token_shared_examples.rb' - 'spec/support/services/issuable_import_csv_service_shared_examples.rb' - 'spec/support/shared_contexts/email_shared_context.rb' + - 'spec/support/shared_examples/controllers/clusters_controller_shared_examples.rb' - 'spec/support/shared_examples/controllers/githubish_import_controller_shared_examples.rb' - 'spec/support/shared_examples/controllers/variables_shared_examples.rb' - 'spec/support/shared_examples/graphql/mutations/boards_create_shared_examples.rb' - 'spec/support/shared_examples/graphql/notes_creation_shared_examples.rb' - 'spec/support/shared_examples/incident_management/issuable_escalation_statuses/build_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/ci/ci_trace_shared_examples.rb' - 'spec/support/shared_examples/loose_foreign_keys/have_loose_foreign_key.rb' - 'spec/support/shared_examples/models/commit_signature_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/bulk_insert_safe_shared_examples.rb' @@ -610,17 +845,29 @@ RSpec/ExpectChange: - 'spec/support/shared_examples/models/concerns/incident_management/escalatable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/limitable_shared_examples.rb' - 'spec/support/shared_examples/models/concerns/repository_storage_movable_shared_examples.rb' + - 'spec/support/shared_examples/models/cycle_analytics_stage_shared_examples.rb' - 'spec/support/shared_examples/models/member_shared_examples.rb' - 'spec/support/shared_examples/models/packages/debian/component_file_shared_example.rb' - 'spec/support/shared_examples/models/with_uploads_shared_examples.rb' - 'spec/support/shared_examples/requests/access_tokens_controller_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/conan_packages_shared_examples.rb' - 'spec/support/shared_examples/requests/api/graphql/mutations/destroy_list_shared_examples.rb' - 'spec/support/shared_examples/requests/api/graphql/read_only_instance_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/helm_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/npm_packages_tags_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/nuget_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/pypi_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/rubygems_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/terraform/modules/v1/packages_shared_examples.rb' - 'spec/support/shared_examples/services/common_system_notes_shared_examples.rb' - 'spec/support/shared_examples/services/container_expiration_policy_shared_examples.rb' - 'spec/support/shared_examples/services/container_registry_auth_service_shared_examples.rb' + - 'spec/support/shared_examples/services/dependency_proxy_ttl_policies_shared_examples.rb' - 'spec/support/shared_examples/services/issuable_links/create_links_shared_examples.rb' - 'spec/support/shared_examples/services/merge_request_shared_examples.rb' + - 'spec/support/shared_examples/services/namespace_package_settings_shared_examples.rb' + - 'spec/support/shared_examples/services/packages_shared_examples.rb' - 'spec/support/shared_examples/services/rate_limited_service_shared_examples.rb' - 'spec/support/shared_examples/services/repositories/housekeeping_shared_examples.rb' - 'spec/support/shared_examples/services/updating_mentions_shared_examples.rb' @@ -633,14 +880,26 @@ RSpec/ExpectChange: - 'spec/tooling/rspec_flaky/listener_spec.rb' - 'spec/uploaders/file_uploader_spec.rb' - 'spec/uploaders/records_uploads_spec.rb' + - 'spec/workers/analytics/usage_trends/counter_job_worker_spec.rb' - 'spec/workers/destroy_pages_deployments_worker_spec.rb' - 'spec/workers/environments/auto_delete_cron_worker_spec.rb' - 'spec/workers/gitlab/phabricator_import/base_worker_spec.rb' - 'spec/workers/gitlab_service_ping_worker_spec.rb' - 'spec/workers/group_import_worker_spec.rb' - 'spec/workers/incident_management/process_alert_worker_v2_spec.rb' + - 'spec/workers/namespaces/root_statistics_worker_spec.rb' + - 'spec/workers/namespaces/schedule_aggregation_worker_spec.rb' - 'spec/workers/new_issue_worker_spec.rb' - 'spec/workers/new_merge_request_worker_spec.rb' + - 'spec/workers/packages/cleanup_package_file_worker_spec.rb' + - 'spec/workers/packages/composer/cache_cleanup_worker_spec.rb' + - 'spec/workers/packages/composer/cache_update_worker_spec.rb' + - 'spec/workers/packages/debian/process_changes_worker_spec.rb' + - 'spec/workers/packages/go/sync_packages_worker_spec.rb' + - 'spec/workers/packages/helm/extraction_worker_spec.rb' + - 'spec/workers/packages/maven/metadata/sync_worker_spec.rb' + - 'spec/workers/packages/nuget/extraction_worker_spec.rb' + - 'spec/workers/packages/rubygems/extraction_worker_spec.rb' - 'spec/workers/pages_domain_removal_cron_worker_spec.rb' - 'spec/workers/projects/post_creation_worker_spec.rb' - 'spec/workers/prune_old_events_worker_spec.rb' diff --git a/.rubocop_todo/rspec/file_path.yml b/.rubocop_todo/rspec/file_path.yml new file mode 100644 index 00000000000..60ef265fafe --- /dev/null +++ b/.rubocop_todo/rspec/file_path.yml @@ -0,0 +1,65 @@ +--- +RSpec/FilePath: + Details: grace period + Exclude: + - 'ee/spec/frontend/fixtures/analytics/charts.rb' + - 'ee/spec/frontend/fixtures/analytics/devops_reports/devops_adoption/enabled_namespaces.rb' + - 'ee/spec/frontend/fixtures/analytics/metrics.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams_code_stage.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams_issue_stage.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams_plan_stage.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams_review_stage.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams_staging_stage.rb' + - 'ee/spec/frontend/fixtures/analytics/value_streams_test_stage.rb' + - 'ee/spec/frontend/fixtures/dora/metrics.rb' + - 'ee/spec/models/merge_request/blocking_spec.rb' + - 'ee/spec/requests/api/ci/runner/jobs_put_spec.rb' + - 'ee/spec/requests/api/ci/runner/jobs_trace_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/compliance_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/cross_needs_artifacts_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/needs_spec.rb' + - 'ee/spec/services/ci/create_pipeline_service/runnable_builds_spec.rb' + - 'spec/benchmarks/banzai_benchmark.rb' + - 'spec/docs_screenshots/container_registry_docs.rb' + - 'spec/docs_screenshots/wiki_docs.rb' + - 'spec/lib/error_tracking/sentry_client/event_spec.rb' + - 'spec/lib/gitlab/import_export/import_export_equivalence_spec.rb' + - 'spec/lib/gitlab/import_export/import_export_spec.rb' + - 'spec/lib/gitlab/mail_room/mail_room_spec.rb' + - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' + - 'spec/requests/api/ci/runner/jobs_put_spec.rb' + - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' + - 'spec/requests/api/ci/runner/jobs_trace_spec.rb' + - 'spec/requests/api/ci/runner/runners_delete_spec.rb' + - 'spec/requests/api/ci/runner/runners_post_spec.rb' + - 'spec/requests/api/ci/runner/runners_reset_spec.rb' + - 'spec/requests/api/ci/runner/runners_verify_post_spec.rb' + - 'spec/requests/api/issues/get_group_issues_spec.rb' + - 'spec/requests/api/issues/get_project_issues_spec.rb' + - 'spec/requests/api/issues/issues_spec.rb' + - 'spec/requests/api/issues/post_projects_issues_spec.rb' + - 'spec/requests/api/issues/put_projects_issues_spec.rb' + - 'spec/requests/api/pages/pages_spec.rb' + - 'spec/services/ci/create_pipeline_service/artifacts_spec.rb' + - 'spec/services/ci/create_pipeline_service/cache_spec.rb' + - 'spec/services/ci/create_pipeline_service/creation_errors_and_warnings_spec.rb' + - 'spec/services/ci/create_pipeline_service/cross_project_pipeline_spec.rb' + - 'spec/services/ci/create_pipeline_service/custom_config_content_spec.rb' + - 'spec/services/ci/create_pipeline_service/custom_yaml_tags_spec.rb' + - 'spec/services/ci/create_pipeline_service/dry_run_spec.rb' + - 'spec/services/ci/create_pipeline_service/environment_spec.rb' + - 'spec/services/ci/create_pipeline_service/evaluate_runner_tags_spec.rb' + - 'spec/services/ci/create_pipeline_service/include_spec.rb' + - 'spec/services/ci/create_pipeline_service/logger_spec.rb' + - 'spec/services/ci/create_pipeline_service/merge_requests_spec.rb' + - 'spec/services/ci/create_pipeline_service/needs_spec.rb' + - 'spec/services/ci/create_pipeline_service/parallel_spec.rb' + - 'spec/services/ci/create_pipeline_service/parameter_content_spec.rb' + - 'spec/services/ci/create_pipeline_service/parent_child_pipeline_spec.rb' + - 'spec/services/ci/create_pipeline_service/partitioning_spec.rb' + - 'spec/services/ci/create_pipeline_service/pre_post_stages_spec.rb' + - 'spec/services/ci/create_pipeline_service/rate_limit_spec.rb' + - 'spec/services/ci/create_pipeline_service/rules_spec.rb' + - 'spec/services/ci/create_pipeline_service/tags_spec.rb' diff --git a/.rubocop_todo/rspec/let_before_examples.yml b/.rubocop_todo/rspec/let_before_examples.yml new file mode 100644 index 00000000000..f84df4bdb5f --- /dev/null +++ b/.rubocop_todo/rspec/let_before_examples.yml @@ -0,0 +1,17 @@ +--- +# Cop supports --auto-correct. +RSpec/LetBeforeExamples: + Exclude: + - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' + - 'ee/spec/models/resource_weight_event_spec.rb' + - 'ee/spec/models/vulnerabilities/feedback_spec.rb' + - 'ee/spec/requests/api/internal/kubernetes_spec.rb' + - 'ee/spec/requests/api/scim_spec.rb' + - 'spec/graphql/types/ci/detailed_status_type_spec.rb' + - 'spec/graphql/types/merge_request_type_spec.rb' + - 'spec/graphql/types/snippets/blob_type_spec.rb' + - 'spec/models/ci/job_token/project_scope_link_spec.rb' + - 'spec/models/ci/runner_version_spec.rb' + - 'spec/models/group_deploy_key_spec.rb' + - 'spec/models/snippet_repository_spec.rb' + - 'spec/requests/api/issue_links_spec.rb' diff --git a/.rubocop_todo/rspec/multiple_memoized_helpers.yml b/.rubocop_todo/rspec/multiple_memoized_helpers.yml index 8330d768794..fc26b5e3065 100644 --- a/.rubocop_todo/rspec/multiple_memoized_helpers.yml +++ b/.rubocop_todo/rspec/multiple_memoized_helpers.yml @@ -1,9 +1,38 @@ --- RSpec/MultipleMemoizedHelpers: + Details: grace period Exclude: - - spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb - - spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb - - spec/requests/api/ci/runner/jobs_artifacts_spec.rb - - ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb - - ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb - - ee/spec/services/ee/boards/issues/move_service_spec.rb + - 'ee/spec/features/boards/swimlanes/epics_swimlanes_filtering_spec.rb' + - 'ee/spec/finders/epics_finder_spec.rb' + - 'ee/spec/finders/incident_management/oncall_users_finder_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/populate_latest_pipeline_ids_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/populate_uuids_for_security_findings_spec.rb' + - 'ee/spec/lib/gitlab/graphql/loaders/bulk_epic_aggregate_loader_spec.rb' + - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' + - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' + - 'ee/spec/services/ee/boards/issues/move_service_spec.rb' + - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' + - 'spec/features/boards/boards_spec.rb' + - 'spec/finders/ci/runners_finder_spec.rb' + - 'spec/finders/labels_finder_spec.rb' + - 'spec/finders/user_recent_events_finder_spec.rb' + - 'spec/lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid_spec.rb' + - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' + - 'spec/migrations/backfill_escalation_policies_for_oncall_schedules_spec.rb' + - 'spec/models/event_spec.rb' + - 'spec/models/milestone_spec.rb' + - 'spec/models/packages/package_file_spec.rb' + - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' + - 'spec/requests/api/issues/get_group_issues_spec.rb' + - 'spec/requests/api/issues/get_project_issues_spec.rb' + - 'spec/requests/api/issues/issues_spec.rb' + - 'spec/requests/api/issues/put_projects_issues_spec.rb' + - 'spec/requests/api/maven_packages_spec.rb' + - 'spec/services/boards/issues/list_service_spec.rb' + - 'spec/services/labels/promote_service_spec.rb' + - 'spec/services/merge_requests/push_options_handler_service_spec.rb' + - 'spec/services/packages/cleanup/execute_policy_service_spec.rb' + - 'spec/services/todo_service_spec.rb' + - 'spec/services/todos/destroy/entity_leave_service_spec.rb' + - 'spec/support/shared_contexts/policies/project_policy_shared_context.rb' + - 'spec/support/shared_contexts/requests/api/debian_repository_shared_context.rb' diff --git a/.rubocop_todo/rspec/overwriting_setup.yml b/.rubocop_todo/rspec/overwriting_setup.yml new file mode 100644 index 00000000000..630f08eb72f --- /dev/null +++ b/.rubocop_todo/rspec/overwriting_setup.yml @@ -0,0 +1,17 @@ +--- +RSpec/OverwritingSetup: + Exclude: + - 'ee/spec/features/groups/analytics/ci_cd_analytics_spec.rb' + - 'ee/spec/lib/gitlab/analytics/type_of_work/tasks_by_type_spec.rb' + - 'ee/spec/models/ee/iteration_spec.rb' + - 'ee/spec/requests/api/namespaces_spec.rb' + - 'ee/spec/services/epics/descendant_count_service_spec.rb' + - 'spec/finders/packages/helm/packages_finder_spec.rb' + - 'spec/finders/packages/npm/package_finder_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' + - 'spec/models/packages/package_file_spec.rb' + - 'spec/models/todo_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/policies/ci/build_policy_spec.rb' + - 'spec/services/packages/nuget/search_service_spec.rb' + - 'spec/services/projects/container_repository/gitlab/cleanup_tags_service_spec.rb' diff --git a/.rubocop_todo/rspec/scattered_let.yml b/.rubocop_todo/rspec/scattered_let.yml index 93f373b0a9e..16ae879c531 100644 --- a/.rubocop_todo/rspec/scattered_let.yml +++ b/.rubocop_todo/rspec/scattered_let.yml @@ -1,123 +1,145 @@ --- # Cop supports --auto-correct. RSpec/ScatteredLet: + Details: grace period Exclude: + - 'ee/spec/features/boards/user_visits_board_spec.rb' - 'ee/spec/features/groups/group_roadmap_spec.rb' - - 'ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb' + - 'ee/spec/features/milestones/user_views_milestone_spec.rb' + - 'ee/spec/finders/analytics/devops_adoption/enabled_namespaces_finder_spec.rb' + - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' + - 'ee/spec/finders/issues_finder_spec.rb' - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' - - 'ee/spec/finders/security/vulnerability_reads_finder_spec.rb' - - 'ee/spec/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' + - 'ee/spec/frontend/fixtures/runner.rb' + - 'ee/spec/graphql/ee/types/clusters/agent_type_spec.rb' - 'ee/spec/graphql/mutations/boards/epics/create_spec.rb' - - 'ee/spec/graphql/mutations/dast_site_profiles/create_spec.rb' - 'ee/spec/graphql/mutations/merge_requests/accept_spec.rb' - 'ee/spec/graphql/mutations/releases/update_spec.rb' + - 'ee/spec/graphql/resolvers/analytics/devops_adoption/enabled_namespaces_resolver_spec.rb' + - 'ee/spec/graphql/resolvers/clusters/agents_resolver_spec.rb' - 'ee/spec/graphql/resolvers/security_orchestration/scan_execution_policy_resolver_spec.rb' + - 'ee/spec/graphql/types/asset_type_spec.rb' - 'ee/spec/graphql/types/boards/board_epic_type_spec.rb' - 'ee/spec/graphql/types/instance_security_dashboard_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_evidence_source_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_evidence_supporting_message_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_evidence_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_request_response_header_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_request_type_spec.rb' + - 'ee/spec/graphql/types/vulnerability_response_type_spec.rb' + - 'ee/spec/helpers/ee/integrations_helper_spec.rb' - 'ee/spec/helpers/ee/subscribable_banner_helper_spec.rb' - - 'ee/spec/helpers/trial_status_widget_helper_spec.rb' + - 'ee/spec/lib/audit/external_status_check_changes_auditor_spec.rb' + - 'ee/spec/lib/ee/api/helpers/members_helpers_spec.rb' - 'ee/spec/lib/ee/audit/compliance_framework_changes_auditor_spec.rb' - - 'ee/spec/lib/ee/gitlab/ci/config_spec.rb' - - 'ee/spec/lib/ee/gitlab/email/handler/service_desk_handler_spec.rb' + - 'ee/spec/lib/ee/gitlab/scim/provisioning_service_spec.rb' - 'ee/spec/lib/gitlab/background_migration/migrate_requirements_to_work_items_spec.rb' - 'ee/spec/lib/gitlab/ci/parsers/security/dast_spec.rb' - - 'ee/spec/lib/gitlab/ci/parsers/security/formatters/dependency_list_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb' - - 'ee/spec/lib/gitlab/ci/templates/dast_api_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/code_owners/loader_spec.rb' - 'ee/spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb' - 'ee/spec/lib/gitlab/elastic/bulk_indexer_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/repositories_changed_event_spec.rb' - - 'ee/spec/lib/gitlab/geo/log_cursor/events/repository_updated_event_spec.rb' - 'ee/spec/lib/gitlab/geo/replication/blob_downloader_spec.rb' - 'ee/spec/lib/gitlab/git_access_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/security_orchestration_policies/lazy_dast_profile_aggregate_spec.rb' - - 'ee/spec/lib/gitlab/graphql/aggregations/vulnerability_statistics/lazy_aggregate_spec.rb' - 'ee/spec/lib/gitlab/insights/reducers/count_per_label_reducer_spec.rb' - 'ee/spec/lib/gitlab/insights/reducers/label_count_per_period_reducer_spec.rb' + - 'ee/spec/lib/gitlab/usage/metrics/instrumentations/approval_project_rules_with_user_metric_spec.rb' - 'ee/spec/lib/gitlab/usage_data_metrics_spec.rb' - - 'ee/spec/models/analytics/cycle_analytics/group_level_spec.rb' - 'ee/spec/models/approval_wrapped_any_approver_rule_spec.rb' - - 'ee/spec/models/approvals/scan_finding_wrapped_rule_set_spec.rb' - - 'ee/spec/models/ci/minutes/notification_spec.rb' - - 'ee/spec/models/ci/pipeline_spec.rb' + - 'ee/spec/models/dast_site_validation_spec.rb' - 'ee/spec/models/ee/ci/build_dependencies_spec.rb' - - 'ee/spec/models/label_note_spec.rb' - - 'ee/spec/models/sca/license_compliance_spec.rb' - - 'ee/spec/policies/merge_request_policy_spec.rb' + - 'ee/spec/models/ee/iteration_spec.rb' + - 'ee/spec/models/ee/user_spec.rb' + - 'ee/spec/models/epic_spec.rb' + - 'ee/spec/models/preloaders/environments/protected_environment_preloader_spec.rb' + - 'ee/spec/models/vulnerabilities/historical_statistic_spec.rb' + - 'ee/spec/requests/api/analytics/project_deployment_frequency_spec.rb' - 'ee/spec/requests/api/graphql/compliance_management/merge_requests/compliance_violations_spec.rb' - 'ee/spec/requests/api/graphql/group/ci_cd_settings_spec.rb' - 'ee/spec/requests/api/graphql/group/epic/notes_spec.rb' - - 'ee/spec/requests/api/graphql/group_query_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/boards/epic_boards/epic_move_list_spec.rb' + - 'ee/spec/requests/api/graphql/instance_security_dashboard_spec.rb' - 'ee/spec/requests/api/graphql/mutations/incident_management/oncall_rotation/update_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/issues/promote_to_epic_spec.rb' - - 'ee/spec/requests/api/graphql/mutations/security_policy/commit_scan_execution_policy_spec.rb' - - 'ee/spec/requests/api/graphql/project/alert_management/http_integrations_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/projects/set_compliance_framework_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/security/finding/create_issue_spec.rb' - 'ee/spec/requests/api/graphql/project/dast_profile_schedule_spec.rb' + - 'ee/spec/requests/api/graphql/project/environments_spec.rb' - 'ee/spec/requests/api/graphql/project/pipeline/dast_profile_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/security_report_finding_spec.rb' + - 'ee/spec/requests/api/graphql/project/pipeline/security_report_summary_spec.rb' - 'ee/spec/requests/api/graphql/project/pipelines/dast_profile_spec.rb' - - 'ee/spec/requests/api/internal/base_spec.rb' - - 'ee/spec/requests/api/projects_spec.rb' + - 'ee/spec/requests/api/graphql/project/requirements_management/requirements_spec.rb' + - 'ee/spec/requests/api/graphql/project/requirements_management/test_reports_spec.rb' + - 'ee/spec/requests/api/graphql/vulnerabilities/details_spec.rb' + - 'ee/spec/requests/api/group_boards_spec.rb' + - 'ee/spec/requests/api/project_push_rule_spec.rb' - 'ee/spec/requests/api/settings_spec.rb' - 'ee/spec/requests/api/vulnerability_findings_spec.rb' - - 'ee/spec/requests/git_http_geo_spec.rb' - - 'ee/spec/serializers/license_compliance/collapsed_comparer_entity_spec.rb' - - 'ee/spec/serializers/status_page/incident_serializer_spec.rb' + - 'ee/spec/services/analytics/devops_adoption/snapshots/calculate_and_save_service_spec.rb' - 'ee/spec/services/app_sec/dast/scan_configs/fetch_service_spec.rb' - - 'ee/spec/services/app_sec/dast/scanner_profiles/update_service_spec.rb' - 'ee/spec/services/arkose/blocked_users_report_service_spec.rb' - - 'ee/spec/services/arkose/user_verification_service_spec.rb' - 'ee/spec/services/audit_event_service_spec.rb' - - 'ee/spec/services/audit_events/protected_branch_audit_event_service_spec.rb' + - 'ee/spec/services/boards/epics/move_service_spec.rb' + - 'ee/spec/services/compliance_management/frameworks/create_service_spec.rb' + - 'ee/spec/services/compliance_management/frameworks/update_service_spec.rb' + - 'ee/spec/services/concerns/epics/related_epic_links/usage_data_helper_spec.rb' - 'ee/spec/services/ee/issue_links/create_service_spec.rb' + - 'ee/spec/services/ee/issues/create_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/base_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/update_assignees_service_spec.rb' + - 'ee/spec/services/ee/merge_requests/update_reviewers_service_spec.rb' - 'ee/spec/services/epic_issues/create_service_spec.rb' - 'ee/spec/services/epics/issue_promote_service_spec.rb' - - 'ee/spec/services/gitlab_subscriptions/activate_service_spec.rb' + - 'ee/spec/services/geo/metrics_update_service_spec.rb' - 'ee/spec/services/group_saml/saml_provider/create_service_spec.rb' - 'ee/spec/services/group_saml/saml_provider/update_service_spec.rb' - 'ee/spec/services/groups/memberships/export_service_spec.rb' - 'ee/spec/services/incident_management/escalation_policies/create_service_spec.rb' - 'ee/spec/services/incident_management/oncall_rotations/remove_participant_service_spec.rb' - - 'ee/spec/services/merge_request_approval_settings/update_service_spec.rb' - - 'ee/spec/services/merge_trains/refresh_service_spec.rb' - - 'ee/spec/services/projects/destroy_service_spec.rb' - - 'ee/spec/services/projects/prometheus/alerts/notify_service_spec.rb' - - 'ee/spec/services/quality_management/test_cases/create_service_spec.rb' - - 'ee/spec/services/quick_actions/interpret_service_spec.rb' - - 'ee/spec/services/requirements_management/update_requirement_service_spec.rb' - - 'ee/spec/services/search/group_service_spec.rb' - - 'ee/spec/services/search/project_service_spec.rb' - - 'ee/spec/services/security/ingestion/tasks/update_vulnerability_uuids_spec.rb' - - 'ee/spec/services/todo_service_spec.rb' - - 'ee/spec/views/shared/_mirror_update_button.html.haml_spec.rb' + - 'ee/spec/services/members/activate_service_spec.rb' + - 'ee/spec/services/personal_access_tokens/groups/update_lifetime_service_spec.rb' + - 'ee/spec/services/security/report_summary_service_spec.rb' + - 'ee/spec/services/vulnerabilities/create_from_security_finding_service_spec.rb' + - 'ee/spec/services/vulnerabilities/findings/create_from_security_finding_service_spec.rb' + - 'ee/spec/services/vulnerabilities/security_finding/create_issue_service_spec.rb' - 'ee/spec/views/subscriptions/groups/edit.html.haml_spec.rb' - - 'ee/spec/workers/compliance_management/merge_requests/compliance_violations_worker_spec.rb' - 'ee/spec/workers/concerns/update_orchestration_policy_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_audit_logs_1_spec.rb' - - 'spec/controllers/projects/artifacts_controller_spec.rb' + - 'spec/controllers/concerns/metrics_dashboard_spec.rb' + - 'spec/controllers/import/bitbucket_server_controller_spec.rb' - 'spec/controllers/projects/deploy_keys_controller_spec.rb' - 'spec/controllers/projects/environments_controller_spec.rb' - 'spec/controllers/projects/issues_controller_spec.rb' - - 'spec/controllers/projects/releases/evidences_controller_spec.rb' - - 'spec/controllers/projects/releases_controller_spec.rb' - - 'spec/finders/ci/daily_build_group_report_results_finder_spec.rb' + - 'spec/controllers/projects/jobs_controller_spec.rb' + - 'spec/features/boards/user_visits_board_spec.rb' + - 'spec/features/groups/dependency_proxy_for_containers_spec.rb' + - 'spec/features/issues/user_filters_issues_spec.rb' - 'spec/finders/concerns/finder_with_cross_project_access_spec.rb' - - 'spec/finders/concerns/finder_with_group_hierarchy_spec.rb' - - 'spec/finders/events_finder_spec.rb' - 'spec/finders/group_projects_finder_spec.rb' + - 'spec/finders/groups/user_groups_finder_spec.rb' - 'spec/finders/license_template_finder_spec.rb' - - 'spec/frontend/fixtures/pipelines.rb' - - 'spec/graphql/resolvers/commit_pipelines_resolver_spec.rb' + - 'spec/finders/projects/groups_finder_spec.rb' + - 'spec/frontend/fixtures/jobs.rb' + - 'spec/graphql/resolvers/clusters/agents_resolver_spec.rb' + - 'spec/graphql/resolvers/concerns/looks_ahead_spec.rb' + - 'spec/graphql/resolvers/concerns/resolves_project_spec.rb' - 'spec/graphql/resolvers/design_management/version_in_collection_resolver_spec.rb' - - 'spec/graphql/resolvers/design_management/versions_resolver_spec.rb' + - 'spec/graphql/resolvers/group_milestones_resolver_spec.rb' + - 'spec/graphql/resolvers/users/groups_resolver_spec.rb' + - 'spec/graphql/types/base_object_spec.rb' - 'spec/graphql/types/ci/job_token_scope_type_spec.rb' + - 'spec/graphql/types/environment_type_spec.rb' + - 'spec/graphql/types/merge_request_type_spec.rb' + - 'spec/graphql/types/project_type_spec.rb' + - 'spec/graphql/types/terraform/state_version_type_spec.rb' + - 'spec/graphql/types/user_type_spec.rb' + - 'spec/helpers/blob_helper_spec.rb' - 'spec/helpers/merge_requests_helper_spec.rb' + - 'spec/lib/atlassian/jira_connect/jwt/asymmetric_spec.rb' - 'spec/lib/banzai/filter/references/project_reference_filter_spec.rb' - 'spec/lib/banzai/filter/references/user_reference_filter_spec.rb' - - 'spec/lib/banzai/filter/upload_link_filter_spec.rb' - 'spec/lib/banzai/reference_parser/alert_parser_spec.rb' - 'spec/lib/banzai/reference_parser/commit_parser_spec.rb' - 'spec/lib/banzai/reference_parser/commit_range_parser_spec.rb' + - 'spec/lib/banzai/reference_parser/design_parser_spec.rb' - 'spec/lib/banzai/reference_parser/external_issue_parser_spec.rb' - 'spec/lib/banzai/reference_parser/label_parser_spec.rb' - 'spec/lib/banzai/reference_parser/merge_request_parser_spec.rb' @@ -125,32 +147,29 @@ RSpec/ScatteredLet: - 'spec/lib/banzai/reference_parser/project_parser_spec.rb' - 'spec/lib/banzai/reference_parser/snippet_parser_spec.rb' - 'spec/lib/banzai/reference_parser/user_parser_spec.rb' + - 'spec/lib/bulk_imports/groups/pipelines/subgroup_entities_pipeline_spec.rb' - 'spec/lib/bulk_imports/pipeline/runner_spec.rb' - 'spec/lib/bulk_imports/projects/pipelines/snippets_repository_pipeline_spec.rb' - 'spec/lib/gitlab/asciidoc/include_processor_spec.rb' - 'spec/lib/gitlab/auth/ldap/person_spec.rb' - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' - 'spec/lib/gitlab/background_migration/backfill_imported_issue_search_data_spec.rb' - - 'spec/lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans_spec.rb' - 'spec/lib/gitlab/background_migration/disable_legacy_open_source_license_for_inactive_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/encrypt_static_object_token_spec.rb' - 'spec/lib/gitlab/background_migration/legacy_uploads_migrator_spec.rb' - 'spec/lib/gitlab/background_migration/nullify_orphan_runner_id_on_ci_builds_spec.rb' - 'spec/lib/gitlab/background_migration/reset_too_many_tags_skipped_registry_imports_spec.rb' - - 'spec/lib/gitlab/background_migration/set_legacy_open_source_license_available_for_non_public_projects_spec.rb' - 'spec/lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url_spec.rb' + - 'spec/lib/gitlab/checks/matching_merge_request_spec.rb' - 'spec/lib/gitlab/ci/config/external/file/artifact_spec.rb' + - 'spec/lib/gitlab/ci/config_spec.rb' - 'spec/lib/gitlab/ci/pipeline/chain/helpers_spec.rb' - - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' - 'spec/lib/gitlab/ci/status/stage/factory_spec.rb' - - 'spec/lib/gitlab/ci/variables/builder/group_spec.rb' - - 'spec/lib/gitlab/ci/variables/builder/project_spec.rb' - 'spec/lib/gitlab/ci/yaml_processor_spec.rb' - 'spec/lib/gitlab/cycle_analytics/stage_summary_spec.rb' - - 'spec/lib/gitlab/database/background_migration/batched_migration_wrapper_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_migration_spec.rb' - 'spec/lib/gitlab/database/migrations/test_batched_background_runner_spec.rb' - 'spec/lib/gitlab/database/partitioning/partition_manager_spec.rb' - - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb' - 'spec/lib/gitlab/database/postgresql_adapter/empty_query_ping_spec.rb' - 'spec/lib/gitlab/database/reindexing/grafana_notifier_spec.rb' - 'spec/lib/gitlab/diff/file_collection/merge_request_diff_batch_spec.rb' @@ -160,41 +179,42 @@ RSpec/ScatteredLet: - 'spec/lib/gitlab/diff/position_tracer/line_strategy_spec.rb' - 'spec/lib/gitlab/diff/suggestion_diff_spec.rb' - 'spec/lib/gitlab/diff/suggestion_spec.rb' - - 'spec/lib/gitlab/email/handler/service_desk_handler_spec.rb' - 'spec/lib/gitlab/error_tracking/processor/context_payload_processor_spec.rb' - - 'spec/lib/gitlab/error_tracking_spec.rb' - 'spec/lib/gitlab/git/blame_spec.rb' - 'spec/lib/gitlab/git/diff_collection_spec.rb' - 'spec/lib/gitlab/git_access_spec.rb' - 'spec/lib/gitlab/github_import/importer/single_endpoint_issue_events_importer_spec.rb' - - 'spec/lib/gitlab/github_import/parallel_scheduling_spec.rb' - 'spec/lib/gitlab/import_export/group/relation_tree_restorer_spec.rb' - - 'spec/lib/gitlab/import_export/project/export_task_spec.rb' + - 'spec/lib/gitlab/import_export/project/relation_tree_restorer_spec.rb' + - 'spec/lib/gitlab/import_export/project/sample/relation_tree_restorer_spec.rb' - 'spec/lib/gitlab/jira_import/issue_serializer_spec.rb' - 'spec/lib/gitlab/lets_encrypt/client_spec.rb' - 'spec/lib/gitlab/metrics/dashboard/stages/grafana_formatter_spec.rb' - 'spec/lib/gitlab/metrics/subscribers/external_http_spec.rb' - 'spec/lib/gitlab/middleware/memory_report_spec.rb' - - 'spec/lib/gitlab/pagination/gitaly_keyset_pager_spec.rb' - 'spec/lib/gitlab/pagination/keyset/page_spec.rb' - 'spec/lib/gitlab/pagination/offset_pagination_spec.rb' - 'spec/lib/gitlab/patch/database_config_spec.rb' - 'spec/lib/gitlab/path_regex_spec.rb' - 'spec/lib/gitlab/prometheus/queries/matched_metric_query_spec.rb' + - 'spec/lib/gitlab/redis/multi_store_spec.rb' + - 'spec/lib/gitlab/relative_positioning/item_context_spec.rb' + - 'spec/lib/gitlab/relative_positioning/mover_spec.rb' - 'spec/lib/gitlab/serializer/pagination_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/extra_done_log_metadata_spec.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/validator_spec.rb' - - 'spec/lib/gitlab/spamcheck/client_spec.rb' - 'spec/lib/gitlab/template/finders/global_template_finder_spec.rb' - 'spec/lib/gitlab/tree_summary_spec.rb' - 'spec/lib/gitlab/usage_data_metrics_spec.rb' + - 'spec/lib/gitlab/usage_data_spec.rb' - 'spec/lib/gitlab/utils/measuring_spec.rb' - 'spec/lib/gitlab/zentao/client_spec.rb' - 'spec/lib/peek/views/external_http_spec.rb' - 'spec/mailers/emails/in_product_marketing_spec.rb' - - 'spec/migrations/20210421163509_schedule_update_jira_tracker_data_deployment_type_based_on_url_spec.rb' + - 'spec/mailers/notify_spec.rb' + - 'spec/mailers/previews_spec.rb' - 'spec/migrations/20220329175119_remove_leftover_ci_job_artifact_deletions_spec.rb' - - 'spec/models/application_record_spec.rb' + - 'spec/models/ci/bridge_spec.rb' - 'spec/models/ci/build_dependencies_spec.rb' - 'spec/models/ci/pipeline_spec.rb' - 'spec/models/concerns/issuable_spec.rb' @@ -203,68 +223,61 @@ RSpec/ScatteredLet: - 'spec/models/deploy_keys_project_spec.rb' - 'spec/models/design_management/design_at_version_spec.rb' - 'spec/models/diff_note_spec.rb' - - 'spec/models/environment_spec.rb' - 'spec/models/integration_spec.rb' - - 'spec/models/merge_request_diff_spec.rb' - 'spec/models/merge_request_spec.rb' - - 'spec/models/milestone_spec.rb' - 'spec/models/push_event_spec.rb' + - 'spec/models/snippet_repository_spec.rb' - 'spec/models/ssh_host_key_spec.rb' - 'spec/models/user_spec.rb' - 'spec/models/users/credit_card_validation_spec.rb' - 'spec/models/wiki_page_spec.rb' - - 'spec/policies/ci/build_policy_spec.rb' - - 'spec/policies/design_management/design_policy_spec.rb' - 'spec/policies/group_member_policy_spec.rb' - 'spec/requests/admin/background_migrations_controller_spec.rb' + - 'spec/requests/api/ci/jobs_spec.rb' - 'spec/requests/api/ci/pipeline_schedules_spec.rb' - - 'spec/requests/api/ci/pipelines_spec.rb' - 'spec/requests/api/commit_statuses_spec.rb' - - 'spec/requests/api/graphql/ci/groups_spec.rb' - - 'spec/requests/api/graphql/ci/pipelines_spec.rb' + - 'spec/requests/api/graphql/ci/runners_spec.rb' + - 'spec/requests/api/graphql/group/work_item_types_spec.rb' + - 'spec/requests/api/graphql/milestone_spec.rb' - 'spec/requests/api/graphql/mutations/boards/create_spec.rb' + - 'spec/requests/api/graphql/mutations/work_items/delete_task_spec.rb' - 'spec/requests/api/graphql/namespace/projects_spec.rb' + - 'spec/requests/api/graphql/project/deployment_spec.rb' + - 'spec/requests/api/graphql/project/environments_spec.rb' - 'spec/requests/api/graphql/project/issue/design_collection/version_spec.rb' - 'spec/requests/api/graphql/project/issue/design_collection/versions_spec.rb' - 'spec/requests/api/graphql/project/issue_spec.rb' + - 'spec/requests/api/graphql/project/jira_projects_spec.rb' + - 'spec/requests/api/graphql/project/merge_request/diff_notes_spec.rb' - 'spec/requests/api/graphql/project/milestones_spec.rb' - - 'spec/requests/api/graphql/project/pipeline_spec.rb' - - 'spec/requests/api/graphql/project/release_spec.rb' - - 'spec/requests/api/graphql/user/starred_projects_query_spec.rb' + - 'spec/requests/api/graphql/project/work_item_types_spec.rb' + - 'spec/requests/api/graphql/todo_query_spec.rb' + - 'spec/requests/api/group_boards_spec.rb' - 'spec/requests/api/issues/get_group_issues_spec.rb' - - 'spec/requests/api/issues/get_project_issues_spec.rb' - - 'spec/requests/api/issues/post_projects_issues_spec.rb' - - 'spec/requests/api/issues/put_projects_issues_spec.rb' - 'spec/requests/api/merge_requests_spec.rb' - 'spec/requests/api/notes_spec.rb' - 'spec/requests/api/project_clusters_spec.rb' - - 'spec/requests/api/project_export_spec.rb' - - 'spec/requests/api/rubygem_packages_spec.rb' - 'spec/requests/jira_routing_spec.rb' - - 'spec/requests/projects/releases_controller_spec.rb' - 'spec/rubocop/cop/migration/update_column_in_batches_spec.rb' - 'spec/scripts/pipeline_test_report_builder_spec.rb' - 'spec/serializers/build_details_entity_spec.rb' - 'spec/serializers/ci/job_entity_spec.rb' - 'spec/serializers/merge_requests/pipeline_entity_spec.rb' - - 'spec/services/ci/change_variable_service_spec.rb' - - 'spec/services/ci/change_variables_service_spec.rb' - 'spec/services/ci/create_downstream_pipeline_service_spec.rb' + - 'spec/services/ci/create_pipeline_service/include_spec.rb' - 'spec/services/ci/create_pipeline_service/logger_spec.rb' + - 'spec/services/ci/create_pipeline_service/rules_spec.rb' - 'spec/services/ci/create_pipeline_service_spec.rb' - 'spec/services/ci/destroy_pipeline_service_spec.rb' - - 'spec/services/ci/find_exposed_artifacts_service_spec.rb' - - 'spec/services/ci/pipeline_bridge_status_service_spec.rb' - - 'spec/services/commits/cherry_pick_service_spec.rb' - 'spec/services/design_management/delete_designs_service_spec.rb' - 'spec/services/design_management/save_designs_service_spec.rb' - 'spec/services/discussions/capture_diff_note_positions_service_spec.rb' - 'spec/services/events/destroy_service_spec.rb' - 'spec/services/git/base_hooks_service_spec.rb' - - 'spec/services/groups/group_links/update_service_spec.rb' - - 'spec/services/jira_import/cloud_users_mapper_service_spec.rb' - - 'spec/services/jira_import/server_users_mapper_service_spec.rb' - - 'spec/services/lfs/push_service_spec.rb' + - 'spec/services/issues/create_service_spec.rb' + - 'spec/services/merge_requests/mergeability/logger_spec.rb' + - 'spec/services/merge_requests/update_assignees_service_spec.rb' + - 'spec/services/merge_requests/update_reviewers_service_spec.rb' - 'spec/services/metrics/dashboard/custom_metric_embed_service_spec.rb' - 'spec/services/metrics/dashboard/dynamic_embed_service_spec.rb' - 'spec/services/metrics/dashboard/gitlab_alert_embed_service_spec.rb' @@ -272,19 +285,18 @@ RSpec/ScatteredLet: - 'spec/services/notification_service_spec.rb' - 'spec/services/packages/composer/create_package_service_spec.rb' - 'spec/services/packages/conan/create_package_file_service_spec.rb' + - 'spec/services/packages/debian/create_distribution_service_spec.rb' - 'spec/services/packages/debian/create_package_file_service_spec.rb' - 'spec/services/packages/debian/generate_distribution_key_service_spec.rb' - 'spec/services/packages/debian/update_distribution_service_spec.rb' - 'spec/services/projects/lfs_pointers/lfs_download_link_list_service_spec.rb' - 'spec/services/snippets/create_service_spec.rb' - - 'spec/services/spam/spam_verdict_service_spec.rb' - 'spec/services/suggestions/create_service_spec.rb' - 'spec/services/system_notes/design_management_service_spec.rb' - 'spec/services/system_notes/merge_requests_service_spec.rb' + - 'spec/services/system_notes/time_tracking_service_spec.rb' - 'spec/services/todo_service_spec.rb' - - 'spec/services/web_hook_service_spec.rb' - - 'spec/services/work_items/update_service_spec.rb' - 'spec/support/shared_examples/graphql/sorted_paginated_query_shared_examples.rb' - 'spec/tasks/gitlab/artifacts/migrate_rake_spec.rb' - - 'spec/workers/concerns/gitlab/github_import/object_importer_spec.rb' + - 'spec/workers/environments/auto_stop_worker_spec.rb' - 'spec/workers/packages/debian/generate_distribution_worker_spec.rb' diff --git a/.rubocop_todo/rspec/variable_definition.yml b/.rubocop_todo/rspec/variable_definition.yml new file mode 100644 index 00000000000..797fa763ba1 --- /dev/null +++ b/.rubocop_todo/rspec/variable_definition.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --auto-correct. +RSpec/VariableDefinition: + Exclude: + - 'spec/lib/gitlab/usage_data_spec.rb' + - 'spec/presenters/packages/npm/package_presenter_spec.rb' diff --git a/.rubocop_todo/rspec/variable_name.yml b/.rubocop_todo/rspec/variable_name.yml new file mode 100644 index 00000000000..8858fbd9eb7 --- /dev/null +++ b/.rubocop_todo/rspec/variable_name.yml @@ -0,0 +1,4 @@ +--- +RSpec/VariableName: + Exclude: + - 'spec/models/user_spec.rb' diff --git a/.rubocop_todo/rspec/verified_doubles.yml b/.rubocop_todo/rspec/verified_doubles.yml index a225dbf21ae..c9f405a8283 100644 --- a/.rubocop_todo/rspec/verified_doubles.yml +++ b/.rubocop_todo/rspec/verified_doubles.yml @@ -67,7 +67,6 @@ RSpec/VerifiedDoubles: - ee/spec/lib/gitlab/authority_analyzer_spec.rb - ee/spec/lib/gitlab/cache_spec.rb - ee/spec/lib/gitlab/ci/pipeline/chain/limit/activity_spec.rb - - ee/spec/lib/gitlab/ci/pipeline/chain/limit/job_activity_spec.rb - ee/spec/lib/gitlab/ci/pipeline/chain/limit/size_spec.rb - ee/spec/lib/gitlab/code_owners/groups_loader_spec.rb - ee/spec/lib/gitlab/code_owners/users_loader_spec.rb diff --git a/.rubocop_todo/security/open.yml b/.rubocop_todo/security/open.yml new file mode 100644 index 00000000000..9626b442a92 --- /dev/null +++ b/.rubocop_todo/security/open.yml @@ -0,0 +1,4 @@ +--- +Security/Open: + Exclude: + - 'scripts/lib/glfm/update_specification.rb' diff --git a/.rubocop_todo/style/conditional_assignment.yml b/.rubocop_todo/style/conditional_assignment.yml new file mode 100644 index 00000000000..c9bbaaeb175 --- /dev/null +++ b/.rubocop_todo/style/conditional_assignment.yml @@ -0,0 +1,5 @@ +--- +# Cop supports --auto-correct. +Style/ConditionalAssignment: + Exclude: + - 'app/helpers/icons_helper.rb' diff --git a/.rubocop_todo/style/each_for_simple_loop.yml b/.rubocop_todo/style/each_for_simple_loop.yml new file mode 100644 index 00000000000..5d495f890d2 --- /dev/null +++ b/.rubocop_todo/style/each_for_simple_loop.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --auto-correct. +Style/EachForSimpleLoop: + Exclude: + - 'ee/spec/lib/gitlab/insights/reducers/count_per_period_reducer_spec.rb' + - 'spec/services/members/invitation_reminder_email_service_spec.rb' diff --git a/.rubocop_todo/style/if_unless_modifier.yml b/.rubocop_todo/style/if_unless_modifier.yml index cc21860d462..3263204cb3f 100644 --- a/.rubocop_todo/style/if_unless_modifier.yml +++ b/.rubocop_todo/style/if_unless_modifier.yml @@ -34,7 +34,6 @@ Style/IfUnlessModifier: - 'app/controllers/import/github_controller.rb' - 'app/controllers/import/gitlab_controller.rb' - 'app/controllers/import/manifest_controller.rb' - - 'app/controllers/jwt_controller.rb' - 'app/controllers/omniauth_callbacks_controller.rb' - 'app/controllers/profiles/emails_controller.rb' - 'app/controllers/profiles/two_factor_auths_controller.rb' @@ -47,7 +46,6 @@ Style/IfUnlessModifier: - 'app/controllers/projects/deploy_keys_controller.rb' - 'app/controllers/projects/design_management/designs_controller.rb' - 'app/controllers/projects/imports_controller.rb' - - 'app/controllers/projects/integrations/shimos_controller.rb' - 'app/controllers/projects/issues_controller.rb' - 'app/controllers/projects/merge_requests/diffs_controller.rb' - 'app/controllers/projects/merge_requests_controller.rb' @@ -94,13 +92,9 @@ Style/IfUnlessModifier: - 'app/graphql/mutations/release_asset_links/update.rb' - 'app/graphql/mutations/todos/mark_all_done.rb' - 'app/graphql/resolvers/blobs_resolver.rb' - - 'app/graphql/resolvers/ci/runner_jobs_resolver.rb' - 'app/graphql/resolvers/concerns/board_item_filterable.rb' - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - 'app/graphql/resolvers/concerns/time_frame_arguments.rb' - - 'app/graphql/resolvers/group_packages_resolver.rb' - - 'app/graphql/resolvers/package_details_resolver.rb' - - 'app/graphql/resolvers/project_jobs_resolver.rb' - 'app/graphql/resolvers/project_pipeline_resolver.rb' - 'app/graphql/resolvers/timelog_resolver.rb' - 'app/graphql/types/ci/job_type.rb' @@ -133,7 +127,6 @@ Style/IfUnlessModifier: - 'app/helpers/selects_helper.rb' - 'app/helpers/snippets_helper.rb' - 'app/helpers/sorting_helper.rb' - - 'app/helpers/storage_helper.rb' - 'app/helpers/submodule_helper.rb' - 'app/helpers/tab_helper.rb' - 'app/helpers/timeboxes_helper.rb' @@ -168,7 +161,6 @@ Style/IfUnlessModifier: - 'app/models/concerns/bulk_users_by_email_load.rb' - 'app/models/concerns/cache_markdown_field.rb' - 'app/models/concerns/ci/artifactable.rb' - - 'app/models/concerns/counter_attribute.rb' - 'app/models/concerns/deprecated_assignee.rb' - 'app/models/concerns/group_descendant.rb' - 'app/models/concerns/has_wiki_page_meta_attributes.rb' @@ -272,7 +264,6 @@ Style/IfUnlessModifier: - 'app/services/ci/job_token_scope/remove_project_service.rb' - 'app/services/ci/parse_dotenv_artifact_service.rb' - 'app/services/ci/pipeline_processing/atomic_processing_service.rb' - - 'app/services/ci/pipelines/add_job_service.rb' - 'app/services/ci/register_job_service.rb' - 'app/services/ci/retry_job_service.rb' - 'app/services/ci/run_scheduled_build_service.rb' @@ -322,14 +313,11 @@ Style/IfUnlessModifier: - 'app/services/merge_requests/add_context_service.rb' - 'app/services/merge_requests/base_service.rb' - 'app/services/merge_requests/build_service.rb' - - 'app/services/merge_requests/handle_assignees_change_service.rb' - 'app/services/merge_requests/merge_base_service.rb' - 'app/services/merge_requests/mergeability_check_service.rb' - 'app/services/merge_requests/push_options_handler_service.rb' - 'app/services/merge_requests/refresh_service.rb' - - 'app/services/merge_requests/request_attention_service.rb' - 'app/services/merge_requests/squash_service.rb' - - 'app/services/merge_requests/toggle_attention_requested_service.rb' - 'app/services/merge_requests/update_service.rb' - 'app/services/metrics/dashboard/clone_dashboard_service.rb' - 'app/services/metrics/dashboard/update_dashboard_service.rb' @@ -354,7 +342,6 @@ Style/IfUnlessModifier: - 'app/services/packages/maven/find_or_create_package_service.rb' - 'app/services/packages/nuget/update_package_from_metadata_service.rb' - 'app/services/packages/pypi/create_package_service.rb' - - 'app/services/packages/rubygems/dependency_resolver_service.rb' - 'app/services/pages/migrate_legacy_storage_to_deployment_service.rb' - 'app/services/post_receive_service.rb' - 'app/services/projects/container_repository/gitlab/delete_tags_service.rb' @@ -375,7 +362,6 @@ Style/IfUnlessModifier: - 'app/services/projects/update_repository_storage_service.rb' - 'app/services/protected_branches/cache_service.rb' - 'app/services/resource_access_tokens/create_service.rb' - - 'app/services/resource_events/change_labels_service.rb' - 'app/services/snippets/create_service.rb' - 'app/services/snippets/destroy_service.rb' - 'app/services/snippets/repository_validation_service.rb' @@ -422,8 +408,6 @@ Style/IfUnlessModifier: - 'app/workers/google_cloud/create_cloudsql_instance_worker.rb' - 'app/workers/issues/rebalancing_worker.rb' - 'app/workers/merge_request_mergeability_check_worker.rb' - - 'app/workers/object_storage/migrate_uploads_worker.rb' - - 'app/workers/process_commit_worker.rb' - 'app/workers/projects/import_export/relation_export_worker.rb' - 'app/workers/remove_expired_members_worker.rb' - 'app/workers/repository_fork_worker.rb' @@ -450,8 +434,6 @@ Style/IfUnlessModifier: - 'config/initializers/sidekiq.rb' - 'config/initializers/stackprof.rb' - 'config/initializers/validate_database_config.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - - 'config/initializers/zz_metrics.rb' - 'config/initializers_before_autoloader/002_sidekiq.rb' - 'config/routes.rb' - 'danger/database/Dangerfile' @@ -603,6 +585,7 @@ Style/IfUnlessModifier: - 'ee/app/services/ee/protected_branches/create_service.rb' - 'ee/app/services/ee/todo_service.rb' - 'ee/app/services/ee/users/update_service.rb' + - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/services/elastic/indexing_control_service.rb' - 'ee/app/services/elastic/process_bookkeeping_service.rb' - 'ee/app/services/epics/base_service.rb' @@ -652,7 +635,6 @@ Style/IfUnlessModifier: - 'ee/app/services/vulnerability_feedback/create_service.rb' - 'ee/app/services/vulnerability_feedback/destroy_service.rb' - 'ee/app/services/vulnerability_feedback_module/update_service.rb' - - 'ee/app/services/elastic/cluster_reindexing_service.rb' - 'ee/app/validators/host_validator.rb' - 'ee/app/validators/password/complexity_validator.rb' - 'ee/app/workers/app_sec/dast/profile_schedule_worker.rb' @@ -889,7 +871,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/ci/config/normalizer.rb' - 'lib/gitlab/ci/parsers/coverage/sax_document.rb' - 'lib/gitlab/ci/parsers/security/common.rb' - - 'lib/gitlab/ci/parsers/security/validators/schema_validator.rb' - 'lib/gitlab/ci/pipeline/chain/populate.rb' - 'lib/gitlab/ci/pipeline/chain/seed.rb' - 'lib/gitlab/ci/pipeline/chain/validate/abilities.rb' @@ -991,7 +972,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/import_export/project/relation_factory.rb' - 'lib/gitlab/import_export/project/tree_restorer.rb' - 'lib/gitlab/instrumentation/rate_limiting_gates.rb' - - 'lib/gitlab/instrumentation/redis_interceptor.rb' - 'lib/gitlab/jira_import.rb' - 'lib/gitlab/jira_import/base_importer.rb' - 'lib/gitlab/legacy_github_import/client.rb' @@ -1034,7 +1014,6 @@ Style/IfUnlessModifier: - 'lib/gitlab/search/params.rb' - 'lib/gitlab/search_context.rb' - 'lib/gitlab/search_results.rb' - - 'lib/gitlab/shell.rb' - 'lib/gitlab/sidekiq_config.rb' - 'lib/gitlab/sidekiq_config/cli_methods.rb' - 'lib/gitlab/sidekiq_config/worker_router.rb' @@ -1063,7 +1042,6 @@ Style/IfUnlessModifier: - 'lib/sidebars/projects/menus/packages_registries_menu.rb' - 'lib/sidebars/projects/menus/security_compliance_menu.rb' - 'lib/sidebars/projects/menus/settings_menu.rb' - - 'lib/sidebars/projects/panel.rb' - 'lib/system_check/app/systemd_unit_files_or_init_script_up_to_date_check.rb' - 'lib/system_check/init_helpers.rb' - 'lib/tasks/cleanup.rake' @@ -1078,7 +1056,6 @@ Style/IfUnlessModifier: - 'lib/tasks/gitlab/snippets.rake' - 'lib/tasks/gitlab/storage.rake' - 'lib/tasks/gitlab/update_templates.rake' - - 'qa/qa/ee/page/merge_request/show.rb' - 'qa/qa/ee/resource/settings/elasticsearch.rb' - 'qa/qa/flow/sign_up.rb' - 'qa/qa/page/component/select2.rb' @@ -1099,21 +1076,10 @@ Style/IfUnlessModifier: - 'qa/qa/runtime/ip_address.rb' - 'qa/qa/scenario/bootable.rb' - 'qa/qa/service/praefect_manager.rb' - - 'qa/qa/specs/features/api/3_create/gitaly/distributed_reads_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/merge_request/merge_when_pipeline_succeeds_spec.rb' - 'qa/qa/specs/features/browser_ui/3_create/web_ide/web_terminal_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/package_registry/nuget/nuget_group_level_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/advanced_global_advanced_syntax_search_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/elasticsearch_api_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/commit_index/commit_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/issues_index/issue_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/main_index/blob_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/merge_request_index/merge_request_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/index_tests/notes_index/note_index_spec.rb' - - 'qa/qa/specs/features/ee/api/9_enablement/elasticsearch/nightly_elasticsearch_test_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/geo_replication_maven_package_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/1_manage/group/group_ldap_sync_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/9_enablement/elasticsearch/elasticsearch_reindexing_spec.rb' - 'qa/qa/specs/helpers/context_selector.rb' - 'qa/qa/specs/parallel_runner.rb' - 'qa/qa/support/loglinking.rb' @@ -1123,7 +1089,6 @@ Style/IfUnlessModifier: - 'rubocop/cop/api/grape_array_missing_coerce.rb' - 'rubocop/cop/avoid_keyword_arguments_in_sidekiq_workers.rb' - 'rubocop/cop/gitlab/event_store_subscriber.rb' - - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' - 'rubocop/cop/gitlab/policy_rule_boolean.rb' - 'rubocop/cop/ignored_columns.rb' @@ -1131,8 +1096,6 @@ Style/IfUnlessModifier: - 'rubocop/cop/migration/add_reference.rb' - 'rubocop/cop/migration/remove_column.rb' - 'rubocop/cop/migration/sidekiq_queue_migrate.rb' - - 'rubocop/cop/performance/ar_exists_and_present_blank.rb' - - 'rubocop/cop/rspec/web_mock_enable.rb' - 'rubocop/routes_under_scope.rb' - 'scripts/pipeline_test_report_builder.rb' - 'scripts/review_apps/automated_cleanup.rb' @@ -1187,6 +1150,7 @@ Style/IfUnlessModifier: - 'spec/requests/api/integrations_spec.rb' - 'spec/requests/users_controller_spec.rb' - 'spec/routing/import_routing_spec.rb' + - 'spec/rubocop_spec_helper.rb' - 'spec/serializers/issue_sidebar_basic_entity_spec.rb' - 'spec/services/application_settings/update_service_spec.rb' - 'spec/services/clusters/applications/create_service_spec.rb' @@ -1197,7 +1161,6 @@ Style/IfUnlessModifier: - 'spec/services/packages/maven/find_or_create_package_service_spec.rb' - 'spec/services/packages/maven/metadata/append_package_file_service_spec.rb' - 'spec/services/packages/maven/metadata/sync_service_spec.rb' - - 'spec/services/projects/container_repository/cleanup_tags_service_spec.rb' - 'spec/services/projects/create_service_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/capybara.rb' diff --git a/.rubocop_todo/style/redundant_begin.yml b/.rubocop_todo/style/redundant_begin.yml new file mode 100644 index 00000000000..e96cdb26b08 --- /dev/null +++ b/.rubocop_todo/style/redundant_begin.yml @@ -0,0 +1,57 @@ +--- +# Cop supports --auto-correct. +Style/RedundantBegin: + Details: grace period + Exclude: + - 'app/controllers/concerns/membership_actions.rb' + - 'app/controllers/concerns/metrics_dashboard.rb' + - 'app/controllers/concerns/renders_ldap_servers.rb' + - 'app/helpers/auth_helper.rb' + - 'app/models/event.rb' + - 'app/models/integrations/asana.rb' + - 'app/models/integrations/jira.rb' + - 'app/models/user.rb' + - 'app/services/ci/register_job_service.rb' + - 'app/services/design_management/generate_image_versions_service.rb' + - 'app/services/error_tracking/list_projects_service.rb' + - 'app/services/issue_links/create_service.rb' + - 'app/services/merge_requests/assign_issues_service.rb' + - 'app/services/projects/batch_forks_count_service.rb' + - 'app/services/projects/batch_open_issues_count_service.rb' + - 'app/services/projects/lfs_pointers/lfs_object_download_list_service.rb' + - 'app/services/users/update_highest_member_role_service.rb' + - 'ee/app/controllers/groups/sso_controller.rb' + - 'ee/app/finders/security/findings_finder.rb' + - 'ee/app/services/epics/epic_links/create_service.rb' + - 'ee/app/services/epics/related_epic_links/create_service.rb' + - 'ee/app/services/geo/container_repository_sync_service.rb' + - 'ee/app/validators/ee/json_schema_validator.rb' + - 'ee/lib/ee/api/helpers/award_emoji.rb' + - 'ee/lib/gem_extensions/elasticsearch/model/adapter/multiple/records.rb' + - 'ee/lib/gitlab/ci/parsers/security/dast.rb' + - 'ee/lib/omni_auth/strategies/group_saml.rb' + - 'ee/lib/system_check/geo/authorized_keys_check.rb' + - 'lib/api/helpers/award_emoji.rb' + - 'lib/api/time_tracking_endpoints.rb' + - 'lib/atlassian/jira_connect/serializers/build_entity.rb' + - 'lib/backup/manager.rb' + - 'lib/banzai/pipeline/wiki_pipeline.rb' + - 'lib/gem_extensions/active_record/association.rb' + - 'lib/gitlab.rb' + - 'lib/gitlab/changes_list.rb' + - 'lib/gitlab/color.rb' + - 'lib/gitlab/database/migration_helpers.rb' + - 'lib/gitlab/database/schema_cache_with_renamed_table.rb' + - 'lib/gitlab/favicon.rb' + - 'lib/gitlab/import_export/base/relation_factory.rb' + - 'lib/gitlab/import_export/members_mapper.rb' + - 'lib/gitlab/import_export/project/tree_saver.rb' + - 'lib/gitlab/instrumentation/redis_interceptor.rb' + - 'lib/gitlab/metrics/dashboard/importers/prometheus_metrics.rb' + - 'lib/gitlab/phabricator_import/project_creator.rb' + - 'lib/gitlab/project_search_results.rb' + - 'lib/gitlab/shell.rb' + - 'lib/gitlab/usage/metrics/aggregates/sources/calculations/intersection.rb' + - 'lib/sidebars/menu.rb' + - 'qa/qa/resource/api_fabricator.rb' + - 'qa/qa/runtime/api/client.rb' diff --git a/.rubocop_todo/style/redundant_condition.yml b/.rubocop_todo/style/redundant_condition.yml new file mode 100644 index 00000000000..86be40f7ffa --- /dev/null +++ b/.rubocop_todo/style/redundant_condition.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --auto-correct. +Style/RedundantCondition: + Exclude: + - 'ee/app/models/license.rb' + - 'spec/lib/gitlab/sidekiq_middleware/server_metrics_spec.rb' diff --git a/.rubocop_todo/style/redundant_parentheses.yml b/.rubocop_todo/style/redundant_parentheses.yml new file mode 100644 index 00000000000..1ca658776b8 --- /dev/null +++ b/.rubocop_todo/style/redundant_parentheses.yml @@ -0,0 +1,6 @@ +--- +# Cop supports --auto-correct. +Style/RedundantParentheses: + Exclude: + - 'lib/gitlab/database/tables_truncate.rb' + - 'qa/qa/specs/features/ee/browser_ui/11_fulfillment/utilization/billing_seats_usage_data_spec.rb' diff --git a/.rubocop_todo/style/symbol_proc.yml b/.rubocop_todo/style/symbol_proc.yml index bfb3867b127..d373788dbc6 100644 --- a/.rubocop_todo/style/symbol_proc.yml +++ b/.rubocop_todo/style/symbol_proc.yml @@ -70,8 +70,6 @@ Style/SymbolProc: - 'app/services/clusters/agents/delete_expired_events_service.rb' - 'app/services/feature_flags/update_service.rb' - 'app/services/merge_requests/base_service.rb' - - 'app/services/merge_requests/bulk_remove_attention_requested_service.rb' - - 'app/services/merge_requests/reopen_service.rb' - 'app/services/notes/destroy_service.rb' - 'app/services/packages/debian/generate_distribution_service.rb' - 'app/services/resource_events/synthetic_label_notes_builder_service.rb' @@ -87,7 +85,6 @@ Style/SymbolProc: - 'config/initializers/01_active_record_database_tasks_configuration_flag.rb' - 'config/initializers/doorkeeper_openid_connect.rb' - 'config/initializers/mail_encoding_patch.rb' - - 'config/initializers/wikicloth_redos_patch.rb' - 'config/settings.rb' - 'db/migrate/20210318134427_delete_security_findings_without_uuid.rb' - 'db/migrate/20210503105845_add_project_value_stream_id_to_project_stages.rb' @@ -136,7 +133,6 @@ Style/SymbolProc: - 'ee/spec/helpers/ee/registrations_helper_spec.rb' - 'ee/spec/lib/ee/gitlab/search_results_spec.rb' - 'ee/spec/lib/gitlab/elastic/document_reference_spec.rb' - - 'ee/spec/models/ee/iterations/cadence_spec.rb' - 'ee/spec/services/groups/participants_service_spec.rb' - 'ee/spec/support/helpers/subscription_portal_helpers.rb' - 'ee/spec/support/shared_examples/lib/gitlab/graphql/issuables_lazy_links_aggregate_shared_examples.rb' @@ -205,17 +201,13 @@ Style/SymbolProc: - 'qa/qa/specs/features/browser_ui/3_create/web_ide/review_merge_request_spec.rb' - 'qa/qa/specs/features/browser_ui/4_verify/ci_variable/custom_variable_spec.rb' - 'qa/qa/specs/features/browser_ui/5_package/container_registry/online_garbage_collection_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/attachment_replication_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/http_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/rename_replication_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/ssh_push_spec.rb' - - 'qa/qa/specs/features/ee/browser_ui/12_geo/wiki_http_push_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/merge_request/approval_rules_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/3_create/repository/file_locking_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_status_on_operation_dashboard_spec.rb' - 'qa/qa/specs/features/ee/browser_ui/4_verify/pipeline_subscription_with_group_owned_project_spec.rb' - 'rubocop/cop/gitlab/mark_used_feature_flags.rb' + - 'rubocop/cop/gitlab/namespaced_class.rb' - 'scripts/qa/testcases-check' - 'scripts/static-analysis' - 'spec/controllers/concerns/product_analytics_tracking_spec.rb' @@ -245,7 +237,6 @@ Style/SymbolProc: - 'spec/lib/gitlab/database/loose_foreign_keys_spec.rb' - 'spec/lib/gitlab/database/migration_helpers/loose_foreign_key_helpers_spec.rb' - 'spec/lib/gitlab/git/commit_spec.rb' - - 'spec/lib/gitlab/git/repository_spec.rb' - 'spec/lib/gitlab/gpg/invalid_gpg_signature_updater_spec.rb' - 'spec/lib/gitlab/graphql/lazy_spec.rb' - 'spec/lib/gitlab/graphql/markdown_field_spec.rb' @@ -272,7 +263,6 @@ Style/SymbolProc: - 'spec/services/merge_requests/conflicts/list_service_spec.rb' - 'spec/services/notification_recipients/builder/default_spec.rb' - 'spec/services/packages/go/create_package_service_spec.rb' - - 'spec/services/suggestions/apply_service_spec.rb' - 'spec/spec_helper.rb' - 'spec/support/generate-seed-repo-rb' - 'spec/support/helpers/filter_spec_helper.rb' diff --git a/.rubocop_todo/style/word_array.yml b/.rubocop_todo/style/word_array.yml new file mode 100644 index 00000000000..7e8122bf9d9 --- /dev/null +++ b/.rubocop_todo/style/word_array.yml @@ -0,0 +1,8 @@ +--- +# Cop supports --auto-correct. +Style/WordArray: + Exclude: + - 'ee/spec/features/protected_branches_spec.rb' + - 'qa/qa/page/project/settings/mirroring_repositories.rb' + - 'qa/qa/specs/features/ee/browser_ui/13_secure/enable_scanning_from_configuration_spec.rb' + - 'spec/features/protected_branches_spec.rb' diff --git a/Gemfile b/Gemfile index fdce5e0dc50..b1cb1d38981 100644 --- a/Gemfile +++ b/Gemfile @@ -381,7 +381,7 @@ group :development, :test do gem 'spring', '~> 2.1.0' gem 'spring-commands-rspec', '~> 1.0.4' - gem 'gitlab-styles', '~> 8.0.0', require: false + gem 'gitlab-styles', '~> 9.0.0', require: false gem 'haml_lint', '~> 0.40.0', require: false gem 'bundler-audit', '~> 0.7.0.1', require: false diff --git a/Gemfile.lock b/Gemfile.lock index 34f518a0f60..ea63918a7e8 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -585,13 +585,13 @@ GEM openid_connect (~> 1.2) gitlab-sidekiq-fetcher (0.8.0) sidekiq (~> 6.1) - gitlab-styles (8.0.0) - rubocop (~> 0.91, >= 0.91.1) + gitlab-styles (9.0.0) + rubocop (~> 1.36.0) rubocop-gitlab-security (~> 0.1.1) - rubocop-graphql (~> 0.10) - rubocop-performance (~> 1.9.2) - rubocop-rails (~> 2.9) - rubocop-rspec (~> 1.44) + rubocop-graphql (~> 0.14) + rubocop-performance (~> 1.14) + rubocop-rails (~> 2.15) + rubocop-rspec (~> 2.12) gitlab_chronic_duration (0.10.6.2) numerizer (~> 0.2) gitlab_omniauth-ldap (2.2.0) @@ -1209,31 +1209,31 @@ GEM pg rails sqlite3 - rubocop (0.93.1) + rubocop (1.36.0) + json (~> 2.3) parallel (~> 1.10) - parser (>= 2.7.1.5) + parser (>= 3.1.2.1) rainbow (>= 2.2.2, < 4.0) - regexp_parser (>= 1.8) - rexml - rubocop-ast (>= 0.6.0) + regexp_parser (>= 1.8, < 3.0) + rexml (>= 3.2.5, < 4.0) + rubocop-ast (>= 1.20.1, < 2.0) ruby-progressbar (~> 1.7) - unicode-display_width (>= 1.4.0, < 2.0) + unicode-display_width (>= 1.4.0, < 3.0) rubocop-ast (1.21.0) parser (>= 3.1.1.0) rubocop-gitlab-security (0.1.1) rubocop (>= 0.51) rubocop-graphql (0.14.6) rubocop (>= 0.87, < 2) - rubocop-performance (1.9.2) - rubocop (>= 0.90.0, < 2.0) + rubocop-performance (1.14.3) + rubocop (>= 1.7.0, < 2.0) rubocop-ast (>= 0.4.0) - rubocop-rails (2.9.1) + rubocop-rails (2.15.2) activesupport (>= 4.2.0) rack (>= 1.1) - rubocop (>= 0.90.0, < 2.0) - rubocop-rspec (1.44.1) - rubocop (~> 0.87) - rubocop-ast (>= 0.7.1) + rubocop (>= 1.7.0, < 2.0) + rubocop-rspec (2.12.1) + rubocop (~> 1.31) ruby-fogbugz (0.2.1) crack (~> 0.4) ruby-magic (0.5.4) @@ -1619,7 +1619,7 @@ DEPENDENCIES gitlab-net-dns (~> 0.9.1) gitlab-omniauth-openid-connect (~> 0.10.0) gitlab-sidekiq-fetcher (= 0.8.0) - gitlab-styles (~> 8.0.0) + gitlab-styles (~> 9.0.0) gitlab_chronic_duration (~> 0.10.6.2) gitlab_omniauth-ldap (~> 2.2.0) gon (~> 6.4.0) diff --git a/app/services/ci/create_pipeline_service.rb b/app/services/ci/create_pipeline_service.rb index af175b8da1c..8262691644b 100644 --- a/app/services/ci/create_pipeline_service.rb +++ b/app/services/ci/create_pipeline_service.rb @@ -26,6 +26,7 @@ module Ci Gitlab::Ci::Pipeline::Chain::AssignPartition, Gitlab::Ci::Pipeline::Chain::Seed, Gitlab::Ci::Pipeline::Chain::Limit::Size, + Gitlab::Ci::Pipeline::Chain::Limit::ActiveJobs, Gitlab::Ci::Pipeline::Chain::Limit::Deployments, Gitlab::Ci::Pipeline::Chain::Validate::External, Gitlab::Ci::Pipeline::Chain::Populate, @@ -36,7 +37,7 @@ module Ci Gitlab::Ci::Pipeline::Chain::CreateDeployments, Gitlab::Ci::Pipeline::Chain::CreateCrossDatabaseAssociations, Gitlab::Ci::Pipeline::Chain::Limit::Activity, - Gitlab::Ci::Pipeline::Chain::Limit::JobActivity, + Gitlab::Ci::Pipeline::Chain::Limit::JobActivity, # deprecated in favour of Limit::ActiveJobs Gitlab::Ci::Pipeline::Chain::CancelPendingPipelines, Gitlab::Ci::Pipeline::Chain::Metrics, Gitlab::Ci::Pipeline::Chain::TemplateUsage, diff --git a/app/views/projects/protected_branches/_create_protected_branch.html.haml b/app/views/projects/protected_branches/_create_protected_branch.html.haml index 34fe9a29068..76aadc3be28 100644 --- a/app/views/projects/protected_branches/_create_protected_branch.html.haml +++ b/app/views/projects/protected_branches/_create_protected_branch.html.haml @@ -1,12 +1,12 @@ - content_for :merge_access_levels do .merge_access_levels-container - = dropdown_tag('Select', + = dropdown_tag(_('Select'), options: { toggle_class: 'js-allowed-to-merge wide', dropdown_class: 'dropdown-menu-selectable capitalize-header', dropdown_qa_selector: 'allowed_to_merge_dropdown_content', dropdown_testid: 'allowed-to-merge-dropdown', data: { field_name: 'protected_branch[merge_access_levels_attributes][0][access_level]', input_id: 'merge_access_levels_attributes', qa_selector: 'allowed_to_merge_dropdown' }}) - content_for :push_access_levels do .push_access_levels-container - = dropdown_tag('Select', + = dropdown_tag(_('Select'), options: { toggle_class: "js-allowed-to-push js-multiselect wide", dropdown_class: 'dropdown-menu-selectable capitalize-header', dropdown_qa_selector: 'allowed_to_push_dropdown_content' , dropdown_testid: 'allowed-to-push-dropdown', data: { field_name: 'protected_branch[push_access_levels_attributes][0][access_level]', input_id: 'push_access_levels_attributes', qa_selector: 'allowed_to_push_dropdown' }}) diff --git a/app/views/projects/protected_branches/shared/_dropdown.html.haml b/app/views/projects/protected_branches/shared/_dropdown.html.haml index 4b09d36e7c3..d5111bd8be5 100644 --- a/app/views/projects/protected_branches/shared/_dropdown.html.haml +++ b/app/views/projects/protected_branches/shared/_dropdown.html.haml @@ -2,11 +2,11 @@ = f.hidden_field(:name) -= dropdown_tag('Select branch or create wildcard', += dropdown_tag(_('Select branch or create wildcard'), options: { toggle_class: "js-protected-branch-select js-filter-submit wide monospace qa-protected-branch-select #{toggle_classes}", filter: true, dropdown_class: "dropdown-menu-selectable git-revision-dropdown qa-protected-branch-dropdown", - placeholder: "Search protected branches", + placeholder: _("Search protected branches"), footer_content: true, data: { show_no: true, show_any: true, show_upcoming: true, selected: params[:protected_branch_name], @@ -14,6 +14,6 @@ %ul.dropdown-footer-list %li - %button{ class: "dropdown-create-new-item-button js-dropdown-create-new-item", title: "New Protected Branch" } - Create wildcard + %button{ class: "dropdown-create-new-item-button js-dropdown-create-new-item", title: _("New Protected Branch") } + = _('Create wildcard') %code diff --git a/app/views/shared/issuable/_sort_dropdown.html.haml b/app/views/shared/issuable/_sort_dropdown.html.haml index e36c4cd6be0..ccc1a9fda6e 100644 --- a/app/views/shared/issuable/_sort_dropdown.html.haml +++ b/app/views/shared/issuable/_sort_dropdown.html.haml @@ -1,5 +1,5 @@ - viewing_issues = controller.controller_name == 'issues' || controller.action_name == 'issues' -- viewing_merge_requests = controller.controller_name == 'merge_requests' +- viewing_merge_requests = controller.controller_name == 'merge_requests' || controller.action_name == 'merge_requests' - items = issuable_sort_options(viewing_issues, viewing_merge_requests) - selected = issuable_sort_option_overrides[@sort] || @sort diff --git a/config/feature_flags/development/ci_variables_refactoring_to_variable.yml b/config/feature_flags/development/ci_variables_refactoring_to_variable.yml deleted file mode 100644 index 131df28d104..00000000000 --- a/config/feature_flags/development/ci_variables_refactoring_to_variable.yml +++ /dev/null @@ -1,8 +0,0 @@ ---- -name: ci_variables_refactoring_to_variable -introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/95390 -rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/371559 -milestone: '15.4' -type: development -group: group::pipeline authoring -default_enabled: false diff --git a/db/post_migrate/20220916065418_add_index_id_partition_id_to_ci_builds_metadata.rb b/db/post_migrate/20220916065418_add_index_id_partition_id_to_ci_builds_metadata.rb new file mode 100644 index 00000000000..c781f2a9ef9 --- /dev/null +++ b/db/post_migrate/20220916065418_add_index_id_partition_id_to_ci_builds_metadata.rb @@ -0,0 +1,16 @@ +# frozen_string_literal: true + +class AddIndexIdPartitionIdToCiBuildsMetadata < Gitlab::Database::Migration[2.0] + disable_ddl_transaction! + + TABLE_NAME = :ci_builds_metadata + INDEX_NAME = :index_ci_builds_metadata_on_id_partition_id_unique + + def up + add_concurrent_index(TABLE_NAME, %i[id partition_id], unique: true, name: INDEX_NAME) + end + + def down + remove_concurrent_index_by_name(TABLE_NAME, INDEX_NAME) + end +end diff --git a/db/post_migrate/20220916070101_add_index_build_id_partition_id_to_ci_build_metadata.rb b/db/post_migrate/20220916070101_add_index_build_id_partition_id_to_ci_build_metadata.rb new file mode 100644 index 00000000000..18c24c47325 --- /dev/null +++ b/db/post_migrate/20220916070101_add_index_build_id_partition_id_to_ci_build_metadata.rb @@ -0,0 +1,16 @@ +# frozen_string_literal: true + +class AddIndexBuildIdPartitionIdToCiBuildMetadata < Gitlab::Database::Migration[2.0] + disable_ddl_transaction! + + TABLE_NAME = :ci_builds_metadata + INDEX_NAME = :index_ci_builds_metadata_on_build_id_partition_id_unique + + def up + add_concurrent_index(TABLE_NAME, %i[build_id partition_id], unique: true, name: INDEX_NAME) + end + + def down + remove_concurrent_index_by_name(TABLE_NAME, INDEX_NAME) + end +end diff --git a/db/schema.rb b/db/schema.rb deleted file mode 100644 index 26ce2ed69c4..00000000000 --- a/db/schema.rb +++ /dev/null @@ -1,5 +0,0 @@ -# Disabled in favour of structure.sql -# Please refer to https://gitlab.com/gitlab-org/gitlab/-/issues/211487 for details - -raise 'schema.rb should not be used anymore, use structure.sql instead' - diff --git a/db/schema_migrations/20220916065418 b/db/schema_migrations/20220916065418 new file mode 100644 index 00000000000..f78f7149e66 --- /dev/null +++ b/db/schema_migrations/20220916065418 @@ -0,0 +1 @@ +2950f1826c77539072f66fcc46fefb77dcbcafe4cc8e5d0bdc090b19fc1600c7 \ No newline at end of file diff --git a/db/schema_migrations/20220916070101 b/db/schema_migrations/20220916070101 new file mode 100644 index 00000000000..90afdffcddb --- /dev/null +++ b/db/schema_migrations/20220916070101 @@ -0,0 +1 @@ +e63bd78b80b7a5a475f0246fb8d2dcb1164f410705dfae44579dce5579655841 \ No newline at end of file diff --git a/db/structure.sql b/db/structure.sql index 825cf6b9142..589b57851dc 100644 --- a/db/structure.sql +++ b/db/structure.sql @@ -28034,6 +28034,10 @@ CREATE INDEX index_ci_builds_metadata_on_build_id_and_has_exposed_artifacts ON c CREATE INDEX index_ci_builds_metadata_on_build_id_and_id_and_interruptible ON ci_builds_metadata USING btree (build_id) INCLUDE (id) WHERE (interruptible = true); +CREATE UNIQUE INDEX index_ci_builds_metadata_on_build_id_partition_id_unique ON ci_builds_metadata USING btree (build_id, partition_id); + +CREATE UNIQUE INDEX index_ci_builds_metadata_on_id_partition_id_unique ON ci_builds_metadata USING btree (id, partition_id); + CREATE INDEX index_ci_builds_metadata_on_project_id ON ci_builds_metadata USING btree (project_id); CREATE INDEX index_ci_builds_on_auto_canceled_by_id ON ci_builds USING btree (auto_canceled_by_id); diff --git a/doc/administration/packages/container_registry.md b/doc/administration/packages/container_registry.md index 84c15986def..f88ed46a58c 100644 --- a/doc/administration/packages/container_registry.md +++ b/doc/administration/packages/container_registry.md @@ -884,10 +884,41 @@ point to the correct registry URL and copy the `registry.key` file to each Sidek information, see the [Sidekiq configuration](../sidekiq.md) page. -To reduce the amount of [Container Registry disk space used by a given project](../troubleshooting/gitlab_rails_cheat_sheet.md#registry-disk-space-usage-by-project), +To reduce the amount of [Container Registry disk space used by a given project](#registry-disk-space-usage-by-project), administrators can clean up image tags and [run garbage collection](#container-registry-garbage-collection). +### Registry Disk Space Usage by Project + +To find the disk space used by each project, run the following in the +[GitLab Rails console](../operations/rails_console.md#starting-a-rails-console-session): + +```ruby +projects_and_size = [["project_id", "creator_id", "registry_size_bytes", "project path"]] +# You need to specify the projects that you want to look through. You can get these in any manner. +projects = Project.last(100) + +projects.each do |p| + project_total_size = 0 + container_repositories = p.container_repositories + + container_repositories.each do |c| + c.tags.each do |t| + project_total_size = project_total_size + t.total_size unless t.total_size.nil? + end + end + + if project_total_size > 0 + projects_and_size << [p.project_id, p.creator.id, project_total_size, p.full_path] + end +end + +# print it as comma separated output +projects_and_size.each do |ps| + puts "%s,%s,%s,%s" % ps +end +``` + To remove image tags by running the cleanup policy, run the following commands in the [GitLab Rails console](../operations/rails_console.md): diff --git a/doc/development/documentation/styleguide/index.md b/doc/development/documentation/styleguide/index.md index b0cd61a7ed6..179e2308c01 100644 --- a/doc/development/documentation/styleguide/index.md +++ b/doc/development/documentation/styleguide/index.md @@ -17,7 +17,7 @@ In addition to this page, the following resources can help you craft and contrib - [Doc contribution guidelines](../index.md) - [Recommended word list](word_list.md) - [Doc style and consistency testing](../testing.md) -- [UI text guidelines](https://design.gitlab.com/content/error-messages/) +- [Guidelines for UI error messages](https://design.gitlab.com/content/error-messages/) - [GitLab Handbook style guidelines](https://about.gitlab.com/handbook/communication/#writing-style-guidelines) - [Microsoft Style Guide](https://docs.microsoft.com/en-us/style-guide/welcome/) - [Google Developer Documentation Style Guide](https://developers.google.com/style) @@ -841,6 +841,28 @@ To open group settings: 1. Expand **General pipelines**. ``` +To open either project or group settings: + +```markdown +1. On the top bar, select **Main menu**, and: + - For a project, select ***Projects** and find your project. + - For a group, select **Groups** and find your group. +1. On the left sidebar, select **Settings > CI/CD**. +1. Expand **General pipelines**. +``` + +To create a project: + +```markdown +1. On the top bar, select **Create new... > New project**. +``` + +To create a group: + +```markdown +1. On the top bar, select **Create new... > New group**. +``` + To open the Admin Area: ```markdown diff --git a/doc/development/gitlab_flavored_markdown/specification_guide/index.md b/doc/development/gitlab_flavored_markdown/specification_guide/index.md index c1227e5d33f..304345275b5 100644 --- a/doc/development/gitlab_flavored_markdown/specification_guide/index.md +++ b/doc/development/gitlab_flavored_markdown/specification_guide/index.md @@ -6,28 +6,61 @@ info: To determine the technical writer assigned to the Stage/Group associated w # GitLab Flavored Markdown (GLFM) Specification Guide **(FREE)** +## Summary + +- _GitLab_ Flavored Markdown (GLFM) is based on + [_GitHub_ Flavored Markdown](https://github.github.com/gfm/) (GFM), + which is based on [CommonMark](https://spec.commonmark.org/current/). +- GLFM is divided into two "sets" of Markdown syntax: + - An "[official specification](#official-specifications)", + which is not dependent upon any specific + implementation or environment, and can be supported in any editor. + - "[Internal extensions](#internal-extensions)", which may be + dependent upon the GitLab environment and metadata. +- Everything in each of these sets of syntax is specified by + [special Markdown files](#input-specification-files) + based on the [CommonMark specification syntax](https://spec.commonmark.org/0.30/#about-this-document), + which contain side-by-side "examples" of Markdown and the corresponding + generated HTML, and associated documentation describing each example. +- There are also [YAML metadata files](#input-specification-files), which + may contain additional information on how individual Markdown/HTML examples + should be processed and rendered. +- These Markdown/YAML files and the examples they contain serve multiple goals: + - They are the canonical "source of truth" for how GLFM should be rendered. + - They support rendering a [formatted HTML document](#spechtml) containing all + of the examples and associated documentation, as the + [GFM and CommonMark specs](#various-markdown-specifications) also do. + - They support running standard CommonMark [conformance testing](#markdown-conformance-testing) + against the official specification. + - They support [snapshot testing](#markdown-snapshot-testing) of GitLab + internal GLFM processing logic. This is accomplished by automatically + generating YAML ["example snapshot files"](#example-snapshot-files) + which are used as fixtures to drive automated testing within the GitLab app. +- There are [various scripts and logic](#scripts) + which are used to accomplish the above goals. + +## Introduction + GitLab supports Markdown in various places. The Markdown dialect we use is called -GitLab Flavored Markdown, or GLFM. - -The specification for the GLFM dialect is based on the -[GitHub Flavored Markdown (GFM) specification](https://github.github.com/gfm/), -which is in turn based on the [CommonMark specification](https://spec.commonmark.org/current/). -The GLFM specification includes -[several extensions](../../../user/markdown.md#differences-between-gitlab-flavored-markdown-and-standard-markdown) -to the GFM specification. - -See the [section on acronyms](#acronyms-glfm-ghfm-gfm-commonmark) for a -detailed explanation of the various acronyms used in this document. -This guide is a developer-facing document that describes the various terms and -definitions, goals, tools, and implementations related to the GLFM specification. -It is intended to support and augment the [user-facing documentation](../../../user/markdown.md) -for GitLab Flavored Markdown. +GitLab Flavored Markdown (GLFM). NOTE: In this document, _GFM_ refers to _GitHub_ Flavored Markdown, not _GitLab_ Flavored Markdown. Refer to the [section on acronyms](#acronyms-glfm-ghfm-gfm-commonmark) for a detailed explanation of the various acronyms used in this document. +The specification for the GLFM dialect is based on the +[GitHub Flavored Markdown (GFM) specification](https://github.github.com/gfm/), +which is in turn based on the [CommonMark specification](https://spec.commonmark.org/current/). +The GLFM specification includes +[many additions](../../../user/markdown.md#differences-between-gitlab-flavored-markdown-and-standard-markdown) +compared to the GFM specification. + +This guide is a developer-facing document that describes the various terms and +definitions, goals, tools, and implementations related to the GLFM specification. +It is intended to support and augment the [user-facing documentation](../../../user/markdown.md) +for GitLab Flavored Markdown. + NOTE: This guide and the implementation and files described in it are still a work in progress. As the work progresses, rewrites and consolidation diff --git a/doc/tutorials/index.md b/doc/tutorials/index.md index 1b4762052c0..8b2ad1173fc 100644 --- a/doc/tutorials/index.md +++ b/doc/tutorials/index.md @@ -16,10 +16,10 @@ and running quickly. | Topic | Description | Good for beginners | |-------|-------------|--------------------| | [Introduction to GitLab](https://youtu.be/_4SmIyQ5eis?t=90) (59m 51s) | Walk through recommended processes and example workflows for using GitLab. | **{star}** | -| [GitLab 101](https://gitlab.edcast.com/pathways/ECL-ce65e759-d9e7-459f-83d0-1765459395d2) | Learn the basics of GitLab in this certification course. | **{star}** | +| [GitLab 101](https://levelup.gitlab.com/learn/course/gitlab101) | Learn the basics of GitLab in this certification course. | **{star}** | | [Use GitLab for DevOps](https://www.youtube.com/watch?v=7q9Y1Cv-ib0) (12m 34s) | Use GitLab through the entire DevOps lifecycle, from planning to monitoring. | **{star}** | | [Use Markdown at GitLab](../user/markdown.md) | GitLab Flavored Markdown (GLFM) is used in many areas of GitLab, for example, in merge requests. | **{star}** | -| [GitLab 201](https://gitlab.edcast.com/pathways/ECL-44010cf6-7a9c-4b9b-b684-fa08508a3252) | Go beyond the basics to learn more about using GitLab for your work. | | +| [GitLab 201](https://levelup.gitlab.com/learn/course/gitlab-201-certification) | Go beyond the basics to learn more about using GitLab for your work. | | | [Learn GitLab project walkthrough](https://www.youtube.com/watch?v=-oaI2WEKdI4&list=PL05JrBw4t0KofkHq4GZJ05FnNGa11PQ4d) (59m 2s) | Step through the tutorial-style issues in the **Learn GitLab** project. If you don't have this project, download [the export file](https://gitlab.com/gitlab-org/gitlab/-/blob/master/vendor/project_templates/learn_gitlab_ultimate.tar.gz) and [import it to a new project](../user/project/settings/import_export.md#import-a-project-and-its-data). | | | [Productivity tips](https://about.gitlab.com/blog/2021/02/18/improve-your-gitlab-productivity-with-these-10-tips/) | Get tips to help make you a productive GitLab user. | | | [Structure a multi-team organization](https://www.youtube.com/watch?v=KmASFwSap7c) (37m 37s) | Learn to use issues, milestones, epics, labels, and more to plan and manage your work. | | diff --git a/doc/user/application_security/policies/scan-execution-policies.md b/doc/user/application_security/policies/scan-execution-policies.md index f2fc52a2de8..f8199b69f51 100644 --- a/doc/user/application_security/policies/scan-execution-policies.md +++ b/doc/user/application_security/policies/scan-execution-policies.md @@ -96,7 +96,7 @@ GitLab supports the following types of CRON syntax for the `cadence` field: - A daily cadence of once per hour at a specified hour, for example: `0 18 * * *` - A weekly cadence of once per week on a specified day and at a specified hour, for example: `0 13 * * 0` -It is possible that other elements of the CRON syntax will work in the cadence field, however, GitLab does not officially test or support them. +Other elements of the CRON syntax may work in the cadence field, however, GitLab does not officially test or support them. The CRON expression is evaluated in UTC by default. If you have a self-managed GitLab instance and have [changed the server timezone](../../../administration/timezone.md), the CRON expression is evaluated with the new timezone. ## `scan` action type diff --git a/doc/user/project/clusters/kubernetes_pod_logs.md b/doc/user/project/clusters/kubernetes_pod_logs.md index bd87ab1024d..7bac4d72934 100644 --- a/doc/user/project/clusters/kubernetes_pod_logs.md +++ b/doc/user/project/clusters/kubernetes_pod_logs.md @@ -2,7 +2,7 @@ stage: Monitor group: Respond info: To determine the technical writer assigned to the Stage/Group associated with this page, see https://about.gitlab.com/handbook/engineering/ux/technical-writing/#assignments -remove_date: '2022-18-10' +remove_date: '2022-10-18' redirect_to: '../../clusters/agent/index.md' --- diff --git a/lib/gitlab/ci/config/entry/current_variables.rb b/lib/gitlab/ci/config/entry/current_variables.rb deleted file mode 100644 index 3b6721ec92d..00000000000 --- a/lib/gitlab/ci/config/entry/current_variables.rb +++ /dev/null @@ -1,49 +0,0 @@ -# frozen_string_literal: true - -module Gitlab - module Ci - class Config - module Entry - ## - # Entry that represents CI/CD variables. - # The class will be renamed to `Variables` when removing the FF `ci_variables_refactoring_to_variable`. - # - class CurrentVariables < ::Gitlab::Config::Entry::ComposableHash - include ::Gitlab::Config::Entry::Validatable - - validations do - validates :config, type: Hash - end - - # Enable these lines when removing the FF `ci_variables_refactoring_to_variable` - # and renaming this class to `Variables`. - # def self.default(**) - # {} - # end - - def value - @entries.to_h do |key, entry| - [key.to_s, entry.value] - end - end - - def value_with_data - @entries.to_h do |key, entry| - [key.to_s, entry.value_with_data] - end - end - - private - - def composable_class(_name, _config) - Entry::Variable - end - - def composable_metadata - { allowed_value_data: opt(:allowed_value_data) } - end - end - end - end - end -end diff --git a/lib/gitlab/ci/config/entry/legacy_variables.rb b/lib/gitlab/ci/config/entry/legacy_variables.rb deleted file mode 100644 index 5379f707537..00000000000 --- a/lib/gitlab/ci/config/entry/legacy_variables.rb +++ /dev/null @@ -1,46 +0,0 @@ -# frozen_string_literal: true - -module Gitlab - module Ci - class Config - module Entry - ## - # Entry that represents environment variables. - # This is legacy implementation and will be removed with the FF `ci_variables_refactoring_to_variable`. - # - class LegacyVariables < ::Gitlab::Config::Entry::Node - include ::Gitlab::Config::Entry::Validatable - - ALLOWED_VALUE_DATA = %i[value description].freeze - - validations do - validates :config, variables: { allowed_value_data: ALLOWED_VALUE_DATA }, if: :use_value_data? - validates :config, variables: true, unless: :use_value_data? - end - - def value - @config.to_h { |key, value| [key.to_s, expand_value(value)[:value]] } - end - - def value_with_data - @config.to_h { |key, value| [key.to_s, expand_value(value)] } - end - - def use_value_data? - opt(:use_value_data) - end - - private - - def expand_value(value) - if value.is_a?(Hash) - { value: value[:value].to_s, description: value[:description] }.compact - else - { value: value.to_s } - end - end - end - end - end - end -end diff --git a/lib/gitlab/ci/config/entry/root.rb b/lib/gitlab/ci/config/entry/root.rb index 57e89bd7bc5..b1b42cad74c 100644 --- a/lib/gitlab/ci/config/entry/root.rb +++ b/lib/gitlab/ci/config/entry/root.rb @@ -48,10 +48,9 @@ module Gitlab description: 'Script that will be executed after each job.', reserved: true - # use_value_data will be removed with the FF ci_variables_refactoring_to_variable entry :variables, Entry::Variables, description: 'Environment variables that will be used.', - metadata: { use_value_data: true, allowed_value_data: %i[value description] }, + metadata: { allowed_value_data: %i[value description] }, reserved: true entry :stages, Entry::Stages, diff --git a/lib/gitlab/ci/config/entry/variables.rb b/lib/gitlab/ci/config/entry/variables.rb index 0284958d9d4..7fa0ee00066 100644 --- a/lib/gitlab/ci/config/entry/variables.rb +++ b/lib/gitlab/ci/config/entry/variables.rb @@ -6,20 +6,38 @@ module Gitlab module Entry ## # Entry that represents CI/CD variables. - # CurrentVariables will be renamed to this class when removing the FF `ci_variables_refactoring_to_variable`. - # - class Variables - def self.new(...) - if YamlProcessor::FeatureFlags.enabled?(:ci_variables_refactoring_to_variable) - CurrentVariables.new(...) - else - LegacyVariables.new(...) - end + class Variables < ::Gitlab::Config::Entry::ComposableHash + include ::Gitlab::Config::Entry::Validatable + + validations do + validates :config, type: Hash end def self.default(**) {} end + + def value + @entries.to_h do |key, entry| + [key.to_s, entry.value] + end + end + + def value_with_data + @entries.to_h do |key, entry| + [key.to_s, entry.value_with_data] + end + end + + private + + def composable_class(_name, _config) + Entry::Variable + end + + def composable_metadata + { allowed_value_data: opt(:allowed_value_data) } + end end end end diff --git a/lib/gitlab/ci/pipeline/chain/command.rb b/lib/gitlab/ci/pipeline/chain/command.rb index 14c320f77bf..4b7507b11a7 100644 --- a/lib/gitlab/ci/pipeline/chain/command.rb +++ b/lib/gitlab/ci/pipeline/chain/command.rb @@ -121,7 +121,7 @@ module Gitlab end def observe_jobs_count_in_alive_pipelines - jobs_count = if Feature.enabled?(:ci_limit_active_jobs_early, project) + jobs_count = if limit_active_jobs_early? project.all_pipelines.jobs_count_in_alive_pipelines else project.all_pipelines.builds_count_in_alive_pipelines @@ -136,6 +136,12 @@ module Gitlab .increment(reason: (reason || :unknown_failure).to_s) end + def limit_active_jobs_early? + strong_memoize(:limit_active_jobs_early) do + Feature.enabled?(:ci_limit_active_jobs_early, project) + end + end + private # Verifies that origin_ref is a fully qualified tag reference (refs/tags/) diff --git a/lib/gitlab/ci/pipeline/chain/limit/active_jobs.rb b/lib/gitlab/ci/pipeline/chain/limit/active_jobs.rb new file mode 100644 index 00000000000..cbd895b05a5 --- /dev/null +++ b/lib/gitlab/ci/pipeline/chain/limit/active_jobs.rb @@ -0,0 +1,66 @@ +# frozen_string_literal: true + +module Gitlab + module Ci + module Pipeline + module Chain + module Limit + class ActiveJobs < Chain::Base + include ::Gitlab::Utils::StrongMemoize + include ::Gitlab::Ci::Pipeline::Chain::Helpers + + LIMIT_NAME = :ci_active_jobs + MESSAGE = "Project exceeded the allowed number of jobs in active pipelines. Retry later." + + def perform! + return unless command.limit_active_jobs_early? + return unless limits.exceeded?(LIMIT_NAME, count_jobs_in_alive_pipelines) + + error(MESSAGE, drop_reason: :job_activity_limit_exceeded) + + Gitlab::AppLogger.info( + class: self.class.name, + message: MESSAGE, + project_id: project.id, + plan: project.actual_plan_name) + end + + def break? + return unless command.limit_active_jobs_early? + + pipeline.errors.any? + end + + private + + def namespace + strong_memoize(:namespace) do + project.namespace + end + end + + def limits + strong_memoize(:limits) do + namespace.actual_limits + end + end + + def count_jobs_in_alive_pipelines + strong_memoize(:count_jobs_in_alive_pipelines) do + count_persisted_jobs_in_all_alive_pipelines + count_current_pipeline_jobs + end + end + + def count_current_pipeline_jobs + command.pipeline_seed.size + end + + def count_persisted_jobs_in_all_alive_pipelines + project.all_pipelines.jobs_count_in_alive_pipelines + end + end + end + end + end + end +end diff --git a/lib/gitlab/config/entry/legacy_validation_helpers.rb b/lib/gitlab/config/entry/legacy_validation_helpers.rb index be7d26fed4e..415f6f77214 100644 --- a/lib/gitlab/config/entry/legacy_validation_helpers.rb +++ b/lib/gitlab/config/entry/legacy_validation_helpers.rb @@ -50,12 +50,6 @@ module Gitlab variables.values.flatten(1).all?(&method(:validate_alphanumeric)) end - def validate_string_or_hash_value_variables(variables, allowed_value_data) - variables.is_a?(Hash) && - variables.keys.all?(&method(:validate_alphanumeric)) && - variables.values.all? { |value| validate_string_or_hash_value_variable(value, allowed_value_data) } - end - def validate_alphanumeric(value) validate_string(value) || validate_integer(value) end @@ -68,14 +62,6 @@ module Gitlab value.is_a?(String) || value.is_a?(Symbol) end - def validate_string_or_hash_value_variable(value, allowed_value_data) - if value.is_a?(Hash) - (value.keys - allowed_value_data).empty? && value.values.all?(&method(:validate_alphanumeric)) - else - validate_alphanumeric(value) - end - end - def validate_regexp(value) Gitlab::UntrustedRegexp::RubySyntax.valid?(value) end diff --git a/lib/gitlab/config/entry/validators.rb b/lib/gitlab/config/entry/validators.rb index 337cfbc5287..18ad6dab86e 100644 --- a/lib/gitlab/config/entry/validators.rb +++ b/lib/gitlab/config/entry/validators.rb @@ -304,15 +304,12 @@ module Gitlab end end - # This will be removed with the FF `ci_variables_refactoring_to_variable`. class VariablesValidator < ActiveModel::EachValidator include LegacyValidationHelpers def validate_each(record, attribute, value) if options[:array_values] validate_key_array_values(record, attribute, value) - elsif options[:allowed_value_data] - validate_key_hash_values(record, attribute, value, options[:allowed_value_data]) else validate_key_values(record, attribute, value) end @@ -329,12 +326,6 @@ module Gitlab record.errors.add(attribute, 'should be a hash of key value pairs, value can be an array') end end - - def validate_key_hash_values(record, attribute, value, allowed_value_data) - unless validate_string_or_hash_value_variables(value, allowed_value_data) - record.errors.add(attribute, 'should be a hash of key value pairs, value can be a hash') - end - end end class AlphanumericValidator < ActiveModel::EachValidator diff --git a/locale/gitlab.pot b/locale/gitlab.pot index 2589e868cab..104ee583457 100644 --- a/locale/gitlab.pot +++ b/locale/gitlab.pot @@ -11138,6 +11138,9 @@ msgstr "" msgid "Create user" msgstr "" +msgid "Create wildcard" +msgstr "" + msgid "Create wildcard: %{searchTerm}" msgstr "" @@ -26321,6 +26324,9 @@ msgstr "" msgid "New Project" msgstr "" +msgid "New Protected Branch" +msgstr "" + msgid "New Requirement" msgstr "" @@ -32296,6 +32302,9 @@ msgstr "" msgid "ProtectedBranch|What are protected branches?" msgstr "" +msgid "ProtectedBranch|You can add only groups that have this project shared. %{learn_more_link}" +msgstr "" + msgid "ProtectedBranch|default" msgstr "" @@ -35127,6 +35136,9 @@ msgstr "" msgid "Search projects..." msgstr "" +msgid "Search protected branches" +msgstr "" + msgid "Search rate limits" msgstr "" @@ -36256,6 +36268,9 @@ msgstr "" msgid "Select branch" msgstr "" +msgid "Select branch or create wildcard" +msgstr "" + msgid "Select branches" msgstr "" diff --git a/rubocop/cop/gitlab/duplicate_spec_location.rb b/rubocop/cop/gitlab/duplicate_spec_location.rb index ece3b9313d9..f8c19caf351 100644 --- a/rubocop/cop/gitlab/duplicate_spec_location.rb +++ b/rubocop/cop/gitlab/duplicate_spec_location.rb @@ -1,6 +1,7 @@ # frozen_string_literal: true -require 'rubocop/rspec/top_level_describe' +require 'rubocop/cop/rspec/base' +require 'rubocop/cop/rspec/mixin/top_level_group' module RuboCop module Cop @@ -19,17 +20,17 @@ module RuboCop # # good, spec for EE only code # ee/spec/controllers/my_spec.rb # describe MyClass # - class DuplicateSpecLocation < RuboCop::Cop::Cop - include RuboCop::RSpec::TopLevelDescribe + class DuplicateSpecLocation < RuboCop::Cop::RSpec::Base + include RuboCop::Cop::RSpec::TopLevelGroup MSG = 'Duplicate spec location in `%s`.' - def on_top_level_describe(node, _args) - path = file_path_for_node(node).sub(%r{\A#{rails_root}/}, '') + def on_top_level_group(node) + path = file_path_for_node(node.send_node).sub(%r{\A#{rails_root}/}, '') duplicate_path = find_duplicate_path(path) if duplicate_path && File.exist?(File.join(rails_root, duplicate_path)) - add_offense(node, message: format(MSG, path: duplicate_path)) + add_offense(node.send_node, message: format(MSG, path: duplicate_path)) end end diff --git a/rubocop/cop/rspec/any_instance_of.rb b/rubocop/cop/rspec/any_instance_of.rb index e1cacfebfd3..7016a76ec93 100644 --- a/rubocop/cop/rspec/any_instance_of.rb +++ b/rubocop/cop/rspec/any_instance_of.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +require 'rubocop-rspec' + module RuboCop module Cop module RSpec diff --git a/rubocop/cop/rspec/be_success_matcher.rb b/rubocop/cop/rspec/be_success_matcher.rb index 5a011845075..1ed55762965 100644 --- a/rubocop/cop/rspec/be_success_matcher.rb +++ b/rubocop/cop/rspec/be_success_matcher.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +require 'rubocop-rspec' + module RuboCop module Cop module RSpec diff --git a/rubocop/cop/rspec/env_assignment.rb b/rubocop/cop/rspec/env_assignment.rb index add7897c624..6994f3f0969 100644 --- a/rubocop/cop/rspec/env_assignment.rb +++ b/rubocop/cop/rspec/env_assignment.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +require 'rubocop-rspec' + module RuboCop module Cop module RSpec diff --git a/rubocop/cop/rspec/expect_gitlab_tracking.rb b/rubocop/cop/rspec/expect_gitlab_tracking.rb index 4f92980baa4..13fc7eace71 100644 --- a/rubocop/cop/rspec/expect_gitlab_tracking.rb +++ b/rubocop/cop/rspec/expect_gitlab_tracking.rb @@ -1,6 +1,6 @@ # frozen_string_literal: true -require 'rack/utils' +require 'rubocop-rspec' module RuboCop module Cop diff --git a/rubocop/cop/rspec/factories_in_migration_specs.rb b/rubocop/cop/rspec/factories_in_migration_specs.rb index 6dde3d4524c..7dce1264b0e 100644 --- a/rubocop/cop/rspec/factories_in_migration_specs.rb +++ b/rubocop/cop/rspec/factories_in_migration_specs.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +require 'rubocop-rspec' + module RuboCop module Cop module RSpec diff --git a/rubocop/cop/rspec/factory_bot/inline_association.rb b/rubocop/cop/rspec/factory_bot/inline_association.rb index ccc6364fb73..8d7c73b99a0 100644 --- a/rubocop/cop/rspec/factory_bot/inline_association.rb +++ b/rubocop/cop/rspec/factory_bot/inline_association.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +require 'rubocop-rspec' + module RuboCop module Cop module RSpec diff --git a/rubocop/cop/rspec/have_gitlab_http_status.rb b/rubocop/cop/rspec/have_gitlab_http_status.rb index 86ece72b4f5..29577598ba7 100644 --- a/rubocop/cop/rspec/have_gitlab_http_status.rb +++ b/rubocop/cop/rspec/have_gitlab_http_status.rb @@ -1,6 +1,7 @@ # frozen_string_literal: true require 'rack/utils' +require 'rubocop-rspec' module RuboCop module Cop diff --git a/rubocop/cop/rspec/httparty_basic_auth.rb b/rubocop/cop/rspec/httparty_basic_auth.rb index 1e0f7ae7af0..d188002673f 100644 --- a/rubocop/cop/rspec/httparty_basic_auth.rb +++ b/rubocop/cop/rspec/httparty_basic_auth.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +require 'rubocop-rspec' + module RuboCop module Cop module RSpec diff --git a/rubocop/cop/rspec/modify_sidekiq_middleware.rb b/rubocop/cop/rspec/modify_sidekiq_middleware.rb index 78e3ba223b0..2e27288933f 100644 --- a/rubocop/cop/rspec/modify_sidekiq_middleware.rb +++ b/rubocop/cop/rspec/modify_sidekiq_middleware.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +require 'rubocop-rspec' + module RuboCop module Cop module RSpec diff --git a/rubocop/cop/rspec/timecop_freeze.rb b/rubocop/cop/rspec/timecop_freeze.rb index 70e37ecfa55..b13f5050040 100644 --- a/rubocop/cop/rspec/timecop_freeze.rb +++ b/rubocop/cop/rspec/timecop_freeze.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +require 'rubocop-rspec' + module RuboCop module Cop module RSpec diff --git a/rubocop/cop/rspec/timecop_travel.rb b/rubocop/cop/rspec/timecop_travel.rb index 586567fa0cd..03f978be349 100644 --- a/rubocop/cop/rspec/timecop_travel.rb +++ b/rubocop/cop/rspec/timecop_travel.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +require 'rubocop-rspec' + module RuboCop module Cop module RSpec diff --git a/rubocop/cop/rspec/top_level_describe_path.rb b/rubocop/cop/rspec/top_level_describe_path.rb index 3cc1ee8df90..ee1a0bcc4b6 100644 --- a/rubocop/cop/rspec/top_level_describe_path.rb +++ b/rubocop/cop/rspec/top_level_describe_path.rb @@ -1,21 +1,20 @@ # frozen_string_literal: true -require 'rubocop/rspec/top_level_describe' +require 'rubocop/cop/rspec/base' +require 'rubocop/cop/rspec/mixin/top_level_group' module RuboCop module Cop module RSpec - class TopLevelDescribePath < RuboCop::Cop::Cop - include RuboCop::RSpec::TopLevelDescribe + class TopLevelDescribePath < RuboCop::Cop::RSpec::Base + include RuboCop::Cop::RSpec::TopLevelGroup MESSAGE = 'A file with a top-level `describe` must end in _spec.rb.' - SHARED_EXAMPLES = %i[shared_examples shared_examples_for].freeze - def on_top_level_describe(node, args) + def on_top_level_example_group(node) return if acceptable_file_path?(processed_source.buffer.name) - return if shared_example?(node) - add_offense(node, message: MESSAGE) + add_offense(node.send_node, message: MESSAGE) end private @@ -23,12 +22,6 @@ module RuboCop def acceptable_file_path?(path) File.fnmatch?('*_spec.rb', path) || File.fnmatch?('*/frontend/fixtures/*', path) || File.fnmatch?('*/docs_screenshots/*_docs.rb', path) end - - def shared_example?(node) - node.ancestors.any? do |node| - node.respond_to?(:method_name) && SHARED_EXAMPLES.include?(node.method_name) - end - end end end end diff --git a/rubocop/cop/rspec/web_mock_enable.rb b/rubocop/cop/rspec/web_mock_enable.rb index 0bef16a16b0..395375e5fc1 100644 --- a/rubocop/cop/rspec/web_mock_enable.rb +++ b/rubocop/cop/rspec/web_mock_enable.rb @@ -1,5 +1,7 @@ # frozen_string_literal: true +require 'rubocop-rspec' + module RuboCop module Cop module RSpec diff --git a/scripts/rubocop-max-files-in-cache-check b/scripts/rubocop-max-files-in-cache-check index 5b422d0a0f4..34caa0e197c 100755 --- a/scripts/rubocop-max-files-in-cache-check +++ b/scripts/rubocop-max-files-in-cache-check @@ -1,7 +1,8 @@ #!/usr/bin/env ruby # frozen_string_literal: true -require 'yaml' +require_relative '../config/bundler_setup' +require 'rubocop' MINIMUM_MAX_FILES_IN_CACHE_MARGIN = 1.05 RECOMMENDED_MAX_FILES_IN_CACHE_MARGIN = 1.25 @@ -14,7 +15,7 @@ rubocop_target_files_count = `#{RUBOCOP_LIST_TARGET_FILES_COMMAND}`.strip.to_i raise Error, "#{RUBOCOP_LIST_TARGET_FILES_COMMAND} failed with status #{$?}!" if rubocop_target_files_count == 0 rubocop_target_files_count = rubocop_target_files_count.to_i -rubocop_current_max_files_in_cache = YAML.load_file(File.expand_path('../.rubocop.yml', __dir__)).dig('AllCops', 'MaxFilesInCache').to_i +rubocop_current_max_files_in_cache = RuboCop::ConfigLoader.load_yaml_configuration(File.expand_path('../.rubocop.yml', __dir__)).dig('AllCops', 'MaxFilesInCache').to_i minimum_max_files_in_cache = (rubocop_target_files_count * MINIMUM_MAX_FILES_IN_CACHE_MARGIN).round(-3) # We want AllCops.MaxFilesInCache to be at least 5% above the actual files count at any time to give us enough time to increase it accordingly diff --git a/spec/factories/events.rb b/spec/factories/events.rb index 403165a3935..768ce30b694 100644 --- a/spec/factories/events.rb +++ b/spec/factories/events.rb @@ -26,10 +26,10 @@ FactoryBot.define do factory :wiki_page_event do action { :created } - # rubocop: disable FactoryBot/InlineAssociation + # rubocop: disable RSpec/FactoryBot/InlineAssociation # A persistent project is needed to have a wiki page being created properly. project { @overrides[:wiki_page]&.container || create(:project, :wiki_repo) } - # rubocop: enable FactoryBot/InlineAssociation + # rubocop: enable RSpec/FactoryBot/InlineAssociation target { association(:wiki_page_meta, :for_wiki_page, wiki_page: wiki_page) } transient do diff --git a/spec/factories/go_module_commits.rb b/spec/factories/go_module_commits.rb index 4f86d38954c..44f4ce9ea31 100644 --- a/spec/factories/go_module_commits.rb +++ b/spec/factories/go_module_commits.rb @@ -7,12 +7,12 @@ FactoryBot.define do transient do files { { 'foo.txt' => 'content' } } message { 'Message' } - # rubocop: disable FactoryBot/InlineAssociation + # rubocop: disable RSpec/FactoryBot/InlineAssociation # We need a persisted project so we can create commits and tags # in `commit` otherwise linting this factory with `build` strategy # will fail. project { create(:project, :repository) } - # rubocop: enable FactoryBot/InlineAssociation + # rubocop: enable RSpec/FactoryBot/InlineAssociation service do Files::MultiService.new( diff --git a/spec/factories/packages/packages.rb b/spec/factories/packages/packages.rb index 8074e505243..1da4f0cedbc 100644 --- a/spec/factories/packages/packages.rb +++ b/spec/factories/packages/packages.rb @@ -253,7 +253,7 @@ FactoryBot.define do end trait(:without_loaded_metadatum) do - conan_metadatum { build(:conan_metadatum, package: nil) } # rubocop:disable FactoryBot/InlineAssociation + conan_metadatum { build(:conan_metadatum, package: nil) } # rubocop:disable RSpec/FactoryBot/InlineAssociation end end diff --git a/spec/lib/gitlab/ci/config/entry/legacy_variables_spec.rb b/spec/lib/gitlab/ci/config/entry/legacy_variables_spec.rb deleted file mode 100644 index e9edec9a0a4..00000000000 --- a/spec/lib/gitlab/ci/config/entry/legacy_variables_spec.rb +++ /dev/null @@ -1,173 +0,0 @@ -# frozen_string_literal: true - -require 'spec_helper' - -RSpec.describe Gitlab::Ci::Config::Entry::LegacyVariables do - let(:config) { {} } - let(:metadata) { {} } - - subject(:entry) { described_class.new(config, **metadata) } - - before do - entry.compose! - end - - shared_examples 'valid config' do - describe '#value' do - it 'returns hash with key value strings' do - expect(entry.value).to eq result - end - end - - describe '#errors' do - it 'does not append errors' do - expect(entry.errors).to be_empty - end - end - - describe '#valid?' do - it 'is valid' do - expect(entry).to be_valid - end - end - end - - shared_examples 'invalid config' do |error_message| - describe '#valid?' do - it 'is not valid' do - expect(entry).not_to be_valid - end - end - - describe '#errors' do - it 'saves errors' do - expect(entry.errors) - .to include(error_message) - end - end - end - - context 'when entry config value has key-value pairs' do - let(:config) do - { 'VARIABLE_1' => 'value 1', 'VARIABLE_2' => 'value 2' } - end - - let(:result) do - { 'VARIABLE_1' => 'value 1', 'VARIABLE_2' => 'value 2' } - end - - it_behaves_like 'valid config' - - describe '#value_with_data' do - it 'returns variable with data' do - expect(entry.value_with_data).to eq( - 'VARIABLE_1' => { value: 'value 1' }, - 'VARIABLE_2' => { value: 'value 2' } - ) - end - end - end - - context 'with numeric keys and values in the config' do - let(:config) { { 10 => 20 } } - let(:result) do - { '10' => '20' } - end - - it_behaves_like 'valid config' - end - - context 'when key is an array' do - let(:config) { { ['VAR1'] => 'val1' } } - let(:result) do - { 'VAR1' => 'val1' } - end - - it_behaves_like 'invalid config', /should be a hash of key value pairs/ - end - - context 'when value is a symbol' do - let(:config) { { 'VAR1' => :val1 } } - let(:result) do - { 'VAR1' => 'val1' } - end - - it_behaves_like 'valid config' - end - - context 'when value is a boolean' do - let(:config) { { 'VAR1' => true } } - let(:result) do - { 'VAR1' => 'val1' } - end - - it_behaves_like 'invalid config', /should be a hash of key value pairs/ - end - - context 'when entry config value has key-value pair and hash' do - let(:config) do - { 'VARIABLE_1' => { value: 'value 1', description: 'variable 1' }, - 'VARIABLE_2' => 'value 2' } - end - - it_behaves_like 'invalid config', /should be a hash of key value pairs/ - - context 'when metadata has use_value_data: true' do - let(:metadata) { { use_value_data: true } } - - let(:result) do - { 'VARIABLE_1' => 'value 1', 'VARIABLE_2' => 'value 2' } - end - - it_behaves_like 'valid config' - - describe '#value_with_data' do - it 'returns variable with data' do - expect(entry.value_with_data).to eq( - 'VARIABLE_1' => { value: 'value 1', description: 'variable 1' }, - 'VARIABLE_2' => { value: 'value 2' } - ) - end - end - end - end - - context 'when entry value is an array' do - let(:config) { [:VAR, 'test'] } - - it_behaves_like 'invalid config', /should be a hash of key value pairs/ - end - - context 'when metadata has use_value_data: true' do - let(:metadata) { { use_value_data: true } } - - context 'when entry value has hash with other key-pairs' do - let(:config) do - { 'VARIABLE_1' => { value: 'value 1', hello: 'variable 1' }, - 'VARIABLE_2' => 'value 2' } - end - - it_behaves_like 'invalid config', /should be a hash of key value pairs, value can be a hash/ - end - - context 'when entry config value has hash with nil description' do - let(:config) do - { 'VARIABLE_1' => { value: 'value 1', description: nil } } - end - - it_behaves_like 'invalid config', /should be a hash of key value pairs, value can be a hash/ - end - - context 'when entry config value has hash without description' do - let(:config) do - { 'VARIABLE_1' => { value: 'value 1' } } - end - - let(:result) do - { 'VARIABLE_1' => 'value 1' } - end - - it_behaves_like 'valid config' - end - end -end diff --git a/spec/lib/gitlab/ci/config/entry/processable_spec.rb b/spec/lib/gitlab/ci/config/entry/processable_spec.rb index 5f42a8c49a7..ad90dd59585 100644 --- a/spec/lib/gitlab/ci/config/entry/processable_spec.rb +++ b/spec/lib/gitlab/ci/config/entry/processable_spec.rb @@ -210,20 +210,6 @@ RSpec.describe Gitlab::Ci::Config::Entry::Processable do expect(entry.errors) .to include 'variables:var2 config must be a string' end - - context 'when the FF ci_variables_refactoring_to_variable is disabled' do - let(:entry_without_ff) { node_class.new(config, name: :rspec) } - - before do - stub_feature_flags(ci_variables_refactoring_to_variable: false) - entry_without_ff.compose! - end - - it 'reports error about variable' do - expect(entry_without_ff.errors) - .to include /config should be a hash of key value pairs/ - end - end end end end diff --git a/spec/lib/gitlab/ci/config/entry/root_spec.rb b/spec/lib/gitlab/ci/config/entry/root_spec.rb index 3d19987a0be..64438a1594a 100644 --- a/spec/lib/gitlab/ci/config/entry/root_spec.rb +++ b/spec/lib/gitlab/ci/config/entry/root_spec.rb @@ -361,20 +361,6 @@ RSpec.describe Gitlab::Ci::Config::Entry::Root do expect(root.errors) .to include /var1 config uses invalid data keys: invalid/ end - - context 'when the FF ci_variables_refactoring_to_variable is disabled' do - let(:root_without_ff) { described_class.new(hash, user: user, project: project) } - - before do - stub_feature_flags(ci_variables_refactoring_to_variable: false) - root_without_ff.compose! - end - - it 'reports errors about the invalid variable' do - expect(root_without_ff.errors) - .to include /variables config should be a hash of key value pairs, value can be a hash/ - end - end end end end diff --git a/spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb b/spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb index 303d825c591..3531d6e9f1a 100644 --- a/spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb +++ b/spec/lib/gitlab/ci/config/entry/rules/rule_spec.rb @@ -364,19 +364,6 @@ RSpec.describe Gitlab::Ci::Config::Entry::Rules::Rule do it 'returns an error about invalid variables:' do expect(subject.errors).to include(/variables config should be a hash/) end - - context 'when the FF ci_variables_refactoring_to_variable is disabled' do - let(:entry_without_ff) { factory.create! } - - before do - stub_feature_flags(ci_variables_refactoring_to_variable: false) - entry_without_ff.compose! - end - - it 'returns an error about invalid variables:' do - expect(subject.errors).to include(/variables config should be a hash/) - end - end end end diff --git a/spec/lib/gitlab/ci/pipeline/chain/limit/active_jobs_spec.rb b/spec/lib/gitlab/ci/pipeline/chain/limit/active_jobs_spec.rb new file mode 100644 index 00000000000..9587d6d4e23 --- /dev/null +++ b/spec/lib/gitlab/ci/pipeline/chain/limit/active_jobs_spec.rb @@ -0,0 +1,99 @@ +# frozen_string_literal: true + +require 'spec_helper' + +RSpec.describe ::Gitlab::Ci::Pipeline::Chain::Limit::ActiveJobs do + let_it_be(:namespace) { create(:namespace) } + let_it_be(:project) { create(:project, namespace: namespace) } + let_it_be(:user) { create(:user) } + let_it_be(:default_plan) { create(:default_plan) } + + let(:command) do + instance_double( + ::Gitlab::Ci::Pipeline::Chain::Command, + project: project, + current_user: user, + limit_active_jobs_early?: feature_flag_enabled, + save_incompleted: true, + pipeline_seed: pipeline_seed_double + ) + end + + let(:pipeline_seed_double) do + instance_double(::Gitlab::Ci::Pipeline::Seed::Pipeline, size: 5) + end + + let(:pipeline) do + create(:ci_pipeline, project: project) + end + + let(:existing_pipeline) { create(:ci_pipeline, project: project) } + let(:step) { described_class.new(pipeline, command) } + let(:feature_flag_enabled) { true } + let(:limit) { 10 } + + subject { step.perform! } + + before do + create(:plan_limits, plan: default_plan, ci_active_jobs: limit) + namespace.clear_memoization(:actual_plan) + end + + shared_examples 'successful step' do + it 'doest not fail the pipeline and does not interrupt the chain' do + subject + + expect(pipeline).not_to be_failed + expect(step).not_to be_break + end + end + + context 'when active jobs limit is exceeded' do + before do + create_list(:ci_build, 3, pipeline: existing_pipeline) + create_list(:ci_bridge, 3, pipeline: existing_pipeline) + end + + it 'fails the pipeline with an error', :aggregate_failures do + subject + + expect(pipeline).to be_failed + expect(pipeline).to be_job_activity_limit_exceeded + expect(pipeline.errors.full_messages).to include(described_class::MESSAGE) + end + + it 'logs the failure' do + allow(Gitlab::AppLogger).to receive(:info) + + subject + + expect(Gitlab::AppLogger).to have_received(:info).with( + class: described_class.name, + message: described_class::MESSAGE, + project_id: project.id, + plan: default_plan.name + ) + end + + it 'breaks the chain' do + subject + + expect(step).to be_break + end + + context 'when active jobs limit not enabled' do + let(:limit) { 0 } + + it_behaves_like 'successful step' + end + end + + context 'when active jobs limit is not exceeded' do + before do + create_list(:ci_build, 3, pipeline: existing_pipeline) + create_list(:ci_bridge, 1, pipeline: existing_pipeline) + end + + it_behaves_like 'successful step' + end +end diff --git a/spec/lib/gitlab/ci/yaml_processor_spec.rb b/spec/lib/gitlab/ci/yaml_processor_spec.rb index cc327f5b5f1..b710ee092ec 100644 --- a/spec/lib/gitlab/ci/yaml_processor_spec.rb +++ b/spec/lib/gitlab/ci/yaml_processor_spec.rb @@ -1033,8 +1033,7 @@ module Gitlab end end - # Change this to a `describe` block when removing the FF ci_variables_refactoring_to_variable - shared_examples 'Variables' do + describe 'Variables' do subject(:execute) { described_class.new(config).execute } let(:build) { execute.builds.first } @@ -1163,18 +1162,6 @@ module Gitlab end end - context 'when ci_variables_refactoring_to_variable is enabled' do - it_behaves_like 'Variables' - end - - context 'when ci_variables_refactoring_to_variable is disabled' do - before do - stub_feature_flags(ci_variables_refactoring_to_variable: false) - end - - it_behaves_like 'Variables' - end - context 'when using `extends`' do let(:config_processor) { Gitlab::Ci::YamlProcessor.new(config).execute } diff --git a/spec/lib/gitlab/web_ide/config/entry/terminal_spec.rb b/spec/lib/gitlab/web_ide/config/entry/terminal_spec.rb index 8d4629bf48b..7d96adf95e8 100644 --- a/spec/lib/gitlab/web_ide/config/entry/terminal_spec.rb +++ b/spec/lib/gitlab/web_ide/config/entry/terminal_spec.rb @@ -150,29 +150,6 @@ RSpec.describe Gitlab::WebIde::Config::Entry::Terminal do } ) end - - context 'when the FF ci_variables_refactoring_to_variable is disabled' do - let(:entry_without_ff) { described_class.new(config, with_image_ports: true) } - - before do - stub_feature_flags(ci_variables_refactoring_to_variable: false) - entry_without_ff.compose! - end - - it 'returns correct value' do - expect(entry_without_ff.value) - .to eq( - tag_list: ['webide'], - job_variables: [{ key: 'KEY', value: 'value', public: true }], - options: { - image: { name: "image:1.0" }, - services: [{ name: "mysql" }], - before_script: %w[ls pwd], - script: ['sleep 100'] - } - ) - end - end end end end diff --git a/spec/rubocop/cop/gitlab/duplicate_spec_location_spec.rb b/spec/rubocop/cop/gitlab/duplicate_spec_location_spec.rb index 9a1639806c8..0a121a495c9 100644 --- a/spec/rubocop/cop/gitlab/duplicate_spec_location_spec.rb +++ b/spec/rubocop/cop/gitlab/duplicate_spec_location_spec.rb @@ -4,7 +4,7 @@ require 'rubocop_spec_helper' require_relative '../../../../rubocop/cop/gitlab/duplicate_spec_location' -RSpec.describe RuboCop::Cop::Gitlab::DuplicateSpecLocation do +RSpec.describe RuboCop::Cop::Gitlab::DuplicateSpecLocation, type: :rubocop_rspec do let(:rails_root) { '../../../../' } def full_path(path) diff --git a/spec/rubocop/cop/rspec/top_level_describe_path_spec.rb b/spec/rubocop/cop/rspec/top_level_describe_path_spec.rb index 90101e09023..6c596210f4e 100644 --- a/spec/rubocop/cop/rspec/top_level_describe_path_spec.rb +++ b/spec/rubocop/cop/rspec/top_level_describe_path_spec.rb @@ -22,6 +22,19 @@ RSpec.describe RuboCop::Cop::RSpec::TopLevelDescribePath do end end + context 'when the describe is in a shared context' do + context 'with shared_context' do + it 'registers no offenses' do + expect_no_offenses(<<~SOURCE, 'spec/foo.rb') + shared_context 'Foo' do + describe '#bar' do + end + end + SOURCE + end + end + end + context 'when the describe is in a shared example' do context 'with shared_examples' do it 'registers no offenses' do diff --git a/spec/rubocop/formatter/graceful_formatter_spec.rb b/spec/rubocop/formatter/graceful_formatter_spec.rb index 0e0c1d52067..1ed8533ac16 100644 --- a/spec/rubocop/formatter/graceful_formatter_spec.rb +++ b/spec/rubocop/formatter/graceful_formatter_spec.rb @@ -2,7 +2,8 @@ require 'fast_spec_helper' require 'rspec-parameterized' -require 'rubocop/rspec/shared_contexts' +require 'rubocop' +require 'rubocop/rspec/support' require 'stringio' require_relative '../../../rubocop/formatter/graceful_formatter' @@ -225,14 +226,14 @@ RSpec.describe RuboCop::Formatter::GracefulFormatter, :isolated_environment do cop_name: cop_name, corrected?: false, correctable?: false, - severity: double(:severity, name: 'convention', code: :C), + severity: double(:severity, name: :convention, code: :C), line: 5, column: 23, real_column: 23, corrected_with_todo?: false, message: "#{cop_name} message", - location: double(:location, source_line: 'line', first_line: 1, last_line: 2), - highlighted_area: double(:highlighted_area, begin_pos: 1, size: 2) + location: double(:location, source_line: 'line', first_line: 1, last_line: 1, single_line?: true), + highlighted_area: double(:highlighted_area, begin_pos: 1, size: 2, source_buffer: 'line', source: 'i') ) # rubocop:enable RSpec/VerifiedDoubles end diff --git a/spec/rubocop_spec_helper.rb b/spec/rubocop_spec_helper.rb index a37415a25de..cf747132ec1 100644 --- a/spec/rubocop_spec_helper.rb +++ b/spec/rubocop_spec_helper.rb @@ -8,13 +8,23 @@ require 'fast_spec_helper' require 'rubocop' require 'rubocop/rspec/support' -RSpec.configure do |config| - config.include RuboCop::RSpec::ExpectOffense, type: :rubocop +require_relative './support/shared_contexts/rubocop_default_rspec_language_config_context' +RSpec.configure do |config| config.define_derived_metadata(file_path: %r{spec/rubocop}) do |metadata| - metadata[:type] = :rubocop + # TODO: move DuplicateSpecLocation cop to RSpec::DuplicateSpecLocation + unless metadata[:type] == :rubocop_rspec + metadata[:type] = :rubocop + end end - # Include config shared context for all cop specs. + config.define_derived_metadata(file_path: %r{spec/rubocop/cop/rspec}) do |metadata| + metadata[:type] = :rubocop_rspec + end + + config.include RuboCop::RSpec::ExpectOffense, type: :rubocop + config.include RuboCop::RSpec::ExpectOffense, type: :rubocop_rspec + config.include_context 'config', type: :rubocop + config.include_context 'with default RSpec/Language config', type: :rubocop_rspec end diff --git a/spec/services/ci/create_pipeline_service/limit_active_jobs_spec.rb b/spec/services/ci/create_pipeline_service/limit_active_jobs_spec.rb new file mode 100644 index 00000000000..003d109a27c --- /dev/null +++ b/spec/services/ci/create_pipeline_service/limit_active_jobs_spec.rb @@ -0,0 +1,53 @@ +# frozen_string_literal: true +require 'spec_helper' + +RSpec.describe Ci::CreatePipelineService, :yaml_processor_feature_flag_corectness do + let_it_be(:project) { create(:project, :repository) } + let_it_be(:user) { project.first_owner } + let_it_be(:existing_pipeline) { create(:ci_pipeline, project: project) } + + let(:service) { described_class.new(project, user, ref: 'refs/heads/master') } + + subject(:pipeline) { service.execute(:push).payload } + + before do + create_list(:ci_build, 8, pipeline: existing_pipeline) + create_list(:ci_bridge, 1, pipeline: existing_pipeline) + + stub_ci_pipeline_yaml_file(<<~YAML) + job1: + script: echo + job3: + trigger: + project: org/my-project + job4: + script: echo + only: [tags] + YAML + end + + context 'when project has exceeded the active jobs limit' do + before do + project.namespace.actual_limits.update!(ci_active_jobs: 10) + end + + it 'fails the pipeline before populating it' do + expect(pipeline).to be_failed + expect(pipeline).to be_job_activity_limit_exceeded + + expect(pipeline.errors.full_messages) + .to include("Project exceeded the allowed number of jobs in active pipelines. Retry later.") + expect(pipeline.statuses).to be_empty + end + end + + context 'when project has not exceeded the active jobs limit' do + before do + project.namespace.actual_limits.update!(ci_active_jobs: 20) + end + + it 'creates the pipeline successfully' do + expect(pipeline).to be_created + end + end +end diff --git a/spec/support/shared_contexts/rubocop_default_rspec_language_config_context.rb b/spec/support/shared_contexts/rubocop_default_rspec_language_config_context.rb new file mode 100644 index 00000000000..a207c6ae9d1 --- /dev/null +++ b/spec/support/shared_contexts/rubocop_default_rspec_language_config_context.rb @@ -0,0 +1,32 @@ +# frozen_string_literal: true + +# From https://github.com/rubocop/rubocop-rspec/blob/master/spec/shared/default_rspec_language_config_context.rb +# This can be removed once we have https://github.com/rubocop/rubocop-rspec/pull/1377 + +RSpec.shared_context 'with default RSpec/Language config' do + include_context 'config' + + # Deep duplication is needed to prevent config leakage between examples + let(:other_cops) do + default_language = RuboCop::ConfigLoader + .default_configuration['RSpec']['Language'] + default_include = RuboCop::ConfigLoader + .default_configuration['RSpec']['Include'] + { 'RSpec' => + { + 'Include' => default_include, + 'Language' => deep_dup(default_language) + } } + end + + def deep_dup(object) + case object + when Array + object.map { |item| deep_dup(item) } + when Hash + object.transform_values { |value| deep_dup(value) } + else + object # only collections undergo modifications and need duping + end + end +end diff --git a/workhorse/go.mod b/workhorse/go.mod index 500753bbf97..768dc1a4e59 100644 --- a/workhorse/go.mod +++ b/workhorse/go.mod @@ -5,7 +5,7 @@ go 1.17 require ( github.com/Azure/azure-storage-blob-go v0.14.0 github.com/BurntSushi/toml v1.2.0 - github.com/FZambia/sentinel v1.1.0 + github.com/FZambia/sentinel v1.1.1 github.com/alecthomas/chroma/v2 v2.2.0 github.com/aws/aws-sdk-go v1.43.31 github.com/disintegration/imaging v1.6.2 diff --git a/workhorse/go.sum b/workhorse/go.sum index 30c7fec32d2..994d002e2e7 100644 --- a/workhorse/go.sum +++ b/workhorse/go.sum @@ -134,8 +134,8 @@ github.com/DataDog/datadog-go v4.4.0+incompatible/go.mod h1:LButxg5PwREeZtORoXG3 github.com/DataDog/gostackparse v0.5.0/go.mod h1:lTfqcJKqS9KnXQGnyQMCugq3u1FP6UZMfWR0aitKFMM= github.com/DataDog/sketches-go v1.0.0 h1:chm5KSXO7kO+ywGWJ0Zs6tdmWU8PBXSbywFVciL6BG4= github.com/DataDog/sketches-go v1.0.0/go.mod h1:O+XkJHWk9w4hDwY2ZUDU31ZC9sNYlYo8DiFsxjYeo1k= -github.com/FZambia/sentinel v1.1.0 h1:qrCBfxc8SvJihYNjBWgwUI93ZCvFe/PJIPTHKmlp8a8= -github.com/FZambia/sentinel v1.1.0/go.mod h1:ytL1Am/RLlAoAXG6Kj5LNuw/TRRQrv2rt2FT26vP5gI= +github.com/FZambia/sentinel v1.1.1 h1:0ovTimlR7Ldm+wR15GgO+8C2dt7kkn+tm3PQS+Qk3Ek= +github.com/FZambia/sentinel v1.1.1/go.mod h1:ytL1Am/RLlAoAXG6Kj5LNuw/TRRQrv2rt2FT26vP5gI= github.com/GoogleCloudPlatform/cloudsql-proxy v1.29.0/go.mod h1:spvB9eLJH9dutlbPSRmHvSXXHOwGRyeXh1jVdquA2G8= github.com/HdrHistogram/hdrhistogram-go v1.1.1 h1:cJXY5VLMHgejurPjZH6Fo9rIwRGLefBGdiaENZALqrg= github.com/HdrHistogram/hdrhistogram-go v1.1.1/go.mod h1:yDgFjdqOqDEKOvasDdhWNXYg9BVp4O+o5f6V/ehm6Oo=